The 0.93 spec has this implementation for add.uw
uint_xlen_t adduw(uint_xlen_t rs1, uint_xlen_t rs2) {
uint_xlen_t rs1u = (uint32_t)rs1; return rs1u + rs2;
}
The 0.92 spec had the usages of rs1 and rs2 swapped.
Paths
| Differential D95090
[RISCV] Modify add.uw patterns to put the masked operand in rs1 to match 0.93 bitmanip spec. ClosedPublic Authored by craig.topper on Jan 20 2021, 2:05 PM.
Details Summary The 0.93 spec has this implementation for add.uw uint_xlen_t adduw(uint_xlen_t rs1, uint_xlen_t rs2) { uint_xlen_t rs1u = (uint32_t)rs1; return rs1u + rs2; } The 0.92 spec had the usages of rs1 and rs2 swapped.
Diff Detail
Unit TestsFailed Event TimelineHerald added subscribers: NickHung, evandro, apazos and 21 others. · View Herald TranscriptJan 20 2021, 2:05 PM This revision is now accepted and ready to land.Jan 21 2021, 3:52 AM Closed by commit rG9d499e037e6b: [RISCV] Modify add.uw patterns to put the masked operand in rs1 to match 0.93… (authored by craig.topper). · Explain WhyJan 22 2021, 12:51 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 318002 llvm/lib/Target/RISCV/RISCVInstrInfoB.td
llvm/test/CodeGen/RISCV/rv64Zba.ll
|