Also renamed Zbe instructions to resolve name conflict even though
that change is in the 0.94 draft.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
What are the implications of having the renamed Zbe instructions in what we'll advertise as 0.93?
Comment Actions
I'm not sure. It doesn't look like binutils implements Zbe instructions yet so there's no other precedent for handling this conflict.
Comment Actions
LGTM, going with the 0.94 deconflicted naming seems the only reasonable thing to do https://github.com/riscv/riscv-bitmanip/pull/102/commits/b962f8a04be570a93c3c4788425ee2e8a14e9c56
llvm/lib/Target/RISCV/RISCVInstrInfoB.td | ||
---|---|---|
357–358 | It might be worth adding a comment here and for the W variants just to document that these have been renamed to match the v0.94 due to the name conflict in 0.93. |
It might be worth adding a comment here and for the W variants just to document that these have been renamed to match the v0.94 due to the name conflict in 0.93.