When building builtins separately as part of the runtime build, we
also want to include crt. To enable that, enable building builtins
together with crt using the top-level CMake file with a new option
I think this is an improvement, it was awkward to have two top-level entry points to the cmake anyway. This probably allows for some further de-duplication down the road as well.
It would be nice to print the list of supported crt arch here as well.
OS_NAME doesn't currently get set in builtin-config-ix, we'll need to duplicate the setup from config-ix.
We probably should retain the new cmake minimum
We should probably disable the crt build here now.
Ditto the other comment
LGTM, with slight adjustment. Though I will note that this requires a clean build because CMake will complain about the change in source directory in cache:
CMake Error: The source “../compiler-rt/CMakeLists.txt" does not match the source ../compiler-rt/lib/builtins/CMakeLists.txt" used to generate cache. Re-run cmake with a different source directory.
fyi, this needs a slight adjustments because D87120 has landed
The problem we have here is that the scope for these variables has changed, builtin-config-ix.cmake is only included in the builtins CMakeList.tx, so when we go to check COMPILER_RT_HAS_CRT it's out of scope.
Perhaps it would be cleaner to split the CRT checks into it's own crt-config-ix.cmake that can be included at the appropriate scope?