Page MenuHomePhabricator

Chia-hungDuan (Chia-hung Duan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 21 2021, 11:40 PM (60 w, 5 d)

Recent Activity

Tue, May 10

Chia-hungDuan committed rG96e642652b9b: [mlir] Print some message for op-printing verification (authored by Chia-hungDuan).
[mlir] Print some message for op-printing verification
Tue, May 10, 3:56 PM · Restricted Project, Restricted Project
Chia-hungDuan closed D125136: [mlir] Print some message for op-printing verification.
Tue, May 10, 3:56 PM · Restricted Project, Restricted Project
Chia-hungDuan updated the diff for D125136: [mlir] Print some message for op-printing verification.

Address review comment

Tue, May 10, 2:52 PM · Restricted Project, Restricted Project

Fri, May 6

Chia-hungDuan updated the diff for D125136: [mlir] Print some message for op-printing verification.

Address review comment

Fri, May 6, 3:57 PM · Restricted Project, Restricted Project
Chia-hungDuan added inline comments to D125136: [mlir] Print some message for op-printing verification.
Fri, May 6, 3:24 PM · Restricted Project, Restricted Project
Chia-hungDuan requested review of D125136: [mlir] Print some message for op-printing verification.
Fri, May 6, 3:04 PM · Restricted Project, Restricted Project

Apr 14 2022

Chia-hungDuan committed rG5232c5c5d414: [mlir] Fix verification order of nested ops. (authored by Chia-hungDuan).
[mlir] Fix verification order of nested ops.
Apr 14 2022, 9:43 PM · Restricted Project, Restricted Project
Chia-hungDuan closed D122771: [mlir] Fix verification order of nested ops..
Apr 14 2022, 9:43 PM · Restricted Project, Restricted Project
Chia-hungDuan updated the diff for D122771: [mlir] Fix verification order of nested ops..

Rebase

Apr 14 2022, 9:40 PM · Restricted Project, Restricted Project
Chia-hungDuan updated the diff for D122771: [mlir] Fix verification order of nested ops..

Address review comments

Apr 14 2022, 9:25 PM · Restricted Project, Restricted Project
Chia-hungDuan added inline comments to D122771: [mlir] Fix verification order of nested ops..
Apr 14 2022, 9:12 PM · Restricted Project, Restricted Project
Chia-hungDuan added a comment to D122771: [mlir] Fix verification order of nested ops..

@rriddle, a gentle ping, what do you think about the tests?

Apr 14 2022, 10:26 AM · Restricted Project, Restricted Project

Apr 8 2022

Chia-hungDuan updated the diff for D122771: [mlir] Fix verification order of nested ops..

Add test cases

Apr 8 2022, 12:19 PM · Restricted Project, Restricted Project

Mar 31 2022

Chia-hungDuan added a comment to D122692: [GreedPatternRewriter] Preprocess constants while building worklist when not processing top down.

So there are at least 2 significant changes to behaviour

  1. The folder actually sorts commutative ops, but this doesn't trigger the greedy rewriter to run another iteration because tryToFold might still return failure. If -my-pass only has one pattern commutative(a, b) -> foo but the input IR is commutative(b, a), the pattern doesn't match because the folder will re-order the operands but the rewriter will exit.

Was this kind of awkwardly relying on the fact that we always did 2 iterations (given that we refolded existing constants)?

And one of a or b were constant? Then isn't this expected to work? E.g., the constant operand is flipped before pattern matching is attempted?

Mar 31 2022, 9:52 PM · Restricted Project, Restricted Project, Restricted Project

Mar 30 2022

Chia-hungDuan requested review of D122771: [mlir] Fix verification order of nested ops..
Mar 30 2022, 5:03 PM · Restricted Project, Restricted Project

Mar 25 2022

Chia-hungDuan committed rGdda003afa643: [mlir] Add InferTensorType without supporting reifyReturnTypeShapes (authored by Chia-hungDuan).
[mlir] Add InferTensorType without supporting reifyReturnTypeShapes
Mar 25 2022, 12:08 PM · Restricted Project, Restricted Project
Chia-hungDuan closed D121403: [mlir] Add InferTensorType without supporting reifyReturnTypeShapes.
Mar 25 2022, 12:08 PM · Restricted Project, Restricted Project
Chia-hungDuan added a comment to D121403: [mlir] Add InferTensorType without supporting reifyReturnTypeShapes.

SG, one could also just do InferTensorType<> previously I believe where this would allow InferTensorType without <>.

I actually wonder if the above needs the extra .traits, may have been a point in time, I'd expect

def InferTensorTypeWithReify : InferTensorTypeBase<"reifyReturnTypeShapes">;

to be sufficient.

Mar 25 2022, 11:45 AM · Restricted Project, Restricted Project
Chia-hungDuan updated the diff for D121403: [mlir] Add InferTensorType without supporting reifyReturnTypeShapes.

Rebase and address review comment

Mar 25 2022, 11:45 AM · Restricted Project, Restricted Project

Mar 23 2022

Chia-hungDuan committed rG14ecafd0bdc2: [mlir] Make OpBuilder::createOperation to accept raw inputs (authored by Chia-hungDuan).
[mlir] Make OpBuilder::createOperation to accept raw inputs
Mar 23 2022, 3:17 PM · Restricted Project
Chia-hungDuan closed D120787: [mlir] Make OpBuilder::createOperation to accept raw inputs.
Mar 23 2022, 3:17 PM · Restricted Project, Restricted Project
Chia-hungDuan updated the diff for D120787: [mlir] Make OpBuilder::createOperation to accept raw inputs.

Rebase

Mar 23 2022, 3:16 PM · Restricted Project, Restricted Project

Mar 10 2022

Chia-hungDuan committed rGed645f63362e: [mlir] Support verification order (3/3) (authored by Chia-hungDuan).
[mlir] Support verification order (3/3)
Mar 10 2022, 5:20 PM · Restricted Project
Chia-hungDuan closed D120373: [mlir] Support verification order (3/3).
Mar 10 2022, 5:20 PM · Restricted Project, Restricted Project
Chia-hungDuan added inline comments to D120373: [mlir] Support verification order (3/3).
Mar 10 2022, 2:10 PM · Restricted Project, Restricted Project
Chia-hungDuan updated the diff for D120373: [mlir] Support verification order (3/3).

Address review comment

Mar 10 2022, 2:10 PM · Restricted Project, Restricted Project
Chia-hungDuan added a comment to D120787: [mlir] Make OpBuilder::createOperation to accept raw inputs.

@rriddle, a gentle ping!

Mar 10 2022, 12:22 PM · Restricted Project, Restricted Project
Chia-hungDuan requested review of D121403: [mlir] Add InferTensorType without supporting reifyReturnTypeShapes.
Mar 10 2022, 12:21 PM · Restricted Project, Restricted Project

Mar 9 2022

Chia-hungDuan added inline comments to D120373: [mlir] Support verification order (3/3).
Mar 9 2022, 8:40 PM · Restricted Project, Restricted Project
Chia-hungDuan updated the diff for D120373: [mlir] Support verification order (3/3).

Address review comments and rebase

Mar 9 2022, 8:39 PM · Restricted Project, Restricted Project
Chia-hungDuan retitled D121174: [mlir] Emit Warning diagnostic in generic form from [mlir] Emit Diagnostic in generic form by default to [mlir] Emit Warning diagnostic in generic form.
Mar 9 2022, 2:57 PM · Restricted Project, Restricted Project
Chia-hungDuan updated the diff for D121174: [mlir] Emit Warning diagnostic in generic form.

I was thinking if we should have a flag to say if we're doing verification to
avoid recursion. After going through the discussion in D117834 now I got it.

Mar 9 2022, 2:56 PM · Restricted Project, Restricted Project

Mar 8 2022

Chia-hungDuan committed rGfcd4ee52cd6d: [mlir] Make ShapedTypeComponents contructible from ShapeAdaptor (authored by Chia-hungDuan).
[mlir] Make ShapedTypeComponents contructible from ShapeAdaptor
Mar 8 2022, 7:39 PM · Restricted Project
Chia-hungDuan closed D120845: [mlir] Make ShapedTypeComponents contructible from ShapeAdaptor.
Mar 8 2022, 7:38 PM · Restricted Project, Restricted Project
Chia-hungDuan updated the diff for D120845: [mlir] Make ShapedTypeComponents contructible from ShapeAdaptor.

Rebase and check if the build is still broken

Mar 8 2022, 12:56 PM · Restricted Project, Restricted Project
Chia-hungDuan added a comment to D118683: [MLIR][PDL] Add optional attribute to enable commutativity in PDL.

The implementation of commutative matching is very byte-code heavy but it's effectively just permuting every combination of operands. I think this can be implemented by just generating one pattern for every combination. Commutative patterns for an arbitrary number of operands are undesirable in both cases due to combinatorial explosion... Generally the approach is to have a canonical form for the order of operands. I wonder if this could be implemented generatively by creating patterns that reorder operands to the "canonical" form set by the commutative pattern.

Mar 8 2022, 11:38 AM · Restricted Project, Restricted Project
Chia-hungDuan committed rG60d719b462a1: [mlir] Check nullity of MixedContainerType and TypedArrayAttrBase (authored by Chia-hungDuan).
[mlir] Check nullity of MixedContainerType and TypedArrayAttrBase
Mar 8 2022, 10:19 AM · Restricted Project
Chia-hungDuan closed D121178: [mlir] Check nullity of MixedContainerType and TypedArrayAttrBase.
Mar 8 2022, 10:19 AM · Restricted Project, Restricted Project
Chia-hungDuan added inline comments to D118683: [MLIR][PDL] Add optional attribute to enable commutativity in PDL.
Mar 8 2022, 10:18 AM · Restricted Project, Restricted Project
Chia-hungDuan added a reviewer for D121178: [mlir] Check nullity of MixedContainerType and TypedArrayAttrBase: mehdi_amini.
Mar 8 2022, 9:32 AM · Restricted Project, Restricted Project
Chia-hungDuan updated the summary of D121178: [mlir] Check nullity of MixedContainerType and TypedArrayAttrBase.
Mar 8 2022, 9:29 AM · Restricted Project, Restricted Project
Chia-hungDuan updated the diff for D121178: [mlir] Check nullity of MixedContainerType and TypedArrayAttrBase.

Add descriptions

Mar 8 2022, 9:29 AM · Restricted Project, Restricted Project

Mar 7 2022

Chia-hungDuan requested review of D121178: [mlir] Check nullity of MixedContainerType and TypedArrayAttrBase.
Mar 7 2022, 6:25 PM · Restricted Project, Restricted Project
Chia-hungDuan added a comment to D121174: [mlir] Emit Warning diagnostic in generic form.

Also a small snippet of backtrace,
...

#159 0x00005633c4703828 mlir::Operation::print(llvm::raw_ostream&, mlir::OpPrintingFlags const&) 
#160 0x00005633c4756bba mlir::Diagnostic::appendOp(mlir::Operation&, mlir::OpPrintingFlags const&)
#161 0x00005633c4756a9d mlir::Diagnostic::operator<<(mlir::Operation&) 
#162 0x00005633c47af4ac mlir::Operation::emitWarning(llvm::Twine const&)
#163 0x00005633c1a3e6bb mlir::TF::(anonymous namespace)::VerifyShapeOperandAndResult(mlir::Operation*, mlir::Type, mlir::Type, int) tf_ops_n_z.cc:0:0
#164 0x00005633c1a4f650 mlir::TF::VariableShapeOp::verify() 
#165 0x00005633c1742b09 mlir::Op<mlir::TF::VariableShapeOp, mlir::OpTrait::ZeroRegion, mlir::OpTrait::OneResult, mlir::OpTrait::OneTypedResult<mlir::TensorType>::Impl, mlir::OpTrait::ZeroSuccessor, mlir::OpTrait::OneOperand, mlir::OpTrait::OpInvariants, mlir::DerivedAttributeOpInterface::Trait, mlir::MemoryEffectOpInterface::Trait>::verifyInvariants(mlir::Operation*) 
#166 0x00005633b535dff1 mlir::LogicalResult llvm::detail::UniqueFunctionBase<mlir::LogicalResult, mlir::Operation*>::CallImpl<mlir::LogicalResult (* const)(mlir::Operation*)>(void*, mlir::Operation*)
#167 0x00005633c47cd6ae (anonymous namespace)::OperationVerifier::verifyOperation(mlir::Operation&, llvm::SmallVectorImpl<mlir::Operation*>&) Verifier.cpp:0:0
#168 0x00005633c47cdbff (anonymous namespace)::OperationVerifier::verifyOperation(mlir::Operation&, llvm::SmallVectorImpl<mlir::Operation*>&) Verifier.cpp:0:0
#169 0x00005633c47cdbff (anonymous namespace)::OperationVerifier::verifyOperation(mlir::Operation&, llvm::SmallVectorImpl<mlir::Operation*>&) Verifier.cpp:0:0
#170 0x00005633c47cd0c8 (anonymous namespace)::OperationVerifier::verifyOpAndDominance(mlir::Operation&) Verifier.cpp:0:0
#171 0x00005633c47cd069 mlir::verify(mlir::Operation*)
#172 0x00005633c46fcefe mlir::AsmState::AsmState(mlir::Operation*, mlir::OpPrintingFlags const&, llvm::DenseMap<mlir::Operation*, std::__u::pair<unsigned int, unsigned int>, llvm::DenseMapInfo<mlir::Operation*, void>, llvm::detail::DenseMapPair<mlir::Operation*, std::__u::pair<unsigned int, unsigned int> > >*) 
#173 0x00005633c4703828 mlir::Operation::print(llvm::raw_ostream&, mlir::OpPrintingFlags const&) 
#174 0x00005633c4756bba mlir::Diagnostic::appendOp(mlir::Operation&, mlir::OpPrintingFlags const&) 
#175 0x00005633c4756a9d mlir::Diagnostic::operator<<(mlir::Operation&)
#176 0x00005633c47af4ac mlir::Operation::emitWarning(llvm::Twine const&) 
#177 0x00005633c1a3e6bb mlir::TF::(anonymous namespace)::VerifyShapeOperandAndResult(mlir::Operation*, mlir::Type, mlir::Type, int) tf_ops_n_z.cc:0:0
#178 0x00005633c1a4f650 mlir::TF::VariableShapeOp::verify() 
#179 0x00005633c1742b09 mlir::Op<mlir::TF::VariableShapeOp, mlir::OpTrait::ZeroRegion, mlir::OpTrait::OneResult, mlir::OpTrait::OneTypedResult<mlir::TensorType>::Impl, mlir::OpTrait::ZeroSuccessor, mlir::OpTrait::OneOperand, mlir::OpTrait::OpInvariants, mlir::DerivedAttributeOpInterface::Trait, mlir::MemoryEffectOpInterface::Trait>::verifyInvariants(mlir::Operation*) 
#180 0x00005633b535dff1 mlir::LogicalResult llvm::detail::UniqueFunctionBase<mlir::LogicalResult, mlir::Operation*>::CallImpl<mlir::LogicalResult (* const)(mlir::Operation*)>(void*, mlir::Operation*)
#181 0x00005633c47cd6ae (anonymous namespace)::OperationVerifier::verifyOperation(mlir::Operation&, llvm::SmallVectorImpl<mlir::Operation*>&) Verifier.cpp:0:0
#182 0x00005633c47cdbff (anonymous namespace)::OperationVerifier::verifyOperation(mlir::Operation&, llvm::SmallVectorImpl<mlir::Operation*>&) Verifier.cpp:0:0
#183 0x00005633c47cdbff (anonymous namespace)::OperationVerifier::verifyOperation(mlir::Operation&, llvm::SmallVectorImpl<mlir::Operation*>&) Verifier.cpp:0:0
#184 0x00005633c47cd0c8 (anonymous namespace)::OperationVerifier::verifyOpAndDominance(mlir::Operation&) Verifier.cpp:0:0
#185 0x00005633c47cd069 mlir::verify(mlir::Operation*)
Mar 7 2022, 5:05 PM · Restricted Project, Restricted Project
Chia-hungDuan added a comment to D121174: [mlir] Emit Warning diagnostic in generic form.

The case is here,
https://github.com/tensorflow/tensorflow/blob/fddb6c72caa6a63ec86263a4d4230812c861cd10/tensorflow/compiler/mlir/tensorflow/ir/tf_ops_n_z.cc#L1026

Mar 7 2022, 5:00 PM · Restricted Project, Restricted Project
Chia-hungDuan added a comment to D121174: [mlir] Emit Warning diagnostic in generic form.

Sorry, I'm not following all the discussion in D117834. That CL causes recursively verification in the case that a verifier tries to emitWarning or remark. Any suggestion for the fix?

Mar 7 2022, 4:55 PM · Restricted Project, Restricted Project
Chia-hungDuan requested review of D121174: [mlir] Emit Warning diagnostic in generic form.
Mar 7 2022, 4:53 PM · Restricted Project, Restricted Project

Mar 3 2022

Chia-hungDuan added a comment to D120787: [mlir] Make OpBuilder::createOperation to accept raw inputs.

Also changed the createOperation to create.

Mar 3 2022, 4:59 PM · Restricted Project, Restricted Project
Chia-hungDuan updated the diff for D120787: [mlir] Make OpBuilder::createOperation to accept raw inputs.

Use StringAttr instead and updated some cases to use the create without OperationState

Mar 3 2022, 4:56 PM · Restricted Project, Restricted Project
Chia-hungDuan updated the diff for D120845: [mlir] Make ShapedTypeComponents contructible from ShapeAdaptor.

Added explicit only.

Mar 3 2022, 4:02 PM · Restricted Project, Restricted Project

Mar 2 2022

Chia-hungDuan added a comment to D120787: [mlir] Make OpBuilder::createOperation to accept raw inputs.

A part of me wants to ask what the trade off of this is vs just doing createOperation(OperationState(...))? Well we could also rename createOperation to create(to match the other API), which would make create(OperationState(...)) less redundant to read.

Either way, if we think this is a common enough use case I would be okay with adding the API for it.

OperationState is more like an implementation detail thing and having this makes the preparation of creating operation the same in between registered and unregistered op. I mean, when a user wants to create an unregistered op, they don't need to know there's a OperationState structure to work with. They could have same experience of creating operation. So far, I'm not sure if there's anything bad if we provide this.

I think we can make the createOperation(OperationState) private and having create(...) as public. Or do you think it's better to have both of them for users? I.e., have both create(OperationState) and create(...) in public?

OperationState isn't really just an implementation detail though, given that it is heavily exposed (e.g. all builders use it, parsers use it, etc.).

Mar 2 2022, 9:24 PM · Restricted Project, Restricted Project
Chia-hungDuan added a comment to D120787: [mlir] Make OpBuilder::createOperation to accept raw inputs.

A part of me wants to ask what the trade off of this is vs just doing createOperation(OperationState(...))? Well we could also rename createOperation to create(to match the other API), which would make create(OperationState(...)) less redundant to read.

Either way, if we think this is a common enough use case I would be okay with adding the API for it.

Mar 2 2022, 9:16 PM · Restricted Project, Restricted Project
Chia-hungDuan added inline comments to D120845: [mlir] Make ShapedTypeComponents contructible from ShapeAdaptor.
Mar 2 2022, 9:01 PM · Restricted Project, Restricted Project
Chia-hungDuan added a comment to D120845: [mlir] Make ShapedTypeComponents contructible from ShapeAdaptor.

@jpienaar, this is more like a RFC CL, The target is that I want to avoid certain unexpected thing mentioned in the commit message.

Mar 2 2022, 1:38 PM · Restricted Project, Restricted Project
Chia-hungDuan requested review of D120845: [mlir] Make ShapedTypeComponents contructible from ShapeAdaptor.
Mar 2 2022, 1:35 PM · Restricted Project, Restricted Project

Mar 1 2022

Chia-hungDuan added inline comments to D120787: [mlir] Make OpBuilder::createOperation to accept raw inputs.
Mar 1 2022, 9:35 PM · Restricted Project, Restricted Project
Chia-hungDuan requested review of D120787: [mlir] Make OpBuilder::createOperation to accept raw inputs.
Mar 1 2022, 5:03 PM · Restricted Project, Restricted Project

Feb 28 2022

Chia-hungDuan updated the diff for D120373: [mlir] Support verification order (3/3).

Fix verification label in linalg op interface

Feb 28 2022, 8:44 PM · Restricted Project, Restricted Project
Chia-hungDuan added inline comments to D120373: [mlir] Support verification order (3/3).
Feb 28 2022, 7:05 PM · Restricted Project, Restricted Project
Chia-hungDuan updated the diff for D120373: [mlir] Support verification order (3/3).

Address review comment and quickly went through the verifiers on Ops and updated some of them.

Feb 28 2022, 7:05 PM · Restricted Project, Restricted Project
Chia-hungDuan committed rGd56ef5ed20c5: [mlir-tblgen] Fix non-deterministic generating static verifier in DRR. (authored by Chia-hungDuan).
[mlir-tblgen] Fix non-deterministic generating static verifier in DRR.
Feb 28 2022, 10:41 AM
Chia-hungDuan closed D120514: [mlir-tblgen] Fix non-deterministic generating static verifier in DRR..
Feb 28 2022, 10:41 AM · Restricted Project

Feb 25 2022

Chia-hungDuan abandoned D120588: [mlir] Update description of verification order..

Just saw the comment in D120373, will allow to have both hasVerifier and hasRegionVerifier. Abandon this

Feb 25 2022, 2:22 PM · Restricted Project
Chia-hungDuan requested review of D120588: [mlir] Update description of verification order..
Feb 25 2022, 12:47 PM · Restricted Project
Chia-hungDuan added a comment to D116789: [mlir] Support verification order (2/3).

You hadn't updated the documentation, and our discussion hadn't been resolved. Please refrain from submitting patches that have open discussion.

Feb 25 2022, 12:06 PM · Restricted Project
Chia-hungDuan added a reviewer for D120373: [mlir] Support verification order (3/3): Mogball.
Feb 25 2022, 11:20 AM · Restricted Project, Restricted Project
Chia-hungDuan committed rG9445b39673c8: [mlir] Support verification order (2/3) (authored by Chia-hungDuan).
[mlir] Support verification order (2/3)
Feb 25 2022, 11:09 AM
Chia-hungDuan closed D116789: [mlir] Support verification order (2/3).
Feb 25 2022, 11:09 AM · Restricted Project
Chia-hungDuan added a comment to D116789: [mlir] Support verification order (2/3).

Because there's no major concern in the verification order, I would like to merge this first so that we can have the new test cases written in a way that meet the new verification request.

Feb 25 2022, 10:15 AM · Restricted Project
Chia-hungDuan updated the diff for D116789: [mlir] Support verification order (2/3).

Rebase only

Feb 25 2022, 10:12 AM · Restricted Project

Feb 24 2022

Chia-hungDuan added a comment to D120514: [mlir-tblgen] Fix non-deterministic generating static verifier in DRR..

Thanks for the review. Will wait for @quinnp's verification

Feb 24 2022, 9:22 PM · Restricted Project
Chia-hungDuan updated the diff for D120514: [mlir-tblgen] Fix non-deterministic generating static verifier in DRR..

Address review comment

Feb 24 2022, 9:21 PM · Restricted Project
Chia-hungDuan added reviewers for D120514: [mlir-tblgen] Fix non-deterministic generating static verifier in DRR.: mehdi_amini, quinnp.
Feb 24 2022, 1:19 PM · Restricted Project
Chia-hungDuan requested review of D120514: [mlir-tblgen] Fix non-deterministic generating static verifier in DRR..
Feb 24 2022, 1:15 PM · Restricted Project

Feb 23 2022

Chia-hungDuan added a comment to D110199: Static verifier for type/attribute in DRR.

Thanks, just saw it. I don't quite understand either. Let's move the discussion there

Feb 23 2022, 2:26 PM · Restricted Project
Chia-hungDuan added a comment to D110199: Static verifier for type/attribute in DRR.

Hi @Chia-hungDuan, while doing PowerPC Linux release testing for LLVM 14.0.0-rc1 I encountered some differing object files between Phase2 and Phase3 of the bootstrap build:

# Comparing Phase 2 and Phase 3 files
file ArithmeticOps.cpp.o differs between phase 2 and phase 3
file TestPatterns.cpp.o differs between phase 2 and phase 3

I used git bisect to find that this patch was the first instance of the differing files. We are hoping to fix this for the LLVM 14.0.0 release. I've created this issue in the llvm project. It would be great if you could take a look at it. Thanks!

Feb 23 2022, 2:13 PM · Restricted Project
Chia-hungDuan added inline comments to D116789: [mlir] Support verification order (2/3).
Feb 23 2022, 9:47 AM · Restricted Project

Feb 22 2022

Chia-hungDuan requested review of D120373: [mlir] Support verification order (3/3).
Feb 22 2022, 5:13 PM · Restricted Project, Restricted Project
Chia-hungDuan updated the diff for D116789: [mlir] Support verification order (2/3).

Rebase

Feb 22 2022, 5:12 PM · Restricted Project

Feb 17 2022

Chia-hungDuan added a comment to D116789: [mlir] Support verification order (2/3).

@rriddle, a gentle ping. Would like to see if we can merge this soon

Feb 17 2022, 9:41 AM · Restricted Project

Feb 10 2022

Chia-hungDuan added inline comments to D116789: [mlir] Support verification order (2/3).
Feb 10 2022, 8:28 PM · Restricted Project
Chia-hungDuan updated the diff for D116789: [mlir] Support verification order (2/3).

Address review comments

Feb 10 2022, 8:28 PM · Restricted Project

Feb 8 2022

Chia-hungDuan added a comment to D116789: [mlir] Support verification order (2/3).

@rriddle, can you help with reviewing this approach?

Feb 8 2022, 8:35 PM · Restricted Project
Chia-hungDuan added inline comments to D116789: [mlir] Support verification order (2/3).
Feb 8 2022, 2:59 PM · Restricted Project
Chia-hungDuan updated the diff for D116789: [mlir] Support verification order (2/3).

Address review comment

Feb 8 2022, 2:59 PM · Restricted Project

Feb 7 2022

Chia-hungDuan added inline comments to D116789: [mlir] Support verification order (2/3).
Feb 7 2022, 12:31 PM · Restricted Project

Feb 6 2022

Chia-hungDuan updated the summary of D116789: [mlir] Support verification order (2/3).
Feb 6 2022, 11:15 PM · Restricted Project
Chia-hungDuan updated the diff for D116789: [mlir] Support verification order (2/3).

Abandon the early-/late- label which are too complicated.
Add hasRegionVerifier and verifyWithRegions for op and interface respectively
and keep the order of verifier defined by hasVerifier so that we have reduced
the number of new labels.

Feb 6 2022, 11:14 PM · Restricted Project

Feb 4 2022

Chia-hungDuan added inline comments to D116789: [mlir] Support verification order (2/3).
Feb 4 2022, 9:29 AM · Restricted Project

Feb 2 2022

Chia-hungDuan accepted D118763: [mlir] Fix crash in RewriterGen when a `TypeConstraint` is not given an argument.
Feb 2 2022, 3:29 PM · Restricted Project
Chia-hungDuan committed rG91e8a63c20ea: [mlir] Support verification order (1/3) (authored by Chia-hungDuan).
[mlir] Support verification order (1/3)
Feb 2 2022, 10:27 AM
Chia-hungDuan closed D115135: [mlir] Support verification order (1/3).
Feb 2 2022, 10:27 AM · Restricted Project
Chia-hungDuan added inline comments to D115135: [mlir] Support verification order (1/3).
Feb 2 2022, 10:24 AM · Restricted Project
Chia-hungDuan updated the diff for D115135: [mlir] Support verification order (1/3).

Rebase and address the review comments

Feb 2 2022, 10:24 AM · Restricted Project
Chia-hungDuan added inline comments to D116789: [mlir] Support verification order (2/3).
Feb 2 2022, 9:29 AM · Restricted Project

Feb 1 2022

Chia-hungDuan added a comment to D118742: [mlir] Refactor how additional verification is specified in ODS.

In D116789, I'm considering to use a trait to specify if an operation has an additional verifier. There are two kind of the these traits, indicating when it'll be run(before/after region verification). What do you think about this approach? Sorry that CL is pending now, will work on it ASAP.

Feb 1 2022, 4:02 PM · Restricted Project, Restricted Project

Jan 16 2022

Chia-hungDuan updated the diff for D115135: [mlir] Support verification order (1/3).

Check the dependency from tblgen instead.

Jan 16 2022, 10:28 PM · Restricted Project

Jan 12 2022

Chia-hungDuan committed rGc025fd8b0b79: [mlir] Update BUILD rule for MathDialect. (authored by Chia-hungDuan).
[mlir] Update BUILD rule for MathDialect.
Jan 12 2022, 10:13 AM
Chia-hungDuan closed D117127: [mlir] Update BUILD rule for MathDialect..
Jan 12 2022, 10:12 AM · Restricted Project
Chia-hungDuan requested review of D117127: [mlir] Update BUILD rule for MathDialect..
Jan 12 2022, 10:07 AM · Restricted Project