Page MenuHomePhabricator

Chia-hungDuan (Chia-hung Duan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 21 2021, 11:40 PM (7 w, 2 d)

Recent Activity

Yesterday

Chia-hungDuan committed rGf653313d4aec: [mlir][AsmPrinter] Remove recursion while SSA naming (authored by Chia-hungDuan).
[mlir][AsmPrinter] Remove recursion while SSA naming
Tue, May 11, 8:32 PM
Chia-hungDuan closed D102226: [mlir][AsmPrinter] Remove recursion while SSA naming.
Tue, May 11, 8:32 PM · Restricted Project
Chia-hungDuan added inline comments to D102226: [mlir][AsmPrinter] Remove recursion while SSA naming.
Tue, May 11, 8:20 PM · Restricted Project
Chia-hungDuan updated the diff for D102226: [mlir][AsmPrinter] Remove recursion while SSA naming.

Address review comments

  1. Use explict type for auto
  2. Use one SmallVector
Tue, May 11, 8:05 PM · Restricted Project
Chia-hungDuan requested review of D102226: [mlir][AsmPrinter] Remove recursion while SSA naming.
Tue, May 11, 2:58 AM · Restricted Project

Mon, May 10

Chia-hungDuan requested review of D102160: [mlir-tblgen] Support binding multi-results of NativeCodeCall.
Mon, May 10, 3:40 AM · Restricted Project

Sun, May 9

Chia-hungDuan committed rG34b5482b334f: Support NativeCodeCall binding in rewrite pattern. (authored by Chia-hungDuan).
Support NativeCodeCall binding in rewrite pattern.
Sun, May 9, 6:30 PM
Chia-hungDuan closed D100746: Support NativeCodeCall binding in rewrite pattern..
Sun, May 9, 6:29 PM · Restricted Project
Chia-hungDuan updated the diff for D100746: Support NativeCodeCall binding in rewrite pattern..

Addressed review comments

Sun, May 9, 5:30 PM · Restricted Project
Chia-hungDuan added inline comments to D100746: Support NativeCodeCall binding in rewrite pattern..
Sun, May 9, 5:29 PM · Restricted Project

Fri, May 7

Chia-hungDuan updated the diff for D101607: [mlir-reduce] Create MlirReduceLib.

Amend previous uploaded patches which was an accident.

Fri, May 7, 3:52 AM · Restricted Project
Chia-hungDuan updated the diff for D101046: [mlir-reduce] Reducer refactor..

Added comments

Fri, May 7, 3:50 AM · Restricted Project
Chia-hungDuan updated the diff for D101607: [mlir-reduce] Create MlirReduceLib.

Added comment

Fri, May 7, 3:41 AM · Restricted Project

Sun, May 2

Chia-hungDuan updated the diff for D101046: [mlir-reduce] Reducer refactor..

Addressed review comment

Sun, May 2, 8:33 PM · Restricted Project
Chia-hungDuan added inline comments to D101046: [mlir-reduce] Reducer refactor..
Sun, May 2, 8:32 PM · Restricted Project
Chia-hungDuan updated the diff for D100746: Support NativeCodeCall binding in rewrite pattern..

Addressed missed/wrong replied review comments

Sun, May 2, 3:57 PM · Restricted Project
Chia-hungDuan added inline comments to D100746: Support NativeCodeCall binding in rewrite pattern..
Sun, May 2, 3:56 PM · Restricted Project

Fri, Apr 30

Chia-hungDuan updated the diff for D100746: Support NativeCodeCall binding in rewrite pattern..

Addressed review comments

Fri, Apr 30, 2:55 AM · Restricted Project
Chia-hungDuan added inline comments to D100746: Support NativeCodeCall binding in rewrite pattern..
Fri, Apr 30, 2:54 AM · Restricted Project
Chia-hungDuan updated the summary of D101607: [mlir-reduce] Create MlirReduceLib.
Fri, Apr 30, 1:57 AM · Restricted Project
Chia-hungDuan requested review of D101607: [mlir-reduce] Create MlirReduceLib.
Fri, Apr 30, 1:56 AM · Restricted Project
Chia-hungDuan updated the diff for D101046: [mlir-reduce] Reducer refactor..

Addressed review comments

Fri, Apr 30, 1:56 AM · Restricted Project
Chia-hungDuan added inline comments to D101046: [mlir-reduce] Reducer refactor..
Fri, Apr 30, 1:55 AM · Restricted Project

Thu, Apr 29

Chia-hungDuan updated the diff for D101046: [mlir-reduce] Reducer refactor..

Addressed review comments

Thu, Apr 29, 5:45 AM · Restricted Project
Chia-hungDuan added inline comments to D101046: [mlir-reduce] Reducer refactor..
Thu, Apr 29, 5:45 AM · Restricted Project

Mon, Apr 26

Chia-hungDuan updated the diff for D101046: [mlir-reduce] Reducer refactor..

Add comments and did some structures clean up

Mon, Apr 26, 7:21 PM · Restricted Project
Chia-hungDuan added inline comments to D101046: [mlir-reduce] Reducer refactor..
Mon, Apr 26, 7:20 PM · Restricted Project

Fri, Apr 23

Chia-hungDuan added a comment to D100746: Support NativeCodeCall binding in rewrite pattern..

Thanks for reviewing the sentences and sorry for my bad writing. Can you take a look the updated one and see if it's more clear now?

Fri, Apr 23, 6:08 AM · Restricted Project
Chia-hungDuan updated the diff for D100746: Support NativeCodeCall binding in rewrite pattern..

Revised the comments

Fri, Apr 23, 6:04 AM · Restricted Project
Chia-hungDuan updated the diff for D101046: [mlir-reduce] Reducer refactor..

Fixed linting error and updated comment

Fri, Apr 23, 3:31 AM · Restricted Project
Chia-hungDuan added inline comments to D100746: Support NativeCodeCall binding in rewrite pattern..
Fri, Apr 23, 3:21 AM · Restricted Project
Chia-hungDuan added inline comments to D100746: Support NativeCodeCall binding in rewrite pattern..
Fri, Apr 23, 3:11 AM · Restricted Project
Chia-hungDuan updated the diff for D100746: Support NativeCodeCall binding in rewrite pattern..

Applied review comments and updated the document.

Fri, Apr 23, 3:10 AM · Restricted Project

Thu, Apr 22

Chia-hungDuan updated the diff for D101046: [mlir-reduce] Reducer refactor..

Handle empty region and adjusted some early return logics.

Thu, Apr 22, 4:30 AM · Restricted Project
Chia-hungDuan added reviewers for D101046: [mlir-reduce] Reducer refactor.: jpienaar, rriddle.
Thu, Apr 22, 4:20 AM · Restricted Project
Chia-hungDuan requested review of D101046: [mlir-reduce] Reducer refactor..
Thu, Apr 22, 4:15 AM · Restricted Project

Mon, Apr 19

Chia-hungDuan added a reviewer for D100746: Support NativeCodeCall binding in rewrite pattern.: jpienaar.
Mon, Apr 19, 2:39 AM · Restricted Project
Chia-hungDuan requested review of D100746: Support NativeCodeCall binding in rewrite pattern..
Mon, Apr 19, 2:38 AM · Restricted Project

Tue, Apr 13

Chia-hungDuan updated the diff for D100155: Use PassPipelineCLParser in mlir-reduce.

Fix naming

Tue, Apr 13, 8:20 PM · Restricted Project
Chia-hungDuan added inline comments to D100155: Use PassPipelineCLParser in mlir-reduce.
Tue, Apr 13, 5:24 AM · Restricted Project
Chia-hungDuan updated the diff for D100155: Use PassPipelineCLParser in mlir-reduce.

Fixes from review comments

Tue, Apr 13, 5:24 AM · Restricted Project
Chia-hungDuan updated the diff for D99713: Refactor the architecture of mlir-reduce.

Fix linting erros.

Tue, Apr 13, 3:06 AM · Restricted Project

Apr 8 2021

Chia-hungDuan added a comment to D100155: Use PassPipelineCLParser in mlir-reduce.

This CL also erases the bug mentioned here, https://bugs.llvm.org/show_bug.cgi?id=48094

Apr 8 2021, 11:02 PM · Restricted Project
Chia-hungDuan added inline comments to D99713: Refactor the architecture of mlir-reduce.
Apr 8 2021, 10:59 PM · Restricted Project
Chia-hungDuan updated the diff for D99713: Refactor the architecture of mlir-reduce.

Remove debugging header

Apr 8 2021, 10:50 PM · Restricted Project
Chia-hungDuan requested review of D100156: [mlir] Fix passArg of ViewOpGraphPass.
Apr 8 2021, 4:59 PM · Restricted Project
Chia-hungDuan added inline comments to D100155: Use PassPipelineCLParser in mlir-reduce.
Apr 8 2021, 4:30 PM · Restricted Project
Chia-hungDuan updated the diff for D100155: Use PassPipelineCLParser in mlir-reduce.
Apr 8 2021, 4:26 PM · Restricted Project
Chia-hungDuan requested review of D100155: Use PassPipelineCLParser in mlir-reduce.
Apr 8 2021, 4:23 PM · Restricted Project

Apr 7 2021

Chia-hungDuan added inline comments to D99713: Refactor the architecture of mlir-reduce.
Apr 7 2021, 1:09 AM · Restricted Project
Chia-hungDuan updated the diff for D99713: Refactor the architecture of mlir-reduce.

Add more algorithm comments and fix some lints/erros based on review comments.

Apr 7 2021, 1:09 AM · Restricted Project

Apr 6 2021

Chia-hungDuan updated the diff for D99713: Refactor the architecture of mlir-reduce.

Reduce the number of generating new variants and change to use llvm::ArrayRef while accessing variants vector.

Apr 6 2021, 3:29 AM · Restricted Project
Chia-hungDuan added inline comments to D99713: Refactor the architecture of mlir-reduce.
Apr 6 2021, 12:27 AM · Restricted Project
Chia-hungDuan updated the diff for D99713: Refactor the architecture of mlir-reduce.

Fixed the review comments and removed weird file in the previous change

Apr 6 2021, 12:25 AM · Restricted Project

Apr 1 2021

Chia-hungDuan updated the diff for D99713: Refactor the architecture of mlir-reduce.

Add header for ReductionTreePass.cpp and fix some linting error

Apr 1 2021, 3:50 AM · Restricted Project
Chia-hungDuan added a reviewer for D99713: Refactor the architecture of mlir-reduce: jpienaar.
Apr 1 2021, 3:20 AM · Restricted Project
Chia-hungDuan updated the summary of D99713: Refactor the architecture of mlir-reduce.
Apr 1 2021, 3:19 AM · Restricted Project
Chia-hungDuan requested review of D99713: Refactor the architecture of mlir-reduce.
Apr 1 2021, 3:18 AM · Restricted Project

Mar 22 2021

Chia-hungDuan added a reviewer for D99060: Fix the order of directives and the target string: jpienaar.
Mar 22 2021, 2:43 AM · Restricted Project
Chia-hungDuan requested review of D99060: Fix the order of directives and the target string.
Mar 22 2021, 2:18 AM · Restricted Project