Page MenuHomePhabricator
People efocht

efocht (Erich Focht)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 17 2019, 5:27 AM (179 w, 6 d)

Recent Activity
View All

Nov 24 2022

efocht accepted D138544: [VE] Remove unnecessary isReMaterializable flags.

Looks good and makes sense.

Nov 24 2022, 2:29 PM · Unknown Object (Project), Restricted Project, Restricted Project

Oct 19 2022

efocht accepted D136049: [VE] Change the way to lower selectcc.

Looks good.

Oct 19 2022, 7:00 AM · Restricted Project, Unknown Object (Project), Restricted Project

Oct 13 2022

efocht accepted D135878: [VE] Change the way to lower select.

LGTM

Oct 13 2022, 6:32 PM · Unknown Object (Project), Restricted Project, Restricted Project

Sep 27 2022

efocht accepted D134695: [VE] Change to expand FPOW.

LGTM

Sep 27 2022, 3:01 AM · Unknown Object (Project), Restricted Project, Restricted Project

Sep 26 2022

efocht accepted D134595: [VE] Disable automatic maxnum/minnum selection.
Sep 26 2022, 5:12 AM · Unknown Object (Project), Restricted Project, Restricted Project
efocht accepted D134583: [VE] Support smax/smin.
Sep 26 2022, 4:10 AM · Unknown Object (Project), Restricted Project, Restricted Project

Sep 21 2022

efocht accepted D134341: [VE] Remove obsolete ANDrm patterns.

+1

Sep 21 2022, 3:14 AM · Unknown Object (Project), Restricted Project, Restricted Project
efocht accepted D134118: [VE][NFC] Change to use l2i/i2l to simplify code.
Sep 21 2022, 1:17 AM · Unknown Object (Project), Restricted Project, Restricted Project
efocht accepted D134108: [VE] Add maxnum and minnum.

LGTM

Sep 21 2022, 1:15 AM · Unknown Object (Project), Restricted Project, Restricted Project
efocht accepted D134107: [VE] Change to expand FMA.

LGTM

Sep 21 2022, 1:01 AM · Restricted Project, Unknown Object (Project), Restricted Project

Sep 15 2022

efocht accepted D133514: [VP][VE] Default VP_SREM/UREM to Expand and add generic expansion using VP_SDIV/UDIV+VP_MUL+VP_SUB..

The expansion in the downstream code for VE does exactly the same thing like the proposed changes.
The code generated for the tests also looks good. Thanks for implementing this!

Sep 15 2022, 12:48 AM · Restricted Project, Restricted Project

Aug 22 2022

efocht accepted D132380: [VE] Support inlineasm memory operand.

Looks good.

Aug 22 2022, 9:51 AM · Restricted Project, Unknown Object (Project), Restricted Project

Jul 16 2022

efocht accepted D129415: [VE] Support load/store/spill of vector mask registers.
Jul 16 2022, 2:15 AM · Unknown Object (Project), Restricted Project, Restricted Project

Jul 15 2022

efocht requested changes to D129415: [VE] Support load/store/spill of vector mask registers.

Just a tiny typo. Otherwise looks good.

Jul 15 2022, 2:15 AM · Unknown Object (Project), Restricted Project, Restricted Project

Jul 5 2022

efocht accepted D129034: [VE] Restructure eliminateFrameIndex.

Looks good to me.

Jul 5 2022, 2:36 AM · Unknown Object (Project), Restricted Project, Restricted Project

Jun 30 2022

efocht accepted D128610: [VE] Support load/store vm regsiters.
Jun 30 2022, 2:48 AM · Restricted Project, Unknown Object (Project), Restricted Project

Jun 20 2022

efocht accepted D128120: [Clang][VE] Add missing intrinsics.

Looks ok for me.

Jun 20 2022, 3:16 AM · Unknown Object (Project), Restricted Project, Restricted Project

Oct 26 2021

efocht added inline comments to D112384: [LegalizeTypes][VE] Fix a regression test following previous cttz fix.
Oct 26 2021, 12:51 PM · Unknown Object (Project), Restricted Project

Mar 26 2020

efocht added a comment to D76843: [Openmp] Libomptarget plugin for NEC SX-Aurora.

Thanks for pushing this upstream, Manoel! Some comments below, inline.

Mar 26 2020, 3:47 PM · Restricted Project, Unknown Object (Project)