User Details
- User Since
- Mar 22 2013, 2:32 PM (483 w, 5 d)
Thu, Jun 23
LGTM
LGTM
Mon, Jun 20
Sat, Jun 11
Fri, Jun 10
Wed, Jun 8
LGTM
Tue, Jun 7
The patch looks good.
But could you remove the unrelated cosmetic changes, please?
May 23 2022
LGTM.
May 19 2022
Everything is ready for the new worker to be staged.
LGTM.
LGTM.
Once committed, please feel free to connect the new worker to the staging.
May 3 2022
By the way, we had a conditional cmake run before, and removed that because of some dependencies were not forced by ninja.
https://github.com/llvm/llvm-zorg/commit/a9f92433031343bfbb6b2160e2829b89d39ab461
LGTM.
May 2 2022
This does not handle the case when incremental build starts on empty build directory.
LGTM.
Apr 23 2022
Thanks, Konrad!
When you will do the follow up changes, you may want to remove the clang version number from the name of the builder and from the paths. Using update-alternatives or something similar to manage the versions of the system tool chain might be a good idea. This way you will not need to make changes to zorg every time you update the tool chain.
LGTM
LGTM.
Please feel free to connect the new workers to the staging.
LGTM
LGTM with a nit pick.
Apr 12 2022
Depending on the build requests queues any combination of 2 concurrent builds is possible. Yes, it is possible to have 2 ppc64le-flang-rhel-clang builds running and ppc64le-mlir-rhel-clang builds waiting.
Apr 4 2022
Hello Kamau,
Apr 2 2022
Mar 29 2022
Mar 25 2022
LGTM.
Mar 24 2022
I can commit on your behalf.
But before that, I'll need a password for the new worker. You can either send it to me directly, or I can assign a random one and send it to you.
Please let me know what you prefer.
Mar 22 2022
It was staged long enough without any discovered issues.
Thanks, Konrad!
Please feel free to commit. I'll follow up with some changes to clean the dependencies.
LGTM
I'd just make a new clean diff with only related changes and upload it through the Phabricator WebUI. This might be more controllable and straight forward.
Almost missed.
LGTM with a nitpick.
Please feel free to commit with removed watchedWorkers arg.
Did you do that the other way around? :)
I see only removed trailing white spaces in this patch now.
Mar 21 2022
Thanks for the patch, Paul!
Mar 4 2022
LGTM.
Mar 3 2022
LGTM.
LGTM
Mar 1 2022
Thanks, Diana!
LGTM.
Feb 28 2022
List of checks is a good idea.
LGTM
LGTM
Feb 23 2022
I was planning to start using the pip-tools, but you bet me to it.
Thanks!
LGTM.
Feb 22 2022
LGTM
Are you sure you don’t want to skip watchpoint tests? They seem unreliable on Windows.
Feb 18 2022
LGTM
Feb 17 2022
Feb 16 2022
Do you need help committing this change?
Thanks, Kamau!
LGTM.
Feb 15 2022
Thanks, Teresa!
LGTM
Feb 5 2022
Feb 4 2022
LGTM
Feb 3 2022
Jan 30 2022
Jan 29 2022
Jan 27 2022
LGTM with a nit.
Jan 26 2022
The patch looks good. Thanks, Stella!
LGTM
Thanks for the patch, Alex!
Jan 20 2022
Jan 19 2022
Jan 17 2022
Jan 15 2022
Jan 14 2022
What about adding a separate parameter for the jobs for the tests? That way a different level of parallelism could be specified for build and test? That's the route I would have gone.
I think they should be set in just one place to make the code more readable.
I was about to suggest the same.
Hi Douglas,
Jan 13 2022
That is, if clean is set to False, the value of clean_obj does not matter, even if it is True and the build dir is not cleaned. This is what this patch intends to change.
Jan 12 2022
You are welcome, Amir!
Jan 11 2022
Hi Amir,
Jan 10 2022
Jan 8 2022
Jan 6 2022
Sure, I commit this for you.
LGTM
Jan 1 2022
Dec 30 2021
Looks good with one cosmetic nit pick.
The patch looks good with one thing:
In addition to be "not set", the clean property can also be "false". Should this count as "set"?
Dec 22 2021
Thanks, Philip!
LGTM.
Dec 17 2021
Hi Zarko,
Dec 14 2021
Please feel free to commit.