User Details
- User Since
- Mar 22 2013, 2:32 PM (523 w, 1 d)
Thu, Mar 30
OpenMPBuilder didn't do enable_runtimes="auto". This is fixed in https://github.com/llvm/llvm-zorg/commit/b86d771caf03cb7fe94d0d187cad25d9519ea584.
Please keep it as is. I'll take a look later today on what might be wrong.
Thanks for updating the patch, JP.
Wed, Mar 29
libc will be a runtime by default.
Tue, Mar 28
Could you elaborate on why did you specify LLVM_ENABLE_PROJECTS explicitly, and why it does not match what's in the depends_on_projects, please? The same question is for LLVM_ENABLE_RUNTIMES and enable_runtimes respectively.
Fri, Mar 24
LGTM
Thu, Mar 23
Fri, Mar 10
LGTM.
Thu, Mar 9
LGTM.
The patch looks fine with one thing to fix.
Wed, Mar 8
Please ping me with the password for this worker before committing the patch.
Fri, Mar 3
LGTM.
Mar 1 2023
LGTM.
Feb 28 2023
LGTM.
The patch looks good in general.
There is no promise of forward compatibility as far as I know. Thus far I have seen working workers from version 0.8.4 to version 3.7.0. I have also seen people setting up workers from the source code and not any particular release. All this is fine. I don't think we should force everyone to use a particular version as long as that does not affect reliability of the production buildbot, and experiments with newer versions do not require much attention and troubleshooting on the server side. Being flexible with the requirements to workers help bot owners to keep them on their own schedule.
Feb 25 2023
Feb 21 2023
Production buildbot gets reconfigured or restarted only if it is necessary when we have less commits and builds activity. And that's usually combined with other maintenance work. Frankly, I don't think it worth mentioning in the docs.
That's fine, you do not have to submit perf results to LNT if you do not want to.
Just add something to the description which would provide the reasoning why you stop doing so. Saying something like "because recently LNT server became unreliable with accepting runs", or whatever you things the reason is, is Ok.
LGTM
More recent versions of buildbot-worker would work too. But you are right, we shall recommend what would work for sure and what would require less effort to setup.
Feb 14 2023
Feb 13 2023
LGTM
Could you update the summary with the reason of why LNT submit gets removed, please?
Feb 10 2023
Feb 8 2023
If LIT default threads usage is what you are after, the patch looks good.
Adding Simon as a reviewer.
LGTM
Feb 7 2023
Feel free to connect your worker to the staging.
Feb 6 2023
Feb 3 2023
Feb 2 2023
We can use this builder as a pilot of gated builds if you have bandwidth and are willing to babysit it for awhile. I'm looking forward to it.
Feb 1 2023
LGTM.
LGTM with a nit pick.
LGTM.
Jan 31 2023
LGTM.
Jan 27 2023
Jan 24 2023
LGTM.
Jan 17 2023
Jan 13 2023
Thanks, Amir!
Thanks, Muhammad!
Looks good.
Jan 11 2023
The meaning is changing over time as we are getting more and more fast builders. For now, I'd call a builder quick if it is able to build each commit and stay current with the build queue in general (something like 3-5 minutes response time or better).
Jan 9 2023
LGTM.
Jan 8 2023
The patch looks good.
Thanks for making the changes!
LGTM.
Dec 31 2022
Dec 27 2022
LGTM.
Thanks for the patch, Muhammad.
Hello Ron,
Dec 25 2022
The patch looks good. The only thing I'm not sure is the error handling at the check-bolt-different step. + one cosmetic nit pick.
Dec 20 2022
Nice catch! :)
Thanks for the patch, Ilya!
And thanks for helping with the review, Kadir! All good comments.
Dec 18 2022
I believe I commented this patch, but do not see my comments here. :(
Sorry for this.
Dec 16 2022
Thanks everyone for helping with the review!
Dec 15 2022
LGTM.
LGTM.
Dec 14 2022
Hi Amir,
Hello David,
I don't think I'm a good reviewer for this patch.
LGTM.
LGTM.
Interesting.
Could you tell me how ccache with icecream will work for you with a real load after a few weeks of working, please?
Dec 7 2022
Hi Amir,
The patch itself looks Ok.
Nov 29 2022
Doesn't look like I'm a good reviewer for the proposed patch.
Nov 15 2022
LGTM.
LGTM.
Nov 14 2022
LGTM.
The patch itself looks good.
Nov 10 2022
Nov 9 2022
Hi Michael.
Nov 8 2022
LGTM.
Thanks for the patch, Amir!
The patch itself looks good.
Oct 19 2022
LGTM
LGTM
LGTM