Page MenuHomePhabricator
People gkistanova

gkistanova (Galina)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 22 2013, 2:32 PM (366 w, 3 d)

Recent Activity
View All

Sat, Mar 28

gkistanova added a comment to D75105: mlir-nvidia builder: using traget X86 instead of host.

Hi Christian,

Sat, Mar 28, 5:44 PM

Fri, Mar 27

gkistanova committed rZORG4abf27c36f15: Updated UnifiedTreeBuilder to use LitTestCommand for testing steps. (authored by gkistanova).
Updated UnifiedTreeBuilder to use LitTestCommand for testing steps.
Fri, Mar 27, 10:32 PM

Fri, Mar 20

gkistanova accepted D76441: [zorg] Add -fcommon to polly aosp buildbot..

LGTM

Fri, Mar 20, 5:22 PM
gkistanova committed rZORG5fab453ffc9c: Removed extra square bracket. (authored by gkistanova).
Removed extra square bracket.
Fri, Mar 20, 2:40 PM

Thu, Mar 19

gkistanova committed rZORGfbf5b2d2a356: Fixed -DLLVM_TARGETS_TO_BUILD in mlir-nvidia builder. (authored by gkistanova).
Fixed -DLLVM_TARGETS_TO_BUILD in mlir-nvidia builder.
Thu, Mar 19, 8:52 PM
gkistanova added a comment to D75105: mlir-nvidia builder: using traget X86 instead of host.

Hi Christian,

Thu, Mar 19, 8:50 PM

Wed, Mar 4

gkistanova committed rZORG68e4894ccf7a: Fixed missing bracket. (authored by gkistanova).
Fixed missing bracket.
Wed, Mar 4, 9:13 PM

Tue, Mar 3

gkistanova committed rZORG0ac4345f5c1f: Added a new 'publish-sphinx-docs' builder. (authored by gkistanova).
Added a new 'publish-sphinx-docs' builder.
Tue, Mar 3, 9:16 PM
gkistanova accepted D75593: Added getLLVMDocsBuildFactory to build and publish LLVM documentation..

It would be nice to refactor getSphinxDocsBuildFactory to use the same approach with llvm_docs. Would simplify the things.
Not a subject of this patch, of course.

Tue, Mar 3, 9:15 PM · Restricted Project, Restricted Project, Restricted Project, lld, Restricted Project, Restricted Project, Restricted Project, Restricted Project
gkistanova added inline comments to D75495: [buildbot] Add an MLIR buildbot on Windows.
Tue, Mar 3, 7:37 PM
gkistanova added a comment to D75105: mlir-nvidia builder: using traget X86 instead of host.

Hi Christian.

Tue, Mar 3, 7:37 PM
gkistanova accepted D75495: [buildbot] Add an MLIR buildbot on Windows.

Let me know if we need to do anything else other than commit the patch and wait for a reboot.

Tue, Mar 3, 7:37 PM

Feb 28 2020

gkistanova accepted D75376: Execute libunwind/libc++abi tests on AArch64 devboard by llvm-clang-win-x-aarch64 builder. .

LGTM

Feb 28 2020, 7:05 PM

Feb 26 2020

gkistanova accepted D75127: [zorg] Add x86_64 buildbots for Polly..

LGTM

Feb 26 2020, 11:59 AM · Restricted Project

Feb 17 2020

gkistanova committed rZORG3be8cdf34c8e: Added missing commas for mlir-nvidia buildbot. This fixed the broken CMake… (authored by gkistanova).
Added missing commas for mlir-nvidia buildbot. This fixed the broken CMake…
Feb 17 2020, 7:06 PM
gkistanova closed D74699: added missing commas for mlir-nvidia buildbot.
Feb 17 2020, 7:06 PM
gkistanova accepted D74699: added missing commas for mlir-nvidia buildbot.
Feb 17 2020, 12:21 PM

Feb 13 2020

gkistanova accepted D74199: [libc builder] Use annotated builder for libc buildbot..

Do I need to specify a scheduler if I'm using the annotated builder?

Feb 13 2020, 7:22 PM · Restricted Project, Restricted Project
gkistanova committed rZORG2c7cdfff1efc: Config for mlir-nvidia buildbot. (authored by gkistanova).
Config for mlir-nvidia buildbot.
Feb 13 2020, 7:04 PM
gkistanova closed D74200: config for mlir-nvidia buildbot.
Feb 13 2020, 7:04 PM

Feb 11 2020

gkistanova added a comment to D73840: [CMake] Add missing component dependencies, to fix building for mingw with BUILD_SHARED_LIBS.

Hello Martin,

Feb 11 2020, 4:55 PM · Restricted Project
gkistanova committed rGf9219e644ac6: Reverted the remainings of c1c9819ef91aab51b5a23fb3027adac5a2f551cc as it has… (authored by gkistanova).
Reverted the remainings of c1c9819ef91aab51b5a23fb3027adac5a2f551cc as it has…
Feb 11 2020, 4:20 PM
gkistanova accepted D74193: [zorg] Add extra argument passing to getAnnotatedBuildFactory..
Feb 11 2020, 11:28 AM · Restricted Project
gkistanova accepted D74200: config for mlir-nvidia buildbot.

LGTM

Feb 11 2020, 11:19 AM

Feb 8 2020

gkistanova requested changes to D74193: [zorg] Add extra argument passing to getAnnotatedBuildFactory..

Thanks for documenting the Annotated Bulder, Paula!

Feb 8 2020, 10:24 PM · Restricted Project

Feb 3 2020

gkistanova accepted D73578: Execute libc++abi tests on Armv7 devboard by llvm-clang-win-x-armv7l builder..
Feb 3 2020, 11:48 AM · Restricted Project
gkistanova accepted D73799: Requested informative notifications for aarch64/armv7 cross builders..

LGTM

Feb 3 2020, 11:48 AM · Restricted Project
gkistanova accepted D73797: Merge requests for llvm-clang-win-x-armv7l and llvm-clang-win-x-aarch64 builders..
Feb 3 2020, 11:48 AM · Restricted Project

Jan 20 2020

gkistanova added a comment to D72646: [zorg] Pass "-DLLVM_POLLY_LINK_INTO_TOOLS=ON" in getPollyBuildFactory.

Yes, restart is required. It's planned tonight.

Jan 20 2020, 11:03 AM

Jan 13 2020

gkistanova accepted D72646: [zorg] Pass "-DLLVM_POLLY_LINK_INTO_TOOLS=ON" in getPollyBuildFactory.

LGTM

Jan 13 2020, 7:28 PM

Jan 7 2020

gkistanova accepted D71417: [VE] Staging buildbot.

LGTM

Jan 7 2020, 11:31 AM · Restricted Project

Dec 29 2019

gkistanova added a comment to D71626: Enable remote host configuration to run the target tests for Windows to ARM Linux cross builders..

Yes. Would you stage it first, please?

Dec 29 2019, 11:21 PM · Restricted Project

Dec 28 2019

gkistanova accepted D71626: Enable remote host configuration to run the target tests for Windows to ARM Linux cross builders..

LGTM

Dec 28 2019, 5:28 PM · Restricted Project

Dec 18 2019

gkistanova requested changes to D71417: [VE] Staging buildbot.

Simon,
Please update the diff without that unrelated cosmetic change (an empty line after line #1319).
Otherwise LGTM.

Dec 18 2019, 12:05 PM · Restricted Project
gkistanova accepted D70715: [AVR] Add the AVR builder 'llvm-avr-linux' back, pulling from GitHub.

LGTM

Dec 18 2019, 12:05 PM

Dec 9 2019

gkistanova accepted D70976: [zorg] Add LNT testing to clang-ppc64le-rhel.

LGTM

Dec 9 2019, 11:12 PM

Dec 4 2019

gkistanova committed rZORG4ec74127d5f9: Removed c_compiler and cxx_compiler options from OpenMPBuilder (authored by gribozavr).
Removed c_compiler and cxx_compiler options from OpenMPBuilder
Dec 4 2019, 8:07 PM

Dec 3 2019

gkistanova committed rZORGa5fe1bde920a: Added more builders to report github status. (authored by gkistanova).
Added more builders to report github status.
Dec 3 2019, 11:11 PM
gkistanova committed rZORGab4824235f7b: Removed legacy mode from OpenMPBuilder (authored by gribozavr).
Removed legacy mode from OpenMPBuilder
Dec 3 2019, 11:02 PM
gkistanova committed rZORGff24a1f5a4c2: Enabled ccache on OpenMP jobs (authored by gribozavr).
Enabled ccache on OpenMP jobs
Dec 3 2019, 11:02 PM
gkistanova committed rZORG6c3e9906adee: Removed an unused variable from OpenMPBuilder (authored by gribozavr).
Removed an unused variable from OpenMPBuilder
Dec 3 2019, 11:02 PM

Dec 2 2019

gkistanova committed rZORGb89b2c731886: Notify on some missing builders. (authored by gkistanova).
Notify on some missing builders.
Dec 2 2019, 7:28 PM

Nov 29 2019

gkistanova committed rZORGde35b25c23a4: Added new llvm-clang-x86_64-expensive-checks-debian and clang-x86_64-debian-new… (authored by gkistanova).
Added new llvm-clang-x86_64-expensive-checks-debian and clang-x86_64-debian-new…
Nov 29 2019, 4:43 PM

Nov 26 2019

gkistanova added a comment to D70543: [zorg] Add Clang PPC buildbot on Red Hat.

@w2yehia Hi Wael,
If you mean that e-mail with the computer you are going to use for this builder, then yes, I have received it and applied all the needed changes to the staging.

Nov 26 2019, 11:35 AM

Nov 22 2019

gkistanova committed rZORGcd88a122e80b: Polished the success status description. (authored by gkistanova).
Polished the success status description.
Nov 22 2019, 9:09 PM

Nov 21 2019

gkistanova committed rZORG16c005683f28: Imported status. (authored by gkistanova).
Imported status.
Nov 21 2019, 11:19 PM
gkistanova committed rZORG16c86f773c08: Added the first github status reporter in pilot mode. (authored by gkistanova).
Added the first github status reporter in pilot mode.
Nov 21 2019, 11:10 PM
gkistanova committed rZORGe44a4915f243: Add Clang PPC buildbot on Red Hat. (authored by gkistanova).
Add Clang PPC buildbot on Red Hat.
Nov 21 2019, 10:13 PM
gkistanova closed D70543: [zorg] Add Clang PPC buildbot on Red Hat.
Nov 21 2019, 10:13 PM
gkistanova committed rZORGb03d19aca551: Added GitHubStatus to report build statuses to github llvm-project repo. (authored by gkistanova).
Added GitHubStatus to report build statuses to github llvm-project repo.
Nov 21 2019, 10:03 PM
gkistanova added a comment to D70543: [zorg] Add Clang PPC buildbot on Red Hat.

I'll commit it for you.

Nov 21 2019, 8:24 PM
gkistanova accepted D70543: [zorg] Add Clang PPC buildbot on Red Hat.

LGTM

Nov 21 2019, 12:22 PM

Nov 17 2019

gkistanova raised a concern with rG979da9a4c3ba: Avoid including Builtins.h in Preprocessor.h.

Hello Reid,

Nov 17 2019, 2:44 PM

Nov 12 2019

gkistanova committed rZORG1c80bd6649c7: Preserve input case in InterpolateToNativePath. (authored by gkistanova).
Preserve input case in InterpolateToNativePath.
Nov 12 2019, 7:35 PM
gkistanova committed rZORG363234d18617: Looks like XToolchainBuilder wants forward slash path separator for llvm-ar… (authored by gkistanova).
Looks like XToolchainBuilder wants forward slash path separator for llvm-ar…
Nov 12 2019, 4:44 PM

Nov 11 2019

gkistanova committed rZORG3b645861c511: Removed from staging bots which cannot work with gihub. (authored by gkistanova).
Removed from staging bots which cannot work with gihub.
Nov 11 2019, 7:31 PM
gkistanova accepted D70098: Added builders to build cross from Windows to ARMv7l and AArch64 LLVM toolchains..

LGTM

Nov 11 2019, 4:18 PM · Restricted Project, Restricted Project, Restricted Project
gkistanova committed rZORGd1365377b546: Fixed typo. NFC. (authored by gkistanova).
Fixed typo. NFC.
Nov 11 2019, 3:32 PM
gkistanova accepted D70039: Added XToolchainBuilder to build cross toolchains..

LGTM

Nov 11 2019, 11:35 AM · Restricted Project, Restricted Project, Restricted Project
gkistanova accepted D70028: Update Fuchsia builder to use Git.

Thanks for changing this, Petr!

Nov 11 2019, 11:35 AM

Nov 7 2019

gkistanova committed rGad3c9d46fe39: Revert "[MachineVerifier] Improve verification of live-in lists. (authored by gkistanova).
Revert "[MachineVerifier] Improve verification of live-in lists.
Nov 7 2019, 2:08 PM
gkistanova added a reverting change for rGb7b170c9b46a: [MachineVerifier] Improve verification of live-in lists.: rGad3c9d46fe39: Revert "[MachineVerifier] Improve verification of live-in lists..
Nov 7 2019, 2:08 PM
gkistanova added a comment to D68267: [MBB LiveIn lists, MachineVerifier, SystemZ] New method isLiveOut() and mverifier improvement..

I have reverted this by ad3c9d4.

Nov 7 2019, 2:07 PM · Restricted Project

Nov 5 2019

gkistanova committed rZORG6aa8dfedf8c1: Updated LLVMBuildFactory to place by default the build directory outside of the… (authored by gkistanova).
Updated LLVMBuildFactory to place by default the build directory outside of the…
Nov 5 2019, 8:18 PM
gkistanova committed rZORGdcb16080a521: Create a separate step for each check in UnifiedTreeBuilder. (authored by gkistanova).
Create a separate step for each check in UnifiedTreeBuilder.
Nov 5 2019, 8:18 PM
gkistanova committed rZORG3ef3b908ed15: Some code cleaning for LLDPerformanceTestsuite. (authored by gkistanova).
Some code cleaning for LLDPerformanceTestsuite.
Nov 5 2019, 7:32 PM

Nov 4 2019

gkistanova requested changes to D69727: [libc builder] Use AnnotatedBuilder instead of LLVMBuilder..

Hello Siva,

Nov 4 2019, 8:55 PM
gkistanova accepted D69799: Bring back clang-x64-ninja-win7 and clang-atom-d525-fedora-rel after fixing git problems.

Thanks, Ilia!
Could you connect your atom1-buildbot and windows7-buildbot bots to the staging master first, please?

Nov 4 2019, 8:46 PM

Nov 1 2019

gkistanova committed rZORG8ea093f54b1b: Removed builders not working with github monorepo. (authored by gkistanova).
Removed builders not working with github monorepo.
Nov 1 2019, 11:43 PM
gkistanova accepted D69651: [CMake] Add cross Windows to ARM Linux toolchain CMake cache file..

LGTM. Thank you!

Nov 1 2019, 12:41 PM · Restricted Project
gkistanova requested changes to D69655: Add llvm-libc builders..

Could you address the above comments, please?

Nov 1 2019, 11:38 AM
gkistanova reopened D69655: Add llvm-libc builders..

Thanks for working on this, Siva!

Nov 1 2019, 11:36 AM
gkistanova accepted D69703: Refactored PollyBuilder.getPollyBuildFactory to support github..

LGTM

Nov 1 2019, 11:07 AM · Restricted Project, Restricted Project, Restricted Project

Oct 31 2019

gkistanova committed rZORG899a38f03cbc: Fixed a wrong libc++ path for monorepo. (authored by gkistanova).
Fixed a wrong libc++ path for monorepo.
Oct 31 2019, 9:42 PM
gkistanova committed rZORGe249863ac732: Removed extra quotation marks around -DLLVM_ENABLE_PROJECTS list in LLDBBuilder. (authored by gkistanova).
Removed extra quotation marks around -DLLVM_ENABLE_PROJECTS list in LLDBBuilder.
Oct 31 2019, 10:31 AM

Oct 30 2019

gkistanova committed rZORG72013c2d90c5: Made expensive checks buulders report extra information on tests failures. (authored by gkistanova).
Made expensive checks buulders report extra information on tests failures.
Oct 30 2019, 10:23 PM
gkistanova committed rZORGca287e6e2217: Turn the legacy mode off by default. (authored by gkistanova).
Turn the legacy mode off by default.
Oct 30 2019, 8:32 PM
gkistanova added a comment to D69555: [zorg] Fix LLDBCmakeBuildFactory.

The cmake command redefinition effectively is not supported any more, but the 'cmake' arg is left behind.
+ inline comments.

Oct 30 2019, 4:32 PM
gkistanova committed rZORGb94571639635: Force LIT verbose mode for some ARM builders to prevent a timeout on clean… (authored by gkistanova).
Force LIT verbose mode for some ARM builders to prevent a timeout on clean…
Oct 30 2019, 4:23 PM
gkistanova committed rZORG3b78160a8bd4: Always do a clean build on llvm-clang-x86_64-expensive-checks-win. (authored by gkistanova).
Always do a clean build on llvm-clang-x86_64-expensive-checks-win.
Oct 30 2019, 4:13 PM
gkistanova committed rZORG425eeb1bf21b: Some code cleaning for LLDBBuilder.getLLDBCMakeBuildFactory. (authored by gkistanova).
Some code cleaning for LLDBBuilder.getLLDBCMakeBuildFactory.
Oct 30 2019, 4:07 PM
gkistanova committed rZORG54d5d91270e1: Fix the default build and install directories in LLVMBuildFactory. (authored by gkistanova).
Fix the default build and install directories in LLVMBuildFactory.
Oct 30 2019, 1:25 PM

Oct 29 2019

gkistanova committed rZORGd755ff9ed86f: Added support for git/github to OpenMPBuilder. (authored by gkistanova).
Added support for git/github to OpenMPBuilder.
Oct 29 2019, 6:16 AM

Oct 26 2019

gkistanova accepted D69291: Hide LLVM Lab internals by always pointing changes to github.com/llvm..

Thanks. This should help to avoid any possible confusion.

Oct 26 2019, 6:14 PM · Restricted Project, Restricted Project
gkistanova accepted D69467: Added support for git/github to SanitizerBuilder.

LGTM

Oct 26 2019, 6:14 PM · Restricted Project, Restricted Project
gkistanova accepted D69359: Added a new llvm expensive check builder on Linux Ubuntu platform. .

Indeed, we need more builders with expensive checks!

Oct 26 2019, 6:14 PM · Restricted Project, Restricted Project

Oct 21 2019

gkistanova committed rL375482: Cosmetic. NFC..
Cosmetic. NFC.
Oct 21 2019, 9:46 PM
gkistanova committed rL375481: Removed dependency on compiler-rt for llvm-clang-lld-x86_64-scei-ps4-* builders..
Removed dependency on compiler-rt for llvm-clang-lld-x86_64-scei-ps4-* builders.
Oct 21 2019, 9:46 PM
gkistanova committed rL375479: Check out LNT and test-sute under test directory by default..
Check out LNT and test-sute under test directory by default.
Oct 21 2019, 9:46 PM

Oct 19 2019

gkistanova committed rL375353: Handle is_legacy_mode in ClangLTOBuilder. Refactored to simplify the code..
Handle is_legacy_mode in ClangLTOBuilder. Refactored to simplify the code.
Oct 19 2019, 8:52 PM
gkistanova committed rL375336: Handle is_legacy_mode in LLDPerformanceTestsuite..
Handle is_legacy_mode in LLDPerformanceTestsuite.
Oct 19 2019, 1:33 AM

Oct 18 2019

gkistanova committed rL375331: Added the step name param to LLVMBuildFactory.addGetSourcecodeForProject..
Added the step name param to LLVMBuildFactory.addGetSourcecodeForProject.
Oct 18 2019, 11:34 PM
gkistanova committed rL375330: Added zorg to the list of SVN projects..
Added zorg to the list of SVN projects.
Oct 18 2019, 11:34 PM
gkistanova committed rL375268: Apply defaut cmake flags to ABITestsuitBuilder..
Apply defaut cmake flags to ABITestsuitBuilder.
Oct 18 2019, 11:26 AM

Oct 17 2019

gkistanova committed rL375205: Add LLVMGitPoller to listen for changes in the monorepo..
Add LLVMGitPoller to listen for changes in the monorepo.
Oct 17 2019, 10:56 PM
gkistanova committed rL375204: Separate automatic schedulers for builders depending on is_legacy_mode. .
Separate automatic schedulers for builders depending on is_legacy_mode.
Oct 17 2019, 10:48 PM
gkistanova accepted D69159: Separate automatic schedulers for builders depending on is_legacy_mode. .

LGTM

Oct 17 2019, 10:48 PM · Restricted Project, Restricted Project
gkistanova committed rL375202: Refactored ClangBuilde.getClangCMakeBuildFactory and ClangBuilde..
Refactored ClangBuilde.getClangCMakeBuildFactory and ClangBuilde.
Oct 17 2019, 10:33 PM
gkistanova accepted D69158: Refactored ClangBuilde.getClangCMakeBuildFactory and ClangBuilde.getClangCMakeGCSBuildFactory to support github..

LGTM

Oct 17 2019, 10:33 PM · Restricted Project, Restricted Project
gkistanova committed rL375201: Added LLVMPoller to work with github..
Added LLVMPoller to work with github.
Oct 17 2019, 10:25 PM