Page MenuHomePhabricator

gkistanova (Galina)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 22 2013, 2:32 PM (430 w, 3 d)

Recent Activity

Fri, Jun 18

gkistanova updated subscribers of D104467: [M68k] Add new worker suse-gary-m68k-cross for Linux 32-bit M68k.

The patch has been committed on your behalf.

Fri, Jun 18, 3:50 PM
gkistanova committed rZORGd1284d3eadb9: [M68k] Add new worker suse-gary-m68k-cross for Linux 32-bit M68k (authored by glaubitz).
[M68k] Add new worker suse-gary-m68k-cross for Linux 32-bit M68k
Fri, Jun 18, 3:41 PM
gkistanova closed D104467: [M68k] Add new worker suse-gary-m68k-cross for Linux 32-bit M68k.
Fri, Jun 18, 3:41 PM

Thu, Jun 17

gkistanova added a comment to D104467: [M68k] Add new worker suse-gary-m68k-cross for Linux 32-bit M68k.

Do you need a help with the commit?

Thu, Jun 17, 5:08 PM
gkistanova added a comment to D104467: [M68k] Add new worker suse-gary-m68k-cross for Linux 32-bit M68k.

The staging is ready for you. Please feel free to commit.

Thu, Jun 17, 5:06 PM
gkistanova accepted D103199: Add flang-x86_64-windows builder..

LGTM

Thu, Jun 17, 12:25 PM · Restricted Project, Restricted Project
gkistanova accepted D104467: [M68k] Add new worker suse-gary-m68k-cross for Linux 32-bit M68k.

Please feel free to connect to the staging.

Thu, Jun 17, 12:24 PM

Thu, May 27

gkistanova added a comment to D103199: Add flang-x86_64-windows builder..

Frankly, I don't like the idea of allowing failing tests, definitely not in production. I see what you want to achieve with this, though.

Thu, May 27, 10:55 PM · Restricted Project, Restricted Project
gkistanova committed rZORGf395d4d0c7d3: Removed abandoned lldb-sphinx-docs builder. (authored by gkistanova).
Removed abandoned lldb-sphinx-docs builder.
Thu, May 27, 5:28 PM

May 20 2021

gkistanova committed rZORGfbffb6400d33: Limit the number of parallel link jobs for the full LTO rerlease builder. (authored by gkistanova).
Limit the number of parallel link jobs for the full LTO rerlease builder.
May 20 2021, 4:13 PM
gkistanova committed rZORGbf146f5f2d31: Limit the number of parallel link jobs for the full LTO builder. (authored by gkistanova).
Limit the number of parallel link jobs for the full LTO builder.
May 20 2021, 4:10 PM

May 19 2021

gkistanova added inline comments to D101268: [Zorg][OpenMP] Add CUDA offloading worker..
May 19 2021, 12:56 PM · Restricted Project

May 18 2021

gkistanova committed rZORG69e37a9fe8b7: Fixed undefined runtime_projects in OpenMPBuilder. (authored by gkistanova).
Fixed undefined runtime_projects in OpenMPBuilder.
May 18 2021, 8:39 PM
gkistanova committed rZORG6ca77ac1f512: Run only 1 build at a time for heavily loaded workers. (authored by gkistanova).
Run only 1 build at a time for heavily loaded workers.
May 18 2021, 8:38 PM
gkistanova accepted D102741: Update configuration for Arm/Aarch64 cross Windows to Linux toolchan builders..

LGTM

May 18 2021, 8:24 PM

May 17 2021

gkistanova accepted D91945: Enable retry on failed git operations.

Did you analyze what's the most often reason of git fetch failures? Shall we also set clobberOnFailure to escalate a clone?

May 17 2021, 10:12 PM
gkistanova accepted D102626: [PowerPC] Removed `-DLLVM_ENABLE_PROJECTS=flang` to allow flang bot to build flang again.

LGTM

May 17 2021, 10:05 PM · Restricted Project, Restricted Project
gkistanova committed rZORG8bbdd35de2d2: Added missing comma in clang-ppc64le-rhel builder configuration. (authored by gkistanova).
Added missing comma in clang-ppc64le-rhel builder configuration.
May 17 2021, 8:42 PM

May 13 2021

gkistanova added a comment to D100674: Add ziglang builder.

If this is fine with you, let's finish this patch first, stage the builder to make sure it is reliably green, then you could move it to the production build bot and add to the release_builders.py.

May 13 2021, 10:52 AM

May 12 2021

gkistanova added a comment to D100674: Add ziglang builder.

Also I had questions on about if I needed to rebuild llvm, clang and lld-devel to test; is it possible to use what was built beforehand by previous tests on the same commit ?

May 12 2021, 11:09 PM
gkistanova added a comment to D102331: [zorg] Enable timeout for getClangCMakeBuildFactory.

And I was even looking at it there!

May 12 2021, 4:49 PM
gkistanova accepted D102319: [zorg] Remove flang-aarch64-ubuntu-out-of-tree-new-driver.

But please wait for the patch Andrzej mentioned before committing.

May 12 2021, 4:46 PM · Restricted Project, Restricted Project
gkistanova added a comment to D101717: [zorg] Parse Ninja output..

LitTestCommand parses LIT logs only and is not intended to parse anything else, AnnotatedCommand parses annotations only and is not intended to parse anything else. NinjaCommand could build (build logs), test (LIT logs), install (install logs).

May 12 2021, 4:46 PM · Restricted Project
gkistanova added a comment to D100674: Add ziglang builder.

Hello Brice,

May 12 2021, 4:36 PM
gkistanova accepted D101199: [PowerPC] [Zorg] Change ppc64le-rhel bot to unified tree instead.

Before committing, could you make sure you are based on the current UnifiedTreeBuilder and LLVMBuildFactory, please?
If I remember the context correctly, you may need to specify enable_runtimes="auto", since the default behavior has been changed in https://reviews.llvm.org/rZORGf7b888457641 per request.

May 12 2021, 4:27 PM · Restricted Project, Restricted Project
gkistanova added a comment to D102331: [zorg] Enable timeout for getClangCMakeBuildFactory.

I would not characterize the ninja invocation doing the build as a "single command".

May 12 2021, 3:50 PM
gkistanova added a comment to D102331: [zorg] Enable timeout for getClangCMakeBuildFactory.

So, your builder does not send anything to TTY for more than 20 minutes during a normal regular build. Meaning that a single commands takes longer than 20 minutes to execute.

May 12 2021, 1:20 PM

May 10 2021

gkistanova added a comment to D101717: [zorg] Parse Ninja output..

Almost forgot to mention.

May 10 2021, 11:53 PM · Restricted Project
gkistanova accepted D101268: [Zorg][OpenMP] Add CUDA offloading worker..

LGTM

May 10 2021, 10:58 PM · Restricted Project
gkistanova added a comment to D101717: [zorg] Parse Ninja output..

Sorry for the delay.

May 10 2021, 10:40 PM · Restricted Project

May 4 2021

gkistanova added a comment to rZORG2ed0c6ae25a4: Added enable_runtimes and enable_projects to LLVMBuildFactory..

Anyway, the default has been changed in https://reviews.llvm.org/rZORGf7b888457641 to not use LLVM_ENABLE_RUNTIMES unless explicitly requested.
That should address your concern.
Thanks again, Michael.

May 4 2021, 5:45 PM
gkistanova committed rZORGf7b888457641: Added "auto" for LLVMBuildFactory enable_runtimes arg; changed default to not… (authored by gkistanova).
Added "auto" for LLVMBuildFactory enable_runtimes arg; changed default to not…
May 4 2021, 5:41 PM
gkistanova added a comment to rZORG2ed0c6ae25a4: Added enable_runtimes and enable_projects to LLVMBuildFactory..

This is why I asked if you know what builders should build without using LLVM_ENABLE_RUNTIMES but now they don't.
The change we are discussing does not necessarily mean that LLVM_ENABLE_RUNTIMES is always engaged.

May 4 2021, 5:31 PM
gkistanova added a comment to rZORG2ed0c6ae25a4: Added enable_runtimes and enable_projects to LLVMBuildFactory..

To make sure I'll check the fix, could you point me to a particular builder or builders where you see the problem, please?

May 4 2021, 12:34 PM
gkistanova committed rZORG93900f5122cc: Revert "Support compatibility with buildbot 2.10." (authored by gkistanova).
Revert "Support compatibility with buildbot 2.10."
May 4 2021, 12:21 PM
gkistanova added a reverting change for rZORG3f44862c69dd: Support compatibility with buildbot 2.10.: rZORG93900f5122cc: Revert "Support compatibility with buildbot 2.10.".
May 4 2021, 12:21 PM
gkistanova added a reverting change for D95867: Support compatibility with buildbot 2.10.: rZORG93900f5122cc: Revert "Support compatibility with buildbot 2.10.".
May 4 2021, 12:21 PM
gkistanova added a comment to rZORG2ed0c6ae25a4: Added enable_runtimes and enable_projects to LLVMBuildFactory..

Hello Michael,

May 4 2021, 12:20 PM

Apr 30 2021

gkistanova added a comment to D101268: [Zorg][OpenMP] Add CUDA offloading worker..

Thanks for the patch, Michael!

Apr 30 2021, 6:56 PM · Restricted Project
gkistanova added a comment to D101199: [PowerPC] [Zorg] Change ppc64le-rhel bot to unified tree instead.

Please see my comments inline.

Apr 30 2021, 12:40 AM · Restricted Project, Restricted Project

Apr 29 2021

gkistanova committed rZORGa138f265e7a4: Changed LibcxxAndAbiBuilder to use LLVMBuildFactory enable_projects and… (authored by gkistanova).
Changed LibcxxAndAbiBuilder to use LLVMBuildFactory enable_projects and…
Apr 29 2021, 11:06 PM
gkistanova committed rZORG1a77335dfe7c: Added support for LLVM_ENABLE_RUNTIMES to ClangLTOBuilder. (authored by gkistanova).
Added support for LLVM_ENABLE_RUNTIMES to ClangLTOBuilder.
Apr 29 2021, 11:03 PM
gkistanova committed rZORG4762fe8e3c66: Documentation builds do not support LLVM_ENABLE_RUNTIMES. (authored by gkistanova).
Documentation builds do not support LLVM_ENABLE_RUNTIMES.
Apr 29 2021, 11:02 PM
gkistanova committed rZORG90c0b74c2ee5: Added support for LLVM_ENABLE_RUNTIMES to UnifiedTreeBuilder. (authored by gkistanova).
Added support for LLVM_ENABLE_RUNTIMES to UnifiedTreeBuilder.
Apr 29 2021, 11:00 PM
gkistanova committed rZORG2ed0c6ae25a4: Added enable_runtimes and enable_projects to LLVMBuildFactory. (authored by gkistanova).
Added enable_runtimes and enable_projects to LLVMBuildFactory.
Apr 29 2021, 10:59 PM
gkistanova committed rZORGde05587afe1c: Bumped urllib3 from 1.26.3 to 1.26.4. (authored by gkistanova).
Bumped urllib3 from 1.26.3 to 1.26.4.
Apr 29 2021, 10:54 PM
gkistanova added a comment to D100497: Build and test project depends on project enabled in LibcxxAndAbiBuilder.

This patch introduced a bug.

Apr 29 2021, 11:59 AM
gkistanova committed rZORG9710f7832a34: Fixed bug introduced by D100497 - local variable jobs_flag referenced before… (authored by gkistanova).
Fixed bug introduced by D100497 - local variable jobs_flag referenced before…
Apr 29 2021, 11:49 AM
gkistanova accepted D101345: [zorg] Add buildbot for Synopsys ARC.

Looks good with a nitpick.

Apr 29 2021, 12:51 AM · Restricted Project

Apr 22 2021

gkistanova accepted D99894: [zorg] Add buildbot for HIP.

LGTM

Apr 22 2021, 9:50 PM
gkistanova added a comment to D99894: [zorg] Add buildbot for HIP.

Looks good with a nitpick. Please see my comment inline.

Apr 22 2021, 12:31 PM
gkistanova accepted D100666: [zorg] Support other relative scripts in AnnotatedBuilder.

Thanks! Looks good now.

Apr 22 2021, 12:22 AM
gkistanova accepted D100749: Remove 3 Flang workers/builders.

Yep. The raw diff looks good.

Apr 22 2021, 12:15 AM
gkistanova requested changes to D100431: [Zorg] Change make to ninja instead for Clang RHEL buildbot.

Sorry for reverting your patches, but I do not see a quick and easy way to fix the problems it has introduced.

Apr 22 2021, 12:04 AM · Restricted Project

Apr 21 2021

gkistanova added a reverting change for rZORG4b8974b63dcc: [PowerPC] Allow the PowerPC RHEL buildbot to use cmake with test-suite: rZORG6eff27204f3e: Revert "[PowerPC] Allow the PowerPC RHEL buildbot to use cmake with test-suite".
Apr 21 2021, 11:51 PM
gkistanova added a reverting change for D99097: [zorg] [PowerPC] Allow the PowerPC RHEL buildbot to use cmake with test-suite instead of LNT: rZORG6eff27204f3e: Revert "[PowerPC] Allow the PowerPC RHEL buildbot to use cmake with test-suite".
Apr 21 2021, 11:51 PM · Restricted Project, Restricted Project
gkistanova committed rZORG6eff27204f3e: Revert "[PowerPC] Allow the PowerPC RHEL buildbot to use cmake with test-suite" (authored by gkistanova).
Revert "[PowerPC] Allow the PowerPC RHEL buildbot to use cmake with test-suite"
Apr 21 2021, 11:51 PM
gkistanova added a reverting change for rZORGf785f4216432: [Zorg] Change make to ninja instead for Clang RHEL buildbot: rZORG930e06c67422: Revert "[Zorg] Change make to ninja instead for Clang RHEL buildbot".
Apr 21 2021, 11:51 PM
gkistanova added a reverting change for D100431: [Zorg] Change make to ninja instead for Clang RHEL buildbot: rZORG930e06c67422: Revert "[Zorg] Change make to ninja instead for Clang RHEL buildbot".
Apr 21 2021, 11:51 PM · Restricted Project
gkistanova committed rZORG930e06c67422: Revert "[Zorg] Change make to ninja instead for Clang RHEL buildbot" (authored by gkistanova).
Revert "[Zorg] Change make to ninja instead for Clang RHEL buildbot"
Apr 21 2021, 11:51 PM
gkistanova reopened D100431: [Zorg] Change make to ninja instead for Clang RHEL buildbot.

This patch has broken zorg. I reverted the both this one and D99097 as they seems closely related, and D100431 fixes D99097.

Apr 21 2021, 11:49 PM · Restricted Project

Apr 20 2021

gkistanova added a comment to D100749: Remove 3 Flang workers/builders.

Looks good with a nit pick.
Could you clean the patch off of the unrelated changes, please?

Apr 20 2021, 2:45 PM

Apr 19 2021

gkistanova requested changes to D100749: Remove 3 Flang workers/builders.

Could you also clean up config/workers.py and config/status.py from the unused now workers, please?

Apr 19 2021, 9:41 PM

Apr 15 2021

gkistanova added a comment to D99894: [zorg] Add buildbot for HIP.

No. Cuda builders got that in the code base as a temporary solution while they are working on their annotated script. Exactly the same arguments as yours. And I see that being confusing, and don't think it worth it after all.

Apr 15 2021, 4:18 PM

Apr 7 2021

gkistanova committed rZORGa9e099490c78: Revert "Respect jobs property for LIT tests in UnifiedTreeBuilder." (authored by gkistanova).
Revert "Respect jobs property for LIT tests in UnifiedTreeBuilder."
Apr 7 2021, 12:40 PM
gkistanova added a reverting change for rZORG13c3c22377e3: Respect jobs property for LIT tests in UnifiedTreeBuilder.: rZORGa9e099490c78: Revert "Respect jobs property for LIT tests in UnifiedTreeBuilder.".
Apr 7 2021, 12:40 PM
gkistanova added a comment to D97389: added section on CI system.

Thanks for updating the LLVM Developer Policy, Christian.
It looks good with a couple nit picks.

Apr 7 2021, 12:02 PM · Restricted Project

Apr 6 2021

gkistanova accepted D97326: [zorg] Adjust libcxx buildbot config on AIX.

LGTM

Apr 6 2021, 12:52 PM
gkistanova accepted D99985: Enable build_standalone in LibcxxAndAbiBuilder.

LGTM

Apr 6 2021, 12:51 PM
gkistanova added a comment to D99894: [zorg] Add buildbot for HIP.

Everything else looks Ok.

Apr 6 2021, 10:26 AM
gkistanova added a comment to D97326: [zorg] Adjust libcxx buildbot config on AIX.

Looks fine.

Apr 6 2021, 10:15 AM

Mar 25 2021

gkistanova accepted D97326: [zorg] Adjust libcxx buildbot config on AIX.

LGTM

Mar 25 2021, 12:02 PM

Mar 24 2021

gkistanova added a comment to D98645: [zorg] Allow SanitizerBuilder.getSanitizerBuildFactory to accept extra args.

Hm. This is weird.
I see a wrong patch assigned to this review now.,

Mar 24 2021, 3:30 PM · Restricted Project
gkistanova accepted D98645: [zorg] Allow SanitizerBuilder.getSanitizerBuildFactory to accept extra args.

Thanks, Albion!
Looks much better now.

Mar 24 2021, 3:22 PM · Restricted Project
gkistanova accepted D98647: [zorg][PowerPC] Limit number of threads to 256 on ppc64le-sanitizer bot.

LGTM

Mar 24 2021, 1:57 PM · Restricted Project
gkistanova accepted D99097: [zorg] [PowerPC] Allow the PowerPC RHEL buildbot to use cmake with test-suite instead of LNT.

LGTM

Mar 24 2021, 1:45 PM · Restricted Project, Restricted Project
gkistanova accepted D99216: [libc] Add a full build worker and two builders to run on it..

LGTM

Mar 24 2021, 1:42 PM
gkistanova added a comment to D97326: [zorg] Adjust libcxx buildbot config on AIX.

Almost there.
One problem to fix.

Mar 24 2021, 1:40 PM

Mar 23 2021

gkistanova committed rZORG13c3c22377e3: Respect jobs property for LIT tests in UnifiedTreeBuilder. (authored by gkistanova).
Respect jobs property for LIT tests in UnifiedTreeBuilder.
Mar 23 2021, 11:01 AM

Mar 20 2021

gkistanova added a comment to D97326: [zorg] Adjust libcxx buildbot config on AIX.

I have added the support you need to UnifiedTreeBuilder.

Mar 20 2021, 11:57 AM
gkistanova committed rZORG8f5c30cb3af8: Added support for a new src_to_build_dir argument to UnifiedTreeBuilder to… (authored by gkistanova).
Added support for a new src_to_build_dir argument to UnifiedTreeBuilder to…
Mar 20 2021, 11:48 AM
gkistanova committed rZORG5a63cfb04642: Added support for a new src_to_build_dir argument to LLVMBuildFactory to… (authored by gkistanova).
Added support for a new src_to_build_dir argument to LLVMBuildFactory to…
Mar 20 2021, 11:46 AM

Mar 19 2021

gkistanova accepted D98961: Add a mailer config for MLIR testing bots to Google build monitoring mailing-list.

LGTM

Mar 19 2021, 8:12 PM
gkistanova added a comment to D98645: [zorg] Allow SanitizerBuilder.getSanitizerBuildFactory to accept extra args.

There are few comments for the buildbot part.

Mar 19 2021, 2:10 PM · Restricted Project

Mar 12 2021

gkistanova accepted D97943: [XCore] Build fewer components. Run 4 parallel jobs..

LGTM

Mar 12 2021, 10:31 PM

Mar 2 2021

gkistanova accepted D97607: Added openmp doxygen; increased the doxygent step timeout, as it could take a long time without anything in TTY..

LGTM

Mar 2 2021, 7:49 PM · Restricted Project
gkistanova accepted D97626: Add check-flang option to some of the Flang builders..

LGTM

Mar 2 2021, 7:49 PM
gkistanova accepted D97678: Add Flang builder for latest gcc..

Looks good with a couple of nit picks.
Please see my comments in line.

Mar 2 2021, 7:48 PM
gkistanova accepted D97685: Add Flang builder for latest llvm and libc++..

Looks good with a couple nit picks.
Please see my comments in line.

Mar 2 2021, 7:45 PM
gkistanova accepted D97270: Add buildbot for Clang for XCore target on Ubuntu host..

It is good with a couple of small things to address.

Mar 2 2021, 7:37 PM
gkistanova requested changes to D97326: [zorg] Adjust libcxx buildbot config on AIX.

It seems this patch needs more attention.
Please see my comments above.

Mar 2 2021, 6:15 PM
gkistanova reopened D97326: [zorg] Adjust libcxx buildbot config on AIX.

I'm not sure I follow what are you trying to achieve by changing the src_root.

Mar 2 2021, 6:14 PM
gkistanova committed rZORG4cd2689758e9: Fixed mistype in LibcxxAndAbiBuilder.py introduced by… (authored by gkistanova).
Fixed mistype in LibcxxAndAbiBuilder.py introduced by…
Mar 2 2021, 5:43 PM
gkistanova accepted D97492: Enable mlir integration tests on the mlir-nvidia bot..

Christian, do you need a help with committing this patch? You should be good if you have LLVM commit permissions, but please let me know if you want me to commit.

Mar 2 2021, 12:08 PM

Feb 24 2021

gkistanova committed rZORG388283cab6e6: Fixed misspelled builder name for e-mail notifications. (authored by gkistanova).
Fixed misspelled builder name for e-mail notifications.
Feb 24 2021, 7:19 PM

Feb 21 2021

gkistanova accepted D97180: Add myself to be notified for sie-linux-builder failures..

LGTM

Feb 21 2021, 11:27 PM · Restricted Project
gkistanova accepted D96814: [zorg] Add runtimes buildbot for AIX.

LGTM.

Feb 21 2021, 11:26 PM
gkistanova accepted D96857: Add flang release buildbot..

LGTM

Feb 21 2021, 11:25 PM
gkistanova accepted D96858: Add flang release with assertions buildbot..

LGTM

Feb 21 2021, 11:25 PM
gkistanova committed rZORGc8a67928ed44: One GitHubStatusPush reporter is enough for our needs. (authored by gkistanova).
One GitHubStatusPush reporter is enough for our needs.
Feb 21 2021, 11:02 PM