By the way, we had a conditional cmake run before, and removed that because of some dependencies were not forced by ninja.
https://github.com/llvm/llvm-zorg/commit/a9f92433031343bfbb6b2160e2829b89d39ab461

May 3 2022, 12:59 PM · Restricted Project

gkistanova accepted D124864: [mlir, win] Set LLVM_ENABLE_WERROR=ON on the mlir-windows bot.

LGTM.

May 3 2022, 12:57 PM · Restricted Project

May 2 2022

gkistanova added a comment to D123759: UnifiedTreeBuilder: only add cmake steps if clean build is requested.

This does not handle the case when incremental build starts on empty build directory.

May 2 2022, 10:46 AM · Restricted Project

gkistanova accepted D124706: [libc] Extend libc's linux script to handle runtimes build..

LGTM.

May 2 2022, 10:45 AM · Restricted Project

gkistanova accepted D124727: [BOLT] Add MSVC builder.

LGTM.

May 2 2022, 10:43 AM · Restricted Project

Apr 23 2022

gkistanova accepted D124172: Added worker and placeholder for standalone-build-x86_64 builder.

Thanks, Konrad!

Apr 23 2022, 10:53 AM · Restricted Project

gkistanova accepted D124329: [BOLT] Add AArch64 builder and worker.

When you will do the follow up changes, you may want to remove the clang version number from the name of the builder and from the paths. Using update-alternatives or something similar to manage the versions of the system tool chain might be a good idea. This way you will not need to make changes to zorg every time you update the tool chain.

Apr 23 2022, 10:52 AM · Restricted Project

gkistanova added inline comments to D124172: Added worker and placeholder for standalone-build-x86_64 builder.

Apr 23 2022, 12:27 AM · Restricted Project

gkistanova accepted D123762: [libc] Add a runtimes build builder to the libc x86_64 debian worker..

LGTM

Apr 23 2022, 12:26 AM · Restricted Project

gkistanova accepted D123060: Changing number max number of build for ppc64le-flang-mlir-rhel-test.

LGTM.
Please feel free to connect the new workers to the staging.

Apr 23 2022, 12:23 AM · Restricted Project

gkistanova accepted D123542: [libc] Add an aarch64 fullbuild builder on the existing aarch64 worker..

LGTM

Apr 23 2022, 12:16 AM · Restricted Project

gkistanova accepted D123282: [Fuchsia] Omit the list of projects and runtimes.

LGTM with a nit pick.

Apr 23 2022, 12:15 AM · Restricted Project

Apr 12 2022

gkistanova added a comment to D123060: Changing number max number of build for ppc64le-flang-mlir-rhel-test.

Depending on the build requests queues any combination of 2 concurrent builds is possible. Yes, it is possible to have 2 ppc64le-flang-rhel-clang builds running and ppc64le-mlir-rhel-clang builds waiting.

Apr 12 2022, 9:57 PM · Restricted Project

Apr 4 2022

gkistanova added a comment to D123060: Changing number max number of build for ppc64le-flang-mlir-rhel-test.

Hello Kamau,

Apr 4 2022, 10:35 PM · Restricted Project

Apr 2 2022

gkistanova committed rZORG1152743906d0: Sorted out ccache-related environment variables. (authored by gkistanova).

Sorted out ccache-related environment variables.

Apr 2 2022, 1:28 PM · Restricted Project

Mar 29 2022

gkistanova committed rZORG49bce09a9987: Added missing commas. (authored by gkistanova).

Added missing commas.

Mar 29 2022, 8:04 PM · Restricted Project

gkistanova committed rZORGd3f8451443cd: ROCm test support for buildbot. (authored by pcf000).

ROCm test support for buildbot.

Mar 29 2022, 6:09 PM · Restricted Project

gkistanova closed D122168: ROCm test support for buildbot..

Mar 29 2022, 6:09 PM · Restricted Project

Mar 25 2022

gkistanova accepted D122451: [Buildbot] Add two new workers for the cross win-to-linux Arm/Aarch64 release builders..

LGTM.

Mar 25 2022, 9:43 AM · Restricted Project

Mar 24 2022

gkistanova added a comment to D122168: ROCm test support for buildbot..

I can commit on your behalf.
But before that, I'll need a password for the new worker. You can either send it to me directly, or I can assign a random one and send it to you.
Please let me know what you prefer.

Mar 24 2022, 11:59 AM · Restricted Project

Mar 22 2022

gkistanova accepted D120245: Use tooling (pip-compile) to manage dependencies.

It was staged long enough without any discovered issues.
Thanks, Konrad!
Please feel free to commit. I'll follow up with some changes to clean the dependencies.

Mar 22 2022, 4:34 PM · Restricted Project, Restricted Project

gkistanova accepted D122168: ROCm test support for buildbot..

LGTM

Mar 22 2022, 1:07 PM · Restricted Project

gkistanova added a comment to D122168: ROCm test support for buildbot..

I'd just make a new clean diff with only related changes and upload it through the Phabricator WebUI. This might be more controllable and straight forward.

Mar 22 2022, 11:51 AM · Restricted Project

gkistanova added a comment to D122235: [mlgo] Add worker watch notification.

Almost missed.

Mar 22 2022, 11:13 AM · Restricted Project

gkistanova accepted D122235: [mlgo] Add worker watch notification.

LGTM with a nitpick.
Please feel free to commit with removed watchedWorkers arg.

Mar 22 2022, 11:12 AM · Restricted Project

gkistanova added a comment to D122168: ROCm test support for buildbot..

Did you do that the other way around? :)
I see only removed trailing white spaces in this patch now.

Mar 22 2022, 11:01 AM · Restricted Project

Mar 21 2022

gkistanova added a comment to D122168: ROCm test support for buildbot..

Thanks for the patch, Paul!

Mar 21 2022, 11:08 PM · Restricted Project

Mar 4 2022

gkistanova accepted D121031: [Buildbot] Use 'TOOLCHAIN_TARGET_TRIPLE' instead of `TARGET_TRIPLE` for Win to Linux Arm cross builders..

LGTM.

Mar 4 2022, 5:05 PM · Restricted Project

Mar 3 2022

gkistanova accepted D120957: [Buildbot] Enable zlib support for Windows to Linux cross toolchain builders..

LGTM.

Mar 3 2022, 6:30 PM · Restricted Project

gkistanova accepted D120955: [Buildbot] Remove outdated LLVM_AR parameter for Windows to Linux Cross toolchain builders..

LGTM

Mar 3 2022, 6:29 PM · Restricted Project

Mar 1 2022

gkistanova accepted D120653: ClangBuilder: Use list of checks instead of boolean. NFCI.

Thanks, Diana!
LGTM.

Mar 1 2022, 8:36 AM · Restricted Project, Restricted Project

Feb 28 2022

gkistanova closed D120035: Notify me when the SIE builders running cross-project-tests fail.

Feb 28 2022, 9:18 PM · Restricted Project

gkistanova committed rZORGa3055e829af0: Notify when the SIE builders running cross-project-tests fail. (authored by gkistanova).

Notify when the SIE builders running cross-project-tests fail.

Feb 28 2022, 9:18 PM

gkistanova requested changes to D120653: ClangBuilder: Use list of checks instead of boolean. NFCI.

List of checks is a good idea.

Feb 28 2022, 9:40 AM · Restricted Project, Restricted Project

gkistanova accepted D120654: WoA: Change target triple & try_compile config.

LGTM

Feb 28 2022, 9:07 AM · Restricted Project

gkistanova accepted D120655: WoA: Enable check-flang on clang-arm64-windows-msvc.

LGTM

Feb 28 2022, 9:00 AM · Restricted Project, Restricted Project, Restricted Project

Feb 23 2022

gkistanova added a comment to D120245: Use tooling (pip-compile) to manage dependencies.

I was planning to start using the pip-tools, but you bet me to it.

Feb 23 2022, 11:37 AM · Restricted Project, Restricted Project

gkistanova accepted D120274: Add LLDB AArch64 Windows buildbot.

Thanks!
LGTM.

Feb 23 2022, 10:24 AM · Restricted Project

Feb 22 2022

gkistanova accepted D120293: [Buildbot] Updated configuration for Armv7/Aarch64 Win-x-Linux cross builders..

LGTM

Feb 22 2022, 1:32 PM · Restricted Project

gkistanova added a comment to D120274: Add LLDB AArch64 Windows buildbot.

Are you sure you don’t want to skip watchpoint tests? They seem unreliable on Windows.

Feb 22 2022, 1:31 PM · Restricted Project

Feb 18 2022

gkistanova accepted D120035: Notify me when the SIE builders running cross-project-tests fail.

LGTM

Feb 18 2022, 8:14 AM · Restricted Project

Feb 17 2022

gkistanova added inline comments to D120035: Notify me when the SIE builders running cross-project-tests fail.

Feb 17 2022, 8:25 PM · Restricted Project

Feb 16 2022

gkistanova committed rZORG4ce46538a6d7: Bumped twisted to 22.1.0. (authored by gkistanova).

Bumped twisted to 22.1.0.

Feb 16 2022, 8:25 PM

gkistanova accepted D111234: [zorg] [PowerPC] Fix passing cmake args to sanitizer-ppc64le-linux bot..

Do you need help committing this change?

Feb 16 2022, 11:52 AM · Restricted Project

gkistanova accepted D119757: Enabling ccache for all ppc64le buildbots.

Thanks, Kamau!
LGTM.

Feb 16 2022, 11:48 AM · Restricted Project

Feb 15 2022

gkistanova accepted D119882: [buildbot] Enable CCACHE for all stages of ThinLTO WPD worker.

Thanks, Teresa!
LGTM

Feb 15 2022, 12:57 PM

Feb 5 2022

gkistanova committed rZORG1b485b5a9e82: Reduced verbosity of LLVMPoller logs. (authored by gkistanova).

Reduced verbosity of LLVMPoller logs.

Feb 5 2022, 1:35 PM

Feb 4 2022

gkistanova accepted D118881: Revert PS4 linux bot to original configuration and add cross-project-tests builder.

LGTM

Feb 4 2022, 9:31 AM · Restricted Project, Restricted Project

Feb 3 2022

gkistanova committed rZORGf63e09653974: Bumped sqlparse to 0.4.2, urllib3 to 1.26.8, treq to 22.1.0. (authored by gkistanova).

Bumped sqlparse to 0.4.2, urllib3 to 1.26.8, treq to 22.1.0.

Feb 3 2022, 9:30 PM

gkistanova committed rZORG6beec67c0441: Removed nersc-flang worker and flang-x86_64-linux builder. (authored by gkistanova).

Removed nersc-flang worker and flang-x86_64-linux builder.

Feb 3 2022, 11:28 AM

Jan 30 2022

gkistanova committed rZORGec91c988e9f6: Fixed --skip-category for lldb-x64-windows-ninja. (authored by gkistanova).

Fixed --skip-category for lldb-x64-windows-ninja.

Jan 30 2022, 1:18 PM

Jan 29 2022

gkistanova committed rZORG1a83a131c733: Added missing comma. (authored by gkistanova).

Added missing comma.

Jan 29 2022, 5:42 PM

Jan 27 2022

gkistanova accepted D118403: [lldb, win] Skip watchpoint tests on the Windows lldb bot.

LGTM with a nit.

Jan 27 2022, 1:01 PM

Jan 26 2022

gkistanova accepted D117267: [lldb] Add support for choosing which checks to run on lldb builders.

The patch looks good. Thanks, Stella!

Jan 26 2022, 9:59 PM

gkistanova accepted D117716: [zorg] Remove the clang-ppc64be-linux bot.

LGTM

Jan 26 2022, 9:47 PM

gkistanova accepted D117729: Update PS4 bot configurations.

LGTM

Jan 26 2022, 9:17 PM · Restricted Project

gkistanova added a comment to D117702: Install MLIR Python requirements on buildbot workers.

Thanks for the patch, Alex!

Jan 26 2022, 9:16 PM

Jan 20 2022

gkistanova committed rZORG548e2995baa3: Added thinlto-x86-64-bot2 worker; fixed emain notifier for clang-with-thin-lto… (authored by gkistanova).

Added thinlto-x86-64-bot2 worker; fixed emain notifier for clang-with-thin-lto…

Jan 20 2022, 3:52 PM

gkistanova committed rZORG3ae9516a2d32: Fixed the wrong arg name. (authored by gkistanova).

Fixed the wrong arg name.

Jan 20 2022, 11:32 AM

Jan 19 2022

gkistanova accepted D117212: Add Windows PS4 builder.

LGTM

Jan 19 2022, 9:07 AM · Restricted Project

Jan 17 2022

gkistanova accepted D107193: [Zorg] Honor clean_obj in WebUI..

LGTM

Jan 17 2022, 10:42 AM

Jan 15 2022

gkistanova added inline comments to D116972: [lldb] Run the test suite in verbose mode.

Jan 15 2022, 2:55 PM

Jan 14 2022

gkistanova added a comment to D117363: LLDB Windows x64 buildbot set lit -j8.

What about adding a separate parameter for the jobs for the tests? That way a different level of parallelism could be specified for build and test? That's the route I would have gone.

Jan 14 2022, 11:10 PM · Restricted Project

gkistanova added a comment to D117363: LLDB Windows x64 buildbot set lit -j8.

I think they should be set in just one place to make the code more readable.

I was about to suggest the same.

Jan 14 2022, 3:01 PM · Restricted Project

gkistanova added a comment to D117212: Add Windows PS4 builder.

Hi Douglas,

Jan 14 2022, 2:31 PM · Restricted Project

Jan 13 2022

gkistanova added a comment to D107193: [Zorg] Honor clean_obj in WebUI..

That is, if clean is set to False, the value of clean_obj does not matter, even if it is True and the build dir is not cleaned. This is what this patch intends to change.

Jan 13 2022, 1:16 PM