Page MenuHomePhabricator

gkistanova (Galina)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 22 2013, 2:32 PM (390 w, 6 d)

Recent Activity

Yesterday

gkistanova committed rZORG94e652786cb7: Changed to use cmake arguments to specify C and C++ compilers. (authored by gkistanova).
Changed to use cmake arguments to specify C and C++ compilers.
Thu, Sep 17, 7:06 PM

Thu, Sep 10

gkistanova committed rZORG29eb67693d9a: Cleaned status.py from old notifiers. (authored by gkistanova).
Cleaned status.py from old notifiers.
Thu, Sep 10, 11:13 PM
gkistanova committed rZORG97c8bbea257b: Removed unused code from LLDBBuilder. (authored by gkistanova).
Removed unused code from LLDBBuilder.
Thu, Sep 10, 9:06 PM
gkistanova committed rZORGd1f7315cc1aa: More builders.py cleaning. (authored by gkistanova).
More builders.py cleaning.
Thu, Sep 10, 9:03 PM
gkistanova committed rZORG3c45e09f5c09: Removed scei-ps4 builders. (authored by gkistanova).
Removed scei-ps4 builders.
Thu, Sep 10, 8:39 PM
gkistanova requested changes to D87125: Update recipe for flang-aarch64 slaves.

Hi Caroline,

Thu, Sep 10, 8:29 PM
gkistanova accepted D87156: Reduce a build path for clang-win-x-aarch64 builder..

LGTM

Thu, Sep 10, 8:24 PM · Restricted Project
gkistanova accepted D87186: Add ARM64 Windows on Arm buildbots.

Thanks, Maxim! Looks good.
Please feel free to commit.

Thu, Sep 10, 4:18 PM

Wed, Sep 9

gkistanova committed rZORG0687cd500d45: Removed abandoned builders. (authored by gkistanova).
Removed abandoned builders.
Wed, Sep 9, 11:47 PM
gkistanova committed rZORG31bc43fb6edc: Removed clang-lld-x86_64-2stage builder. (authored by gkistanova).
Removed clang-lld-x86_64-2stage builder.
Wed, Sep 9, 11:47 PM
gkistanova committed rZORGdf6e2e274d03: Removed netbsd-amd64 since it is offline since August-10-2020. (authored by gkistanova).
Removed netbsd-amd64 since it is offline since August-10-2020.
Wed, Sep 9, 9:52 PM

Tue, Sep 8

gkistanova added a comment to D87293: [GVN] Fix undef incoming value for phi node when new loop exit block created..

The repository for this diff is specified as Zorg, which does not seem right.

Tue, Sep 8, 3:45 PM · Restricted Project
gkistanova requested changes to D87085: Add flang out of tree buildbot.

Thanks for working on this, Diana!

Tue, Sep 8, 3:39 PM · Restricted Project
gkistanova added a comment to D87330: [zorg] [PowerPC] Limit number of threads to 256 on ppc64le-sanitizer bot.

Unfortunately, SanitizerBuilder.getSanitizerBuildFactory does not accept accept extra_configure_args argument and does not pass it down to the script.

Tue, Sep 8, 3:13 PM · Restricted Project

Sun, Sep 6

gkistanova committed rZORG45ff0650596c: Removed redundant code. (authored by gkistanova).
Removed redundant code.
Sun, Sep 6, 11:43 PM

Thu, Sep 3

gkistanova accepted D87100: Remove #llvm buildbot as it doesn't scale to the size of the project anymore.

LGTM

Thu, Sep 3, 9:03 PM

Wed, Sep 2

gkistanova committed rZORGf8cd579ea9f9: Removed unused code. (authored by gkistanova).
Removed unused code.
Wed, Sep 2, 9:18 PM
gkistanova accepted D87058: Run libc++ tests on AArch64 Windows-to-Linux cross builders.

LGTM

Wed, Sep 2, 8:16 PM

Mon, Aug 31

gkistanova accepted D86868: Fix typos in builder descriptions.

Thanks for fixing this!

Mon, Aug 31, 2:15 PM
gkistanova accepted D85820: Use find_library for ncurses.

Statically linked LLVM + LLD builds with this patch.

Mon, Aug 31, 2:13 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Aug 27

gkistanova added a comment to D86521: Revert "Use find_library for ncurses".

Fair enough. Reverted.
https://github.com/llvm/llvm-project/commit/cdcb9ab10e53ff08293915af3cd897c42112bcc5

Thu, Aug 27, 6:01 PM · Restricted Project, Restricted Project, Restricted Project
gkistanova added a reverting change for rGa52173a3e565: Use find_library for ncurses: rGcdcb9ab10e53: Revert "Use find_library for ncurses".
Thu, Aug 27, 5:58 PM
gkistanova added a reverting change for rG495f91fd33d4: [CMake] Don't look for terminfo libs when LLVM_ENABLE_TERMINFO=OFF: rGcdcb9ab10e53: Revert "Use find_library for ncurses".
Thu, Aug 27, 5:58 PM
gkistanova added a reverting change for rG8e4acb82f71a: [CMake] Fix OCaml build failure because of absolute path in system libs: rGcdcb9ab10e53: Revert "Use find_library for ncurses".
Thu, Aug 27, 5:58 PM
gkistanova added a reverting change for rG76bf26236f6f: [CMake] Always mark terminfo as unavailable on Windows: rGcdcb9ab10e53: Revert "Use find_library for ncurses".
Thu, Aug 27, 5:58 PM
gkistanova added a reverting change for D86134: Fix OCaml build failure because of absolute path in system libs: rGcdcb9ab10e53: Revert "Use find_library for ncurses".
Thu, Aug 27, 5:58 PM · Restricted Project
gkistanova added a reverting change for D86245: Fix an issue where get_system_libname creates an empty regex capture on windows: rGcdcb9ab10e53: Revert "Use find_library for ncurses".
Thu, Aug 27, 5:58 PM · Restricted Project
gkistanova added a reverting change for D86234: [CMake] Always mark terminfo as unavailable on Windows: rGcdcb9ab10e53: Revert "Use find_library for ncurses".
Thu, Aug 27, 5:58 PM · Restricted Project
gkistanova added a reverting change for D86173: Don't look for terminfo libs when LLVM_ENABLE_TERMINFO=OFF: rGcdcb9ab10e53: Revert "Use find_library for ncurses".
Thu, Aug 27, 5:58 PM · Restricted Project, Restricted Project
gkistanova added a reverting change for D85820: Use find_library for ncurses: rGcdcb9ab10e53: Revert "Use find_library for ncurses".
Thu, Aug 27, 5:58 PM · Restricted Project, Restricted Project, Restricted Project
gkistanova added a reverting change for rG1ed1e16ab83f: [CMake] Fix an issue where get_system_libname creates an empty regex capture on…: rGcdcb9ab10e53: Revert "Use find_library for ncurses".
Thu, Aug 27, 5:58 PM
gkistanova committed rGcdcb9ab10e53: Revert "Use find_library for ncurses" (authored by haampie).
Revert "Use find_library for ncurses"
Thu, Aug 27, 5:58 PM
gkistanova added a reverting change for rG34fe9613dda3: Fix msan build: rGcdcb9ab10e53: Revert "Use find_library for ncurses".
Thu, Aug 27, 5:58 PM
gkistanova closed D86521: Revert "Use find_library for ncurses".
Thu, Aug 27, 5:58 PM · Restricted Project, Restricted Project, Restricted Project
gkistanova added a comment to D86521: Revert "Use find_library for ncurses".

Hi Petr,

Thu, Aug 27, 1:50 PM · Restricted Project, Restricted Project, Restricted Project
gkistanova added a comment to D86521: Revert "Use find_library for ncurses".

Hi Mateusz,
Yes, this looks like a separate patch on top of this revert.

Thu, Aug 27, 1:14 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Aug 25

gkistanova committed rZORG8d3a31cb12b5: Let mlir-nvidia and mlir-windows builders combine commits, otherwise the… (authored by gkistanova).
Let mlir-nvidia and mlir-windows builders combine commits, otherwise the…
Tue, Aug 25, 10:28 PM
gkistanova accepted D86521: Revert "Use find_library for ncurses".

I have checked this patch with http://lab.llvm.org:8011/builders/lld-perf-testsuite bot. It makes it green.

Tue, Aug 25, 12:58 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Aug 24

gkistanova requested changes to D85820: Use find_library for ncurses.
Mon, Aug 24, 9:40 PM · Restricted Project, Restricted Project, Restricted Project
gkistanova reopened D85820: Use find_library for ncurses.

@haampie Are you working on fixing the http://lab.llvm.org:8011/builders/lld-perf-testsuite bot? This patch has broken it.

Mon, Aug 24, 9:40 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Aug 19

gkistanova committed rZORGd7c226fb8d65: AnnotatedCommand.py is a part of the build bot, thus does not need x permission… (authored by gkistanova).
AnnotatedCommand.py is a part of the build bot, thus does not need x permission…
Wed, Aug 19, 11:56 PM
gkistanova committed rZORG6d0ca51e742e: Removed unused code from zorg/buildbot/commands. (authored by gkistanova).
Removed unused code from zorg/buildbot/commands.
Wed, Aug 19, 11:54 PM

Aug 17 2020

gkistanova committed rZORG6bfe283aef36: Cleaned __init__.py files in zorg package. (authored by gkistanova).
Cleaned __init__.py files in zorg package.
Aug 17 2020, 10:58 PM

Aug 13 2020

gkistanova accepted D85816: Fix binaries directory for flang slaves gcc10 and clang10.

LGTM

Aug 13 2020, 6:59 PM

Aug 11 2020

gkistanova committed rZORG9ad0d8f03829: Specify a number of jobs as a property for flang-aarch64-ubuntu-clang and flang… (authored by gkistanova).
Specify a number of jobs as a property for flang-aarch64-ubuntu-clang and flang…
Aug 11 2020, 11:07 PM
gkistanova committed rZORG714b345535c0: Add Flang and MLIR PowerPC buildbot on Red Hat (authored by zacharyselk).
Add Flang and MLIR PowerPC buildbot on Red Hat
Aug 11 2020, 10:50 PM
gkistanova closed D84956: [zorg] Add Flang and MLIR PowerPC buildbot on Red Hat.
Aug 11 2020, 10:50 PM

Aug 7 2020

gkistanova accepted D84956: [zorg] Add Flang and MLIR PowerPC buildbot on Red Hat.

Thanks! Please feel free to commit.

Aug 7 2020, 9:49 PM
gkistanova accepted D85529: Add flang slaves builds with clang10 and gcc10.

LGTM

Aug 7 2020, 2:48 PM

Aug 6 2020

gkistanova accepted D85462: [zorg] Solaris buildbot updates.

LGTM

Aug 6 2020, 3:10 PM · Restricted Project

Aug 3 2020

gkistanova accepted D84956: [zorg] Add Flang and MLIR PowerPC buildbot on Red Hat.

Looks Ok with one problem.

Aug 3 2020, 11:48 AM

Jul 31 2020

gkistanova committed rZORG9c39add1f0c8: Got rid of legacy schedulers. (authored by gkistanova).
Got rid of legacy schedulers.
Jul 31 2020, 10:00 PM
gkistanova committed rZORG993dd9a2b15d: Refactored getSingleBranchSchedulers, since now we use LLVMBuildFactory for all… (authored by gkistanova).
Refactored getSingleBranchSchedulers, since now we use LLVMBuildFactory for all…
Jul 31 2020, 9:56 PM

Jul 28 2020

gkistanova committed rZORG634c4d1cb0fe: Fixed typo. (authored by gkistanova).
Fixed typo.
Jul 28 2020, 9:39 PM

Jul 24 2020

gkistanova committed rZORG888548a89c74: Removed remainings of the legacy mode support from LLVMBuildFactory. (authored by gkistanova).
Removed remainings of the legacy mode support from LLVMBuildFactory.
Jul 24 2020, 4:51 PM
gkistanova committed rZORGfedf037b5633: Removed deprecated legacy mode from AnnotatedBuilder. (authored by gkistanova).
Removed deprecated legacy mode from AnnotatedBuilder.
Jul 24 2020, 4:48 PM
gkistanova committed rZORG25a1c1217d5e: Removed deprecated legacy mode from SanitizerBuilder. (authored by gkistanova).
Removed deprecated legacy mode from SanitizerBuilder.
Jul 24 2020, 4:46 PM
gkistanova committed rZORG13d5bd03292d: Removed deprecated legacy mode from LLDBBuilder. (authored by gkistanova).
Removed deprecated legacy mode from LLDBBuilder.
Jul 24 2020, 4:44 PM
gkistanova committed rZORG26b99961d2e8: Removed deprecated legacy mode from LibcxxAndAbiBuilder. (authored by gkistanova).
Removed deprecated legacy mode from LibcxxAndAbiBuilder.
Jul 24 2020, 4:42 PM
gkistanova committed rZORG66c5d318ae7e: Removed deprecated legacy mode from ClangBuilder. (authored by gkistanova).
Removed deprecated legacy mode from ClangBuilder.
Jul 24 2020, 4:40 PM
gkistanova committed rZORG18839ec8d638: Removed deprecated legacy mode from ClangLTOBuilder. (authored by gkistanova).
Removed deprecated legacy mode from ClangLTOBuilder.
Jul 24 2020, 4:33 PM
gkistanova committed rZORG516f7df34146: Removed deprecated legacy mode from ABITestsuitBuilder. (authored by gkistanova).
Removed deprecated legacy mode from ABITestsuitBuilder.
Jul 24 2020, 4:30 PM
gkistanova committed rZORGe03d2cdd40a3: Removed deprecated legacy mode from LLDPerformanceTestsuite. (authored by gkistanova).
Removed deprecated legacy mode from LLDPerformanceTestsuite.
Jul 24 2020, 4:27 PM
gkistanova committed rZORG3406d698660b: Removed deprecated legacy mode from UnifiedTreeBuilder. (authored by gkistanova).
Removed deprecated legacy mode from UnifiedTreeBuilder.
Jul 24 2020, 4:25 PM
gkistanova committed rZORG5f219e04786e: Removed deprecated legacy mode automatic schedulers. (authored by gkistanova).
Removed deprecated legacy mode automatic schedulers.
Jul 24 2020, 3:52 PM
gkistanova committed rZORGa7a86153e52d: Removed deprecated SVN LLVMPoller. (authored by gkistanova).
Removed deprecated SVN LLVMPoller.
Jul 24 2020, 3:35 PM

Jul 23 2020

gkistanova committed rZORGbba0a62fc068: NFC. Removed deprecated code from LLVMBuildFactory. (authored by gkistanova).
NFC. Removed deprecated code from LLVMBuildFactory.
Jul 23 2020, 4:26 PM
gkistanova committed rZORG283f51fbca14: Removed deprecated ClangAndLLDBuilder. (authored by gkistanova).
Removed deprecated ClangAndLLDBuilder.
Jul 23 2020, 4:13 PM
gkistanova committed rZORG2a70474c3aa3: Removed deprecated LLVMBuilder. (authored by gkistanova).
Removed deprecated LLVMBuilder.
Jul 23 2020, 4:10 PM
gkistanova committed rZORG96b56cb1ba5a: Removed deprecated SanitizerBuilderII. (authored by gkistanova).
Removed deprecated SanitizerBuilderII.
Jul 23 2020, 4:05 PM
gkistanova committed rZORG7a49d525fd7d: Removed deprecated LLVMGCCBuilder. (authored by gkistanova).
Removed deprecated LLVMGCCBuilder.
Jul 23 2020, 3:59 PM
gkistanova committed rZORG320055350cc0: Removed deprecated ClangLTOBuilder3Stage. (authored by gkistanova).
Removed deprecated ClangLTOBuilder3Stage.
Jul 23 2020, 3:52 PM
gkistanova committed rZORG97c6f126a34e: Removed deprecated code from ClangBuilder. (authored by gkistanova).
Removed deprecated code from ClangBuilder.
Jul 23 2020, 3:36 PM
gkistanova committed rZORG4c22206f091b: Removed deprecated NightlytestBuilder. (authored by gkistanova).
Removed deprecated NightlytestBuilder.
Jul 23 2020, 2:59 PM
gkistanova committed rZORG8b090dc39e43: NFC. Removed unused imports from LibcxxAndAbiBuilder. (authored by gkistanova).
NFC. Removed unused imports from LibcxxAndAbiBuilder.
Jul 23 2020, 2:49 PM
gkistanova committed rZORG21ce676ffb64: Removed deprecated LNTBuilder. (authored by gkistanova).
Removed deprecated LNTBuilder.
Jul 23 2020, 2:39 PM
gkistanova committed rZORGaae98571ef04: Removed deprecated LibCXXBuilder. (authored by gkistanova).
Removed deprecated LibCXXBuilder.
Jul 23 2020, 2:34 PM

Jul 22 2020

gkistanova added a comment to D83026: Adding autodetection for Visual Studio 2019.

https://reviews.llvm.org/rZORG0e45046f4212 should fix this for you.

Jul 22 2020, 11:15 PM
gkistanova committed rZORGc6d0f0011d06: Fixed mistype in bot name cuda-p4-0. (authored by gkistanova).
Fixed mistype in bot name cuda-p4-0.
Jul 22 2020, 10:32 PM
gkistanova committed rZORGec561d2abbf9: Removed deprecated LLDBuilder. (authored by gkistanova).
Removed deprecated LLDBuilder.
Jul 22 2020, 4:16 PM
gkistanova accepted D81118: [buildbot] Added builders and slaves for the new CUDA build/test bots..

LGTM

Jul 22 2020, 4:07 PM
gkistanova accepted D83503: [buildbot] Annotated builder tweaks.

Ok. Let’s see how this will work in the reality.

Jul 22 2020, 4:06 PM
gkistanova committed rZORG0e45046f4212: Added support for autodetection of build-tools only Visual Studio installations. (authored by gkistanova).
Added support for autodetection of build-tools only Visual Studio installations.
Jul 22 2020, 4:01 PM

Jul 20 2020

gkistanova added a comment to D83503: [buildbot] Annotated builder tweaks.

A script could be "external" as long as it is a part of the LLVM code base, i.e. committed under https://github.com/llvm to be available to others for review, use, and improve according to the "Apache 2.0 License with LLVM exceptions” and the Developer Policy.
llvm-zorg is the right place for the components of CI, but if your script is also used for generic builds, it is fine to have it as a part of CUDA.

Jul 20 2020, 9:16 PM

Jul 13 2020

gkistanova added a comment to D81118: [buildbot] Added builders and slaves for the new CUDA build/test bots..

Hello Artem,

Jul 13 2020, 9:16 PM
gkistanova requested changes to D83503: [buildbot] Annotated builder tweaks.

Hello Artem,

Jul 13 2020, 9:12 PM
gkistanova added a comment to D83026: Adding autodetection for Visual Studio 2019.

Hello Christian,

Jul 13 2020, 8:49 PM

Jun 30 2020

gkistanova accepted D82758: new win32 buildbot.

LGTM

Jun 30 2020, 11:56 AM

Jun 27 2020

gkistanova requested changes to D80838: [llvm-ar] Add more tests for errors in opening archives.

Hi Sameer,

Jun 27 2020, 12:49 AM · Restricted Project
gkistanova reopened D80838: [llvm-ar] Add more tests for errors in opening archives.

This patch introduced a test failure on FreeBSD.
The error message is different than what's the expected by the test.

Jun 27 2020, 12:41 AM · Restricted Project

Jun 25 2020

gkistanova added a comment to D81118: [buildbot] Added builders and slaves for the new CUDA build/test bots..

Now the script runs before LLVM source tree has been checked out, so there's no sources for me to work with. AFAICT, revision hash is not available in the environment, so there's no way for me to check out the correct revision.

Jun 25 2020, 6:35 PM

Jun 24 2020

gkistanova added a comment to D81118: [buildbot] Added builders and slaves for the new CUDA build/test bots..

I have changed the staging to invoke /buildbot/external.py.
http://lab.llvm.org:8014/builders/clang-cuda-gce-build/builds/313/steps/annotate/logs/stdio

Jun 24 2020, 7:01 PM
gkistanova added a comment to D81118: [buildbot] Added builders and slaves for the new CUDA build/test bots..

You could put that script somewhere local and give me the fully qualified path to that script.I'll set the staging accordingly.

Jun 24 2020, 3:47 PM

Jun 18 2020

gkistanova accepted D82127: Reduce a builder path for the windows builder to let some libc++ tests pass..

LGTM

Jun 18 2020, 3:21 PM

Jun 15 2020

gkistanova added a comment to D81118: [buildbot] Added builders and slaves for the new CUDA build/test bots..

Staging is ready for your experiments.

Jun 15 2020, 1:36 AM

Jun 12 2020

gkistanova added a comment to D81118: [buildbot] Added builders and slaves for the new CUDA build/test bots..

I can temporarily set you up like this in the staging. You would do all the experiments you are after, tinker, and such. Once you are happy you could prepare a final patch for the review.
For how long do you expect tinkering?

Jun 12 2020, 3:24 PM

Jun 11 2020

gkistanova committed rZORG8d932d037711: Do not use os.path, since the code runs on one computer but the command will be… (authored by gkistanova).
Do not use os.path, since the code runs on one computer but the command will be…
Jun 11 2020, 7:16 PM

Jun 10 2020

gkistanova committed rZORGbe944a94952e: Added projects and categories for flang, mlir, libc. (authored by gkistanova).
Added projects and categories for flang, mlir, libc.
Jun 10 2020, 10:06 PM

Jun 8 2020

gkistanova added a comment to D81118: [buildbot] Added builders and slaves for the new CUDA build/test bots..

Thanks for updating the patch, Artem.

Jun 8 2020, 4:06 PM

Jun 7 2020

gkistanova requested changes to D81118: [buildbot] Added builders and slaves for the new CUDA build/test bots..

Hello Artem.

Jun 7 2020, 11:25 PM