- User Since
- Mar 22 2013, 2:32 PM (265 w, 2 d)
Tue, Apr 10
Tue, Apr 3
Tue, Mar 27
Mar 22 2018
Mar 1 2018
Feb 23 2018
Feb 15 2018
Feb 13 2018
This seems a proper GTest way, indeed.
Just for the record, the warning was reported by clang 5.0.1.
Feb 12 2018
Feb 10 2018
Feb 1 2018
There is a cosmetic issue, but your change seems in line with the rest of the file, so, not sure if you would want to do this just for 2 ninja commands you are adding, or address it everywhere in this file as a separate patch.
Dec 21 2017
Dec 20 2017
Dec 15 2017
Dec 13 2017
Dec 8 2017
Dec 5 2017
Nov 29 2017
Nov 20 2017
WithProperties should work just fine in this context.
It gets rendered for each build, but will always be the same, unless someone would overwrite it for a particular build.
This approach does not support a build slave "jobs" property, making it hard to support multiple slaves for the same builder.
However, since this change is local for OpenMPBuilder, you may go ahead and commit it, if you are not up to a better implementation at the moment.
Oct 26 2017
Let's keep only the changes relevant to this patch. Feel free to make a separate cosmetic NFC patch if you'd like.
Please feel free to commit, assuming you would roll that leading whitespace back.
Oct 19 2017
Oct 12 2017
Oct 9 2017
Oct 2 2017
Sep 28 2017
Sep 27 2017
Sep 26 2017
Sep 21 2017
Thanks for splitting the original review item.
When you force to build a revision 0, you would get a red build before the next one will do a clean checkout. Which is not always good.
This seems like 2 unrelated changes.
Could you split it to 2 different items, please?
Not sure the naming is good, though. Since this is a build property, it might be a good idea to be a bit more specific of what kind of mode is that, what do you think?
How about "checkout_mode" or "svn_mode"?
Jul 21 2017
Jul 19 2017
Jul 11 2017
Jul 10 2017
LGTM, assuming you will remove the unrelated cosmetic changes, and figure out what place you want to specify the number of jobs. Up to me, a slave property seems a better and more natural place.