Page MenuHomePhabricator

gkistanova (Galina)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 22 2013, 2:32 PM (523 w, 1 d)

Recent Activity

Thu, Mar 30

gkistanova added a comment to D146722: [OpenMP][LibC] Adds testing LibC GPU Mode for AMDGPU.

OpenMPBuilder didn't do enable_runtimes="auto". This is fixed in https://github.com/llvm/llvm-zorg/commit/b86d771caf03cb7fe94d0d187cad25d9519ea584.

Thu, Mar 30, 7:30 PM · Restricted Project
gkistanova committed rZORGb86d771caf03: Updated OpenMPBuilder to make enable_runtimes="auto" the default, and to remove… (authored by gkistanova).
Updated OpenMPBuilder to make enable_runtimes="auto" the default, and to remove…
Thu, Mar 30, 7:21 PM · Restricted Project
gkistanova updated subscribers of D146722: [OpenMP][LibC] Adds testing LibC GPU Mode for AMDGPU.

Please keep it as is. I'll take a look later today on what might be wrong.

Thu, Mar 30, 3:37 PM · Restricted Project
gkistanova accepted D146722: [OpenMP][LibC] Adds testing LibC GPU Mode for AMDGPU.

Thanks for updating the patch, JP.

Thu, Mar 30, 9:44 AM · Restricted Project

Wed, Mar 29

gkistanova added inline comments to D146722: [OpenMP][LibC] Adds testing LibC GPU Mode for AMDGPU.
Wed, Mar 29, 6:18 PM · Restricted Project
gkistanova added a comment to D146722: [OpenMP][LibC] Adds testing LibC GPU Mode for AMDGPU.

libc will be a runtime by default.

Wed, Mar 29, 1:30 PM · Restricted Project
gkistanova requested changes to D146722: [OpenMP][LibC] Adds testing LibC GPU Mode for AMDGPU.
Wed, Mar 29, 12:04 PM · Restricted Project

Tue, Mar 28

gkistanova reopened D146722: [OpenMP][LibC] Adds testing LibC GPU Mode for AMDGPU.

Could you elaborate on why did you specify LLVM_ENABLE_PROJECTS explicitly, and why it does not match what's in the depends_on_projects, please? The same question is for LLVM_ENABLE_RUNTIMES and enable_runtimes respectively.

Tue, Mar 28, 3:02 PM · Restricted Project

Fri, Mar 24

gkistanova accepted D146432: [Test suite builder] Make enable_runtimes="auto" the default.

LGTM

Fri, Mar 24, 11:40 AM · Restricted Project

Thu, Mar 23

gkistanova committed rZORGccf282b68c4d: Fixed a typing error in https://reviews.llvm.org/D146332 (authored by gkistanova).
Fixed a typing error in https://reviews.llvm.org/D146332
Thu, Mar 23, 12:52 PM · Restricted Project

Fri, Mar 10

gkistanova accepted D145830: Remove lldb-x64-windows-ninja bot.

LGTM.

Fri, Mar 10, 3:14 PM · Restricted Project

Thu, Mar 9

gkistanova accepted D145713: [mlir] Add a new mlir buildbot on s390x with werror enabled.

LGTM.

Thu, Mar 9, 9:48 PM · Restricted Project
gkistanova requested changes to D145713: [mlir] Add a new mlir buildbot on s390x with werror enabled.

The patch looks fine with one thing to fix.

Thu, Mar 9, 4:42 PM · Restricted Project

Wed, Mar 8

gkistanova accepted D145470: [libc] Add a riscv64 worker and two builders on it..

Please ping me with the password for this worker before committing the patch.

Wed, Mar 8, 9:56 AM · Restricted Project

Fri, Mar 3

gkistanova committed rZORG7c8403c9d8c5: [VE] Change to not use standalone build (authored by kaz7).
[VE] Change to not use standalone build
Fri, Mar 3, 11:40 PM · Restricted Project
gkistanova closed D144837: [VE] Change to not use standalone build.
Fri, Mar 3, 11:40 PM · Restricted Project
gkistanova accepted D144837: [VE] Change to not use standalone build.

LGTM.

Fri, Mar 3, 11:32 PM · Restricted Project

Mar 1 2023

gkistanova committed rZORG0dd2471ba420: Fixed missed comma. (authored by gkistanova).
Fixed missed comma.
Mar 1 2023, 10:45 AM · Restricted Project
gkistanova accepted D144858: Generate ENABLE_RUNTIMES in ClangBuilder.

LGTM.

Mar 1 2023, 10:34 AM · Restricted Project

Feb 28 2023

gkistanova accepted D145029: [libc] Add a lint worker and a builder running on it..

LGTM.

Feb 28 2023, 11:26 PM · Restricted Project
gkistanova requested changes to D144858: Generate ENABLE_RUNTIMES in ClangBuilder.

The patch looks good in general.

Feb 28 2023, 10:29 AM · Restricted Project
gkistanova added a comment to D144464: [docs] Improve guidance on installing the correct buildbot-worker version.

There is no promise of forward compatibility as far as I know. Thus far I have seen working workers from version 0.8.4 to version 3.7.0. I have also seen people setting up workers from the source code and not any particular release. All this is fine. I don't think we should force everyone to use a particular version as long as that does not affect reliability of the production buildbot, and experiments with newer versions do not require much attention and troubleshooting on the server side. Being flexible with the requirements to workers help bot owners to keep them on their own schedule.

Feb 28 2023, 10:06 AM · Restricted Project, Restricted Project

Feb 25 2023

gkistanova committed rZORG562ccebc5263: Remove submit perf results (authored by yinyangsx).
Remove submit perf results
Feb 25 2023, 12:15 AM · Restricted Project
gkistanova closed D143878: Remove submit perf results.
Feb 25 2023, 12:15 AM · Restricted Project

Feb 21 2023

gkistanova added a comment to D144465: [docs] Document how frequently the staging buildmaster configuration is reconfigured.

Production buildbot gets reconfigured or restarted only if it is necessary when we have less commits and builds activity. And that's usually combined with other maintenance work. Frankly, I don't think it worth mentioning in the docs.

Feb 21 2023, 8:14 PM · Restricted Project, Restricted Project
gkistanova added a comment to D143878: Remove submit perf results.

That's fine, you do not have to submit perf results to LNT if you do not want to.
Just add something to the description which would provide the reasoning why you stop doing so. Saying something like "because recently LNT server became unreliable with accepting runs", or whatever you things the reason is, is Ok.

Feb 21 2023, 10:36 AM · Restricted Project
gkistanova accepted D144465: [docs] Document how frequently the staging buildmaster configuration is reconfigured.

LGTM

Feb 21 2023, 10:29 AM · Restricted Project, Restricted Project
gkistanova accepted D144464: [docs] Improve guidance on installing the correct buildbot-worker version.

More recent versions of buildbot-worker would work too. But you are right, we shall recommend what would work for sure and what would require less effort to setup.

Feb 21 2023, 10:25 AM · Restricted Project, Restricted Project

Feb 14 2023

gkistanova committed rZORG79dc9b90712c: [clang][VE] Change to use only use major version in resource dir (authored by kaz7).
[clang][VE] Change to use only use major version in resource dir
Feb 14 2023, 11:00 AM · Restricted Project
gkistanova closed D143441: [clang][VE] Change to use only use major version in resource dir.
Feb 14 2023, 11:00 AM · Restricted Project

Feb 13 2023

gkistanova accepted D143172: [zorg][RISCV] Add a qemu-user based builder.

LGTM

Feb 13 2023, 7:20 PM · Restricted Project
gkistanova added a comment to D143878: Remove submit perf results.

Could you update the summary with the reason of why LNT submit gets removed, please?

Feb 13 2023, 7:19 PM · Restricted Project
gkistanova accepted D143441: [clang][VE] Change to use only use major version in resource dir.
Feb 13 2023, 7:16 PM · Restricted Project

Feb 10 2023

gkistanova committed rZORG00bb7dbc46f0: Remove clang-cmake-x86_64-sde-avx512-linux builder (authored by yinyangsx).
Remove clang-cmake-x86_64-sde-avx512-linux builder
Feb 10 2023, 11:26 PM · Restricted Project
gkistanova closed D143552: Remove clang-cmake-x86_64-sde-avx512-linux builder.
Feb 10 2023, 11:26 PM · Restricted Project

Feb 8 2023

gkistanova accepted D143365: Remove -j argument to llvm-clang-x86_64-sie-win builder for lit testing.

If LIT default threads usage is what you are after, the patch looks good.

Feb 8 2023, 8:20 PM · Restricted Project, Restricted Project
gkistanova added a reviewer for D143441: [clang][VE] Change to use only use major version in resource dir: simoll.

Adding Simon as a reviewer.

Feb 8 2023, 8:08 PM · Restricted Project
gkistanova accepted D143552: Remove clang-cmake-x86_64-sde-avx512-linux builder.

LGTM

Feb 8 2023, 8:01 PM · Restricted Project

Feb 7 2023

gkistanova added a comment to D143047: Switch from autoconfigure to cmake for clang-cmake-x86_64-avx2-linux-perf builder.

Feel free to connect your worker to the staging.

Feb 7 2023, 10:14 AM · Restricted Project

Feb 6 2023

gkistanova committed rZORG0cc50a77ae86: Switch from autoconfigure to cmake for clang-cmake-x86_64-avx2-linux-perf… (authored by yinyangsx).
Switch from autoconfigure to cmake for clang-cmake-x86_64-avx2-linux-perf…
Feb 6 2023, 9:31 PM · Restricted Project
gkistanova closed D143047: Switch from autoconfigure to cmake for clang-cmake-x86_64-avx2-linux-perf builder.
Feb 6 2023, 9:31 PM · Restricted Project

Feb 3 2023

gkistanova committed rZORG7986e6372b36: Switch from autoconfigure to cmake for clang-cmake-x86_64-avx2-linux builder (authored by yinyangsx).
Switch from autoconfigure to cmake for clang-cmake-x86_64-avx2-linux builder
Feb 3 2023, 12:14 AM · Restricted Project
gkistanova closed D143045: Switch from autoconfigure to cmake for clang-cmake-x86_64-avx2-linux builder.
Feb 3 2023, 12:14 AM · Restricted Project

Feb 2 2023

gkistanova requested changes to D143172: [zorg][RISCV] Add a qemu-user based builder.

We can use this builder as a pilot of gated builds if you have bandwidth and are willing to babysit it for awhile. I'm looking forward to it.

Feb 2 2023, 11:55 PM · Restricted Project

Feb 1 2023

gkistanova accepted D143045: Switch from autoconfigure to cmake for clang-cmake-x86_64-avx2-linux builder.

LGTM.

Feb 1 2023, 11:36 PM · Restricted Project
gkistanova accepted D142854: [BOLT] Combine two clang-bolt builders into one.

LGTM with a nit pick.

Feb 1 2023, 11:30 PM · Restricted Project
gkistanova accepted D143047: Switch from autoconfigure to cmake for clang-cmake-x86_64-avx2-linux-perf builder.

LGTM.

Feb 1 2023, 11:27 PM · Restricted Project

Jan 31 2023

gkistanova accepted D143003: [sanitizer] Add more aarch64 workers.

LGTM.

Jan 31 2023, 12:45 PM · Restricted Project

Jan 27 2023

gkistanova committed rG00ecf3f33962: Added a note that "%p" is also a Lit token and needs to be escaped. (authored by FlashSheridan).
Added a note that "%p" is also a Lit token and needs to be escaped.
Jan 27 2023, 5:58 PM · Restricted Project, Restricted Project
gkistanova committed rG01f13f487775: Explain code coverage with Lit in docs/SourceBasedCodeCoverage.rst (authored by FlashSheridan).
Explain code coverage with Lit in docs/SourceBasedCodeCoverage.rst
Jan 27 2023, 5:52 PM · Restricted Project, Restricted Project
gkistanova closed D140730: 59559 Explain code coverage with Lit in docs/SourceBasedCodeCoverage.rst.
Jan 27 2023, 5:52 PM · Restricted Project, Restricted Project

Jan 24 2023

gkistanova accepted D140730: 59559 Explain code coverage with Lit in docs/SourceBasedCodeCoverage.rst.

LGTM.

Jan 24 2023, 12:18 PM · Restricted Project, Restricted Project

Jan 17 2023

gkistanova committed rZORG1f1512b0378e: [NFC] Removed trailing whitespaces. (authored by gkistanova).
[NFC] Removed trailing whitespaces.
Jan 17 2023, 7:38 PM · Restricted Project

Jan 13 2023

gkistanova committed rZORGd6d48a07440e: Bumped certifi to 2022.12.7. (authored by gkistanova).
Bumped certifi to 2022.12.7.
Jan 13 2023, 11:42 PM · Restricted Project
gkistanova accepted D137678: [BOLT] Enable clang-bolt for host-gcc-built Clang.

Thanks, Amir!

Jan 13 2023, 12:04 PM · Restricted Project
gkistanova accepted D140384: Revamp LLVM WoA buildbots.

Thanks, Muhammad!
Looks good.

Jan 13 2023, 12:00 PM · Restricted Project

Jan 11 2023

gkistanova added a comment to D140384: Revamp LLVM WoA buildbots.

The meaning is changing over time as we are getting more and more fast builders. For now, I'd call a builder quick if it is able to build each commit and stay current with the build queue in general (something like 3-5 minutes response time or better).

Jan 11 2023, 11:15 AM · Restricted Project

Jan 9 2023

gkistanova accepted D141169: [libc] Add a gcc fullbuild builder..

LGTM.

Jan 9 2023, 1:37 AM · Restricted Project

Jan 8 2023

gkistanova added a comment to D141169: [libc] Add a gcc fullbuild builder..

The patch looks good.

Jan 8 2023, 11:17 PM · Restricted Project
gkistanova added a comment to D140384: Revamp LLVM WoA buildbots.

Thanks for making the changes!

Jan 8 2023, 11:14 PM · Restricted Project
gkistanova accepted D141217: Turn on ccache and clean builds for llvm-clang-x86_64-sie-win builder.

LGTM.

Jan 8 2023, 9:04 PM · Restricted Project, Restricted Project

Dec 31 2022

gkistanova committed rZORG518a5288c964: Require LLVM_ENABLE_ASSERTIONS=OFF for last stages of the ClangLTOBuilder. (authored by gkistanova).
Require LLVM_ENABLE_ASSERTIONS=OFF for last stages of the ClangLTOBuilder.
Dec 31 2022, 11:32 PM · Restricted Project

Dec 27 2022

gkistanova committed rZORGc342f3f087ec: arc-builder is not fast enough to build each commit, so let it collapse build… (authored by gkistanova).
arc-builder is not fast enough to build each commit, so let it collapse build…
Dec 27 2022, 11:35 PM · Restricted Project
gkistanova accepted D140269: [BOLT] Check llvm-bolt binaries before running NFC checks.

LGTM.

Dec 27 2022, 10:31 PM · Restricted Project
gkistanova requested changes to D140384: Revamp LLVM WoA buildbots.

Thanks for the patch, Muhammad.

Dec 27 2022, 8:19 PM · Restricted Project
gkistanova raised a concern with rZORG8a912708050b: [bbot][amdgpu][openmp] experimental: checkAll.

Hello Ron,

Dec 27 2022, 6:38 PM · Restricted Project
gkistanova added a reverting change for rZORGd8256b1fd25b: [bbot][amdgpu][openmp] experimental: run all checks: rZORG77c13db86195: Reverted 8a912708050b and d8256b1fd25b, as neither "checkAll" nor "checks" args….
Dec 27 2022, 6:35 PM · Restricted Project
gkistanova added a reverting change for rZORG8a912708050b: [bbot][amdgpu][openmp] experimental: checkAll: rZORG77c13db86195: Reverted 8a912708050b and d8256b1fd25b, as neither "checkAll" nor "checks" args….
Dec 27 2022, 6:35 PM · Restricted Project
gkistanova committed rZORG77c13db86195: Reverted 8a912708050b and d8256b1fd25b, as neither "checkAll" nor "checks" args… (authored by gkistanova).
Reverted 8a912708050b and d8256b1fd25b, as neither "checkAll" nor "checks" args…
Dec 27 2022, 6:35 PM · Restricted Project

Dec 25 2022

gkistanova added a comment to D140269: [BOLT] Check llvm-bolt binaries before running NFC checks.

The patch looks good. The only thing I'm not sure is the error handling at the check-bolt-different step. + one cosmetic nit pick.

Dec 25 2022, 8:55 PM · Restricted Project

Dec 20 2022

gkistanova accepted D140390: Fix a typo in /vol/ccache for clangd builder.

Nice catch! :)

Dec 20 2022, 10:02 PM · Restricted Project
gkistanova accepted D140317: Add buildbot with C++20 configuration.

Thanks for the patch, Ilya!
And thanks for helping with the review, Kadir! All good comments.

Dec 20 2022, 10:01 PM · Restricted Project

Dec 18 2022

gkistanova added a comment to D101717: [zorg] Parse Ninja output..

I believe I commented this patch, but do not see my comments here. :(
Sorry for this.

Dec 18 2022, 12:53 AM · Restricted Project, Restricted Project

Dec 16 2022

gkistanova accepted D138672: [buildbot] Add a LoongArch buildbot on CLFS.

Thanks everyone for helping with the review!

Dec 16 2022, 10:08 AM · Restricted Project

Dec 15 2022

gkistanova accepted D133939: Add enable_runtimes option to Clang builder.

LGTM.

Dec 15 2022, 4:20 PM · Restricted Project
gkistanova accepted D139694: [BOLT] Fold bolt-nfc builder into BOLTBuilder.

LGTM.

Dec 15 2022, 4:13 PM · Restricted Project

Dec 14 2022

gkistanova added a comment to D139694: [BOLT] Fold bolt-nfc builder into BOLTBuilder.

Hi Amir,

Dec 14 2022, 11:30 PM · Restricted Project
gkistanova requested changes to D133939: Add enable_runtimes option to Clang builder.

Hello David,

Dec 14 2022, 11:28 PM · Restricted Project
gkistanova resigned from D138500: [RISCV] Change the return type of getStreamer() to support the use of overloading and other functions in RISCVELFStreamer..

I don't think I'm a good reviewer for this patch.

Dec 14 2022, 6:28 PM · Restricted Project, Restricted Project
gkistanova accepted D139735: Add additional buildbots to my notification list.

LGTM.

Dec 14 2022, 1:20 PM · Restricted Project, Restricted Project
gkistanova accepted D139912: [BOLT] Create MailNotifier for NFC check mismatches.

LGTM.

Dec 14 2022, 1:19 PM · Restricted Project
gkistanova accepted D140041: Remove explicit LLVM ccache-ing.

Interesting.
Could you tell me how ccache with icecream will work for you with a real load after a few weeks of working, please?

Dec 14 2022, 12:14 PM · Restricted Project, Restricted Project

Dec 7 2022

gkistanova added a comment to rZORG437caa7e15cd: [BOLT] Collapse requests on LTO+PGO builder.

Hi Amir,

Dec 7 2022, 5:39 PM · Restricted Project
gkistanova committed rZORG481d97ed8a3d: Removed 'collapseRequests': True to let the default machinery handle collapsing… (authored by gkistanova).
Removed 'collapseRequests': True to let the default machinery handle collapsing…
Dec 7 2022, 5:31 PM · Restricted Project
gkistanova committed rZORGa283a62381c6: Fixed cmake args passing. (authored by gkistanova).
Fixed cmake args passing.
Dec 7 2022, 5:22 PM · Restricted Project
gkistanova accepted D138726: Rename and reassign a few SIE workers/builders.

The patch itself looks Ok.

Dec 7 2022, 11:05 AM · Restricted Project, Restricted Project

Nov 29 2022

gkistanova resigned from D138760: BLAKE3: do not try to use neon on big-endian aarch64.

Doesn't look like I'm a good reviewer for the proposed patch.

Nov 29 2022, 10:25 AM · Restricted Project, Restricted Project

Nov 15 2022

gkistanova accepted D137678: [BOLT] Enable clang-bolt for host-gcc-built Clang.

LGTM.

Nov 15 2022, 5:22 PM · Restricted Project
gkistanova accepted D137988: [BOLT] Fold bolt-x86_64-ubuntu into bolt-nfc builder.

LGTM.

Nov 15 2022, 9:49 AM · Restricted Project
gkistanova added a comment to D131077: Builder for LLVM Embedded Toolchain for Arm.

Hi Galina, this change does build LLVM mainline (see line 42).

Nov 15 2022, 9:38 AM · Restricted Project, Restricted Project

Nov 14 2022

gkistanova accepted D136298: Add warnOnWarnings AnnotatedBuilder property.

LGTM.

Nov 14 2022, 9:22 AM · Restricted Project
gkistanova added a comment to D137678: [BOLT] Enable clang-bolt for host-gcc-built Clang.

The patch itself looks good.

Nov 14 2022, 9:18 AM · Restricted Project

Nov 10 2022

gkistanova committed rZORG0d335fdbe870: Fixed mistype introduced by 61ebcff9a. (authored by gkistanova).
Fixed mistype introduced by 61ebcff9a.
Nov 10 2022, 7:52 PM · Restricted Project

Nov 9 2022

gkistanova added a comment to D131077: Builder for LLVM Embedded Toolchain for Arm.

Hi Michael.

Nov 9 2022, 10:57 AM · Restricted Project, Restricted Project

Nov 8 2022

gkistanova accepted D137405: Add new linux worker and a legacy linux gcc build that we do internally.

LGTM.

Nov 8 2022, 5:38 PM · Restricted Project, Restricted Project
gkistanova accepted D136410: [BOLT] Enable clang-bolt LTO+PGO target.

Thanks for the patch, Amir!

Nov 8 2022, 11:52 AM · Restricted Project
gkistanova added a comment to D137405: Add new linux worker and a legacy linux gcc build that we do internally.

The patch itself looks good.

Nov 8 2022, 11:37 AM · Restricted Project, Restricted Project

Oct 19 2022

gkistanova accepted D136223: Collapse the build requests for NVidia NVPTX builders on Windows platforms..

LGTM

Oct 19 2022, 11:50 AM · Restricted Project
gkistanova accepted D135830: Add new linux worker and dwarf5 based cross-project builder.

LGTM

Oct 19 2022, 2:51 AM · Restricted Project, Restricted Project
gkistanova accepted D136199: [BOLT] Add BOLT-NFC annotated builder.

LGTM

Oct 19 2022, 2:50 AM · Restricted Project