Hi Caroline,

LGTM

Thanks, Maxim! Looks good.
Please feel free to commit.

The repository for this diff is specified as Zorg, which does not seem right.

Thanks for working on this, Diana!

Unfortunately, SanitizerBuilder.getSanitizerBuildFactory does not accept accept extra_configure_args argument and does not pass it down to the script.

LGTM

LGTM

Thanks for fixing this!

Statically linked LLVM + LLD builds with this patch.

Fair enough. Reverted.
https://github.com/llvm/llvm-project/commit/cdcb9ab10e53ff08293915af3cd897c42112bcc5

Hi Petr,

Hi Mateusz,
Yes, this looks like a separate patch on top of this revert.

I have checked this patch with http://lab.llvm.org:8011/builders/lld-perf-testsuite bot. It makes it green.

@haampie Are you working on fixing the http://lab.llvm.org:8011/builders/lld-perf-testsuite bot? This patch has broken it.

LGTM

Thanks! Please feel free to commit.

LGTM

LGTM

Looks Ok with one problem.

https://reviews.llvm.org/rZORG0e45046f4212 should fix this for you.

LGTM

Ok. Let’s see how this will work in the reality.

A script could be "external" as long as it is a part of the LLVM code base, i.e. committed under https://github.com/llvm to be available to others for review, use, and improve according to the "Apache 2.0 License with LLVM exceptions” and the Developer Policy.
llvm-zorg is the right place for the components of CI, but if your script is also used for generic builds, it is fine to have it as a part of CUDA.

Hello Artem,

Hello Artem,

Hello Christian,

LGTM

Hi Sameer,

This patch introduced a test failure on FreeBSD.
The error message is different than what's the expected by the test.

Now the script runs before LLVM source tree has been checked out, so there's no sources for me to work with. AFAICT, revision hash is not available in the environment, so there's no way for me to check out the correct revision.

I have changed the staging to invoke /buildbot/external.py.
http://lab.llvm.org:8014/builders/clang-cuda-gce-build/builds/313/steps/annotate/logs/stdio

You could put that script somewhere local and give me the fully qualified path to that script.I'll set the staging accordingly.

LGTM

Staging is ready for your experiments.

I can temporarily set you up like this in the staging. You would do all the experiments you are after, tinker, and such. Once you are happy you could prepare a final patch for the review.
For how long do you expect tinkering?

Thanks for updating the patch, Artem.

Hello Artem.