- User Since
- Mar 22 2013, 2:32 PM (430 w, 3 d)
Fri, Jun 18
The patch has been committed on your behalf.
Thu, Jun 17
Do you need a help with the commit?
The staging is ready for you. Please feel free to commit.
Please feel free to connect to the staging.
Thu, May 27
Frankly, I don't like the idea of allowing failing tests, definitely not in production. I see what you want to achieve with this, though.
May 20 2021
May 19 2021
May 18 2021
May 17 2021
Did you analyze what's the most often reason of git fetch failures? Shall we also set clobberOnFailure to escalate a clone?
May 13 2021
If this is fine with you, let's finish this patch first, stage the builder to make sure it is reliably green, then you could move it to the production build bot and add to the release_builders.py.
May 12 2021
Also I had questions on about if I needed to rebuild llvm, clang and lld-devel to test; is it possible to use what was built beforehand by previous tests on the same commit ?
And I was even looking at it there!
But please wait for the patch Andrzej mentioned before committing.
LitTestCommand parses LIT logs only and is not intended to parse anything else, AnnotatedCommand parses annotations only and is not intended to parse anything else. NinjaCommand could build (build logs), test (LIT logs), install (install logs).
Before committing, could you make sure you are based on the current UnifiedTreeBuilder and LLVMBuildFactory, please?
If I remember the context correctly, you may need to specify enable_runtimes="auto", since the default behavior has been changed in https://reviews.llvm.org/rZORGf7b888457641 per request.
I would not characterize the ninja invocation doing the build as a "single command".
So, your builder does not send anything to TTY for more than 20 minutes during a normal regular build. Meaning that a single commands takes longer than 20 minutes to execute.
May 10 2021
Almost forgot to mention.
Sorry for the delay.
May 4 2021
Anyway, the default has been changed in https://reviews.llvm.org/rZORGf7b888457641 to not use LLVM_ENABLE_RUNTIMES unless explicitly requested.
That should address your concern.
Thanks again, Michael.
This is why I asked if you know what builders should build without using LLVM_ENABLE_RUNTIMES but now they don't.
The change we are discussing does not necessarily mean that LLVM_ENABLE_RUNTIMES is always engaged.
To make sure I'll check the fix, could you point me to a particular builder or builders where you see the problem, please?
Apr 30 2021
Thanks for the patch, Michael!
Please see my comments inline.
Apr 29 2021
This patch introduced a bug.
Looks good with a nitpick.
Apr 22 2021
Looks good with a nitpick. Please see my comment inline.
Thanks! Looks good now.
Yep. The raw diff looks good.
Sorry for reverting your patches, but I do not see a quick and easy way to fix the problems it has introduced.
Apr 21 2021
Apr 20 2021
Looks good with a nit pick.
Could you clean the patch off of the unrelated changes, please?
Apr 19 2021
Could you also clean up config/workers.py and config/status.py from the unused now workers, please?
Apr 15 2021
No. Cuda builders got that in the code base as a temporary solution while they are working on their annotated script. Exactly the same arguments as yours. And I see that being confusing, and don't think it worth it after all.
Apr 7 2021
Thanks for updating the LLVM Developer Policy, Christian.
It looks good with a couple nit picks.
Apr 6 2021
Everything else looks Ok.
Mar 25 2021
Mar 24 2021
Hm. This is weird.
I see a wrong patch assigned to this review now.,
Looks much better now.
One problem to fix.
Mar 23 2021
Mar 20 2021
I have added the support you need to UnifiedTreeBuilder.
Mar 19 2021
There are few comments for the buildbot part.
Mar 12 2021
Mar 2 2021
Looks good with a couple of nit picks.
Please see my comments in line.
Looks good with a couple nit picks.
Please see my comments in line.
It is good with a couple of small things to address.
It seems this patch needs more attention.
Please see my comments above.
I'm not sure I follow what are you trying to achieve by changing the src_root.
Christian, do you need a help with committing this patch? You should be good if you have LLVM commit permissions, but please let me know if you want me to commit.
Feb 24 2021
Feb 21 2021