gkistanova (Galina)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 22 2013, 2:32 PM (217 w, 3 d)

Recent Activity

Today

gkistanova committed rL303653: Removed fallthrough annotation which does not directly precede switch label..
Removed fallthrough annotation which does not directly precede switch label.
Tue, May 23, 9:56 AM
gkistanova committed rL303649: Added LLVM_FALLTHROUGH to address gcc warning: this statement may fall through..
Added LLVM_FALLTHROUGH to address gcc warning: this statement may fall through.
Tue, May 23, 9:33 AM

Yesterday

gkistanova committed rL303604: Added LLVM_FALLTHROUGH to address gcc warning: this statement may fall through..
Added LLVM_FALLTHROUGH to address gcc warning: this statement may fall through.
Mon, May 22, 10:18 PM
gkistanova committed rL303602: Cosmetic. Added braces to address gcc warning: suggest explicit braces to avoid….
Cosmetic. Added braces to address gcc warning: suggest explicit braces to avoid…
Mon, May 22, 10:00 PM
gkistanova committed rL303597: Added LLVM_FALLTHROUGH to address gcc warning: this statement may fall through..
Added LLVM_FALLTHROUGH to address gcc warning: this statement may fall through.
Mon, May 22, 6:21 PM
gkistanova committed rL303595: Added LLVM_FALLTHROUGH to address gcc warning: this statement may fall through..
Added LLVM_FALLTHROUGH to address gcc warning: this statement may fall through.
Mon, May 22, 6:07 PM
gkistanova committed rL303585: Added LLVM_FALLTHROUGH to address gcc warning: this statement may fall through..
Added LLVM_FALLTHROUGH to address gcc warning: this statement may fall through.
Mon, May 22, 3:46 PM

Fri, May 19

gkistanova added a comment to D33148: add generic annotated builder and clang-with-thin-lto-windows.

Thanks for addressing the comments, Bob.
We are getting there.

Fri, May 19, 5:16 PM
gkistanova committed rL303471: Cosmetic. Added braces to address gcc warning: suggest explicit braces to avoid….
Cosmetic. Added braces to address gcc warning: suggest explicit braces to avoid…
Fri, May 19, 5:15 PM
gkistanova committed rL303457: Added LLVM_FALLTHROUGH to address gcc warning: this statement may fall through..
Added LLVM_FALLTHROUGH to address gcc warning: this statement may fall through.
Fri, May 19, 2:21 PM
gkistanova committed rL303454: Added missing break..
Added missing break.
Fri, May 19, 1:45 PM
gkistanova committed rL303449: Lit now only supports process pools. This is a leftover from when the.
Lit now only supports process pools. This is a leftover from when the
Fri, May 19, 1:04 PM

Thu, May 18

gkistanova committed rL303375: LLVM_FALLTHROUGH instead of fall-through comment..
LLVM_FALLTHROUGH instead of fall-through comment.
Thu, May 18, 1:15 PM
gkistanova committed rL303365: Reduce gcc-7 warnings by fall-through comments..
Reduce gcc-7 warnings by fall-through comments.
Thu, May 18, 11:07 AM

Wed, May 17

gkistanova requested changes to D33148: add generic annotated builder and clang-with-thin-lto-windows.

Hello Bob,

Wed, May 17, 12:50 PM

Tue, May 16

gkistanova committed rL303229: Added LLVM_DUMP_METHOD attributes for MatchableInfo::dump(). Defined it only if….
Added LLVM_DUMP_METHOD attributes for MatchableInfo::dump(). Defined it only if…
Tue, May 16, 7:33 PM

Fri, May 12

gkistanova committed rL302922: Make sure we have actually written what is expected by the test..
Make sure we have actually written what is expected by the test.
Fri, May 12, 10:13 AM

Mon, May 8

gkistanova committed rL302478: Skip install step if not requested..
Skip install step if not requested.
Mon, May 8, 4:08 PM
gkistanova committed rL302477: Changed a default source code directory from llvm.src to llvm..
Changed a default source code directory from llvm.src to llvm.
Mon, May 8, 4:00 PM
gkistanova committed rL302457: Set ENABLE_WERROR=OFF for ABITestsuitBuilder..
Set ENABLE_WERROR=OFF for ABITestsuitBuilder.
Mon, May 8, 12:44 PM
gkistanova committed rL302455: Fixed 'haltOnFailure' for build step..
Fixed 'haltOnFailure' for build step.
Mon, May 8, 12:13 PM

Wed, May 3

gkistanova committed rL302075: Refactored ABITestsuitBuilder to use UnifiedTreeBuilder, so it could track the….
Refactored ABITestsuitBuilder to use UnifiedTreeBuilder, so it could track the…
Wed, May 3, 1:38 PM
gkistanova committed rL302074: Remove source code only if clean build has been requested by a property..
Remove source code only if clean build has been requested by a property.
Wed, May 3, 1:35 PM

Fri, Apr 28

gkistanova committed rL301733: Remove the source code as well if a clean build is requested by a property….
Remove the source code as well if a clean build is requested by a property…
Fri, Apr 28, 7:51 PM
gkistanova committed rL301708: Added new slave for builder clang-lld-x86_64-2stage..
Added new slave for builder clang-lld-x86_64-2stage.
Fri, Apr 28, 3:50 PM
gkistanova committed rL301675: Added support for the 'clean' property..
Added support for the 'clean' property.
Fri, Apr 28, 1:29 PM

Mon, Apr 24

gkistanova committed rL301253: Cosmetic change..
Cosmetic change.
Mon, Apr 24, 2:19 PM
gkistanova committed rL301248: Small addition on how to add a builder..
Small addition on how to add a builder.
Mon, Apr 24, 2:01 PM

Apr 19 2017

gkistanova committed rL300783: Temporarily revert r299221 to fix nondeterminism in ThinLTO builder..
Temporarily revert r299221 to fix nondeterminism in ThinLTO builder.
Apr 19 2017, 4:29 PM

Apr 14 2017

gkistanova committed rL300378: Added support for the 'clean' property..
Added support for the 'clean' property.
Apr 14 2017, 4:58 PM
gkistanova accepted D31126: Do not run tests for crash recovery if libstdc++ safe mode is enabled.

LGTM

Apr 14 2017, 10:50 AM

Apr 12 2017

gkistanova committed rL300166: No need to create a build directory, it will be created by the next step..
No need to create a build directory, it will be created by the next step.
Apr 12 2017, 8:46 PM
gkistanova committed rL300095: Updated list of builders for myself..
Updated list of builders for myself.
Apr 12 2017, 12:50 PM

Apr 11 2017

gkistanova committed rL300013: Added support for requesting a clean build from a commit comment..
Added support for requesting a clean build from a commit comment.
Apr 11 2017, 5:43 PM

Apr 3 2017

gkistanova committed rL299410: Modules/builtins.m requires shell..
Modules/builtins.m requires shell.
Apr 3 2017, 8:03 PM

Mar 10 2017

gkistanova committed rL297497: Attempt to fix Windows buildbot..
Attempt to fix Windows buildbot.
Mar 10 2017, 11:46 AM
gkistanova committed rL297445: Verbose lit logs for llvm-clang-x86_64-expensive-checks-win builder..
Verbose lit logs for llvm-clang-x86_64-expensive-checks-win builder.
Mar 10 2017, 12:10 AM
gkistanova committed rL297444: No stage name for a single stage build..
No stage name for a single stage build.
Mar 10 2017, 12:08 AM

Mar 9 2017

gkistanova committed rL297435: Added new builder llvm-clang-x86_64-expensive-checks-win..
Added new builder llvm-clang-x86_64-expensive-checks-win.
Mar 9 2017, 5:21 PM
gkistanova committed rL297434: Added support for MSVC build..
Added support for MSVC build.
Mar 9 2017, 5:18 PM

Mar 8 2017

gkistanova committed rL297335: Removed builder clang-3stage-ubuntu temporally..
Removed builder clang-3stage-ubuntu temporally.
Mar 8 2017, 4:34 PM

Mar 6 2017

gkistanova committed rL297123: Reverted r297041..
Reverted r297041.
Mar 6 2017, 11:03 PM
gkistanova committed rL297041: Fixed paths issues in getSanitizerWindowsBuildFactory..
Fixed paths issues in getSanitizerWindowsBuildFactory.
Mar 6 2017, 10:32 AM

Mar 4 2017

gkistanova committed rL296983: Added InterpolateToNativePath and InterpolateToPosixPath classes..
Added InterpolateToNativePath and InterpolateToPosixPath classes.
Mar 4 2017, 7:50 PM

Mar 2 2017

gkistanova added a comment to D30505: Allow users to force clean builds from the web.

Hello Reid,

Mar 2 2017, 3:32 PM

Feb 21 2017

gkistanova committed rL295806: Reverted r295785, as the buildslave does not support "env" command..
Reverted r295785, as the buildslave does not support "env" command.
Feb 21 2017, 7:21 PM
gkistanova added a comment to D30231: Replace backslashes with forward slashes.

Galina, do you know how to get the working directory with forward slashes instead of backslashes?

Feb 21 2017, 3:48 PM
gkistanova added a comment to D30231: Replace backslashes with forward slashes.

Hi Zachary,

Feb 21 2017, 3:39 PM
gkistanova committed rL295785: Added a workaround for Windows paths in cmake arguments..
Added a workaround for Windows paths in cmake arguments.
Feb 21 2017, 3:24 PM

Feb 9 2017

gkistanova added a comment to D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows..

I'll restart the master at the end of the day today.

Feb 9 2017, 2:19 PM
gkistanova added a comment to D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows..

Hi Zachary,

Feb 9 2017, 2:02 PM
gkistanova added a comment to D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows..

Yes, please, once this change is landed.
Just stop the slave, point it to the silent master, and start it again. It should connect with the same credentials.
In a day or two of the reliably green builds on the staging, feel free to return it back to the normal build master.

Feb 9 2017, 1:20 PM
gkistanova added inline comments to D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows..
Feb 9 2017, 12:09 PM
gkistanova accepted D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows..

Hello Marcos,

Feb 9 2017, 12:08 PM

Feb 8 2017

gkistanova requested changes to D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows..

We run buildbot 0.8.5 on the master. It does not have Interpolate.
So, please use WithProperties instead.

Feb 8 2017, 4:17 PM
gkistanova requested changes to D29677: [buildbot] Add check-fuzzer to Asan buildbot on Windows..

Hello Marcos,

Feb 8 2017, 11:17 AM

Jan 27 2017

gkistanova requested changes to D28663: [zorg] Delete two unused functions from UnifiedTreeBuilder.

These are unused yet and there for purpose.
Do these cause any problem for you? If so, could you elaborate, please?

Jan 27 2017, 12:35 PM
gkistanova added a comment to D28664: [zorg] Remove old autotools getLLDBBuildFactory.

Did you discuss this in the lldb list and got a confirmation that no one is using this for downstream builds and private builders?

Jan 27 2017, 12:25 PM
gkistanova requested changes to D28665: [zorg] Remove unused run_* options from getClangBuildFactory.

As far as I remember David Blaikie had plans on builder clang-x86_64-ubuntu-gdb-75.
Please contact him on removing the builder.

Jan 27 2017, 11:33 AM
gkistanova accepted D28660: [zorg] Delete NightlyTest and friends.

LGTM

Jan 27 2017, 11:06 AM

Jan 17 2017

gkistanova committed rL292344: Removed redundant steps; fixed the wrong clang version formatting..
Removed redundant steps; fixed the wrong clang version formatting.
Jan 17 2017, 9:52 PM

Jan 9 2017

gkistanova accepted D28492: [buildbot] Add slave to test libomp for ppc64le targets..
Jan 9 2017, 4:42 PM
gkistanova added a comment to D28492: [buildbot] Add slave to test libomp for ppc64le targets..

LGTM.

Jan 9 2017, 4:32 PM

Jan 6 2017

gkistanova committed rL291327: Reduce jobs number for builder clang-with-thin-lto-ubuntu..
Reduce jobs number for builder clang-with-thin-lto-ubuntu.
Jan 6 2017, 6:02 PM
gkistanova committed rL291325: Added jobs arg to builder clang-with-thin-lto-ubuntu..
Added jobs arg to builder clang-with-thin-lto-ubuntu.
Jan 6 2017, 5:48 PM

Jan 3 2017

gkistanova accepted D27771: [buildbot] switch CUDA buildbot to use CUDATestsuiteBuilder..

LGTM

Jan 3 2017, 1:50 PM
gkistanova requested changes to D27771: [buildbot] switch CUDA buildbot to use CUDATestsuiteBuilder..

The params there do not match what was committed for the factory.
Please check.

Jan 3 2017, 11:52 AM

Jan 2 2017

gkistanova committed rL290855: Some code cleaning for UnifiedTreeBuilder..
Some code cleaning for UnifiedTreeBuilder.
Jan 2 2017, 8:20 PM

Dec 23 2016

gkistanova committed rL290454: Added new builder clang-lld-x86_64-2stage..
Added new builder clang-lld-x86_64-2stage.
Dec 23 2016, 2:30 PM

Dec 21 2016

gkistanova committed rL290293: Added a unified tree multi-stage build factory..
Added a unified tree multi-stage build factory.
Dec 21 2016, 4:57 PM
gkistanova accepted D27766: [buildbot] Added CUDATestsuiteBuilder.py.

LGTM.
Thanks for the changes, Artem.

Dec 21 2016, 1:22 PM

Dec 20 2016

gkistanova committed rL290220: Overwrite the jobs properties if specified as a factory argument..
Overwrite the jobs properties if specified as a factory argument.
Dec 20 2016, 4:57 PM
gkistanova added a comment to D27766: [buildbot] Added CUDATestsuiteBuilder.py.

It is almost there.

Dec 20 2016, 4:40 PM

Dec 17 2016

gkistanova requested changes to D27766: [buildbot] Added CUDATestsuiteBuilder.py.

Thanks for working on this, Artem.

Dec 17 2016, 11:09 PM

Dec 16 2016

gkistanova added a comment to D27771: [buildbot] switch CUDA buildbot to use CUDATestsuiteBuilder..

Only changes in llvm and clang repo would trigger a build on this builder. Is this intentional?

Dec 16 2016, 2:35 PM

Dec 6 2016

gkistanova added a comment to D25398: [lit] Use path as test suite name.

LitTestCommand parses LIT printout, looking for the ::, then uses the built "path" to make temp files with log chunks.

Dec 6 2016, 11:35 AM

Nov 21 2016

gkistanova committed rL287601: Added skipped checkout_lld argument to getClangBuildFactory..
Added skipped checkout_lld argument to getClangBuildFactory.
Nov 21 2016, 4:33 PM

Nov 18 2016

gkistanova committed rL287396: Added missing comma..
Added missing comma.
Nov 18 2016, 3:27 PM
gkistanova accepted D26783: Set up an AVR buildslave.

LGTM

Nov 18 2016, 10:17 AM

Nov 15 2016

gkistanova committed rL286988: Added a new slave for docs builders..
Added a new slave for docs builders.
Nov 15 2016, 9:56 AM

Nov 7 2016

gkistanova committed rL286175: get3StageClangLTOBuildFactory - increased timeout for the test step..
get3StageClangLTOBuildFactory - increased timeout for the test step.
Nov 7 2016, 3:26 PM

Oct 31 2016

gkistanova committed rL285626: Changed builder clang-bpf-build to use getClangCMakeBuildFactory..
Changed builder clang-bpf-build to use getClangCMakeBuildFactory.
Oct 31 2016, 12:38 PM

Oct 27 2016

gkistanova committed rL285374: Remove directory should not flunk on failure. It might be missing in the first….
Remove directory should not flunk on failure. It might be missing in the first…
Oct 27 2016, 6:36 PM
gkistanova committed rL285373: Reverted r285335, as some of recent Windows buildslaves do not handle….
Reverted r285335, as some of recent Windows buildslaves do not handle…
Oct 27 2016, 6:27 PM
gkistanova committed rL285335: Use buildbot RemoveDirectory instead of platform-dependent rm/rmdir command..
Use buildbot RemoveDirectory instead of platform-dependent rm/rmdir command.
Oct 27 2016, 12:47 PM
gkistanova committed rL285334: Removed redundant step..
Removed redundant step.
Oct 27 2016, 12:44 PM

Oct 20 2016

gkistanova committed rL284767: A bit different handling for the lto param..
A bit different handling for the lto param.
Oct 20 2016, 1:04 PM
gkistanova committed rL284765: Changed getClangWithLTOBuildFactory to configure with cmake options only..
Changed getClangWithLTOBuildFactory to configure with cmake options only.
Oct 20 2016, 11:50 AM

Oct 18 2016

gkistanova committed rL284569: Corrected jobs numbers for builders of slave ps4-buildslave1a..
Corrected jobs numbers for builders of slave ps4-buildslave1a.
Oct 18 2016, 10:37 PM
gkistanova committed rL284568: Added builder clang-with-thin-lto-ubuntu..
Added builder clang-with-thin-lto-ubuntu.
Oct 18 2016, 10:24 PM
gkistanova committed rL284558: Done switch from VS2013 to VS2015 for builder clang-x64-ninja-win7..
Done switch from VS2013 to VS2015 for builder clang-x64-ninja-win7.
Oct 18 2016, 5:29 PM

Oct 15 2016

gkistanova committed rL284330: Added support for gold as a system linker..
Added support for gold as a system linker.
Oct 15 2016, 10:11 PM

Oct 13 2016

gkistanova committed rL284153: Added support for ThinLTO..
Added support for ThinLTO.
Oct 13 2016, 12:41 PM

Oct 11 2016

gkistanova committed rL283846: Changed jobs to be one of the pass-trough kwargs..
Changed jobs to be one of the pass-trough kwargs.
Oct 11 2016, 3:07 AM
gkistanova committed rL283845: Re-factored to take the jobs property every time a build step gets created….
Re-factored to take the jobs property every time a build step gets created…
Oct 11 2016, 3:07 AM
gkistanova committed rL283844: Re-factored to take the jobs property every time a build step gets created….
Re-factored to take the jobs property every time a build step gets created…
Oct 11 2016, 3:07 AM

Oct 7 2016

gkistanova committed rL283597: Added build factories for the unified tree builder..
Added build factories for the unified tree builder.
Oct 7 2016, 1:57 PM
gkistanova committed rL283595: Refactored to support extra options..
Refactored to support extra options.
Oct 7 2016, 1:54 PM
gkistanova committed rL283594: Added MakeCommand..
Added MakeCommand.
Oct 7 2016, 1:46 PM
gkistanova committed rL283592: Refactored to support extra options..
Refactored to support extra options.
Oct 7 2016, 1:45 PM