Page MenuHomePhabricator

kaz7 (Kazushi Marukawa)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 11 2019, 7:43 PM (51 w, 5 h)

Recent Activity

Today

kaz7 requested review of D92550: [VE] Add vsll, vsrl, vsla, vsra, and vsfa intrinsic instructions.
Thu, Dec 3, 12:40 AM · Restricted Project, Restricted Project
kaz7 committed rGb91238173dd9: [VE] Add veqv and vseq intrinsic instructions (authored by kaz7).
[VE] Add veqv and vseq intrinsic instructions
Thu, Dec 3, 12:39 AM
kaz7 closed D92527: [VE] Add veqv and vseq intrinsic instructions.
Thu, Dec 3, 12:39 AM · Restricted Project, Restricted Project

Yesterday

kaz7 requested review of D92527: [VE] Add veqv and vseq intrinsic instructions.
Wed, Dec 2, 5:19 PM · Restricted Project, Restricted Project
kaz7 committed rGdd0159bd8141: [VE] Add vand, vor, and vxor intrinsic instructions (authored by kaz7).
[VE] Add vand, vor, and vxor intrinsic instructions
Wed, Dec 2, 5:53 AM
kaz7 closed D92454: [VE] Add vand, vor, and vxor intrinsic instructions.
Wed, Dec 2, 5:53 AM · Restricted Project, Restricted Project

Tue, Dec 1

kaz7 requested review of D92454: [VE] Add vand, vor, and vxor intrinsic instructions.
Tue, Dec 1, 8:23 PM · Restricted Project, Restricted Project
kaz7 planned changes to D92386: [VE] Add standard include path and library path for C++.
Tue, Dec 1, 8:10 PM · Restricted Project, Restricted Project
kaz7 committed rGc1762bcf0a3b: [VE] Add vcmp, vmax, and vmin intrinsic instructions (authored by kaz7).
[VE] Add vcmp, vmax, and vmin intrinsic instructions
Tue, Dec 1, 6:17 PM
kaz7 closed D92387: [VE] Add vcmp, vmax, and vmin intrinsic instructions.
Tue, Dec 1, 6:17 PM · Restricted Project, Restricted Project
kaz7 requested review of D92387: [VE] Add vcmp, vmax, and vmin intrinsic instructions.
Tue, Dec 1, 6:04 AM · Restricted Project, Restricted Project
kaz7 committed rG10b164d2f72a: [VE] Add vmul and vdiv intrinsic instructions (authored by kaz7).
[VE] Add vmul and vdiv intrinsic instructions
Tue, Dec 1, 6:04 AM
kaz7 closed D92377: [VE] Add vmul and vdiv intrinsic instructions.
Tue, Dec 1, 6:04 AM · Restricted Project, Restricted Project
kaz7 requested review of D92386: [VE] Add standard include path and library path for C++.
Tue, Dec 1, 6:02 AM · Restricted Project, Restricted Project
kaz7 requested review of D92377: [VE] Add vmul and vdiv intrinsic instructions.
Tue, Dec 1, 3:09 AM · Restricted Project, Restricted Project
kaz7 committed rGc3fe6ea22e96: [VE] Add vadd and vsub intrinsic instructions (authored by kaz7).
[VE] Add vadd and vsub intrinsic instructions
Tue, Dec 1, 2:57 AM
kaz7 closed D92332: [VE] Add vadd and vsub intrinsic instructions.
Tue, Dec 1, 2:57 AM · Restricted Project, Restricted Project

Mon, Nov 30

kaz7 committed rG3d872cbc2fd3: [VE][NFC] Update comments (authored by kaz7).
[VE][NFC] Update comments
Mon, Nov 30, 9:57 AM
kaz7 requested review of D92332: [VE] Add vadd and vsub intrinsic instructions.
Mon, Nov 30, 9:33 AM · Restricted Project, Restricted Project
kaz7 committed rG6834b3d6d52a: [VE] Optimize prologue/epilogue instructions about GOT (authored by kaz7).
[VE] Optimize prologue/epilogue instructions about GOT
Mon, Nov 30, 9:23 AM
kaz7 closed D92313: [VE] Optimize prologue/epilogue instructions about GOT.
Mon, Nov 30, 9:22 AM · Restricted Project, Restricted Project
kaz7 committed rG6fe610535f4e: [VE] Clean check routines of branch types (authored by kaz7).
[VE] Clean check routines of branch types
Mon, Nov 30, 9:20 AM
kaz7 closed D92254: [VE] Clean check routines of branch types.
Mon, Nov 30, 9:19 AM · Restricted Project, Restricted Project
kaz7 updated the diff for D92254: [VE] Clean check routines of branch types.

Update comments following suggestions.

Mon, Nov 30, 5:52 AM · Restricted Project, Restricted Project
kaz7 requested review of D92313: [VE] Optimize prologue/epilogue instructions about GOT.
Mon, Nov 30, 5:33 AM · Restricted Project, Restricted Project
kaz7 committed rG686988a50f50: [VE] Optimize prologue/epilogue instructions (authored by kaz7).
[VE] Optimize prologue/epilogue instructions
Mon, Nov 30, 5:22 AM
kaz7 closed D92251: [VE] Optimize prologue/epilogue instructions.
Mon, Nov 30, 5:22 AM · Restricted Project, Restricted Project
kaz7 planned changes to D92254: [VE] Clean check routines of branch types.

Thank you for reviewing.

Mon, Nov 30, 5:21 AM · Restricted Project, Restricted Project
kaz7 committed rG44a679eaa40c: [VE] Change the behaviour of truncate (authored by kaz7).
[VE] Change the behaviour of truncate
Mon, Nov 30, 5:13 AM
kaz7 closed D92226: [VE] Change the behaviour of truncate.
Mon, Nov 30, 5:12 AM · Restricted Project, Restricted Project
kaz7 committed rG33eac0f2830e: [VE] Specify vector alignments (authored by kaz7).
[VE] Specify vector alignments
Mon, Nov 30, 5:09 AM
kaz7 closed D92256: [VE] Specify vector alignments.
Mon, Nov 30, 5:09 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Nov 27

kaz7 requested review of D92256: [VE] Specify vector alignments.
Fri, Nov 27, 7:41 PM · Restricted Project, Restricted Project, Restricted Project
kaz7 requested review of D92254: [VE] Clean check routines of branch types.
Fri, Nov 27, 6:51 PM · Restricted Project, Restricted Project
kaz7 added inline comments to D91416: [VE] LVLGen sets VL before vector insts.
Fri, Nov 27, 4:55 PM · Restricted Project, Restricted Project
kaz7 requested review of D92251: [VE] Optimize prologue/epilogue instructions.
Fri, Nov 27, 3:47 PM · Restricted Project, Restricted Project
kaz7 committed rG3bd78b7cc00d: [VE] Optimize emitSPAdjustment function (authored by kaz7).
[VE] Optimize emitSPAdjustment function
Fri, Nov 27, 3:07 PM
kaz7 closed D92174: [VE] Optimize emitSPAdjustment function.
Fri, Nov 27, 3:06 PM · Restricted Project, Restricted Project
kaz7 added a comment to D92226: [VE] Change the behaviour of truncate.

I understand this is necessary for VE ABI compliance. Is there anything in LLVM that says a truncate has to zero-out all leading bits?

Fri, Nov 27, 2:54 PM · Restricted Project, Restricted Project
kaz7 added inline comments to D92174: [VE] Optimize emitSPAdjustment function.
Fri, Nov 27, 2:35 PM · Restricted Project, Restricted Project
kaz7 requested review of D92226: [VE] Change the behaviour of truncate.
Fri, Nov 27, 6:10 AM · Restricted Project, Restricted Project
kaz7 added inline comments to D92174: [VE] Optimize emitSPAdjustment function.
Fri, Nov 27, 5:15 AM · Restricted Project, Restricted Project
kaz7 updated the diff for D92174: [VE] Optimize emitSPAdjustment function.

Correct typo in a comment

Fri, Nov 27, 3:37 AM · Restricted Project, Restricted Project
kaz7 added inline comments to D92174: [VE] Optimize emitSPAdjustment function.
Fri, Nov 27, 3:37 AM · Restricted Project, Restricted Project

Thu, Nov 26

kaz7 requested review of D92174: [VE] Optimize emitSPAdjustment function.
Thu, Nov 26, 5:33 AM · Restricted Project, Restricted Project
kaz7 committed rGc2b49b2fb4bf: [VE] Add comprehensive stackframe tests (authored by kaz7).
[VE] Add comprehensive stackframe tests
Thu, Nov 26, 5:12 AM
kaz7 closed D92170: [VE] Add comprehensive stackframe tests.
Thu, Nov 26, 5:12 AM · Restricted Project, Restricted Project
kaz7 requested review of D92170: [VE] Add comprehensive stackframe tests.
Thu, Nov 26, 3:51 AM · Restricted Project, Restricted Project

Tue, Nov 24

kaz7 added a comment to D92027: [OpenMP] libomp: fix non-X86 non-AARCH64 builds.

Hi, it works fine for, not merged yet, VE architecture. Thank you for emergency patch.

Tue, Nov 24, 2:48 PM · Restricted Project
kaz7 added a comment to D88252: z_Linux_asm.S modifications for arm64 (AARCH64) for Darwin/macOS.

FYI.

Tue, Nov 24, 4:13 AM · Restricted Project, Restricted Project

Mon, Nov 23

kaz7 committed rG590aaa507733: [VE] Remove magic numbers 176 (authored by kaz7).
[VE] Remove magic numbers 176
Mon, Nov 23, 7:13 AM
kaz7 closed D91958: [VE] Remove magic numbers 176.
Mon, Nov 23, 7:13 AM · Restricted Project, Restricted Project
kaz7 accepted D91802: [VE] VE Vector Predicated SDNode, vector add isel and tests.

LGTM.

Mon, Nov 23, 6:12 AM · Restricted Project, Restricted Project
kaz7 requested review of D91958: [VE] Remove magic numbers 176.
Mon, Nov 23, 4:57 AM · Restricted Project, Restricted Project
kaz7 added inline comments to D91802: [VE] VE Vector Predicated SDNode, vector add isel and tests.
Mon, Nov 23, 4:34 AM · Restricted Project, Restricted Project
kaz7 committed rG677e94c0f09b: [VE] Clean canRealignStack implementation (authored by kaz7).
[VE] Clean canRealignStack implementation
Mon, Nov 23, 4:09 AM
kaz7 closed D91929: [VE] Clean canRealignStack implementation.
Mon, Nov 23, 4:09 AM · Restricted Project, Restricted Project
kaz7 committed rG3a302349ebd1: [VE][NFC] Clean stack frame description (authored by kaz7).
[VE][NFC] Clean stack frame description
Mon, Nov 23, 4:00 AM
kaz7 closed D91946: [VE][NFC] Clean stack frame description.
Mon, Nov 23, 3:59 AM · Restricted Project, Restricted Project
kaz7 added a comment to D91802: [VE] VE Vector Predicated SDNode, vector add isel and tests.

Small checks like 80 columns and indentation. And one question about how you plan to implement test cases for fold immediates.

Mon, Nov 23, 3:58 AM · Restricted Project, Restricted Project
kaz7 requested review of D91946: [VE][NFC] Clean stack frame description.
Mon, Nov 23, 1:21 AM · Restricted Project, Restricted Project
kaz7 added inline comments to D91802: [VE] VE Vector Predicated SDNode, vector add isel and tests.
Mon, Nov 23, 1:16 AM · Restricted Project, Restricted Project

Sun, Nov 22

kaz7 requested review of D91929: [VE] Clean canRealignStack implementation.
Sun, Nov 22, 2:57 AM · Restricted Project, Restricted Project

Fri, Nov 20

kaz7 committed rG4a1d230fa6f4: [VE][NFC] Modify function order and simplify comments (authored by kaz7).
[VE][NFC] Modify function order and simplify comments
Fri, Nov 20, 11:10 PM
kaz7 committed rG02b2bcd940cc: [VE] Correct types of return/argument values for getAdjustedFrameSize() (authored by kaz7).
[VE] Correct types of return/argument values for getAdjustedFrameSize()
Fri, Nov 20, 11:08 PM
kaz7 closed D91862: [VE] Correct types of return/argument values for getAdjustedFrameSize().
Fri, Nov 20, 11:08 PM · Restricted Project, Restricted Project
kaz7 added a comment to D91802: [VE] VE Vector Predicated SDNode, vector add isel and tests.

I add some comments inlined.

Fri, Nov 20, 11:04 PM · Restricted Project, Restricted Project
kaz7 planned changes to D91781: [VE] Add regression test for D91151.
Fri, Nov 20, 9:22 PM · Restricted Project, Restricted Project
kaz7 updated the diff for D91781: [VE] Add regression test for D91151.

Update regression test and rebase it. Need to inspect behavior of VEISelDAGToDAG.

Fri, Nov 20, 9:22 PM · Restricted Project, Restricted Project
kaz7 updated the diff for D91862: [VE] Correct types of return/argument values for getAdjustedFrameSize().

Rebase and correct capitalization. Also add two regression tests. The
test_frame4294967296 function didn't allocate stack frame correctly before
this modification.

Fri, Nov 20, 8:23 PM · Restricted Project, Restricted Project
kaz7 committed rGa2dc4ac86b8e: [VE][NFC] Update missing bulk update tests to use typed sret (authored by kaz7).
[VE][NFC] Update missing bulk update tests to use typed sret
Fri, Nov 20, 8:20 PM
kaz7 added a comment to D91862: [VE] Correct types of return/argument values for getAdjustedFrameSize().

It's a good question. VE has 32 bits offset, so we don't consider such large frames or data structures seriously.

Fri, Nov 20, 5:48 PM · Restricted Project, Restricted Project
kaz7 added a comment to D91781: [VE] Add regression test for D91151.

With the use of CReduce & some manual reduction, I managed to get the test down to this:

Fri, Nov 20, 4:53 AM · Restricted Project, Restricted Project
kaz7 requested review of D91862: [VE] Correct types of return/argument values for getAdjustedFrameSize().
Fri, Nov 20, 4:29 AM · Restricted Project, Restricted Project
kaz7 committed rG42389f1e96af: [VE] Change threshold for jump table generation (authored by kaz7).
[VE] Change threshold for jump table generation
Fri, Nov 20, 4:27 AM
kaz7 closed D91785: [VE] Change threshold for jump table generation.
Fri, Nov 20, 4:27 AM · Restricted Project, Restricted Project

Thu, Nov 19

kaz7 added a comment to D91781: [VE] Add regression test for D91151.

There is no assertions.

'cast' has an assertion built into it if the cast is not valid ( https://github.com/llvm-mirror/llvm/blob/master/include/llvm/Support/Casting.h#L250 ). If this dyn_cast has any effect (ie: if any execution of the program has different behavior with the dyn_cast compared to the cast) it should be true that the cast version of the code would've triggered an assertion on that same program.

Are you building/running the code with assertions enabled? (I'm not asking you to add a new assertion to the code - I'm asking if you have assertions enabled in your build so you'd see an assertion before/rather than a segmentation fault)

Thu, Nov 19, 1:33 PM · Restricted Project, Restricted Project
kaz7 added a comment to D91781: [VE] Add regression test for D91151.

Hi, @dblaikie. I generated a test case which causes a segmentation fault if we didn't apply D91151 (https://reviews.llvm.org/D91151) following your suggestion. I appreciate if you have more suggestions.

Were you testing with assertions enabled? I'd expect a test case to cause an assertion failure (when the "cast" was applied to an object that wasn't the intended type) rather than a segmentation fault.

Thu, Nov 19, 1:08 PM · Restricted Project, Restricted Project
kaz7 requested review of D91785: [VE] Change threshold for jump table generation.
Thu, Nov 19, 5:02 AM · Restricted Project, Restricted Project
kaz7 added a comment to D91781: [VE] Add regression test for D91151.

Hi, @dblaikie. I generated a test case which causes a segmentation fault if we didn't apply D91151 (https://reviews.llvm.org/D91151) following your suggestion. I appreciate if you have more suggestions.

Thu, Nov 19, 4:17 AM · Restricted Project, Restricted Project
kaz7 requested review of D91781: [VE] Add regression test for D91151.
Thu, Nov 19, 4:10 AM · Restricted Project, Restricted Project
kaz7 added a comment to D91518: [LV][NFC-ish] Allow vector widths over 256 elements.

dividing the widest register in bits by the smallest possible type width in bits (1) seems a suitable upper bound to preserve the spirit of the assert

Thu, Nov 19, 1:41 AM · Restricted Project
kaz7 added a comment to D91518: [LV][NFC-ish] Allow vector widths over 256 elements.

I thought it's a good idea when I hear it from @fhahn, but... I think It's not a good idea since 1) WidestRegister holds bit width, 2) MaxVectorSize is calculated from TTI->getRegisterBitWidth anyway.

Thu, Nov 19, 12:52 AM · Restricted Project
kaz7 accepted D91646: [VE] VEC_BROADCAST, lowering and isel.

Thanks. LGTM.

Thu, Nov 19, 12:39 AM · Restricted Project, Restricted Project

Wed, Nov 18

kaz7 added a comment to D91646: [VE] VEC_BROADCAST, lowering and isel.

Thank you for updates.

Wed, Nov 18, 3:09 PM · Restricted Project, Restricted Project
kaz7 committed rG132d6d73ea02: [VE] Add vmv intrinsic instructions (authored by kaz7).
[VE] Add vmv intrinsic instructions
Wed, Nov 18, 3:06 PM
kaz7 closed D91700: [VE] Add vmv intrinsic instructions.
Wed, Nov 18, 3:05 PM · Restricted Project, Restricted Project
kaz7 requested review of D91700: [VE] Add vmv intrinsic instructions.
Wed, Nov 18, 5:01 AM · Restricted Project, Restricted Project
kaz7 added inline comments to D91646: [VE] VEC_BROADCAST, lowering and isel.
Wed, Nov 18, 3:31 AM · Restricted Project, Restricted Project

Tue, Nov 17

kaz7 committed rGf4517bbd7340: [VE] Implement JumpTable (authored by kaz7).
[VE] Implement JumpTable
Tue, Nov 17, 5:43 AM
kaz7 closed D91582: [VE] Implement JumpTable.
Tue, Nov 17, 5:43 AM · Restricted Project, Restricted Project
kaz7 added a comment to D91518: [LV][NFC-ish] Allow vector widths over 256 elements.

I think removing this is good idea, but I'm not sure why the maximum vector size was limited to 64 and recently jumped up to 256. So, I cannot say LGTM atm. Does anyone know background on this?

Tue, Nov 17, 5:38 AM · Restricted Project
kaz7 committed rG5872cab84937: [VE] Correct getMnemonic (authored by kaz7).
[VE] Correct getMnemonic
Tue, Nov 17, 5:34 AM
kaz7 closed D91619: [VE] Correct getMnemonic.
Tue, Nov 17, 5:33 AM · Restricted Project, Restricted Project
kaz7 requested review of D91619: [VE] Correct getMnemonic.
Tue, Nov 17, 4:53 AM · Restricted Project, Restricted Project
kaz7 committed rG3a5c0ea895f4: [VE] Add vbrd intrinsic instructions (authored by kaz7).
[VE] Add vbrd intrinsic instructions
Tue, Nov 17, 2:04 AM
kaz7 closed D91569: [VE] Add vbrd intrinsic instructions.
Tue, Nov 17, 2:04 AM · Restricted Project, Restricted Project

Mon, Nov 16

kaz7 added a comment to D91151: [VE][NFC] Change cast to dyn_cast.

@dblaikie, Thank you for suggestion. I'll try to make it tonight.

Mon, Nov 16, 8:23 PM · Restricted Project, Restricted Project
kaz7 updated the diff for D91582: [VE] Implement JumpTable.

Update by following clang-tidy.

Mon, Nov 16, 6:42 PM · Restricted Project, Restricted Project
kaz7 requested review of D91582: [VE] Implement JumpTable.
Mon, Nov 16, 5:16 PM · Restricted Project, Restricted Project