Page MenuHomePhabricator

kaz7 (Kazushi Marukawa)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 11 2019, 7:43 PM (133 w, 6 d)

Recent Activity

Yesterday

kaz7 committed rGda5a6b2bf574: [VE] Restructure eliminateFrameIndex (authored by kaz7).
[VE] Restructure eliminateFrameIndex
Tue, Jul 5, 4:00 AM · Restricted Project, Restricted Project
kaz7 closed D129034: [VE] Restructure eliminateFrameIndex.
Tue, Jul 5, 4:00 AM · Restricted Project, Restricted Project, Restricted Project
kaz7 updated the diff for D129034: [VE] Restructure eliminateFrameIndex.

Add missing DEBUG_TYPE.

Tue, Jul 5, 3:44 AM · Restricted Project, Restricted Project, Restricted Project
kaz7 reopened D129034: [VE] Restructure eliminateFrameIndex.
Tue, Jul 5, 3:44 AM · Restricted Project, Restricted Project, Restricted Project
kaz7 added a reverting change for rG98e52e8bff52: [VE] Restructure eliminateFrameIndex: rG9ad38e5288a1: Revert "[VE] Restructure eliminateFrameIndex".
Tue, Jul 5, 3:36 AM · Restricted Project, Restricted Project
kaz7 committed rG9ad38e5288a1: Revert "[VE] Restructure eliminateFrameIndex" (authored by kaz7).
Revert "[VE] Restructure eliminateFrameIndex"
Tue, Jul 5, 3:36 AM · Restricted Project, Restricted Project
kaz7 added a reverting change for D129034: [VE] Restructure eliminateFrameIndex: rG9ad38e5288a1: Revert "[VE] Restructure eliminateFrameIndex".
Tue, Jul 5, 3:35 AM · Restricted Project, Restricted Project, Restricted Project
kaz7 committed rG98e52e8bff52: [VE] Restructure eliminateFrameIndex (authored by kaz7).
[VE] Restructure eliminateFrameIndex
Tue, Jul 5, 3:28 AM · Restricted Project, Restricted Project
kaz7 closed D129034: [VE] Restructure eliminateFrameIndex.
Tue, Jul 5, 3:28 AM · Restricted Project, Restricted Project, Restricted Project

Sat, Jul 2

kaz7 updated the diff for D129034: [VE] Restructure eliminateFrameIndex.

Add regression tests and support the case like the first 8 bytes fits in
the immediate field but the second 8 bytes doesn't fit in the immediate
field.

Sat, Jul 2, 3:54 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Jul 1

kaz7 requested review of D129034: [VE] Restructure eliminateFrameIndex.
Fri, Jul 1, 10:16 PM · Restricted Project, Restricted Project, Restricted Project
kaz7 committed rGde690a643895: [VE][NFC] Correct comment (authored by kaz7).
[VE][NFC] Correct comment
Fri, Jul 1, 3:25 AM · Restricted Project, Restricted Project

Thu, Jun 30

kaz7 committed rGadbb46ea651c: [VE] Support load/store vm regsiters (authored by kaz7).
[VE] Support load/store vm regsiters
Thu, Jun 30, 4:26 PM · Restricted Project, Restricted Project
kaz7 closed D128610: [VE] Support load/store vm regsiters.
Thu, Jun 30, 4:25 PM · Restricted Project, Restricted Project, Restricted Project

Sun, Jun 26

kaz7 requested review of D128610: [VE] Support load/store vm regsiters.
Sun, Jun 26, 7:30 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 20

kaz7 committed rG5ba0a9571b3e: [Clang][VE] Add missing intrinsics (authored by kaz7).
[Clang][VE] Add missing intrinsics
Mon, Jun 20, 3:30 PM · Restricted Project, Restricted Project
kaz7 closed D128120: [Clang][VE] Add missing intrinsics.
Mon, Jun 20, 3:30 PM · Restricted Project, Restricted Project, Restricted Project

Sat, Jun 18

kaz7 committed rGf61f7be0c76b: [VE][NFC] Remove obsoleted function declaration (authored by kaz7).
[VE][NFC] Remove obsoleted function declaration
Sat, Jun 18, 9:34 PM · Restricted Project, Restricted Project
kaz7 requested review of D128120: [Clang][VE] Add missing intrinsics.
Sat, Jun 18, 7:22 AM · Restricted Project, Restricted Project, Restricted Project

Sun, Jun 12

kaz7 added a reverting change for rGc1b610307df2: [NFC] Remove 'br i1 undef' from SROA tests: rGa43c55dcd740: Revert "[NFC] Remove 'br i1 undef' from SROA tests".
Sun, Jun 12, 8:35 PM · Restricted Project, Restricted Project
kaz7 committed rGa43c55dcd740: Revert "[NFC] Remove 'br i1 undef' from SROA tests" (authored by kaz7).
Revert "[NFC] Remove 'br i1 undef' from SROA tests"
Sun, Jun 12, 8:35 PM · Restricted Project, Restricted Project

Sat, Jun 11

kaz7 committed rG140ad7d37813: [Clang][VE][NFC] Fix a comment (authored by kaz7).
[Clang][VE][NFC] Fix a comment
Sat, Jun 11, 6:28 PM · Restricted Project, Restricted Project

Mon, Jun 6

kaz7 added a comment to D125839: [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in DebugTypeVisitor.

Thank you, @chapuni and @ahatanak, for quick fixing.

Mon, Jun 6, 8:15 PM · debug-info, Restricted Project, Restricted Project
kaz7 added a comment to D125839: [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in DebugTypeVisitor.

Hi, after this patch, our buildbot for VE having errors like https://lab.llvm.org/buildbot/#/builders/91/builds/9984.

Mon, Jun 6, 6:37 PM · debug-info, Restricted Project, Restricted Project

Jun 2 2022

kaz7 added a comment to D124926: [LoopInterchange] New cost model for loop interchange.

Hi, after this patch, our buildbot for VE has been failing, https://lab.llvm.org/buildbot/#/builders/91/builds/9844. Is it possible to inspect these failures? Thanks.

Jun 2 2022, 5:50 PM · Restricted Project, Restricted Project, Restricted Project

Apr 17 2022

kaz7 added a comment to D120094: [CallingConv] Generate isCCArgumentReg() predicate via tablegen.

VE part looks OK too.

Apr 17 2022, 12:44 AM · Restricted Project, Restricted Project

Mar 22 2022

kaz7 accepted D121913: [VP] Fix VPintrinsic::getStaticVectorLength for vp.merge|select.

Thank you. LGTM.

Mar 22 2022, 1:54 AM · Restricted Project, Restricted Project, Restricted Project

Mar 19 2022

kaz7 added inline comments to D121913: [VP] Fix VPintrinsic::getStaticVectorLength for vp.merge|select.
Mar 19 2022, 5:01 PM · Restricted Project, Restricted Project, Restricted Project

Mar 17 2022

kaz7 added a comment to D121816: [Clang][VE] Add vector mask intrinsics to clang.

Having timeout errors on lldb-aarch64-ubuntu builder... I'm not sure what modification on this patch causes a such error.

Mar 17 2022, 3:23 AM · Restricted Project, Restricted Project
kaz7 added a comment to D120682: [CMake][compiler-rt] Make CRT separately buildable.

@simoll , thank you for fixing the VE bot problem. This should work fine now.

Mar 17 2022, 3:19 AM · Restricted Project, Restricted Project
kaz7 committed rG9df395bb68a6: [Clang][VE] Add vector mask intrinsics to clang (authored by kaz7).
[Clang][VE] Add vector mask intrinsics to clang
Mar 17 2022, 2:53 AM · Restricted Project
kaz7 closed D121816: [Clang][VE] Add vector mask intrinsics to clang.
Mar 17 2022, 2:52 AM · Restricted Project, Restricted Project

Mar 16 2022

kaz7 requested review of D121816: [Clang][VE] Add vector mask intrinsics to clang.
Mar 16 2022, 8:55 AM · Restricted Project, Restricted Project
kaz7 committed rGc2f62ab84b5f: [Clang][VE] Add the rest of intrinsics to clang (authored by kaz7).
[Clang][VE] Add the rest of intrinsics to clang
Mar 16 2022, 8:17 AM · Restricted Project
kaz7 closed D121586: [Clang][VE] Add the rest of intrinsics to clang.
Mar 16 2022, 8:17 AM · Restricted Project, Restricted Project
kaz7 updated the diff for D121586: [Clang][VE] Add the rest of intrinsics to clang.

Rebased and removed whole dead codes as requested.

Mar 16 2022, 8:16 AM · Restricted Project, Restricted Project

Mar 15 2022

kaz7 accepted D121620: [VE] v512|256 f32|64 fneg isel and tests.

Thank you for answering my question. LGTM now.

Mar 15 2022, 8:20 PM · Restricted Project, Restricted Project, Restricted Project
kaz7 added a comment to D121620: [VE] v512|256 f32|64 fneg isel and tests.

Looks fine except these:

Mar 15 2022, 3:59 AM · Restricted Project, Restricted Project, Restricted Project
kaz7 accepted D121616: [VE] strided v256.23 isel and tests.

LGTM.

Mar 15 2022, 3:56 AM · Restricted Project, Restricted Project, Restricted Project

Mar 14 2022

kaz7 added inline comments to D121586: [Clang][VE] Add the rest of intrinsics to clang.
Mar 14 2022, 7:49 AM · Restricted Project, Restricted Project
kaz7 added inline comments to D121586: [Clang][VE] Add the rest of intrinsics to clang.
Mar 14 2022, 6:26 AM · Restricted Project, Restricted Project
kaz7 updated the diff for D121586: [Clang][VE] Add the rest of intrinsics to clang.

Change code to follow suggestions.

Mar 14 2022, 6:24 AM · Restricted Project, Restricted Project
kaz7 updated the diff for D121586: [Clang][VE] Add the rest of intrinsics to clang.

Correct the order of #include

Mar 14 2022, 4:42 AM · Restricted Project, Restricted Project
kaz7 requested review of D121586: [Clang][VE] Add the rest of intrinsics to clang.
Mar 14 2022, 4:06 AM · Restricted Project, Restricted Project
kaz7 committed rG926059214193: [VE] Support more intrinsics (authored by kaz7).
[VE] Support more intrinsics
Mar 14 2022, 3:17 AM · Restricted Project
kaz7 closed D121509: [VE] Support more intrinsics.
Mar 14 2022, 3:17 AM · Restricted Project, Restricted Project, Restricted Project

Mar 11 2022

kaz7 accepted D121477: [VE] v256f32|64 fma isel.

LGTM.

Mar 11 2022, 10:55 PM · Restricted Project, Restricted Project, Restricted Project
kaz7 requested review of D121509: [VE] Support more intrinsics.
Mar 11 2022, 8:24 PM · Restricted Project, Restricted Project, Restricted Project
kaz7 committed rGb1b4b6f36695: [Clang][VE] Add vector load intrinsics (authored by kaz7).
[Clang][VE] Add vector load intrinsics
Mar 11 2022, 4:10 PM · Restricted Project
kaz7 closed D121049: [Clang][VE] Add vector load intrinsics.
Mar 11 2022, 4:10 PM · Restricted Project, Restricted Project
kaz7 accepted D121469: v256i32|64 reduction isel and tests.

Please add [VE] to the title when merge this. Otherwise, LGTM.

Mar 11 2022, 4:06 PM · Restricted Project, Restricted Project, Restricted Project
kaz7 accepted D121453: [VE] Transfer backend ownership.

LGTM. Thank you for your contributions.

Mar 11 2022, 4:03 PM · Restricted Project, Restricted Project, Restricted Project
kaz7 accepted D121288: [VE] v256.32|64 gather|scatter isel and tests.

LGTM

Mar 11 2022, 4:02 PM · Restricted Project, Restricted Project, Restricted Project

Mar 9 2022

kaz7 added a comment to D121288: [VE] v256.32|64 gather|scatter isel and tests.

Please add summary. Is this adding not only vp_gather and vp_scatter but also vec_gather and vec_scatter?

Mar 9 2022, 9:49 PM · Restricted Project, Restricted Project, Restricted Project

Mar 7 2022

kaz7 accepted D120682: [CMake][compiler-rt] Make CRT separately buildable.

LGTM.

Mar 7 2022, 6:06 AM · Restricted Project, Restricted Project
kaz7 accepted D120818: [VE] Split v512.32 load store into interleaved v256.32 ops.

LGTM.

Mar 7 2022, 6:01 AM · Restricted Project, Restricted Project, Restricted Project

Mar 6 2022

Herald added a project to D88905: [Clang] Allow "ext_vector_type" applied to Booleans: Restricted Project.

At the beginning, this implementation extends vector_type attribute which is GCC's attribute. So, this may cause future conflicts with GCC when they extend it. But, now this patch uses it's own ext_vector_type attribute. So, basically this modification is safe against to the C/C++ future extension and the GCC future extension, in my honest opinion.

Mar 6 2022, 5:20 AM · Restricted Project, Restricted Project
kaz7 updated the diff for D121049: [Clang][VE] Add vector load intrinsics.

Add intrinsics for not only VLD instructions but also VLD2D instructions

Mar 6 2022, 5:06 AM · Restricted Project, Restricted Project

Mar 5 2022

kaz7 requested review of D121049: [Clang][VE] Add vector load intrinsics.
Mar 5 2022, 9:01 AM · Restricted Project, Restricted Project

Mar 4 2022

Herald added a project to D120682: [CMake][compiler-rt] Make CRT separately buildable: Restricted Project.

Thank you. For the case of VE, this works fine as

$ mkdir build-crt
$ cd build-crt
$ cmake -G Ninja ../llvm-project/compiler-rt/lib/crt
$ ninja install
Mar 4 2022, 3:05 AM · Restricted Project, Restricted Project
kaz7 added inline comments to D120818: [VE] Split v512.32 load store into interleaved v256.32 ops.
Mar 4 2022, 2:10 AM · Restricted Project, Restricted Project, Restricted Project

Feb 28 2022

kaz7 accepted D120413: [VE] (masked) load|store v256.32|64 isel.

LGTM. Please apply clang-format suggestions.

Feb 28 2022, 4:43 PM · Restricted Project, Restricted Project, Restricted Project

Feb 22 2022

kaz7 accepted D120146: [VE] Split unsupported v512.32 ops.
Feb 22 2022, 12:49 AM · Restricted Project, Restricted Project

Feb 19 2022

kaz7 added inline comments to D120146: [VE] Split unsupported v512.32 ops.
Feb 19 2022, 10:43 PM · Restricted Project, Restricted Project
kaz7 accepted D120053: [VE] v512i1 mask arithmetic isel.

LGTM.

Feb 19 2022, 10:38 PM · Restricted Project, Restricted Project

Feb 18 2022

kaz7 accepted D120054: [VE] Fix vmp0 subregister mapping.

LGTM.

Feb 18 2022, 4:11 AM · Restricted Project, Restricted Project
kaz7 added a comment to D120053: [VE] v512i1 mask arithmetic isel.

Please add summary. Otherwise, LGTM.

Feb 18 2022, 4:10 AM · Restricted Project, Restricted Project
kaz7 accepted D119936: [VE] Enable v256 fcmp true|false tests.

LGTM. Thank you for updating regression tests.

Feb 18 2022, 3:56 AM · Restricted Project, Restricted Project

Feb 14 2022

kaz7 accepted D119241: [VE] v256i1 broadcast isel and tests.

Well, LGTM.

Feb 14 2022, 2:05 AM · Restricted Project, Restricted Project

Feb 11 2022

kaz7 added a comment to D89492: [compiler-rt] Enable building builtins using top-level CMake file.

I understand you are very busy. But, is there any way to push forward this patch since the ability of runtime standalone build has been removed at D119255. We, VE, badly need this feature, compiling crtbegin.o and crtend.o before runtimes. I previously posted similar patch, D115038, but it is recommended to remove since you already post this patch. But, this patch is not merged yet. Now, this patch is blocking VE runtime build from my point of view. Is it OK to make a similar patch if you don't have time to work on this? Please let me know what you think. Thanks.

Feb 11 2022, 3:28 PM · Restricted Project, Restricted Project, Restricted Project
kaz7 added a comment to D119241: [VE] v256i1 broadcast isel and tests.

Is it possible to add 512i1 test cases?

Feb 11 2022, 3:13 PM · Restricted Project, Restricted Project
kaz7 accepted D119239: [VE] v256i1 and|or|xor isel and tests.

LGTM.

Feb 11 2022, 3:09 PM · Restricted Project, Restricted Project

Feb 8 2022

kaz7 accepted D119223: [VE] v256.32|64 setcc isel and tests.

LGTM.

Feb 8 2022, 4:09 AM · Restricted Project, Restricted Project

Feb 2 2022

kaz7 accepted D118332: [VE] Packed v512i32 isel and tests.

Thanks. LGTM.

Feb 2 2022, 7:36 PM · Restricted Project, Restricted Project

Jan 31 2022

kaz7 accepted D118321: [VE] LEGALAVL and staged VVP legalization.

LGTM now.

Jan 31 2022, 11:29 PM · Restricted Project, Restricted Project
kaz7 added a comment to D118332: [VE] Packed v512i32 isel and tests.

Is it possible to add "vr" and "rv" test cases similar to D118335?

Jan 31 2022, 4:52 PM · Restricted Project, Restricted Project
kaz7 accepted D118335: [VE] Packed v512f32 binop isel and tests.

LGTM

Jan 31 2022, 4:46 PM · Restricted Project, Restricted Project

Jan 30 2022

kaz7 added a comment to D118321: [VE] LEGALAVL and staged VVP legalization.

Please add more comments.

Jan 30 2022, 8:17 PM · Restricted Project, Restricted Project

Jan 21 2022

kaz7 accepted D117878: [VE] Packed 32/64bit broadcast isel and tests.

LGTM.

Jan 21 2022, 10:11 PM · Restricted Project, Restricted Project

Jan 20 2022

kaz7 accepted D117683: [VE][NFC] Factor out helper functions.

LGTM.

Jan 20 2022, 3:17 PM · Restricted Project, Restricted Project

Jan 18 2022

kaz7 accepted D117495: [VE] vp_select+vectorBinOp passthru isel and tests.

LGTM

Jan 18 2022, 12:58 AM · Restricted Project, Restricted Project
kaz7 accepted D116103: [VE] VECustomDAG builder class.

LGTM

Jan 18 2022, 12:58 AM · Restricted Project, Restricted Project

Jan 17 2022

kaz7 accepted D117206: [VE] select|vp.merge|vp.select v256 isel and tests.

LGTM.

Jan 17 2022, 2:46 AM · Restricted Project, Restricted Project
kaz7 added a comment to D116103: [VE] VECustomDAG builder class.

Sorry for delay of reviewing. Please add little more explanation to a head file.

Jan 17 2022, 2:45 AM · Restricted Project, Restricted Project

Dec 23 2021

kaz7 added a comment to D116103: [VE] VECustomDAG builder class.

Please apply clang-format suggestsions.

Dec 23 2021, 4:31 AM · Restricted Project, Restricted Project
kaz7 accepted D116212: [VE] Add manuals to CompilerWriterInfo.

In addition, I've also read following manuals often.

Dec 23 2021, 4:28 AM · Restricted Project, Restricted Project
kaz7 accepted D116104: [VE] Add VE support to update_llc_test_checks.

LGTM.

Dec 23 2021, 4:26 AM · Restricted Project, Restricted Project

Dec 22 2021

kaz7 added a comment to D116103: [VE] VECustomDAG builder class.

I have several quesions.

Dec 22 2021, 9:02 AM · Restricted Project, Restricted Project
kaz7 added inline comments to D116104: [VE] Add VE support to update_llc_test_checks.
Dec 22 2021, 8:47 AM · Restricted Project, Restricted Project

Dec 20 2021

kaz7 accepted D116035: [VE] FADD,FSUB,FMUL,FDIV v256f32|f64 isel and tests.

LGTM.

Dec 20 2021, 2:56 PM · Restricted Project, Restricted Project
kaz7 accepted D115940: [VE] U|SDIV v256i32|64 isel and tests.

LGTM.

Dec 20 2021, 2:40 PM · Restricted Project, Restricted Project

Dec 17 2021

kaz7 added a comment to D89492: [compiler-rt] Enable building builtins using top-level CMake file.

Hi, is there anything I can help to merge this patch? We need this modification to compile crtbegin/crtend before runtime libraries in order to compile LLVM for VE using bootstrapping build, https://libcxx.llvm.org/BuildingLibcxx.html#bootstrapping-build.

Dec 17 2021, 5:08 AM · Restricted Project, Restricted Project, Restricted Project

Dec 14 2021

kaz7 accepted D115734: [VE] SHL,SRA,SRL v256i32|64 isel and tests.

LGTM. Pass check-llvm locally.

Dec 14 2021, 10:54 PM · Restricted Project, Restricted Project
kaz7 added a comment to D115276: [CMake] Move the AIX archiver settings to a module.

Is it OK to accept this patch by me? Or should we wait for @ldionne? Just curious.

For the record, the review guidelines we have for libc++/libc++abi do not necessarily apply to compiler-rt, so there's no requirement that someone from the libc++ review group gives an approval for this to make progress.

Dec 14 2021, 7:17 AM · Restricted Project
kaz7 accepted D115643: [VE] MUL,SUB,OR,XOR v256i32|64 isel.

LGTM

Dec 14 2021, 1:40 AM · Restricted Project, Restricted Project

Dec 13 2021

kaz7 added a comment to D115276: [CMake] Move the AIX archiver settings to a module.

Is it OK to accept this patch by me? Or should we wait for @ldionne? Just curious.

Dec 13 2021, 10:21 PM · Restricted Project
kaz7 accepted D115664: [OpenMP][libomp] Fix compile errors with new KMP_HW_SUBSET changes.
Dec 13 2021, 10:19 PM · Restricted Project
kaz7 added a comment to D114901: [OpenMP][libomp] Add core attributes to KMP_HW_SUBSET.

In addition, these lines also cause compiler errors.

Thanks for this report. I've just submitted https://reviews.llvm.org/D115664 with you as a reviewer. Is it possible for you to test that this fixes the compiler errors?

Dec 13 2021, 10:18 PM · Restricted Project
kaz7 added a comment to D115664: [OpenMP][libomp] Fix compile errors with new KMP_HW_SUBSET changes.

LGTM too. I can compile openmp for VE without errors after applying this patch.

Dec 13 2021, 10:17 PM · Restricted Project
kaz7 added a comment to D114901: [OpenMP][libomp] Add core attributes to KMP_HW_SUBSET.

In addition, these lines also cause compiler errors.

Dec 13 2021, 10:49 AM · Restricted Project