- User Since
- Dec 11 2019, 7:43 PM (133 w, 6 d)
Add missing DEBUG_TYPE.
Sat, Jul 2
Add regression tests and support the case like the first 8 bytes fits in
the immediate field but the second 8 bytes doesn't fit in the immediate
Fri, Jul 1
Thu, Jun 30
Sun, Jun 26
Mon, Jun 20
Sat, Jun 18
Sun, Jun 12
Sat, Jun 11
Mon, Jun 6
Hi, after this patch, our buildbot for VE having errors like https://lab.llvm.org/buildbot/#/builders/91/builds/9984.
Jun 2 2022
Hi, after this patch, our buildbot for VE has been failing, https://lab.llvm.org/buildbot/#/builders/91/builds/9844. Is it possible to inspect these failures? Thanks.
Apr 17 2022
VE part looks OK too.
Mar 22 2022
Thank you. LGTM.
Mar 19 2022
Mar 17 2022
Having timeout errors on lldb-aarch64-ubuntu builder... I'm not sure what modification on this patch causes a such error.
@simoll , thank you for fixing the VE bot problem. This should work fine now.
Mar 16 2022
Rebased and removed whole dead codes as requested.
Mar 15 2022
Thank you for answering my question. LGTM now.
Looks fine except these:
Mar 14 2022
Change code to follow suggestions.
Correct the order of #include
Mar 11 2022
Please add [VE] to the title when merge this. Otherwise, LGTM.
LGTM. Thank you for your contributions.
Mar 9 2022
Please add summary. Is this adding not only vp_gather and vp_scatter but also vec_gather and vec_scatter?
Mar 7 2022
Mar 6 2022
At the beginning, this implementation extends vector_type attribute which is GCC's attribute. So, this may cause future conflicts with GCC when they extend it. But, now this patch uses it's own ext_vector_type attribute. So, basically this modification is safe against to the C/C++ future extension and the GCC future extension, in my honest opinion.
Add intrinsics for not only VLD instructions but also VLD2D instructions
Mar 5 2022
Mar 4 2022
Thank you. For the case of VE, this works fine as
$ mkdir build-crt $ cd build-crt $ cmake -G Ninja ../llvm-project/compiler-rt/lib/crt $ ninja install
Feb 28 2022
LGTM. Please apply clang-format suggestions.
Feb 22 2022
Feb 19 2022
Feb 18 2022
Please add summary. Otherwise, LGTM.
LGTM. Thank you for updating regression tests.
Feb 14 2022
Feb 11 2022
I understand you are very busy. But, is there any way to push forward this patch since the ability of runtime standalone build has been removed at D119255. We, VE, badly need this feature, compiling crtbegin.o and crtend.o before runtimes. I previously posted similar patch, D115038, but it is recommended to remove since you already post this patch. But, this patch is not merged yet. Now, this patch is blocking VE runtime build from my point of view. Is it OK to make a similar patch if you don't have time to work on this? Please let me know what you think. Thanks.
Is it possible to add 512i1 test cases?
Feb 8 2022
Feb 2 2022
Jan 31 2022
Is it possible to add "vr" and "rv" test cases similar to D118335?
Jan 30 2022
Please add more comments.
Jan 21 2022
Jan 20 2022
Jan 18 2022
Jan 17 2022
Sorry for delay of reviewing. Please add little more explanation to a head file.
Dec 23 2021
Please apply clang-format suggestsions.
In addition, I've also read following manuals often.
Dec 22 2021
I have several quesions.
Dec 20 2021
Dec 17 2021
Hi, is there anything I can help to merge this patch? We need this modification to compile crtbegin/crtend before runtime libraries in order to compile LLVM for VE using bootstrapping build, https://libcxx.llvm.org/BuildingLibcxx.html#bootstrapping-build.
Dec 14 2021
LGTM. Pass check-llvm locally.
Dec 13 2021
Is it OK to accept this patch by me? Or should we wait for @ldionne? Just curious.
LGTM too. I can compile openmp for VE without errors after applying this patch.
In addition, these lines also cause compiler errors.