ping

Hi again, this is a following patch of https://reviews.llvm.org/D143441.

ping

Hi Galina-san, Simon-san,

I didn't realize that we use "cf" in VEInstrFormats.td. Thank you so much. Modified llc works fine, so LGTM.

ping. Is there anything I can help? I'd like to merge this patch as soon as possible. :-)

Thank you very much for updating VEInstInfo.td and fixing CVTRDm problem. I have only one comment.

LGTM

Thanks! I'll check it out soon. sorry for multiple pings.

In D133092#3788749, @azat wrote:

In D133092#3788734, @kaz7 wrote:

For your information, after this patch check-clang fails with following errors if there is no lld (lld is not enable in CMake, and lld is not installed previously). I appreciate if you run debug-options.c test with -fuse-ld=lld if the lld is existing. Thanks.

Yep, already worked on it, fix - https://reviews.llvm.org/D133841

P.S. I don't have commit rights so if someone can commit it after CI that will be great

For your information, after this patch check-clang fails with following errors if there is no lld (lld is not enable in CMake, and lld is not installed previously). I appreciate if you run debug-options.c test with -fuse-ld=lld if the lld is existing. Thanks.

In D100185#3788693, @Vigneshbalu wrote:

python3 is required to build gdb-plugin code. It is used as an interface between gdb, libompd and openmp runtime (libomp).
please use configuration variable "DISABLE_OMPD_GDB_PLUGIN" to disable the plugin code.

I will see if we can disable by default when python is not available.

Hi, I'm having following errors after this patch. I'm compiling llvm and runtimes for X86. Is Python3_INCLUDE_DIRS required for the debugging purpose? Thanks!

Hi @daltenty, is it possible to re-review this patch which you requested changes previously? This patch is holded because of your request, I think. Thank you!

Correct errors in buildbot.

Thank you!

Thank you, but I would like to consider what option is the best for this case. So, please merge this patch as is. Thank you again for fixing the problem in regexp.

Hi, is it possible to rebase this patch to the latest main branch? I think this patch is almost done since many pieces of this patch is already merged. I appreciate if you have time to rebase it and merge this patch to main. I, llvm for VE, definitely need this feature to compile llvm at once. Thanks!

Maybe the purpose of this patch is related to D131431. LGTM.

Ah, Ok. I've understood what you are trying to fix now. You are trying to correct regexp for VE in UpdateTestChecks/asm.py. I couldn't correct it, so I just hand-write this builtin_sjlj_landingpad.ll test when I created this.

This patch itself looks fine although I'm not sure what the point of this patch is.

It's looks like this patch itself IS removing landing pad instructions from builtin_sjlj_landingpad.ll although the explanation of this patch is saying opposite.

In D129875#3704796, @JonChesterfield wrote:

Libomptarget is host code. There's another library called DeviceRTL which runs on the accelerator and that won't be linking in llvm libs or zlib.

In D129875#3704145, @jhuber6 wrote:

Libomptarget now depends on the LLVM libraries , so whatever dependencies LLVM has libomptarget needs to have as well. Is it possible for you to build with -DLLVM_ENABLE_TERMINFO=OFF -DLLVM_ENABLE_ZLIB=OFF? I'd assume that would stop LLVM from looking for it and prevent libomptarget from picking it up either.

Hi, I am having configuration error after this patch like it cannot find zlib and terminfo to compile libomptarget. Why those are required for libomptarget is that those libraries are listed in install/lib/cmake/llvm/LLVMConfig.cmake like below if I compile llvm with default setting. it's clear that libomptarget doesn't require them, but this patch change it to require similar libraries as llvm itself. I would like to disable them for only libomptarget compiling. Do you know how to do that? Please let me know any way to solve this situation. Thank you!

Rebased to land

Correct typo in comments as reviewed.

From instruction point of view, each instrucment has space for only 32 bit immediates.

Add missing DEBUG_TYPE.

Add regression tests and support the case like the first 8 bytes fits in
the immediate field but the second 8 bytes doesn't fit in the immediate
field.

Thank you, @chapuni and @ahatanak, for quick fixing.

Hi, after this patch, our buildbot for VE having errors like https://lab.llvm.org/buildbot/#/builders/91/builds/9984.

Hi, after this patch, our buildbot for VE has been failing, https://lab.llvm.org/buildbot/#/builders/91/builds/9844. Is it possible to inspect these failures? Thanks.

VE part looks OK too.

Thank you. LGTM.

Having timeout errors on lldb-aarch64-ubuntu builder... I'm not sure what modification on this patch causes a such error.

@simoll , thank you for fixing the VE bot problem. This should work fine now.