Page MenuHomePhabricator

kaz7 (Kazushi Marukawa)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 11 2019, 7:43 PM (25 w, 15 h)

Recent Activity

Today

kaz7 updated the diff for D81132: [VE] Clean SDNodeXForm stuff.

Renamed two function as suggested by clang-tidy.

Thu, Jun 4, 1:02 AM · Restricted Project, Restricted Project
kaz7 planned changes to D81132: [VE] Clean SDNodeXForm stuff.

The clang-tidy suggested renaming of two functions. I'll modify them.

Thu, Jun 4, 12:29 AM · Restricted Project, Restricted Project

Yesterday

kaz7 created D81132: [VE] Clean SDNodeXForm stuff.
Wed, Jun 3, 10:29 PM · Restricted Project, Restricted Project
kaz7 added a child revision for D81129: [VE] Change to use EXTRACT_SUBREG instead of COPY_TO_REGCLASS: D81132: [VE] Clean SDNodeXForm stuff.
Wed, Jun 3, 10:29 PM · Restricted Project, Restricted Project
kaz7 created D81129: [VE] Change to use EXTRACT_SUBREG instead of COPY_TO_REGCLASS.
Wed, Jun 3, 8:53 PM · Restricted Project, Restricted Project
kaz7 added a comment to D79411: [VE] Clang toolchain for VE.

It looks fine to me but I'm not clang expert. Can anyone review this or introduce us reviewers? Thanks.

Wed, Jun 3, 8:53 PM · Restricted Project, Restricted Project

Tue, Jun 2

kaz7 updated the diff for D80912: [VE] Support a basic disassembler for Aurora VE target.

Rebased.

Tue, Jun 2, 2:12 AM · Restricted Project, Restricted Project

Mon, Jun 1

kaz7 created D80912: [VE] Support a basic disassembler for Aurora VE target.
Mon, Jun 1, 2:37 AM · Restricted Project, Restricted Project
kaz7 added a child revision for D80777: [VE] Support I32/F32 registers in assembler parser: D80912: [VE] Support a basic disassembler for Aurora VE target.
Mon, Jun 1, 2:37 AM · Restricted Project, Restricted Project

Sun, May 31

kaz7 abandoned D78698: [VE] Implements minimum MC layer for VE.

Closing this ticket since I divided this to 4 patches, and all of them are reviewed and landed well. Thank you!

Sun, May 31, 3:41 PM · Restricted Project, Restricted Project

Fri, May 29

kaz7 updated the diff for D80777: [VE] Support I32/F32 registers in assembler parser.

Rebase

Fri, May 29, 12:33 PM · Restricted Project, Restricted Project

Thu, May 28

kaz7 retitled D80777: [VE] Support I32/F32 registers in assembler parser from [VE] Add regression tests for LD/ST instructions to [VE] Support I32/F32 registers in assembler parser.
Thu, May 28, 10:27 PM · Restricted Project, Restricted Project
kaz7 updated the diff for D80777: [VE] Support I32/F32 registers in assembler parser.

Add missing modifications.

Thu, May 28, 9:55 PM · Restricted Project, Restricted Project
kaz7 created D80777: [VE] Support I32/F32 registers in assembler parser.
Thu, May 28, 9:23 PM · Restricted Project, Restricted Project
kaz7 added a child revision for D79546: [VE] Implements minimum MC layer for VE (4/4): D80777: [VE] Support I32/F32 registers in assembler parser.
Thu, May 28, 9:23 PM · Restricted Project, Restricted Project
kaz7 added a comment to D79546: [VE] Implements minimum MC layer for VE (4/4).

Update inline comments.

Thu, May 28, 6:43 PM · Restricted Project, Restricted Project
kaz7 updated the diff for D79546: [VE] Implements minimum MC layer for VE (4/4).

Update following suggestions and rebase.

Thu, May 28, 6:43 PM · Restricted Project, Restricted Project
kaz7 planned changes to D79546: [VE] Implements minimum MC layer for VE (4/4).

Thanks for reviewing. Yes, you are correct. I removed relocation features too from this patch. I added comments in the commit message. Thanks.

Thu, May 28, 8:42 AM · Restricted Project, Restricted Project
kaz7 updated the summary of D79546: [VE] Implements minimum MC layer for VE (4/4).
Thu, May 28, 8:42 AM · Restricted Project, Restricted Project
kaz7 added a comment to D79545: [VE] Implements minimum MC layer for VE (3/4).

Thank you. I appreciate your kind suggestions and examples too.

Thu, May 28, 8:07 AM · Restricted Project, Restricted Project

Tue, May 26

kaz7 updated the diff for D79545: [VE] Implements minimum MC layer for VE (3/4).

Update following jhenderson's suggestions. Also rebase to the latest.

Tue, May 26, 4:50 AM · Restricted Project, Restricted Project
kaz7 planned changes to D79545: [VE] Implements minimum MC layer for VE (3/4).

No problem. Thank you for your time for reviewing. I also almost ran out my time this month to work on this. ;)

Tue, May 26, 3:11 AM · Restricted Project, Restricted Project

Sun, May 24

kaz7 updated the diff for D79546: [VE] Implements minimum MC layer for VE (4/4).

Remove several functions which is not required at this time in order to
shrink the size of modifications. Rebased to the latest D79545.

Sun, May 24, 7:43 PM · Restricted Project, Restricted Project
kaz7 created D80501: [VE][NFC] Correct sjlj_expection test.
Sun, May 24, 5:35 PM · Restricted Project, Restricted Project

Thu, May 21

kaz7 added inline comments to D79545: [VE] Implements minimum MC layer for VE (3/4).
Thu, May 21, 2:08 AM · Restricted Project, Restricted Project

Wed, May 20

kaz7 updated the diff for D79545: [VE] Implements minimum MC layer for VE (3/4).

Update regression tests.
Also rebase to the latest master.

Wed, May 20, 7:53 PM · Restricted Project, Restricted Project
kaz7 added a comment to D79545: [VE] Implements minimum MC layer for VE (3/4).

OK, I will run clang-format. It modifies ENUM_ENT definitions in ELFDumper.cpp, so that I was not running it in this patch since I feel modifying existing format is not good. Maybe I should think like this patch is a good practice to update existing format. Thanks.

Wed, May 20, 7:53 PM · Restricted Project, Restricted Project

Tue, May 19

kaz7 added a comment to D79084: [VE] Dynamic stack allocation.

verifyLeafProcRegUse function is not used anymore.

Tue, May 19, 10:32 PM · Restricted Project, Restricted Project, Restricted Project
kaz7 closed D76334: [VE] Support VE architecture.

Closing this one since it is landed already. Thank you for reviewing and landing this.

Tue, May 19, 5:06 PM · Restricted Project

Mon, May 18

kaz7 added a comment to D79084: [VE] Dynamic stack allocation.

@arsenm Yes! I didn't notice those calling conventions. We can use them as our target depend special calling conventions. Thank you for informing us.

Mon, May 18, 9:40 PM · Restricted Project, Restricted Project, Restricted Project
kaz7 added a comment to D79084: [VE] Dynamic stack allocation.
  • use standard C CC for grow_stack builtins.
Mon, May 18, 5:54 PM · Restricted Project, Restricted Project, Restricted Project
kaz7 updated the diff for D79545: [VE] Implements minimum MC layer for VE (3/4).

Add all necessary unit tests now.

Mon, May 18, 3:10 AM · Restricted Project, Restricted Project
kaz7 added a comment to D79545: [VE] Implements minimum MC layer for VE (3/4).

I managed to implement test code for ELFYAML modifications. Now we can test relocation type info through unit tests. Therefore, I'll remove following lit tests.

Mon, May 18, 3:10 AM · Restricted Project, Restricted Project
kaz7 updated the diff for D79545: [VE] Implements minimum MC layer for VE (3/4).

Update along to suggestions. Need to finish implementation of
unittests/ObjectYAML/ELFRelocationTypeTest.cpp which takes for a
while to learn how to traverse symbol information in ELFObjectFile.

Mon, May 18, 12:29 AM · Restricted Project, Restricted Project
kaz7 added inline comments to D79545: [VE] Implements minimum MC layer for VE (3/4).
Mon, May 18, 12:29 AM · Restricted Project, Restricted Project

Fri, May 15

kaz7 planned changes to D79545: [VE] Implements minimum MC layer for VE (3/4).
Fri, May 15, 1:35 AM · Restricted Project, Restricted Project
kaz7 added a comment to D79545: [VE] Implements minimum MC layer for VE (3/4).

Thanks for inspecting tests. I'll update them Monday again.

Fri, May 15, 1:35 AM · Restricted Project, Restricted Project

Thu, May 14

kaz7 updated the diff for D79545: [VE] Implements minimum MC layer for VE (3/4).

Update to correct filenames and to avoid warning messages.

Thu, May 14, 4:21 PM · Restricted Project, Restricted Project
kaz7 added a comment to D79545: [VE] Implements minimum MC layer for VE (3/4).

Thank you @jhenderson too. Thanks for spending your time for this review and letting me know your situation. I misunderstood what you said about a unit test. Anyway, I've not made a unit test for tools this time. :)

Thu, May 14, 4:21 PM · Restricted Project, Restricted Project
kaz7 added a comment to D76334: [VE] Support VE architecture.

Hi, this patch is accepted and landed like (https://github.com/llvm/llvm-lnt/commit/9c9f6f8aaca07b783b4a2db2b68f7878a61bd97a). Thank you.

Thu, May 14, 1:01 AM · Restricted Project

Wed, May 13

kaz7 updated the diff for D79545: [VE] Implements minimum MC layer for VE (3/4).

I add several unit tests. I summarized modified files and tests for
each of them below. Please check them and let me know what you think.
Thanks.

Wed, May 13, 6:34 PM · Restricted Project, Restricted Project
kaz7 added a comment to D79545: [VE] Implements minimum MC layer for VE (3/4).

Having been looking at another piece of work in the Object library, rather than introducing lit tests for it to cover the specific behaviour, I think gtest unit tests should be introduced instead to cover the behaviour. For more thoughts on this, see D79612.

Wed, May 13, 2:39 AM · Restricted Project, Restricted Project
kaz7 updated the diff for D79545: [VE] Implements minimum MC layer for VE (3/4).

Remove FIXME part from a test and put it to ELFDumper.cpp.

Wed, May 13, 2:39 AM · Restricted Project, Restricted Project

Mon, May 11

kaz7 planned changes to D79546: [VE] Implements minimum MC layer for VE (4/4).

I'm trying to reduce the amount of code size.

Mon, May 11, 10:39 PM · Restricted Project, Restricted Project
kaz7 retitled D79546: [VE] Implements minimum MC layer for VE (4/4) from [VE] Implements minimum MC layer for VE to [VE] Implements minimum MC layer for VE (4/4).
Mon, May 11, 10:39 PM · Restricted Project, Restricted Project
kaz7 added inline comments to D79545: [VE] Implements minimum MC layer for VE (3/4).
Mon, May 11, 6:55 PM · Restricted Project, Restricted Project
kaz7 updated the diff for D79545: [VE] Implements minimum MC layer for VE (3/4).

I update following jhenderson's suggestions and also add a new test to
check triple for ve.

Mon, May 11, 6:55 PM · Restricted Project, Restricted Project
kaz7 added a comment to D79545: [VE] Implements minimum MC layer for VE (3/4).

Thank you for kind suggestions.

Mon, May 11, 6:55 PM · Restricted Project, Restricted Project

Fri, May 8

kaz7 added inline comments to D79545: [VE] Implements minimum MC layer for VE (3/4).
Fri, May 8, 2:38 AM · Restricted Project, Restricted Project
kaz7 updated the diff for D79545: [VE] Implements minimum MC layer for VE (3/4).

Add regression tests and update codes following jhenderson suggestions.
Thanks!

Fri, May 8, 2:38 AM · Restricted Project, Restricted Project

Thu, May 7

kaz7 added a comment to D79545: [VE] Implements minimum MC layer for VE (3/4).

Add some tests locally and found a problem need other's help. Please let me know how to fix EM_ECOG1X problem and how to check Tripe::ve. Thanks!

Thu, May 7, 3:21 AM · Restricted Project, Restricted Project
kaz7 planned changes to D79545: [VE] Implements minimum MC layer for VE (3/4).

Thank you for your comments and examples for regression tests. I'll add them.

Thu, May 7, 1:41 AM · Restricted Project, Restricted Project

Wed, May 6

kaz7 added a comment to D79546: [VE] Implements minimum MC layer for VE (4/4).

This is a patch related to https://reviews.llvm.org/D78698

Wed, May 6, 8:27 PM · Restricted Project, Restricted Project
kaz7 created D79546: [VE] Implements minimum MC layer for VE (4/4).
Wed, May 6, 8:27 PM · Restricted Project, Restricted Project
kaz7 added a child revision for D79545: [VE] Implements minimum MC layer for VE (3/4): D79546: [VE] Implements minimum MC layer for VE (4/4).
Wed, May 6, 8:27 PM · Restricted Project, Restricted Project
kaz7 created D79545: [VE] Implements minimum MC layer for VE (3/4).
Wed, May 6, 8:27 PM · Restricted Project, Restricted Project
kaz7 added a child revision for D79544: [VE] Implements minimum MC layer for VE (2/4): D79545: [VE] Implements minimum MC layer for VE (3/4).
Wed, May 6, 8:27 PM · Restricted Project, Restricted Project
kaz7 created D79544: [VE] Implements minimum MC layer for VE (2/4).
Wed, May 6, 8:27 PM · Restricted Project, Restricted Project
kaz7 added a child revision for D79539: [VE] Implements minimum MC layer for VE (1/4): D79544: [VE] Implements minimum MC layer for VE (2/4).
Wed, May 6, 8:27 PM · Restricted Project, Restricted Project
kaz7 created D79539: [VE] Implements minimum MC layer for VE (1/4).
Wed, May 6, 6:46 PM · Restricted Project, Restricted Project
kaz7 added a comment to D79539: [VE] Implements minimum MC layer for VE (1/4).

This is a patch related to https://reviews.llvm.org/D78698

Wed, May 6, 6:46 PM · Restricted Project, Restricted Project
kaz7 planned changes to D78698: [VE] Implements minimum MC layer for VE.
Wed, May 6, 4:30 PM · Restricted Project, Restricted Project

Apr 28 2020

kaz7 added a comment to D78698: [VE] Implements minimum MC layer for VE.

Thanks for the comments.

Apr 28 2020, 3:11 AM · Restricted Project, Restricted Project
kaz7 added a comment to D78698: [VE] Implements minimum MC layer for VE.

Thank you for the comments. I'm also considering the size of this patch. I'll split it as you suggested after a week and half holidays. How should I leave this patch? Close this and open divided patches newly? Let me know the recommended way. Thanks in advance.

Apr 28 2020, 3:11 AM · Restricted Project, Restricted Project

Apr 27 2020

kaz7 added inline comments to D78887: [VE] Support floating point immediate values.
Apr 27 2020, 3:39 PM · Restricted Project, Restricted Project
kaz7 updated the summary of D78889: [VE] Update branch instructions.
Apr 27 2020, 2:05 AM · Restricted Project, Restricted Project
kaz7 added inline comments to D78889: [VE] Update branch instructions.
Apr 27 2020, 2:05 AM · Restricted Project, Restricted Project
kaz7 updated the diff for D78889: [VE] Update branch instructions.

Modify code to follow Simon-san's suggestions.

Apr 27 2020, 1:33 AM · Restricted Project, Restricted Project
kaz7 updated the diff for D78887: [VE] Support floating point immediate values.

Modify codes to follow simon-san's suggestions.

Apr 27 2020, 1:33 AM · Restricted Project, Restricted Project
kaz7 added inline comments to D78887: [VE] Support floating point immediate values.
Apr 27 2020, 1:33 AM · Restricted Project, Restricted Project

Apr 26 2020

kaz7 created D78889: [VE] Update branch instructions.
Apr 26 2020, 7:07 PM · Restricted Project, Restricted Project
kaz7 added a child revision for D78887: [VE] Support floating point immediate values: D78889: [VE] Update branch instructions.
Apr 26 2020, 7:07 PM · Restricted Project, Restricted Project
kaz7 updated the diff for D78698: [VE] Implements minimum MC layer for VE.

I guess lld error is caused by build server.
This time, I've rebased to the latest and updated.

Apr 26 2020, 6:03 PM · Restricted Project, Restricted Project
kaz7 created D78887: [VE] Support floating point immediate values.
Apr 26 2020, 4:59 PM · Restricted Project, Restricted Project

Apr 24 2020

kaz7 added inline comments to D78768: [VE] Update floating-point arithmetic instructions.
Apr 24 2020, 2:06 AM · Restricted Project, Restricted Project

Apr 23 2020

kaz7 planned changes to D78698: [VE] Implements minimum MC layer for VE.

I've not recognized several errors related to lld. I'll revise this patch to fix those errors.

Apr 23 2020, 5:25 PM · Restricted Project, Restricted Project
kaz7 created D78768: [VE] Update floating-point arithmetic instructions.
Apr 23 2020, 3:49 PM · Restricted Project, Restricted Project
kaz7 created D78698: [VE] Implements minimum MC layer for VE.
Apr 23 2020, 2:06 AM · Restricted Project, Restricted Project

Apr 21 2020

kaz7 updated the diff for D78174: [VE] Add alternative names to registers.

Removed StringRef constructor by following arsenm suggestion. Thanks!
Rebased to the latest master.

Apr 21 2020, 6:25 PM · Restricted Project, Restricted Project
kaz7 created D78543: [VE] Create a TargetInfo header. NFC.
Apr 21 2020, 1:35 AM · Restricted Project, Restricted Project

Apr 20 2020

kaz7 updated the diff for D78174: [VE] Add alternative names to registers.

Remove lower() by lowering register name defined in VERegisterInfo.td.
Following an @arsenm suggesntion. Thanks!

Apr 20 2020, 8:36 PM · Restricted Project, Restricted Project
kaz7 added inline comments to D78174: [VE] Add alternative names to registers.
Apr 20 2020, 8:36 PM · Restricted Project, Restricted Project
kaz7 added inline comments to D78468: [VE] Update shift operation instructions.
Apr 20 2020, 8:36 PM · Restricted Project, Restricted Project
kaz7 updated the diff for D78174: [VE] Add alternative names to registers.

Update code to follow @arsenm comments.

Apr 20 2020, 6:28 PM · Restricted Project, Restricted Project
kaz7 added a comment to D78174: [VE] Add alternative names to registers.
Apr 20 2020, 6:28 PM · Restricted Project, Restricted Project

Apr 19 2020

kaz7 created D78468: [VE] Update shift operation instructions.
Apr 19 2020, 8:49 PM · Restricted Project, Restricted Project

Apr 16 2020

kaz7 updated the diff for D78177: [VE] Update logical operation instructions.

Rebased to the latest master. Passed check-llvm.

Apr 16 2020, 1:33 AM · Restricted Project, Restricted Project

Apr 15 2020

kaz7 updated the diff for D78174: [VE] Add alternative names to registers.

Modify include path to try to avoid clang-tidy error.

Apr 15 2020, 5:41 PM · Restricted Project, Restricted Project
kaz7 added inline comments to D78177: [VE] Update logical operation instructions.
Apr 15 2020, 5:06 PM · Restricted Project, Restricted Project
kaz7 updated the diff for D78177: [VE] Update logical operation instructions.

Remove mnemonic aliases.

Apr 15 2020, 5:06 PM · Restricted Project, Restricted Project
kaz7 added inline comments to D78177: [VE] Update logical operation instructions.
Apr 15 2020, 1:36 AM · Restricted Project, Restricted Project

Apr 14 2020

kaz7 created D78177: [VE] Update logical operation instructions.
Apr 14 2020, 7:03 PM · Restricted Project, Restricted Project
kaz7 added a child revision for D77856: [VE] Update integer arithmetic instructions: D78177: [VE] Update logical operation instructions.
Apr 14 2020, 7:03 PM · Restricted Project, Restricted Project
kaz7 created D78174: [VE] Add alternative names to registers.
Apr 14 2020, 5:58 PM · Restricted Project, Restricted Project
kaz7 added a comment to D78174: [VE] Add alternative names to registers.

This time, I am using new feature so I would like to add reviewers who know about it.

Apr 14 2020, 5:58 PM · Restricted Project, Restricted Project
kaz7 added a comment to D77856: [VE] Update integer arithmetic instructions.

Thanks, Simon-san. I've updated summary description.

Apr 14 2020, 1:01 AM · Restricted Project, Restricted Project
kaz7 updated the summary of D77856: [VE] Update integer arithmetic instructions.
Apr 14 2020, 1:01 AM · Restricted Project, Restricted Project

Apr 9 2020

kaz7 created D77856: [VE] Update integer arithmetic instructions.
Apr 9 2020, 9:56 PM · Restricted Project, Restricted Project
kaz7 updated the diff for D77770: [VE] Remove unnecessary iz pattern.

Rebased to the latest source.

Apr 9 2020, 9:13 PM · Restricted Project, Restricted Project

Apr 8 2020

kaz7 added a child revision for D77769: [VE] Support (m)0 and (m)1 operands: D77770: [VE] Remove unnecessary iz pattern.
Apr 8 2020, 7:25 PM · Restricted Project, Restricted Project