- User Since
- Dec 11 2019, 7:43 PM (51 w, 5 h)
Tue, Dec 1
Mon, Nov 30
Update comments following suggestions.
Thank you for reviewing.
Fri, Nov 27
Correct typo in a comment
Thu, Nov 26
Tue, Nov 24
Hi, it works fine for, not merged yet, VE architecture. Thank you for emergency patch.
Mon, Nov 23
Small checks like 80 columns and indentation. And one question about how you plan to implement test cases for fold immediates.
Sun, Nov 22
Fri, Nov 20
I add some comments inlined.
Update regression test and rebase it. Need to inspect behavior of VEISelDAGToDAG.
Rebase and correct capitalization. Also add two regression tests. The
test_frame4294967296 function didn't allocate stack frame correctly before
It's a good question. VE has 32 bits offset, so we don't consider such large frames or data structures seriously.
Thu, Nov 19
Hi, @dblaikie. I generated a test case which causes a segmentation fault if we didn't apply D91151 (https://reviews.llvm.org/D91151) following your suggestion. I appreciate if you have more suggestions.
I thought it's a good idea when I hear it from @fhahn, but... I think It's not a good idea since 1) WidestRegister holds bit width, 2) MaxVectorSize is calculated from TTI->getRegisterBitWidth anyway.
Wed, Nov 18
Thank you for updates.
Tue, Nov 17
I think removing this is good idea, but I'm not sure why the maximum vector size was limited to 64 and recently jumped up to 256. So, I cannot say LGTM atm. Does anyone know background on this?
Mon, Nov 16
@dblaikie, Thank you for suggestion. I'll try to make it tonight.
Update by following clang-tidy.