This is an archive of the discontinued LLVM Phabricator instance.

[clang][VE] Change to use only use major version in resource dir
ClosedPublic

Authored by kaz7 on Feb 6 2023, 3:54 PM.

Details

Summary

VE's makefile needs to know resource directory in order to compile crt-ve
correctly. The path of resource directory is changed at e1b88c8. So, we
need to correct our definition of resource directory in makefile.

This problem, not working top-level CMake with VE, will be fixed once
https://reviews.llvm.org/D89492 is merged.

Diff Detail

Event Timeline

kaz7 created this revision.Feb 6 2023, 3:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2023, 3:54 PM
kaz7 requested review of this revision.Feb 6 2023, 3:54 PM

Adding Simon as a reviewer.

Thanks for the patch, Marukawa-san!

It looks good at a quick glance. But please wait for Simon's approval before committing.

LGTM. I am no longer the maintainer of the VE bot, though.

gkistanova accepted this revision.Feb 13 2023, 7:16 PM
This revision is now accepted and ready to land.Feb 13 2023, 7:16 PM
kaz7 added a comment.Feb 14 2023, 12:30 AM

Hi Galina-san, Simon-san,

Simon and me were the maintainer of the VE and VE bot. But, Simon left us a year ago, so I'm the last member of the VE and VE bot now. VE bot haven't shown any problems, so this is my first action as a VE bot maintainer.

When I've tried to modify upstream/main with this patch, I've noticed than't I have no permission to write zorg. It's the reason why I send this patch for review.

So, @gkistanova -san, please land this patch. Thank you.