Putting all the options in the same file is needed so they can be
ordered based on the dependencies between them.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Hello
Did you mean to remove CC1Options.td too? Otherwise it does not appear to be used any more or this has duplicated the contents.
Also can you make sure the new content of Options.td reflects the latest version of CC1Options.td, and that no extra changes have been made since this was created.
Thanks
Could you add the normalization back? This is in line with the comment to make sure the old and new files align.
clang/include/clang/Driver/Options.td | ||
---|---|---|
3436 | There is some explicit normalization missing here. In CC1Options.td this is def triple : Separate<["-"], "triple">, HelpText<"Specify target triple (e.g. i686-apple-darwin9)">, MarshallingInfoString<"TargetOpts->Triple", "llvm::Triple::normalize(llvm::sys::getDefaultTargetTriple())", "std::string">, AlwaysEmit, Normalizer<"normalizeTriple">, DenormalizeString; It seems the normalizer does not apply to the defaults and we now see a failure in clang/unittests/Frontend/CompilerInvocationTest.cpp for powerpc targets. |
clang/include/clang/Driver/Options.td | ||
---|---|---|
3436 | Of course, I must have lost it at some point. Can you link me to the failure for reference. |
clang/include/clang/Driver/Options.td | ||
---|---|---|
3436 | Done in 0555db0a5df4 |
There is some explicit normalization missing here. In CC1Options.td this is
It seems the normalizer does not apply to the defaults and we now see a failure in clang/unittests/Frontend/CompilerInvocationTest.cpp for powerpc targets.