Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Paths

Table of Contentst

Turn arcmt-* options into a single option
ClosedPublic
Actions

Authored by jansvoboda11 on Jul 7 2020, 8:52 AM.

Details

Reviewers

Bigcheese
dang

Commits

rG05eeda9752b3: [clang][cli] Turn arcmt-* options into a single option

Summary

The new option, -arcmt-action, is a simple enum based option.
The driver is modified to translate the existing -ccc-acmt-* options accordingly

Depends on D83298

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

dang created this revision.Jul 7 2020, 8:52 AM

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 7 2020, 8:52 AM

Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. · View Herald Transcript

Harbormaster failed remote builds in B63222: Diff 276088!Jul 7 2020, 8:52 AM

I have a slight preference for -arcmt-action=, but up to you if you want to change it. Otherwise LGTM.

This revision is now accepted and ready to land.Jul 7 2020, 10:31 AM

Instead of using a Separate option kind (-arcmt-action action) use a Joined kind (-arcmt-action=*)

Harbormaster failed remote builds in B63421: Diff 276438!Jul 8 2020, 7:56 AM

dang added a child revision: D83406: Remove NormalizerRetTy and use the decltype of the KeyPath instead.Jul 8 2020, 9:38 AM

Taking over this patch, as Daniel is no longer involved.

This revision was landed with ongoing or failed builds.Nov 18 2020, 1:54 AM

Closed by commit rG05eeda9752b3: [clang][cli] Turn arcmt-* options into a single option (authored by jansvoboda11). · Explain Why

This revision was automatically updated to reflect the committed changes.

jansvoboda11 added a commit: rG05eeda9752b3: [clang][cli] Turn arcmt-* options into a single option.

Revision Contents
Changeset List

Path

Size

clang/

include/

clang/

Driver/

Options.td

15 lines

lib/

Driver/

ToolChains/

Clang.cpp

6 lines

Frontend/

CompilerInvocation.cpp

68 lines

test/

ARCMT/

GC-check-warn-nsalloc.m

4 lines

GC-check.m

4 lines

atautorelease-check.m

2 lines

check-api.m

2 lines

check-with-pch.m

2 lines

check-with-serialized-diag.m

2 lines

2 lines

2 lines

2 lines

2 lines

migrate-emit-errors.m

4 lines

migrate-plist-output.m

2 lines

migrate-space-in-path.m

4 lines

migrate-with-pch.m

4 lines

migrate.m

4 lines

no-canceling-bridge-to-bridge-cast.m

2 lines

nonobjc-to-objc-cast-2.m

2 lines

releases-driver.m

2 lines

releases-driver.m.result

2 lines

verify.m

4 lines

with-arc-mode-modify.m

2 lines

with-arc-mode-modify.m.result

2 lines

llvm/

include/

llvm/

Option/

OptParser.td

3 lines

utils/

TableGen/

OptParserEmitter.cpp

2 lines

Diff 306008

View Options

clang/include/clang/Driver/Options.td

View Options

clang/lib/Driver/ToolChains/Clang.cpp

View Options

clang/lib/Frontend/CompilerInvocation.cpp

View Options

clang/test/ARCMT/GC-check-warn-nsalloc.m

View Options

clang/test/ARCMT/GC-check.m

View Options

clang/test/ARCMT/atautorelease-check.m

View Options

clang/test/ARCMT/check-api.m

View Options

clang/test/ARCMT/check-with-pch.m

View Options

clang/test/ARCMT/check-with-serialized-diag.m

View Options

clang/test/ARCMT/checking-in-arc.m

View Options

clang/test/ARCMT/checking.m

View Options

clang/test/ARCMT/cxx-checking.mm

View Options

clang/test/ARCMT/driver-migrate.m

View Options

clang/test/ARCMT/migrate-emit-errors.m

View Options

clang/test/ARCMT/migrate-plist-output.m

View Options

clang/test/ARCMT/migrate-space-in-path.m

View Options

clang/test/ARCMT/migrate-with-pch.m

View Options

clang/test/ARCMT/migrate.m

View Options

clang/test/ARCMT/no-canceling-bridge-to-bridge-cast.m

View Options

clang/test/ARCMT/nonobjc-to-objc-cast-2.m

View Options

clang/test/ARCMT/releases-driver.m

View Options

clang/test/ARCMT/releases-driver.m.result

View Options

clang/test/ARCMT/verify.m

View Options

clang/test/ARCMT/with-arc-mode-modify.m

View Options

clang/test/ARCMT/with-arc-mode-modify.m.result

View Options

llvm/include/llvm/Option/OptParser.td

View Options

llvm/utils/TableGen/OptParserEmitter.cpp

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Turn arcmt-* options into a single optionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 306008

clang/include/clang/Driver/Options.td

clang/lib/Driver/ToolChains/Clang.cpp

clang/lib/Frontend/CompilerInvocation.cpp

clang/test/ARCMT/GC-check-warn-nsalloc.m

clang/test/ARCMT/GC-check.m

clang/test/ARCMT/atautorelease-check.m

clang/test/ARCMT/check-api.m

clang/test/ARCMT/check-with-pch.m

clang/test/ARCMT/check-with-serialized-diag.m

clang/test/ARCMT/checking-in-arc.m

clang/test/ARCMT/checking.m

clang/test/ARCMT/cxx-checking.mm

clang/test/ARCMT/driver-migrate.m

clang/test/ARCMT/migrate-emit-errors.m

clang/test/ARCMT/migrate-plist-output.m

clang/test/ARCMT/migrate-space-in-path.m

clang/test/ARCMT/migrate-with-pch.m

clang/test/ARCMT/migrate.m

clang/test/ARCMT/no-canceling-bridge-to-bridge-cast.m

clang/test/ARCMT/nonobjc-to-objc-cast-2.m

clang/test/ARCMT/releases-driver.m

clang/test/ARCMT/releases-driver.m.result

clang/test/ARCMT/verify.m

clang/test/ARCMT/with-arc-mode-modify.m

clang/test/ARCMT/with-arc-mode-modify.m.result

llvm/include/llvm/Option/OptParser.td

llvm/utils/TableGen/OptParserEmitter.cpp

Turn arcmt-* options into a single option
ClosedPublic
Actions

Revision Contents
Changeset List