Page MenuHomePhabricator

Turn arcmt-* options into a single option
AcceptedPublic

Authored by dang on Tue, Jul 7, 8:52 AM.

Details

Reviewers
Bigcheese
Summary
  • The new option, -arcmt-action, is a simple enum based option.
  • The driver is modified to translate the existing -ccc-acmt-* options accordingly

Depends on D83298

Diff Detail

Event Timeline

dang created this revision.Tue, Jul 7, 8:52 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptTue, Jul 7, 8:52 AM
Bigcheese accepted this revision.Tue, Jul 7, 10:31 AM

I have a slight preference for -arcmt-action=, but up to you if you want to change it. Otherwise LGTM.

This revision is now accepted and ready to land.Tue, Jul 7, 10:31 AM
dang updated this revision to Diff 276438.Wed, Jul 8, 7:55 AM

Instead of using a Separate option kind (-arcmt-action action) use a Joined kind (-arcmt-action=*)