Page MenuHomePhabricator

vdmitrie (Valeriy Dmitriev)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 30 2018, 9:33 AM (237 w, 6 d)

Recent Activity

Thu, Mar 16

vdmitrie accepted D146167: [SLP]Introduce shuffle of the nodes + gather/vectorbuild of the remaining scalars..

LGTM. Thanks.

Thu, Mar 16, 6:10 PM · Restricted Project, Restricted Project
vdmitrie committed rG4c2299003fe1: [TTI] Add X86 target specific version of getPointersChainCost. (authored by vdmitrie).
[TTI] Add X86 target specific version of getPointersChainCost.
Thu, Mar 16, 10:27 AM · Restricted Project, Restricted Project
vdmitrie closed D146102: [TTI] Add X86 target specific version of getPointersChainCost..
Thu, Mar 16, 10:27 AM · Restricted Project, Restricted Project

Tue, Mar 14

vdmitrie requested review of D146102: [TTI] Add X86 target specific version of getPointersChainCost..
Tue, Mar 14, 3:30 PM · Restricted Project, Restricted Project
vdmitrie committed rGf9b438b51971: [SLP] Outline GEP chain cost modeling into new TTI interface - NFCI. (authored by vdmitrie).
[SLP] Outline GEP chain cost modeling into new TTI interface - NFCI.
Tue, Mar 14, 2:02 PM · Restricted Project, Restricted Project
vdmitrie closed D144770: [SLP] Outline GEP chain cost modeling into new TTI interface - NFCI..
Tue, Mar 14, 2:01 PM · Restricted Project, Restricted Project
vdmitrie updated the diff for D144770: [SLP] Outline GEP chain cost modeling into new TTI interface - NFCI..

rebase

Tue, Mar 14, 1:07 PM · Restricted Project, Restricted Project

Mon, Mar 13

vdmitrie accepted D145988: [SLP]Remove CreateShuffle lambda and reuse ShuffleBuilder functions..

LG

Mon, Mar 13, 6:18 PM · Restricted Project, Restricted Project
vdmitrie updated the diff for D144770: [SLP] Outline GEP chain cost modeling into new TTI interface - NFCI..

Fixed issues revealed with more extensive test run.
Removed asserts from base implementation. Same GEPs origin is not guaranteed and and I don't find asserting for kinds of incoming pointers as quite useful.
Added assertion that Base is provided if sameBase is set.
PointersChainInfo changed to satisfy static assert condition on Windows.
Rebased.

Mon, Mar 13, 11:31 AM · Restricted Project, Restricted Project

Fri, Mar 10

vdmitrie added a comment to D145732: [SLP][NFC]Initial merge of gather/buildvector code in the createBuildVector function..

Looks good with a nit. I'm fine if it addressed in a separate patch since we have quite a few places in SLP vectorizer like here:
for (auto [I, V] : enumerate(VL)) {

Fri, Mar 10, 10:23 AM · Restricted Project, Restricted Project
vdmitrie added inline comments to D145732: [SLP][NFC]Initial merge of gather/buildvector code in the createBuildVector function..
Fri, Mar 10, 9:55 AM · Restricted Project, Restricted Project
vdmitrie added inline comments to D145732: [SLP][NFC]Initial merge of gather/buildvector code in the createBuildVector function..
Fri, Mar 10, 9:47 AM · Restricted Project, Restricted Project

Thu, Mar 9

vdmitrie added inline comments to D144770: [SLP] Outline GEP chain cost modeling into new TTI interface - NFCI..
Thu, Mar 9, 1:54 PM · Restricted Project, Restricted Project
vdmitrie added inline comments to D144770: [SLP] Outline GEP chain cost modeling into new TTI interface - NFCI..
Thu, Mar 9, 12:12 PM · Restricted Project, Restricted Project

Wed, Mar 8

vdmitrie updated the diff for D144770: [SLP] Outline GEP chain cost modeling into new TTI interface - NFCI..

add zero initializer for reserved field as some compilers complain

Wed, Mar 8, 6:21 PM · Restricted Project, Restricted Project
vdmitrie updated the diff for D144770: [SLP] Outline GEP chain cost modeling into new TTI interface - NFCI..

Address comments

Wed, Mar 8, 5:33 PM · Restricted Project, Restricted Project
vdmitrie added inline comments to D144770: [SLP] Outline GEP chain cost modeling into new TTI interface - NFCI..
Wed, Mar 8, 10:10 AM · Restricted Project, Restricted Project

Tue, Mar 7

vdmitrie updated the diff for D144770: [SLP] Outline GEP chain cost modeling into new TTI interface - NFCI..

Address comments to add assertions.
Rebase.

Tue, Mar 7, 1:20 PM · Restricted Project, Restricted Project
vdmitrie added a comment to D144958: [SLP]Initial support for reshuffling of non-starting buildvector/gather nodes..

LG. Thanks.

Tue, Mar 7, 9:27 AM · Restricted Project, Restricted Project
vdmitrie added inline comments to D144958: [SLP]Initial support for reshuffling of non-starting buildvector/gather nodes..
Tue, Mar 7, 9:12 AM · Restricted Project, Restricted Project

Wed, Mar 1

vdmitrie added inline comments to D144770: [SLP] Outline GEP chain cost modeling into new TTI interface - NFCI..
Wed, Mar 1, 8:55 AM · Restricted Project, Restricted Project
vdmitrie added inline comments to D144770: [SLP] Outline GEP chain cost modeling into new TTI interface - NFCI..
Wed, Mar 1, 8:34 AM · Restricted Project, Restricted Project

Tue, Feb 28

vdmitrie added inline comments to D144958: [SLP]Initial support for reshuffling of non-starting buildvector/gather nodes..
Tue, Feb 28, 6:12 PM · Restricted Project, Restricted Project
vdmitrie added a comment to D144770: [SLP] Outline GEP chain cost modeling into new TTI interface - NFCI..

I thought they don't have remarks. Maybe add remarks to some other tests?

Tue, Feb 28, 5:09 PM · Restricted Project, Restricted Project
vdmitrie updated the diff for D144770: [SLP] Outline GEP chain cost modeling into new TTI interface - NFCI..

Address comment.
Rebase.

Tue, Feb 28, 4:57 PM · Restricted Project, Restricted Project
vdmitrie committed rGec7154fe7028: [SLP] Add banner argument to SLP costs debug printer method - NFC. (authored by vdmitrie).
[SLP] Add banner argument to SLP costs debug printer method - NFC.
Tue, Feb 28, 11:23 AM · Restricted Project, Restricted Project
vdmitrie closed D144992: [SLP] Add banner argument to SLP costs debug printer method - NFC..
Tue, Feb 28, 11:23 AM · Restricted Project, Restricted Project
vdmitrie added inline comments to D144770: [SLP] Outline GEP chain cost modeling into new TTI interface - NFCI..
Tue, Feb 28, 11:20 AM · Restricted Project, Restricted Project
vdmitrie requested review of D144992: [SLP] Add banner argument to SLP costs debug printer method - NFC..
Tue, Feb 28, 11:01 AM · Restricted Project, Restricted Project

Mon, Feb 27

vdmitrie added a comment to D144770: [SLP] Outline GEP chain cost modeling into new TTI interface - NFCI..

I'd expect this to cause cost changes - have you had any luck creating tests demonstrating that?

I was not able to make one. Existing tests that are sensitive to this cost modeling are:

  • for plain wide loads:

llvm/test/Transforms/SLPVectorizer/X86/remark_horcost.ll
llvm/test/Transforms/SLPVectorizer/X86/remark_not_all_parts.ll

  • for gather loads:

llvm/test/Transforms/SLPVectorizer/X86/remark_gather-load-redux-cost.ll

But yep, I agree that this is not a great coverage.

Make them to emit remarks with costs estimations?

Mon, Feb 27, 5:43 PM · Restricted Project, Restricted Project
vdmitrie added inline comments to D144770: [SLP] Outline GEP chain cost modeling into new TTI interface - NFCI..
Mon, Feb 27, 5:34 PM · Restricted Project, Restricted Project
vdmitrie added a comment to D144770: [SLP] Outline GEP chain cost modeling into new TTI interface - NFCI..

I'd expect this to cause cost changes - have you had any luck creating tests demonstrating that?

Mon, Feb 27, 5:22 PM · Restricted Project, Restricted Project
vdmitrie updated the diff for D144770: [SLP] Outline GEP chain cost modeling into new TTI interface - NFCI..

Address comments. Rebase.

Mon, Feb 27, 5:15 PM · Restricted Project, Restricted Project

Fri, Feb 24

vdmitrie requested review of D144770: [SLP] Outline GEP chain cost modeling into new TTI interface - NFCI..
Fri, Feb 24, 7:20 PM · Restricted Project, Restricted Project
vdmitrie accepted D144689: [SLP]Improve handling gathers/buildvectors with undefs..
Fri, Feb 24, 10:27 AM · Restricted Project, Restricted Project

Thu, Feb 23

vdmitrie added inline comments to D144689: [SLP]Improve handling gathers/buildvectors with undefs..
Thu, Feb 23, 6:48 PM · Restricted Project, Restricted Project

Feb 16 2023

vdmitrie accepted D132261: [SLP]Do not reduce repeated values, use scalar red ops instead..

Perfect! Looks good. Thanks, Alexey!

Feb 16 2023, 5:43 PM · Restricted Project, Restricted Project
vdmitrie added inline comments to D132261: [SLP]Do not reduce repeated values, use scalar red ops instead..
Feb 16 2023, 4:56 PM · Restricted Project, Restricted Project
vdmitrie added inline comments to D132261: [SLP]Do not reduce repeated values, use scalar red ops instead..
Feb 16 2023, 4:51 PM · Restricted Project, Restricted Project
vdmitrie added a comment to D132261: [SLP]Do not reduce repeated values, use scalar red ops instead..

Thanks. This revision basically looks good to me. So I'm going to accept it.
@RKSimon , do you have any remarks/comments/concerns?

Feb 16 2023, 4:10 PM · Restricted Project, Restricted Project
vdmitrie added inline comments to D132261: [SLP]Do not reduce repeated values, use scalar red ops instead..
Feb 16 2023, 11:39 AM · Restricted Project, Restricted Project
vdmitrie added inline comments to D132261: [SLP]Do not reduce repeated values, use scalar red ops instead..
Feb 16 2023, 10:04 AM · Restricted Project, Restricted Project

Feb 13 2023

vdmitrie added inline comments to D132261: [SLP]Do not reduce repeated values, use scalar red ops instead..
Feb 13 2023, 6:29 PM · Restricted Project, Restricted Project
vdmitrie added inline comments to D132261: [SLP]Do not reduce repeated values, use scalar red ops instead..
Feb 13 2023, 3:25 PM · Restricted Project, Restricted Project
vdmitrie added a comment to D132261: [SLP]Do not reduce repeated values, use scalar red ops instead..

I'm sorry for the delay. Was bit overloaded with an internal stuff.

Feb 13 2023, 3:05 PM · Restricted Project, Restricted Project

Jan 20 2023

vdmitrie added a comment to D132261: [SLP]Do not reduce repeated values, use scalar red ops instead..

I'll try to look at this closely next week (but not earlier than Monday). Just a quick note about terminology used. The option name "slp-same-scalars-reduction" does not actually tell much about what it actually controls.
Since you basically are trying to optimize away identity operations in reduction sequences I'd suggest you to use name for option and across the code that better reflect that.
The option name could be "-slp-optimize-identity-hor-reduction-ops=true|false" for example.

Jan 20 2023, 12:57 PM · Restricted Project, Restricted Project

Jan 19 2023

vdmitrie accepted D141512: [SLP]Improve isGatherShuffledEntry by looking deeper through the reused scalars..

LG. Thanks.

Jan 19 2023, 11:47 AM · Restricted Project, Restricted Project
vdmitrie added inline comments to D141512: [SLP]Improve isGatherShuffledEntry by looking deeper through the reused scalars..
Jan 19 2023, 10:03 AM · Restricted Project, Restricted Project
vdmitrie added inline comments to D141512: [SLP]Improve isGatherShuffledEntry by looking deeper through the reused scalars..
Jan 19 2023, 9:16 AM · Restricted Project, Restricted Project

Jan 18 2023

vdmitrie added inline comments to D141512: [SLP]Improve isGatherShuffledEntry by looking deeper through the reused scalars..
Jan 18 2023, 6:25 PM · Restricted Project, Restricted Project

Jan 13 2023

vdmitrie committed rGd1fbe2ba6d40: [SLP] Remove unused check label from test - NFC (authored by vdmitrie).
[SLP] Remove unused check label from test - NFC
Jan 13 2023, 4:01 PM · Restricted Project, Restricted Project
vdmitrie added a comment to D132261: [SLP]Do not reduce repeated values, use scalar red ops instead..

A couple of general thoughts. Can you please add a knob that allows to turn off the optimization? And can some sort of debug tracing be added? Such as values that has been optimized away?

Jan 13 2023, 10:55 AM · Restricted Project, Restricted Project
vdmitrie added inline comments to D141512: [SLP]Improve isGatherShuffledEntry by looking deeper through the reused scalars..
Jan 13 2023, 10:23 AM · Restricted Project, Restricted Project

Jan 10 2023

vdmitrie committed rGfd7273359a33: [SLP] Do not ignore ordering for root node when it has in-tree uses. (authored by vdmitrie).
[SLP] Do not ignore ordering for root node when it has in-tree uses.
Jan 10 2023, 10:13 AM · Restricted Project, Restricted Project
vdmitrie closed D141309: [SLP] Do not ignore ordering for root node when it has in-tree uses..
Jan 10 2023, 10:13 AM · Restricted Project, Restricted Project

Jan 9 2023

vdmitrie updated the diff for D141309: [SLP] Do not ignore ordering for root node when it has in-tree uses..

rename method as per suggestion

Jan 9 2023, 5:10 PM · Restricted Project, Restricted Project
vdmitrie updated the diff for D141309: [SLP] Do not ignore ordering for root node when it has in-tree uses..

address comment

Jan 9 2023, 2:22 PM · Restricted Project, Restricted Project
vdmitrie added inline comments to D141309: [SLP] Do not ignore ordering for root node when it has in-tree uses..
Jan 9 2023, 11:53 AM · Restricted Project, Restricted Project
vdmitrie added inline comments to D141309: [SLP] Do not ignore ordering for root node when it has in-tree uses..
Jan 9 2023, 11:43 AM · Restricted Project, Restricted Project
vdmitrie requested review of D141309: [SLP] Do not ignore ordering for root node when it has in-tree uses..
Jan 9 2023, 11:07 AM · Restricted Project, Restricted Project

Jan 6 2023

vdmitrie accepted D141161: [SLP]Fix incorrect reordering of clustered scalars..

LG. Thanks

Jan 6 2023, 2:41 PM · Restricted Project, Restricted Project

Jan 5 2023

vdmitrie committed rG6d677c0b3d91: [SLP] Unify GEP cost modeling for load, store and GEP nodes. (authored by vdmitrie).
[SLP] Unify GEP cost modeling for load, store and GEP nodes.
Jan 5 2023, 10:12 AM · Restricted Project, Restricted Project
vdmitrie closed D140789: [SLP] Unify GEP cost modeling for load, store and GEP nodes..
Jan 5 2023, 10:12 AM · Restricted Project, Restricted Project

Jan 4 2023

vdmitrie added inline comments to D140789: [SLP] Unify GEP cost modeling for load, store and GEP nodes..
Jan 4 2023, 10:50 AM · Restricted Project, Restricted Project
vdmitrie added inline comments to D140789: [SLP] Unify GEP cost modeling for load, store and GEP nodes..
Jan 4 2023, 10:29 AM · Restricted Project, Restricted Project
vdmitrie added inline comments to D140789: [SLP] Unify GEP cost modeling for load, store and GEP nodes..
Jan 4 2023, 10:11 AM · Restricted Project, Restricted Project

Jan 3 2023

vdmitrie updated the diff for D140789: [SLP] Unify GEP cost modeling for load, store and GEP nodes..

Address comment + rebase

Jan 3 2023, 2:34 PM · Restricted Project, Restricted Project
vdmitrie added inline comments to D140789: [SLP] Unify GEP cost modeling for load, store and GEP nodes..
Jan 3 2023, 11:57 AM · Restricted Project, Restricted Project
vdmitrie added a comment to D140789: [SLP] Unify GEP cost modeling for load, store and GEP nodes..

Jan 3 2023, 10:45 AM · Restricted Project, Restricted Project
vdmitrie added inline comments to D140789: [SLP] Unify GEP cost modeling for load, store and GEP nodes..
Jan 3 2023, 9:14 AM · Restricted Project, Restricted Project

Dec 30 2022

vdmitrie requested review of D140789: [SLP] Unify GEP cost modeling for load, store and GEP nodes..
Dec 30 2022, 2:47 PM · Restricted Project, Restricted Project
vdmitrie committed rG6bb4b2d00221: [NFC] Test case intended to cover SLP cost for chain with masked gather loads. (authored by vdmitrie).
[NFC] Test case intended to cover SLP cost for chain with masked gather loads.
Dec 30 2022, 12:32 PM · Restricted Project, Restricted Project
vdmitrie closed D140785: [NFC] Test case intended to cover SLP cost for chain with masked gather loads..
Dec 30 2022, 12:32 PM · Restricted Project, Restricted Project
vdmitrie requested review of D140785: [NFC] Test case intended to cover SLP cost for chain with masked gather loads..
Dec 30 2022, 11:46 AM · Restricted Project, Restricted Project

Dec 29 2022

vdmitrie accepted D140580: [SLP]Do not emit many extractelements, reuse the single one emitted..

LG. Please fix indentation before pushing the patch. Thanks.

Dec 29 2022, 4:48 PM · Restricted Project, Restricted Project
vdmitrie committed rGad956ed568ce: [SLP] Fix debug print for cost in tryToVectorizeList - NFC. (authored by vdmitrie).
[SLP] Fix debug print for cost in tryToVectorizeList - NFC.
Dec 29 2022, 11:31 AM · Restricted Project, Restricted Project
vdmitrie committed rG8eb3698b940c: [SLP] A couple of minor improvements for slp graph view - NFC. (authored by vdmitrie).
[SLP] A couple of minor improvements for slp graph view - NFC.
Dec 29 2022, 11:03 AM · Restricted Project, Restricted Project

Dec 20 2022

vdmitrie accepted D140100: [SLP]Integrate looking through shuffles logic into ShuffleInstructionBuilder..

Looks good. Thanks.

Dec 20 2022, 5:22 PM · Restricted Project, Restricted Project

Dec 16 2022

vdmitrie added inline comments to D140100: [SLP]Integrate looking through shuffles logic into ShuffleInstructionBuilder..
Dec 16 2022, 11:25 AM · Restricted Project, Restricted Project
vdmitrie added inline comments to D140100: [SLP]Integrate looking through shuffles logic into ShuffleInstructionBuilder..
Dec 16 2022, 10:32 AM · Restricted Project, Restricted Project

Dec 15 2022

vdmitrie added inline comments to D140100: [SLP]Integrate looking through shuffles logic into ShuffleInstructionBuilder..
Dec 15 2022, 6:25 PM · Restricted Project, Restricted Project

Dec 13 2022

vdmitrie accepted D139718: [SLP][NFC]Inital redesign of ShuffleInstructionBuilder, NFC..

Looks good. Thanks!

Dec 13 2022, 9:22 AM · Restricted Project, Restricted Project

Dec 12 2022

vdmitrie added inline comments to D139718: [SLP][NFC]Inital redesign of ShuffleInstructionBuilder, NFC..
Dec 12 2022, 6:34 PM · Restricted Project, Restricted Project

Dec 9 2022

vdmitrie added inline comments to D139718: [SLP][NFC]Inital redesign of ShuffleInstructionBuilder, NFC..
Dec 9 2022, 10:12 AM · Restricted Project, Restricted Project
vdmitrie added inline comments to D139718: [SLP][NFC]Inital redesign of ShuffleInstructionBuilder, NFC..
Dec 9 2022, 10:03 AM · Restricted Project, Restricted Project
vdmitrie added inline comments to D139718: [SLP][NFC]Inital redesign of ShuffleInstructionBuilder, NFC..
Dec 9 2022, 9:35 AM · Restricted Project, Restricted Project

Dec 7 2022

vdmitrie added inline comments to D137913: [X86] Rewrite `getScalarizationOverhead()`.
Dec 7 2022, 3:10 PM · Restricted Project, Restricted Project
vdmitrie added inline comments to D137913: [X86] Rewrite `getScalarizationOverhead()`.
Dec 7 2022, 1:53 PM · Restricted Project, Restricted Project
vdmitrie added inline comments to D137913: [X86] Rewrite `getScalarizationOverhead()`.
Dec 7 2022, 1:09 PM · Restricted Project, Restricted Project
vdmitrie added inline comments to D137913: [X86] Rewrite `getScalarizationOverhead()`.
Dec 7 2022, 12:56 PM · Restricted Project, Restricted Project
vdmitrie added inline comments to D137913: [X86] Rewrite `getScalarizationOverhead()`.
Dec 7 2022, 12:45 PM · Restricted Project, Restricted Project
vdmitrie added inline comments to D137913: [X86] Rewrite `getScalarizationOverhead()`.
Dec 7 2022, 11:54 AM · Restricted Project, Restricted Project

Nov 21 2022

vdmitrie added inline comments to D135282: [SLP]Improve costs of vectorized loads/stores by analyzing GEPs..
Nov 21 2022, 11:28 AM · Restricted Project, Restricted Project

Nov 18 2022

vdmitrie added inline comments to D135282: [SLP]Improve costs of vectorized loads/stores by analyzing GEPs..
Nov 18 2022, 5:25 PM · Restricted Project, Restricted Project
vdmitrie added inline comments to D135282: [SLP]Improve costs of vectorized loads/stores by analyzing GEPs..
Nov 18 2022, 2:32 PM · Restricted Project, Restricted Project
vdmitrie added inline comments to D135282: [SLP]Improve costs of vectorized loads/stores by analyzing GEPs..
Nov 18 2022, 10:22 AM · Restricted Project, Restricted Project
vdmitrie added inline comments to D135282: [SLP]Improve costs of vectorized loads/stores by analyzing GEPs..
Nov 18 2022, 10:04 AM · Restricted Project, Restricted Project
vdmitrie added inline comments to D135282: [SLP]Improve costs of vectorized loads/stores by analyzing GEPs..
Nov 18 2022, 9:39 AM · Restricted Project, Restricted Project

Nov 17 2022

vdmitrie added inline comments to D135282: [SLP]Improve costs of vectorized loads/stores by analyzing GEPs..
Nov 17 2022, 6:31 PM · Restricted Project, Restricted Project

Oct 27 2022

vdmitrie accepted D127531: [SLP]Improve analysis of same/alternate code ops and scheduling..

Looks good. Thanks!

Oct 27 2022, 9:46 AM · Restricted Project, Restricted Project