User Details
- User Since
- Aug 30 2018, 9:33 AM (237 w, 6 d)
Thu, Mar 16
LGTM. Thanks.
Tue, Mar 14
rebase
Mon, Mar 13
LG
Fixed issues revealed with more extensive test run.
Removed asserts from base implementation. Same GEPs origin is not guaranteed and and I don't find asserting for kinds of incoming pointers as quite useful.
Added assertion that Base is provided if sameBase is set.
PointersChainInfo changed to satisfy static assert condition on Windows.
Rebased.
Fri, Mar 10
Looks good with a nit. I'm fine if it addressed in a separate patch since we have quite a few places in SLP vectorizer like here:
for (auto [I, V] : enumerate(VL)) {
Thu, Mar 9
Wed, Mar 8
add zero initializer for reserved field as some compilers complain
Address comments
Tue, Mar 7
Address comments to add assertions.
Rebase.
LG. Thanks.
Wed, Mar 1
Tue, Feb 28
I thought they don't have remarks. Maybe add remarks to some other tests?
Address comment.
Rebase.
Mon, Feb 27
Address comments. Rebase.
Fri, Feb 24
Thu, Feb 23
Feb 16 2023
Perfect! Looks good. Thanks, Alexey!
Thanks. This revision basically looks good to me. So I'm going to accept it.
@RKSimon , do you have any remarks/comments/concerns?
Feb 13 2023
I'm sorry for the delay. Was bit overloaded with an internal stuff.
Jan 20 2023
I'll try to look at this closely next week (but not earlier than Monday). Just a quick note about terminology used. The option name "slp-same-scalars-reduction" does not actually tell much about what it actually controls.
Since you basically are trying to optimize away identity operations in reduction sequences I'd suggest you to use name for option and across the code that better reflect that.
The option name could be "-slp-optimize-identity-hor-reduction-ops=true|false" for example.
Jan 19 2023
LG. Thanks.
Jan 18 2023
Jan 13 2023
A couple of general thoughts. Can you please add a knob that allows to turn off the optimization? And can some sort of debug tracing be added? Such as values that has been optimized away?
Jan 10 2023
Jan 9 2023
rename method as per suggestion
address comment
Jan 6 2023
LG. Thanks
Jan 5 2023
Jan 4 2023
Jan 3 2023
Address comment + rebase
Dec 30 2022
Dec 29 2022
LG. Please fix indentation before pushing the patch. Thanks.
Dec 20 2022
Looks good. Thanks.
Dec 16 2022
Dec 15 2022
Dec 13 2022
Looks good. Thanks!
Dec 12 2022
Dec 9 2022
Dec 7 2022
Nov 21 2022
Nov 18 2022
Nov 17 2022
Oct 27 2022
Looks good. Thanks!