Page MenuHomePhabricator

Port ObjCMTAction to new option parsing system
Needs ReviewPublic

Authored by dang on Jun 30 2020, 4:03 AM.

Details

Reviewers
Bigcheese
Summary

Merge existing marhsalling info kinds and add some primitives to
express flag options that contribute to a bitfield.

Depends on D82574

Diff Detail

Event Timeline

dang created this revision.Jun 30 2020, 4:03 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 30 2020, 4:03 AM
dang marked an inline comment as done.Jun 30 2020, 4:05 AM
dang added inline comments.
clang/include/clang/Driver/Options.td
328–330

If this kind of combination of normalizer, value merger and extractor happen again, I will make a mixin that helps set this up. Or do you reckon it is worth doing it now for readability.

dang updated this revision to Diff 274425.Jun 30 2020, 4:54 AM

Denormalizer should also use the extractor

dang marked an inline comment as not done.Jun 30 2020, 10:13 AM
dang updated this revision to Diff 274736.Jul 1 2020, 3:16 AM

Remove the need for the merger and extractor to be macros

dang updated this revision to Diff 275171.Jul 2 2020, 11:09 AM

Ensure that mergeForwardValue can accept default values whose type doesn't quite match the associated keypath.

dang updated this revision to Diff 276008.Tue, Jul 7, 5:12 AM

Make mergers use values directly instead of constant references.