This is an archive of the discontinued LLVM Phabricator instance.

Merge TableGen files used for clang options

Authored by dang on Jun 25 2020, 9:09 AM.



Putting all the options in the same file is needed so they can be
ordered based on the dependencies between them.

Diff Detail

Event Timeline

dang created this revision.Jun 25 2020, 9:09 AM
Bigcheese accepted this revision.Jul 7 2020, 10:38 AM

LGTM. We can look at splitting it up again once we know what the dependencies are.

This revision is now accepted and ready to land.Jul 7 2020, 10:38 AM
This revision was automatically updated to reflect the committed changes.


Did you mean to remove too? Otherwise it does not appear to be used any more or this has duplicated the contents.

Also can you make sure the new content of reflects the latest version of, and that no extra changes have been made since this was created.


dang added a comment.Jul 9 2020, 10:09 PM

Yes I committed this a while ago, I duplicated all the functionality in

herhut added a subscriber: herhut.Jul 10 2020, 1:51 AM

Could you add the normalization back? This is in line with the comment to make sure the old and new files align.


There is some explicit normalization missing here. In this is

def triple : Separate<["-"], "triple">,
  HelpText<"Specify target triple (e.g. i686-apple-darwin9)">,
  MarshallingInfoString<"TargetOpts->Triple", "llvm::Triple::normalize(llvm::sys::getDefaultTargetTriple())", "std::string">,
  AlwaysEmit, Normalizer<"normalizeTriple">, DenormalizeString;

It seems the normalizer does not apply to the defaults and we now see a failure in clang/unittests/Frontend/CompilerInvocationTest.cpp for powerpc targets.

dang marked an inline comment as done.Jul 10 2020, 5:31 AM
dang added inline comments.

Of course, I must have lost it at some point. Can you link me to the failure for reference.

dang marked 2 inline comments as done.Jul 10 2020, 5:59 AM
dang added inline comments.

Done in 0555db0a5df4

I think that 'clang/include/clang/Driver/' should also be removed ?

dang added a comment.Jul 10 2020, 8:58 AM

I think that 'clang/include/clang/Driver/' should also be removed ?

Yes must have missed it when rebasing. Done now in 3607aacc5981

vdmitrie added inline comments.

This option was deleted.


This option was deleted.

dang added a comment.Jul 10 2020, 9:56 AM

Sorry again, removed the offending options in a2cffb11e287