Added parsing/sema/serialization supoprt for uses_allocators clause.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
A few nits and one question/concern below. Once/If that one is addressed this LGTM.
clang/lib/Sema/SemaOpenMP.cpp | ||
---|---|---|
4823 | Note: We should keep the OpenMP context available all the time and ask it for required clauses. That has to be done later though. | |
18618 | Nit: Typo | |
18628 | Nit: I guess after the condition below these three lines can be placed as bool IsPredefinedAllocator = PredefinedAllocators.count(DRE->getDecl()); | |
clang/test/OpenMP/target_uses_allocators_messages.cpp | ||
55 | Do we handle/test the case where the trait array is empty? omp_alloctrait_t empty_traits[0]; I guess that doesn't mean much and we should error out? |
I think @rnk might not be happy with this include as it might be costly.