This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] "UnFix" layering problem with FrontendOpenMP
ClosedPublic

Authored by jdoerfert on Apr 7 2020, 11:26 AM.

Details

Summary

This reverts commit 97aa593a8387586095b7eac12974ba2fdd08f4c3 as it
causes problems (PR45453) https://reviews.llvm.org/D77574#1966321.

This additionally adds an explicit reference to FrontendOpenMP to
clang-tidy where ASTMatchers is used.

This is hopefully just a temporary solution. The dependence on
FrontendOpenMP from ASTMatchers should be handled by CMake
implicitly, not us explicitly.

Diff Detail

Event Timeline

jdoerfert created this revision.Apr 7 2020, 11:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 7 2020, 11:26 AM
jdoerfert edited the summary of this revision. (Show Details)Apr 7 2020, 11:30 AM
aheejin accepted this revision.Apr 7 2020, 11:38 AM
aheejin added a subscriber: aheejin.

I don't know much about how this part works, but if this is purely a revert of the previous patch, I don't think you need a review for that.

This revision is now accepted and ready to land.Apr 7 2020, 11:38 AM
jdoerfert added a comment.EditedApr 7 2020, 12:01 PM

I don't know much about how this part works, but if this is purely a revert of the previous patch, I don't think you need a review for that.

It is not, as stated in the commit message. A pure revert will cause old failures to reappear, this one should not.


EDIT: I'll merge this to unblock some builders.

This revision was automatically updated to reflect the committed changes.