Page MenuHomePhabricator

usaxena95 (Utkarsh Saxena)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 28 2018, 2:16 AM (145 w, 4 d)

Recent Activity

Mon, May 17

usaxena95 added a comment to D102519: [clangd] Set FileSystem for tweaks in Check tool..

Did you need any other change ? Didn't realise the revision was not "accepted".

Mon, May 17, 2:13 AM · Restricted Project
usaxena95 committed rG0e7c7d461df1: [clangd] Set FileSystem for tweaks in Check tool. (authored by usaxena95).
[clangd] Set FileSystem for tweaks in Check tool.
Mon, May 17, 2:10 AM
usaxena95 closed D102519: [clangd] Set FileSystem for tweaks in Check tool..
Mon, May 17, 2:10 AM · Restricted Project
usaxena95 updated the diff for D102519: [clangd] Set FileSystem for tweaks in Check tool..

added comment.

Mon, May 17, 2:09 AM · Restricted Project

Fri, May 14

usaxena95 requested review of D102519: [clangd] Set FileSystem for tweaks in Check tool..
Fri, May 14, 11:27 AM · Restricted Project

May 4 2021

usaxena95 accepted D101851: Make clangd CompletionModel not depend on directory layout..
May 4 2021, 3:19 PM · Restricted Project
usaxena95 added inline comments to D101851: Make clangd CompletionModel not depend on directory layout..
May 4 2021, 3:04 PM · Restricted Project

May 3 2021

usaxena95 committed rGc3d5f306e910: [clangd] Find implementors only when index is present. (authored by usaxena95).
[clangd] Find implementors only when index is present.
May 3 2021, 8:17 AM
usaxena95 closed D101750: [clangd] Find implementors only when index is present..
May 3 2021, 8:16 AM · Restricted Project
usaxena95 requested review of D101750: [clangd] Find implementors only when index is present..
May 3 2021, 4:08 AM · Restricted Project

Apr 28 2021

usaxena95 committed rGd7cb2305a1e8: [clangd] Add SymbolID to LocatedSymbol. (authored by usaxena95).
[clangd] Add SymbolID to LocatedSymbol.
Apr 28 2021, 6:06 AM
usaxena95 closed D101388: [clangd] Add SymbolID to LocatedSymbol..
Apr 28 2021, 6:06 AM · Restricted Project
usaxena95 updated the summary of D101388: [clangd] Add SymbolID to LocatedSymbol..
Apr 28 2021, 5:58 AM · Restricted Project
usaxena95 updated the diff for D101388: [clangd] Add SymbolID to LocatedSymbol..

Addressed comments.

Apr 28 2021, 5:57 AM · Restricted Project
usaxena95 updated the summary of D101388: [clangd] Add SymbolID to LocatedSymbol..
Apr 28 2021, 5:56 AM · Restricted Project

Apr 27 2021

usaxena95 requested review of D101388: [clangd] Add SymbolID to LocatedSymbol..
Apr 27 2021, 11:48 AM · Restricted Project

Apr 7 2021

usaxena95 committed rGcd824a48cccb: [clang][Syntax] Handle invalid source range in expandedTokens. (authored by usaxena95).
[clang][Syntax] Handle invalid source range in expandedTokens.
Apr 7 2021, 2:19 AM
usaxena95 closed D99934: [clang][Syntax] Handle invalid source range in expandedTokens..
Apr 7 2021, 2:19 AM · Restricted Project
usaxena95 added a comment to D99934: [clang][Syntax] Handle invalid source range in expandedTokens..

Clangd was seen to be crashing on Objective C/C++ files.
It could not be reproduced but inspection of coredump showed that the expandedTokens returned arrayref with begin > end (negative length).

Apr 7 2021, 12:35 AM · Restricted Project

Apr 6 2021

usaxena95 updated the summary of D99934: [clang][Syntax] Handle invalid source range in expandedTokens..
Apr 6 2021, 3:09 AM · Restricted Project
usaxena95 requested review of D99934: [clang][Syntax] Handle invalid source range in expandedTokens..
Apr 6 2021, 3:00 AM · Restricted Project

Mar 25 2021

usaxena95 committed rGaa979084dffb: [clang][Syntax] Optimize expandedTokens for token ranges. (authored by usaxena95).
[clang][Syntax] Optimize expandedTokens for token ranges.
Mar 25 2021, 10:54 AM
usaxena95 closed D99086: [clang][Syntax] Optimize expandedTokens for token ranges..
Mar 25 2021, 10:54 AM · Restricted Project, Restricted Project
usaxena95 updated the diff for D99086: [clang][Syntax] Optimize expandedTokens for token ranges..

Addressed comments.

Mar 25 2021, 10:31 AM · Restricted Project, Restricted Project

Mar 24 2021

usaxena95 updated the diff for D99086: [clang][Syntax] Optimize expandedTokens for token ranges..

Remove unintended changes.

Mar 24 2021, 10:58 AM · Restricted Project, Restricted Project
usaxena95 updated the summary of D99086: [clang][Syntax] Optimize expandedTokens for token ranges..
Mar 24 2021, 10:50 AM · Restricted Project, Restricted Project
usaxena95 updated the diff for D99086: [clang][Syntax] Optimize expandedTokens for token ranges..

Made the optimization an 'opt-in'.
Created TokenBuffer::indexExpandedToken() for creating the index.

Mar 24 2021, 10:48 AM · Restricted Project, Restricted Project
usaxena95 updated the summary of D99086: [clang][Syntax] Optimize expandedTokens for token ranges..
Mar 24 2021, 10:48 AM · Restricted Project, Restricted Project

Mar 22 2021

usaxena95 added inline comments to D99086: [clang][Syntax] Optimize expandedTokens for token ranges..
Mar 22 2021, 12:07 PM · Restricted Project, Restricted Project
usaxena95 requested review of D99086: [clang][Syntax] Optimize expandedTokens for token ranges..
Mar 22 2021, 9:21 AM · Restricted Project, Restricted Project

Mar 18 2021

usaxena95 accepted D96787: Make clangd CompletionModel usable even with non-standard (but supported) layout.

LG. Thanks.
Sorry. This completely missed my inbox.

Mar 18 2021, 3:55 PM · Restricted Project

Mar 11 2021

usaxena95 accepted D98424: [clangd] Reject renames to non-identifier characters.

LGTM. Thanks.

Mar 11 2021, 9:21 AM · Restricted Project, Restricted Project

Mar 2 2021

usaxena95 added a reverting change for rG7f086d74c347: Revert "[clangd] Use ML Code completion ranking as default.": rG890190a61d64: Revert "Revert "[clangd] Use ML Code completion ranking as default."".
Mar 2 2021, 9:04 AM
usaxena95 committed rG890190a61d64: Revert "Revert "[clangd] Use ML Code completion ranking as default."" (authored by usaxena95).
Revert "Revert "[clangd] Use ML Code completion ranking as default.""
Mar 2 2021, 9:04 AM
usaxena95 committed rGbf935a034b34: [clangd] Make categorical features 64 bit in DecisionForest Model. (authored by usaxena95).
[clangd] Make categorical features 64 bit in DecisionForest Model.
Mar 2 2021, 7:27 AM
usaxena95 closed D97770: [clangd] Make categorical features 64 bit in DecisionForest Model..
Mar 2 2021, 7:27 AM · Restricted Project
usaxena95 added a reviewer for D97770: [clangd] Make categorical features 64 bit in DecisionForest Model.: sammccall.
Mar 2 2021, 7:11 AM · Restricted Project
usaxena95 requested review of D97770: [clangd] Make categorical features 64 bit in DecisionForest Model..
Mar 2 2021, 7:08 AM · Restricted Project
usaxena95 added a reverting change for rG438b5bb05a42: [clangd] Use ML Code completion ranking as default.: rG7f086d74c347: Revert "[clangd] Use ML Code completion ranking as default.".
Mar 2 2021, 6:05 AM
usaxena95 committed rG7f086d74c347: Revert "[clangd] Use ML Code completion ranking as default." (authored by usaxena95).
Revert "[clangd] Use ML Code completion ranking as default."
Mar 2 2021, 6:05 AM
usaxena95 added a reverting change for D96353: [clangd] Use ML Code completion ranking as default.: rG7f086d74c347: Revert "[clangd] Use ML Code completion ranking as default.".
Mar 2 2021, 6:05 AM · Restricted Project
usaxena95 updated the summary of D96353: [clangd] Use ML Code completion ranking as default..
Mar 2 2021, 2:00 AM · Restricted Project
usaxena95 committed rGbad8e577f9c7: Fix DecisionForestBenchmark.cpp compile errors (authored by usaxena95).
Fix DecisionForestBenchmark.cpp compile errors
Mar 2 2021, 1:28 AM
usaxena95 closed D97620: Fix DecisionForestBenchmark.cpp compile errors.
Mar 2 2021, 1:28 AM · Restricted Project, Restricted Project
usaxena95 committed rG438b5bb05a42: [clangd] Use ML Code completion ranking as default. (authored by usaxena95).
[clangd] Use ML Code completion ranking as default.
Mar 2 2021, 1:09 AM
usaxena95 closed D96353: [clangd] Use ML Code completion ranking as default..
Mar 2 2021, 1:08 AM · Restricted Project

Mar 1 2021

usaxena95 accepted D97620: Fix DecisionForestBenchmark.cpp compile errors.

LG. Thanks for noticing and fixing it!

Mar 1 2021, 2:42 AM · Restricted Project, Restricted Project

Feb 11 2021

usaxena95 added inline comments to D96353: [clangd] Use ML Code completion ranking as default..
Feb 11 2021, 1:37 AM · Restricted Project
usaxena95 updated the diff for D96353: [clangd] Use ML Code completion ranking as default..

Addressed comments.

Feb 11 2021, 1:37 AM · Restricted Project

Feb 9 2021

usaxena95 requested review of D96353: [clangd] Use ML Code completion ranking as default..
Feb 9 2021, 9:37 AM · Restricted Project
usaxena95 accepted D96262: [clang][index] report references from unreslovedLookupExpr..

Thanks. LG.
Couple of comments about adding tests to clangd as well.

Feb 9 2021, 7:52 AM · Restricted Project

Feb 3 2021

usaxena95 committed rG54afcade3bbc: [clangd] Report xref for base methods. (authored by usaxena95).
[clangd] Report xref for base methods.
Feb 3 2021, 3:08 AM
usaxena95 closed D95852: [clangd] Report xref for base methods..
Feb 3 2021, 3:08 AM · Restricted Project
usaxena95 updated the diff for D95852: [clangd] Report xref for base methods..

Addressed comments.

Feb 3 2021, 2:29 AM · Restricted Project

Feb 2 2021

usaxena95 added inline comments to D95852: [clangd] Report xref for base methods..
Feb 2 2021, 6:40 AM · Restricted Project
usaxena95 committed rGfbeff2ec2bc6: [clangd] Report only decl of overridding method in xref. (authored by usaxena95).
[clangd] Report only decl of overridding method in xref.
Feb 2 2021, 4:07 AM
usaxena95 closed D95812: [clangd] Report only decl of overridding method in xref..
Feb 2 2021, 4:06 AM · Restricted Project
usaxena95 updated the diff for D95812: [clangd] Report only decl of overridding method in xref..

Addressed comments.

Feb 2 2021, 3:48 AM · Restricted Project
usaxena95 added a reviewer for D95852: [clangd] Report xref for base methods.: hokein.
Feb 2 2021, 12:34 AM · Restricted Project
usaxena95 requested review of D95852: [clangd] Report xref for base methods..
Feb 2 2021, 12:06 AM · Restricted Project

Feb 1 2021

usaxena95 updated the diff for D95812: [clangd] Report only decl of overridding method in xref..

Remove unintended changes.

Feb 1 2021, 11:08 PM · Restricted Project
usaxena95 updated the diff for D95812: [clangd] Report only decl of overridding method in xref..

Print value of new OverriddenBy flag.

Feb 1 2021, 11:02 PM · Restricted Project
usaxena95 added a comment to D95812: [clangd] Report only decl of overridding method in xref..

This looks about right to me...
Unfortunately I landed ff4832dbff0ccf1fd29f726efe72fd1220cd645a and 1eb7fd089e2fcf3fe211f865b28e2fed12128c3f meanwhile so this will need a rebase :-(

The first of those patches introduces flags on returned refs to indicate which are decls/defs. I'd suggest adding an "override" flag and populating it for these results.

Feb 1 2021, 9:53 PM · Restricted Project
usaxena95 updated the diff for D95812: [clangd] Report only decl of overridding method in xref..

Rebase + Add OverriddenBy flag for such references.

Feb 1 2021, 9:50 PM · Restricted Project
usaxena95 added a reviewer for D95812: [clangd] Report only decl of overridding method in xref.: hokein.
Feb 1 2021, 12:32 PM · Restricted Project
usaxena95 updated the summary of D95812: [clangd] Report only decl of overridding method in xref..
Feb 1 2021, 12:31 PM · Restricted Project
usaxena95 updated the diff for D95812: [clangd] Report only decl of overridding method in xref..

Move Index query to more logical place.

Feb 1 2021, 12:30 PM · Restricted Project
usaxena95 requested review of D95812: [clangd] Report only decl of overridding method in xref..
Feb 1 2021, 12:23 PM · Restricted Project

Jan 19 2021

usaxena95 committed rG17846ed5af4a: [clangd] Use ASTSignals in Heuristics CC Ranking. (authored by usaxena95).
[clangd] Use ASTSignals in Heuristics CC Ranking.
Jan 19 2021, 10:49 AM
usaxena95 closed D94927: [clangd] Use ASTSignals in Heuristics CC Ranking..
Jan 19 2021, 10:49 AM · Restricted Project
usaxena95 updated the diff for D94927: [clangd] Use ASTSignals in Heuristics CC Ranking..

Added a comment about the calculation.

Jan 19 2021, 10:06 AM · Restricted Project
usaxena95 committed rG8bf7116d50bf: [clangd] Index local classes, virtual and overriding methods. (authored by usaxena95).
[clangd] Index local classes, virtual and overriding methods.
Jan 19 2021, 7:19 AM
usaxena95 closed D94785: [clangd] Index local classes, virtual and overriding methods..
Jan 19 2021, 7:19 AM · Restricted Project
usaxena95 updated the summary of D94785: [clangd] Index local classes, virtual and overriding methods..
Jan 19 2021, 7:14 AM · Restricted Project
usaxena95 added a comment to D94785: [clangd] Index local classes, virtual and overriding methods..

if you don't mind, could you rerun the benchmark (we have a behavior changes from original version, I guess it won't not change significantly)? and update the data in the description before landing.

Jan 19 2021, 6:39 AM · Restricted Project
usaxena95 updated the summary of D94785: [clangd] Index local classes, virtual and overriding methods..
Jan 19 2021, 6:38 AM · Restricted Project
usaxena95 updated the diff for D94785: [clangd] Index local classes, virtual and overriding methods..

Updated index tests's input files.

Jan 19 2021, 4:30 AM · Restricted Project
usaxena95 updated the diff for D94785: [clangd] Index local classes, virtual and overriding methods..

Index all member functions instead of only polymorphic functions.

Jan 19 2021, 4:26 AM · Restricted Project
usaxena95 added a comment to D94785: [clangd] Index local classes, virtual and overriding methods..

I think we'd better bump the index version, even though this is not a breaking change, but we will collect more data. Not bumping the index version may lead to a half-completed state of the index (e.g. only newly-changed files will get completed index data in background index).

Jan 19 2021, 4:25 AM · Restricted Project

Jan 18 2021

usaxena95 added a reviewer for D94927: [clangd] Use ASTSignals in Heuristics CC Ranking.: adamcz.
Jan 18 2021, 12:04 PM · Restricted Project
usaxena95 requested review of D94927: [clangd] Use ASTSignals in Heuristics CC Ranking..
Jan 18 2021, 12:03 PM · Restricted Project
usaxena95 committed rG275716d6db79: [clangd] Derive new signals in CC from ASTSignals. (authored by usaxena95).
[clangd] Derive new signals in CC from ASTSignals.
Jan 18 2021, 8:39 AM
usaxena95 closed D94473: [clangd] Use AST-based signals in CodeCompletion..
Jan 18 2021, 8:38 AM · Restricted Project
usaxena95 updated the diff for D94785: [clangd] Index local classes, virtual and overriding methods..

Addressed comments. Left a todo to fix the bug in RefContainers later.

Jan 18 2021, 5:46 AM · Restricted Project
usaxena95 updated the diff for D94473: [clangd] Use AST-based signals in CodeCompletion..

Addressed comments.

Jan 18 2021, 2:42 AM · Restricted Project

Jan 17 2021

usaxena95 committed rG9abbc050974f: [clangd] Use !empty() instead of size()>0 (authored by usaxena95).
[clangd] Use !empty() instead of size()>0
Jan 17 2021, 6:29 AM
usaxena95 committed rG0f9908a7c9c5: [clangd] Use empty() instead of size()>0 (authored by usaxena95).
[clangd] Use empty() instead of size()>0
Jan 17 2021, 6:21 AM

Jan 15 2021

usaxena95 added a comment to D94785: [clangd] Index local classes, virtual and overriding methods..

My only question is does this try and index lambdas, under the hood they are declared as a CXXRecordDecl, defined in function scope?

Jan 15 2021, 10:26 AM · Restricted Project
usaxena95 updated the diff for D94785: [clangd] Index local classes, virtual and overriding methods..

Added tests for not indexing lambdas.

Jan 15 2021, 10:23 AM · Restricted Project
usaxena95 committed rGd5047d762f39: [clangd] Update CC Ranking model with better sampling. (authored by usaxena95).
[clangd] Update CC Ranking model with better sampling.
Jan 15 2021, 9:14 AM
usaxena95 closed D94697: [clangd] Update CC Ranking model with better sampling..
Jan 15 2021, 9:14 AM · Restricted Project
usaxena95 updated the diff for D94697: [clangd] Update CC Ranking model with better sampling..

Addressed comments.

Jan 15 2021, 8:52 AM · Restricted Project
usaxena95 updated the summary of D94785: [clangd] Index local classes, virtual and overriding methods..
Jan 15 2021, 8:42 AM · Restricted Project
usaxena95 updated the summary of D94785: [clangd] Index local classes, virtual and overriding methods..
Jan 15 2021, 8:41 AM · Restricted Project
usaxena95 requested review of D94785: [clangd] Index local classes, virtual and overriding methods..
Jan 15 2021, 8:23 AM · Restricted Project

Jan 14 2021

usaxena95 added a reviewer for D94473: [clangd] Use AST-based signals in CodeCompletion.: adamcz.
Jan 14 2021, 11:08 PM · Restricted Project
usaxena95 updated the diff for D94473: [clangd] Use AST-based signals in CodeCompletion..

Rebase.

Jan 14 2021, 11:02 PM · Restricted Project
usaxena95 committed rG8b09cf7956d8: [clangd] Trivial: Documentation fix in ASTSignals. (authored by usaxena95).
[clangd] Trivial: Documentation fix in ASTSignals.
Jan 14 2021, 9:40 AM
usaxena95 committed rG2f395b7092bd: [clangd] Make AST-based signals available to runWithPreamble. (authored by usaxena95).
[clangd] Make AST-based signals available to runWithPreamble.
Jan 14 2021, 9:35 AM
usaxena95 closed D94424: [clangd] Make AST-based signals available to runWithPreamble..
Jan 14 2021, 9:35 AM · Restricted Project