Page MenuHomePhabricator
People usaxena95

usaxena95 (UTKARSH SAXENA)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 28 2018, 2:16 AM (84 w, 11 h)

Recent Activity
View All

Wed, Mar 25

usaxena95 accepted D76741: [clangd] Support multiple cursors in selectionRange..

Thanks. LG.

Wed, Mar 25, 6:27 AM · Restricted Project
usaxena95 added a comment to D76741: [clangd] Support multiple cursors in selectionRange..

Mostly looks good. Few nits. Thanks.

Wed, Mar 25, 3:13 AM · Restricted Project

Mar 5 2020

usaxena95 committed rGe397a0a5c3c0: [clangd] Add instrumentation mode in clangd for metrics collection. (authored by usaxena95).
[clangd] Add instrumentation mode in clangd for metrics collection.
Mar 5 2020, 3:52 AM
usaxena95 closed D75603: [clangd] Add instrumentation mode in clangd for metrics collection..
Mar 5 2020, 3:51 AM · Restricted Project
usaxena95 updated the diff for D75603: [clangd] Add instrumentation mode in clangd for metrics collection..

Passed score as a float as an explicit argument of the callback.

Mar 5 2020, 3:51 AM · Restricted Project
usaxena95 added inline comments to D75603: [clangd] Add instrumentation mode in clangd for metrics collection..
Mar 5 2020, 3:18 AM · Restricted Project
usaxena95 updated the diff for D75603: [clangd] Add instrumentation mode in clangd for metrics collection..

Addressed comments.

  • Populated score in CodeCompletion before invoking the callback.
  • Tested that CodeCompletion is scored
  • Updated comment for callback.
Mar 5 2020, 3:18 AM · Restricted Project

Mar 4 2020

usaxena95 updated the diff for D75603: [clangd] Add instrumentation mode in clangd for metrics collection..

Remove ununsed import.

Mar 4 2020, 10:39 AM · Restricted Project
usaxena95 added inline comments to D75603: [clangd] Add instrumentation mode in clangd for metrics collection..
Mar 4 2020, 10:39 AM · Restricted Project
usaxena95 updated the diff for D75603: [clangd] Add instrumentation mode in clangd for metrics collection..

Changed to invoke callback on all code completion items.

Mar 4 2020, 10:38 AM · Restricted Project
usaxena95 updated the diff for D75603: [clangd] Add instrumentation mode in clangd for metrics collection..

Addressed linter issues.

Mar 4 2020, 6:11 AM · Restricted Project
usaxena95 created D75603: [clangd] Add instrumentation mode in clangd for metrics collection..
Mar 4 2020, 5:39 AM · Restricted Project

Feb 20 2020

usaxena95 committed rGcb54c13c217b: [clang][analyzer] Modify include AllocationState.h in PutenvWithAutoChecker.cpp (authored by usaxena95).
[clang][analyzer] Modify include AllocationState.h in PutenvWithAutoChecker.cpp
Feb 20 2020, 8:30 AM
usaxena95 closed D74906: [clang][analyzer] Modify include AllocationState.h in PutenvWithAutoChecker.cpp.
Feb 20 2020, 8:30 AM · Restricted Project
usaxena95 created D74906: [clang][analyzer] Modify include AllocationState.h in PutenvWithAutoChecker.cpp.
Feb 20 2020, 8:21 AM · Restricted Project

Feb 11 2020

usaxena95 accepted D74305: [clangd] Expose completion range in code completion results (C++ API).

Thanks. LG.

Feb 11 2020, 4:58 AM · Restricted Project

Jan 16 2020

usaxena95 accepted D72777: [clangd] Dont display `<unknown>` kinds in hover board.
Jan 16 2020, 2:35 AM · Restricted Project

Jan 13 2020

usaxena95 committed rG734aa1d133f2: [clangd] Publish xref for macros from Index and AST. (authored by usaxena95).
[clangd] Publish xref for macros from Index and AST.
Jan 13 2020, 2:12 AM
usaxena95 closed D72395: [clangd] Publish xref for macros from Index and AST..
Jan 13 2020, 2:12 AM · Restricted Project
usaxena95 added inline comments to D72395: [clangd] Publish xref for macros from Index and AST..
Jan 13 2020, 1:57 AM · Restricted Project
usaxena95 updated the diff for D72395: [clangd] Publish xref for macros from Index and AST..

Removed repeated check from the test.

Jan 13 2020, 1:57 AM · Restricted Project

Jan 8 2020

usaxena95 added inline comments to D72395: [clangd] Publish xref for macros from Index and AST..
Jan 8 2020, 7:59 AM · Restricted Project
usaxena95 updated the diff for D72395: [clangd] Publish xref for macros from Index and AST..

Addressed comments.

Jan 8 2020, 7:50 AM · Restricted Project
usaxena95 created D72395: [clangd] Publish xref for macros from Index and AST..
Jan 8 2020, 5:23 AM · Restricted Project

Jan 7 2020

usaxena95 committed rG583ba07884ed: [clangd] Add xref for macros to FileIndex. (authored by usaxena95).
[clangd] Add xref for macros to FileIndex.
Jan 7 2020, 11:38 PM
usaxena95 closed D71406: [clangd] Add xref for macros to FileIndex..
Jan 7 2020, 11:38 PM · Restricted Project
usaxena95 updated the summary of D71406: [clangd] Add xref for macros to FileIndex..
Jan 7 2020, 11:29 PM · Restricted Project
usaxena95 updated the diff for D71406: [clangd] Add xref for macros to FileIndex..

Added tests.

Jan 7 2020, 9:46 AM · Restricted Project
usaxena95 updated the diff for D71406: [clangd] Add xref for macros to FileIndex..

Removed extra tests.

Jan 7 2020, 6:00 AM · Restricted Project
usaxena95 added inline comments to D71406: [clangd] Add xref for macros to FileIndex..
Jan 7 2020, 2:55 AM · Restricted Project
usaxena95 updated the diff for D71406: [clangd] Add xref for macros to FileIndex..

Addressed comments.

Jan 7 2020, 2:55 AM · Restricted Project

Jan 3 2020

usaxena95 added inline comments to D71406: [clangd] Add xref for macros to FileIndex..
Jan 3 2020, 5:57 AM · Restricted Project
usaxena95 updated the diff for D71406: [clangd] Add xref for macros to FileIndex..

Added another version of handleMacroOccurence to handle MacroReferences from main file.

Jan 3 2020, 5:57 AM · Restricted Project

Dec 12 2019

usaxena95 created D71406: [clangd] Add xref for macros to FileIndex..
Dec 12 2019, 3:20 AM · Restricted Project

Dec 4 2019

usaxena95 closed D70008: [clangd] Store xref for Macros in ParsedAST..
Dec 4 2019, 7:38 PM · Restricted Project
usaxena95 committed rG9347655a2754: [clangd] Add xref for macro to static index. (authored by usaxena95).
[clangd] Add xref for macro to static index.
Dec 4 2019, 7:29 PM
usaxena95 closed D70489: [clangd] Add xref for macro to static index..
Dec 4 2019, 7:29 PM · Restricted Project
usaxena95 updated the summary of D70489: [clangd] Add xref for macro to static index..
Dec 4 2019, 7:29 PM · Restricted Project
usaxena95 updated the summary of D70489: [clangd] Add xref for macro to static index..
Dec 4 2019, 7:19 PM · Restricted Project
usaxena95 added a comment to D70489: [clangd] Add xref for macro to static index..

Updated benchmarks:
Before this patch

Loaded Dex from static-index.idx with estimated memory usage 354410880 bytes
  - number of symbols: 462463
  - number of refs: 6361763
  - numnber of relations: 20322

After this patch
Num refs increases by 5.7%
Disk increase: 2.5%

Loaded Dex from with-macro-xref.idx with estimated memory usage 363390426 bytes
  - number of symbols: 462482
  - number of refs: 6727051
  - numnber of relations: 20325
Dec 4 2019, 7:19 PM · Restricted Project
usaxena95 updated the diff for D70489: [clangd] Add xref for macro to static index..

Addressed comments.

Dec 4 2019, 6:51 PM · Restricted Project
usaxena95 updated the diff for D70489: [clangd] Add xref for macro to static index..

Removed unintended space.

Dec 4 2019, 6:53 AM · Restricted Project
usaxena95 added inline comments to D70489: [clangd] Add xref for macro to static index..
Dec 4 2019, 6:53 AM · Restricted Project
usaxena95 updated the diff for D70489: [clangd] Add xref for macro to static index..

Addressed comments.

Dec 4 2019, 6:53 AM · Restricted Project
usaxena95 updated the diff for D70489: [clangd] Add xref for macro to static index..

Addressed comments.

Dec 4 2019, 3:48 AM · Restricted Project
usaxena95 updated the diff for D70489: [clangd] Add xref for macro to static index..

Explicitly turn off CollectMacro in test.

Dec 4 2019, 3:48 AM · Restricted Project

Dec 3 2019

usaxena95 updated the summary of D70489: [clangd] Add xref for macro to static index..
Dec 3 2019, 2:39 AM · Restricted Project
usaxena95 added a comment to D70489: [clangd] Add xref for macro to static index..

Before this patch
CollectMacro is disabled by default

Loaded Dex from static-index.idx with estimated memory usage 354410880 bytes
  - number of symbols: 462463
  - number of refs: 6361763
  - numnber of relations: 20322

Before this patch
CollectMacros=true enabled in IndexerMain.cpp
Num symbols increases by 3%
Disk increase: 1.2%

Loaded Dex from no-macro-xref.idx with estimated memory usage 358596403 bytes
  - number of symbols: 476056
  - number of refs: 6361764
  - numnber of relations: 20322
Dec 3 2019, 2:29 AM · Restricted Project
usaxena95 updated the diff for D70489: [clangd] Add xref for macro to static index..

Addressed comments.
Will update the increase in size of index shortly.

Dec 3 2019, 12:15 AM · Restricted Project
usaxena95 added inline comments to D70489: [clangd] Add xref for macro to static index..
Dec 3 2019, 12:15 AM · Restricted Project

Dec 2 2019

usaxena95 updated the diff for D70489: [clangd] Add xref for macro to static index..

Added correct documentation.

Dec 2 2019, 3:09 AM · Restricted Project
usaxena95 added inline comments to D70489: [clangd] Add xref for macro to static index..
Dec 2 2019, 2:50 AM · Restricted Project
usaxena95 added inline comments to D70489: [clangd] Add xref for macro to static index..
Dec 2 2019, 1:56 AM · Restricted Project
usaxena95 updated the diff for D70489: [clangd] Add xref for macro to static index..

Addressed comments.

Dec 2 2019, 1:56 AM · Restricted Project

Nov 20 2019

usaxena95 created D70489: [clangd] Add xref for macro to static index..
Nov 20 2019, 6:23 AM · Restricted Project

Nov 18 2019

usaxena95 committed rG2054ed052f15: [clangd] Store xref for Macros in ParsedAST. (authored by usaxena95).
[clangd] Store xref for Macros in ParsedAST.
Nov 18 2019, 7:51 AM
usaxena95 updated the diff for D70008: [clangd] Store xref for Macros in ParsedAST..

Addressed comments.

Nov 18 2019, 6:58 AM · Restricted Project
usaxena95 added inline comments to D70008: [clangd] Store xref for Macros in ParsedAST..
Nov 18 2019, 6:58 AM · Restricted Project

Nov 15 2019

usaxena95 updated the diff for D70008: [clangd] Store xref for Macros in ParsedAST..

Minor change: Resued variable.

Nov 15 2019, 6:49 AM · Restricted Project
usaxena95 added inline comments to D70008: [clangd] Store xref for Macros in ParsedAST..
Nov 15 2019, 6:22 AM · Restricted Project
usaxena95 updated the diff for D70008: [clangd] Store xref for Macros in ParsedAST..

Modified tests for better error messages.

Nov 15 2019, 6:22 AM · Restricted Project
usaxena95 updated the diff for D70008: [clangd] Store xref for Macros in ParsedAST..

Uploading latest patch

Nov 15 2019, 3:09 AM · Restricted Project

Nov 14 2019

usaxena95 added inline comments to D70008: [clangd] Store xref for Macros in ParsedAST..
Nov 14 2019, 7:12 AM · Restricted Project

Nov 12 2019

usaxena95 added inline comments to D70008: [clangd] Store xref for Macros in ParsedAST..
Nov 12 2019, 4:48 AM · Restricted Project
usaxena95 updated the diff for D70008: [clangd] Store xref for Macros in ParsedAST..

Fixed typos.

Nov 12 2019, 4:48 AM · Restricted Project
usaxena95 updated the diff for D70008: [clangd] Store xref for Macros in ParsedAST..

Added tests for CollectMacros.h
Addressed comments.

Nov 12 2019, 4:46 AM · Restricted Project

Nov 11 2019

usaxena95 added inline comments to D70008: [clangd] Store xref for Macros in ParsedAST..
Nov 11 2019, 5:47 AM · Restricted Project
usaxena95 updated the diff for D70008: [clangd] Store xref for Macros in ParsedAST..

Rebase

Nov 11 2019, 5:47 AM · Restricted Project

Nov 8 2019

usaxena95 added a child revision for D69937: [clangd] Use name of Macro to compute its SymbolID.: D70008: [clangd] Store xref for Macros in ParsedAST..
Nov 8 2019, 7:31 AM · Restricted Project
usaxena95 added a parent revision for D70008: [clangd] Store xref for Macros in ParsedAST.: D69937: [clangd] Use name of Macro to compute its SymbolID..
Nov 8 2019, 7:31 AM · Restricted Project
usaxena95 updated the diff for D70008: [clangd] Store xref for Macros in ParsedAST..

Removing changes from different patch.

Nov 8 2019, 7:31 AM · Restricted Project
usaxena95 added a comment to D70008: [clangd] Store xref for Macros in ParsedAST..

Please ignore the changes from patch https://reviews.llvm.org/D69937
Will fix this.

Nov 8 2019, 7:03 AM · Restricted Project
usaxena95 created D70008: [clangd] Store xref for Macros in ParsedAST..
Nov 8 2019, 7:03 AM · Restricted Project
usaxena95 updated the diff for D69937: [clangd] Use name of Macro to compute its SymbolID..

Hopefully reverting unintended changes.

Nov 8 2019, 6:06 AM · Restricted Project
usaxena95 updated the diff for D69937: [clangd] Use name of Macro to compute its SymbolID..
  • [clangd] Store xref for Macros in ParsedAST.
Nov 8 2019, 6:06 AM · Restricted Project

Nov 7 2019

usaxena95 added a comment to D69937: [clangd] Use name of Macro to compute its SymbolID..

We actually use both the name and the source location of the macro to calculate its ID.
I see that the subject of the patch might suggest otherwise.
This is a trivial change which just changes the params of the function so that users don't have to carry the IdentifierInfo when we just want the name out of it.

Nov 7 2019, 6:46 AM · Restricted Project
usaxena95 updated the diff for D69937: [clangd] Use name of Macro to compute its SymbolID..

Addressed comments.

Nov 7 2019, 5:05 AM · Restricted Project
usaxena95 created D69937: [clangd] Use name of Macro to compute its SymbolID..
Nov 7 2019, 3:14 AM · Restricted Project

Oct 31 2019

usaxena95 added inline comments to D69162: [clangd] Remove using-namespace present inside a namespace..
Oct 31 2019, 4:49 AM · Restricted Project
usaxena95 updated the diff for D69162: [clangd] Remove using-namespace present inside a namespace..

Addressed comments.

Oct 31 2019, 4:49 AM · Restricted Project

Oct 29 2019

usaxena95 added inline comments to D69162: [clangd] Remove using-namespace present inside a namespace..
Oct 29 2019, 1:51 PM · Restricted Project
usaxena95 updated the diff for D69162: [clangd] Remove using-namespace present inside a namespace..

Addressed comments.

Oct 29 2019, 1:49 PM · Restricted Project

Oct 18 2019

usaxena95 updated the diff for D69162: [clangd] Remove using-namespace present inside a namespace..

Added additional tests.

Oct 18 2019, 4:13 AM · Restricted Project
usaxena95 updated the summary of D69162: [clangd] Remove using-namespace present inside a namespace..
Oct 18 2019, 3:50 AM · Restricted Project
usaxena95 created D69162: [clangd] Remove using-namespace present inside a namespace..
Oct 18 2019, 3:42 AM · Restricted Project

Oct 16 2019

usaxena95 committed rGb62b45412168: [clangd] Add RemoveUsingNamespace tweak. (authored by usaxena95).
[clangd] Add RemoveUsingNamespace tweak.
Oct 16 2019, 2:56 AM
usaxena95 closed D68562: [clangd] Add RemoveUsingNamespace tweak..
Oct 16 2019, 2:56 AM · Restricted Project
usaxena95 committed rL374982: [clangd] Add RemoveUsingNamespace tweak..
[clangd] Add RemoveUsingNamespace tweak.
Oct 16 2019, 2:55 AM
usaxena95 added inline comments to D68562: [clangd] Add RemoveUsingNamespace tweak..
Oct 16 2019, 2:54 AM · Restricted Project
usaxena95 updated the diff for D68562: [clangd] Add RemoveUsingNamespace tweak..

Addressed comments.

Oct 16 2019, 2:44 AM · Restricted Project

Oct 9 2019

usaxena95 updated the diff for D68562: [clangd] Add RemoveUsingNamespace tweak..

Added documentation.

Oct 9 2019, 8:53 AM · Restricted Project
usaxena95 updated the diff for D68562: [clangd] Add RemoveUsingNamespace tweak..

Make action unavailable if the namespace contains a using namespace decl.

Oct 9 2019, 6:23 AM · Restricted Project
usaxena95 added inline comments to D68562: [clangd] Add RemoveUsingNamespace tweak..
Oct 9 2019, 6:23 AM · Restricted Project

Oct 8 2019

usaxena95 added inline comments to D68562: [clangd] Add RemoveUsingNamespace tweak..
Oct 8 2019, 10:28 AM · Restricted Project
usaxena95 updated the diff for D68562: [clangd] Add RemoveUsingNamespace tweak..

Addressed comments.

Oct 8 2019, 10:28 AM · Restricted Project

Oct 7 2019

usaxena95 committed rGedf5027689c5: [clang] Add test for FindNextToken in Lexer. (authored by usaxena95).
[clang] Add test for FindNextToken in Lexer.
Oct 7 2019, 10:14 PM
usaxena95 committed rL373910: [clang] Add test for FindNextToken in Lexer..
[clang] Add test for FindNextToken in Lexer.
Oct 7 2019, 10:14 PM
usaxena95 closed D68565: [clang] Add test for FindNextToken in Lexer..
Oct 7 2019, 10:14 PM · Restricted Project
usaxena95 updated the diff for D68562: [clangd] Add RemoveUsingNamespace tweak..

Make the tweak trigger only for TopLevelDecl.

Oct 7 2019, 7:17 AM · Restricted Project
usaxena95 updated the diff for D68565: [clang] Add test for FindNextToken in Lexer..

Addressed comments and fixed build failure.

Oct 7 2019, 5:29 AM · Restricted Project