Page MenuHomePhabricator

usaxena95 (UTKARSH SAXENA)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 28 2018, 2:16 AM (63 w, 6 d)

Recent Activity

Today

usaxena95 committed rG2054ed052f15: [clangd] Store xref for Macros in ParsedAST. (authored by usaxena95).
[clangd] Store xref for Macros in ParsedAST.
Mon, Nov 18, 7:51 AM
usaxena95 updated the diff for D70008: [clangd] Store xref for Macros in ParsedAST..

Addressed comments.

Mon, Nov 18, 6:58 AM · Restricted Project
usaxena95 added inline comments to D70008: [clangd] Store xref for Macros in ParsedAST..
Mon, Nov 18, 6:58 AM · Restricted Project

Fri, Nov 15

usaxena95 updated the diff for D70008: [clangd] Store xref for Macros in ParsedAST..

Minor change: Resued variable.

Fri, Nov 15, 6:49 AM · Restricted Project
usaxena95 added inline comments to D70008: [clangd] Store xref for Macros in ParsedAST..
Fri, Nov 15, 6:22 AM · Restricted Project
usaxena95 updated the diff for D70008: [clangd] Store xref for Macros in ParsedAST..

Modified tests for better error messages.

Fri, Nov 15, 6:22 AM · Restricted Project
usaxena95 updated the diff for D70008: [clangd] Store xref for Macros in ParsedAST..

Uploading latest patch

Fri, Nov 15, 3:09 AM · Restricted Project

Thu, Nov 14

usaxena95 added inline comments to D70008: [clangd] Store xref for Macros in ParsedAST..
Thu, Nov 14, 7:12 AM · Restricted Project

Tue, Nov 12

usaxena95 added inline comments to D70008: [clangd] Store xref for Macros in ParsedAST..
Tue, Nov 12, 4:48 AM · Restricted Project
usaxena95 updated the diff for D70008: [clangd] Store xref for Macros in ParsedAST..

Fixed typos.

Tue, Nov 12, 4:48 AM · Restricted Project
usaxena95 updated the diff for D70008: [clangd] Store xref for Macros in ParsedAST..

Added tests for CollectMacros.h
Addressed comments.

Tue, Nov 12, 4:46 AM · Restricted Project

Mon, Nov 11

usaxena95 added inline comments to D70008: [clangd] Store xref for Macros in ParsedAST..
Mon, Nov 11, 5:47 AM · Restricted Project
usaxena95 updated the diff for D70008: [clangd] Store xref for Macros in ParsedAST..

Rebase

Mon, Nov 11, 5:47 AM · Restricted Project

Fri, Nov 8

usaxena95 added a child revision for D69937: [clangd] Use name of Macro to compute its SymbolID.: D70008: [clangd] Store xref for Macros in ParsedAST..
Fri, Nov 8, 7:31 AM · Restricted Project
usaxena95 added a parent revision for D70008: [clangd] Store xref for Macros in ParsedAST.: D69937: [clangd] Use name of Macro to compute its SymbolID..
Fri, Nov 8, 7:31 AM · Restricted Project
usaxena95 updated the diff for D70008: [clangd] Store xref for Macros in ParsedAST..

Removing changes from different patch.

Fri, Nov 8, 7:31 AM · Restricted Project
usaxena95 added a comment to D70008: [clangd] Store xref for Macros in ParsedAST..

Please ignore the changes from patch https://reviews.llvm.org/D69937
Will fix this.

Fri, Nov 8, 7:03 AM · Restricted Project
usaxena95 created D70008: [clangd] Store xref for Macros in ParsedAST..
Fri, Nov 8, 7:03 AM · Restricted Project
usaxena95 updated the diff for D69937: [clangd] Use name of Macro to compute its SymbolID..

Hopefully reverting unintended changes.

Fri, Nov 8, 6:06 AM · Restricted Project
usaxena95 updated the diff for D69937: [clangd] Use name of Macro to compute its SymbolID..
  • [clangd] Store xref for Macros in ParsedAST.
Fri, Nov 8, 6:06 AM · Restricted Project

Thu, Nov 7

usaxena95 added a comment to D69937: [clangd] Use name of Macro to compute its SymbolID..

We actually use both the name and the source location of the macro to calculate its ID.
I see that the subject of the patch might suggest otherwise.
This is a trivial change which just changes the params of the function so that users don't have to carry the IdentifierInfo when we just want the name out of it.

Thu, Nov 7, 6:46 AM · Restricted Project
usaxena95 updated the diff for D69937: [clangd] Use name of Macro to compute its SymbolID..

Addressed comments.

Thu, Nov 7, 5:05 AM · Restricted Project
usaxena95 created D69937: [clangd] Use name of Macro to compute its SymbolID..
Thu, Nov 7, 3:14 AM · Restricted Project

Thu, Oct 31

usaxena95 added inline comments to D69162: [clangd] Remove using-namespace present inside a namespace..
Thu, Oct 31, 4:49 AM · Restricted Project
usaxena95 updated the diff for D69162: [clangd] Remove using-namespace present inside a namespace..

Addressed comments.

Thu, Oct 31, 4:49 AM · Restricted Project

Tue, Oct 29

usaxena95 added inline comments to D69162: [clangd] Remove using-namespace present inside a namespace..
Tue, Oct 29, 1:51 PM · Restricted Project
usaxena95 updated the diff for D69162: [clangd] Remove using-namespace present inside a namespace..

Addressed comments.

Tue, Oct 29, 1:49 PM · Restricted Project

Oct 18 2019

usaxena95 updated the diff for D69162: [clangd] Remove using-namespace present inside a namespace..

Added additional tests.

Oct 18 2019, 4:13 AM · Restricted Project
usaxena95 updated the summary of D69162: [clangd] Remove using-namespace present inside a namespace..
Oct 18 2019, 3:50 AM · Restricted Project
usaxena95 created D69162: [clangd] Remove using-namespace present inside a namespace..
Oct 18 2019, 3:42 AM · Restricted Project

Oct 16 2019

usaxena95 committed rGb62b45412168: [clangd] Add RemoveUsingNamespace tweak. (authored by usaxena95).
[clangd] Add RemoveUsingNamespace tweak.
Oct 16 2019, 2:56 AM
usaxena95 closed D68562: [clangd] Add RemoveUsingNamespace tweak..
Oct 16 2019, 2:56 AM · Restricted Project
usaxena95 committed rL374982: [clangd] Add RemoveUsingNamespace tweak..
[clangd] Add RemoveUsingNamespace tweak.
Oct 16 2019, 2:55 AM
usaxena95 added inline comments to D68562: [clangd] Add RemoveUsingNamespace tweak..
Oct 16 2019, 2:54 AM · Restricted Project
usaxena95 updated the diff for D68562: [clangd] Add RemoveUsingNamespace tweak..

Addressed comments.

Oct 16 2019, 2:44 AM · Restricted Project

Oct 9 2019

usaxena95 updated the diff for D68562: [clangd] Add RemoveUsingNamespace tweak..

Added documentation.

Oct 9 2019, 8:53 AM · Restricted Project
usaxena95 updated the diff for D68562: [clangd] Add RemoveUsingNamespace tweak..

Make action unavailable if the namespace contains a using namespace decl.

Oct 9 2019, 6:23 AM · Restricted Project
usaxena95 added inline comments to D68562: [clangd] Add RemoveUsingNamespace tweak..
Oct 9 2019, 6:23 AM · Restricted Project

Oct 8 2019

usaxena95 added inline comments to D68562: [clangd] Add RemoveUsingNamespace tweak..
Oct 8 2019, 10:28 AM · Restricted Project
usaxena95 updated the diff for D68562: [clangd] Add RemoveUsingNamespace tweak..

Addressed comments.

Oct 8 2019, 10:28 AM · Restricted Project

Oct 7 2019

usaxena95 committed rGedf5027689c5: [clang] Add test for FindNextToken in Lexer. (authored by usaxena95).
[clang] Add test for FindNextToken in Lexer.
Oct 7 2019, 10:14 PM
usaxena95 committed rL373910: [clang] Add test for FindNextToken in Lexer..
[clang] Add test for FindNextToken in Lexer.
Oct 7 2019, 10:14 PM
usaxena95 closed D68565: [clang] Add test for FindNextToken in Lexer..
Oct 7 2019, 10:14 PM · Restricted Project
usaxena95 updated the diff for D68562: [clangd] Add RemoveUsingNamespace tweak..

Make the tweak trigger only for TopLevelDecl.

Oct 7 2019, 7:17 AM · Restricted Project
usaxena95 updated the diff for D68565: [clang] Add test for FindNextToken in Lexer..

Addressed comments and fixed build failure.

Oct 7 2019, 5:29 AM · Restricted Project
usaxena95 updated the summary of D68565: [clang] Add test for FindNextToken in Lexer..
Oct 7 2019, 5:00 AM · Restricted Project
usaxena95 updated the diff for D68565: [clang] Add test for FindNextToken in Lexer..

Revert unintended formatting.

Oct 7 2019, 4:36 AM · Restricted Project
usaxena95 added a reviewer for D68562: [clangd] Add RemoveUsingNamespace tweak.: ilya-biryukov.
Oct 7 2019, 3:36 AM · Restricted Project
usaxena95 created D68565: [clang] Add test for FindNextToken in Lexer..
Oct 7 2019, 3:35 AM · Restricted Project
usaxena95 created D68562: [clangd] Add RemoveUsingNamespace tweak..
Oct 7 2019, 2:50 AM · Restricted Project

Sep 24 2019

usaxena95 committed rG55925da4c98b: [clangd] Add semantic selection to ClangdLSPServer. (authored by usaxena95).
[clangd] Add semantic selection to ClangdLSPServer.
Sep 24 2019, 6:39 AM
usaxena95 committed rL372753: [clangd] Add semantic selection to ClangdLSPServer..
[clangd] Add semantic selection to ClangdLSPServer.
Sep 24 2019, 6:38 AM
usaxena95 closed D67720: [clangd] Add semantic selection to ClangdLSPServer..
Sep 24 2019, 6:38 AM · Restricted Project, Restricted Project
usaxena95 updated the diff for D67720: [clangd] Add semantic selection to ClangdLSPServer..

Removed ununsed header.

Sep 24 2019, 6:36 AM · Restricted Project, Restricted Project
usaxena95 added inline comments to D67720: [clangd] Add semantic selection to ClangdLSPServer..
Sep 24 2019, 5:49 AM · Restricted Project, Restricted Project
usaxena95 updated the diff for D67720: [clangd] Add semantic selection to ClangdLSPServer..

Addressed comments.

Sep 24 2019, 5:49 AM · Restricted Project, Restricted Project
usaxena95 added a comment to D67720: [clangd] Add semantic selection to ClangdLSPServer..

The SelectionRangeClientCapabilities determines what should the LSP server send the client, if it is true, clangd should send SelectionRangeRegistrationOptions.
But looking at the current specification, it doesn't seem to add too much value. I think we can just simplify return a bool for now (as you did in this patch).

Sep 24 2019, 4:43 AM · Restricted Project, Restricted Project
usaxena95 updated the diff for D67720: [clangd] Add semantic selection to ClangdLSPServer..

Addressed comments.

Sep 24 2019, 4:38 AM · Restricted Project, Restricted Project
usaxena95 added a comment to D67720: [clangd] Add semantic selection to ClangdLSPServer..

I am not sure adding client capability is useful here. I have not used the client capability for selectionRange anywhere and I think we can remove it.
WDYT ?

Sep 24 2019, 3:37 AM · Restricted Project, Restricted Project
usaxena95 updated the diff for D67720: [clangd] Add semantic selection to ClangdLSPServer..

Addressed comments:
Added client/server capabilities.
Made lit test smaller.

Sep 24 2019, 3:37 AM · Restricted Project, Restricted Project

Sep 18 2019

usaxena95 added inline comments to D67720: [clangd] Add semantic selection to ClangdLSPServer..
Sep 18 2019, 11:16 AM · Restricted Project, Restricted Project
usaxena95 updated the diff for D67720: [clangd] Add semantic selection to ClangdLSPServer..

Addressed comments.

Sep 18 2019, 11:06 AM · Restricted Project, Restricted Project
usaxena95 updated the diff for D67720: [clangd] Add semantic selection to ClangdLSPServer..

Fixed error message.

Sep 18 2019, 10:49 AM · Restricted Project, Restricted Project
usaxena95 created D67720: [clangd] Add semantic selection to ClangdLSPServer..
Sep 18 2019, 10:18 AM · Restricted Project, Restricted Project

Sep 17 2019

usaxena95 committed rG79d19bdf8196: Add SemanticRanges to Clangd server. (authored by usaxena95).
Add SemanticRanges to Clangd server.
Sep 17 2019, 3:27 AM
usaxena95 committed rL372102: Add SemanticRanges to Clangd server..
Add SemanticRanges to Clangd server.
Sep 17 2019, 3:27 AM
usaxena95 closed D67650: [clangd] Add SemanticRanges to Clangd server..
Sep 17 2019, 3:27 AM · Restricted Project, Restricted Project
usaxena95 updated the diff for D67650: [clangd] Add SemanticRanges to Clangd server..

Addressed comments.

Sep 17 2019, 3:26 AM · Restricted Project, Restricted Project
usaxena95 updated the summary of D67650: [clangd] Add SemanticRanges to Clangd server..
Sep 17 2019, 2:58 AM · Restricted Project, Restricted Project
usaxena95 created D67650: [clangd] Add SemanticRanges to Clangd server..
Sep 17 2019, 2:53 AM · Restricted Project, Restricted Project

Sep 16 2019

usaxena95 committed rG73c09eb7344e: Implement semantic selections. (authored by usaxena95).
Implement semantic selections.
Sep 16 2019, 4:29 AM
usaxena95 committed rL371976: Implement semantic selections..
Implement semantic selections.
Sep 16 2019, 4:28 AM
usaxena95 closed D67358: [clangd] Implement semantic selections..
Sep 16 2019, 4:28 AM · Restricted Project, Restricted Project
usaxena95 updated the diff for D67358: [clangd] Implement semantic selections..

Resolved comments.

Sep 16 2019, 3:21 AM · Restricted Project, Restricted Project

Sep 13 2019

usaxena95 updated the diff for D67358: [clangd] Implement semantic selections..

Remove extraneous namespace comment.

Sep 13 2019, 4:06 AM · Restricted Project, Restricted Project
usaxena95 added inline comments to D67358: [clangd] Implement semantic selections..
Sep 13 2019, 4:04 AM · Restricted Project, Restricted Project
usaxena95 updated the diff for D67358: [clangd] Implement semantic selections..

Minor changes.

Sep 13 2019, 4:04 AM · Restricted Project, Restricted Project
usaxena95 updated the diff for D67358: [clangd] Implement semantic selections..

Addressed comments.

Sep 13 2019, 3:59 AM · Restricted Project, Restricted Project

Sep 9 2019

usaxena95 added a reviewer for D67358: [clangd] Implement semantic selections.: ilya-biryukov.
Sep 9 2019, 10:20 AM · Restricted Project, Restricted Project
usaxena95 updated the diff for D67358: [clangd] Implement semantic selections..

Create range only if it represents a valid file range.

Sep 9 2019, 10:15 AM · Restricted Project, Restricted Project
usaxena95 updated the diff for D67358: [clangd] Implement semantic selections..

Removed logs for debugging.

Sep 9 2019, 9:54 AM · Restricted Project, Restricted Project
usaxena95 created D67358: [clangd] Implement semantic selections..
Sep 9 2019, 8:50 AM · Restricted Project, Restricted Project

Aug 7 2019

usaxena95 updated the diff for D65866: Code completion should not ignore default parameters in functions..

Formatted new test.

Aug 7 2019, 9:30 AM · Restricted Project, Restricted Project
usaxena95 updated the diff for D65866: Code completion should not ignore default parameters in functions..

Added tests in CodeCompletionStringsTests.cpp
Resolved comments.

Aug 7 2019, 9:24 AM · Restricted Project, Restricted Project
usaxena95 updated the diff for D65866: Code completion should not ignore default parameters in functions..

Removed unused include of logger.

Aug 7 2019, 7:01 AM · Restricted Project, Restricted Project
usaxena95 created D65866: Code completion should not ignore default parameters in functions..
Aug 7 2019, 6:32 AM · Restricted Project, Restricted Project

Feb 18 2019

usaxena95 added a comment to D58278: Prepare ground for re-lexing modular headers..

+cc myself

Feb 18 2019, 8:08 AM · Restricted Project

Sep 28 2018

usaxena95 added inline comments to D52620: Added Support for StatOnly Files in VFS..
Sep 28 2018, 5:49 AM
usaxena95 added a comment to D52620: Added Support for StatOnly Files in VFS..

it sounds like this is for record-replay.

Yes this is for record-replay purpose.

What are these files in practice?

During loading a modules the files that were required to make the module are stat()ed and their sizes are used to verify that the module is still valid. There are occurrences of more stat() only files (apart from the use in modules) which I am not aware of.

In the replayed compilation, we assume the accessed files are the same, is it safe to assume we never read files we previously stat()ed?

I would call it a requirement instead of an assumption. The replay must be exactly the same (even the file stats and reads). If Clang reads the file in replay which was only stat()ed during compilation, it indicates non-determinism or something wrong (in clang or FS).
We currently deal with such files by adding empty buffers for them based on this assumption/requirement only.

it seems like this could also be achieved with an overlayFS adding a simple specialized FS that only provides the stat-only files. If this is a relatively niche feature, cramming it into InMemoryFileSystem may not be the best option. Any thoughts on the tradeoff here?

We can reuse the InMemoryFS to make another FS which just serves stat-only files. A tradeoff I can think of is: we might need to store a random buffer of required size to make final status of the file correct.

Sep 28 2018, 5:40 AM

Sep 27 2018

usaxena95 created D52620: Added Support for StatOnly Files in VFS..
Sep 27 2018, 9:52 AM

Sep 4 2018

usaxena95 added a comment to D51359: Adding HardLink Support to VirtualFileSystem..

I don't have commit access. Can you please submit this ?

Sep 4 2018, 4:43 AM
usaxena95 updated the diff for D51359: Adding HardLink Support to VirtualFileSystem..
  • fixed the style issues
Sep 4 2018, 4:42 AM

Sep 3 2018

usaxena95 updated the diff for D51359: Adding HardLink Support to VirtualFileSystem..
  • applied changes
Sep 3 2018, 10:59 AM
usaxena95 added a comment to D51359: Adding HardLink Support to VirtualFileSystem..

Applied the changes suggested.

Sep 3 2018, 10:59 AM
usaxena95 updated the diff for D51359: Adding HardLink Support to VirtualFileSystem..
  • Moved helper function into anonymous namespace
Sep 3 2018, 8:00 AM
usaxena95 updated the diff for D51359: Adding HardLink Support to VirtualFileSystem..
  • applied suggested changes
Sep 3 2018, 7:12 AM
usaxena95 added a comment to D51359: Adding HardLink Support to VirtualFileSystem..

Applied suggested changes.

Sep 3 2018, 7:11 AM

Aug 31 2018

usaxena95 added a comment to D51359: Adding HardLink Support to VirtualFileSystem..

Made the suggested changes.

Aug 31 2018, 9:47 AM
usaxena95 updated the diff for D51359: Adding HardLink Support to VirtualFileSystem..
  • Made suggested changes.
Aug 31 2018, 9:26 AM

Aug 30 2018

usaxena95 updated the diff for D51359: Adding HardLink Support to VirtualFileSystem..
  • Moved Stat to the subclasses of InMemoryNode
Aug 30 2018, 7:56 AM