User Details
- User Since
- Aug 28 2018, 2:16 AM (201 w, 2 d)
Wed, Jun 15
Thanks!
May 19 2022
Addressed comments.
May 18 2022
May 16 2022
Addressed comments and added performance measurements.
Format.
Address comments.
Jan 13 2022
Thanks. LGTM.
Jan 4 2022
Jan 3 2022
Nov 10 2021
Oct 26 2021
No worries. Thanks for taking a look :)
Oct 5 2021
Addressed comments.
Addressed comments.
Oct 3 2021
May 17 2021
Did you need any other change ? Didn't realise the revision was not "accepted".
added comment.
May 14 2021
May 4 2021
May 3 2021
Apr 28 2021
Addressed comments.
Apr 27 2021
Apr 7 2021
Clangd was seen to be crashing on Objective C/C++ files.
It could not be reproduced but inspection of coredump showed that the expandedTokens returned arrayref with begin > end (negative length).
Apr 6 2021
Mar 25 2021
Addressed comments.
Mar 24 2021
Remove unintended changes.
Made the optimization an 'opt-in'.
Created TokenBuffer::indexExpandedToken() for creating the index.
Mar 22 2021
Mar 18 2021
LG. Thanks.
Sorry. This completely missed my inbox.
Mar 11 2021
LGTM. Thanks.
Mar 2 2021
Mar 1 2021
LG. Thanks for noticing and fixing it!
Feb 11 2021
Addressed comments.
Feb 9 2021
Thanks. LG.
Couple of comments about adding tests to clangd as well.
Feb 3 2021
Addressed comments.
Feb 2 2021
Addressed comments.
Feb 1 2021
Remove unintended changes.
Print value of new OverriddenBy flag.
Rebase + Add OverriddenBy flag for such references.
Move Index query to more logical place.
Jan 19 2021
Added a comment about the calculation.