Page MenuHomePhabricator
Differential D68644

[RISCV] Prevent unsafe shrink wrapping with save/restore enabled
AbandonedPublic
Actions

Authored by lewis-revill on Oct 8 2019, 7:36 AM.

Details

Reviewers
asb
luismarques
apazos

Diff Detail

Event Timeline

lewis-revill created this revision.Oct 8 2019, 7:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 8 2019, 7:37 AM
Herald added subscribers: llvm-commits, pzheng, simoncook and 23 others. · View Herald Transcript
lewis-revill added parent revisions: D62190: [RISCV] Allow shrink wrapping for RISC-V, D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.Oct 8 2019, 7:37 AM
lewis-revill mentioned this in D62190: [RISCV] Allow shrink wrapping for RISC-V.Oct 17 2019, 12:15 AM
apazos added a comment.Oct 17 2019, 8:34 AM

Thanks Lewis, I applied this patch with its dependencies, ran -msave-restore -mllvm -enable-shrink-wrap config, and I see no failures.

lewis-revill abandoned this revision.Nov 1 2019, 1:21 PM
lewis-revill mentioned this in D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls.

This functionality has been merged into the save/restore patch.

Herald added a subscriber: sameer.abuasal. · View Herald TranscriptNov 1 2019, 1:21 PM

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
RISCV/
3 lines
44 lines
test/
CodeGen/
RISCV/
29 lines

Diff 223857

View Options

llvm/lib/Target/RISCV/RISCVFrameLowering.h

Loading...
View Options

llvm/lib/Target/RISCV/RISCVFrameLowering.cpp

Loading...
View Options

llvm/test/CodeGen/RISCV/shrinkwrap.ll

Loading...