The concept of strict floating point nodes was added into LLVM in https://reviews.llvm.org/D55506.
This is the second follow-up patch to add round/trunc/extend constraint fp intrinsics support for PowerPC target.
Paths
| Differential D64193
[PowerPC] Add exception constraint to FP rounding operations ClosedPublic Authored by qiucf on Jul 3 2019, 11:10 PM.
Details
Summary The concept of strict floating point nodes was added into LLVM in https://reviews.llvm.org/D55506. This is the second follow-up patch to add round/trunc/extend constraint fp intrinsics support for PowerPC target.
Diff Detail
Unit TestsFailed Event TimelineComment Actions This patch is too large to review and 'remaining parts' is confusing. It's better to split this one into several patches (round, extend/trunc, sqrt, fma, etc.) and push them into a review stack. qiucf retitled this revision from [PowerPC] Add constraint fp support about exception part for remaining operations to [PowerPC] Add exception constraint to FP rounding operations. Comment ActionsRebase and fix test errors qiucf added a child revision: D72749: [PowerPC] Add exception constraint to FP sqrt, fma, min/max.Jan 14 2020, 10:46 PM Comment Actions Unit tests: pass. 61901 tests passed, 0 failed and 781 were skipped. clang-tidy: unknown. clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or applying this patch. Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml qiucf removed a parent revision: D63916: [PowerPC] Add exception constraint to FP arithmetic.Mar 12 2020, 2:17 AM qiucf added a child revision: D77033: [Legalizer] Workaround for scalarizing unary strict-fp ops.Mar 29 2020, 9:52 PM qiucf mentioned this in D77208: [PowerPC] Remove unnecessary XSRSP instruction in MI peephole.Apr 1 2020, 3:27 AM qiucf added a parent revision: D77208: [PowerPC] Remove unnecessary XSRSP instruction in MI peephole.
qiucf removed a child revision: D72749: [PowerPC] Add exception constraint to FP sqrt, fma, min/max.May 11 2020, 2:33 AM qiucf added inline comments.
qiucf added inline comments.
Comment Actions LGTM. But please hold on for several days in case someone has more comments.
This revision is now accepted and ready to land.May 19 2020, 8:04 PM Comment Actions I looked through this and it seems fine to me. Esme added inline comments.
Closed by commit rG13edcd696e08: [PowerPC] Support constrained rounding operations (authored by qiucf). · Explain WhyJun 14 2020, 9:04 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 254427 llvm/lib/Target/PowerPC/PPCISelLowering.cpp
llvm/lib/Target/PowerPC/PPCInstrInfo.td
llvm/lib/Target/PowerPC/PPCInstrVSX.td
llvm/test/CodeGen/PowerPC/fp-strict-round.ll
llvm/test/CodeGen/PowerPC/ppcf128-constrained-fp-intrinsics.ll
llvm/test/CodeGen/PowerPC/vector-constrained-fp-intrinsics.ll
|
clang-format: please reformat the code