Page MenuHomePhabricator

ajwock (Andrew J Wock)
User

Projects

User does not belong to any projects.

User Details

User Since
May 20 2019, 10:32 AM (74 w, 16 h)

Recent Activity

Aug 25 2020

ajwock added a comment to D85548: Allow fneg + strict_fadd -> strict_fsub in DAGCombiner.

This combine does create the strict_fsub in terms of strict_fadd while preserving the chain-protected ordering. Would it still be appropriate to have this transform and others like it in the DAGCombiner?

Aug 25 2020, 7:46 AM · Restricted Project

Aug 14 2020

ajwock added inline comments to D85548: Allow fneg + strict_fadd -> strict_fsub in DAGCombiner.
Aug 14 2020, 1:43 PM · Restricted Project

Aug 7 2020

ajwock requested review of D85548: Allow fneg + strict_fadd -> strict_fsub in DAGCombiner.
Aug 7 2020, 12:28 PM · Restricted Project

Jun 21 2020

ajwock updated the diff for D82020: PowerPC-specific builtin constrained FP enablement.

It seems one of the issues that my tests revealed was already remedied in very recent changes, causing my test to fail. I changed the test to reflect that while also taking steven's recommendations.

Jun 21 2020, 9:41 PM · Restricted Project

Jun 19 2020

ajwock updated the diff for D82020: PowerPC-specific builtin constrained FP enablement.

Took steven.zhang's suggestion, added REQUIRES line to diff. Hopefully addressed harbormaster concerns.

Jun 19 2020, 2:41 PM · Restricted Project

Jun 17 2020

ajwock added a reviewer for D82020: PowerPC-specific builtin constrained FP enablement: steven.zhang.
Jun 17 2020, 9:08 AM · Restricted Project
ajwock created D82020: PowerPC-specific builtin constrained FP enablement.
Jun 17 2020, 9:08 AM · Restricted Project

Apr 2 2020

ajwock updated the diff for D76949: Replace subtract-from-zero float in version with fneg in PowerPC special fma compiler builtins.

Rebased for harbormaster.

Apr 2 2020, 1:33 PM · Restricted Project, Restricted Project

Mar 31 2020

ajwock accepted D77160: Fix PR45371: SeparateConstOffsetFromGEP clean up bookkeeping.

LGTM, just give the test a good name.

Mar 31 2020, 1:47 PM · Restricted Project

Mar 27 2020

ajwock created D76949: Replace subtract-from-zero float in version with fneg in PowerPC special fma compiler builtins.
Mar 27 2020, 1:10 PM · Restricted Project, Restricted Project
ajwock added a reviewer for D76949: Replace subtract-from-zero float in version with fneg in PowerPC special fma compiler builtins: nemanjai.
Mar 27 2020, 1:10 PM · Restricted Project, Restricted Project

Jan 14 2020

ajwock updated the diff for D65967: [SeparateConstOffsetFromGEP][PowerPC] Fix: sext(a) + sext(b) -> sext(a + b) matches add and sub instructions with one another.

Changed directory.

Jan 14 2020, 10:32 AM · Restricted Project

Dec 4 2019

ajwock abandoned D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.

Mooted by D70867.

Dec 4 2019, 10:39 AM · Restricted Project

Nov 1 2019

ajwock updated the diff for D65967: [SeparateConstOffsetFromGEP][PowerPC] Fix: sext(a) + sext(b) -> sext(a + b) matches add and sub instructions with one another.

Sorry for the delay- I had to investigate some of the fragility so that my test case reduced to this pass would still trigger the issue. However, I did manage to get a test case that is only a few lines long that would trigger the issue without the update.

Nov 1 2019, 11:27 AM · Restricted Project

Oct 25 2019

ajwock added reviewers for D65967: [SeparateConstOffsetFromGEP][PowerPC] Fix: sext(a) + sext(b) -> sext(a + b) matches add and sub instructions with one another: arsenm, tra, delena, jlebar.
Oct 25 2019, 5:53 AM · Restricted Project

Oct 11 2019

ajwock added a comment to D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.

ping

Oct 11 2019, 9:38 AM · Restricted Project
ajwock added a comment to D65967: [SeparateConstOffsetFromGEP][PowerPC] Fix: sext(a) + sext(b) -> sext(a + b) matches add and sub instructions with one another.

ping

Oct 11 2019, 9:37 AM · Restricted Project

Sep 27 2019

ajwock added a comment to D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.

ping.

Sep 27 2019, 10:33 AM · Restricted Project
ajwock added a comment to D65967: [SeparateConstOffsetFromGEP][PowerPC] Fix: sext(a) + sext(b) -> sext(a + b) matches add and sub instructions with one another.

ping.

Sep 27 2019, 10:21 AM · Restricted Project

Sep 11 2019

ajwock updated the diff for D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.

Ensured that all changes to LLVM source are clang-formatted.

Sep 11 2019, 12:04 PM · Restricted Project

Sep 6 2019

ajwock updated the diff for D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.

Added libcall lowering for fptosi and fptoui constrained intrinsics. They take a similar lowering route to STRICT_FP_ROUND.

Sep 6 2019, 1:18 PM · Restricted Project

Aug 30 2019

ajwock added inline comments to D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.
Aug 30 2019, 12:50 PM · Restricted Project
ajwock added inline comments to D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.
Aug 30 2019, 12:47 PM · Restricted Project
ajwock updated the diff for D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.

Updated tests to have nounwind attribute so that we don't have to worry about https://reviews.llvm.org/D67016 non-relevant .cfi.

Aug 30 2019, 12:01 PM · Restricted Project
ajwock added a comment to D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.

Still have some test changes that I have to make- slight diff change incoming soon

Aug 30 2019, 11:48 AM · Restricted Project
ajwock updated the diff for D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.

Thanks to jsji for making me realize that a lot of the functionality I implemented in this patch already existed. I converted the ExpandFloatRes/Op_STRICT_* functions to use ExpandChainLibCall and eliminated the LibCallifyStrictFP and MakeLibCallChained functions from the previous diffs.

Aug 30 2019, 11:36 AM · Restricted Project

Aug 28 2019

ajwock added inline comments to D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.
Aug 28 2019, 1:27 PM · Restricted Project
ajwock updated the diff for D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.

Variety of adjustments, see comment replies (still incoming if I just submitted this)

Aug 28 2019, 1:21 PM · Restricted Project

Aug 23 2019

ajwock added a comment to D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.

Ping.

Aug 23 2019, 6:02 AM · Restricted Project
ajwock added a comment to D65967: [SeparateConstOffsetFromGEP][PowerPC] Fix: sext(a) + sext(b) -> sext(a + b) matches add and sub instructions with one another.

Ping.

Aug 23 2019, 5:58 AM · Restricted Project

Aug 8 2019

ajwock updated the diff for D65967: [SeparateConstOffsetFromGEP][PowerPC] Fix: sext(a) + sext(b) -> sext(a + b) matches add and sub instructions with one another.
Aug 8 2019, 1:11 PM · Restricted Project
ajwock added a comment to D65967: [SeparateConstOffsetFromGEP][PowerPC] Fix: sext(a) + sext(b) -> sext(a + b) matches add and sub instructions with one another.

Diff did not include my test case- correcting that.

Aug 8 2019, 1:11 PM · Restricted Project
ajwock created D65967: [SeparateConstOffsetFromGEP][PowerPC] Fix: sext(a) + sext(b) -> sext(a + b) matches add and sub instructions with one another.
Aug 8 2019, 1:07 PM · Restricted Project

Aug 7 2019

ajwock added a comment to D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.

ping

Aug 7 2019, 12:43 PM · Restricted Project

Jul 29 2019

ajwock added a comment to D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.

Ping.

Jul 29 2019, 9:05 AM · Restricted Project

Jul 15 2019

ajwock updated the diff for D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.

Full context.

Jul 15 2019, 11:34 AM · Restricted Project

Jul 12 2019

ajwock added a comment to D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.

Sorry Hal, I must have accidentally released an incomplete draft yesterday instead of simply deleting it like I meant to.

Jul 12 2019, 1:02 PM · Restricted Project
ajwock created D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.
Jul 12 2019, 1:01 PM · Restricted Project

Jun 13 2019

ajwock updated the diff for D63271: [FPEnv] Lower STRICT_FP_EXTEND and STRICT_FP_ROUND nodes in preprocess phase of ISelLowering to mirror non-strict nodes on x86..

That is a good observation, Craig. Changed.

Jun 13 2019, 11:08 AM · Restricted Project
ajwock updated the summary of D63271: [FPEnv] Lower STRICT_FP_EXTEND and STRICT_FP_ROUND nodes in preprocess phase of ISelLowering to mirror non-strict nodes on x86..
Jun 13 2019, 10:17 AM · Restricted Project
ajwock updated the summary of D63271: [FPEnv] Lower STRICT_FP_EXTEND and STRICT_FP_ROUND nodes in preprocess phase of ISelLowering to mirror non-strict nodes on x86..
Jun 13 2019, 10:16 AM · Restricted Project
ajwock created D63271: [FPEnv] Lower STRICT_FP_EXTEND and STRICT_FP_ROUND nodes in preprocess phase of ISelLowering to mirror non-strict nodes on x86..
Jun 13 2019, 7:43 AM · Restricted Project

May 30 2019

ajwock updated the diff for D62546: [FPEnv] Added a special UnrollVectorOp method to deal with the chain on StrictFP opcodes.

Added space (i= 0 -> i = 0)

May 30 2019, 6:17 AM · Restricted Project
ajwock added inline comments to D62546: [FPEnv] Added a special UnrollVectorOp method to deal with the chain on StrictFP opcodes.
May 30 2019, 6:17 AM · Restricted Project

May 29 2019

ajwock updated the diff for D62546: [FPEnv] Added a special UnrollVectorOp method to deal with the chain on StrictFP opcodes.

Modified the SystemZ test for this fix so that it also works for SystemZ Z13, which is afflicted by a different errror involving function return types at an earlier stage in compilation. To circumvent this, all v3f64 tests were changed so that they took a pointer parameter, modified the value at that pointer, and returned void. These still test StrictFP code generation while avoiding an unrelated platform specific error.

May 29 2019, 1:23 PM · Restricted Project

May 28 2019

ajwock created D62546: [FPEnv] Added a special UnrollVectorOp method to deal with the chain on StrictFP opcodes.
May 28 2019, 1:03 PM · Restricted Project

May 24 2019

ajwock created D62388: [FPEnv] PowerPC Vector Constrained FP Intrinsics Test.
May 24 2019, 6:35 AM · Restricted Project