- User Since
- May 20 2019, 10:32 AM (74 w, 16 h)
Aug 25 2020
This combine does create the strict_fsub in terms of strict_fadd while preserving the chain-protected ordering. Would it still be appropriate to have this transform and others like it in the DAGCombiner?
Aug 14 2020
Aug 7 2020
Jun 21 2020
It seems one of the issues that my tests revealed was already remedied in very recent changes, causing my test to fail. I changed the test to reflect that while also taking steven's recommendations.
Jun 19 2020
Took steven.zhang's suggestion, added REQUIRES line to diff. Hopefully addressed harbormaster concerns.
Jun 17 2020
Apr 2 2020
Rebased for harbormaster.
Mar 31 2020
LGTM, just give the test a good name.
Mar 27 2020
Jan 14 2020
Dec 4 2019
Mooted by D70867.
Nov 1 2019
Sorry for the delay- I had to investigate some of the fragility so that my test case reduced to this pass would still trigger the issue. However, I did manage to get a test case that is only a few lines long that would trigger the issue without the update.
Oct 25 2019
Oct 11 2019
Sep 27 2019
Sep 11 2019
Ensured that all changes to LLVM source are clang-formatted.
Sep 6 2019
Added libcall lowering for fptosi and fptoui constrained intrinsics. They take a similar lowering route to STRICT_FP_ROUND.
Aug 30 2019
Updated tests to have nounwind attribute so that we don't have to worry about https://reviews.llvm.org/D67016 non-relevant .cfi.
Still have some test changes that I have to make- slight diff change incoming soon
Thanks to jsji for making me realize that a lot of the functionality I implemented in this patch already existed. I converted the ExpandFloatRes/Op_STRICT_* functions to use ExpandChainLibCall and eliminated the LibCallifyStrictFP and MakeLibCallChained functions from the previous diffs.
Aug 28 2019
Variety of adjustments, see comment replies (still incoming if I just submitted this)
Aug 23 2019
Aug 8 2019
Diff did not include my test case- correcting that.
Aug 7 2019
Jul 29 2019
Jul 15 2019
Jul 12 2019
Sorry Hal, I must have accidentally released an incomplete draft yesterday instead of simply deleting it like I meant to.
Jun 13 2019
That is a good observation, Craig. Changed.
May 30 2019
Added space (i= 0 -> i = 0)
May 29 2019
Modified the SystemZ test for this fix so that it also works for SystemZ Z13, which is afflicted by a different errror involving function return types at an earlier stage in compilation. To circumvent this, all v3f64 tests were changed so that they took a pointer parameter, modified the value at that pointer, and returned void. These still test StrictFP code generation while avoiding an unrelated platform specific error.