Page MenuHomePhabricator

qiucf (Qiu Chaofan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 3 2019, 9:30 PM (81 w, 6 d)

I'm identical to @ecnelises .

Recent Activity

Fri, Sep 25

qiucf committed rGc0f8e4c06c85: [SelectionDAG] Add guard to automatically insert flags (authored by qiucf).
[SelectionDAG] Add guard to automatically insert flags
Fri, Sep 25, 10:58 PM
qiucf closed D87361: [SelectionDAG] Add helper guard to automatically insert flags.
Fri, Sep 25, 10:58 PM · Restricted Project

Tue, Sep 22

qiucf added a comment to D88063: [SelectionDAG] Make sure FMF are propagated when getSetcc canonicalizes FP constants to RHS..

What, if any, interaction is there between this and D87361?
Can we solve this with the more general flag propagation scheme proposed there?

Tue, Sep 22, 8:54 AM · Restricted Project

Sun, Sep 20

qiucf committed rG1d782c29872c: [PowerPC] Pass nofpexcept flag to custom lowered constrained ops (authored by qiucf).
[PowerPC] Pass nofpexcept flag to custom lowered constrained ops
Sun, Sep 20, 7:44 PM
qiucf closed D87390: [PowerPC] Pass nofpexcept flag to custom lowered constrained ops.
Sun, Sep 20, 7:44 PM · Restricted Project

Thu, Sep 17

qiucf added a comment to rGa2fb5446be96: [SelectionDAG] Check any use of negation result before removal.

The differential revision should be https://reviews.llvm.org/D87698

Thu, Sep 17, 1:11 AM
qiucf closed D87698: [SelectionDAG] Check any use of negation result before removal.
Thu, Sep 17, 1:09 AM · Restricted Project
qiucf committed rGa2fb5446be96: [SelectionDAG] Check any use of negation result before removal (authored by qiucf).
[SelectionDAG] Check any use of negation result before removal
Thu, Sep 17, 1:07 AM

Wed, Sep 16

qiucf committed rGebfbdebe9678: [PowerPC] Fix store-fptoi combine of f128 on Power8 (authored by qiucf).
[PowerPC] Fix store-fptoi combine of f128 on Power8
Wed, Sep 16, 7:22 PM
qiucf closed D86686: [PowerPC] Fix store-fptoi combine of f128 on Power8.
Wed, Sep 16, 7:21 PM · Restricted Project
qiucf updated the diff for D86686: [PowerPC] Fix store-fptoi combine of f128 on Power8.

Remove comments

Wed, Sep 16, 8:56 AM · Restricted Project
qiucf updated the diff for D86686: [PowerPC] Fix store-fptoi combine of f128 on Power8.

Use isTypeLegal

Wed, Sep 16, 3:24 AM · Restricted Project
qiucf added a comment to D86686: [PowerPC] Fix store-fptoi combine of f128 on Power8.

Ping.

Wed, Sep 16, 2:47 AM · Restricted Project
qiucf updated the diff for D87361: [SelectionDAG] Add helper guard to automatically insert flags.

Remove flag passing in methods visiting floating-point nodes.

Wed, Sep 16, 2:02 AM · Restricted Project

Tue, Sep 15

qiucf updated the summary of D87738: [PowerPC] Clean-up mayRaiseFPException bits.
Tue, Sep 15, 11:24 PM · Restricted Project
qiucf requested review of D87738: [PowerPC] Clean-up mayRaiseFPException bits.
Tue, Sep 15, 8:54 PM · Restricted Project
qiucf requested review of D87698: [SelectionDAG] Check any use of negation result before removal.
Tue, Sep 15, 8:05 AM · Restricted Project
qiucf committed rGe1669843f2aa: Revert "[SelectionDAG] Remove unused FP constant in getNegatedExpression" (authored by qiucf).
Revert "[SelectionDAG] Remove unused FP constant in getNegatedExpression"
Tue, Sep 15, 7:06 AM
qiucf added a comment to D87614: [SelectionDAG] Remove unused FP constant in getNegatedExpression.

After running sanitizer, I think the bug is not totally covered by this patch.

Tue, Sep 15, 6:06 AM · Restricted Project
qiucf added a comment to rG2508ef014e8b: [SelectionDAG] Remove unused FP constant in getNegatedExpression.

This seems causing an address sanitizer failure: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/46121/steps/check-llvm%20asan/logs/stdio

Tue, Sep 15, 5:36 AM
qiucf committed rG2508ef014e8b: [SelectionDAG] Remove unused FP constant in getNegatedExpression (authored by qiucf).
[SelectionDAG] Remove unused FP constant in getNegatedExpression
Tue, Sep 15, 3:04 AM
qiucf closed D87614: [SelectionDAG] Remove unused FP constant in getNegatedExpression.
Tue, Sep 15, 3:04 AM · Restricted Project

Mon, Sep 14

qiucf updated the diff for D87614: [SelectionDAG] Remove unused FP constant in getNegatedExpression.

Update test using script

Mon, Sep 14, 10:57 PM · Restricted Project
qiucf updated the diff for D87614: [SelectionDAG] Remove unused FP constant in getNegatedExpression.

Reduce test case

Mon, Sep 14, 9:57 AM · Restricted Project
qiucf requested review of D87614: [SelectionDAG] Remove unused FP constant in getNegatedExpression.
Mon, Sep 14, 7:52 AM · Restricted Project

Sun, Sep 13

qiucf updated the diff for D87361: [SelectionDAG] Add helper guard to automatically insert flags.

Keep flags in current methods and introduce new methods to auto-insert flags. (maybe can use variadic template methods?)

Sun, Sep 13, 10:15 AM · Restricted Project
qiucf committed rGa4c535198643: [DAGCombiner] Propagate FMF flags in FMA folding (authored by qiucf).
[DAGCombiner] Propagate FMF flags in FMA folding
Sun, Sep 13, 9:23 AM
qiucf closed D87037: [DAGCombiner] Propagate FMF flags in FMA folding.
Sun, Sep 13, 9:23 AM · Restricted Project
qiucf committed rGbec81dc67d93: Reland "[PowerPC] Implement instruction clustering for stores" (authored by qiucf).
Reland "[PowerPC] Implement instruction clustering for stores"
Sun, Sep 13, 4:52 AM

Fri, Sep 11

qiucf committed rG8ecc8520bc5b: [FPEnv] [Clang] Enable constrained FP support for PowerPC (authored by qiucf).
[FPEnv] [Clang] Enable constrained FP support for PowerPC
Fri, Sep 11, 9:41 AM
qiucf closed D87223: [FPEnv] [Clang] Enable constrained FP support for PowerPC.
Fri, Sep 11, 9:40 AM · Restricted Project

Thu, Sep 10

qiucf added a comment to D87223: [FPEnv] [Clang] Enable constrained FP support for PowerPC.
In D87223#2261086, @kpn wrote:

Over in D80952 there was a comment from @steven.zhang: "Agree that we can turn on it later when it is done." But your comment here is that it is "almost done".

Is it fair to say that the PowerPC work is at _parity_ with X86 and SystemZ? I think that's a better cutover point than "done".

Thu, Sep 10, 3:10 AM · Restricted Project

Wed, Sep 9

qiucf commandeered D85599: [PowerPC] Remove isTerminator for TRAP instruction.
Wed, Sep 9, 11:34 PM · Restricted Project, Restricted Project, Restricted Project
qiucf commandeered D83569: [PowerPC] Fix the killed flag in mi-peephole pass.
Wed, Sep 9, 11:33 PM · Restricted Project
qiucf commandeered D71983: [PowerPC] Set the SideEffects of branch & call instructions from 1 to 0.
Wed, Sep 9, 11:32 PM · Restricted Project
qiucf committed rG6afb27910044: [PowerPC] [FPEnv] Disable strict FP mutation by default (authored by qiucf).
[PowerPC] [FPEnv] Disable strict FP mutation by default
Wed, Sep 9, 10:32 PM
qiucf closed D87222: [PowerPC] [FPEnv] Disable strict FP mutation by default for PowerPC.
Wed, Sep 9, 10:31 PM · Restricted Project
qiucf requested review of D87390: [PowerPC] Pass nofpexcept flag to custom lowered constrained ops.
Wed, Sep 9, 9:11 AM · Restricted Project
qiucf committed rG88ff4d2ca1a0: [PowerPC] Fix STRICT_FRINT/STRICT_FNEARBYINT lowering (authored by qiucf).
[PowerPC] Fix STRICT_FRINT/STRICT_FNEARBYINT lowering
Wed, Sep 9, 7:43 AM
qiucf closed D87220: [PowerPC] Fix STRICT_FRINT/STRICT_FNEARBYINT lowering.
Wed, Sep 9, 7:43 AM · Restricted Project, Restricted Project
qiucf requested review of D87361: [SelectionDAG] Add helper guard to automatically insert flags.
Wed, Sep 9, 4:30 AM · Restricted Project
qiucf accepted D83937: [Power] Set the mayRaiseFPException for FCMPUS/FCMPUD.

LGTM

Wed, Sep 9, 4:28 AM · Restricted Project

Tue, Sep 8

qiucf added a reverting change for rG3c0b3250230b: [PowerPC] Implement instruction clustering for stores: rG8d9c13f37d20: Revert "[PowerPC] Implement instruction clustering for stores".
Tue, Sep 8, 2:28 AM
qiucf committed rG8d9c13f37d20: Revert "[PowerPC] Implement instruction clustering for stores" (authored by qiucf).
Revert "[PowerPC] Implement instruction clustering for stores"
Tue, Sep 8, 2:28 AM
qiucf added a reverting change for D86754: [PowerPC] Implement instruction clustering for stores: rG8d9c13f37d20: Revert "[PowerPC] Implement instruction clustering for stores".
Tue, Sep 8, 2:28 AM · Restricted Project
qiucf committed rGbb39eb9e7f42: [PowerPC] Fix getMemOperandWithOffsetWidth (authored by qiucf).
[PowerPC] Fix getMemOperandWithOffsetWidth
Tue, Sep 8, 12:35 AM

Mon, Sep 7

qiucf committed rG3c0b3250230b: [PowerPC] Implement instruction clustering for stores (authored by qiucf).
[PowerPC] Implement instruction clustering for stores
Mon, Sep 7, 8:14 PM
qiucf closed D86754: [PowerPC] Implement instruction clustering for stores.
Mon, Sep 7, 8:14 PM · Restricted Project
qiucf added inline comments to D87037: [DAGCombiner] Propagate FMF flags in FMA folding.
Mon, Sep 7, 7:52 PM · Restricted Project

Sun, Sep 6

qiucf requested review of D87223: [FPEnv] [Clang] Enable constrained FP support for PowerPC.
Sun, Sep 6, 10:57 PM · Restricted Project
qiucf updated the diff for D87220: [PowerPC] Fix STRICT_FRINT/STRICT_FNEARBYINT lowering.

Fix clang to align the change

Sun, Sep 6, 10:46 PM · Restricted Project, Restricted Project
qiucf requested review of D87222: [PowerPC] [FPEnv] Disable strict FP mutation by default for PowerPC.
Sun, Sep 6, 10:09 PM · Restricted Project
qiucf requested review of D87220: [PowerPC] Fix STRICT_FRINT/STRICT_FNEARBYINT lowering.
Sun, Sep 6, 9:54 PM · Restricted Project, Restricted Project
qiucf added inline comments to D87037: [DAGCombiner] Propagate FMF flags in FMA folding.
Sun, Sep 6, 7:54 PM · Restricted Project
qiucf updated the diff for D87037: [DAGCombiner] Propagate FMF flags in FMA folding.
  • Update tests
  • Keep redundant code (irrelevant to this patch)
Sun, Sep 6, 7:54 PM · Restricted Project

Fri, Sep 4

qiucf committed rG705271d9cd0e: [PowerPC] Expand constrained ppc_fp128 to i32 conversion (authored by qiucf).
[PowerPC] Expand constrained ppc_fp128 to i32 conversion
Fri, Sep 4, 10:43 PM
qiucf closed D86605: [PowerPC] Expand constrained ppc_fp128 to i32 conversion.
Fri, Sep 4, 10:42 PM · Restricted Project
qiucf updated the diff for D86605: [PowerPC] Expand constrained ppc_fp128 to i32 conversion.

Only pass nofpexcept flag.

Fri, Sep 4, 10:33 AM · Restricted Project
qiucf added inline comments to D86605: [PowerPC] Expand constrained ppc_fp128 to i32 conversion.
Fri, Sep 4, 9:11 AM · Restricted Project
qiucf updated the diff for D86605: [PowerPC] Expand constrained ppc_fp128 to i32 conversion.
  • Move out constants
  • Transfer nofpexcept flag. If this is a problem, other lowering methods should also be fixed
  • Transfer nofpexcept to FADD if FADDRtz is nofpexcept
Fri, Sep 4, 9:11 AM · Restricted Project
qiucf updated the diff for D86605: [PowerPC] Expand constrained ppc_fp128 to i32 conversion.
  • Introduce strict version of FADDRTZ
  • Use algorithm similar to expandFP_TO_UINT
Fri, Sep 4, 12:19 AM · Restricted Project

Wed, Sep 2

qiucf requested review of D87037: [DAGCombiner] Propagate FMF flags in FMA folding.
Wed, Sep 2, 8:51 AM · Restricted Project
qiucf committed rGb6b63684b198: [NFC] [PowerPC] Add FMA flag propagation test (authored by qiucf).
[NFC] [PowerPC] Add FMA flag propagation test
Wed, Sep 2, 8:11 AM
qiucf added a comment to D86686: [PowerPC] Fix store-fptoi combine of f128 on Power8.

Ping..

Wed, Sep 2, 5:36 AM · Restricted Project
qiucf added inline comments to D86605: [PowerPC] Expand constrained ppc_fp128 to i32 conversion.
Wed, Sep 2, 5:36 AM · Restricted Project
qiucf updated the diff for D86605: [PowerPC] Expand constrained ppc_fp128 to i32 conversion.

Run clang-format.

Wed, Sep 2, 5:36 AM · Restricted Project

Tue, Sep 1

qiucf added a comment to D83937: [Power] Set the mayRaiseFPException for FCMPUS/FCMPUD.
define i32 @test(double %a, double %b) {
entry:
  %r = fcmp ogt double %a, %b
  %g = zext i1 %r to i32
  ret i32 %g
}
Tue, Sep 1, 8:52 PM · Restricted Project
qiucf committed rG29ae4485950e: [PowerPC] Handle STRICT_FSETCC(S) in more cases (authored by qiucf).
[PowerPC] Handle STRICT_FSETCC(S) in more cases
Tue, Sep 1, 9:33 AM
qiucf closed D86595: [PowerPC] Handle STRICT_FSETCC(S) in more cases.
Tue, Sep 1, 9:33 AM · Restricted Project

Mon, Aug 31

qiucf updated the diff for D86595: [PowerPC] Handle STRICT_FSETCC(S) in more cases.

Fix chain of fcmp instruction

Mon, Aug 31, 11:25 PM · Restricted Project
qiucf committed rG5475154865fd: [NFC] [DAGCombiner] Refactor bitcast folding within fabs/fneg (authored by qiucf).
[NFC] [DAGCombiner] Refactor bitcast folding within fabs/fneg
Mon, Aug 31, 9:49 AM
qiucf added inline comments to D86862: [NFC] [DAGCombiner] Refactor bitcast folding within fabs/fneg.
Mon, Aug 31, 9:49 AM · Restricted Project
qiucf closed D86862: [NFC] [DAGCombiner] Refactor bitcast folding within fabs/fneg.
Mon, Aug 31, 9:49 AM · Restricted Project
qiucf committed rGeb2a405c181c: [NFC] [DAGCombiner] Remove unnecessary negation in visitFNEG (authored by qiucf).
[NFC] [DAGCombiner] Remove unnecessary negation in visitFNEG
Mon, Aug 31, 9:37 AM
qiucf added inline comments to D86862: [NFC] [DAGCombiner] Refactor bitcast folding within fabs/fneg.
Mon, Aug 31, 6:45 AM · Restricted Project
qiucf updated the diff for D86862: [NFC] [DAGCombiner] Refactor bitcast folding within fabs/fneg.

Address style comments.

Mon, Aug 31, 6:45 AM · Restricted Project
qiucf added a reviewer for D86862: [NFC] [DAGCombiner] Refactor bitcast folding within fabs/fneg: nemanjai.
Mon, Aug 31, 2:05 AM · Restricted Project
qiucf requested review of D86862: [NFC] [DAGCombiner] Refactor bitcast folding within fabs/fneg.
Mon, Aug 31, 12:56 AM · Restricted Project

Sat, Aug 29

qiucf updated the diff for D86754: [PowerPC] Implement instruction clustering for stores.

Use FusionFeatures.

Sat, Aug 29, 10:36 PM · Restricted Project

Aug 27 2020

qiucf requested review of D86754: [PowerPC] Implement instruction clustering for stores.
Aug 27 2020, 7:14 PM · Restricted Project
qiucf added inline comments to D86684: [Refactor] Add the SchedHeuristic for Scheduler to allow platform customizing the heuristics.
Aug 27 2020, 3:29 AM · Restricted Project
qiucf requested review of D86686: [PowerPC] Fix store-fptoi combine of f128 on Power8.
Aug 27 2020, 1:16 AM · Restricted Project

Aug 26 2020

qiucf added a comment to D6164: CodeGen, SelectionDAG: Increase width of NumOperands and NumValues.

Is this still relevant?

Aug 26 2020, 7:42 PM
qiucf added inline comments to D86595: [PowerPC] Handle STRICT_FSETCC(S) in more cases.
Aug 26 2020, 9:01 AM · Restricted Project
qiucf requested review of D86605: [PowerPC] Expand constrained ppc_fp128 to i32 conversion.
Aug 26 2020, 2:35 AM · Restricted Project
qiucf requested review of D86595: [PowerPC] Handle STRICT_FSETCC(S) in more cases.
Aug 26 2020, 1:12 AM · Restricted Project

Aug 23 2020

qiucf closed D81918: [PowerPC] Support lowering int-to-fp on ppc_fp128.
Aug 23 2020, 10:25 PM · Restricted Project
qiucf committed rG1bc45b2fd808: [PowerPC] Support lowering int-to-fp on ppc_fp128 (authored by qiucf).
[PowerPC] Support lowering int-to-fp on ppc_fp128
Aug 23 2020, 8:21 PM
qiucf committed rGfed6107dcbfb: [PowerPC] Allow constrained FP intrinsics in mightUseCTR (authored by qiucf).
[PowerPC] Allow constrained FP intrinsics in mightUseCTR
Aug 23 2020, 8:13 PM
qiucf closed D81924: [PowerPC] Allow constrained FP intrinsics in mightUseCTR.
Aug 23 2020, 8:13 PM · Restricted Project
qiucf committed rG41ba9d77231e: [PowerPC] Support constrained vector fp/int conversion (authored by qiucf).
[PowerPC] Support constrained vector fp/int conversion
Aug 23 2020, 7:19 PM
qiucf closed D83654: [PowerPC] Support constrained vector fp/int conversion.
Aug 23 2020, 7:19 PM · Restricted Project

Aug 21 2020

qiucf committed rGa5b7b8cce022: [PowerPC] Support constrained scalar sitofp/uitofp (authored by qiucf).
[PowerPC] Support constrained scalar sitofp/uitofp
Aug 21 2020, 11:10 AM
qiucf closed D81669: [PowerPC] Support constrained fp operation for scalar sitofp/uitofp.
Aug 21 2020, 11:10 AM · Restricted Project
qiucf updated the diff for D81924: [PowerPC] Allow constrained FP intrinsics in mightUseCTR.

use script to refresh test

Aug 21 2020, 2:36 AM · Restricted Project
qiucf updated the diff for D81924: [PowerPC] Allow constrained FP intrinsics in mightUseCTR.

Add test

Aug 21 2020, 12:56 AM · Restricted Project
qiucf committed rG91039784b3c9: [PowerPC] Add readflm/setflm intrinsics to Clang (authored by qiucf).
[PowerPC] Add readflm/setflm intrinsics to Clang
Aug 21 2020, 12:25 AM
qiucf closed D85874: [PowerPC] Add readflm/setflm intrinsics to Clang.
Aug 21 2020, 12:25 AM · Restricted Project, Restricted Project

Aug 20 2020

qiucf updated the diff for D81669: [PowerPC] Support constrained fp operation for scalar sitofp/uitofp.
  • Use PPCany_* to restructure tblgen file
  • Add mayRaiseFPException flag to fcfid*
  • Add default argument to convertIntToFp
Aug 20 2020, 8:20 PM · Restricted Project
qiucf added a comment to D86183: [DAGCombine] Remove dead node when it is created by getNegatedExpression.

The original test case is too big to get something useful. I happened to grab a basic block from it. It's not small enough to be a test, but it would be much easier to analyze: https://reviews.llvm.org/P8230

Aug 20 2020, 2:48 AM · Restricted Project