I'm identical to @ecnelises .
- User Since
- Mar 3 2019, 9:30 PM (46 w, 4 d)
Thu, Jan 16
- Wrap memory modified check into a single method (which can help other methods)
Tue, Jan 14
Rebase and fix test errors
Fix a test error
- Use dedicated method to check ModRefInfo.
- Add tests about calls.
Sat, Jan 11
Fri, Jan 10
Wed, Jan 8
The merge check bot should have some problems in resolving parent-child revision with some already committed. Currently, they have no problem applying into master and tests are passed.
Address some comments.
- Change some use of auto.
- Update test cases with comments.
- Use getModRefInfo.
Mon, Jan 6
This patch is too large to review and 'remaining parts' is confusing. It's better to split this one into several patches (round, extend/trunc, sqrt, fma, etc.) and push them into a review stack.
Rebase and fix conflicts.
Sat, Jan 4
Thu, Jan 2
Use explicit template instantiation approach.
Wed, Jan 1
This causes build failure (using GCC 8.2.1), complaining undefined reference to releaseNode, since this patch splits declaration and definition of the template method.
Mon, Dec 30
Sun, Dec 29
This diff seems out of date, needs rebasing.
- Create inbounds store
- Strip casted pointer before comparison
- Make sure load and store belong to the same BB
- Keep nontemporal metadata of store
Update test case to reflect new points in main patch.
Fri, Dec 27
Extend patch with full contexts.
Wed, Dec 25
- Add check for address of load and store.
- Add check for any memory write instructions between load and store.
- Add more test cases for cases above. (Thanks to spatel)
Dec 23 2019
Update test using auto-genearate tool.
https://reviews.llvm.org/D71828 is created for simpler logic at InstCombine.
Dec 12 2019
Dec 4 2019
Thanks for comments and explanation from everyone. I think there're two key issues to clarify and solve about this revision:
Dec 3 2019
Nov 28 2019
Address some comments from the community:
Nov 27 2019
Will abandon this revision and add them back to D70223 for easier discussion.
Nov 25 2019
Nov 19 2019
Nov 17 2019
Remove test case change to swaps-le-5 and swaps-le-6 since they're moved to a single differential D70373.
Nov 15 2019
- Add regression test.
- Check legality before doing costy operations.
Nov 14 2019
Nov 13 2019
Nov 10 2019
Oct 15 2019
Oct 11 2019
Sep 12 2019
Sep 9 2019
Remove unexpected changed file caused by newline characters.
Upload patch with full context.
Update patch to fix check regressions from recent commits.
Sep 5 2019
I updated a test for testing this new way of division estimations. It's posted at https://github.com/ecnelises/fp-division-test/blob/master/algorithm_test.c so people can do test by their own. Here are my accuracy results:
Sep 3 2019
Sep 2 2019
Update test to reflect changes introduced in rL370071.
Aug 27 2019
Aug 26 2019
Fix typo and rebase.
Aug 22 2019
Aug 18 2019
Rebase to fix regression.
Aug 16 2019
Fix broken LIT tests.
Aug 14 2019
Update patch format.