Page MenuHomePhabricator

qiucf (Qiu Chaofan)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 3 2019, 9:30 PM (119 w, 3 d)

I'm identical to @ecnelises .

Recent Activity

Yesterday

qiucf added inline comments to D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL..
Wed, Jun 16, 11:55 PM · Restricted Project
qiucf added inline comments to D103986: [PowerPC] Floating Point Builtins for XL Compat..
Wed, Jun 16, 11:51 PM · Restricted Project, Restricted Project
qiucf added inline comments to D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility.
Wed, Jun 16, 11:28 PM · Restricted Project, Restricted Project
qiucf added inline comments to D104396: [AIX] Use VSSRC/VSFRC Register classes for f32/f64 callee arguments on P8 and above.
Wed, Jun 16, 11:10 PM · Restricted Project, Restricted Project

Tue, Jun 15

qiucf added a comment to D104247: [DAGCombine] reassoc flag shouldn't enable contract.

Thanks for the patch. It looks reasonable since we've split effect of contract from reassoc (like D89527), and this one does the missing reverse.

Tue, Jun 15, 7:26 PM · Restricted Project

Fri, Jun 11

qiucf committed rGbc104fdcecc0: [PowerPC] Relax register superclasses for paired memops (authored by qiucf).
[PowerPC] Relax register superclasses for paired memops
Fri, Jun 11, 12:06 AM
qiucf closed D104006: [PowerPC] Relax register superclasses for paired memops.
Fri, Jun 11, 12:06 AM · Restricted Project

Thu, Jun 10

qiucf added a comment to D103419: [VectorCombine] Fix alignment in single element store.

Landed. Thanks for the review!

Thu, Jun 10, 7:32 PM · Restricted Project
qiucf committed rG2670c7dd5b25: [VectorCombine] Fix alignment in single element store (authored by qiucf).
[VectorCombine] Fix alignment in single element store
Thu, Jun 10, 7:32 PM
qiucf closed D103419: [VectorCombine] Fix alignment in single element store.
Thu, Jun 10, 7:32 PM · Restricted Project
qiucf updated the diff for D94467: [PowerPC] Use rldimi/rlwimi instructions to optimize build_vector.
Thu, Jun 10, 1:41 AM · Restricted Project

Wed, Jun 9

qiucf updated the diff for D103419: [VectorCombine] Fix alignment in single element store.
Wed, Jun 9, 11:31 PM · Restricted Project
qiucf committed rGa115c5247f5a: [NFC] Pre-commit tests for VectorCombine scalarize (authored by qiucf).
[NFC] Pre-commit tests for VectorCombine scalarize
Wed, Jun 9, 11:29 PM
qiucf committed rG6680538dd0bf: Update my mailmap (authored by qiucf).
Update my mailmap
Wed, Jun 9, 11:15 PM
qiucf requested review of D104006: [PowerPC] Relax register superclasses for paired memops.
Wed, Jun 9, 7:37 PM · Restricted Project
qiucf requested review of D103951: [NFC][Scheduler] Refactor tryCandidate to return boolean.
Wed, Jun 9, 3:07 AM · Restricted Project

Tue, Jun 8

qiucf updated the diff for D103419: [VectorCombine] Fix alignment in single element store.

Add explicit align to affected test.
Add comment for implicit alignment.

Tue, Jun 8, 7:06 PM · Restricted Project
qiucf updated the diff for D103419: [VectorCombine] Fix alignment in single element store.
Tue, Jun 8, 1:38 AM · Restricted Project

Mon, Jun 7

qiucf added inline comments to D103501: [clang][AIX] Enable inlined quadword atomic operations.
Mon, Jun 7, 2:19 AM · Restricted Project
qiucf added inline comments to D103386: [PowerPC] Fix x86 vector intrinsics wrapper compilation under C++.
Mon, Jun 7, 1:50 AM · Restricted Project

Wed, Jun 2

qiucf added inline comments to D103386: [PowerPC] Fix x86 vector intrinsics wrapper compilation under C++.
Wed, Jun 2, 9:51 PM · Restricted Project

Tue, Jun 1

qiucf updated the diff for D103419: [VectorCombine] Fix alignment in single element store.

Add another test (first..)

Tue, Jun 1, 8:37 AM · Restricted Project

Mon, May 31

qiucf requested review of D103419: [VectorCombine] Fix alignment in single element store.
Mon, May 31, 10:40 AM · Restricted Project
qiucf accepted D103259: [PowerPC] Split tests for constrained intrinsics.

LGTM.

Mon, May 31, 10:08 AM · Restricted Project

Sun, May 30

qiucf requested review of D103386: [PowerPC] Fix x86 vector intrinsics wrapper compilation under C++.
Sun, May 30, 10:41 PM · Restricted Project
qiucf planned changes to D94467: [PowerPC] Use rldimi/rlwimi instructions to optimize build_vector.

Will use rldimi/rlwimi instructions to build vector.

Sun, May 30, 8:25 PM · Restricted Project
qiucf added a comment to D98240: [VectorCombine] Simplify to scalar store if only one element updated.

Interesting! I guess the code assumes that a scalar load is always possible & at least as cheap as the vector version. But I think it would make sense to ask the cost-model if that's the case. Not sure if it would be possible to test this with an in-tree target?

Hi thanks for getting back to me. I'm not sure if it's a cost model question, a straight-up disable switch for not morphing vector derefs into scalar might be better? Is there anything else in this pass that might do that? Unfortunately yes, I think there's no proper upstream target with this constraint. Though I am guessing I am not the only downstream target with a vector memory like that. The problem with trying to make this work is that I am worried about what happens to the pointer. Will I always be able to rely on that it will be aligned, probably not...

I guess it depends on whether the backend can legalize/convert back to a vector load. In general, relying on the middle-end to no scalarize those loads for correctness seems a bit fragile. I'm not sure if it makes sense to add a TTI hook that's not used by any in tree targets.

@qiucf would you be able to look into extending the code to check for the cost?

Sun, May 30, 7:10 PM · Restricted Project

Thu, May 27

qiucf commandeered D67694: [Power9] Fix the missing pseudo instruction scheduling information for power9.
Thu, May 27, 10:51 PM · Restricted Project
qiucf added a comment to D103259: [PowerPC] Split tests for constrained intrinsics.

Thanks for the good catch! Actually these IR test are originally copied from X86 and SystemZ's. So they should have similar problem.

Thu, May 27, 10:09 AM · Restricted Project
qiucf updated subscribers of rG5c18d1136665: [SPE] Disable strict-fp for SPE by default.

Hi @tstellar , as https://bugs.llvm.org/show_bug.cgi?id=50385 is a blocking issue for 12.0.1, should this commit be picked into 12.0.1 branch?

Thu, May 27, 9:19 AM
qiucf committed rG5c18d1136665: [SPE] Disable strict-fp for SPE by default (authored by qiucf).
[SPE] Disable strict-fp for SPE by default
Thu, May 27, 9:15 AM
qiucf closed D103235: [SPE] Disable strict-fp for SPE by default.
Thu, May 27, 9:15 AM · Restricted Project
qiucf requested review of D103235: [SPE] Disable strict-fp for SPE by default.
Thu, May 27, 3:37 AM · Restricted Project

Tue, May 18

qiucf accepted D102725: [SDAG] propagate FMF from target-specific IR intrinsics.

LGTM, thanks.

Tue, May 18, 7:16 PM · Restricted Project

May 17 2021

qiucf added a comment to D102443: [PowerPC] Added multiple PowerPC builtins.

Is there any motivation to add these builtins? I don't see them implemented in GCC. Besides, in Clang I think a prefix __builtin is preferred for them.

May 17 2021, 3:05 AM · Restricted Project, Restricted Project
qiucf added inline comments to D90901: [X86] Don't fold (fneg (fma (fneg X), Y, (fneg Z))) to (fma X, Y, Z).
May 17 2021, 2:47 AM · Restricted Project
qiucf added a comment to D102601: [NFC][object] Change the input parameter of the method isDebugSection..

You added implementation of XCOFFObjectFile::isDebugSection, which does not exist before your patch (besides, its implementation is not as 'trivial' as others). Are you sure this is an NFC?

May 17 2021, 2:41 AM · Restricted Project

May 16 2021

qiucf commandeered D86684: [Refactor] Add the SchedHeuristic for Scheduler to allow platform customizing the heuristics.
May 16 2021, 11:01 PM · Restricted Project
qiucf added a comment to D86684: [Refactor] Add the SchedHeuristic for Scheduler to allow platform customizing the heuristics.

I think if the intention is to re-use some generic code in tryCandidate, can we use a lighter approach? For example, make return value type of tryCandidate from void to bool, so that target override can call GenericScheduler::tryCandidate.

May 16 2021, 10:57 PM · Restricted Project

May 12 2021

qiucf added a comment to D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets.

Looks like this is causing failures at https://lab.llvm.org/buildbot/#/builders/76/builds/2422
Please revert.

May 12 2021, 4:21 AM · Restricted Project
qiucf committed rGcbd93cee9bf0: Revert "[PowerPC] [Clang] Enable float128 feature on VSX targets" (authored by qiucf).
Revert "[PowerPC] [Clang] Enable float128 feature on VSX targets"
May 12 2021, 1:57 AM

May 11 2021

qiucf abandoned D80357: [NFC] [PowerPC] Clean-up fast-math options in PPC tests.
May 11 2021, 11:34 PM · Restricted Project
qiucf committed rGfebbe4b5a0ab: [PowerPC] [Clang] Enable float128 feature on VSX targets (authored by qiucf).
[PowerPC] [Clang] Enable float128 feature on VSX targets
May 11 2021, 11:34 PM
qiucf closed D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets.
May 11 2021, 11:34 PM · Restricted Project
qiucf requested verification of rG2db4979c0fe0: [VectorCombine] Simplify to scalar store if only one element updated.
May 11 2021, 10:22 PM
qiucf committed rG6d2df181638a: [VectorComine] Restrict single-element-store index to inbounds constant (authored by qiucf).
[VectorComine] Restrict single-element-store index to inbounds constant
May 11 2021, 10:21 PM
qiucf closed D102146: [VectorComine] Restrict single-element-store index to inbounds constant.
May 11 2021, 10:21 PM · Restricted Project

May 9 2021

qiucf added a comment to rG2db4979c0fe0: [VectorCombine] Simplify to scalar store if only one element updated.

Hi @nlopes , thanks for the notification. I posted a patch to restrict it: D102146

May 9 2021, 7:51 PM
qiucf requested review of D102146: [VectorComine] Restrict single-element-store index to inbounds constant.
May 9 2021, 7:50 PM · Restricted Project

May 8 2021

qiucf abandoned D71828: [InstCombine] Convert vector store to scalar store if only one element updated.

D98240 landed.

May 8 2021, 7:33 PM · Restricted Project
qiucf committed rG2db4979c0fe0: [VectorCombine] Simplify to scalar store if only one element updated (authored by qiucf).
[VectorCombine] Simplify to scalar store if only one element updated
May 8 2021, 3:17 AM
qiucf closed D98240: [VectorCombine] Simplify to scalar store if only one element updated.
May 8 2021, 3:17 AM · Restricted Project

May 6 2021

qiucf committed rGf7294ac8093a: [PowerPC] Remove extra swap for extract+vperm on LE (authored by qiucf).
[PowerPC] Remove extra swap for extract+vperm on LE
May 6 2021, 10:53 PM
qiucf closed D101605: [PowerPC] Remove extra swap for extract+vperm on LE.
May 6 2021, 10:52 PM · Restricted Project
qiucf updated the diff for D98240: [VectorCombine] Simplify to scalar store if only one element updated.

Add more tests.

May 6 2021, 7:46 PM · Restricted Project

Apr 30 2021

qiucf requested review of D101605: [PowerPC] Remove extra swap for extract+vperm on LE.
Apr 30 2021, 1:31 AM · Restricted Project

Apr 29 2021

qiucf committed rGbd48def3e220: Pre-commit test for PPC vector extraction test (authored by qiucf).
Pre-commit test for PPC vector extraction test
Apr 29 2021, 9:04 PM
qiucf committed rG56d923efdb69: [SPE] Support constrained float operations on SPE (authored by qiucf).
[SPE] Support constrained float operations on SPE
Apr 29 2021, 1:34 AM
qiucf closed D101282: [SPE] Support constrained float operations on SPE.
Apr 29 2021, 1:34 AM · Restricted Project

Apr 28 2021

qiucf updated the diff for D98240: [VectorCombine] Simplify to scalar store if only one element updated.

Update tests and store size constraint. Thanks for explanation from @bjope and @fhahn

Apr 28 2021, 9:41 AM · Restricted Project
qiucf committed rGd5c24924552a: [PowerPC] Fix SELECT_CC with i64 operand on PPC32 (authored by qiucf).
[PowerPC] Fix SELECT_CC with i64 operand on PPC32
Apr 28 2021, 2:49 AM

Apr 26 2021

qiucf added a comment to D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets.

Ping...

Apr 26 2021, 8:26 PM · Restricted Project
qiucf updated the diff for D101282: [SPE] Support constrained float operations on SPE.
Apr 26 2021, 3:10 AM · Restricted Project
qiucf requested review of D101282: [SPE] Support constrained float operations on SPE.
Apr 26 2021, 3:08 AM · Restricted Project

Apr 25 2021

qiucf added inline comments to D101209: [PowerPC] Provide fastmath sqrt and div functions in altivec.h.
Apr 25 2021, 9:31 PM · Restricted Project

Apr 22 2021

qiucf added inline comments to D98240: [VectorCombine] Simplify to scalar store if only one element updated.
Apr 22 2021, 2:34 AM · Restricted Project
qiucf updated the diff for D98240: [VectorCombine] Simplify to scalar store if only one element updated.

Address some comments.

Apr 22 2021, 2:34 AM · Restricted Project

Apr 20 2021

qiucf committed rG2432d80d3b54: [PowerPC] Use mtvsrdd to put callee-saved GPR into VSR (authored by qiucf).
[PowerPC] Use mtvsrdd to put callee-saved GPR into VSR
Apr 20 2021, 1:44 AM
qiucf closed D62565: [PowerPC] Exploiting to use mtvsrdd instruction when save called-saved GPR register to VSR registers.
Apr 20 2021, 1:43 AM · Restricted Project, Restricted Project
qiucf committed rGb8203397522f: [PowerPC] Support f128 under VSX (authored by qiucf).
[PowerPC] Support f128 under VSX
Apr 20 2021, 12:50 AM
qiucf closed D92374: [PowerPC] Support f128 under VSX.
Apr 20 2021, 12:50 AM · Restricted Project

Apr 15 2021

qiucf added inline comments to D98240: [VectorCombine] Simplify to scalar store if only one element updated.
Apr 15 2021, 12:50 AM · Restricted Project
qiucf updated the diff for D98240: [VectorCombine] Simplify to scalar store if only one element updated.

Address comments.

Apr 15 2021, 12:50 AM · Restricted Project

Apr 12 2021

qiucf added inline comments to D98240: [VectorCombine] Simplify to scalar store if only one element updated.
Apr 12 2021, 8:10 PM · Restricted Project
qiucf updated the diff for D98240: [VectorCombine] Simplify to scalar store if only one element updated.

Allow non-constant index.

Apr 12 2021, 8:09 PM · Restricted Project
qiucf updated the diff for D92374: [PowerPC] Support f128 under VSX.

Rebase

Apr 12 2021, 12:26 AM · Restricted Project

Apr 11 2021

qiucf added inline comments to D98240: [VectorCombine] Simplify to scalar store if only one element updated.
Apr 11 2021, 11:13 PM · Restricted Project
qiucf updated the diff for D98240: [VectorCombine] Simplify to scalar store if only one element updated.

Address comments

Apr 11 2021, 11:12 PM · Restricted Project
qiucf updated the diff for D98844: [PowerPC] Enable fast-isel on AIX 64 subtarget.

Only include changes to AIX64.

Apr 11 2021, 10:07 PM · Restricted Project
qiucf committed rGece7345859c3: [PowerPC] Lower f128 SETCC/SELECT_CC as libcall if p9vector disabled (authored by qiucf).
[PowerPC] Lower f128 SETCC/SELECT_CC as libcall if p9vector disabled
Apr 11 2021, 7:34 PM
qiucf closed D92083: [PowerPC] Lower f128 SETCC/SELECT_CC as libcall if p9vector disabled.
Apr 11 2021, 7:33 PM · Restricted Project
qiucf updated the summary of D98844: [PowerPC] Enable fast-isel on AIX 64 subtarget.
Apr 11 2021, 7:12 PM · Restricted Project
qiucf added a comment to D98844: [PowerPC] Enable fast-isel on AIX 64 subtarget.

This patch is missing context as well as a description. Can you please add both? It would be good to understand why we want FISEL on AIX. Perhaps some compile-time measurement on some significantly sized code. Also, some notes about how well this was tested would be useful. A different instruction selector is a significant change so it would be good to do some thorough testing at -O0 including some binary compatibility testing (with GCC and/or the system compiler).

Apr 11 2021, 7:08 PM · Restricted Project
qiucf added a comment to D62565: [PowerPC] Exploiting to use mtvsrdd instruction when save called-saved GPR register to VSR registers.

Ping..

Apr 11 2021, 5:40 AM · Restricted Project, Restricted Project

Apr 7 2021

qiucf committed rG033c9c25520c: [PowerPC] Fix use check of swap-reduction (authored by qiucf).
[PowerPC] Fix use check of swap-reduction
Apr 7 2021, 12:58 AM

Apr 6 2021

qiucf added a comment to D93377: [Clang] Add __ibm128 type to represent ppc_fp128.

Ping.. Any further comments?

Apr 6 2021, 7:08 PM · Restricted Project

Apr 1 2021

qiucf added inline comments to D92083: [PowerPC] Lower f128 SETCC/SELECT_CC as libcall if p9vector disabled.
Apr 1 2021, 2:59 AM · Restricted Project
qiucf updated the diff for D92083: [PowerPC] Lower f128 SETCC/SELECT_CC as libcall if p9vector disabled.

Mark BR_CC as expand.

Apr 1 2021, 2:59 AM · Restricted Project

Mar 29 2021

qiucf updated the diff for D92083: [PowerPC] Lower f128 SETCC/SELECT_CC as libcall if p9vector disabled.
Mar 29 2021, 10:50 PM · Restricted Project
qiucf updated the diff for D92374: [PowerPC] Support f128 under VSX.

Change requirement from Altivec to VSX to align with GCC behavior.

Mar 29 2021, 10:43 PM · Restricted Project

Mar 23 2021

qiucf commandeered D92083: [PowerPC] Lower f128 SETCC/SELECT_CC as libcall if p9vector disabled.
Mar 23 2021, 10:32 PM · Restricted Project
qiucf commandeered D92374: [PowerPC] Support f128 under VSX.
Mar 23 2021, 10:30 PM · Restricted Project

Mar 22 2021

qiucf added inline comments to D98003: [obj2yaml] Implement parsing sections and auxiliary entries of XCOFF..
Mar 22 2021, 1:43 AM · Restricted Project

Mar 21 2021

qiucf committed rG52f33f795305: [PowerPC] Enable redundant TOC save removal on AIX (authored by qiucf).
[PowerPC] Enable redundant TOC save removal on AIX
Mar 21 2021, 11:30 PM
qiucf closed D97039: [PowerPC] Enable redundant TOC save removal on AIX.
Mar 21 2021, 11:30 PM · Restricted Project
qiucf added inline comments to D97039: [PowerPC] Enable redundant TOC save removal on AIX.
Mar 21 2021, 11:30 PM · Restricted Project

Mar 18 2021

qiucf requested review of D98844: [PowerPC] Enable fast-isel on AIX 64 subtarget.
Mar 18 2021, 12:34 AM · Restricted Project

Mar 14 2021

qiucf added a comment to D97039: [PowerPC] Enable redundant TOC save removal on AIX.

Gentle ping...

Mar 14 2021, 11:25 PM · Restricted Project
qiucf added a comment to D92374: [PowerPC] Support f128 under VSX.

Since we change the requirement from Altivec to VSX, is this patch still relevant?

Mar 14 2021, 11:12 PM · Restricted Project
qiucf added inline comments to D93377: [Clang] Add __ibm128 type to represent ppc_fp128.
Mar 14 2021, 10:32 PM · Restricted Project