Page MenuHomePhabricator

[PowerPC] Remove unnecessary XSRSP instruction in MI peephole
ClosedPublic

Authored by qiucf on Apr 1 2020, 3:27 AM.

Details

Summary

This is found when looking at test results in D64193. Eliminate xsrsp instruction besides frsp.

Diff Detail

Event Timeline

qiucf created this revision.Apr 1 2020, 3:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2020, 3:27 AM
qiucf added reviewers: nemanjai, jsji, Restricted Project.Apr 1 2020, 3:28 AM
amyk added a subscriber: amyk.Apr 2 2020, 3:35 PM
amyk added inline comments.
llvm/lib/Target/PowerPC/PPCMIPeephole.cpp
543–544

I think it would be good if we also updated the comments and possibly the debug lines to account for the removal of XSRSP.

steven.zhang accepted this revision.Apr 2 2020, 5:46 PM
steven.zhang added a subscriber: steven.zhang.

LGTM as far as you address Amy's comments.

This revision is now accepted and ready to land.Apr 2 2020, 5:46 PM
qiucf marked an inline comment as done.Apr 2 2020, 8:12 PM
This revision was automatically updated to reflect the committed changes.