The concept of strict floating point nodes was added into LLVM in https://reviews.llvm.org/D55506.
This is the third follow-up patch to add constraint fp support about exception part for PowerPC target.
Details
- Reviewers
andrew.w.kaylor kpn steven.zhang hfinkel - Group Reviewers
Restricted Project - Commits
- rGe8d2ff22f09f: [PowerPC] Add fma/fsqrt/fmax strict-fp intrinsics
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Unit tests: pass. 61907 tests passed, 0 failed and 781 were skipped.
clang-tidy: unknown.
clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or applying this patch.
Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml
Please adjust the RUN lines so they do not exceed 80 characters.
llvm/test/CodeGen/PowerPC/fp-strict-fma-f128.ll | ||
---|---|---|
1 ↗ | (On Diff #238174) | Exceeding 80 characters. |
Most of this is in TableGen files, and I have so little experience there that I can't review. I'm sorry.
The test cases have large changes in the generated assembly, but I can't read PowerPC assembly so I don't know what's going on there.
Is there a PowerPC person who can review meaningfully?
llvm/test/CodeGen/PowerPC/fp-strict-fma-f128.ll | ||
---|---|---|
1 ↗ | (On Diff #238174) | I don't think we care about test cases exceeding 80 characters. A quick check shows thousands with just RUN: lines longer than 80. |