Page MenuHomePhabricator

Add more matchers and do cleanups.
ClosedPublic

Authored by djasper on Jul 10 2012, 10:23 AM.

Diff Detail

Event Timeline

klimek added inline comments.Jul 10 2012, 10:50 AM
include/clang/ASTMatchers/ASTMatchers.h
180 ↗(On Diff #6)

Variable naming.

198 ↗(On Diff #6)

Variable naming.

227 ↗(On Diff #6)

Matcher names in the examples.

231 ↗(On Diff #6)

Matcher name.

743 ↗(On Diff #6)

s/Unary/unary/

751 ↗(On Diff #6)

s/Unary/unary/

782 ↗(On Diff #6)

s/PartialMatch/partial match/

783 ↗(On Diff #6)

s/RE/RegExp/

1372 ↗(On Diff #6)

Matcher names.

1386 ↗(On Diff #6)

Matcher names.

1673 ↗(On Diff #6)

Variable naming.

djasper updated this revision to Unknown Object (????).Jul 10 2012, 11:08 AM

Fix naming issues.

include/clang/ASTMatchers/ASTMatchers.h
180 ↗(On Diff #6)

Won't fix.

198 ↗(On Diff #6)

Done.

227 ↗(On Diff #6)

Done.

231 ↗(On Diff #6)

Done.

743 ↗(On Diff #6)

Done.

751 ↗(On Diff #6)

Done.

782 ↗(On Diff #6)

Done.

783 ↗(On Diff #6)

Done.

1372 ↗(On Diff #6)

Done.

1386 ↗(On Diff #6)

Done.

1673 ↗(On Diff #6)

Done.

klimek accepted this revision.Jul 10 2012, 1:10 PM

The patch is borked, but I trust that your client has all the right things :)

include/clang/ASTMatchers/ASTMatchers.h
782 ↗(On Diff #6)

Doesn't parse without the parens... Or just say "partially match"?

djasper updated this revision to Unknown Object (????).Jul 10 2012, 1:14 PM

Hopefully getting the diffs right now!?

djasper updated this revision to Unknown Object (????).Jul 10 2012, 1:18 PM
  • Fix comment.
djasper closed this revision.Jul 10 2012, 1:20 PM

Closed by commit rL160013 (authored by @djasper).