klimek (Manuel Klimek)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 7 2012, 2:55 PM (259 w, 14 h)
Roles
Administrator

Recent Activity

Fri, Jun 23

klimek added inline comments to D34512: [libTooling] Add preliminary Cross Translation Unit support for libTooling.
Fri, Jun 23, 4:38 AM
klimek added reviewers for D34512: [libTooling] Add preliminary Cross Translation Unit support for libTooling: dexonsmith, akyrtzi, benlangmuir, arphaman.

Adding folks interested in the indexing discussion.

Fri, Jun 23, 3:26 AM
klimek added a comment to D34304: Allow CompilerInvocations to generate .d files..

I mean, arguments need to be adjusted before converting to ArgStringList and calling newInvocation? I'm not sure I fully understand the problem, can you elaborate?

This gets back to why the original patch plumbed the boolean all the way down to newInvocation.

newInvocation is the function that actually discards the dependency file options--today unconditionally.

Fri, Jun 23, 1:51 AM

Thu, Jun 22

klimek added a comment to D34512: [libTooling] Add preliminary Cross Translation Unit support for libTooling.

General direction looks good.

Thu, Jun 22, 7:25 AM
klimek accepted D34453: [clang-format] Add a SortUsingDeclaration option and enable it by default..

LG. When you submit, please note the other fixes in the commit message (or make it 2 commits)

Thu, Jun 22, 1:53 AM
klimek added inline comments to D34329: [GSoC] Clang AST diffing.
Thu, Jun 22, 1:31 AM
klimek accepted D34469: Use vfs::FileSystem in ASTUnit when creating CompilerInvocation..

LG

Thu, Jun 22, 1:28 AM
klimek accepted D34470: [clangd] Allow to override resource dir in ClangdServer..

LG

Thu, Jun 22, 1:28 AM · Restricted Project
klimek added a comment to D34304: Allow CompilerInvocations to generate .d files..

I mean, arguments need to be adjusted before converting to ArgStringList and calling newInvocation? I'm not sure I fully understand the problem, can you elaborate?

Thu, Jun 22, 1:09 AM

Wed, Jun 21

klimek accepted D33823: [clang-format] Support sorting using declarations.

lg

Wed, Jun 21, 3:04 AM
klimek accepted D34287: Moved code hanlding precompiled preamble out of the ASTUnit..

lg

Wed, Jun 21, 3:01 AM
klimek added a comment to D34329: [GSoC] Clang AST diffing.

Reviewing this mainly from the API view, and leaving the technical details to others :)

Wed, Jun 21, 12:50 AM

Tue, Jun 20

klimek added inline comments to D34287: Moved code hanlding precompiled preamble out of the ASTUnit..
Tue, Jun 20, 7:41 AM
klimek added inline comments to D34287: Moved code hanlding precompiled preamble out of the ASTUnit..
Tue, Jun 20, 5:46 AM
klimek accepted D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros.

oh, and lg from my side

Tue, Jun 20, 1:00 AM
klimek added a comment to D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros.

how many patches for single file mode are coming down the road, though? I'm somewhat concerned about the overall complexity it'll add to clang.

There is no other patch for using this preprocessor option. Any related improvements down the road will be about general improvements for error recovery, for example things like this:

  • Introduce an UnresolvedTypename type instead of changing unresolved types to int.
  • For @interace A : B, don't completely drop B from the super-class list of A if it is unresolved. These kind of improvements are not conditional.
Tue, Jun 20, 1:00 AM
klimek added a comment to D34304: Allow CompilerInvocations to generate .d files..

I think a better way might be to generally leave dependency options alone, add a default argument adapter to filter out all deps related flags, and allow users to add their own argument adapters that don't do that.

This argument adapter would have to be passed down in a similar way, no?

buildASTFromCodeWithArgs, toolIinvocation::Run, and newInvocation are all entry-points that would need this behavior, and all are called by themselves in one place or another.

Tue, Jun 20, 12:55 AM
klimek added inline comments to D34329: [GSoC] Clang AST diffing.
Tue, Jun 20, 12:16 AM

Mon, Jun 19

klimek added inline comments to D33644: Add default values for function parameter chunks.
Mon, Jun 19, 2:10 AM
klimek added inline comments to D33823: [clang-format] Support sorting using declarations.
Mon, Jun 19, 2:00 AM
klimek added inline comments to D34287: Moved code hanlding precompiled preamble out of the ASTUnit..
Mon, Jun 19, 1:41 AM
klimek added a comment to D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros.

Generally this patch lg from my side - how many patches for single file mode are coming down the road, though? I'm somewhat concerned about the overall complexity it'll add to clang.
When I saw your first patch my reaction was "wow, this works with this little change - cool".
With this patch it's "well, that doesn't seem to add too much complexity, so looks good".
I don't want to realize 5 patches down the line that we're sprinkling all of clang with single file conditional code without some discussion about the strategy with Richard.

Mon, Jun 19, 1:20 AM
klimek added a comment to D34304: Allow CompilerInvocations to generate .d files..

I think a better way might be to generally leave dependency options alone, add a default argument adapter to filter out all deps related flags, and allow users to add their own argument adapters that don't do that.

Mon, Jun 19, 1:12 AM

Wed, Jun 14

klimek added inline comments to D33644: Add default values for function parameter chunks.
Wed, Jun 14, 8:58 AM
klimek added a comment to D33644: Add default values for function parameter chunks.

Ok, now I get it - can you please add tests? This is usually tested by adding a c-index-test based test.

Wed, Jun 14, 6:11 AM
klimek added a comment to D33644: Add default values for function parameter chunks.

Can you give a bit more background what this is trying to do?

Wed, Jun 14, 4:41 AM
klimek accepted D34197: Added Dockerfiles to build clang from sources..

LG

Wed, Jun 14, 4:40 AM
klimek added inline comments to D34197: Added Dockerfiles to build clang from sources..
Wed, Jun 14, 1:15 AM
klimek added a comment to D32480: clang-format: Add CompactNamespaces option.

Generally LG from my side.

Wed, Jun 14, 12:20 AM · Restricted Project

Mon, Jun 12

klimek added a comment to D32480: clang-format: Add CompactNamespaces option.
In D32480#773807, @Typz wrote:

So how do I proceed?

  1. Keep the CompactNamespace option, and make "compacted" namespaces always add at most one level of indentation
  2. Or assume that this can only ever usefully work with the behavior of NI_None and add an additional enum value NI_Compact.
Mon, Jun 12, 8:15 AM · Restricted Project

Wed, Jun 7

klimek accepted D33980: clang-format: [JS] recognize exported type definitions..

lg

Wed, Jun 7, 5:52 AM
klimek added inline comments to D33980: clang-format: [JS] recognize exported type definitions..
Wed, Jun 7, 4:28 AM

Fri, Jun 2

klimek accepted D32403: clang-rename: add new -force option.

lg; sorry for the delay in review

Fri, Jun 2, 1:43 AM

Wed, May 31

klimek accepted D33714: clang-format: [JS] improve calculateBraceType heuristic.

Apart from fixme LG.

Wed, May 31, 2:05 AM

Tue, May 30

klimek added a comment to D32480: clang-format: Add CompactNamespaces option.

I'm less concerned about everything suddenly re-indenting when you change code - if you use any kind of namespace indentation, that's what will happen now and then (and is why many style guides do not indent in namespaces).

Tue, May 30, 4:38 AM · Restricted Project

May 23 2017

klimek accepted D32351: [Tooling][libclang] Remove unused CompilationDatabase::MappedSources.

LG

May 23 2017, 3:22 AM

May 12 2017

klimek added inline comments to D33047: [ClangD] Refactor clangd into separate components.
May 12 2017, 2:25 AM · Restricted Project

May 11 2017

klimek added inline comments to D33047: [ClangD] Refactor clangd into separate components.
May 11 2017, 2:11 AM · Restricted Project

May 5 2017

klimek accepted D32909: [Tooling] Remove redundant check, NFCi.

lg

May 5 2017, 7:14 AM
klimek added a comment to D32351: [Tooling][libclang] Remove unused CompilationDatabase::MappedSources.

Is there a specific reason to take this out? It seems generally useful to allow compilation-db implementors to provide sources.

May 5 2017, 6:18 AM

May 3 2017

klimek accepted D32429: Add capability to format the diff on save to clang-format's vim integration.

Lg

May 3 2017, 11:32 AM
klimek added inline comments to D32403: clang-rename: add new -force option.
May 3 2017, 8:50 AM

Apr 13 2017

klimek added a comment to D31992: [clangd] Escape only necessary characters in JSON output.

Seems that we're starting to hit some YAML/JSON mismatches, or is it that your YAML string support is lacking?

I don't think so. It seems like JSON and YAML are not completely aligned on escaped characters. See http://yaml.org/spec/1.2/spec.html#id2776092 which specifies unicode 8, 16, and 32 bits are escaped with \x, \u, and \U whereas http://www.json.org/string.gif specifies that unicode 16 bit characters can be encoded with \u but \x and \U are not supported. This leads me to believe that a YAML parser can read JSON but a JSON parser will not necessarily be able to read YAML. I thought about using json cpp but that's a much bigger change

Apr 13 2017, 7:21 AM · Restricted Project
klimek added inline comments to D31992: [clangd] Escape only necessary characters in JSON output.
Apr 13 2017, 7:18 AM · Restricted Project

Mar 9 2017

klimek added inline comments to D30777: Added `applyAtomicChanges` function..
Mar 9 2017, 3:33 AM

Mar 8 2017

klimek accepted D30735: Add missing implementation for AtomicChange::replace(...).

lg

Mar 8 2017, 8:02 AM
klimek added a comment to D30650: [clang-tidy] misc-use-after-move: Fix failing assertion.

I think we should refactor this check as part of Static Analyzer, since it's path-sensitive.

Mar 8 2017, 4:24 AM
klimek added a comment to D27810: FileManager: mark virtual file entries as valid entries.

Is the diff view on phab broken, or am I missing something? I only see a single line of diff now, and don't see a way to change the diff.

Mar 8 2017, 3:30 AM

Mar 6 2017

klimek accepted D30636: [analyzer] Fix crash when building CFG with variable of incomplete type.

lg

Mar 6 2017, 1:46 AM

Mar 2 2017

klimek added inline comments to D30532: Add examples to clang-format configuration.
Mar 2 2017, 6:38 AM

Feb 28 2017

klimek accepted D27054: Introducing clang::tooling::AtomicChange for refactoring tools..

lg

Feb 28 2017, 8:34 AM

Feb 27 2017

klimek added a comment to D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded.

Also, do we want to not call ReplaceFile in Path.inc on Win if it potentially leaves temp files lying around?
Reading the code, it looks like we currently actually believe it may fail, and retry with MoveFileEx afterwards...

Feb 27 2017, 7:10 AM
klimek added a comment to D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded.

Can we open the files with FILE_SHARE_DELETE instead?

Feb 27 2017, 7:00 AM
klimek added inline comments to D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded.
Feb 27 2017, 2:03 AM

Feb 23 2017

klimek committed rL295988: Make clang-include-fixer--insert-line work when the difference is on an empty….
Make clang-include-fixer--insert-line work when the difference is on an empty…
Feb 23 2017, 8:14 AM
klimek closed D30292: Make clang-include-fixer--insert-line work when the difference is on an empty line by committing rL295988: Make clang-include-fixer--insert-line work when the difference is on an empty….
Feb 23 2017, 8:14 AM
klimek accepted D30292: Make clang-include-fixer--insert-line work when the difference is on an empty line.

lg

Feb 23 2017, 8:13 AM
klimek added inline comments to D30269: [clang-format] Add a NamespaceEndCommentsFixer.
Feb 23 2017, 12:38 AM

Feb 22 2017

klimek added inline comments to D30210: [include-fixer] Add usage count to find-all-symbols..
Feb 22 2017, 1:48 AM
klimek committed rL295818: Completion related fixes for clang-include-fixer.el..
Completion related fixes for clang-include-fixer.el.
Feb 22 2017, 1:33 AM
klimek closed D30245: Completion-related fixes for clang-include-fixer.el.

Thanks. Landed in r295818

Feb 22 2017, 1:33 AM
klimek accepted D30245: Completion-related fixes for clang-include-fixer.el.

lg

Feb 22 2017, 1:29 AM
klimek closed D30098: clang-include-fixer: Add a hook that's invoked when a new include is added.

Thanks, landed in r295814.

Feb 22 2017, 12:37 AM
klimek committed rL295814: Adds a hook clang-include-fixer-add-include-hook that is invoked with the path….
Adds a hook clang-include-fixer-add-include-hook that is invoked with the path…
Feb 22 2017, 12:37 AM

Feb 20 2017

klimek added inline comments to D30111: [clang-format] Add a test to check at once all the Mozilla coding style.
Feb 20 2017, 1:45 AM

Feb 16 2017

klimek accepted D29943: [clang-format] Align block comment decorations.

lg

Feb 16 2017, 4:46 AM
klimek added inline comments to D29943: [clang-format] Align block comment decorations.
Feb 16 2017, 2:26 AM

Feb 15 2017

klimek accepted D29886: [clangd] Wire up ASTUnit and publish diagnostics with it..

lg

Feb 15 2017, 7:00 AM
klimek added inline comments to D29886: [clangd] Wire up ASTUnit and publish diagnostics with it..
Feb 15 2017, 6:48 AM

Feb 14 2017

klimek added inline comments to D29886: [clangd] Wire up ASTUnit and publish diagnostics with it..
Feb 14 2017, 7:04 AM
klimek added inline comments to D27810: FileManager: mark virtual file entries as valid entries.
Feb 14 2017, 6:34 AM

Feb 8 2017

klimek accepted D29626: [clang-format] Break before a sequence of line comments aligned with the next line..

I'd probably still call it consumeComments or something, as we require a flush afterwards for the unconsumed comments, but I don't feel too strongly about that.

Feb 8 2017, 2:17 AM
klimek added inline comments to D29626: [clang-format] Break before a sequence of line comments aligned with the next line..
Feb 8 2017, 1:38 AM
klimek accepted D29699: [clang-tidy] Add -extra-arg and -extra-arg-before to clang-tidy-diff.py.

lg

Feb 8 2017, 1:14 AM
klimek added inline comments to D29626: [clang-format] Break before a sequence of line comments aligned with the next line..
Feb 8 2017, 1:11 AM

Feb 7 2017

klimek added inline comments to D29626: [clang-format] Break before a sequence of line comments aligned with the next line..
Feb 7 2017, 7:02 AM
klimek added inline comments to D29626: [clang-format] Break before a sequence of line comments aligned with the next line..
Feb 7 2017, 6:26 AM
klimek added a comment to D29626: [clang-format] Break before a sequence of line comments aligned with the next line..

I think this looks pretty good. More comments would help :) Also, organize is spelled with a 'z' in American.

Feb 7 2017, 3:10 AM
klimek added a reviewer for D29221: clang-format-vsix: "format on save" feature: hans.

+1 to "format only current document but save all" not making much sense :)

Feb 7 2017, 2:37 AM
klimek added reviewers for D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks: bkramer, ioeric.
Feb 7 2017, 1:41 AM
klimek added inline comments to D29622: Add a batch query and replace tool based on AST matchers..
Feb 7 2017, 1:38 AM

Feb 3 2017

klimek added inline comments to D29451: Add a prototype for clangd v0.1.
Feb 3 2017, 3:55 AM
klimek accepted D29451: Add a prototype for clangd v0.1.

LG. Couple of questions.

Feb 3 2017, 3:53 AM

Jan 31 2017

klimek accepted D29322: [clang-format] Fix regression merging comments across newlines..

lg minus adding the FIXME to the place where we need the change.

Jan 31 2017, 4:58 AM
klimek accepted D29300: [clang-format] Refactor WhitespaceManager and friends.

lg

Jan 31 2017, 3:24 AM
klimek added inline comments to D29322: [clang-format] Fix regression merging comments across newlines..
Jan 31 2017, 2:45 AM
klimek added a comment to D29300: [clang-format] Refactor WhitespaceManager and friends.

Generally looks like the right direction, minus that I'm not sure yet what the plan for things broken in BreakableToken are.

Jan 31 2017, 1:23 AM

Jan 30 2017

klimek accepted D29271: Revert r293455, which breaks v8 with a spurious error. Testcase added..

lg

Jan 30 2017, 2:47 AM

Jan 25 2017

klimek accepted D28764: [clang-format] Implement comment reflowing (v3).

LG

Jan 25 2017, 6:00 AM
klimek added inline comments to D28764: [clang-format] Implement comment reflowing (v3).
Jan 25 2017, 5:45 AM
klimek added inline comments to D28764: [clang-format] Implement comment reflowing (v3).
Jan 25 2017, 3:38 AM

Jan 24 2017

klimek added inline comments to D28764: [clang-format] Implement comment reflowing (v3).
Jan 24 2017, 8:41 AM
klimek added a comment to D28764: [clang-format] Implement comment reflowing (v3).

This is starting to be pretty awesome. The one thing that would help me review the gist of the implementation a bit more is if that had a bit more comments. Perhaps go over the math in the code and put some comments in why we're doing what at various steps.

Jan 24 2017, 8:14 AM
klimek added inline comments to D28764: [clang-format] Implement comment reflowing (v3).
Jan 24 2017, 4:17 AM

Jan 23 2017

klimek added inline comments to D28764: [clang-format] Implement comment reflowing (v3).
Jan 23 2017, 8:53 AM
klimek added inline comments to D28764: [clang-format] Implement comment reflowing (v3).
Jan 23 2017, 3:40 AM

Jan 20 2017

klimek accepted D28904: Use UTF-8 for all communication with clang-format.

lg; thanks!

Jan 20 2017, 1:46 AM

Jan 17 2017

klimek added a reviewer for D28800: Make sure that clang-format input is in the right encoding: massberg.

Adding Jens as reviewer, as this is quite a bit of elisp :)

Jan 17 2017, 7:09 AM

Jan 11 2017

klimek committed rL291664: Improve include fixer's ranking by taking the paths into account..
Improve include fixer's ranking by taking the paths into account.
Jan 11 2017, 2:43 AM
klimek closed D28548: Improve include fixer's ranking by taking the paths into account. by committing rL291664: Improve include fixer's ranking by taking the paths into account..
Jan 11 2017, 2:43 AM