User Details
- User Since
- Jul 7 2012, 2:55 PM (302 w, 5 d)
- Roles
- Administrator
Today
Is this written down somewhere? https://webkit.org/code-style-guidelines/ doesn't seem to mention it.
Yesterday
LG
Mon, Apr 23
Fri, Apr 20
Address comments.
Tue, Apr 17
lg
Wed, Apr 11
Mon, Apr 9
Jan 16 2018
Just from a formatting point of view, why not:
//. Comment #. define X
Jan 5 2018
Dec 21 2017
Dec 18 2017
I've talked with Daniel and we both believe this patch is not the right way to go forward for clang-format. It is adding configuration mechanisms that we need to maintain going forward, without addressing a general problem; specifically for how to handle macros, I believe there is a clear better way to do it that is also fundamentally more useful than adding extra knobs for every problem we encounter. Finally, these changes do not address a fundamental bug, and workarounds exist, so there is no large benefit to do this now in a non-principled way rather than wait for a more principled fix. Overall, I do understand that this is a trade-off, but I hope you understand that we sometimes have to make decisions.
Dec 13 2017
lg
Dec 11 2017
Dec 8 2017
Dec 6 2017
Dec 4 2017
Dec 1 2017
Add test.
Nov 30 2017
Fix incorrect return value leading to unnecessary computation.
Nov 29 2017
Address review comments.
Nov 28 2017
Address review comments.
LG
Nov 27 2017
LG. Thx!
Restructured to make the invariants clearer based on a chat with Krasimir.
Restructure based on code review feedback.
Self-accepting and closing, as the underlying change has landed, and this diff is incorrect now.
I also have an idea to solve the problem Typz has brought up.
Nov 23 2017
Pull out getRemainingLength.
Address review comments.
Nov 21 2017
Nov 17 2017
Just exporting
Address review comments.
Nov 16 2017
Should that be configured? METADATA seems pretty domain specific ;)
Address review comments.
Nov 15 2017
I think this patch doesn't handle a couple of cases that I'd like to see handled. A counter-proposal with different trade-offs is in D40068.
Nov 14 2017
One interesting trade-off I'm running into:
My gut feeling is that we really want to make local decisions about whether we want to break/reflow - this makes the code significantly simpler (IMO), and handles all tests in this patch correctly, but is fundamentally limiting the global optimizations we can do. Specifically, we would not correctly reflow this:
// |< limit // foo bar // baz // x
to
// foo // bar // baz x
when the excess character limit is low.
Nov 13 2017
Nov 10 2017
- Add test.
LG.