- User Since
- Jul 7 2012, 2:55 PM (266 w, 6 d)
Fri, Aug 11
LG from my side.
Thu, Aug 10
LG, as discussed in person, it's probably a good idea to try to get rid of the non-file-creating version, if possible, or at least fix the comments on the functions to make this behavior clear.
Wed, Aug 9
Tue, Aug 8
Also missing tests :)
High-level question: Why can't we use llvm::ThreadPool?
Mon, Aug 7
Fri, Aug 4
Sorry for missing this - can you add a test?
Thanks! LG after comment change.
Thu, Aug 3
Wed, Aug 2
Just as a general note: adding cfe-commits after the fact is usually not a good idea, as we lose the history of the review in the email list (which is the source of truth).
Why? Also, missing tests.
+Ben who I believe had written a similar function once.
Address review comment.
Tue, Aug 1
Nice catch! lg
Apart from nits, looks OK to me - Eric, are all your concerns addressed?
Fri, Jul 28
Adding Ben as reviewer.
Update to handle hasDeclaration for type alias template decls.
Thu, Jul 27
Tue, Jul 25
Mon, Jul 24
Could we perhaps only suppress the warning when we shadow a variable within the same declcontext? Generally, with macros, shadowing local variables is more surprising.
Your patch description sounds like you're only switching the warning off when the scope ends in a macro, but the patch looks different. For example:
#define M int x
Jul 18 2017
Submitted as r308290.
Jul 17 2017
Jul 14 2017
Jul 12 2017
+Richard, as apparently we get the source ranges for default values of built-in types without the preceding "=", but for user-defined types including the preceding "=" - is that intentional?
Yep, I want Richard's approval for the name. I think he already expressed a pro-pulling-out stance.
Jul 11 2017
Jul 10 2017
Specifically, ping Richard for new top-level lib in clang.
Jul 7 2017
Assuming you're not changing / saving a generated file, I'm wondering whether the real bug is that format-on-save triggers if nothing in the file changed?
Jul 6 2017
+Richard as top-level code owner for new libs.
Jul 5 2017
Jul 4 2017
Jun 30 2017
LG, thx for bearing with me, this looks great.
(and sorry if I didn't send this earlier, just noticed I forgot to hit submit :( )
Jun 29 2017
Jun 28 2017
The main thing I'm concerned about is having the main code in core, but having all tests in tools-extra. I think if we go that route we should also move clang-rename and its tests to core. Thoughts?
Jun 26 2017
Richard (added as reviewer) usually owns decisions around clang itself. Writing an email to cfe-dev with the numbers and wait for whether others have concerns would probably also be good.
Jun 23 2017
Adding folks interested in the indexing discussion.
Jun 22 2017
General direction looks good.
LG. When you submit, please note the other fixes in the commit message (or make it 2 commits)