Page MenuHomePhabricator

klimek (Manuel Klimek)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 7 2012, 2:55 PM (568 w, 4 d)
Roles
Administrator

Recent Activity

Apr 21 2023

klimek added a comment to D146310: [clang-format] Fix dropped 'else' in 398cddf6acec.

Submitted.

Apr 21 2023, 5:00 AM · Restricted Project, Restricted Project, Restricted Project
klimek committed rG9e9e096ae95b: [clang-format] Fix dropped 'else'. (authored by klimek).
[clang-format] Fix dropped 'else'.
Apr 21 2023, 5:00 AM · Restricted Project, Restricted Project
klimek closed D146310: [clang-format] Fix dropped 'else' in 398cddf6acec.
NOTE: Clang-Format Team Automated Review Comment
Apr 21 2023, 5:00 AM · Restricted Project, Restricted Project, Restricted Project

Mar 30 2023

klimek added a comment to D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing.

And thanks a lot for cleaning up, really appreciate it!

Mar 30 2023, 1:59 AM · Restricted Project, Restricted Project, Restricted Project
klimek added a comment to D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing.

I apologize for not tagging appropriately - is that process documented somewhere?

NOTE: Clang-Format Team Automated Review Comment
Mar 30 2023, 1:58 AM · Restricted Project, Restricted Project, Restricted Project

Mar 23 2023

klimek accepted D146310: [clang-format] Fix dropped 'else' in 398cddf6acec.
Mar 23 2023, 1:24 PM · Restricted Project, Restricted Project, Restricted Project
klimek added a comment to D146310: [clang-format] Fix dropped 'else' in 398cddf6acec.

Thanks, yes, I did not intend to delete the else. This only triggers with fuzzing with rather involved inputs, thus I wasn't able to create a nice enough unit test.

Mar 23 2023, 1:15 PM · Restricted Project, Restricted Project, Restricted Project
klimek added a comment to rG398cddf6acec: [clang-format] Fix assertion that doesn't hold under fuzzing..
Mar 23 2023, 1:11 PM · Restricted Project, Restricted Project
klimek updated subscribers of D144170: [clang-format] Add simple macro replacements in formatting..

I am so sorry, thanks for sending out the patch already and fixing the
layout!

Mar 23 2023, 3:48 AM · Restricted Project, Restricted Project, Restricted Project
klimek accepted D146704: [clang-format] NFC Format.h and ClangFormatStyleOptions.rst are out of date.

Thank you!! Sorry for forgetting that I needed to do this, <shamecube>

Mar 23 2023, 3:47 AM · Restricted Project, Restricted Project, Restricted Project

Mar 6 2023

klimek added a comment to D145244: [clang-format] Add ability to trace tokens..

Answering the fundamental design question first.

Mar 6 2023, 2:50 AM · Restricted Project, Restricted Project

Mar 3 2023

klimek updated the diff for D145244: [clang-format] Add ability to trace tokens..

Remove superfluous include.

Mar 3 2023, 7:04 AM · Restricted Project, Restricted Project
klimek requested review of D145244: [clang-format] Add ability to trace tokens..
Mar 3 2023, 6:59 AM · Restricted Project, Restricted Project

Mar 1 2023

klimek committed rGf8d10d5ac9ab: [clang-format][NFC] Refactor formatting unit tests. (authored by klimek).
[clang-format][NFC] Refactor formatting unit tests.
Mar 1 2023, 4:38 AM · Restricted Project, Restricted Project

Feb 27 2023

klimek committed rG398cddf6acec: [clang-format] Fix assertion that doesn't hold under fuzzing. (authored by klimek).
[clang-format] Fix assertion that doesn't hold under fuzzing.
Feb 27 2023, 2:51 AM · Restricted Project, Restricted Project
klimek committed rGf600a5aec52c: [clang-format] Add macro replacement to fuzzing. (authored by klimek).
[clang-format] Add macro replacement to fuzzing.
Feb 27 2023, 2:40 AM · Restricted Project, Restricted Project

Feb 24 2023

klimek committed rG01402831aaae: [clang-format] Add simple macro replacements in formatting. (authored by klimek).
[clang-format] Add simple macro replacements in formatting.
Feb 24 2023, 7:49 AM · Restricted Project, Restricted Project
klimek closed D144170: [clang-format] Add simple macro replacements in formatting..
Feb 24 2023, 7:49 AM · Restricted Project, Restricted Project, Restricted Project
klimek added inline comments to D144170: [clang-format] Add simple macro replacements in formatting..
Feb 24 2023, 7:00 AM · Restricted Project, Restricted Project, Restricted Project
klimek updated the diff for D144170: [clang-format] Add simple macro replacements in formatting..

Address review comments.

Feb 24 2023, 7:00 AM · Restricted Project, Restricted Project, Restricted Project
klimek added inline comments to D144170: [clang-format] Add simple macro replacements in formatting..
Feb 24 2023, 6:20 AM · Restricted Project, Restricted Project, Restricted Project
klimek updated the diff for D144170: [clang-format] Add simple macro replacements in formatting..

Address review comments.

Feb 24 2023, 6:19 AM · Restricted Project, Restricted Project, Restricted Project
klimek added inline comments to D144170: [clang-format] Add simple macro replacements in formatting..
Feb 24 2023, 2:21 AM · Restricted Project, Restricted Project, Restricted Project
klimek updated the diff for D144170: [clang-format] Add simple macro replacements in formatting..

Address review comments.

Feb 24 2023, 2:21 AM · Restricted Project, Restricted Project, Restricted Project

Feb 23 2023

klimek updated the diff for D144170: [clang-format] Add simple macro replacements in formatting..

Add comment.

Feb 23 2023, 2:29 AM · Restricted Project, Restricted Project, Restricted Project
klimek added inline comments to D144170: [clang-format] Add simple macro replacements in formatting..
Feb 23 2023, 2:01 AM · Restricted Project, Restricted Project, Restricted Project
klimek updated the diff for D144170: [clang-format] Add simple macro replacements in formatting..

Address reviewer comments.

Feb 23 2023, 2:01 AM · Restricted Project, Restricted Project, Restricted Project

Feb 16 2023

klimek requested review of D144170: [clang-format] Add simple macro replacements in formatting..
Feb 16 2023, 1:29 AM · Restricted Project, Restricted Project, Restricted Project

Feb 15 2023

klimek committed rG8c1f77af7fd1: [clang-format] Fix windows build. (authored by klimek).
[clang-format] Fix windows build.
Feb 15 2023, 1:03 PM · Restricted Project, Restricted Project
klimek committed rG1995d4424505: [clang-format] Enable FormatTokenSource to insert tokens. (authored by klimek).
[clang-format] Enable FormatTokenSource to insert tokens.
Feb 15 2023, 4:44 AM · Restricted Project, Restricted Project
klimek closed D143070: [clang-format] Enable FormatTokenSource to insert tokens..
Feb 15 2023, 4:43 AM · Restricted Project, Restricted Project, Restricted Project
klimek added inline comments to D143070: [clang-format] Enable FormatTokenSource to insert tokens..
Feb 15 2023, 4:38 AM · Restricted Project, Restricted Project, Restricted Project
klimek updated the diff for D143070: [clang-format] Enable FormatTokenSource to insert tokens..

Address review comments.

Feb 15 2023, 4:38 AM · Restricted Project, Restricted Project, Restricted Project

Feb 14 2023

klimek updated the diff for D143070: [clang-format] Enable FormatTokenSource to insert tokens..

Undo changes to ownership of initial set of FormatTokens.

Feb 14 2023, 1:03 PM · Restricted Project, Restricted Project, Restricted Project
klimek added inline comments to D143070: [clang-format] Enable FormatTokenSource to insert tokens..
Feb 14 2023, 12:57 PM · Restricted Project, Restricted Project, Restricted Project
klimek updated the diff for D143070: [clang-format] Enable FormatTokenSource to insert tokens..

Address reviewer comments.

Feb 14 2023, 12:57 PM · Restricted Project, Restricted Project, Restricted Project

Feb 1 2023

klimek requested review of D143070: [clang-format] Enable FormatTokenSource to insert tokens..
Feb 1 2023, 7:17 AM · Restricted Project, Restricted Project, Restricted Project

Jan 31 2023

klimek added a comment to rG04ed86ff1b72: [clang-format][NFC] Bring FormatTokenSource under test..

And Ben already fixed it.

Jan 31 2023, 12:42 PM · Restricted Project, Restricted Project
klimek updated subscribers of rG04ed86ff1b72: [clang-format][NFC] Bring FormatTokenSource under test..

Working on a fix.

Jan 31 2023, 12:39 PM · Restricted Project, Restricted Project
klimek committed rG04ed86ff1b72: [clang-format][NFC] Bring FormatTokenSource under test. (authored by klimek).
[clang-format][NFC] Bring FormatTokenSource under test.
Jan 31 2023, 8:07 AM · Restricted Project, Restricted Project
klimek committed rGbe31f2c11d47: [clang-format][NFC] Move IndexedTokenSource to FormatTokenSource header. (authored by klimek).
[clang-format][NFC] Move IndexedTokenSource to FormatTokenSource header.
Jan 31 2023, 7:09 AM · Restricted Project, Restricted Project
klimek committed rGc3bc61d72f8d: [clang-format][NFC] Pull FormatTokenSource into its own header. (authored by klimek).
[clang-format][NFC] Pull FormatTokenSource into its own header.
Jan 31 2023, 6:34 AM · Restricted Project, Restricted Project

Nov 28 2022

klimek added a comment to D119138: [clang-format] Further improve support for requires expressions.

For non-functional clean-ups generally llvm doesn't require pre-commit review - I did communicate here so people involved in the original change wouldn't miss the clean-up. I do agree that what commits to pre-review is a fine line, and usually try to err on the side of pre-review; I'll take your feedback into consideration for future changes.

Nov 28 2022, 1:24 AM · Restricted Project, Restricted Project, Restricted Project

Nov 26 2022

klimek added a comment to D119138: [clang-format] Further improve support for requires expressions.

I changed it in 49aca00d63e14df8bc68fc4329e6cbc9c9805eb8.

Nov 26 2022, 10:31 AM · Restricted Project, Restricted Project, Restricted Project
klimek committed rG49aca00d63e1: [NFC] Remove peekNextToken(int). (authored by klimek).
[NFC] Remove peekNextToken(int).
Nov 26 2022, 10:24 AM · Restricted Project, Restricted Project
klimek added a comment to D119138: [clang-format] Further improve support for requires expressions.

Generally, why do we need to have that much information? I.e. why do we need to know the exact type of the "requires" keyword?
I do understand we need to know the brace type, but that seems like it would be easier to figure out in the TokenAnnotator (where we already parsed UnwrappedLines).
Do we ever parse UnwrappedLines differently depending on requires clauses/expressions?
If not, we should really do the annotation in TokenAnnotator, where we already have nice parsing bounds from the parsed UnwrappedLines.

Nov 26 2022, 2:58 AM · Restricted Project, Restricted Project, Restricted Project

Nov 25 2022

Herald added a project to D119138: [clang-format] Further improve support for requires expressions: Restricted Project.

Hey ho, sorry for the late comment here, but adding peekNextToken(n) is problematic, as this gets in the way of future changes we want to do to handle macros better.
Usually we want to use X = Tokens->getPosition() and FormatTok = Tokens->setPosition(X) pairs when doing look-ahead.
I did a quick attempt at fixing this, but ran into infinite loops later in the annotator :(

Nov 25 2022, 7:30 AM · Restricted Project, Restricted Project, Restricted Project
klimek committed rGd65019bbcb0a: [NFC] Clean up printing of UnwrappedLines. (authored by klimek).
[NFC] Clean up printing of UnwrappedLines.
Nov 25 2022, 6:27 AM · Restricted Project, Restricted Project
klimek committed rGca8c6156f270: Fix test output regression from ee88c0cf09969ba44307068797e12533b94768a6. (authored by klimek).
Fix test output regression from ee88c0cf09969ba44307068797e12533b94768a6.
Nov 25 2022, 5:56 AM · Restricted Project, Restricted Project

Sep 21 2022

klimek added a comment to D88299: [clang-format] Add MacroUnexpander..

@sstwcw thanks for pointing it out. See D134329.

Sep 21 2022, 12:32 AM · Restricted Project, Restricted Project, Restricted Project

Jul 18 2022

klimek added a comment to D88299: [clang-format] Add MacroUnexpander..

Thanks! (I was intrigued by Sam's "solves a whole class of clang-format's biggest problems" comment :-))

Jul 18 2022, 12:51 PM · Restricted Project, Restricted Project, Restricted Project
klimek added a comment to D88299: [clang-format] Add MacroUnexpander..

Does this patch change the formatting behaviour of clang-format?

If so, are there any test cases that show before/after formatting? The MacroCallReconstructorTest unit test seems like it's testing an internal interface.

Jul 18 2022, 12:46 PM · Restricted Project, Restricted Project, Restricted Project

Jul 12 2022

klimek committed rGf44d28f840c0: Fix build errors. (authored by klimek).
Fix build errors.
Jul 12 2022, 12:43 AM · Restricted Project, Restricted Project
klimek committed rGd6d0dc1f4537: [clang-format] Add MacroUnexpander. (authored by klimek).
[clang-format] Add MacroUnexpander.
Jul 12 2022, 12:12 AM · Restricted Project, Restricted Project
klimek closed D88299: [clang-format] Add MacroUnexpander..
Jul 12 2022, 12:12 AM · Restricted Project, Restricted Project, Restricted Project

Jul 11 2022

klimek updated the diff for D88299: [clang-format] Add MacroUnexpander..

Address review comments.

Jul 11 2022, 12:57 PM · Restricted Project, Restricted Project, Restricted Project
klimek added inline comments to D88299: [clang-format] Add MacroUnexpander..
Jul 11 2022, 12:48 PM · Restricted Project, Restricted Project, Restricted Project

Jul 5 2022

klimek committed rG4de0680fbf4e: Fix use of pointer arithmetic instead of iterators. (authored by klimek).
Fix use of pointer arithmetic instead of iterators.
Jul 5 2022, 1:26 AM · Restricted Project, Restricted Project

Dec 1 2021

klimek committed rG4dcfae6a003a: Fix a violated precondition in clang-format. (authored by klimek).
Fix a violated precondition in clang-format.
Dec 1 2021, 5:40 AM
klimek committed rGd688b3162800: Fix segfault in clang-format. (authored by klimek).
Fix segfault in clang-format.
Dec 1 2021, 2:58 AM
klimek committed rG597884226094: Fix clang-format bug when handling conflict markers. (authored by klimek).
Fix clang-format bug when handling conflict markers.
Dec 1 2021, 2:23 AM

Nov 26 2021

klimek added a comment to D88299: [clang-format] Add MacroUnexpander..

Noticed I should have waiting with the renaming of the file until the review is done :( Sorry for the extra confusion.

Nov 26 2021, 10:26 AM · Restricted Project, Restricted Project, Restricted Project
klimek updated the diff for D88299: [clang-format] Add MacroUnexpander..

Work in review comments.

Nov 26 2021, 7:32 AM · Restricted Project, Restricted Project, Restricted Project

Nov 24 2021

klimek committed rG1b5a43ac3f11: Clean up clang-format tech debt. (authored by klimek).
Clean up clang-format tech debt.
Nov 24 2021, 3:59 AM
klimek added a comment to D114430: [clang-format] NFC - recent changes caused clang-format to no longer be clang-formatted..

Thanks for cleaning up after me, and sorry for the mess - do y'all have clang-format set up as a presubmit or do you just remember to format manually?

Nov 24 2021, 3:25 AM · Restricted Project, Restricted Project

Nov 22 2021

klimek added inline comments to rG84bf5e328664: Fix various problems found by fuzzing..
Nov 22 2021, 2:47 AM
klimek committed rG84bf5e328664: Fix various problems found by fuzzing. (authored by klimek).
Fix various problems found by fuzzing.
Nov 22 2021, 2:10 AM

Nov 19 2021

klimek committed rGc2271926a4fc: Make clang-format fuzz through Lexing with asserts enabled. (authored by klimek).
Make clang-format fuzz through Lexing with asserts enabled.
Nov 19 2021, 5:44 AM

Aug 9 2021

klimek added a comment to D69764: [clang-format] Add Left/Right Const fixer capability.

I was referring to @rsmith and @aaron.ballman (to clarify), both are maintainers in 'clang', the former of which is the 'superset' maintainer of this format project based on its directory. While Aaron is a peer-maintainer to this project, his contributions are immense, and his points are too-well-reasoned and motivated to be dismissed.

Just so we are clear I'm not dismissing anyone opinions, @arron.ballman and I have been going at this quite a bit both on and off list. I have huge respect for these people, (even if the defence of my review it might not seem so). I can't even think to emulate their contributions.

Ideally I'd like their blessing, but alas I fear that might be beyond my capabilities, but if there are things like the RFC that could even go some way to potentially them seeing a way forward that is mutually beneficial so that the door is even open a jar for this then I'm happy to try.

If ultimately the answer is "no" then I need to understand what can be done if anything, if that means a new tool then I'm ok with that as the compromise. Out right dismissal, I would be very sorry to see.

Here are my thoughts put in one place.

0) I like the idea of being able to format qualifier location, and I think clang-format is the tool I would reach for to perform that work
.33) I wish this was generalized to handle all qualifiers rather than just const. (This is not a blocking wish.)
.66) I wish this used "left" and "right" rather than "east" and "west" for user-facing options and documentation. (This is Very Strong wish but I won't block the patch over it.)

  1. In general, I do not like the idea of my code formatting tool having opinions about the input source's existing formatting (I think valid code should remain valid). This is the area of concern causing me to ask for an RFC because I'm operating under the impression that not breaking code is (generally) the status quo for clang-format.
  2. If the community consensus is that formatting can break code (blanket permission, case by case basis, whatever), I'll definitely abide by that decision. I just want it to be an explicit decision from a wider audience than people who might be following this very long-running patch.
  3. The proposed opt-in nature of the check is a blessing and a curse. It alleviates some of the danger (it's not dangerous by default, you have to manually say you want it). But it doesn't eliminate the danger (code can still be broken) and it does raise the question of how often people opt into this sort of thing and whether it's worth the maintenance costs. I don't think any of us can answer those "do people opt in" questions though, so that's not a concern I think we should hold anything up over unless someone has actual data on usage of opt-in features for clang-format. I think opt-in alleviates enough of the danger that it's a worthwhile approach for this patch (and likely may be a good idea for a policy on future changes of the same kind).

tl;dr: if there's an RFC and the community says "breaking changes aren't that big of a deal to us", it tips me from "against" to "in favor" for this functionality.

Aug 9 2021, 11:00 AM · Restricted Project, Restricted Project
klimek added a comment to D69764: [clang-format] Add Left/Right Const fixer capability.

@steveire, thanks for your comments, I also agree that a second tool shouldn't be needed, especially as this functionality is off by default (and needs to stay that way). This was my suggestion for a compromise.

Its a tough call, but ultimately no on ever gave this a LGTM so I couldn't proceed anyway. Whilst I think we can cover the other qualifiers with a similar approach I don't want to waste more of my time until the fundamental question has been answered if its ok for clang-format to insert/modify the order of tokens and that is more a collective decision.

It was suggested to me that I write up and RFC on the matter, I'm not a massive fan of those as I don't really see a formal process for handling them (the conversation seems to turn into a series of personal preferences then dwindles and dies without conclusion). But if people think it would solve something I guess I could try.

From my perspective I'm more interested in the views of the major clang-format contributors (@curdeius, @krasimir, @owenpan , @sammccall, @HazardyKnusperkeks and people like yourselves who have put time and effort into blogging about these tools), ultimately it will be us who have to handle the impact of this (and maybe the #clangd people) and I don't want to inconvenience them or make work for them.

So here is what is needed to land this in my view:

  1. I'd want at least 2 to 3 of the current reviewers to LGTM.
  2. I'd want 1 person (like yourself) a community contributor to also give their approval (I guess I have that conceptually from you!)

or

  1. @klimek or @djasper to give us an its ok for "clang-format to insert/modify the order of tokens" in a controlled manner decision
  2. 1 LGTM

Whilst I respect the views of those few who have objected, they don't to my knowledge make significant contributions to clang-format (not in the last 5-6 years I've been following it anyway)

I feel this team owns the decision as we are the ones that look after it, warts and all. We'll always have a situation where some don't agree, thats ok, but I feel there is more agreement that this funcationality is ok rather than not.

Until one of those 2 things happens, we are in limbo.

Aug 9 2021, 4:00 AM · Restricted Project, Restricted Project

Feb 8 2021

klimek added a comment to D96114: [ASTMatchers] Fix parent-child traversal between functions and parms.

Can you explain the change and the before/after a bit more? Thanks!

Feb 8 2021, 1:01 AM · Restricted Project

Nov 26 2020

klimek added a comment to D91996: [clang-format] Remove double trim.

Isn't the comment incorrect after this patch?

Nov 26 2020, 1:01 AM · Restricted Project, Restricted Project

Oct 28 2020

klimek added inline comments to D88299: [clang-format] Add MacroUnexpander..
Oct 28 2020, 5:37 AM · Restricted Project, Restricted Project, Restricted Project
klimek updated the diff for D88299: [clang-format] Add MacroUnexpander..

Adapted based on review comments.

Oct 28 2020, 5:37 AM · Restricted Project, Restricted Project, Restricted Project

Oct 22 2020

klimek accepted D89920: Export TemplateArgumentMatcher so clients defining custom matchers don't need to use the internal namespace.

lg

Oct 22 2020, 12:53 AM · Restricted Project

Oct 7 2020

klimek accepted D88952: [clang-format][tests] Fix MacroExpander lexer not parsing C++ keywords.

Nice catch, thanks! LG!

Oct 7 2020, 6:00 AM · Restricted Project
klimek added inline comments to D88956: [clang-format] Fix misformatted macro definitions after D86959.
Oct 7 2020, 5:59 AM · Restricted Project
klimek added inline comments to D88956: [clang-format] Fix misformatted macro definitions after D86959.
Oct 7 2020, 5:28 AM · Restricted Project

Sep 29 2020

klimek added a comment to D83296: [clang-format] Add a MacroExpander..

What does this change mean for users of clang-format -- better formatting of complicated (e.g. multi-line) macro invocations?

Sep 29 2020, 12:32 AM · Restricted Project, Restricted Project

Sep 28 2020

klimek added a comment to D84306: [clang-format][NFC] Be more careful about the layout of FormatToken..

Which bit do you find more complex? adding something to the FormatToken or the use of the is() calls?

Sep 28 2020, 4:44 AM · Restricted Project, Restricted Project

Sep 25 2020

klimek requested review of D88299: [clang-format] Add MacroUnexpander..
Sep 25 2020, 6:28 AM · Restricted Project, Restricted Project, Restricted Project
klimek committed rGe336b74c995d: [clang-format] Add a MacroExpander. (authored by klimek).
[clang-format] Add a MacroExpander.
Sep 25 2020, 5:09 AM
klimek closed D83296: [clang-format] Add a MacroExpander..
Sep 25 2020, 5:09 AM · Restricted Project, Restricted Project
klimek added a comment to D84306: [clang-format][NFC] Be more careful about the layout of FormatToken..

FWIW, finding this due to seeing the added complexity. Do you have data on what the difference is on clang-format for either overall memory use or performance? Thanks!

Sep 25 2020, 4:43 AM · Restricted Project, Restricted Project

Sep 19 2020

klimek added inline comments to D83296: [clang-format] Add a MacroExpander..
Sep 19 2020, 9:23 AM · Restricted Project, Restricted Project
klimek updated the diff for D83296: [clang-format] Add a MacroExpander..

Worked in review comments.

Sep 19 2020, 9:23 AM · Restricted Project, Restricted Project

Aug 20 2020

klimek added inline comments to D83296: [clang-format] Add a MacroExpander..
Aug 20 2020, 2:32 AM · Restricted Project, Restricted Project

Aug 19 2020

klimek added inline comments to D83296: [clang-format] Add a MacroExpander..
Aug 19 2020, 9:26 AM · Restricted Project, Restricted Project

Jul 29 2020

klimek added inline comments to D83296: [clang-format] Add a MacroExpander..
Jul 29 2020, 8:37 AM · Restricted Project, Restricted Project
klimek updated the diff for D83296: [clang-format] Add a MacroExpander..

Addressed code review comments.

Jul 29 2020, 8:34 AM · Restricted Project, Restricted Project

Jul 13 2020

klimek added a comment to D83296: [clang-format] Add a MacroExpander..

Monday-morning ping.

Thanks for the reminder here... however this is taking me a bit to get my head around, and we've got a release branch cut scheduled for a couple of days that we're trying to polish for.
AFAICT there's significant followup work still needed to make use of this - are you wanting this to land in the 11 release? Else i'd probably come back to this after the cut...

Jul 13 2020, 4:15 AM · Restricted Project, Restricted Project
klimek added a comment to D83296: [clang-format] Add a MacroExpander..

Monday-morning ping.

Jul 13 2020, 3:03 AM · Restricted Project, Restricted Project
klimek updated subscribers of D83621: [clang][Tooling] Try to avoid file system access if there is no record for the file in compile_commads.json.

@djasper wrote this iirc, but I doubt he'll have much time to look into this :)

Jul 13 2020, 2:04 AM · Restricted Project

Jul 9 2020

klimek added inline comments to D79773: [clang-format] Improve clang-formats handling of concepts.
Jul 9 2020, 4:32 AM · Restricted Project, Restricted Project

Jul 7 2020

Herald added a project to D83296: [clang-format] Add a MacroExpander.: Restricted Project.
Jul 7 2020, 4:54 AM · Restricted Project, Restricted Project
klimek committed rG8c2a61397607: Hand Allocator and IdentifierTable into FormatTokenLexer. (authored by klimek).
Hand Allocator and IdentifierTable into FormatTokenLexer.
Jul 7 2020, 3:01 AM
klimek closed D83218: Hand Allocator and IdentifierTable into FormatTokenLexer..
Jul 7 2020, 3:00 AM · Restricted Project
klimek updated the diff for D83218: Hand Allocator and IdentifierTable into FormatTokenLexer..

Address review comment.

Jul 7 2020, 2:53 AM · Restricted Project

Jul 6 2020

Herald added a project to D83218: Hand Allocator and IdentifierTable into FormatTokenLexer.: Restricted Project.
Jul 6 2020, 5:46 AM · Restricted Project

Jul 3 2020

klimek accepted D83076: Revert AST Matchers default to AsIs mode.

lg

Jul 3 2020, 1:03 AM · Restricted Project