klimek (Manuel Klimek)
User

Projects

User does not belong to any projects.
User Since
Jul 7 2012, 2:55 PM (246 w, 13 h)
Roles
Administrator

Recent Activity

Thu, Mar 9

klimek added inline comments to D30777: Added `applyAtomicChanges` function..
Thu, Mar 9, 3:33 AM

Wed, Mar 8

klimek accepted D30735: Add missing implementation for AtomicChange::replace(...).

lg

Wed, Mar 8, 8:02 AM
klimek added a comment to D30650: [clang-tidy] misc-use-after-move: Fix failing assertion.

I think we should refactor this check as part of Static Analyzer, since it's path-sensitive.

Wed, Mar 8, 4:24 AM
klimek added a comment to D27810: FileManager: mark virtual file entries as valid entries.

Is the diff view on phab broken, or am I missing something? I only see a single line of diff now, and don't see a way to change the diff.

Wed, Mar 8, 3:30 AM

Mon, Mar 6

klimek accepted D30636: [analyzer] Fix crash when building CFG with variable of incomplete type.

lg

Mon, Mar 6, 1:46 AM

Thu, Mar 2

klimek added inline comments to D30532: Add examples to clang-format configuration.
Thu, Mar 2, 6:38 AM

Tue, Feb 28

klimek accepted D27054: Introducing clang::tooling::AtomicChange for refactoring tools..

lg

Tue, Feb 28, 8:34 AM

Mon, Feb 27

klimek added a comment to D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded.

Also, do we want to not call ReplaceFile in Path.inc on Win if it potentially leaves temp files lying around?
Reading the code, it looks like we currently actually believe it may fail, and retry with MoveFileEx afterwards...

Mon, Feb 27, 7:10 AM
klimek added a comment to D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded.

Can we open the files with FILE_SHARE_DELETE instead?

Mon, Feb 27, 7:00 AM
klimek added inline comments to D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded.
Mon, Feb 27, 2:03 AM

Feb 23 2017

klimek committed rL295988: Make clang-include-fixer--insert-line work when the difference is on an empty….
Make clang-include-fixer--insert-line work when the difference is on an empty…
Feb 23 2017, 8:14 AM
klimek closed D30292: Make clang-include-fixer--insert-line work when the difference is on an empty line by committing rL295988: Make clang-include-fixer--insert-line work when the difference is on an empty….
Feb 23 2017, 8:14 AM
klimek accepted D30292: Make clang-include-fixer--insert-line work when the difference is on an empty line.

lg

Feb 23 2017, 8:13 AM
klimek added inline comments to D30269: [clang-format] Add a NamespaceEndCommentsFixer.
Feb 23 2017, 12:38 AM

Feb 22 2017

klimek added inline comments to D30210: [include-fixer] Add usage count to find-all-symbols..
Feb 22 2017, 1:48 AM
klimek committed rL295818: Completion related fixes for clang-include-fixer.el..
Completion related fixes for clang-include-fixer.el.
Feb 22 2017, 1:33 AM
klimek closed D30245: Completion-related fixes for clang-include-fixer.el.

Thanks. Landed in r295818

Feb 22 2017, 1:33 AM
klimek accepted D30245: Completion-related fixes for clang-include-fixer.el.

lg

Feb 22 2017, 1:29 AM
klimek closed D30098: clang-include-fixer: Add a hook that's invoked when a new include is added.

Thanks, landed in r295814.

Feb 22 2017, 12:37 AM
klimek committed rL295814: Adds a hook clang-include-fixer-add-include-hook that is invoked with the path….
Adds a hook clang-include-fixer-add-include-hook that is invoked with the path…
Feb 22 2017, 12:37 AM

Feb 20 2017

klimek added inline comments to D30111: [clang-format] Add a test to check at once all the Mozilla coding style.
Feb 20 2017, 1:45 AM

Feb 16 2017

klimek accepted D29943: [clang-format] Align block comment decorations.

lg

Feb 16 2017, 4:46 AM
klimek added inline comments to D29943: [clang-format] Align block comment decorations.
Feb 16 2017, 2:26 AM

Feb 15 2017

klimek accepted D29886: [clangd] Wire up ASTUnit and publish diagnostics with it..

lg

Feb 15 2017, 7:00 AM
klimek added inline comments to D29886: [clangd] Wire up ASTUnit and publish diagnostics with it..
Feb 15 2017, 6:48 AM

Feb 14 2017

klimek added inline comments to D29886: [clangd] Wire up ASTUnit and publish diagnostics with it..
Feb 14 2017, 7:04 AM
klimek added inline comments to D27810: FileManager: mark virtual file entries as valid entries.
Feb 14 2017, 6:34 AM

Feb 8 2017

klimek accepted D29626: [clang-format] Break before a sequence of line comments aligned with the next line..

I'd probably still call it consumeComments or something, as we require a flush afterwards for the unconsumed comments, but I don't feel too strongly about that.

Feb 8 2017, 2:17 AM
klimek added inline comments to D29626: [clang-format] Break before a sequence of line comments aligned with the next line..
Feb 8 2017, 1:38 AM
klimek accepted D29699: [clang-tidy] Add -extra-arg and -extra-arg-before to clang-tidy-diff.py.

lg

Feb 8 2017, 1:14 AM
klimek added inline comments to D29626: [clang-format] Break before a sequence of line comments aligned with the next line..
Feb 8 2017, 1:11 AM

Feb 7 2017

klimek added inline comments to D29626: [clang-format] Break before a sequence of line comments aligned with the next line..
Feb 7 2017, 7:02 AM
klimek added inline comments to D29626: [clang-format] Break before a sequence of line comments aligned with the next line..
Feb 7 2017, 6:26 AM
klimek added a comment to D29626: [clang-format] Break before a sequence of line comments aligned with the next line..

I think this looks pretty good. More comments would help :) Also, organize is spelled with a 'z' in American.

Feb 7 2017, 3:10 AM
klimek added a reviewer for D29221: clang-format-vsix: "format on save" feature: hans.

+1 to "format only current document but save all" not making much sense :)

Feb 7 2017, 2:37 AM
klimek added reviewers for D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks: bkramer, ioeric.
Feb 7 2017, 1:41 AM
klimek added inline comments to D29622: Add a batch query and replace tool based on AST matchers..
Feb 7 2017, 1:38 AM

Feb 3 2017

klimek added inline comments to D29451: Add a prototype for clangd v0.1.
Feb 3 2017, 3:55 AM
klimek accepted D29451: Add a prototype for clangd v0.1.

LG. Couple of questions.

Feb 3 2017, 3:53 AM

Jan 31 2017

klimek accepted D29322: [clang-format] Fix regression merging comments across newlines..

lg minus adding the FIXME to the place where we need the change.

Jan 31 2017, 4:58 AM
klimek accepted D29300: [clang-format] Refactor WhitespaceManager and friends.

lg

Jan 31 2017, 3:24 AM
klimek added inline comments to D29322: [clang-format] Fix regression merging comments across newlines..
Jan 31 2017, 2:45 AM
klimek added a comment to D29300: [clang-format] Refactor WhitespaceManager and friends.

Generally looks like the right direction, minus that I'm not sure yet what the plan for things broken in BreakableToken are.

Jan 31 2017, 1:23 AM

Jan 30 2017

klimek accepted D29271: Revert r293455, which breaks v8 with a spurious error. Testcase added..

lg

Jan 30 2017, 2:47 AM

Jan 25 2017

klimek accepted D28764: [clang-format] Implement comment reflowing (v3).

LG

Jan 25 2017, 6:00 AM
klimek added inline comments to D28764: [clang-format] Implement comment reflowing (v3).
Jan 25 2017, 5:45 AM
klimek added inline comments to D28764: [clang-format] Implement comment reflowing (v3).
Jan 25 2017, 3:38 AM

Jan 24 2017

klimek added inline comments to D28764: [clang-format] Implement comment reflowing (v3).
Jan 24 2017, 8:41 AM
klimek added a comment to D28764: [clang-format] Implement comment reflowing (v3).

This is starting to be pretty awesome. The one thing that would help me review the gist of the implementation a bit more is if that had a bit more comments. Perhaps go over the math in the code and put some comments in why we're doing what at various steps.

Jan 24 2017, 8:14 AM
klimek added inline comments to D28764: [clang-format] Implement comment reflowing (v3).
Jan 24 2017, 4:17 AM

Jan 23 2017

klimek added inline comments to D28764: [clang-format] Implement comment reflowing (v3).
Jan 23 2017, 8:53 AM
klimek added inline comments to D28764: [clang-format] Implement comment reflowing (v3).
Jan 23 2017, 3:40 AM

Jan 20 2017

klimek accepted D28904: Use UTF-8 for all communication with clang-format.

lg; thanks!

Jan 20 2017, 1:46 AM

Jan 17 2017

klimek added a reviewer for D28800: Make sure that clang-format input is in the right encoding: massberg.

Adding Jens as reviewer, as this is quite a bit of elisp :)

Jan 17 2017, 7:09 AM

Jan 11 2017

klimek committed rL291664: Improve include fixer's ranking by taking the paths into account..
Improve include fixer's ranking by taking the paths into account.
Jan 11 2017, 2:43 AM
klimek closed D28548: Improve include fixer's ranking by taking the paths into account. by committing rL291664: Improve include fixer's ranking by taking the paths into account..
Jan 11 2017, 2:43 AM
klimek retitled D28548: Improve include fixer's ranking by taking the paths into account. from to Improve include fixer's ranking by taking the paths into account..
Jan 11 2017, 1:59 AM

Jan 10 2017

klimek committed rL291653: Only launch asynchronously if threading is enabled..
Only launch asynchronously if threading is enabled.
Jan 10 2017, 11:31 PM

Jan 9 2017

klimek added a reviewer for D28260: Add an argumentsAre matcher: bkramer.

+benjamin

Jan 9 2017, 2:13 AM
klimek accepted D28465: clang-format: [JS] ASI after imports.

LG

Jan 9 2017, 1:06 AM

Dec 21 2016

klimek added inline comments to D27971: Make FormatStyle.GetStyleOfFile test work on MSVC .
Dec 21 2016, 4:16 AM
klimek accepted D27971: Make FormatStyle.GetStyleOfFile test work on MSVC .

Apart from the error handling LG. Thanks!

Dec 21 2016, 12:24 AM

Dec 20 2016

klimek added a comment to D27971: Make FormatStyle.GetStyleOfFile test work on MSVC .

Why isn't the right solution to make getStyle() use vfs::FileSystem? Generally, everything in clang-format (well, in clang) should use vfs::FileSystem for file access.

Dec 20 2016, 1:10 AM

Dec 19 2016

klimek added a comment to D27440: clang-format-vsix: fail when clang-format outputs to stderr.

llvm::ErrorOr carries std::error_code. If you want richer information (e.g. error_code + error message), llvm::Expcted<T> and llvm::Error are your friends.

FYI, if you only need error_code + error_message in the returned error, there is also llvm::StringError. And if you want to carry even more information in the errors, you can implement llvm::ErrorInfo, which is what we are doing in libTooling replacements library: https://github.com/llvm-mirror/clang/blob/master/include/clang/Tooling/Core/Replacement.h#L150

Thanks, I'll check these out! Btw, I noticed that the clang-format tests are non-Windows due to path assumptions. Is this a lost cause, or just something no one's bothered to look into yet?

Dec 19 2016, 7:25 AM
klimek added a reviewer for D27440: clang-format-vsix: fail when clang-format outputs to stderr: ioeric.

+eric, who has some experience llvm::Error'ing our interfaces :)
llvm::ErrorOr seems like the right approach here?

Dec 19 2016, 1:13 AM

Dec 14 2016

klimek added inline comments to D27754: [clang-format] Implement comment reflowing (again)..
Dec 14 2016, 8:37 AM
klimek added inline comments to D27754: [clang-format] Implement comment reflowing (again)..
Dec 14 2016, 6:59 AM

Dec 12 2016

klimek accepted D27501: clang-format-vsix: add command to format document.

LG. I also think it makes the code nicer by breaking out the right functions. Thanks!

Dec 12 2016, 6:54 AM
klimek accepted D27557: Update the default of the Mozilla coding style.

lg

Dec 12 2016, 5:45 AM

Dec 8 2016

klimek accepted D27447: [ASTMatcher] Add hasReplacementType matcher for SubstTemplateTypeParmType.

Looks good. Thanks!

Dec 8 2016, 3:00 AM
klimek added inline comments to D27501: clang-format-vsix: add command to format document.
Dec 8 2016, 2:21 AM

Dec 6 2016

klimek added a reviewer for D27440: clang-format-vsix: fail when clang-format outputs to stderr: djasper.

Adding djasper, who had brought forward the idea.

Dec 6 2016, 7:38 AM
klimek accepted D27140: Allow clang to write compilation database records.

LG. We can always add more intricate ways later on.

Dec 6 2016, 2:09 AM
klimek added a comment to D27440: clang-format-vsix: fail when clang-format outputs to stderr.

Pondering this a bit - one question is whether we should make clang-format not return 0 if we pass -fallback-style=none (it already has this option) and we can't figure out a style. What do you think?

Dec 6 2016, 1:55 AM
klimek added inline comments to D27447: [ASTMatcher] Add hasReplacementType matcher for SubstTemplateTypeParmType.
Dec 6 2016, 1:51 AM

Dec 5 2016

klimek accepted D27350: CFGBuilder: Fix crash when visiting delete expression on dependent type.

lg

Dec 5 2016, 2:56 AM

Dec 1 2016

klimek committed rL288366: Adds hasUnqualifiedDesugaredType to allow matching through type sugar..
Adds hasUnqualifiedDesugaredType to allow matching through type sugar.
Dec 1 2016, 7:55 AM
klimek closed D27207: Adds hasUnqualifiedDesugaredType to allow matching through type sugar. by committing rL288366: Adds hasUnqualifiedDesugaredType to allow matching through type sugar..
Dec 1 2016, 7:55 AM
klimek added a comment to D27207: Adds hasUnqualifiedDesugaredType to allow matching through type sugar..

I added a test for multi-stage desugaring. Generally, we want to model Clang's AST where it makes sense. The AST has a getUnqualifiedDesugaredType, thus the matcher as it is is expected. We can add single step desugaring or hasAnyDeclaration or similar things when they are actually needed.

Dec 1 2016, 4:00 AM
klimek accepted D27138: Extend CompilationDatabase by a field for the output filename.

Which struct are we talking about, CompileCommandRef or CompileCommand? It is a pointer in the former and a plain StringRef in the latter. I don't think making it a pointer in both is an advantage, i.e. distinguishing empty input from missing field is not valuable in my opinion.

Dec 1 2016, 3:52 AM
klimek updated the diff for D27207: Adds hasUnqualifiedDesugaredType to allow matching through type sugar..

Add multi-level using test.

Dec 1 2016, 3:44 AM

Nov 30 2016

klimek added inline comments to D27054: Introducing clang::tooling::AtomicChange for refactoring tools..
Nov 30 2016, 4:41 AM

Nov 29 2016

klimek added a comment to D27207: Adds hasUnqualifiedDesugaredType to allow matching through type sugar..

How about using hasUnqualifiedDesugaredType(recordType(hasDeclaration instead?

Nov 29 2016, 10:48 PM
klimek added a comment to D27138: Extend CompilationDatabase by a field for the output filename.

It's not the directory, but the output file. That's optional since it is a new addition and I don't want to invalidate all existing JSON databases.

Nov 29 2016, 6:44 AM
klimek added a comment to D27211: [clang-format] Implement comment reflowing.

for these cases the
original Breakable{Line,Block}Comment still breaks the long lines.

Nov 29 2016, 6:14 AM
klimek added inline comments to D27138: Extend CompilationDatabase by a field for the output filename.
Nov 29 2016, 5:28 AM
klimek added a comment to D27181: [ASTImporter] Support for importing UsingDecl and UsingShadowDecl.

Can you add a test to ASTMatchersNodeTests.cpp? Otherwise LG for the matcher parts.

Nov 29 2016, 5:27 AM
klimek added reviewers for D27140: Allow clang to write compilation database records: bkramer, akyrtzi.

Adding some folks. One question is whether we can use the additional output stuff doug added at some point for this.

Nov 29 2016, 5:24 AM
klimek retitled D27207: Adds hasUnqualifiedDesugaredType to allow matching through type sugar. from to Adds hasUnqualifiedDesugaredType to allow matching through type sugar..
Nov 29 2016, 5:23 AM
klimek added a comment to D27104: Unify and simplify the behavior of the hasDeclaration matcher..

Forcing shallow matching means that unit test below will stop passing after this CL.

TEST(HasDeclaration, DeepTagType) {
  std::string input =
      "class Foo {};\n"
      "using Bar = Foo;\n"
      "void Function(Bar param) {}\n";
 
  // Matcher for declaration of the Foo class.
  auto param_type_decl_matcher = cxxRecordDecl(hasName("Foo"));
 
  // hasDeclaration / qualType-flavour.
  EXPECT_TRUE(matches(input, parmVarDecl(
      hasName("param"),
      hasType(qualType(hasDeclaration(decl(param_type_decl_matcher)))))));
}

I am working on a tool that renames methods in a specific namespace - the tool depends on hasDeclaration doing deep-matching to tell whether an UnresolvedUsingValueDecl and/or CXXDependentScopeMemberExpr end up pointing at a record or template from the namespace of interest.

Q1: I assume that the breaking aspect of this CL is understood and accepted?

Nov 29 2016, 3:23 AM
klimek updated the diff for D27104: Unify and simplify the behavior of the hasDeclaration matcher..

Add tests, update hasDeclaration to work for ElaboratedType.

Nov 29 2016, 3:18 AM

Nov 28 2016

klimek accepted D27164: Removed DEBUG_TYPE from TokenAnalyzer.h.

LG

Nov 28 2016, 7:39 AM
klimek added inline comments to D27138: Extend CompilationDatabase by a field for the output filename.
Nov 28 2016, 7:38 AM
klimek added inline comments to D27138: Extend CompilationDatabase by a field for the output filename.
Nov 28 2016, 4:49 AM
klimek added inline comments to D27138: Extend CompilationDatabase by a field for the output filename.
Nov 28 2016, 1:57 AM

Nov 24 2016

klimek retitled D27104: Unify and simplify the behavior of the hasDeclaration matcher. from to Unify and simplify the behavior of the hasDeclaration matcher..
Nov 24 2016, 7:24 AM

Nov 16 2016

klimek accepted D26745: [Frontend] Allow attaching an external sema source to compiler instance and extra diags to TypoCorrections.

LG

Nov 16 2016, 6:34 AM

Nov 5 2016

klimek added a comment to D26288: Deduplicate replacements by FileEntry instead of file names..

Ok, makes sense. Can you add a comment to the function that explains what happens with replacements for files that do not exist (we ignore them, unless I'm mistaken). Otherwise LG.

Nov 5 2016, 5:35 PM
klimek added a comment to D26288: Deduplicate replacements by FileEntry instead of file names..
  • Addressed comments: handle non-existing files.
Nov 5 2016, 11:21 AM

Nov 3 2016

klimek added a comment to D26288: Deduplicate replacements by FileEntry instead of file names..

If the files do not exist, how does this work? Won't that potentially give different results if the files exist locally vs if they don't?

Nov 3 2016, 2:32 PM