- User Since
- Nov 12 2013, 7:42 AM (201 w, 4 d)
Wed, Sep 20
+Chandler (SROA owner)
-James (not active AFAICT)
Tue, Sep 19
Mon, Sep 18
Fri, Sep 15
LGTM. Thanks, Mandeep. These type of changes generally don't require pre-approval, btw.
Please add test cases.
Thu, Sep 14
Wed, Sep 13
Fri, Sep 1
Mon, Aug 28
Overall, the logic of the patch is in good shape. However, I'd suggest some minor refactoring to delineate the select of constants/values vs. GEPs for SROA.
Aug 24 2017
Seems reasonable to me assuming the usual bit of testing has been done.
-Add +rdm to llvm::AArch64::getExtensionFeatures. This was exposed while trying to write clang/driver tests. Thanks, Sjoerd.
Address Sam's feedback by adding a few more tests.
Aug 23 2017
Aug 22 2017
Aug 21 2017
Aug 18 2017
We can revisit this once there's a use case.
Aug 14 2017
Aug 11 2017
Aug 10 2017
Aug 9 2017
-Disable this feature by default.
-Update test RUN commands due to change.
One small comment, but otherwise LGTM. Thanks, Davide.
@haicheng has offered to take up this work!
Aug 8 2017
Aug 7 2017
@bmakam: Isn't this very similar to some of your recent work?
Aug 4 2017
Eli and Danny have (rightfully) convinced me this has little/no merit. However, this is a derivative of some other work I've been doing with the inline cost model and I think both of your inputs would be very valuable. Please see: http://lists.llvm.org/pipermail/llvm-dev/2017-August/116183.html
Aug 3 2017
Approved, per Jun.
Seems reasonable to me as well..
Aug 2 2017
Aug 1 2017
Jul 28 2017
Sounds reasonable to me.
Jul 26 2017
Update comments and minor formatting improvements.
Jul 25 2017
Address Geoff's offline comments.
-Remove the constraint that the 'and' or 'or' is operating on an i1 value.
Jul 24 2017
I'm not going to pursue this further, but if someone wants to pick up this work I'd be more than happy to assist.