nwilson (Nathan Wilson)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 3 2015, 11:10 AM (128 w, 6 d)

Recent Activity

Dec 28 2016

nwilson added a comment to D26882: Refactor how FunctionDecl handles constexpr:.

Small Ping. @rsmith - did you have anymore thoughts about this patch?

Dec 28 2016, 4:55 PM

Dec 20 2016

nwilson updated the diff for D26882: Refactor how FunctionDecl handles constexpr:.
  • Remove the call to setImplicitlyInline() within setImplicitlyConstexpr() and call setImplicitlyInline() directly for function concepts.
Dec 20 2016, 7:37 PM
nwilson added a comment to D26882: Refactor how FunctionDecl handles constexpr:.

Ping

Dec 20 2016, 4:30 PM

Dec 9 2016

nwilson added a comment to D26882: Refactor how FunctionDecl handles constexpr:.
Dec 9 2016, 3:59 AM
nwilson updated the diff for D26882: Refactor how FunctionDecl handles constexpr:.
  • Initialize IsConstexprSpecified
  • Remove unnecessary parenthetical in comment
  • Fix non-portable test
Dec 9 2016, 3:59 AM

Nov 22 2016

nwilson added a reviewer for D26882: Refactor how FunctionDecl handles constexpr:: faisalv.
Nov 22 2016, 8:25 PM
nwilson added inline comments to D26882: Refactor how FunctionDecl handles constexpr:.
Nov 22 2016, 8:24 PM

Nov 18 2016

nwilson updated subscribers of D26882: Refactor how FunctionDecl handles constexpr:.
Nov 18 2016, 8:00 PM
nwilson retitled D26882: Refactor how FunctionDecl handles constexpr: from to Refactor how FunctionDecl handles constexpr:.
Nov 18 2016, 7:59 PM

Apr 8 2016

nwilson committed rL265868: [Concepts] Implement subsection [dcl.spec.concept]p7 of the Concepts TS.
[Concepts] Implement subsection [dcl.spec.concept]p7 of the Concepts TS
Apr 8 2016, 8:01 PM
nwilson closed D18221: [Concepts] Implement subsection [dcl.spec.concept]p7 of the Concepts TS by committing rL265868: [Concepts] Implement subsection [dcl.spec.concept]p7 of the Concepts TS.
Apr 8 2016, 8:00 PM
nwilson updated the diff for D18221: [Concepts] Implement subsection [dcl.spec.concept]p7 of the Concepts TS.
  • Address Aaron's comments by putting comments next to the magic numbers
Apr 8 2016, 4:52 PM

Mar 16 2016

nwilson added inline comments to D18221: [Concepts] Implement subsection [dcl.spec.concept]p7 of the Concepts TS.
Mar 16 2016, 1:28 PM
nwilson retitled D18221: [Concepts] Implement subsection [dcl.spec.concept]p7 of the Concepts TS from to [Concepts] Implement subsection [dcl.spec.concept]p7 of the Concepts TS.
Mar 16 2016, 1:18 PM

Feb 8 2016

nwilson committed rL260155: [Concepts] Remove the IsConcept bit and associated member functions from VarDecl.
[Concepts] Remove the IsConcept bit and associated member functions from VarDecl
Feb 8 2016, 2:07 PM

Feb 7 2016

nwilson committed rL260074: [Concepts] Implement a portion of Concepts TS[dcl.spec.concept]p1 by.
[Concepts] Implement a portion of Concepts TS[dcl.spec.concept]p1 by
Feb 7 2016, 9:38 PM
nwilson closed D13357: [Concepts] Diagnose when 'concept' is specified on a specialization by committing rL260074: [Concepts] Implement a portion of Concepts TS[dcl.spec.concept]p1 by.
Feb 7 2016, 9:38 PM

Feb 3 2016

nwilson updated the diff for D13357: [Concepts] Diagnose when 'concept' is specified on a specialization.
  • Address Hubert's comments about the quoted section of the TS.
Feb 3 2016, 8:04 PM
nwilson updated the diff for D13357: [Concepts] Diagnose when 'concept' is specified on a specialization.
  • This update removes the parameter in TemplateDecl::setConcept since there isn't a need to mark a concept false.
Feb 3 2016, 5:15 PM

Feb 1 2016

nwilson added inline comments to D13357: [Concepts] Diagnose when 'concept' is specified on a specialization.
Feb 1 2016, 7:12 PM
nwilson added a comment to D13357: [Concepts] Diagnose when 'concept' is specified on a specialization.

Marking some comments Done which were fixed in previous updates.

Feb 1 2016, 4:16 PM
nwilson updated the diff for D13357: [Concepts] Diagnose when 'concept' is specified on a specialization.
  • Fix a couple of comments to reflect the Patch.
  • Clang-format the changes in this Patch.
Feb 1 2016, 4:10 PM

Jan 28 2016

nwilson committed rL259159: [Concepts] Implement a portion of Concepts TS[dcl.spec.concept]p5 and p6:.
[Concepts] Implement a portion of Concepts TS[dcl.spec.concept]p5 and p6:
Jan 28 2016, 8:48 PM
nwilson closed D16163: [Concepts] Diagnose when return type of a function concept or declaration type of a variable concept is not bool. by committing rL259159: [Concepts] Implement a portion of Concepts TS[dcl.spec.concept]p5 and p6:.
Jan 28 2016, 8:48 PM

Jan 26 2016

nwilson added a comment to D13357: [Concepts] Diagnose when 'concept' is specified on a specialization.

@rsmith - would you also mind clarifying the comment regarding setConcept(bool IC) at to whether it should exist at all or simply not have any params?

Jan 26 2016, 11:36 AM

Jan 20 2016

nwilson added inline comments to D16163: [Concepts] Diagnose when return type of a function concept or declaration type of a variable concept is not bool..
Jan 20 2016, 4:03 PM
nwilson updated the diff for D16163: [Concepts] Diagnose when return type of a function concept or declaration type of a variable concept is not bool..
  • Take qualifiers into account.
  • Check VarDecl is valid when checking declaration type to account for constexpr being specified. Is there any opinion on a better way to handle this? I *could* check for both diagnostics in the test...
  • Remove erroneous check for auto (containsPlaceholderType) and associated function concept test.
  • Removed the use of Diagnostic Range because we'd need to enumerate over the various qualifiers.
Jan 20 2016, 3:10 PM

Jan 13 2016

nwilson added inline comments to D13357: [Concepts] Diagnose when 'concept' is specified on a specialization.
Jan 13 2016, 5:18 PM
nwilson added inline comments to D13357: [Concepts] Diagnose when 'concept' is specified on a specialization.
Jan 13 2016, 4:41 PM
nwilson added a comment to D16163: [Concepts] Diagnose when return type of a function concept or declaration type of a variable concept is not bool..

Please let me know if the subject or summary of this Patch is ambiguous.

Jan 13 2016, 4:12 PM
nwilson retitled D16163: [Concepts] Diagnose when return type of a function concept or declaration type of a variable concept is not bool. from to [Concepts] Diagnose when return type of a function concept or declaration type of a variable concept is not bool..
Jan 13 2016, 4:08 PM
nwilson added a comment to D15421: [Feature] Add a builtin for indexing into parameter packs.

Bikeshedding on the name a bit... how about __type_pack_element?

Jan 13 2016, 2:31 PM

Jan 7 2016

nwilson added a comment to D13357: [Concepts] Diagnose when 'concept' is specified on a specialization.

Ping. Now that the holidays are over-ish, as Aaron said in one of his Patches.

Jan 7 2016, 11:59 AM

Dec 29 2015

nwilson added inline comments to D15801: Improve the documentation on committing code reviewed on Phabricator to trunk. .
Dec 29 2015, 2:58 PM

Dec 27 2015

nwilson updated the diff for D13357: [Concepts] Diagnose when 'concept' is specified on a specialization.
  • Store the IsConcept boolean flag in TemplateDecl by making TemplatedDecl an IntPointerPair, and move the associated member functions into TemplateDecl.
  • Remove unnecessary quoted comment.
  • Remove an extra space where the diagnostic is used.
Dec 27 2015, 8:25 PM
nwilson added inline comments to D13357: [Concepts] Diagnose when 'concept' is specified on a specialization.
Dec 27 2015, 7:44 PM

Dec 22 2015

nwilson updated the diff for D13357: [Concepts] Diagnose when 'concept' is specified on a specialization.

Updating to r256247

Dec 22 2015, 12:01 PM

Dec 16 2015

nwilson updated the diff for D13357: [Concepts] Diagnose when 'concept' is specified on a specialization.
  • Move IsConcept bit and associated member functions from FunctionDecl to FunctionTemplateDecl.
  • Set the IsConcept flag using getDescribedFunctionTemplate.
Dec 16 2015, 3:08 PM

Dec 10 2015

nwilson added a comment to D15421: [Feature] Add a builtin for indexing into parameter packs.

Hi Louis,

Dec 10 2015, 9:49 AM

Nov 30 2015

nwilson updated the diff for D13357: [Concepts] Diagnose when 'concept' is specified on a specialization.

Updating to r254337

Nov 30 2015, 2:59 PM
nwilson added inline comments to D13357: [Concepts] Diagnose when 'concept' is specified on a specialization.
Nov 30 2015, 2:39 PM

Nov 18 2015

nwilson added inline comments to D13357: [Concepts] Diagnose when 'concept' is specified on a specialization.
Nov 18 2015, 3:10 PM

Nov 12 2015

nwilson updated the diff for D13357: [Concepts] Diagnose when 'concept' is specified on a specialization.
  • Remove marking a variable concept invalid when specialized since we'll only look at the primary template downstream. This removal let's us use the same recovery path as before when 'concept' is specified on a non-template.
Nov 12 2015, 8:02 PM

Nov 11 2015

nwilson committed rL252855: [Sema] Remove unnecessary parens in check using logical or; NFC..
[Sema] Remove unnecessary parens in check using logical or; NFC.
Nov 11 2015, 8:27 PM
nwilson committed rL252827: Add diagnostics which fall under [dcl.spec.concept]p5.
Add diagnostics which fall under [dcl.spec.concept]p5
Nov 11 2015, 3:56 PM
nwilson closed D14352: Add diagnostics which fall under [dcl.spec.concept]p5 by committing rL252827: Add diagnostics which fall under [dcl.spec.concept]p5.
Nov 11 2015, 3:56 PM

Nov 5 2015

nwilson updated the diff for D14352: Add diagnostics which fall under [dcl.spec.concept]p5.
  • replace hyphen and apostrophe with equivalent ASCII characters
Nov 5 2015, 10:49 AM

Nov 4 2015

nwilson updated the diff for D14352: Add diagnostics which fall under [dcl.spec.concept]p5.
  • Cover variadic arguments in check for no params.
  • Add tests to cover variadic arguments.
Nov 4 2015, 9:06 PM
nwilson retitled D14352: Add diagnostics which fall under [dcl.spec.concept]p5 from to Add diagnostics which fall under [dcl.spec.concept]p5.
Nov 4 2015, 3:10 PM
nwilson committed rL252061: [Concepts] Add diagnostics which fall under [dcl.spec.concept]p1.
[Concepts] Add diagnostics which fall under [dcl.spec.concept]p1
Nov 4 2015, 10:21 AM
nwilson closed D14316: [Concepts] Add diagnostics which fall under [dcl.spec.concept]p1 by committing rL252061: [Concepts] Add diagnostics which fall under [dcl.spec.concept]p1.
Nov 4 2015, 10:21 AM

Nov 3 2015

nwilson retitled D14316: [Concepts] Add diagnostics which fall under [dcl.spec.concept]p1 from to [Concepts] Add diagnostics which fall under [dcl.spec.concept]p1.
Nov 3 2015, 7:13 PM

Nov 2 2015

nwilson added inline comments to D13357: [Concepts] Diagnose when 'concept' is specified on a specialization.
Nov 2 2015, 8:46 PM
nwilson updated the diff for D13357: [Concepts] Diagnose when 'concept' is specified on a specialization.

Updating to r251898

Nov 2 2015, 8:36 PM

Oct 22 2015

nwilson added inline comments to D13357: [Concepts] Diagnose when 'concept' is specified on a specialization.
Oct 22 2015, 9:09 PM

Oct 15 2015

nwilson updated the diff for D13357: [Concepts] Diagnose when 'concept' is specified on a specialization.

Addressing Richard's other comment regarding the check that the FunctionDecl is not a concept. Also, not marking the specialization as invalid if it's declared with the concept specifier since the downstream parts of Clang should look at the primary template.

Oct 15 2015, 3:40 PM

Oct 12 2015

nwilson added inline comments to D13357: [Concepts] Diagnose when 'concept' is specified on a specialization.
Oct 12 2015, 6:33 AM
nwilson retitled D13357: [Concepts] Diagnose when 'concept' is specified on a specialization from [Concepts] Add diagnostic; specializations of variable and function concepts to [Concepts] Diagnose when 'concept' is specified on a specialization.
Oct 12 2015, 6:10 AM
nwilson updated the diff for D13357: [Concepts] Diagnose when 'concept' is specified on a specialization.

Moving tests to the correct file.
Modifying the diagnostic id and message so it's more applicable to the checks in this Patch. Update the quoted sections of the standard as well.
Use ternary operator for Partial Specialization check.
Add missing period in comment.

Oct 12 2015, 6:07 AM

Oct 9 2015

nwilson committed rL249934: [Concepts] Fixing Concepts TS directory structure; NFC.
[Concepts] Fixing Concepts TS directory structure; NFC
Oct 9 2015, 7:19 PM

Oct 1 2015

nwilson retitled D13357: [Concepts] Diagnose when 'concept' is specified on a specialization from to [Concepts] Add diagnostic; specializations of variable and function concepts.
Oct 1 2015, 11:01 AM

Sep 17 2015

nwilson committed rL247966: [Concepts] Moving tests to match the corresponding section of the TS.
[Concepts] Moving tests to match the corresponding section of the TS
Sep 17 2015, 7:52 PM

Sep 9 2015

nwilson committed rL247194: [Concepts] Add diagnostic; invalid specifier on function or variable concept….
[Concepts] Add diagnostic; invalid specifier on function or variable concept…
Sep 9 2015, 2:49 PM
nwilson closed D12435: [Concepts] Add diagnostic; invalid specifier on function or variable concept declaration.
Sep 9 2015, 2:49 PM

Sep 4 2015

nwilson added a comment to D12435: [Concepts] Add diagnostic; invalid specifier on function or variable concept declaration.

Ping

Sep 4 2015, 12:52 PM

Aug 31 2015

nwilson updated the diff for D12435: [Concepts] Add diagnostic; invalid specifier on function or variable concept declaration.

Change the wording of diagnostic message and quote the invalid specifier. Add 'friend' as an invalid specifier and diagnose function concepts when 'friend' is specified. Reorder the list of invalid specifiers and corresponding checks in the code to match the TS.

Aug 31 2015, 10:12 AM

Aug 28 2015

nwilson added inline comments to D12435: [Concepts] Add diagnostic; invalid specifier on function or variable concept declaration.
Aug 28 2015, 2:39 PM
nwilson retitled D12435: [Concepts] Add diagnostic; invalid specifier on function or variable concept declaration from to [Concepts] Add diagnostic; invalid specifier on function or variable concept declaration.
Aug 28 2015, 9:25 AM

Aug 25 2015

nwilson committed rL246005: Modify DeclaratorChuck::getFunction to be passed an Exception Specification….
Modify DeclaratorChuck::getFunction to be passed an Exception Specification…
Aug 25 2015, 9:20 PM
nwilson closed D11789: Modify DeclaratorChuck::getFunction to be passed an Exception Specification SourceRange by committing rL246005: Modify DeclaratorChuck::getFunction to be passed an Exception Specification….
Aug 25 2015, 9:20 PM
nwilson closed D11789: Modify DeclaratorChuck::getFunction to be passed an Exception Specification SourceRange.
Aug 25 2015, 9:20 PM
nwilson added a comment to D11789: Modify DeclaratorChuck::getFunction to be passed an Exception Specification SourceRange.

Ping

Aug 25 2015, 11:19 AM
nwilson updated the diff for D11789: Modify DeclaratorChuck::getFunction to be passed an Exception Specification SourceRange.
Aug 25 2015, 11:18 AM

Aug 15 2015

nwilson updated the diff for D11789: Modify DeclaratorChuck::getFunction to be passed an Exception Specification SourceRange.

Patch addressing comments; fix comment/documentation wording, scoping of diagnostic and setting invalid declaration, and fix test.

Aug 15 2015, 9:23 PM

Aug 14 2015

nwilson committed rL245123: [CONCEPTS] Add diagnostic; invalid tag when concept specified.
[CONCEPTS] Add diagnostic; invalid tag when concept specified
Aug 14 2015, 4:20 PM
nwilson closed D11916: [CONCEPTS] Add diagnostic; invalid tag when concept specified by committing rL245123: [CONCEPTS] Add diagnostic; invalid tag when concept specified.
Aug 14 2015, 4:20 PM
nwilson added a comment to D11789: Modify DeclaratorChuck::getFunction to be passed an Exception Specification SourceRange.

Ping

Aug 14 2015, 3:50 PM

Aug 12 2015

nwilson updated the diff for D11916: [CONCEPTS] Add diagnostic; invalid tag when concept specified.

Addressing comments which were discussed on the mailing list - Apply the same text when diagnosing a free standing declaration as suggested by Aaron. Replace diagnostic identifier err_concept_decl_non_template with err_concept_wrong_decl_kind as suggested by Hubert and Richard. Fix tests corresponding to the changes.

Aug 12 2015, 10:40 AM

Aug 11 2015

nwilson added a comment to D11928: Deleted old fixme..

Hi Piotr,

Aug 11 2015, 4:31 PM

Aug 10 2015

nwilson added inline comments to D11859: Generating vptr assume loads.
Aug 10 2015, 9:59 PM
nwilson updated subscribers of D11859: Generating vptr assume loads.
Aug 10 2015, 9:49 PM
nwilson retitled D11916: [CONCEPTS] Add diagnostic; invalid tag when concept specified from to [CONCEPTS] Add diagnostic; invalid tag when concept specified.
Aug 10 2015, 12:00 PM

Aug 6 2015

nwilson added inline comments to D11789: Modify DeclaratorChuck::getFunction to be passed an Exception Specification SourceRange.
Aug 6 2015, 7:26 PM
nwilson updated the diff for D11789: Modify DeclaratorChuck::getFunction to be passed an Exception Specification SourceRange.
  • Update Patch based on comments; rephrase exception spec comment, adjust nesting of check for FunctionTypeInfo, remove SourceRange check, fix test
Aug 6 2015, 7:25 PM
nwilson added inline comments to D11789: Modify DeclaratorChuck::getFunction to be passed an Exception Specification SourceRange.
Aug 6 2015, 7:09 PM
nwilson updated the diff for D11789: Modify DeclaratorChuck::getFunction to be passed an Exception Specification SourceRange.

Updated Patch based on comments; fix diagnostic spacing and phrasing, add getExceptionSpecRange, check FunctionTypeInfo exists, use PartialDiagnostic, add static_assert test for function concept being treated as noexcept(true)

Aug 6 2015, 3:54 PM

Aug 5 2015

nwilson added a comment to D11789: Modify DeclaratorChuck::getFunction to be passed an Exception Specification SourceRange.

I'll make the fixes based on the comments, but had question about the FunctionTypeInfo in the meantime.

Aug 5 2015, 7:28 PM
nwilson retitled D11789: Modify DeclaratorChuck::getFunction to be passed an Exception Specification SourceRange from to Modify DeclaratorChuck::getFunction to be passed an Exception Specification SourceRange.
Aug 5 2015, 4:17 PM

Aug 3 2015

nwilson committed rL243876: [CONCEPTS] Add concept to VarDecl and diagnostic for uninitialized variable….
[CONCEPTS] Add concept to VarDecl and diagnostic for uninitialized variable…
Aug 3 2015, 7:26 AM
nwilson closed D11600: [CONCEPTS] Add concept to VarDecl and diagnostic for uninitialized variable concept.
Aug 3 2015, 7:26 AM

Jul 31 2015

nwilson committed rL243776: test commit; wrap ellipses in comment with brackets.
test commit; wrap ellipses in comment with brackets
Jul 31 2015, 1:00 PM

Jul 29 2015

nwilson updated the diff for D11600: [CONCEPTS] Add concept to VarDecl and diagnostic for uninitialized variable concept.

Putting diagnostic on one line.

Jul 29 2015, 9:39 PM
nwilson updated the diff for D11490: [Concepts] Add diagnostic: non template declaration.

Removing failing test case (in Parser) created by this Patch

Jul 29 2015, 9:21 PM
nwilson added a comment to D11490: [Concepts] Add diagnostic: non template declaration.

Thanks Richard.

Jul 29 2015, 7:22 PM
nwilson retitled D11600: [CONCEPTS] Add concept to VarDecl and diagnostic for uninitialized variable concept from [CONCEPTS] Add concept to VarDecl and diagnostic for unitialized variable concept to [CONCEPTS] Add concept to VarDecl and diagnostic for uninitialized variable concept.
Jul 29 2015, 10:53 AM
nwilson retitled D11600: [CONCEPTS] Add concept to VarDecl and diagnostic for uninitialized variable concept from Add concept to VarDecl and diagnostic for unitialized variable concept to [CONCEPTS] Add concept to VarDecl and diagnostic for unitialized variable concept.
Jul 29 2015, 10:52 AM
nwilson added a comment to D11600: [CONCEPTS] Add concept to VarDecl and diagnostic for uninitialized variable concept.

If deemed necessary, I can split this patch out to two patches; one for adding IsConcept to the NonParmVarDeclBitfields bitfield and associated VarDecl member functions and another patch for the Diagnostic/tests

Jul 29 2015, 10:47 AM
nwilson retitled D11600: [CONCEPTS] Add concept to VarDecl and diagnostic for uninitialized variable concept from to Add concept to VarDecl and diagnostic for unitialized variable concept.
Jul 29 2015, 10:39 AM

Jul 24 2015

nwilson updated the diff for D11490: [Concepts] Add diagnostic: non template declaration.

modifying diagnostic message to: 'concept' can only appear on the definition of a function template or variable template

Jul 24 2015, 1:22 PM
nwilson retitled D11490: [Concepts] Add diagnostic: non template declaration from to [Concepts] Add diagnostic: non template declaration.
Jul 24 2015, 11:43 AM