djasper (Daniel Jasper)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 10:15 AM (271 w, 5 d)

Recent Activity

Thu, Sep 21

djasper committed rL313876: Revert r313825: "[IR] Add llvm.dbg.addr, a control-dependent version of llvm..
Revert r313825: "[IR] Add llvm.dbg.addr, a control-dependent version of llvm.
Thu, Sep 21, 5:09 AM

Tue, Sep 19

djasper added a comment to D33589: clang-format: consider not splitting tokens in optimization.

I think doing the computation twice is fine. Or at least, I'd need a test case where it actually shows substantial overhead before doing what you are doing here. Understand that creating more States and making the State object itself larger also has cost and that cost occurs in the combinatorial exploration of the solution space. Doing an additional computation at the end should be comparatively cheap. Look at it this way: During the exploration of the solution space, we might enter breakProtrudingToken many times for the same comment. One more time during reconstruction of the solution is not that harmful.

Tue, Sep 19, 5:02 AM

Mon, Sep 18

djasper edited reviewers for D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true., added: krasimir; removed: djasper.
Mon, Sep 18, 2:11 AM

Thu, Sep 14

djasper added inline comments to D33440: clang-format: better handle statement macros.
Thu, Sep 14, 2:30 AM
djasper added a comment to D33589: clang-format: consider not splitting tokens in optimization.

I still don't understand yet. breakProtrudingToken has basically two options:

Thu, Sep 14, 12:58 AM

Tue, Sep 12

djasper added a comment to D33440: clang-format: better handle statement macros.

I'd still prefer individual patches for each of these changes. If the code review system or VCS make it hard for you to deal with two adjacent changes this way, do them in sequence.

Tue, Sep 12, 2:29 AM
djasper added a reviewer for D33440: clang-format: better handle statement macros: klimek.
Tue, Sep 12, 2:14 AM
djasper added a comment to D37260: [clang-format] Fixed extern C brace wrapping.

BraceWrapping.AfterExternC makes sense to me.

Tue, Sep 12, 2:14 AM
djasper added a comment to D33589: clang-format: consider not splitting tokens in optimization.

I have a slightly hard time grasping what this patch now actually does? Doesn't it simply try to decide whether or not to make a split locally be comparing the PenaltyBreakComment against the penalty for the access characters? If so, couldn't we simply do that as an implementation detail of breakProtrudingToken() without needing to let anything outside of it now and without introducing State.Reflow?

Tue, Sep 12, 2:13 AM
djasper added a comment to D37260: [clang-format] Fixed extern C brace wrapping.

I am very strongly against a flag that just leaves the line break as is. What's the motivation?

Tue, Sep 12, 1:59 AM

Mon, Sep 11

djasper committed rL313007: Creating tags/google/stable/2017-09-12 from r312634.
Creating tags/google/stable/2017-09-12 from r312634
Mon, Sep 11, 11:41 PM
djasper committed rL313008: Updating branches/google/stable to r312634.
Updating branches/google/stable to r312634
Mon, Sep 11, 11:41 PM
djasper committed rL313006: Updating branches/google/stable to r312634.
Updating branches/google/stable to r312634
Mon, Sep 11, 11:31 PM
djasper committed rL313005: Creating tags/google/stable/2017-09-12 from r312634.
Creating tags/google/stable/2017-09-12 from r312634
Mon, Sep 11, 11:31 PM
djasper committed rL312998: Updating branches/google/stable to r312634.
Updating branches/google/stable to r312634
Mon, Sep 11, 11:31 PM
djasper committed rL312997: Creating tags/google/stable/2017-09-12 from r312634.
Creating tags/google/stable/2017-09-12 from r312634
Mon, Sep 11, 11:31 PM
djasper committed rL313002: Updating branches/google/stable to r312634.
Updating branches/google/stable to r312634
Mon, Sep 11, 11:28 PM
djasper committed rL313001: Creating tags/google/stable/2017-09-12 from r312634.
Creating tags/google/stable/2017-09-12 from r312634
Mon, Sep 11, 11:27 PM
djasper committed rL313000: Updating branches/google/stable to r312634.
Updating branches/google/stable to r312634
Mon, Sep 11, 11:27 PM
djasper committed rL312999: Creating tags/google/stable/2017-09-12 from r312634.
Creating tags/google/stable/2017-09-12 from r312634
Mon, Sep 11, 11:26 PM
djasper accepted D37685: clang-format: [JS] wrap and indent `goog.setTestOnly` calls..
Mon, Sep 11, 7:30 AM
djasper committed rL312897: Revert r312830: "Reinstall the patch "Use EmitPointerWithAlignment to get….
Revert r312830: "Reinstall the patch "Use EmitPointerWithAlignment to get…
Mon, Sep 11, 12:38 AM

Thu, Sep 7

djasper accepted D37513: [clang-format] Fix documentation for AllowAllParametersOfDeclarationOnNextLine.

Submitted as r312721. Thank you.

Thu, Sep 7, 6:47 AM
djasper committed rL312721: [clang-format] Fix documentation for AllowAllParametersOfDeclarationOnNextLine.
[clang-format] Fix documentation for AllowAllParametersOfDeclarationOnNextLine
Thu, Sep 7, 6:47 AM
djasper accepted D37132: [clang-format] Add support for C++17 structured bindings..

Looks good. Sorry for the delay.

Thu, Sep 7, 6:44 AM
djasper accepted D37513: [clang-format] Fix documentation for AllowAllParametersOfDeclarationOnNextLine.

Also run dump_format_style.py and keep the changed .rst file in this change.

Thu, Sep 7, 5:00 AM
djasper accepted D37558: Refresh the clang format options doc with the recent changes.

Thank you.

Thu, Sep 7, 4:31 AM
djasper accepted D37531: Add an usage example of BreakBeforeBraces.

Looks good.

Thu, Sep 7, 4:30 AM
djasper added a comment to D37531: Add an usage example of BreakBeforeBraces.

This change needs to be made to include/clang/Format/Format.h and then the rst file needs to be regenerated with docs/tools/dump_format_style.py.

Thu, Sep 7, 2:58 AM

Wed, Sep 6

djasper added a comment to D37513: [clang-format] Fix documentation for AllowAllParametersOfDeclarationOnNextLine.

Note that these changes need to be made to the corresponding comments in include/clang/Format/Format.h and then this file is auto-generated with docs/tools/dump_format_style.py.

Wed, Sep 6, 6:30 AM

Tue, Sep 5

djasper added inline comments to D35943: [clang-format] Format raw string literals.
Tue, Sep 5, 7:45 AM

Mon, Sep 4

djasper committed rL312484: clang-format: Fix indentation of macros in include guards (after r312125)..
clang-format: Fix indentation of macros in include guards (after r312125).
Mon, Sep 4, 6:35 AM

Sun, Sep 3

djasper committed rL312437: clang-format: Fix formatting of for loops with multiple increments..
clang-format: Fix formatting of for loops with multiple increments.
Sun, Sep 3, 1:57 AM

Fri, Sep 1

djasper removed a reviewer for D37372: [XRay][compiler-rt] Make __xray_CustomEvent PIC friendlier and build a dynamic version of the XRay runtime: djasper.
Fri, Sep 1, 12:39 AM

Thu, Aug 31

djasper committed rL312243: Revert r311525: "[XRay][CodeGen] Use PIC-friendly code in XRay sleds; remove….
Revert r311525: "[XRay][CodeGen] Use PIC-friendly code in XRay sleds; remove…
Thu, Aug 31, 8:18 AM

Wed, Aug 30

djasper committed rL312219: Revert r312194: "[MachineOutliner] Add missed optimization remarks for the….
Revert r312194: "[MachineOutliner] Add missed optimization remarks for the…
Wed, Aug 30, 11:23 PM

Tue, Aug 29

djasper accepted D37136: [clang-format] Do not format likely xml.

Just a few minor comments, otherwise looks good.

Tue, Aug 29, 5:12 AM
djasper added a comment to D37132: [clang-format] Add support for C++17 structured bindings..

Are you changing the line endings here? Phabricator tells me that basically all the lines change. If so, please don't ;).

Tue, Aug 29, 5:10 AM
djasper accepted D37143: [clang-format] Fixed typedef enum brace wrapping.

Looks good. Thank you.

Tue, Aug 29, 5:02 AM

Mon, Aug 28

djasper added inline comments to D37142: clang-format: [JS] simplify template string wrapping..
Mon, Aug 28, 3:19 AM
djasper added inline comments to D37142: clang-format: [JS] simplify template string wrapping..
Mon, Aug 28, 2:12 AM
djasper accepted D37142: clang-format: [JS] simplify template string wrapping..

Yay for *removing* complexity for a change :).
Let me know how it goes in practice.

Mon, Aug 28, 12:44 AM

Sun, Aug 27

djasper accepted D37192: [clang-format] Add support for generic Obj-C categories.

Looks good.

Sun, Aug 27, 11:17 PM

Aug 25 2017

djasper committed rL311792: [Format] Invert nestingAndIndentLevel pair in WhitespaceManager used for.
[Format] Invert nestingAndIndentLevel pair in WhitespaceManager used for
Aug 25 2017, 12:16 PM

Aug 24 2017

djasper accepted D35955: clang-format: Add preprocessor directive indentation.

From my side this looks good for now (we can always improve more later). Krasimir, what do you think?

Aug 24 2017, 7:55 AM · Restricted Project
djasper accepted D37109: [clang-format] Emit absolute splits before lines for comments, try 2.

Does the test still test the same thing if you set the column limit to 60 and remove 20 spaces? If not, this is fine.

Aug 24 2017, 7:27 AM

Aug 23 2017

djasper added inline comments to D35955: clang-format: Add preprocessor directive indentation.
Aug 23 2017, 7:10 AM · Restricted Project
djasper accepted D36956: [clang-format] Emit absolute splits before lines for comments.

Looks good.

Aug 23 2017, 5:13 AM

Aug 22 2017

djasper added a comment to D35955: clang-format: Add preprocessor directive indentation.

Krasimir: Can you actually give this a round of review? I will also try to do so tomorrow.

Aug 22 2017, 10:38 AM · Restricted Project
djasper added a reviewer for D35955: clang-format: Add preprocessor directive indentation: krasimir.
Aug 22 2017, 10:38 AM · Restricted Project
djasper accepted D37007: [clang-format] Break non-trailing block comments.

If no tests break with this, lets just go for it. We can follow up and fix individual cases if we find undesired behavior.

Aug 22 2017, 7:38 AM
djasper accepted D37011: [clang-format] Fix lines regression in clang-format.py.

Thank you

Aug 22 2017, 7:22 AM

Aug 21 2017

djasper added inline comments to D36614: [clang-format] Refine trailing comment detection.
Aug 21 2017, 11:58 PM
djasper added inline comments to D36956: [clang-format] Emit absolute splits before lines for comments.
Aug 21 2017, 11:51 PM
djasper added inline comments to D36967: [clang-format] Align trailing comments if ColumnLimit is 0.
Aug 21 2017, 12:28 PM
djasper accepted D36967: [clang-format] Align trailing comments if ColumnLimit is 0.
Aug 21 2017, 8:42 AM

Aug 16 2017

djasper committed rL311070: Fix undefined behavior that is caused by not always initializing a bool..
Fix undefined behavior that is caused by not always initializing a bool.
Aug 16 2017, 11:35 PM
djasper added inline comments to D35955: clang-format: Add preprocessor directive indentation.
Aug 16 2017, 1:20 AM · Restricted Project

Aug 14 2017

djasper accepted D36684: clang-format: [JS] wrap optional properties in type aliases..

Looks good.

Aug 14 2017, 9:04 AM
djasper accepted D36142: clang-format: [JS] do not insert whitespace in call positions..

Looks good.

Aug 14 2017, 9:04 AM

Aug 10 2017

djasper committed rL310574: Updating branches/google/stable to r310337.
Updating branches/google/stable to r310337
Aug 10 2017, 2:57 AM
djasper committed rL310573: Creating tags/google/stable/2017-08-10 from r310337.
Creating tags/google/stable/2017-08-10 from r310337
Aug 10 2017, 2:57 AM
djasper committed rL310572: Updating branches/google/stable to r310337.
Updating branches/google/stable to r310337
Aug 10 2017, 2:51 AM
djasper committed rL310571: Creating tags/google/stable/2017-08-10 from r310337.
Creating tags/google/stable/2017-08-10 from r310337
Aug 10 2017, 2:51 AM
djasper committed rL310564: Updating branches/google/stable to r310337.
Updating branches/google/stable to r310337
Aug 10 2017, 2:50 AM
djasper committed rL310563: Creating tags/google/stable/2017-08-10 from r310337.
Creating tags/google/stable/2017-08-10 from r310337
Aug 10 2017, 2:50 AM
djasper committed rL310567: Creating tags/google/stable/2017-08-10 from r310337.
Creating tags/google/stable/2017-08-10 from r310337
Aug 10 2017, 2:47 AM
djasper committed rL310568: Updating branches/google/stable to r310337.
Updating branches/google/stable to r310337
Aug 10 2017, 2:47 AM
djasper committed rL310566: Updating branches/google/stable to r310337.
Updating branches/google/stable to r310337
Aug 10 2017, 2:46 AM
djasper committed rL310565: Creating tags/google/stable/2017-08-10 from r310337.
Creating tags/google/stable/2017-08-10 from r310337
Aug 10 2017, 2:44 AM

Aug 9 2017

djasper accepted D34324: [clang-format] let PointerAlignment dictate spacing of function ref qualifiers.

Looks good. Thank you!

Aug 9 2017, 2:31 AM

Aug 8 2017

djasper accepted D36491: clang-format: [JS] detect ASI after closing parens..

LG

Aug 8 2017, 10:12 PM
djasper added a comment to D35955: clang-format: Add preprocessor directive indentation.

Manuel: Can you take a look at the last comment here? Why does PPBranchLevel start at -1?

Aug 8 2017, 1:32 AM · Restricted Project

Aug 6 2017

djasper accepted D36019: [clang-format] Fix bug with ENAS_DontAlign and empty lines.

Thanks you.

Aug 6 2017, 10:18 PM

Aug 4 2017

djasper added inline comments to D35943: [clang-format] Format raw string literals.
Aug 4 2017, 6:34 AM
djasper added inline comments to D36019: [clang-format] Fix bug with ENAS_DontAlign and empty lines.
Aug 4 2017, 1:19 AM
djasper added inline comments to D35955: clang-format: Add preprocessor directive indentation.
Aug 4 2017, 12:55 AM · Restricted Project

Aug 3 2017

djasper accepted D36148: clang-format: [JS] support fields with case/switch/default labels..

Looks good.

Aug 3 2017, 11:07 PM
djasper committed rL310022: Prevent unused warning in non-assert builds (introduced in r310014)..
Prevent unused warning in non-assert builds (introduced in r310014).
Aug 3 2017, 10:06 PM

Aug 2 2017

djasper committed rL309922: Fix WebAssembly target after r309911..
Fix WebAssembly target after r309911.
Aug 2 2017, 10:16 PM
djasper committed rL309868: Creating tags/google/stable/2017-08-02 from r309660.
Creating tags/google/stable/2017-08-02 from r309660
Aug 2 2017, 12:42 PM
djasper committed rL309869: Updating branches/google/stable to r309660.
Updating branches/google/stable to r309660
Aug 2 2017, 12:42 PM
djasper committed rL309867: Updating branches/google/stable to r309660.
Updating branches/google/stable to r309660
Aug 2 2017, 12:34 PM
djasper committed rL309866: Creating tags/google/stable/2017-08-02 from r309660.
Creating tags/google/stable/2017-08-02 from r309660
Aug 2 2017, 12:34 PM
djasper committed rL309858: Creating tags/google/stable/2017-08-02 from r309660.
Creating tags/google/stable/2017-08-02 from r309660
Aug 2 2017, 12:33 PM
djasper committed rL309859: Updating branches/google/stable to r309660.
Updating branches/google/stable to r309660
Aug 2 2017, 12:33 PM
djasper committed rL309863: Updating branches/google/stable to r309660.
Updating branches/google/stable to r309660
Aug 2 2017, 12:28 PM
djasper committed rL309862: Creating tags/google/stable/2017-08-02 from r309660.
Creating tags/google/stable/2017-08-02 from r309660
Aug 2 2017, 12:28 PM
djasper committed rL309861: Updating branches/google/stable to r309660.
Updating branches/google/stable to r309660
Aug 2 2017, 12:26 PM
djasper committed rL309860: Creating tags/google/stable/2017-08-02 from r309660.
Creating tags/google/stable/2017-08-02 from r309660
Aug 2 2017, 12:24 PM

Aug 1 2017

djasper added a comment to D35743: [clang-format] Adjust space around &/&& of structured bindings.

Generally, please upload patches with full context to phabricator. (or use arc)

Aug 1 2017, 11:11 PM · Restricted Project
djasper added a reviewer for D35743: [clang-format] Adjust space around &/&& of structured bindings: klimek.
Aug 1 2017, 11:11 PM · Restricted Project
djasper added inline comments to D36142: clang-format: [JS] do not insert whitespace in call positions..
Aug 1 2017, 9:04 AM
djasper added inline comments to D36139: clang-format: [JS] prefer wrapping chains over empty literals..
Aug 1 2017, 9:04 AM
djasper accepted D36144: clang-format: [JS] consistenly format enums..

LG

Aug 1 2017, 9:04 AM
djasper accepted D36146: clang-format: [JS] whitespace between keywords and parenthesized expressions..

LG

Aug 1 2017, 9:04 AM
djasper accepted D36147: clang-format: [JS] handle union types in arrow functions..

LG

Aug 1 2017, 9:04 AM
djasper accepted D36132: clang-format: [JS] support default imports..
Aug 1 2017, 4:37 AM
djasper accepted D36131: clang-format: [JS] handle object types in extends positions..

Looks good.

Aug 1 2017, 4:36 AM

Jul 31 2017

djasper committed rL309659: Revert r309415: "[LVI] Constant-propagate a zero extension of the switch….
Revert r309415: "[LVI] Constant-propagate a zero extension of the switch…
Jul 31 2017, 10:31 PM