djasper (Daniel Jasper)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 10:15 AM (262 w, 3 d)

Recent Activity

Yesterday

djasper accepted D35485: [clang-format] Fix comment levels between '}' and PPDirective.

Looks good.

Fri, Jul 21, 2:05 AM

Wed, Jul 19

djasper added inline comments to D35485: [clang-format] Fix comment levels between '}' and PPDirective.
Wed, Jul 19, 7:43 AM

Tue, Jul 18

djasper committed rL308372: Creating tags/google/stable/2017-07-18 from r308006.
Creating tags/google/stable/2017-07-18 from r308006
Tue, Jul 18, 2:31 PM
djasper committed rL308373: Updating branches/google/stable to r308006.
Updating branches/google/stable to r308006
Tue, Jul 18, 2:30 PM
djasper committed rL308371: Updating branches/google/stable to r308006.
Updating branches/google/stable to r308006
Tue, Jul 18, 2:20 PM
djasper committed rL308362: Creating tags/google/stable/2017-07-18 from r308006.
Creating tags/google/stable/2017-07-18 from r308006
Tue, Jul 18, 2:18 PM
djasper committed rL308363: Updating branches/google/stable to r308006.
Updating branches/google/stable to r308006
Tue, Jul 18, 2:17 PM
djasper committed rL308370: Creating tags/google/stable/2017-07-18 from r308006.
Creating tags/google/stable/2017-07-18 from r308006
Tue, Jul 18, 2:17 PM
djasper committed rL308367: Updating branches/google/stable to r308006.
Updating branches/google/stable to r308006
Tue, Jul 18, 2:11 PM
djasper committed rL308366: Creating tags/google/stable/2017-07-18 from r308006.
Creating tags/google/stable/2017-07-18 from r308006
Tue, Jul 18, 2:10 PM
djasper committed rL308365: Updating branches/google/stable to r308006.
Updating branches/google/stable to r308006
Tue, Jul 18, 2:09 PM
djasper committed rL308364: Creating tags/google/stable/2017-07-18 from r308006.
Creating tags/google/stable/2017-07-18 from r308006
Tue, Jul 18, 2:07 PM
djasper added inline comments to D35485: [clang-format] Fix comment levels between '}' and PPDirective.
Tue, Jul 18, 7:38 AM
djasper accepted D34824: clang-format: add an option -verbose to list the files being processed.

Yeah, improving the testsuite generally seems like a good idea. But unrelated to this patch. This looks good now.

Tue, Jul 18, 7:33 AM · Restricted Project
djasper added a comment to D33440: clang-format: better handle statement and namespace macros.

So, there are two things in this patch: Statement macros and namespace macros. Lets break this out and handle them individually. They really aren't related that much.

Tue, Jul 18, 4:13 AM
djasper added inline comments to D35485: [clang-format] Fix comment levels between '}' and PPDirective.
Tue, Jul 18, 2:22 AM
djasper added inline comments to D34824: clang-format: add an option -verbose to list the files being processed.
Tue, Jul 18, 12:08 AM · Restricted Project

Thu, Jul 13

djasper removed a reviewer for D35329: [clang-reorder-fields] Enable reordering for plain C structs: djasper.
Thu, Jul 13, 10:24 AM

Wed, Jul 12

djasper accepted D35296: [clang-format] Keep level of comment before an empty line.

Some small comments, otherwise looks good.

Wed, Jul 12, 8:09 AM
djasper added a reviewer for D35296: [clang-format] Keep level of comment before an empty line: klimek.
Wed, Jul 12, 3:41 AM
djasper added a comment to D35296: [clang-format] Keep level of comment before an empty line.

I still think we should make this dependent on the current indentation. Why do you think this is better?

Wed, Jul 12, 3:41 AM

Tue, Jul 11

djasper added a comment to D34824: clang-format: add an option -verbose to list the files being processed.

Generally upload diffs with full context to phabricator. That makes reviewing much easier.

Tue, Jul 11, 10:25 PM · Restricted Project
djasper added inline comments to D34225: [clang-format] Teach clang-format how to handle C++ coroutines.
Tue, Jul 11, 10:10 PM
djasper added inline comments to D34225: [clang-format] Teach clang-format how to handle C++ coroutines.
Tue, Jul 11, 8:13 AM

Fri, Jul 7

djasper committed rL307383: Fix uninitalized memory access introduced in r307350..
Fix uninitalized memory access introduced in r307350.
Fri, Jul 7, 3:23 AM

Thu, Jul 6

djasper accepted D35015: [clang-format] Add space between a message field key and the opening bracket in proto messages.

Looks good.

Thu, Jul 6, 6:23 AM

Tue, Jul 4

djasper added inline comments to D33589: clang-format: consider not splitting tokens in optimization.
Tue, Jul 4, 1:51 AM
djasper accepted D34953: clang-format: [JS] space between pseudo keywords and template literals..
Tue, Jul 4, 1:27 AM

Mon, Jul 3

djasper accepted D34441: [clang-format] Support text proto messages.
Mon, Jul 3, 7:56 AM
djasper accepted D34938: clang-format: [JS] space between pseudo keywords and template literals..
Mon, Jul 3, 7:34 AM

Fri, Jun 30

djasper added inline comments to D34441: [clang-format] Support text proto messages.
Fri, Jun 30, 7:22 AM
djasper added a comment to D34824: clang-format: add an option -verbose to list the files being processed.

Can you add a test? Tests for this kind of behavior of the clang-format command line go in test/Format/.

Fri, Jun 30, 7:13 AM · Restricted Project
djasper committed rL306804: Fix heap use after free introduced by r306769..
Fix heap use after free introduced by r306769.
Fri, Jun 30, 1:03 AM

Thu, Jun 29

djasper committed rL306793: Revert "r306541 - Add zero-length check to memcpy/memset load store loop….
Revert "r306541 - Add zero-length check to memcpy/memset load store loop…
Thu, Jun 29, 11:37 PM
djasper committed rL306792: Revert "r306473 - re-commit r306336: Enable vectorizer-maximize-bandwidth by….
Revert "r306473 - re-commit r306336: Enable vectorizer-maximize-bandwidth by…
Thu, Jun 29, 11:32 PM
djasper committed rL306676: Revert "r306529 - [X86] Correct dwarf unwind information in function epilogue".
Revert "r306529 - [X86] Correct dwarf unwind information in function epilogue"
Thu, Jun 29, 6:59 AM
djasper accepted D34749: [clang-format] Fix parsing of msg{field}-style proto options.

Looks good.

Thu, Jun 29, 4:56 AM
djasper accepted D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting..

Looks good. Thank you.

Thu, Jun 29, 4:56 AM

Wed, Jun 28

djasper added a comment to D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting..

Just make clang-format always do this. I don't think anyone is relying on the current behavior.

Wed, Jun 28, 10:03 AM

Tue, Jun 27

djasper accepted D34621: [clang-format] Support <>-style proto message fields.

Looks good.

Tue, Jun 27, 6:30 AM
djasper accepted D34623: [clang-format] Add a test for associative map proto buffer fields.

Looks good. Thank you!

Tue, Jun 27, 2:49 AM

Mon, Jun 26

djasper added a comment to D34623: [clang-format] Add a test for associative map proto buffer fields.

Can you create a more interesting test case where the map definition spans multiple lines? Possibly use qualified names for the field types.

Mon, Jun 26, 8:20 AM
djasper accepted D34395: clang-format: add options to merge empty record body.

Looks good.

Mon, Jun 26, 6:34 AM
djasper added a comment to D34395: clang-format: add options to merge empty record body.

Yes merge them into those two, please. I think we introduced the others because of some linux style, but generally lets try not to introduce options that people aren't going to use.

Mon, Jun 26, 1:32 AM
djasper added inline comments to D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting..
Mon, Jun 26, 12:59 AM

Sun, Jun 25

djasper added a reviewer for D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set: klimek.
Sun, Jun 25, 11:18 PM
djasper added a comment to D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set.

I don't want to move forward with this patch. But adding Manuel as another reviewer to sanity-check.

Sun, Jun 25, 11:18 PM
djasper added a comment to D34395: clang-format: add options to merge empty record body.

Do you know of a style guide that would actually want to handle class, structs and unions differently? In most of Clang, they are handled as "records" and fundamentally, they are so alike that I'd hope that people always want the same behavior for all of them.

Sun, Jun 25, 11:10 PM
djasper accepted D34238: clang-format: Do not binpack initialization lists.

Looks good. Thank you!

Sun, Jun 25, 11:09 PM
djasper committed rL306252: Revert "[LoopSimplify] Factor the logic to form dedicated exits into a utility.".
Revert "[LoopSimplify] Factor the logic to form dedicated exits into a utility."
Sun, Jun 25, 1:55 PM

Fri, Jun 23

djasper added a comment to D34443: DISCUSS investigate multiline <>-message fields in proto options.

I am not really sure. Dict literals seems cleaner, but it might confuse us in other places.

Fri, Jun 23, 6:01 AM
djasper accepted D34552: [clang-format] Update dump_format_style.py to indent nested fields.

Looks good.

Fri, Jun 23, 4:10 AM

Thu, Jun 22

djasper committed rL306026: Updating branches/google/stable to r305862.
Updating branches/google/stable to r305862
Thu, Jun 22, 10:26 AM
djasper committed rL306015: Creating tags/google/stable/2017-06-22 from r305862.
Creating tags/google/stable/2017-06-22 from r305862
Thu, Jun 22, 9:42 AM
djasper committed rL306016: Updating branches/google/stable to r305862.
Updating branches/google/stable to r305862
Thu, Jun 22, 9:42 AM
djasper committed rL306023: Creating tags/google/stable/2017-06-22 from r305862.
Creating tags/google/stable/2017-06-22 from r305862
Thu, Jun 22, 9:41 AM
djasper committed rL306024: Updating branches/google/stable to r305862.
Updating branches/google/stable to r305862
Thu, Jun 22, 9:41 AM
djasper committed rL306022: Updating branches/google/stable to r305862.
Updating branches/google/stable to r305862
Thu, Jun 22, 9:26 AM
djasper committed rL306021: Creating tags/google/stable/2017-06-22 from r305862.
Creating tags/google/stable/2017-06-22 from r305862
Thu, Jun 22, 9:24 AM
djasper committed rL306014: Cleaning up stable branch.
Cleaning up stable branch
Thu, Jun 22, 9:21 AM
djasper committed rL306020: Updating branches/google/stable to r305862.
Updating branches/google/stable to r305862
Thu, Jun 22, 9:18 AM
djasper committed rL306019: Creating tags/google/stable/2017-06-22 from r305862.
Creating tags/google/stable/2017-06-22 from r305862
Thu, Jun 22, 9:16 AM
djasper committed rL306018: Updating branches/google/stable to r305862.
Updating branches/google/stable to r305862
Thu, Jun 22, 9:13 AM
djasper committed rL306017: Creating tags/google/stable/2017-06-22 from r305862.
Creating tags/google/stable/2017-06-22 from r305862
Thu, Jun 22, 9:09 AM

Jun 21 2017

djasper added a comment to D34443: DISCUSS investigate multiline <>-message fields in proto options.

So, what do you want to discuss? The problem is (I think) that we treat a colon as "this can't be a template" in TokenAnnotator::parseAngle. We probably shouldn't do that for proto text.

Jun 21 2017, 8:54 AM
djasper accepted D34399: clang-format: introduce InlineOnly short function style.

Looks good.

Jun 21 2017, 5:08 AM
djasper added inline comments to D34399: clang-format: introduce InlineOnly short function style.
Jun 21 2017, 1:23 AM

Jun 19 2017

djasper added a comment to D34351: [clang-format] Simplify TT_SelectorName assignment logic.

For the test introduced in https://reviews.llvm.org/rL262291, either of the changes causes a TT_SelectorName to become a TT_Unknown. So lets figure out how to make this a difference in observable formatting behavior instead of removing these checks.

Jun 19 2017, 8:27 AM
djasper accepted D33491: clang-format: Fix C99 designated initializers corner cases.

Looks good.

Jun 19 2017, 6:05 AM
djasper added inline comments to D33491: clang-format: Fix C99 designated initializers corner cases.
Jun 19 2017, 3:21 AM
djasper closed D32825: [clang-format] Improve understanding of combined typedef+record declarations.

Renamed Tok to RecordTok to avoid the nested scope and submitted as r305667.

Jun 19 2017, 12:46 AM
djasper committed rL305667: clang-format: Improve understanding of combined typedef+record declarations.
clang-format: Improve understanding of combined typedef+record declarations
Jun 19 2017, 12:46 AM
djasper closed D26953: clang-format: handle formatting on constexpr if.

Submitted the other implementation of this as r305666.

Jun 19 2017, 12:42 AM
djasper closed D34330: [clang-format] handle `if constexpr`.

Yes, I saw. As this version seems to handle the one-line case correctly, I submitted this one as r305666.

Jun 19 2017, 12:41 AM
djasper committed rL305666: clang-format: Handle "if constexpr"..
clang-format: Handle "if constexpr".
Jun 19 2017, 12:41 AM
djasper closed D32429: Add capability to format the diff on save to clang-format's vim integration.
Jun 19 2017, 12:31 AM
djasper added a comment to D32429: Add capability to format the diff on save to clang-format's vim integration.

Submitted as r305665.

Jun 19 2017, 12:31 AM
djasper committed rL305665: clang-format: Add capability to format the diff on save in vim..
clang-format: Add capability to format the diff on save in vim.
Jun 19 2017, 12:30 AM

Jun 18 2017

djasper accepted D34330: [clang-format] handle `if constexpr`.

Looks good. Thanks for implementing this.

Jun 18 2017, 10:54 PM

Jun 16 2017

djasper committed rL305574: Ignore return value in test..
Ignore return value in test.
Jun 16 2017, 12:30 PM

Jun 15 2017

djasper added a comment to D34238: clang-format: Do not binpack initialization lists.

I am fine not bin-packing when the last element has a trailing comma. But lets not special case assignments.

Jun 15 2017, 8:12 AM
djasper committed rL305456: Revert "Define _GNU_SOURCE for rtems c++".
Revert "Define _GNU_SOURCE for rtems c++"
Jun 15 2017, 2:18 AM

Jun 14 2017

djasper accepted D32480: clang-format: Add CompactNamespaces option.

Yeah, looks good.

Jun 14 2017, 4:26 AM · Restricted Project

Jun 13 2017

djasper added a comment to D32480: clang-format: Add CompactNamespaces option.

Ok. Works for me.

Jun 13 2017, 12:38 AM · Restricted Project
djasper committed rL305271: Read /out:%t which was (accidentally?) removed in r305258..
Read /out:%t which was (accidentally?) removed in r305258.
Jun 13 2017, 12:00 AM

Jun 12 2017

djasper accepted D33447: clang-format: add option to merge empty function body.

Looks good.

Jun 12 2017, 7:43 AM
djasper committed rL305182: Revert r305164/5/7..
Revert r305164/5/7.
Jun 12 2017, 1:09 AM

Jun 6 2017

djasper edited reviewers for D33857: Correctly Indent Nested JavaScript Literals., added: mprobst; removed: djasper.
Jun 6 2017, 5:30 AM · Restricted Project
djasper edited reviewers for D33823: [clang-format] Support sorting using declarations, added: klimek; removed: djasper.
Jun 6 2017, 5:29 AM

May 30 2017

djasper removed a reviewer for D32059: Make AssumptionCache's interface return a range of Values: djasper.
May 30 2017, 4:54 AM

May 29 2017

djasper accepted D33641: clang-format: [JS] do not clean up duplicated commas..
May 29 2017, 1:40 AM
djasper added inline comments to D33641: clang-format: [JS] do not clean up duplicated commas..
May 29 2017, 1:27 AM
djasper accepted D33640: clang-format: [JS] fix indenting bound functions..
May 29 2017, 12:43 AM

May 26 2017

djasper added inline comments to D33447: clang-format: add option to merge empty function body.
May 26 2017, 8:42 AM
djasper added a comment to D33447: clang-format: add option to merge empty function body.

Lets try this the other way around. I am not ok with introducing an additional top-level option for this. It simply isn't important enough. So find a way for the existing style flags to support what you need and not regress existing users. If that can't be done, I am also ok with adding another value into BraceWrapping (which you suggested at some point, I think).

May 26 2017, 7:13 AM
djasper added a comment to D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set.
In D32478#765642, @Typz wrote:

Nop, it's formatted like this:

bool a = aaaaaa   //
          == bbbb //
      && ccccc;
 
bool a = aaaaaa //
      == bbbb   //
             + ccccc;

The current way to format operators is not affected: the indentation is done as "usual", then they are unindented by the operator width to keep the alignment...

May 26 2017, 7:00 AM
djasper added a comment to D33447: clang-format: add option to merge empty function body.

I think it's just wrong that WebKit inherits this. The style guide explicitly says that this is wrong:

May 26 2017, 6:26 AM
djasper added a comment to D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set.
In D32478#765583, @Typz wrote:

I actually don't know how, but it still manages somehow : I rebuilt this exact patch to ensure I gave you the correct output.
And the same behavior can be seen in the test cases, where the operator with highest precedence is aligned with the equal sign.

May 26 2017, 6:20 AM
djasper added a comment to D33447: clang-format: add option to merge empty function body.

I don't understand. WebKit style would not set AllowShortFunctionsOnASingleLine and so the behavior there wouldn't change, I presume?

May 26 2017, 5:43 AM
djasper committed rL303974: Remove unnecessary double-assignment triggering -Wsequence-point..
Remove unnecessary double-assignment triggering -Wsequence-point.
May 26 2017, 5:07 AM