djasper (Daniel Jasper)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 10:15 AM (279 w, 6 d)

Recent Activity

Fri, Nov 17

djasper accepted D40178: clang-format: [JS] remove trailing lines in arrow functions..

Looks good. There is a chance that some people do not want this in their coding style. But if so, we can add an option later.

Fri, Nov 17, 9:49 AM
djasper added a comment to D40178: clang-format: [JS] remove trailing lines in arrow functions..

Is this different for C++ lambdas? I would think that we never should add an empty line before the "}" of a child block.

Fri, Nov 17, 8:30 AM

Fri, Nov 10

djasper committed rL317901: [clang-format] Handle leading comments in using declaration.
[clang-format] Handle leading comments in using declaration
Fri, Nov 10, 9:12 AM
djasper closed D39478: [clang-format] Handle leading comments in using declaration.

Submitted as r317901.

Fri, Nov 10, 9:11 AM
djasper accepted D39806: [clang-format] Support python-style comments in text protos.
Fri, Nov 10, 12:53 AM

Thu, Nov 9

djasper added a comment to D33440: clang-format: better handle statement macros.

Out of curiosity, will this be able to fix the two situations that you get for python extension?
There, you usually have a PyObject_HEAD with out semicolon in a struct and than a PyObject_HEAD_INIT(..) in a braced init list. More info:
http://starship.python.net/crew/mwh/toext/node20.html

Thu, Nov 9, 1:15 AM

Tue, Nov 7

djasper accepted D39478: [clang-format] Handle leading comments in using declaration.

Looks good. Do you have submit access?

Tue, Nov 7, 2:19 AM

Mon, Nov 6

djasper closed D39587: [clang-format] Handle unary operator overload with arguments and specifiers.
Mon, Nov 6, 4:12 AM
djasper accepted D39587: [clang-format] Handle unary operator overload with arguments and specifiers.
Mon, Nov 6, 4:12 AM
djasper added a comment to D39587: [clang-format] Handle unary operator overload with arguments and specifiers.

Submitted as r317473. Thank you!

Mon, Nov 6, 4:12 AM
djasper committed rL317473: [clang-format] Handle unary operator overload with arguments and specifiers.
[clang-format] Handle unary operator overload with arguments and specifiers
Mon, Nov 6, 4:12 AM

Fri, Nov 3

djasper added a comment to D39587: [clang-format] Handle unary operator overload with arguments and specifiers.

Looks good, thank you.

Fri, Nov 3, 1:48 AM

Wed, Nov 1

djasper accepted D39478: [clang-format] Handle leading comments in using declaration.

Some minor remarks, but generally looks good. Thanks for fixing this!

Wed, Nov 1, 12:12 PM

Oct 18 2017

djasper accepted D39024: [clang-format] Sort whole block of using declarations while partially formatting.

LG.

Oct 18 2017, 2:21 PM
djasper committed rL316121: Creating tags/google/stable/2017-10-18 from r315680.
Creating tags/google/stable/2017-10-18 from r315680
Oct 18 2017, 12:40 PM
djasper committed rL316122: Updating branches/google/stable to r315680.
Updating branches/google/stable to r315680
Oct 18 2017, 12:40 PM
djasper committed rL316120: Updating branches/google/stable to r315680.
Updating branches/google/stable to r315680
Oct 18 2017, 12:31 PM
djasper committed rL316119: Creating tags/google/stable/2017-10-18 from r315680.
Creating tags/google/stable/2017-10-18 from r315680
Oct 18 2017, 12:30 PM
djasper committed rL316112: Updating branches/google/stable to r315680.
Updating branches/google/stable to r315680
Oct 18 2017, 12:30 PM
djasper committed rL316111: Creating tags/google/stable/2017-10-18 from r315680.
Creating tags/google/stable/2017-10-18 from r315680
Oct 18 2017, 12:29 PM
djasper committed rL316116: Updating branches/google/stable to r315680.
Updating branches/google/stable to r315680
Oct 18 2017, 12:25 PM
djasper committed rL316115: Creating tags/google/stable/2017-10-18 from r315680.
Creating tags/google/stable/2017-10-18 from r315680
Oct 18 2017, 12:24 PM
djasper committed rL316114: Updating branches/google/stable to r315680.
Updating branches/google/stable to r315680
Oct 18 2017, 12:23 PM
djasper committed rL316113: Creating tags/google/stable/2017-10-18 from r315680.
Creating tags/google/stable/2017-10-18 from r315680
Oct 18 2017, 12:21 PM
djasper added inline comments to D39024: [clang-format] Sort whole block of using declarations while partially formatting.
Oct 18 2017, 11:31 AM

Oct 13 2017

djasper committed rL315680: Revert r314923: "Recommit : Use the basic cost if a GEP is not used as….
Revert r314923: "Recommit : Use the basic cost if a GEP is not used as…
Oct 13 2017, 7:04 AM

Oct 12 2017

djasper accepted D37695: [clang-format] Break non-trailing comments, try 2.

looks good.

Oct 12 2017, 7:11 AM
djasper committed rL315576: Reinstantiate old/bad deduplication logic that was removed in r315279..
Reinstantiate old/bad deduplication logic that was removed in r315279.
Oct 12 2017, 6:25 AM
djasper added a comment to D37979: ClangFormat - Add one space in inline empty function that can be wrapped on a single line. .

I believe that this extra option is not worth its cost in terms of maintainability and (more importantly) discoverability of options. You say that the behavior is documented in your coding style, but it is not (probably for the same reason). There isn't even a single example of this, I think. As such, I don't think we should go forward with adding this option.

Oct 12 2017, 12:35 AM

Oct 11 2017

djasper committed rL315439: Revert r314955: "Remove PendingBody mechanism for function and ObjC method….
Revert r314955: "Remove PendingBody mechanism for function and ObjC method…
Oct 11 2017, 12:48 AM

Oct 1 2017

djasper committed rL314622: Revert r314579: "Recommi r314561 after fixing over-debug assertion"..
Revert r314579: "Recommi r314561 after fixing over-debug assertion".
Oct 1 2017, 2:55 AM

Sep 30 2017

djasper committed rL314589: Revert r314435: "[JumpThreading] Preserve DT and LVI across the pass".
Revert r314435: "[JumpThreading] Preserve DT and LVI across the pass"
Sep 30 2017, 4:59 AM

Sep 28 2017

djasper committed rL314408: Creating tags/google/stable/2017-09-28 from r313876.
Creating tags/google/stable/2017-09-28 from r313876
Sep 28 2017, 4:18 AM
djasper committed rL314409: Updating branches/google/stable to r313876.
Updating branches/google/stable to r313876
Sep 28 2017, 4:18 AM
djasper committed rL314407: Updating branches/google/stable to r313876.
Updating branches/google/stable to r313876
Sep 28 2017, 4:08 AM
djasper committed rL314406: Creating tags/google/stable/2017-09-28 from r313876.
Creating tags/google/stable/2017-09-28 from r313876
Sep 28 2017, 4:08 AM
djasper committed rL314399: Updating branches/google/stable to r313876.
Updating branches/google/stable to r313876
Sep 28 2017, 4:08 AM
djasper committed rL314398: Creating tags/google/stable/2017-09-28 from r313876.
Creating tags/google/stable/2017-09-28 from r313876
Sep 28 2017, 4:08 AM
djasper committed rL314402: Creating tags/google/stable/2017-09-28 from r313876.
Creating tags/google/stable/2017-09-28 from r313876
Sep 28 2017, 4:04 AM
djasper committed rL314403: Updating branches/google/stable to r313876.
Updating branches/google/stable to r313876
Sep 28 2017, 4:04 AM
djasper committed rL314401: Updating branches/google/stable to r313876.
Updating branches/google/stable to r313876
Sep 28 2017, 4:03 AM
djasper committed rL314400: Creating tags/google/stable/2017-09-28 from r313876.
Creating tags/google/stable/2017-09-28 from r313876
Sep 28 2017, 4:02 AM

Sep 26 2017

djasper added inline comments to D37695: [clang-format] Break non-trailing comments, try 2.
Sep 26 2017, 3:30 PM
djasper accepted D38243: [clang-format] Add ext/ to google include categories.

Looks good.

Sep 26 2017, 3:30 PM

Sep 21 2017

djasper committed rL313876: Revert r313825: "[IR] Add llvm.dbg.addr, a control-dependent version of llvm..
Revert r313825: "[IR] Add llvm.dbg.addr, a control-dependent version of llvm.
Sep 21 2017, 5:09 AM

Sep 19 2017

djasper added a comment to D33589: clang-format: consider not splitting tokens in optimization.

I think doing the computation twice is fine. Or at least, I'd need a test case where it actually shows substantial overhead before doing what you are doing here. Understand that creating more States and making the State object itself larger also has cost and that cost occurs in the combinatorial exploration of the solution space. Doing an additional computation at the end should be comparatively cheap. Look at it this way: During the exploration of the solution space, we might enter breakProtrudingToken many times for the same comment. One more time during reconstruction of the solution is not that harmful.

Sep 19 2017, 5:02 AM

Sep 18 2017

djasper edited reviewers for D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true., added: krasimir; removed: djasper.
Sep 18 2017, 2:11 AM

Sep 14 2017

djasper added inline comments to D33440: clang-format: better handle statement macros.
Sep 14 2017, 2:30 AM
djasper added a comment to D33589: clang-format: consider not splitting tokens in optimization.

I still don't understand yet. breakProtrudingToken has basically two options:

Sep 14 2017, 12:58 AM

Sep 12 2017

djasper added a comment to D33440: clang-format: better handle statement macros.

I'd still prefer individual patches for each of these changes. If the code review system or VCS make it hard for you to deal with two adjacent changes this way, do them in sequence.

Sep 12 2017, 2:29 AM
djasper added a reviewer for D33440: clang-format: better handle statement macros: klimek.
Sep 12 2017, 2:14 AM
djasper added a comment to D37260: [clang-format] Fixed extern C brace wrapping.

BraceWrapping.AfterExternC makes sense to me.

Sep 12 2017, 2:14 AM
djasper added a comment to D33589: clang-format: consider not splitting tokens in optimization.

I have a slightly hard time grasping what this patch now actually does? Doesn't it simply try to decide whether or not to make a split locally be comparing the PenaltyBreakComment against the penalty for the access characters? If so, couldn't we simply do that as an implementation detail of breakProtrudingToken() without needing to let anything outside of it now and without introducing State.Reflow?

Sep 12 2017, 2:13 AM
djasper added a comment to D37260: [clang-format] Fixed extern C brace wrapping.

I am very strongly against a flag that just leaves the line break as is. What's the motivation?

Sep 12 2017, 1:59 AM

Sep 11 2017

djasper committed rL313007: Creating tags/google/stable/2017-09-12 from r312634.
Creating tags/google/stable/2017-09-12 from r312634
Sep 11 2017, 11:41 PM
djasper committed rL313008: Updating branches/google/stable to r312634.
Updating branches/google/stable to r312634
Sep 11 2017, 11:41 PM
djasper committed rL313006: Updating branches/google/stable to r312634.
Updating branches/google/stable to r312634
Sep 11 2017, 11:31 PM
djasper committed rL313005: Creating tags/google/stable/2017-09-12 from r312634.
Creating tags/google/stable/2017-09-12 from r312634
Sep 11 2017, 11:31 PM
djasper committed rL312998: Updating branches/google/stable to r312634.
Updating branches/google/stable to r312634
Sep 11 2017, 11:31 PM
djasper committed rL312997: Creating tags/google/stable/2017-09-12 from r312634.
Creating tags/google/stable/2017-09-12 from r312634
Sep 11 2017, 11:31 PM
djasper committed rL313002: Updating branches/google/stable to r312634.
Updating branches/google/stable to r312634
Sep 11 2017, 11:28 PM
djasper committed rL313001: Creating tags/google/stable/2017-09-12 from r312634.
Creating tags/google/stable/2017-09-12 from r312634
Sep 11 2017, 11:27 PM
djasper committed rL313000: Updating branches/google/stable to r312634.
Updating branches/google/stable to r312634
Sep 11 2017, 11:27 PM
djasper committed rL312999: Creating tags/google/stable/2017-09-12 from r312634.
Creating tags/google/stable/2017-09-12 from r312634
Sep 11 2017, 11:26 PM
djasper accepted D37685: clang-format: [JS] wrap and indent `goog.setTestOnly` calls..
Sep 11 2017, 7:30 AM
djasper committed rL312897: Revert r312830: "Reinstall the patch "Use EmitPointerWithAlignment to get….
Revert r312830: "Reinstall the patch "Use EmitPointerWithAlignment to get…
Sep 11 2017, 12:38 AM

Sep 7 2017

djasper accepted D37513: [clang-format] Fix documentation for AllowAllParametersOfDeclarationOnNextLine.

Submitted as r312721. Thank you.

Sep 7 2017, 6:47 AM
djasper committed rL312721: [clang-format] Fix documentation for AllowAllParametersOfDeclarationOnNextLine.
[clang-format] Fix documentation for AllowAllParametersOfDeclarationOnNextLine
Sep 7 2017, 6:47 AM
djasper accepted D37132: [clang-format] Add support for C++17 structured bindings..

Looks good. Sorry for the delay.

Sep 7 2017, 6:44 AM
djasper accepted D37513: [clang-format] Fix documentation for AllowAllParametersOfDeclarationOnNextLine.

Also run dump_format_style.py and keep the changed .rst file in this change.

Sep 7 2017, 5:00 AM
djasper accepted D37558: Refresh the clang format options doc with the recent changes.

Thank you.

Sep 7 2017, 4:31 AM
djasper accepted D37531: Add an usage example of BreakBeforeBraces.

Looks good.

Sep 7 2017, 4:30 AM
djasper added a comment to D37531: Add an usage example of BreakBeforeBraces.

This change needs to be made to include/clang/Format/Format.h and then the rst file needs to be regenerated with docs/tools/dump_format_style.py.

Sep 7 2017, 2:58 AM

Sep 6 2017

djasper added a comment to D37513: [clang-format] Fix documentation for AllowAllParametersOfDeclarationOnNextLine.

Note that these changes need to be made to the corresponding comments in include/clang/Format/Format.h and then this file is auto-generated with docs/tools/dump_format_style.py.

Sep 6 2017, 6:30 AM

Sep 5 2017

djasper added inline comments to D35943: [clang-format] Format raw string literals.
Sep 5 2017, 7:45 AM

Sep 4 2017

djasper committed rL312484: clang-format: Fix indentation of macros in include guards (after r312125)..
clang-format: Fix indentation of macros in include guards (after r312125).
Sep 4 2017, 6:35 AM

Sep 3 2017

djasper committed rL312437: clang-format: Fix formatting of for loops with multiple increments..
clang-format: Fix formatting of for loops with multiple increments.
Sep 3 2017, 1:57 AM

Sep 1 2017

djasper removed a reviewer for D37372: [XRay][compiler-rt] Make __xray_CustomEvent PIC friendlier and build a dynamic version of the XRay runtime: djasper.
Sep 1 2017, 12:39 AM

Aug 31 2017

djasper committed rL312243: Revert r311525: "[XRay][CodeGen] Use PIC-friendly code in XRay sleds; remove….
Revert r311525: "[XRay][CodeGen] Use PIC-friendly code in XRay sleds; remove…
Aug 31 2017, 8:18 AM

Aug 30 2017

djasper committed rL312219: Revert r312194: "[MachineOutliner] Add missed optimization remarks for the….
Revert r312194: "[MachineOutliner] Add missed optimization remarks for the…
Aug 30 2017, 11:23 PM

Aug 29 2017

djasper accepted D37136: [clang-format] Do not format likely xml.

Just a few minor comments, otherwise looks good.

Aug 29 2017, 5:12 AM
djasper added a comment to D37132: [clang-format] Add support for C++17 structured bindings..

Are you changing the line endings here? Phabricator tells me that basically all the lines change. If so, please don't ;).

Aug 29 2017, 5:10 AM
djasper accepted D37143: [clang-format] Fixed typedef enum brace wrapping.

Looks good. Thank you.

Aug 29 2017, 5:02 AM

Aug 28 2017

djasper added inline comments to D37142: clang-format: [JS] simplify template string wrapping..
Aug 28 2017, 3:19 AM
djasper added inline comments to D37142: clang-format: [JS] simplify template string wrapping..
Aug 28 2017, 2:12 AM
djasper accepted D37142: clang-format: [JS] simplify template string wrapping..

Yay for *removing* complexity for a change :).
Let me know how it goes in practice.

Aug 28 2017, 12:44 AM

Aug 27 2017

djasper accepted D37192: [clang-format] Add support for generic Obj-C categories.

Looks good.

Aug 27 2017, 11:17 PM

Aug 25 2017

djasper committed rL311792: [Format] Invert nestingAndIndentLevel pair in WhitespaceManager used for.
[Format] Invert nestingAndIndentLevel pair in WhitespaceManager used for
Aug 25 2017, 12:16 PM

Aug 24 2017

djasper accepted D35955: clang-format: Add preprocessor directive indentation.

From my side this looks good for now (we can always improve more later). Krasimir, what do you think?

Aug 24 2017, 7:55 AM · Restricted Project
djasper accepted D37109: [clang-format] Emit absolute splits before lines for comments, try 2.

Does the test still test the same thing if you set the column limit to 60 and remove 20 spaces? If not, this is fine.

Aug 24 2017, 7:27 AM

Aug 23 2017

djasper added inline comments to D35955: clang-format: Add preprocessor directive indentation.
Aug 23 2017, 7:10 AM · Restricted Project
djasper accepted D36956: [clang-format] Emit absolute splits before lines for comments.

Looks good.

Aug 23 2017, 5:13 AM

Aug 22 2017

djasper added a comment to D35955: clang-format: Add preprocessor directive indentation.

Krasimir: Can you actually give this a round of review? I will also try to do so tomorrow.

Aug 22 2017, 10:38 AM · Restricted Project
djasper added a reviewer for D35955: clang-format: Add preprocessor directive indentation: krasimir.
Aug 22 2017, 10:38 AM · Restricted Project
djasper accepted D37007: [clang-format] Break non-trailing block comments.

If no tests break with this, lets just go for it. We can follow up and fix individual cases if we find undesired behavior.

Aug 22 2017, 7:38 AM
djasper accepted D37011: [clang-format] Fix lines regression in clang-format.py.

Thank you

Aug 22 2017, 7:22 AM

Aug 21 2017

djasper added inline comments to D36614: [clang-format] Refine trailing comment detection.
Aug 21 2017, 11:58 PM
djasper added inline comments to D36956: [clang-format] Emit absolute splits before lines for comments.
Aug 21 2017, 11:51 PM
djasper added inline comments to D36967: [clang-format] Align trailing comments if ColumnLimit is 0.
Aug 21 2017, 12:28 PM
djasper accepted D36967: [clang-format] Align trailing comments if ColumnLimit is 0.
Aug 21 2017, 8:42 AM