- User Since
- Jul 10 2012, 10:15 AM (262 w, 3 d)
Wed, Jul 19
Tue, Jul 18
Yeah, improving the testsuite generally seems like a good idea. But unrelated to this patch. This looks good now.
So, there are two things in this patch: Statement macros and namespace macros. Lets break this out and handle them individually. They really aren't related that much.
Thu, Jul 13
Wed, Jul 12
Some small comments, otherwise looks good.
I still think we should make this dependent on the current indentation. Why do you think this is better?
Tue, Jul 11
Generally upload diffs with full context to phabricator. That makes reviewing much easier.
Fri, Jul 7
Thu, Jul 6
Tue, Jul 4
Mon, Jul 3
Fri, Jun 30
Can you add a test? Tests for this kind of behavior of the clang-format command line go in test/Format/.
Thu, Jun 29
Looks good. Thank you.
Wed, Jun 28
Just make clang-format always do this. I don't think anyone is relying on the current behavior.
Tue, Jun 27
Looks good. Thank you!
Mon, Jun 26
Can you create a more interesting test case where the map definition spans multiple lines? Possibly use qualified names for the field types.
Yes merge them into those two, please. I think we introduced the others because of some linux style, but generally lets try not to introduce options that people aren't going to use.
Sun, Jun 25
I don't want to move forward with this patch. But adding Manuel as another reviewer to sanity-check.
Do you know of a style guide that would actually want to handle class, structs and unions differently? In most of Clang, they are handled as "records" and fundamentally, they are so alike that I'd hope that people always want the same behavior for all of them.
Looks good. Thank you!
Fri, Jun 23
I am not really sure. Dict literals seems cleaner, but it might confuse us in other places.
Thu, Jun 22
Jun 21 2017
So, what do you want to discuss? The problem is (I think) that we treat a colon as "this can't be a template" in TokenAnnotator::parseAngle. We probably shouldn't do that for proto text.
Jun 19 2017
For the test introduced in https://reviews.llvm.org/rL262291, either of the changes causes a TT_SelectorName to become a TT_Unknown. So lets figure out how to make this a difference in observable formatting behavior instead of removing these checks.
Renamed Tok to RecordTok to avoid the nested scope and submitted as r305667.
Submitted the other implementation of this as r305666.
Yes, I saw. As this version seems to handle the one-line case correctly, I submitted this one as r305666.
Submitted as r305665.
Jun 18 2017
Looks good. Thanks for implementing this.
Jun 16 2017
Jun 15 2017
I am fine not bin-packing when the last element has a trailing comma. But lets not special case assignments.
Jun 14 2017
Yeah, looks good.
Jun 13 2017
Ok. Works for me.
Jun 12 2017
Jun 6 2017
May 30 2017
May 29 2017
May 26 2017
Lets try this the other way around. I am not ok with introducing an additional top-level option for this. It simply isn't important enough. So find a way for the existing style flags to support what you need and not regress existing users. If that can't be done, I am also ok with adding another value into BraceWrapping (which you suggested at some point, I think).
I think it's just wrong that WebKit inherits this. The style guide explicitly says that this is wrong:
I don't understand. WebKit style would not set AllowShortFunctionsOnASingleLine and so the behavior there wouldn't change, I presume?