djasper (Daniel Jasper)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 10 2012, 10:15 AM (249 w, 6 d)

Recent Activity

Yesterday

djasper committed rL301182: clang-format: Fix bad corner case in formatting of function types..
clang-format: Fix bad corner case in formatting of function types.
Mon, Apr 24, 7:41 AM
djasper created D32429: Add capability to format the diff on save to clang-format's vim integration.
Mon, Apr 24, 6:00 AM

Sun, Apr 23

djasper added inline comments to D28462: clang-format: Add new style option AlignConsecutiveMacros.
Sun, Apr 23, 4:40 PM · Restricted Project
djasper committed rL301123: Creating tags/google/stable/2017-04-23 from r300801.
Creating tags/google/stable/2017-04-23 from r300801
Sun, Apr 23, 7:15 AM
djasper committed rL301124: Updating branches/google/stable to r300801.
Updating branches/google/stable to r300801
Sun, Apr 23, 7:15 AM
djasper committed rL301122: Updating branches/google/stable to r300801.
Updating branches/google/stable to r300801
Sun, Apr 23, 6:42 AM
djasper committed rL301114: Updating branches/google/stable to r300801.
Updating branches/google/stable to r300801
Sun, Apr 23, 6:41 AM
djasper committed rL301121: Creating tags/google/stable/2017-04-23 from r300801.
Creating tags/google/stable/2017-04-23 from r300801
Sun, Apr 23, 6:41 AM
djasper committed rL301113: Creating tags/google/stable/2017-04-23 from r300801.
Creating tags/google/stable/2017-04-23 from r300801
Sun, Apr 23, 6:41 AM
djasper committed rL301120: Updating branches/google/stable to r300801.
Updating branches/google/stable to r300801
Sun, Apr 23, 6:27 AM
djasper committed rL301119: Creating tags/google/stable/2017-04-23 from r300801.
Creating tags/google/stable/2017-04-23 from r300801
Sun, Apr 23, 6:24 AM
djasper committed rL301112: Cleaning up stable branch.
Cleaning up stable branch
Sun, Apr 23, 6:23 AM
djasper committed rL301118: Updating branches/google/stable to r300801.
Updating branches/google/stable to r300801
Sun, Apr 23, 6:20 AM
djasper committed rL301117: Creating tags/google/stable/2017-04-23 from r300801.
Creating tags/google/stable/2017-04-23 from r300801
Sun, Apr 23, 6:18 AM
djasper committed rL301116: Updating branches/google/stable to r300801.
Updating branches/google/stable to r300801
Sun, Apr 23, 6:16 AM
djasper committed rL301115: Creating tags/google/stable/2017-04-23 from r300801.
Creating tags/google/stable/2017-04-23 from r300801
Sun, Apr 23, 6:13 AM

Fri, Apr 21

djasper accepted D32298: [clang-format] Replace IncompleteFormat by a struct with Line.

Sounds good.

Fri, Apr 21, 7:34 AM
djasper added inline comments to D32298: [clang-format] Replace IncompleteFormat by a struct with Line.
Fri, Apr 21, 4:51 AM

Thu, Apr 20

djasper added inline comments to D32298: [clang-format] Replace IncompleteFormat by a struct with Line.
Thu, Apr 20, 11:12 PM

Tue, Apr 18

djasper added inline comments to D28462: clang-format: Add new style option AlignConsecutiveMacros.
Tue, Apr 18, 11:35 PM · Restricted Project
djasper committed rL300661: clang-format: Properly match parens of macro parameter lists..
clang-format: Properly match parens of macro parameter lists.
Tue, Apr 18, 11:19 PM
djasper added inline comments to D32170: Add a FixItHint for -Wmissing-prototypes to insert 'static '..
Tue, Apr 18, 2:49 PM

Sun, Apr 16

djasper added inline comments to D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and &s to the right.
Sun, Apr 16, 10:13 PM

Tue, Apr 11

djasper added inline comments to D31881: DRAFT [clang-format] Format raw string proto text literals.
Tue, Apr 11, 12:31 AM

Mon, Apr 10

djasper accepted D31408: Add more examples to clang-format configuration.

Yes, thank you!

Mon, Apr 10, 11:12 PM
djasper accepted D31706: [clang-format] Handle NSString literals by merging tokens..

Looks good. Thanks for cleaning this up.

Mon, Apr 10, 10:36 PM

Wed, Apr 5

djasper accepted D31698: clang-format: [JS] fix whitespace around "of" operator..
Wed, Apr 5, 1:16 AM

Sat, Apr 1

djasper added a comment to D31574: [clang-format] update documentation.

This file is auto-generated from include/clang/format/Format.h. Changes need to be made there and then this files needs to be regenerated with docs/tools/dump_format_style.py. Sorry, we probably need to make that more obvious.

Sat, Apr 1, 11:36 PM · Restricted Project
djasper accepted D31575: [clang-format] Use configured IndentWidth instead of 2.

looks good

Sat, Apr 1, 11:20 PM

Fri, Mar 31

djasper committed rL299214: clang-format: Fix post-commit review comment of r299204, use Style.isCpp()..
clang-format: Fix post-commit review comment of r299204, use Style.isCpp().
Fri, Mar 31, 6:42 AM
djasper committed rL299204: clang-format: [JavaScript] Ignore QT keywords..
clang-format: [JavaScript] Ignore QT keywords.
Fri, Mar 31, 5:17 AM

Thu, Mar 30

djasper added a comment to D31408: Add more examples to clang-format configuration.

Generally please upload diffs with more contexts. For some here it's not even clear to which option they refer ;)

Thu, Mar 30, 11:47 PM

Tue, Mar 28

djasper edited reviewers for D31441: [clang-format] fix crash in NamespaceEndCommentsFixer (PR32438), added: krasimir; removed: djasper.
Tue, Mar 28, 2:42 PM

Mon, Mar 27

djasper added a comment to D31334: [clang-format] Add options for indenting preprocessor directives.

Thank you for working on this. Unfortunately, this is done at the wrong level:

  • You are using a separate pass, which means that as soon as the preprocessor directives exceed the column limit, they won't be wrapped correctly.
  • You aren't using Clang's Lexer to separate PP directives into tokens, which might work in the short term, but seems really fragile and a maintenance headache.
Mon, Mar 27, 10:47 PM
djasper added inline comments to D28462: clang-format: Add new style option AlignConsecutiveMacros.
Mon, Mar 27, 10:32 PM · Restricted Project
djasper committed rL298853: Look through CXXBindTemporaryExprs when checking CXXFunctionCastExprs.
Look through CXXBindTemporaryExprs when checking CXXFunctionCastExprs
Mon, Mar 27, 9:42 AM

Sun, Mar 26

djasper added inline comments to D28462: clang-format: Add new style option AlignConsecutiveMacros.
Sun, Mar 26, 11:54 PM · Restricted Project

Mar 22 2017

djasper accepted D30777: Added `applyAtomicChanges` function..

Looks good.. Very nice :)

Mar 22 2017, 11:54 AM

Mar 20 2017

djasper accepted D30990: Add more examples to clang-format configuration.

Looks good, just minor remarks.

Mar 20 2017, 4:14 AM

Mar 16 2017

djasper committed rL297931: clang-format: Fix bug in wrapping behavior of operators..
clang-format: Fix bug in wrapping behavior of operators.
Mar 16 2017, 1:06 AM

Mar 13 2017

djasper committed rL297696: clang-format: Make it very slighly more expensive to wrap between "= {"..
clang-format: Make it very slighly more expensive to wrap between "= {".
Mar 13 2017, 5:52 PM
djasper edited reviewers for D30863: [clang-format] make docs/tools/{dump_format_style.py,dump_ast_matchers.py} flake8 compliant, added: klimek; removed: djasper.
Mar 13 2017, 2:57 AM
djasper accepted D30860: [clang-format] Add more examples and fix a bug in the py generation script.

Looks good.

Mar 13 2017, 2:57 AM
djasper accepted D30883: clang-format: [JS] do not wrap @see tags..

Looks good.

Mar 13 2017, 2:46 AM
djasper accepted D30874: clang-format: [JS] do not wrap after interface and type..

Looks good.

Mar 13 2017, 12:01 AM

Mar 10 2017

djasper added inline comments to D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.
Mar 10 2017, 6:30 AM · Restricted Project

Mar 9 2017

djasper added inline comments to D30777: Added `applyAtomicChanges` function..
Mar 9 2017, 11:20 AM
djasper accepted D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.

A few nits, otherwise looks good.

Mar 9 2017, 8:31 AM · Restricted Project
djasper added a comment to D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.

I think the patch is fine, except for the name of the flag. It is not breaking inheritance ;).

Mar 9 2017, 7:35 AM · Restricted Project

Mar 8 2017

djasper accepted D30740: Remove a useless subsitution in doxygen2rst which was incorrectly replacing * by \*.

Looks good.

Mar 8 2017, 2:48 PM
djasper accepted D30734: Add more examples to clang-format configuration.

Please upload patches with full context or use arc (https://secure.phabricator.com/book/phabricator/article/arcanist/).

Mar 8 2017, 5:21 AM
djasper accepted D30575: [clang-format] Look at NoLineBreak and NoLineBreakInOperand before breakProtrudingToken.

Looks good.

Mar 8 2017, 5:05 AM
djasper added inline comments to D30575: [clang-format] Look at NoLineBreak and NoLineBreakInOperand before breakProtrudingToken.
Mar 8 2017, 3:32 AM
djasper committed rL297268: clang-format: Get slightly better at understanding */&..
clang-format: Get slightly better at understanding */&.
Mar 8 2017, 2:01 AM
djasper accepted D30705: clang-format: [JS] allow breaking after non-null assertions..
Mar 8 2017, 1:41 AM

Mar 7 2017

djasper added inline comments to D30705: clang-format: [JS] allow breaking after non-null assertions..
Mar 7 2017, 10:38 AM
djasper accepted D30646: ClangFormat - When adding a comment at the end of a return type declaration, the function name is incorrectly indented.

Looks good, thank you!

Mar 7 2017, 6:36 AM · Restricted Project
djasper accepted D30688: [clang-format] Support namespaces ending in semicolon.

Minor nit, otherwise looks good.

Mar 7 2017, 6:12 AM

Mar 6 2017

djasper accepted D30659: [clang-format] Make NamespaceEndCommentFixer add at most one comment.

Would probably be interesting to add these test cases:

Mar 6 2017, 8:44 AM
djasper added inline comments to D30646: ClangFormat - When adding a comment at the end of a return type declaration, the function name is incorrectly indented.
Mar 6 2017, 8:26 AM · Restricted Project
djasper accepted D30532: Add examples to clang-format configuration.

Looks good. Thank you for doing this!

Mar 6 2017, 8:12 AM
djasper added a comment to D30646: ClangFormat - When adding a comment at the end of a return type declaration, the function name is incorrectly indented.

Thanks for catching and fixing this.
Generally, please upload diffs with the full file as context. That way, phabricator allows expanding the code around your changes.

Mar 6 2017, 8:07 AM · Restricted Project

Mar 3 2017

djasper added a comment to D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.

Hm. Unfortunately, this seems to have been implemented to support Webkit style and Webkit style is explicit about wanting this (https://webkit.org/code-style-guidelines/) :(.

Mar 3 2017, 5:09 AM · Restricted Project
djasper added inline comments to D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.
Mar 3 2017, 4:57 AM · Restricted Project
djasper added a comment to D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.

Do you know whether that is intentional? The style guide isn't really conclusive.

Mar 3 2017, 4:55 AM · Restricted Project
djasper added a comment to D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.

Before '? Can you give an example?

Mar 3 2017, 4:49 AM · Restricted Project
djasper added a comment to D30532: Add examples to clang-format configuration.

I agree, just generally we should aim for keeping these short.

Mar 3 2017, 3:12 AM
djasper added inline comments to D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.
Mar 3 2017, 2:07 AM · Restricted Project
djasper added a comment to D30532: Add examples to clang-format configuration.

Sure, then go ahead. If these examples would have helped you, that's one datapoint :).

Mar 3 2017, 2:02 AM
djasper added a comment to D30532: Add examples to clang-format configuration.

Hm. I don't actually know whether these examples are useful as is. You only present one setting of the value in most cases. What's interesting is actually how the flag changes the behavior. I mean in most cases, this can be derived from the example, but in those cases, it's also fairly obvious what the flag does. Unfortunately, I also don't have a significantly better idea. Maybe something like https://clangformat.com/ is just better at handling this?

Mar 3 2017, 1:53 AM

Mar 2 2017

djasper requested changes to D30111: [clang-format] Add a test to check at once all the Mozilla coding style.

So, while it might be convenient to view this all in one file, a test here is not convenient for me (or presumably other clang-format developers) to work with. You can make a pretty much 1:1 copy of it using a raw string literal in unittests. However, I don't think this is actually a good idea.

Mar 2 2017, 10:29 PM
djasper added inline comments to D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.
Mar 2 2017, 8:13 AM · Restricted Project
djasper added a comment to D30111: [clang-format] Add a test to check at once all the Mozilla coding style.

Please don't add this as is. I don't usually run the file-based tests in my development workflow and suspect that I might be breaking this a lot.

Mar 2 2017, 7:58 AM
djasper added a comment to D30492: [clang-format] Allow all but the first string literal in a sequence to be put on a newline.

As discussed offline, I think this solves the wrong problem. My guess is that breakProtrudingToken checks State.Stack.back().NoLinebreak, but I forget to make it also check NoLinebreakInOperand.

Mar 2 2017, 4:31 AM
djasper accepted D30528: [clang-format] Use number of unwrapped lines for short namespace.

Please include the reasoning in the patch description, i.e. that otherwise clang-format might need to runs to add all the namespace comments.

Mar 2 2017, 1:50 AM

Mar 1 2017

djasper committed rL296664: clang-format: [JS] Properly format object literals with shorthands..
clang-format: [JS] Properly format object literals with shorthands.
Mar 1 2017, 11:59 AM
djasper committed rL296659: clang-format: [JS/TS] Properly understand cast expressions..
clang-format: [JS/TS] Properly understand cast expressions.
Mar 1 2017, 11:38 AM
djasper added a comment to D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration.

Could you please upload a diff with the entire file as context? That makes reviewing this easier.

Mar 1 2017, 7:51 AM · Restricted Project
djasper accepted D30405: [clang-format] Add a new flag FixNamespaceComments to FormatStyle.

LG

Mar 1 2017, 6:59 AM
djasper committed rL296608: Fix r296605 so that stuff in #ifndef SWIG blocks is still formatted..
Fix r296605 so that stuff in #ifndef SWIG blocks is still formatted.
Mar 1 2017, 3:22 AM
djasper added inline comments to D30405: [clang-format] Add a new flag FixNamespaceComments to FormatStyle.
Mar 1 2017, 3:08 AM
djasper committed rL296605: clang-format: Ignore contents of #ifdef SWIG .. #endif blocks..
clang-format: Ignore contents of #ifdef SWIG .. #endif blocks.
Mar 1 2017, 2:59 AM

Feb 28 2017

djasper committed rL296499: clang-format: [Java] Fix bug in enum formatting..
clang-format: [Java] Fix bug in enum formatting.
Feb 28 2017, 10:40 AM
djasper accepted D30452: Blacklist @mods and several other JSDoc tags from wrapping..
Feb 28 2017, 3:15 AM
djasper added inline comments to D30452: Blacklist @mods and several other JSDoc tags from wrapping..
Feb 28 2017, 2:54 AM

Feb 27 2017

djasper added a comment to D30269: [clang-format] Add a NamespaceEndCommentsFixer.

On by default for LLVM and Google style, don't know about the others.

Feb 27 2017, 5:32 AM
djasper accepted D30269: [clang-format] Add a NamespaceEndCommentsFixer.

Looks good.

Feb 27 2017, 5:26 AM
djasper added inline comments to D30399: clang-format: [JS] whitespace after async in arrow functions..
Feb 27 2017, 3:13 AM
djasper added inline comments to D30269: [clang-format] Add a NamespaceEndCommentsFixer.
Feb 27 2017, 2:44 AM

Feb 26 2017

djasper committed rL296295: Revert "[CGP] Split some critical edges coming out of indirect branches".
Revert "[CGP] Split some critical edges coming out of indirect branches"
Feb 26 2017, 3:21 AM

Feb 25 2017

djasper committed rL296249: Add static_cast to silence -Wc++11-narrowing..
Add static_cast to silence -Wc++11-narrowing.
Feb 25 2017, 12:05 AM

Feb 23 2017

djasper added inline comments to D30297: DRAFT [clang-format] Compute matching block lines during parsing..
Feb 23 2017, 6:33 AM
djasper added a comment to D30269: [clang-format] Add a NamespaceEndCommentsFixer.

An unwrapped line can contain many braces, but (I think/hope) only one that belongs to a non-nested block. So every unwrapped line that opens a namespace/class/function/enum/... should have exactly one counterpart that closes it again.

Feb 23 2017, 3:02 AM
djasper added a comment to D30269: [clang-format] Add a NamespaceEndCommentsFixer.

I started reviewing, but after a while it occurred to me that some of this might not be the right approach. We are essentially duplicating the parsing of namespaces, which is already done in UnwrappedLineParser. Lets instead just store more information in the AnnotatedLines (or FormatTokens) to carry the required information forward.

Feb 23 2017, 12:23 AM

Feb 20 2017

djasper committed rL295663: clang-format: [JS] Improve line-wrapping behavior of template strings..
clang-format: [JS] Improve line-wrapping behavior of template strings.
Feb 20 2017, 7:02 AM
djasper committed rL295659: clang-format: Prevent weird line-wraps in complex lambda introducers.
clang-format: Prevent weird line-wraps in complex lambda introducers
Feb 20 2017, 4:55 AM
djasper committed rL295658: clang-format: [JS/TS] Improve detection for array subscripts in types..
clang-format: [JS/TS] Improve detection for array subscripts in types.
Feb 20 2017, 4:55 AM

Feb 19 2017

djasper committed rL295623: s/REQUIRES: Asserts/REQUIRES: asserts/.
s/REQUIRES: Asserts/REQUIRES: asserts/
Feb 19 2017, 3:37 PM

Feb 17 2017

djasper committed rL295437: clang-format: Don't remove existing spaces between identifier and ::..
clang-format: Don't remove existing spaces between identifier and ::.
Feb 17 2017, 2:55 AM

Feb 15 2017

djasper committed rL295162: Revert r295110 and r295144..
Revert r295110 and r295144.
Feb 15 2017, 2:07 AM