- User Since
- Sun, Jun 24, 6:54 AM (3 w, 1 d)
Sat, Jul 14
The change is OK but I have some questions regarding tests.
Could you provide some tests for the issue?
Adding new nodes is always welcome.
LGTM. Just some stylish nits.
To resolve this issue, I used Sema::DeclareImplicit... methods. But I like this approach much more because it doesn't allows to forget different kinds of implicit methods and doesn't require passing Sema into ASTImporter.
This looks mostly good but I have a question inline.
Wed, Jul 11
Thank you Gabor!
Sun, Jul 8
LGTM too. Thank you!
I like the new syntax. There are some comments inline; most of them are just stylish.
Wed, Jul 4
LG with a nit. Thank you!
This change is good, just some cleanup is needed.
Sat, Jun 30
Sun, Jun 24
LGTM, thank you!