a_sidorin (Aleksei Sidorin)
User

Projects

User does not belong to any projects.

User Details

User Since
Sun, Jun 24, 6:54 AM (3 w, 1 d)

Recent Activity

Sat, Jul 14

a_sidorin added a comment to D49296: [ASTImporter] Fix import of unnamed structs.

Hi Gabor,
The change is OK but I have some questions regarding tests.

Sat, Jul 14, 11:18 PM
a_sidorin added a comment to D49300: [ASTImporter] Fix poisonous structural equivalence cache.

Hi Gabor,
Could you provide some tests for the issue?

Sat, Jul 14, 11:07 PM
a_sidorin added a comment to D49293: [ASTImporter] Add support for import of CXXInheritedCtorInitExpr..

Adding new nodes is always welcome.

Sat, Jul 14, 10:56 PM
a_sidorin accepted D49245: [ASTImporter] Import implicit methods of existing class..

LGTM. Just some stylish nits.
To resolve this issue, I used Sema::DeclareImplicit... methods. But I like this approach much more because it doesn't allows to forget different kinds of implicit methods and doesn't require passing Sema into ASTImporter.

Sat, Jul 14, 10:42 PM
a_sidorin added a comment to D49235: [ASTImporter] Import described template (if any) of function..

Hello Balasz,
This looks mostly good but I have a question inline.

Sat, Jul 14, 10:23 PM

Wed, Jul 11

a_sidorin accepted D47632: [ASTImporter] Refactor Decl creation.

Thank you Gabor!

Wed, Jul 11, 2:59 PM

Sun, Jul 8

a_sidorin accepted D48941: [ASTImporter] import FunctionDecl end locations.

LGTM too. Thank you!

Sun, Jul 8, 3:36 PM
a_sidorin added inline comments to D48628: [AST] Structural equivalence of methods.
Sun, Jul 8, 3:32 PM
a_sidorin added a comment to D47632: [ASTImporter] Refactor Decl creation.

Hi Gabor,
I like the new syntax. There are some comments inline; most of them are just stylish.

Sun, Jul 8, 3:29 PM

Wed, Jul 4

a_sidorin accepted D48628: [AST] Structural equivalence of methods.

LG with a nit. Thank you!

Wed, Jul 4, 10:44 PM
a_sidorin added a comment to D48941: [ASTImporter] import FunctionDecl end locations.

Hello Rafael.
This change is good, just some cleanup is needed.

Wed, Jul 4, 2:14 PM
a_sidorin accepted D48773: [ASTImporter] Fix import of objects with anonymous types.

Nice!

Wed, Jul 4, 1:52 PM

Sat, Jun 30

a_sidorin added a comment to D48773: [ASTImporter] Fix import of objects with anonymous types.

Hello Gabor,

Sat, Jun 30, 12:02 AM

Sun, Jun 24

a_sidorin added a comment to D47459: [ASTImporter] Eliminated some unittest warnings..

Hello Balázs,

Sun, Jun 24, 3:42 PM
a_sidorin accepted D47367: [ASTImporter] Add ms compatibility to tests.

LGTM, thank you!

Sun, Jun 24, 3:36 PM
a_sidorin accepted D47532: [ASTImporter] Import the whole redecl chain of functions.

Hi Gabor,

Sun, Jun 24, 3:28 PM
a_sidorin accepted D47534: [ASTImporter] Add new tests about templated-described swing.

Hi Gabor,

Sun, Jun 24, 2:08 PM
a_sidorin added a comment to D47450: [ASTImporter] Use InjectedClassNameType at import of templated record..

Hello Balázs,

Sun, Jun 24, 1:31 PM