- User Since
- Jun 24 2018, 6:54 AM (13 w, 1 d)
Sun, Sep 16
Sat, Sep 15
Sun, Sep 9
The change looks mostly fine but the difference with ASTReader approach disturbs me a bit.
Sun, Sep 2
Aug 23 2018
Aug 22 2018
Thank you for working on this!
Wow, I totally overlooked this. Thank you!
Aug 21 2018
Aug 20 2018
These methods will be really useful.
Aug 19 2018
Aug 15 2018
As a side note: It seems this test case actually reveals that we don't import the body of Foo's destructor?
This is strange. If you manage to find the reason, please notify us!
Hello Gabor and Balazs,
Tests are always welcome. Thanks!
Aug 13 2018
All declarations are reordered now, not only fields. Also some review comments were addressed.
Aug 11 2018
Aug 8 2018
Yes, this seems to be correct. Thanks!
LGTM! Just a stylish nit.
Aug 3 2018
The approach is OK but I have some minor comments inline.
Aug 1 2018
LGTM. Thank you!
Jul 16 2018
Thank you Gabor!
Jul 14 2018
The change is OK but I have some questions regarding tests.
Could you provide some tests for the issue?
Adding new nodes is always welcome.
LGTM. Just some stylish nits.
To resolve this issue, I used Sema::DeclareImplicit... methods. But I like this approach much more because it doesn't allows to forget different kinds of implicit methods and doesn't require passing Sema into ASTImporter.
This looks mostly good but I have a question inline.
Jul 11 2018
Thank you Gabor!
Jul 8 2018
LGTM too. Thank you!
I like the new syntax. There are some comments inline; most of them are just stylish.
Jul 4 2018
LG with a nit. Thank you!
This change is good, just some cleanup is needed.
Jun 30 2018
Jun 24 2018
LGTM, thank you!