a_sidorin (Aleksei Sidorin)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 24 2018, 6:54 AM (13 w, 1 d)

Recent Activity

Sun, Sep 16

a_sidorin added a comment to D51633: [ASTImporter] Added error handling for AST import..

Hi Gabor,

Sun, Sep 16, 3:52 PM

Sat, Sep 15

a_sidorin accepted D51597: [ASTImporter] Fix import of VarDecl init.
Sat, Sep 15, 3:10 PM

Sun, Sep 9

a_sidorin added a comment to D51597: [ASTImporter] Fix import of VarDecl init.

Hi Gabor,
The change looks mostly fine but the difference with ASTReader approach disturbs me a bit.

Sun, Sep 9, 2:06 PM

Sun, Sep 2

a_sidorin accepted D51533: [ASTImporter] Merge ExprBits.

Looks good, thanks!

Sun, Sep 2, 1:51 PM

Aug 23 2018

a_sidorin accepted D51178: [ASTImporter] Add test for importing anonymous namespaces..
Aug 23 2018, 11:30 PM
a_sidorin accepted D51142: [ASTImporter] Add test for PackExpansionExpr.
Aug 23 2018, 11:17 PM

Aug 22 2018

a_sidorin accepted D51056: [ASTImporter] Add test for SwitchStmt.

Thank you for working on this!

Aug 22 2018, 3:32 PM
a_sidorin accepted D51110: [ASTImporter] Remove duplicated and dead CXXNamedCastExpr handling code..
Aug 22 2018, 3:30 PM
a_sidorin accepted D51115: [ASTImporter] Actually test ArrayInitLoopExpr in the array-init-loop-expr test..

Wow, I totally overlooked this. Thank you!

Aug 22 2018, 3:26 PM
a_sidorin accepted D51121: [ASTImporter] Add test for ObjCAtTryStmt/ObjCAtCatchStmt/ObjCAtThrowStmt.
Aug 22 2018, 3:24 PM
a_sidorin accepted D51123: [ASTImporter] Add test for ObjCAutoreleasePoolStmt.
Aug 22 2018, 3:19 PM
a_sidorin accepted D51059: [ASTImporter] Add test for ObjCTypeParamDecl.
Aug 22 2018, 3:19 PM

Aug 21 2018

a_sidorin accepted D50451: [ASTImporter] Fix import of class templates partial specialization.

Thank you!

Aug 21 2018, 11:33 PM

Aug 20 2018

a_sidorin requested changes to D50662: Add dump() method for SourceRange.

Hello Stephen,
These methods will be really useful.

Aug 20 2018, 3:02 PM
a_sidorin accepted D50978: [ASTImporter] Add test for C++'s try/catch statements..
Aug 20 2018, 1:45 PM

Aug 19 2018

a_sidorin accepted D49798: [ASTImporter] Adding some friend function related unittests..
Aug 19 2018, 8:15 AM
a_sidorin accepted D50928: [ASTImporter] Test for importing condition variable from a ForStmt.
Aug 19 2018, 8:09 AM
a_sidorin added inline comments to D50451: [ASTImporter] Fix import of class templates partial specialization.
Aug 19 2018, 8:08 AM
a_sidorin accepted D50932: [ASTImporter] Add test for C++ casts and fix broken const_cast importing..

Thank you!

Aug 19 2018, 6:44 AM
a_sidorin accepted D50737: [ASTImporter] Add test for CXXNoexceptExpr.

Thanks!

Aug 19 2018, 6:41 AM

Aug 15 2018

a_sidorin accepted D50812: [ASTImporter] Add test for ForStmt and ContinueStmt.
Aug 15 2018, 5:14 PM
a_sidorin accepted D50735: [ASTImporter] Add test for CXXScalarValueInit.
Aug 15 2018, 5:09 PM
a_sidorin accepted D50732: [ASTImporter] Add test for CXXDefaultInitExpr.

As a side note: It seems this test case actually reveals that we don't import the body of Foo's destructor?

This is strange. If you manage to find the reason, please notify us!

Aug 15 2018, 5:08 PM
a_sidorin added a comment to D49798: [ASTImporter] Adding some friend function related unittests..

Hi Balasz,

Aug 15 2018, 5:03 PM
a_sidorin added a comment to D50672: [ASTImporter] Change the return result of Decl import to Optional .

Hello Gabor and Balazs,

Aug 15 2018, 4:56 PM
a_sidorin added inline comments to D44100: [ASTImporter] Reorder fields after structure import is finished.
Aug 15 2018, 3:51 PM
a_sidorin accepted D50733: [ASTImporter] Add test for ArrayInitLoopExpr.
Aug 15 2018, 3:50 PM
a_sidorin accepted D50731: [ASTImporter] Add test for ExprWithCleanups.

Tests are always welcome. Thanks!

Aug 15 2018, 3:45 PM

Aug 13 2018

a_sidorin added inline comments to D44100: [ASTImporter] Reorder fields after structure import is finished.
Aug 13 2018, 3:59 PM
a_sidorin updated the diff for D44100: [ASTImporter] Reorder fields after structure import is finished.

All declarations are reordered now, not only fields. Also some review comments were addressed.

Aug 13 2018, 3:57 PM
a_sidorin commandeered D44100: [ASTImporter] Reorder fields after structure import is finished.
Aug 13 2018, 3:55 PM
a_sidorin created D50672: [ASTImporter] Change the return result of Decl import to Optional .
Aug 13 2018, 3:52 PM

Aug 11 2018

a_sidorin accepted D50550: [ASTImporter] Added test case for opaque enums.

LGTM!

Aug 11 2018, 1:32 PM
a_sidorin accepted D50552: [ASTImporter] Added test case for CXXConversionDecl importing.

Thanks!

Aug 11 2018, 1:28 PM
a_sidorin accepted D50516: [ASTImporter] Improved import of friend templates..
Aug 11 2018, 1:26 PM
a_sidorin added a comment to D49798: [ASTImporter] Adding some friend function related unittests..

Hi Balazs,

Aug 11 2018, 10:46 AM
a_sidorin added a comment to D46940: [ASTImporter] make sure that ACtx::getParents still works.

Hello Richard,

Aug 11 2018, 8:06 AM
a_sidorin added a comment to D50451: [ASTImporter] Fix import of class templates partial specialization.

Hi Gabor,

Aug 11 2018, 8:01 AM

Aug 8 2018

a_sidorin accepted D50444: [ASTImporter] Fix structural inequivalency of forward EnumDecl.

Yes, this seems to be correct. Thanks!

Aug 8 2018, 3:39 PM
a_sidorin accepted D50428: [ASTImporter] Add support for importing imaginary literals.

LGTM! Just a stylish nit.

Aug 8 2018, 2:59 PM

Aug 3 2018

a_sidorin added inline comments to D49223: [AST] Check described template at structural equivalence check..
Aug 3 2018, 3:17 PM · Restricted Project
a_sidorin added a comment to D49796: [ASTImporter] Load external Decls when getting field index..

Hi Balázs,
The approach is OK but I have some minor comments inline.

Aug 3 2018, 2:06 PM

Aug 1 2018

a_sidorin accepted D49792: [ASTmporter] SourceRange-free function parameter checking for declarations.

LGTM. Thank you!

Aug 1 2018, 7:41 AM
a_sidorin added inline comments to D49223: [AST] Check described template at structural equivalence check..
Aug 1 2018, 7:28 AM · Restricted Project

Jul 16 2018

a_sidorin added inline comments to D49293: [ASTImporter] Add support for import of CXXInheritedCtorInitExpr..
Jul 16 2018, 3:55 PM
a_sidorin accepted D49235: [ASTImporter] Import described template (if any) of function..

LGTM.

Jul 16 2018, 3:54 PM
a_sidorin accepted D49296: [ASTImporter] Fix import of unnamed structs.

Thank you Gabor!

Jul 16 2018, 3:51 PM
a_sidorin accepted D49300: [ASTImporter] Fix poisonous structural equivalence cache.

Hi Gabor,

Jul 16 2018, 3:29 PM

Jul 14 2018

a_sidorin added a comment to D49296: [ASTImporter] Fix import of unnamed structs.

Hi Gabor,
The change is OK but I have some questions regarding tests.

Jul 14 2018, 11:18 PM
a_sidorin added a comment to D49300: [ASTImporter] Fix poisonous structural equivalence cache.

Hi Gabor,
Could you provide some tests for the issue?

Jul 14 2018, 11:07 PM
a_sidorin added a comment to D49293: [ASTImporter] Add support for import of CXXInheritedCtorInitExpr..

Adding new nodes is always welcome.

Jul 14 2018, 10:56 PM
a_sidorin accepted D49245: [ASTImporter] Import implicit methods of existing class..

LGTM. Just some stylish nits.
To resolve this issue, I used Sema::DeclareImplicit... methods. But I like this approach much more because it doesn't allows to forget different kinds of implicit methods and doesn't require passing Sema into ASTImporter.

Jul 14 2018, 10:42 PM
a_sidorin added a comment to D49235: [ASTImporter] Import described template (if any) of function..

Hello Balasz,
This looks mostly good but I have a question inline.

Jul 14 2018, 10:23 PM

Jul 11 2018

a_sidorin accepted D47632: [ASTImporter] Refactor Decl creation.

Thank you Gabor!

Jul 11 2018, 2:59 PM

Jul 8 2018

a_sidorin accepted D48941: [ASTImporter] import FunctionDecl end locations.

LGTM too. Thank you!

Jul 8 2018, 3:36 PM
a_sidorin added inline comments to D48628: [AST] Structural equivalence of methods.
Jul 8 2018, 3:32 PM
a_sidorin added a comment to D47632: [ASTImporter] Refactor Decl creation.

Hi Gabor,
I like the new syntax. There are some comments inline; most of them are just stylish.

Jul 8 2018, 3:29 PM

Jul 4 2018

a_sidorin accepted D48628: [AST] Structural equivalence of methods.

LG with a nit. Thank you!

Jul 4 2018, 10:44 PM
a_sidorin added a comment to D48941: [ASTImporter] import FunctionDecl end locations.

Hello Rafael.
This change is good, just some cleanup is needed.

Jul 4 2018, 2:14 PM
a_sidorin accepted D48773: [ASTImporter] Fix import of objects with anonymous types.

Nice!

Jul 4 2018, 1:52 PM

Jun 30 2018

a_sidorin added a comment to D48773: [ASTImporter] Fix import of objects with anonymous types.

Hello Gabor,

Jun 30 2018, 12:02 AM

Jun 24 2018

a_sidorin added a comment to D47459: [ASTImporter] Eliminated some unittest warnings..

Hello Balázs,

Jun 24 2018, 3:42 PM
a_sidorin accepted D47367: [ASTImporter] Add ms compatibility to tests.

LGTM, thank you!

Jun 24 2018, 3:36 PM
a_sidorin accepted D47532: [ASTImporter] Import the whole redecl chain of functions.

Hi Gabor,

Jun 24 2018, 3:28 PM
a_sidorin accepted D47534: [ASTImporter] Add new tests about templated-described swing.

Hi Gabor,

Jun 24 2018, 2:08 PM
a_sidorin added a comment to D47450: [ASTImporter] Use InjectedClassNameType at import of templated record..

Hello Balázs,

Jun 24 2018, 1:31 PM