Page MenuHomePhabricator

jdennett (James Dennett)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 23 2012, 12:53 PM (553 w, 2 d)

Recent Activity

Jan 15 2019

jdennett added a comment to D56731: Add -Wctad-maybe-unsupported to diagnose CTAD on types with no user defined deduction guides..

For my own use-cases, I will continue to want a 100% comprehensive -Wctad. All these "heuristics" you're proposing seem very ad-hoc, and make a lot of work for the compiler vendor, and seem complicated enough that I would still worry about bugs slipping through the cracks. Whereas, if the user can simply 100% outlaw CTAD, then they don't ever have to worry.

Jan 15 2019, 3:45 PM

Nov 27 2018

jdennett committed rL347679: Documentation: add \file markup as needed..
Documentation: add \file markup as needed.
Nov 27 2018, 9:56 AM

Jul 18 2018

jdennett committed rL337431: Documentation: fix a typo in the AST Matcher Reference docs..
Documentation: fix a typo in the AST Matcher Reference docs.
Jul 18 2018, 4:26 PM
jdennett committed rC337431: Documentation: fix a typo in the AST Matcher Reference docs..
Documentation: fix a typo in the AST Matcher Reference docs.
Jul 18 2018, 4:26 PM

Apr 30 2018

jdennett committed rOLDT331185: Add a missing `||` operator in a preprocessor condition..
Add a missing `||` operator in a preprocessor condition.
Apr 30 2018, 8:21 AM
jdennett committed rL331185: Add a missing `||` operator in a preprocessor condition..
Add a missing `||` operator in a preprocessor condition.
Apr 30 2018, 8:20 AM

Feb 2 2018

jdennett committed rC324142: More documentation cleanup for Decl.h..
More documentation cleanup for Decl.h.
Feb 2 2018, 1:40 PM
jdennett committed rL324142: More documentation cleanup for Decl.h..
More documentation cleanup for Decl.h.
Feb 2 2018, 1:40 PM
jdennett committed rL324133: Documentation cleanup, no functional change..
Documentation cleanup, no functional change.
Feb 2 2018, 12:24 PM
jdennett committed rC324133: Documentation cleanup, no functional change..
Documentation cleanup, no functional change.
Feb 2 2018, 12:24 PM

Jan 2 2017

jdennett committed rL290838: Extend documentation of how to test clang-tidy checks..
Extend documentation of how to test clang-tidy checks.
Jan 2 2017, 1:56 PM
jdennett closed D28189: Extend documentation of how to test clang-tidy checks..
Jan 2 2017, 1:56 PM
jdennett updated the diff for D28189: Extend documentation of how to test clang-tidy checks..

Addressed review comments: double-backtick quoting, underscores for references
to FileCheck, and change "matcher tests" to "clang-tidy tests".

Jan 2 2017, 1:50 PM
jdennett added a comment to D28189: Extend documentation of how to test clang-tidy checks..

Thanks for the review. I've address your comments, and will check over the (presumed-final) diff before submitting.

Jan 2 2017, 1:48 PM

Dec 30 2016

jdennett retitled D28189: Extend documentation of how to test clang-tidy checks. from to Extend documentation of how to test clang-tidy checks..
Dec 30 2016, 6:27 PM
jdennett committed rL290777: Typo fix in AST matcher documentation: s/aribtrary/arbitrary/.
Typo fix in AST matcher documentation: s/aribtrary/arbitrary/
Dec 30 2016, 5:14 PM

Aug 4 2016

jdennett added a comment to rL277342: Make RecursiveASTVisitor visit lambda capture initialization expressions.

I don't understand the intent of this patch.

Aug 4 2016, 10:08 AM

Aug 5 2015

jdennett committed rL244124: Documentation: fix another typo, "arrays types" -> "array types"..
Documentation: fix another typo, "arrays types" -> "array types".
Aug 5 2015, 1:59 PM
jdennett committed rL244104: Documentation: fix a typo, "This flag is determines" -> "This flag determines"..
Documentation: fix a typo, "This flag is determines" -> "This flag determines".
Aug 5 2015, 12:45 PM

Jul 16 2015

jdennett committed rL242485: Doxygen: Enable autobrief feature, matching llvm config/coding standards..
Doxygen: Enable autobrief feature, matching llvm config/coding standards.
Jul 16 2015, 4:18 PM
jdennett closed D11281: Doxygen: Enable autobrief feature, matching llvm config/coding standards..
Jul 16 2015, 4:17 PM
jdennett retitled D11281: Doxygen: Enable autobrief feature, matching llvm config/coding standards. from to Doxygen: Enable autobrief feature, matching llvm config/coding standards..
Jul 16 2015, 3:09 PM
jdennett committed rL242450: Documentation cleanup. No functional change intended..
Documentation cleanup. No functional change intended.
Jul 16 2015, 3:07 PM

Jul 15 2015

jdennett closed D11069: Allow any comment to be a trailing comment when -fparse-all-comments is on..

Committed as r242317.

Jul 15 2015, 12:14 PM
jdennett committed rL242317: Allow any comment to be a trailing comment when -fparse-all-comments is on..
Allow any comment to be a trailing comment when -fparse-all-comments is on.
Jul 15 2015, 12:13 PM

Jul 14 2015

jdennett committed rL242258: Documentation cleanup, mostly fixing summaries. No functional change intended..
Documentation cleanup, mostly fixing summaries. No functional change intended.
Jul 14 2015, 5:23 PM

Jun 11 2015

jdennett closed D9486: Replace the broken LambdaCapture::isInitCapture API..

That last patch was me losing a fight with arc. The clang-format patch is http://reviews.llvm.org/D10410. This one really is closed.

Jun 11 2015, 11:04 PM
jdennett updated subscribers of D10410: Improve formatting of lambda functions..
Jun 11 2015, 11:02 PM
jdennett updated D10410: Improve formatting of lambda functions..
Jun 11 2015, 11:02 PM
jdennett retitled D10410: Improve formatting of lambda functions. from to Improve formatting of lambda functions..
Jun 11 2015, 11:00 PM
jdennett updated the diff for D9486: Replace the broken LambdaCapture::isInitCapture API..

Improve formatting of lambda functions.

Jun 11 2015, 10:52 PM

May 11 2015

jdennett committed rL237068: Typo fix: s/initialzier/initializer/ in a doc comment..
Typo fix: s/initialzier/initializer/ in a doc comment.
May 11 2015, 4:29 PM

May 7 2015

jdennett committed rL236760: Replace the broken LambdaCapture::isInitCapture API..
Replace the broken LambdaCapture::isInitCapture API.
May 7 2015, 11:51 AM

May 5 2015

jdennett updated the diff for D9486: Replace the broken LambdaCapture::isInitCapture API..

Fixing formatting.

May 5 2015, 2:46 PM
jdennett updated the diff for D9486: Replace the broken LambdaCapture::isInitCapture API..

Coding style fix: change parameter name from capture to Capture.

May 5 2015, 2:28 PM
jdennett updated the diff for D9486: Replace the broken LambdaCapture::isInitCapture API..

Actually add the test.

May 5 2015, 2:27 PM
jdennett updated the diff for D9486: Replace the broken LambdaCapture::isInitCapture API..

Added tests, and fixed the fix.

May 5 2015, 2:26 PM

May 4 2015

jdennett added a reviewer for D9486: Replace the broken LambdaCapture::isInitCapture API.: rsmith.
May 4 2015, 12:51 PM
jdennett updated D9486: Replace the broken LambdaCapture::isInitCapture API..
May 4 2015, 12:49 PM
jdennett retitled D9486: Replace the broken LambdaCapture::isInitCapture API. from to Replace the broken LambdaCapture::isInitCapture API..
May 4 2015, 12:45 PM

Apr 6 2015

jdennett committed rL234221: Fix a call to std::unique to actually discard the trailing (junk) elements..
Fix a call to std::unique to actually discard the trailing (junk) elements.
Apr 6 2015, 2:26 PM

May 27 2014

jdennett closed D3926: Add range accessors for captures of a LambdaExpr..

Closed by commit rL209679 (authored by @jdennett).

May 27 2014, 12:20 PM
jdennett added a reviewer for D3926: Add range accessors for captures of a LambdaExpr.: aaron.ballman.
May 27 2014, 11:56 AM
jdennett retitled D3926: Add range accessors for captures of a LambdaExpr. from to Add range accessors for captures of a LambdaExpr..
May 27 2014, 10:59 AM