Page MenuHomePhabricator

omjavaid (Muhammad Omair Javaid)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 13 2015, 4:38 PM (375 w, 2 d)

Recent Activity

Yesterday

omjavaid added a comment to D124731: [lldb] Consider binary as module of last resort.

I have reverted this temporarily as It broke LLDB API test TestBadAddressBreakpoints.py

Sun, May 22, 11:31 PM · Restricted Project, Restricted Project
omjavaid added a reverting change for rGa3c3482ceb52: [lldb] Consider binary as module of last resort: rGb876c23604c7: Revert "[lldb] Consider binary as module of last resort".
Sun, May 22, 11:20 PM · Restricted Project
omjavaid committed rGb876c23604c7: Revert "[lldb] Consider binary as module of last resort" (authored by omjavaid).
Revert "[lldb] Consider binary as module of last resort"
Sun, May 22, 11:20 PM · Restricted Project
omjavaid added a reverting change for D124731: [lldb] Consider binary as module of last resort: rGb876c23604c7: Revert "[lldb] Consider binary as module of last resort".
Sun, May 22, 11:20 PM · Restricted Project, Restricted Project

Tue, May 17

omjavaid accepted D118794: [lldb] Remove non-address bits from read/write addresses in lldb.
Tue, May 17, 8:46 PM · Restricted Project, Restricted Project
omjavaid accepted D125090: [lldb] Add --show-tags option to "memory find".
Tue, May 17, 8:44 PM · Restricted Project, Restricted Project, Restricted Project
omjavaid accepted D125089: [lldb] Change implementation of memory read --show-tags option.
Tue, May 17, 8:44 PM · Restricted Project, Restricted Project

Tue, Apr 26

omjavaid accepted D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits.

LGTM. With a minor nit fix about FixAnyAddress vs FixDataAddress if required.

Tue, Apr 26, 3:29 AM · Restricted Project, Restricted Project

Mon, Apr 25

omjavaid added a comment to D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits.

Very corner case but Is there a possibility of masks changing positions during the life-time of an inferior ? So this makes me think that code/data masks are per process and cant be changes once set. Should we worry about it?AFAIK this is fine but just asking to clear any ambiguities.

Mon, Apr 25, 5:32 AM · Restricted Project, Restricted Project
omjavaid accepted D124000: [lldb] Add FixAnyAddress to ABI plugins.

Looks good to me.

Mon, Apr 25, 5:25 AM · Restricted Project, Restricted Project

Apr 20 2022

omjavaid committed rGe3cd8fedcac3: [LLDB] Skip TestCrashDuringStep.py AArch64/Windows (authored by omjavaid).
[LLDB] Skip TestCrashDuringStep.py AArch64/Windows
Apr 20 2022, 5:11 PM · Restricted Project
omjavaid committed rG5341b5f8d3ce: [LLDB] Update inspect getargspec to getfullargspec (authored by omjavaid).
[LLDB] Update inspect getargspec to getfullargspec
Apr 20 2022, 1:34 PM · Restricted Project
omjavaid closed D121786: [LLDB] Update inspect getargspec to getfullargspec.
Apr 20 2022, 1:34 PM · Restricted Project, Restricted Project

Apr 13 2022

omjavaid added a comment to D118979: [AArch64] Set maximum VF with shouldMaximizeVectorBandwidth.

um... I have tried to reproduce it on a64fx machine. It looks it is failed with the big number of parallel tasks of ninja build. When I run the failed command manually, it is passed... If I reduce the number of the parallel tasks with ninja build like ninja -j16, the build is also passed... it could be memory allocation error from the bigger memory allocation than before...
The stage2 build and check-all are passed on Cortex-A72 machine...
To be safe, for now, I would like to disable shouldMaximizeVectorBandwidth for SVE...
Let me update this patch with it.

I did have a completely difference experience, here are steps to reproduce:

Apr 13 2022, 2:54 PM · Restricted Project, Restricted Project

Apr 12 2022

omjavaid reopened D118979: [AArch64] Set maximum VF with shouldMaximizeVectorBandwidth.
Apr 12 2022, 4:54 PM · Restricted Project, Restricted Project
omjavaid added a reverting change for rG64b6192e8129: [AArch64] Set maximum VF with shouldMaximizeVectorBandwidth: rG42ebfa826947: Revert "[AArch64] Set maximum VF with shouldMaximizeVectorBandwidth".
Apr 12 2022, 4:54 PM · Restricted Project, Restricted Project
omjavaid committed rG42ebfa826947: Revert "[AArch64] Set maximum VF with shouldMaximizeVectorBandwidth" (authored by omjavaid).
Revert "[AArch64] Set maximum VF with shouldMaximizeVectorBandwidth"
Apr 12 2022, 4:54 PM · Restricted Project, Restricted Project
omjavaid added a comment to D118979: [AArch64] Set maximum VF with shouldMaximizeVectorBandwidth.

This broke LLVM AArch64 buildbot clang-aarch64-sve-vls-2stage
https://lab.llvm.org/buildbot/#/builders/176/builds/1515
llvm-tblgen crashes after applying this patch.

Apr 12 2022, 4:53 PM · Restricted Project, Restricted Project
omjavaid added a reverting change for D118979: [AArch64] Set maximum VF with shouldMaximizeVectorBandwidth: rG42ebfa826947: Revert "[AArch64] Set maximum VF with shouldMaximizeVectorBandwidth".
Apr 12 2022, 4:53 PM · Restricted Project, Restricted Project
omjavaid requested review of D123593: [MS][ARM64]: Use _setjmp instead of _setjmpex on AArch64.
Apr 12 2022, 5:25 AM · Restricted Project

Apr 8 2022

omjavaid added a comment to D118794: [lldb] Remove non-address bits from read/write addresses in lldb.

Thanks for good detailed explanation. I think from the code readability point of view, we may use FixAddress function which i believe already exists in ABI and if not then introduce FixAnyAddress may be. We can put all the comments about PAC/TBI code vs data address bits there in AArch64 ABI code instead of putting a comment about code/data address everytime we use FixDataAddress in generic code.

Apr 8 2022, 5:34 AM · Restricted Project, Restricted Project

Apr 7 2022

omjavaid added a comment to D118794: [lldb] Remove non-address bits from read/write addresses in lldb.

Switch to removing non-address bits in lldb instead of lldb-server.

The breakpoint issues I mention only really happen if you try to break on a tagged
function pointer. Which is pretty niche, but I hope to address it later anyway.

On the issue of whether to use FixData vs FixCode there's 2 maybe 3 ways to go:

  • Assume that they're the same, which does work for Linux, for now.
  • Add a method that does both fixes, on the assumption that the virtual address size for code and data is the same so no harm done and all bits will be removed either way.
  • Extensively track whether addresses refer to code or data. In some situations this is possible (looking at the exec bits of a memory mapping for example) but I don't have a great idea what that looks like at this time.

Option 2 seems like a good way to go for now.

Apr 7 2022, 2:00 AM · Restricted Project, Restricted Project

Apr 5 2022

omjavaid added a comment to D114545: [CodeGen] Async unwind - add a pass to fix CFI information.

Hi I have temporarily reverted this change as it has caused LLVM buildbot failures with failing fuzzer-threaded.test with clang crashing over an assertion failure in llvm/lib/CodeGen/CFIFixup.cpp. Kindly look into it. Thanks
.

Apr 5 2022, 1:14 AM · Restricted Project, Restricted Project
omjavaid added a reverting change for rG980c3e6dd223: [CodeGen] Async unwind - add a pass to fix CFI information: rG0320115c16fc: Revert "[CodeGen] Async unwind - add a pass to fix CFI information".
Apr 5 2022, 1:13 AM · Restricted Project, Restricted Project
omjavaid added a reverting change for D114545: [CodeGen] Async unwind - add a pass to fix CFI information: rG0320115c16fc: Revert "[CodeGen] Async unwind - add a pass to fix CFI information".
Apr 5 2022, 1:13 AM · Restricted Project, Restricted Project
omjavaid committed rG0320115c16fc: Revert "[CodeGen] Async unwind - add a pass to fix CFI information" (authored by omjavaid).
Revert "[CodeGen] Async unwind - add a pass to fix CFI information"
Apr 5 2022, 1:13 AM · Restricted Project, Restricted Project

Apr 4 2022

omjavaid committed rGa96638e50ef5: Revert "[NFCI] Regenerate PhaseOrdering test checks" (authored by omjavaid).
Revert "[NFCI] Regenerate PhaseOrdering test checks"
Apr 4 2022, 3:32 AM · Restricted Project, Restricted Project
omjavaid added a reverting change for rGe91fe08999d5: [NFCI] Regenerate PhaseOrdering test checks: rGa96638e50ef5: Revert "[NFCI] Regenerate PhaseOrdering test checks".
Apr 4 2022, 3:32 AM · Restricted Project, Restricted Project

Apr 1 2022

omjavaid committed rGa1901f501ca9: [LLDB] Fix TestJobControl.py decorators import (authored by omjavaid).
[LLDB] Fix TestJobControl.py decorators import
Apr 1 2022, 2:14 AM · Restricted Project
omjavaid committed rGc103eac9d859: [LLDB] Skip TestJobControl.py AArch64/Arm Linux (authored by omjavaid).
[LLDB] Skip TestJobControl.py AArch64/Arm Linux
Apr 1 2022, 1:59 AM · Restricted Project

Mar 28 2022

omjavaid committed rG5c6ee1305e77: [LLDB] Skip TestProcessIOHandlerInterrupt Arm/AArch64 Linux (authored by omjavaid).
[LLDB] Skip TestProcessIOHandlerInterrupt Arm/AArch64 Linux
Mar 28 2022, 12:36 AM · Restricted Project

Mar 16 2022

omjavaid added a comment to D121786: [LLDB] Update inspect getargspec to getfullargspec.

by python 11x release

Is this a typo or some numbering system not related to the 2.x/3.x cadence?

Mar 16 2022, 4:54 AM · Restricted Project, Restricted Project
omjavaid requested review of D121786: [LLDB] Update inspect getargspec to getfullargspec.
Mar 16 2022, 3:15 AM · Restricted Project, Restricted Project

Mar 8 2022

omjavaid committed rGde0b4f4b86fd: [LLDB] Skip TestIOHandlerProcessSTDIO.py for Arm/AArch64 Linux (authored by omjavaid).
[LLDB] Skip TestIOHandlerProcessSTDIO.py for Arm/AArch64 Linux
Mar 8 2022, 1:18 AM · Restricted Project

Feb 25 2022

omjavaid closed D120274: Add LLDB AArch64 Windows buildbot.
Feb 25 2022, 7:56 AM · Restricted Project
omjavaid committed rZORG3429c1d7bb8b: Add LLDB AArch64 Windows buildbot (authored by omjavaid).
Add LLDB AArch64 Windows buildbot
Feb 25 2022, 7:56 AM
omjavaid committed rGcc7bf4afeefc: [LLDB] XFAIL TestUnambiguousTailCalls.py for Arm/Linux (authored by omjavaid).
[LLDB] XFAIL TestUnambiguousTailCalls.py for Arm/Linux
Feb 25 2022, 4:10 AM
omjavaid committed rG317a2b1f6004: [LLDB] Remove XFAIL from minidebuginfo-set-and-hit-breakpoint.test (authored by omjavaid).
[LLDB] Remove XFAIL from minidebuginfo-set-and-hit-breakpoint.test
Feb 25 2022, 2:55 AM

Feb 23 2022

omjavaid added a comment to D120274: Add LLDB AArch64 Windows buildbot.

Are you sure you don’t want to skip watchpoint tests? They seem unreliable on Windows.

Feb 23 2022, 2:07 AM · Restricted Project

Feb 21 2022

omjavaid requested review of D120274: Add LLDB AArch64 Windows buildbot.
Feb 21 2022, 11:52 AM · Restricted Project

Feb 17 2022

omjavaid added a comment to D119797: Fix race condition when launching and attaching..

Hi @clayborg this rev has caused some lldb-vscode test failures across all LLDB/Linux buildbots.

Feb 17 2022, 11:22 PM · Restricted Project, Restricted Project

Feb 15 2022

omjavaid added a comment to rGa1862d78eb45: Set LLVM_FORCE_USE_OLD_TOOLCHAIN to disable VS2019 checks.

Hi James, Thanks for highlighting this. I ve merged a fix.

Feb 15 2022, 1:37 PM
omjavaid committed rG2aed90bfbadd: Fix typo in llvm-config.h.cmake (authored by omjavaid).
Fix typo in llvm-config.h.cmake
Feb 15 2022, 1:36 PM

Feb 10 2022

omjavaid committed rZORGb995583f207b: [LLDB] Force clean build for aarch64/arm-ubuntu builders (authored by omjavaid).
[LLDB] Force clean build for aarch64/arm-ubuntu builders
Feb 10 2022, 2:43 AM

Feb 9 2022

omjavaid committed rG73a961b9cca1: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows (authored by omjavaid).
[LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows
Feb 9 2022, 4:41 AM
omjavaid closed D117676: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows.
Feb 9 2022, 4:40 AM · Restricted Project
omjavaid added a reviewer for D117676: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows: labath.
Feb 9 2022, 3:37 AM · Restricted Project
omjavaid added a comment to D117676: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows.

ping!

Feb 9 2022, 3:36 AM · Restricted Project
omjavaid accepted D115508: Reland "[lldb] Remove non address bits when looking up memory regions".
Feb 9 2022, 3:35 AM · Restricted Project, Restricted Project
omjavaid committed rGa1862d78eb45: Set LLVM_FORCE_USE_OLD_TOOLCHAIN to disable VS2019 checks (authored by omjavaid).
Set LLVM_FORCE_USE_OLD_TOOLCHAIN to disable VS2019 checks
Feb 9 2022, 1:40 AM
omjavaid committed rGcd817231ec4f: [clang-cl] Bump default -fms-compatibility-version to 19.14 (authored by omjavaid).
[clang-cl] Bump default -fms-compatibility-version to 19.14
Feb 9 2022, 12:56 AM

Jan 27 2022

omjavaid accepted D118358: [lldb][ARM/AArch64] Update dissembler to v9.3-a.
Jan 27 2022, 6:00 PM · Restricted Project

Jan 25 2022

omjavaid accepted D107140: [lldb] Add option to show memory tags in memory read output.

looks good thanks

Jan 25 2022, 7:15 PM · Restricted Project, Restricted Project
omjavaid accepted D112824: [lldb][AArch64] Add MakeTaggedRanges to MemoryTagManager.

LGTM Thanks! for your patience

Jan 25 2022, 5:23 PM · Restricted Project

Jan 23 2022

omjavaid accepted D117299: [lldb] Ignore non-address bits in "memory find" arguments.
Jan 23 2022, 8:46 PM · Restricted Project
omjavaid added inline comments to D112824: [lldb][AArch64] Add MakeTaggedRanges to MemoryTagManager.
Jan 23 2022, 6:43 PM · Restricted Project

Jan 20 2022

omjavaid added inline comments to D117299: [lldb] Ignore non-address bits in "memory find" arguments.
Jan 20 2022, 4:11 PM · Restricted Project
omjavaid added a comment to D117676: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows.

FWIW, I consider the build.py script a failed experiment. The idea itself was not completely bad, but the lack of buy-in from sufficient amount of developers meant that it never really had a chance of fulfilling its (rather lofty) goals.

I think it should be removed or at least scaled back significantly. The only thing it's really used for these days is to invoke msvc and clang-cl, and I'm sure we can achieve the same thing with some lit substitutions as well...

Jan 20 2022, 2:32 PM · Restricted Project

Jan 19 2022

omjavaid accepted D117671: [lldb] Rename MemoryTagManager RemoveNonAddressBits to RemoveTagBits.
Jan 19 2022, 4:37 PM · Restricted Project
omjavaid accepted D117672: [lldb] Remove non-address bits from addresses given to memory tag commands.
Jan 19 2022, 4:32 PM · Restricted Project
omjavaid committed rG9c4e93c71a80: [LLDB] Adjust compiler-full-path.test for Windows/Arm64 (authored by TCWG <tcwg@linaro.org>).
[LLDB] Adjust compiler-full-path.test for Windows/Arm64
Jan 19 2022, 6:48 AM
omjavaid requested review of D117676: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows.
Jan 19 2022, 6:43 AM · Restricted Project
omjavaid committed rZORGc87e73dd0889: LLDB Windows x64 buildbot set lit -j8 (authored by omjavaid).
LLDB Windows x64 buildbot set lit -j8
Jan 19 2022, 4:04 AM
omjavaid closed D117363: LLDB Windows x64 buildbot set lit -j8.
Jan 19 2022, 4:04 AM · Restricted Project
omjavaid added a comment to D117363: LLDB Windows x64 buildbot set lit -j8.

I have still setting up the Arm WoA worker which requires a bit of tweaking with visual studio config as well. I have not found a final patch for it and going to commit this one while I work on a follow up.

Jan 19 2022, 3:50 AM · Restricted Project
omjavaid added a comment to D117559: [lldb] Remove forward-connect ability from lldb-server tests.

This doesnt interfere with LLDB tests for SVE. Rather I have not used it in a while for SVE tests I ahve using setup similar to to one David has explained above.

Jan 19 2022, 3:48 AM · Restricted Project, Restricted Project

Jan 14 2022

omjavaid added a comment to D117363: LLDB Windows x64 buildbot set lit -j8.

I think they should be set in just one place to make the code more readable.

I was about to suggest the same.

It might be simpler and more straight forward to revert D116972 and just explicitly specify the needed LLVM_LIT_ARGS in the extra_cmake_args.
If you would like to set -v and -j by default, that could be done by something like this:

defult_lit_args = '-v'
if if jobs:
    defult_lit_args += " -j{jobs}".format(jobs=jobs)
CmakeCommand.applyDefaultOptions(cmake_options, [
        ('-DLLVM_LIT_ARGS=', defult_lit_args),
        ])

This is not a blocker for this patch, though.

A separate thing. The patch specifies the both s and v, which kinds of contradict each other, What's the point?

I conveniently copied lit args from arm lldb bot. AFAIK both giving and sv together shows output as well as a progress bar but I am not too sure.

Jan 14 2022, 3:17 PM · Restricted Project
omjavaid added inline comments to D117363: LLDB Windows x64 buildbot set lit -j8.
Jan 14 2022, 3:00 PM · Restricted Project
omjavaid added inline comments to D117363: LLDB Windows x64 buildbot set lit -j8.
Jan 14 2022, 2:50 PM · Restricted Project
omjavaid requested review of D117363: LLDB Windows x64 buildbot set lit -j8.
Jan 14 2022, 2:35 PM · Restricted Project
omjavaid committed rGdf13239c1177: [LLDB] Skip TestIOHandlerPythonREPLSigint.py on AArch64/Linux (authored by omjavaid).
[LLDB] Skip TestIOHandlerPythonREPLSigint.py on AArch64/Linux
Jan 14 2022, 2:25 PM
omjavaid committed rG3dc858f9847d: [LLDB] Skip TestIOHandlerPythonREPLSigint.py on Arm/Linux (authored by omjavaid).
[LLDB] Skip TestIOHandlerPythonREPLSigint.py on Arm/Linux
Jan 14 2022, 2:47 AM

Jan 12 2022

omjavaid added a comment to D115508: Reland "[lldb] Remove non address bits when looking up memory regions".

Apologies for late response!!!

Jan 12 2022, 4:17 PM · Restricted Project, Restricted Project

Jan 10 2022

omjavaid accepted D116972: [lldb] Run the test suite in verbose mode.
Jan 10 2022, 2:43 PM

Dec 29 2021

omjavaid added a comment to D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled..

This breaks LLDB Linux buildbots:

Dec 29 2021, 12:29 AM · Restricted Project

Dec 23 2021

omjavaid added a reverting change for rG62a6b9e9ab3e: Revert "[DwarfDebug] Support emitting function-local declaration for a lexical…: rGf9607d45f399: Revert "Revert "[DwarfDebug] Support emitting function-local declaration for a….
Dec 23 2021, 1:14 AM
omjavaid committed rGf9607d45f399: Revert "Revert "[DwarfDebug] Support emitting function-local declaration for a… (authored by omjavaid).
Revert "Revert "[DwarfDebug] Support emitting function-local declaration for a…
Dec 23 2021, 1:14 AM
omjavaid raised a concern with rG62a6b9e9ab3e: Revert "[DwarfDebug] Support emitting function-local declaration for a lexical….

This has broken all LLDB buildbots:

Dec 23 2021, 1:07 AM

Dec 14 2021

omjavaid added a comment to D98378: [LSR] Fix crash in Phi node with EHPad block.

@lorenz are you still working on this issue? We are seeing this issue on LLVM for Windows on Arm while compiling TensorFlow with clang-cl.

Dec 14 2021, 4:42 AM · Restricted Project

Dec 3 2021

omjavaid committed rG80792368bb87: [LLDB] XFAIL on Arm/Linux minidebuginfo-set-and-hit-breakpoint.test (authored by omjavaid).
[LLDB] XFAIL on Arm/Linux minidebuginfo-set-and-hit-breakpoint.test
Dec 3 2021, 8:52 AM

Dec 1 2021

omjavaid added a comment to D114288: [NFC] Refactor symbol table parsing..

Hi @clayborg
This breaks LLDB Arm/Linux buildbot. https://lab.llvm.org/buildbot/#/builders/17/builds/14035

Dec 1 2021, 3:42 AM · Restricted Project

Nov 8 2021

omjavaid added inline comments to D112824: [lldb][AArch64] Add MakeTaggedRanges to MemoryTagManager.
Nov 8 2021, 3:13 AM · Restricted Project

Nov 4 2021

omjavaid committed rGb595137fe1c0: [LLDB] Fix Cpsr size for WoA64 target (authored by omjavaid).
[LLDB] Fix Cpsr size for WoA64 target
Nov 4 2021, 5:44 AM
omjavaid committed rGcbd215dfe51d: [LIT] Add win32 PLATFORM env var to test config (authored by omjavaid).
[LIT] Add win32 PLATFORM env var to test config
Nov 4 2021, 5:44 AM
omjavaid closed D112471: [LLDB] Fix Cpsr size for WoA64 target.
Nov 4 2021, 5:44 AM · Restricted Project
omjavaid closed D113165: [LIT] Add win32 PLATFORM env var to test config.
Nov 4 2021, 5:44 AM · Restricted Project, Restricted Project

Nov 3 2021

omjavaid committed rG553a87246510: [LLDB] Adjust DumpDataExtractorTest.Formats for Windows (authored by omjavaid).
[LLDB] Adjust DumpDataExtractorTest.Formats for Windows
Nov 3 2021, 8:49 PM
omjavaid requested review of D113165: [LIT] Add win32 PLATFORM env var to test config.
Nov 3 2021, 8:13 PM · Restricted Project, Restricted Project

Oct 26 2021

omjavaid committed rG4c8ea90b252e: [LLDB] Fix LLDB buildbots break due to --image-base (authored by omjavaid).
[LLDB] Fix LLDB buildbots break due to --image-base
Oct 26 2021, 12:11 AM

Oct 25 2021

omjavaid requested review of D112471: [LLDB] Fix Cpsr size for WoA64 target.
Oct 25 2021, 10:43 AM · Restricted Project

Oct 20 2021

omjavaid accepted D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn.

This look great. Thanks for doing the legit fix.

Oct 20 2021, 2:23 PM · Restricted Project

Oct 11 2021

omjavaid committed rG483db1c70686: [LLDB] Remove xfail decorator TestInferiorAssert.py AArch64/Linux (authored by omjavaid).
[LLDB] Remove xfail decorator TestInferiorAssert.py AArch64/Linux
Oct 11 2021, 2:41 AM
omjavaid added inline comments to D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess.
Oct 11 2021, 1:08 AM · Restricted Project
omjavaid committed rGc63cb0c80ec7: [LLDB] Skip TestScriptedProcess on Arm/AArch64 Linux (authored by omjavaid).
[LLDB] Skip TestScriptedProcess on Arm/AArch64 Linux
Oct 11 2021, 12:59 AM

Oct 6 2021

omjavaid added a comment to rGd2b9d0fdda5e: Round XML register bitsize to byte boundary.

These two are rare control paths so I thought not to infiltrate with
lambda arguments. Maybe we can readjust it if further logging needs arise
in future.

Oct 6 2021, 2:17 AM
omjavaid committed rGd2b9d0fdda5e: Round XML register bitsize to byte boundary (authored by omjavaid).
Round XML register bitsize to byte boundary
Oct 6 2021, 2:04 AM
omjavaid closed D111131: [LLDB] Round XML register bitsize to byte boundary.
Oct 6 2021, 2:04 AM · Restricted Project
omjavaid updated the diff for D111131: [LLDB] Round XML register bitsize to byte boundary.

This addresses review comments converts printfs to log messages.

Oct 6 2021, 1:55 AM · Restricted Project

Oct 5 2021

omjavaid added inline comments to D111131: [LLDB] Round XML register bitsize to byte boundary.
Oct 5 2021, 4:06 AM · Restricted Project
omjavaid added inline comments to D111131: [LLDB] Round XML register bitsize to byte boundary.
Oct 5 2021, 4:01 AM · Restricted Project