User Details
- User Since
- Mar 13 2015, 4:38 PM (318 w, 3 d)
Thu, Apr 15
This looks very good and I have couple of highlights to make from Linux/AArch64 perspective:
qHostInfo is not sufficient for mask calculation on Linux because both data/code ptr auth masks are read by thread register context (both masks are currently same and they same for all the threads of a process).
IMO moving the mask calculation to ABI GetCodeAddress method may be a better option. We can pull in information of addressable bits from process and also read register context for code/data masks by passing threadsp to ABI::GetCodeAddress. But in case we dont get agreement on moving mask calculation to ABI we can calculate mask somewhere inside ProcessGDBRemote and set it from there.... similar to what I have done in D99947.
Tue, Apr 13
Mon, Apr 12
Tue, Apr 6
Fri, Apr 2
Thu, Apr 1
I am going ahead and commit this change till we find a better way to fix the sync issue. sleep time set to 2s now.
Wed, Mar 31
Tue, Mar 30
Mon, Mar 29
Fri, Mar 26
Thu, Mar 25
Tue, Mar 23
Pulling GetAuxValue from NativeProcessELF. @labath what do you think.
Mon, Mar 22
Mar 19 2021
Rebased after changes to parent D96458
This update further cleans up and removes static functions that calculated m_register_info_p GetRegisterInfoPtr and m_register_info_count GetRegisterInfoCount
This update address review comments from @labath
Mar 15 2021
Mar 12 2021
Rebased.
Updated after changes in parent. Also removed D96459
This update incorporates changes written by @labath
Mar 11 2021
Mar 10 2021
Mar 9 2021
FIxes stale diff uploaded by mistake.
fixes review comments.
Minor fix to write unique value to all z/p registers when writing them using register write command.
Rebased after changes to parent.
Rebased after changes in parent.
This update fixes review comments highlighted by @rovka
Mar 8 2021
Mar 4 2021
Mar 3 2021
Mar 2 2021
This looks good apart from minor nits inline
Mar 1 2021
I guess we also need LLDB API interface for reading/writing memory tags. So that we can do something like process.ReadMemoryTags() from python. Do you plan on adding it in a later patch?
This looks good overall except for one comment inline.
Feb 26 2021
This is accepted with a caveat above.
Feb 25 2021
Feb 22 2021
Ran clang format and fixed typos.
Review comments resolved.
Rebased after updates to parent.
Rebased after updates to parent.
This moves ConfigureRegisterInfos into constructor.