Page MenuHomePhabricator

omjavaid (Muhammad Omair Javaid)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 13 2015, 4:38 PM (419 w, 1 d)

Recent Activity

Fri, Mar 24

omjavaid added a comment to D142888: [compiler-rt] Fix building GWPASAN on ARM.

@luporl @DavidSpickett any thoughts on suggestion by @MaskRay?

Fri, Mar 24, 1:17 AM · Restricted Project, Restricted Project

Thu, Mar 23

omjavaid added a comment to D142888: [compiler-rt] Fix building GWPASAN on ARM.

Hi I was wondering if we could fast track merge of this patch into LLVM main and 16.0.0 release branch. This patch fixes LLVM 16.0.0 release build for armv7 Linux and release is waiting on this patch to be merged.

Thu, Mar 23, 3:05 PM · Restricted Project, Restricted Project

Mon, Mar 20

omjavaid closed D145551: [SVE] Add patterns for shift intrinsics with FalseLanesZero mode.

Sorry for inconvenience.
I have reverted the revert of this patch as it turned out buildbot breakage was cause by some other commit.

Mon, Mar 20, 3:35 AM · Restricted Project, Restricted Project
omjavaid added a reverting change for rG57aeb3054604: [JITLink][ELF] Don't skip debug info sections by default.: rGf721fcb6ed0a: Revert "[JITLink][ELF] Don't skip debug info sections by default.".
Mon, Mar 20, 3:33 AM · Restricted Project, Restricted Project
omjavaid committed rGf721fcb6ed0a: Revert "[JITLink][ELF] Don't skip debug info sections by default." (authored by omjavaid).
Revert "[JITLink][ELF] Don't skip debug info sections by default."
Mon, Mar 20, 3:33 AM · Restricted Project, Restricted Project
omjavaid added a reverting change for rG32bd1f562f83: Revert "[SVE] Add patterns for shift intrinsics with FalseLanesZero mode": rG8d6ab7d51964: Revert "Revert "[SVE] Add patterns for shift intrinsics with FalseLanesZero….
Mon, Mar 20, 3:33 AM · Restricted Project, Restricted Project
omjavaid committed rG8d6ab7d51964: Revert "Revert "[SVE] Add patterns for shift intrinsics with FalseLanesZero… (authored by omjavaid).
Revert "Revert "[SVE] Add patterns for shift intrinsics with FalseLanesZero…
Mon, Mar 20, 3:33 AM · Restricted Project, Restricted Project
omjavaid added a reverting change for D145551: [SVE] Add patterns for shift intrinsics with FalseLanesZero mode: rG8d6ab7d51964: Revert "Revert "[SVE] Add patterns for shift intrinsics with FalseLanesZero….
Mon, Mar 20, 3:33 AM · Restricted Project, Restricted Project
omjavaid reopened D145551: [SVE] Add patterns for shift intrinsics with FalseLanesZero mode.

This change has broken LLVM SVE buildbot https://lab.llvm.org/buildbot/#/builders/197/builds/4272
I have reverted the change for now.

Mon, Mar 20, 12:41 AM · Restricted Project, Restricted Project
omjavaid added a reverting change for rG22c3ba4bb519: [SVE] Add patterns for shift intrinsics with FalseLanesZero mode: rG32bd1f562f83: Revert "[SVE] Add patterns for shift intrinsics with FalseLanesZero mode".
Mon, Mar 20, 12:41 AM · Restricted Project, Restricted Project
omjavaid committed rG32bd1f562f83: Revert "[SVE] Add patterns for shift intrinsics with FalseLanesZero mode" (authored by omjavaid).
Revert "[SVE] Add patterns for shift intrinsics with FalseLanesZero mode"
Mon, Mar 20, 12:41 AM · Restricted Project, Restricted Project
omjavaid added a reverting change for D145551: [SVE] Add patterns for shift intrinsics with FalseLanesZero mode: rG32bd1f562f83: Revert "[SVE] Add patterns for shift intrinsics with FalseLanesZero mode".
Mon, Mar 20, 12:41 AM · Restricted Project, Restricted Project

Mon, Mar 6

omjavaid committed rG71b38063b282: Fix LLDB windows build (authored by omjavaid).
Fix LLDB windows build
Mon, Mar 6, 5:38 PM · Restricted Project
omjavaid closed D145446: Fix LLDB windows build.
Mon, Mar 6, 5:38 PM · Restricted Project, Restricted Project
omjavaid requested review of D145446: Fix LLDB windows build.
Mon, Mar 6, 3:53 PM · Restricted Project, Restricted Project

Sun, Mar 5

omjavaid committed rG1a6dfa2beeb4: [LLVM] Remove XFAIL from merge-equivalent-ranges.ll (authored by omjavaid).
[LLVM] Remove XFAIL from merge-equivalent-ranges.ll
Sun, Mar 5, 11:32 PM · Restricted Project, Restricted Project

Wed, Mar 1

omjavaid committed rGe85e5abdceff: [LLDB] XFAIL TestRunLocker.py for windows (authored by omjavaid).
[LLDB] XFAIL TestRunLocker.py for windows
Wed, Mar 1, 11:58 PM · Restricted Project
omjavaid added a reverting change for rG9d28e00e741c: [LLDB] XFAIL TestRunLocker.py on Windows: rG588da01621a1: Revert "[LLDB] XFAIL TestRunLocker.py on Windows".
Wed, Mar 1, 11:22 PM · Restricted Project
omjavaid committed rG588da01621a1: Revert "[LLDB] XFAIL TestRunLocker.py on Windows" (authored by omjavaid).
Revert "[LLDB] XFAIL TestRunLocker.py on Windows"
Wed, Mar 1, 11:22 PM · Restricted Project
omjavaid committed rG9d28e00e741c: [LLDB] XFAIL TestRunLocker.py on Windows (authored by omjavaid).
[LLDB] XFAIL TestRunLocker.py on Windows
Wed, Mar 1, 11:05 PM · Restricted Project

Sun, Feb 26

omjavaid added a comment to D142888: [compiler-rt] Fix building GWPASAN on ARM.

@DavidSpickett Its been while since no further comments on this rev. So I was wondering if you can kindly approve this patch. This is blocker for llvm 16.x armv7 release.
@luporl kindly port this to 16.x release branch once approved.

Sun, Feb 26, 12:01 PM · Restricted Project, Restricted Project

Feb 13 2023

omjavaid committed rGc5e1000b2915: Add build for Windows on Arm in packaging script (authored by pbo-linaro).
Add build for Windows on Arm in packaging script
Feb 13 2023, 1:37 AM · Restricted Project, Restricted Project
omjavaid closed D142983: Add build for Windows on Arm in packaging script.
Feb 13 2023, 1:37 AM · Restricted Project, Restricted Project

Feb 3 2023

omjavaid added inline comments to D142983: Add build for Windows on Arm in packaging script.
Feb 3 2023, 12:31 AM · Restricted Project, Restricted Project

Feb 1 2023

omjavaid added a comment to D142983: Add build for Windows on Arm in packaging script.

@pbo-linaro I have replied to flang query and also going to issue a build using this script to verify it. Looks good to me. I ll post the result of my build tomorrow.

Feb 1 2023, 1:06 PM · Restricted Project, Restricted Project

Jan 31 2023

omjavaid added a comment to D142983: Add build for Windows on Arm in packaging script.

This looks good to me after fixing nits mentioned inline.

Jan 31 2023, 8:09 AM · Restricted Project, Restricted Project
omjavaid added a reviewer for D142983: Add build for Windows on Arm in packaging script: tstellar.
Jan 31 2023, 8:03 AM · Restricted Project, Restricted Project

Jan 30 2023

omjavaid added a reverting change for rGe1bbe50f5a48: Revert "[lldb] Make SBSection::GetSectionData call Section::GetSectionData.": rGbde5d31e96f5: Revert "Revert "[lldb] Make SBSection::GetSectionData call Section….
Jan 30 2023, 3:49 AM · Restricted Project
omjavaid committed rGbde5d31e96f5: Revert "Revert "[lldb] Make SBSection::GetSectionData call Section… (authored by omjavaid).
Revert "Revert "[lldb] Make SBSection::GetSectionData call Section…
Jan 30 2023, 3:49 AM · Restricted Project
omjavaid added a reverting change for D142672: [lldb] Make SBSection::GetSectionData call Section::GetSectionData.: rGbde5d31e96f5: Revert "Revert "[lldb] Make SBSection::GetSectionData call Section….
Jan 30 2023, 3:49 AM · Restricted Project, Restricted Project
omjavaid closed D142672: [lldb] Make SBSection::GetSectionData call Section::GetSectionData..
Jan 30 2023, 3:49 AM · Restricted Project, Restricted Project

Jan 29 2023

omjavaid reopened D142672: [lldb] Make SBSection::GetSectionData call Section::GetSectionData..

LLDB windows buildbots were broken by the TestSectionAPI.py test. I dont
have full context of the commit to fix it. Reverting it temporarily.

Jan 29 2023, 11:36 PM · Restricted Project, Restricted Project
omjavaid added a reverting change for rG805600c7d573: [lldb] Make SBSection::GetSectionData call Section::GetSectionData.: rGe1bbe50f5a48: Revert "[lldb] Make SBSection::GetSectionData call Section::GetSectionData.".
Jan 29 2023, 11:36 PM · Restricted Project
omjavaid committed rGe1bbe50f5a48: Revert "[lldb] Make SBSection::GetSectionData call Section::GetSectionData." (authored by omjavaid).
Revert "[lldb] Make SBSection::GetSectionData call Section::GetSectionData."
Jan 29 2023, 11:36 PM · Restricted Project
omjavaid added a reverting change for D142672: [lldb] Make SBSection::GetSectionData call Section::GetSectionData.: rGe1bbe50f5a48: Revert "[lldb] Make SBSection::GetSectionData call Section::GetSectionData.".
Jan 29 2023, 11:35 PM · Restricted Project, Restricted Project

Jan 25 2023

omjavaid reopened D140624: [LLDB] Fixes summary formatter for libc++ map allowing modification of contained value.

This rev has broken lldb-arm-ubuntu buildbot https://lab.llvm.org/buildbot/#/builders/17/builds/33173

Jan 25 2023, 1:28 AM · Restricted Project, Restricted Project

Jan 24 2023

omjavaid committed rG37505da42f62: [compiler-rt] Remove XFAIL decorator trampoline_setup_test.c (authored by omjavaid).
[compiler-rt] Remove XFAIL decorator trampoline_setup_test.c
Jan 24 2023, 5:19 PM · Restricted Project, Restricted Project

Jan 16 2023

omjavaid committed rZORG2b275a3cfade: Revamp LLVM WoA buildbots (authored by omjavaid).
Revamp LLVM WoA buildbots
Jan 16 2023, 2:02 AM · Restricted Project
omjavaid closed D140384: Revamp LLVM WoA buildbots.
Jan 16 2023, 2:02 AM · Restricted Project

Jan 13 2023

omjavaid updated the diff for D140384: Revamp LLVM WoA buildbots.

Rename clang-arm64-windows-msvc-quick back to clang-arm64-windows-msvc.

Jan 13 2023, 3:17 AM · Restricted Project

Jan 10 2023

omjavaid added a comment to D140384: Revamp LLVM WoA buildbots.

Thanks for making the changes!

The patch looks good with a nit pick.

Since you replaced clang-arm64-windows-msvc, could you keep the same builder name, please?
The new builder is faster than the old one, which is great. Doesn’t make it a quick one, though. Keeping the same name seems reasonable.

Jan 10 2023, 3:02 AM · Restricted Project

Jan 6 2023

omjavaid added a comment to D140384: Revamp LLVM WoA buildbots.

Ping! @DavidSpickett @gkistanova

Jan 6 2023, 2:48 AM · Restricted Project
omjavaid added a comment to D136915: Add build for Windows on Arm in packaging script.

There must be some issue with your configuration possible not testing the top of tree main branch as 15.0.6 may not have the patches for the build to succeed. Please follow the instructions on link provided below to setup your test machine:
https://linaro.atlassian.net/wiki/spaces/TCWGPUB/pages/28809266294/How+to+setup+LLVM+buildbots+for+Windows+11+on+Arm

Jan 6 2023, 2:48 AM · Restricted Project, Restricted Project

Jan 4 2023

omjavaid added a comment to D136915: Add build for Windows on Arm in packaging script.

Also it would be great if we allow user to choose between cl and clang-cl for the stage 0 build using a command line option and set CMAKE_C_COMPILER and CMAKE_CXX_COMPILER accordingly.

Jan 4 2023, 6:21 AM · Restricted Project, Restricted Project
omjavaid added a comment to D136915: Add build for Windows on Arm in packaging script.

This looks like a good time to merge this script however some changes are needed:

Jan 4 2023, 6:17 AM · Restricted Project, Restricted Project

Jan 3 2023

omjavaid committed rG21be357873c0: [LLDB] Skip python exception unit test on AArch64/Windows (authored by omjavaid).
[LLDB] Skip python exception unit test on AArch64/Windows
Jan 3 2023, 6:44 AM · Restricted Project
omjavaid committed rG2b8c308fa1d3: [LLDB] Skip TestThreadSpecificBreakpoint.py on AArch64/Windows (authored by omjavaid).
[LLDB] Skip TestThreadSpecificBreakpoint.py on AArch64/Windows
Jan 3 2023, 6:44 AM · Restricted Project
omjavaid committed rGcd8b36190d16: [llvm] XFAIL X86 tests failing on AArch64/Windows (authored by omjavaid).
[llvm] XFAIL X86 tests failing on AArch64/Windows
Jan 3 2023, 4:53 AM · Restricted Project, Restricted Project
omjavaid committed rGaa36207c7861: [compiler-rt] XFAIL builtins unit tests on WoA (authored by omjavaid).
[compiler-rt] XFAIL builtins unit tests on WoA
Jan 3 2023, 3:23 AM · Restricted Project, Restricted Project

Jan 2 2023

omjavaid added inline comments to D140384: Revamp LLVM WoA buildbots.
Jan 2 2023, 12:14 PM · Restricted Project
omjavaid updated the diff for D140384: Revamp LLVM WoA buildbots.

Add more changes updating all LLVM Windows on Arm builders.

Jan 2 2023, 12:10 PM · Restricted Project
omjavaid committed rGdbee45d8fea9: [LLDB] Enable TestSignedTypes.py for AArch64/Windows (authored by omjavaid).
[LLDB] Enable TestSignedTypes.py for AArch64/Windows
Jan 2 2023, 7:34 AM · Restricted Project

Dec 20 2022

omjavaid added inline comments to D140384: Revamp LLVM WoA buildbots.
Dec 20 2022, 4:11 AM · Restricted Project
omjavaid added inline comments to D140384: Revamp LLVM WoA buildbots.
Dec 20 2022, 4:05 AM · Restricted Project
omjavaid requested review of D140384: Revamp LLVM WoA buildbots.
Dec 20 2022, 3:19 AM · Restricted Project
omjavaid committed rG301f3da51624: [CLANG] Fix typo in test/CodeGen/c-strings.c (authored by omjavaid).
[CLANG] Fix typo in test/CodeGen/c-strings.c
Dec 20 2022, 1:01 AM · Restricted Project, Restricted Project

Dec 19 2022

omjavaid committed rG8e029d9e3509: [CLANG] XFAIL c-strings.c & volatile-1.c AArch64/Windows (authored by omjavaid).
[CLANG] XFAIL c-strings.c & volatile-1.c AArch64/Windows
Dec 19 2022, 1:03 AM · Restricted Project, Restricted Project
omjavaid committed rG58e9cc13e24f: Revert "[lldb] Remove redundant .c_str() and .get() calls" (authored by omjavaid).
Revert "[lldb] Remove redundant .c_str() and .get() calls"
Dec 19 2022, 12:52 AM · Restricted Project
omjavaid added a reverting change for rGfbaf48be0ff6: [lldb] Remove redundant .c_str() and .get() calls: rG58e9cc13e24f: Revert "[lldb] Remove redundant .c_str() and .get() calls".
Dec 19 2022, 12:52 AM · Restricted Project

Nov 30 2022

omjavaid committed rGc687c2cce519: [FLANG] Fix MSVC + clang-cl build (authored by omjavaid).
[FLANG] Fix MSVC + clang-cl build
Nov 30 2022, 3:30 AM · Restricted Project, Restricted Project
omjavaid closed D138023: [FLANG] Fix MSVC + clang-cl build.
Nov 30 2022, 3:29 AM · Restricted Project, Restricted Project, Restricted Project

Nov 21 2022

omjavaid added a comment to D138023: [FLANG] Fix MSVC + clang-cl build.

@mstorsjo Is it good to land?

Nov 21 2022, 6:29 AM · Restricted Project, Restricted Project, Restricted Project

Nov 18 2022

omjavaid updated the diff for D138023: [FLANG] Fix MSVC + clang-cl build.

Corrects the diff error from last patch.

Nov 18 2022, 2:34 AM · Restricted Project, Restricted Project, Restricted Project
omjavaid added a comment to D138023: [FLANG] Fix MSVC + clang-cl build.

So I went ahead and tried a simple int128 div and compiled it with clang-cl on Surface X. As you suggested clang does not implicitly link rt library. I actually just read docs that target specific rtlib is implicitly linked
https://github.com/llvm/llvm-project/blob/main/clang/docs/Toolchain.rst

Ok, I see! Yes, that document might not take all clang-cl considerations into account.

For most clang targets, you really do need the builtins (either in the form of libgcc, or compiler-rt builtins) everywhere. But for MSVC targets, it's usually not needed and thus not linked in implicitly, since everything you normally need is in the MSVC static libraries. But since MSVC doesn't support int128 (and Clang lowers it to a libgcc named helper function) they obviously don't provide that one. (There has been discussions about whether they could start including these helpe functions somewhere, to help Clang cases, but it hasn't materialized yet at least.)

Overall, this is a Clang-cl toolchain issue - known for some time already; since this is a builtin type, the helpers for it should really be handled automatically. But since most use in MSVC style settings invoke the linker directly instead of via the compiler driver, the fix isn't entirely trivial. https://reviews.llvm.org/D134912#3828421 is the latest word on what would be a good way forward to handle it (from the toolchain point of view).

Also from a toolchain point of view, this is a bit tricky, since you normally can cross compile with clang-cl for any supported architecture as long as you've got MSVC and WinSDK, but when clang starts requiring the builtins, they you also need to have those built and available, for all architectures that you want to compile for. MSVC itself actually does ship with these files for some architectures (x86 and x64), but not for arm64 (or arm). So I think we should request that MSVC should start bundling clang_rt.*.lib for arm64 too, at least as many parts of compiler-rt as works on arm64 (IIRC the sanitizers don't support it yet), so that Clang could start automatically linking against it when needed (without needing to ship it along with Clang specifically for arm64 only).

How does flang work when built with MSVC proper, which doesn't have int128 as a built-in type at all?

We have not been using cl as they are available as emulated tools on WoA while clang-cl is native and faster. Although I tried cl just today but was not able to get the build working facing errors which are unrelated to this particular issue.

Ok, I see. (BTW since some months, MSVC should be available as properly native arm64 apps now too. But I don't expect you to try to set it up right now, I'm sure there's lots of things one would run into trying to build flang with it.)

I wonder why this isn't an issue with clang-cl builds on x86_64 too - the same issue should appear there too, if it uses int128 in the same way.

This issue appear when compiling flang project and it also appears on x86_64 when a combination of MSVC + Clang-cl is used. I have not tried a MSVC + cl build.

If it is possible to just decide not to use int128 for this build configuration, that's clearly the simplest solution. But if that's not possible, I guess something like this has to be done.

I guess Fortran extensively uses 128bit types and 128 bit division may not be avoidable in this case.

Nov 18 2022, 2:04 AM · Restricted Project, Restricted Project, Restricted Project
omjavaid updated the diff for D138023: [FLANG] Fix MSVC + clang-cl build.

Updated patch to include check for MSVC + Clang.
Also updated commit log description with information on uint128 division builtin function dependency.

Nov 18 2022, 1:52 AM · Restricted Project, Restricted Project, Restricted Project
omjavaid reopened D137915: [LegacyPM] Remove cl::opts controlling optimization pass manager passes.

This appears to have broken https://lab.llvm.org/buildbot/#/builders/191/builds/11279

Nov 18 2022, 1:46 AM · Restricted Project, Restricted Project

Nov 17 2022

omjavaid added a reverting change for D137368: [lld-macho] Overhaul map file code: rG38d6202a4254: Revert "[lld-macho] Overhaul map file code".
Nov 17 2022, 12:15 AM · Restricted Project, Restricted Project, Restricted Project
omjavaid added a reverting change for rG213dbdbef0ba: [lld-macho] Overhaul map file code: rG38d6202a4254: Revert "[lld-macho] Overhaul map file code".
Nov 17 2022, 12:15 AM · Restricted Project
omjavaid committed rG38d6202a4254: Revert "[lld-macho] Overhaul map file code" (authored by omjavaid).
Revert "[lld-macho] Overhaul map file code"
Nov 17 2022, 12:15 AM · Restricted Project
omjavaid added a reverting change for rG7f0779967f06: [lld-macho] Emit map file entry for compact unwind info: rGac3096e1dd77: Revert "[lld-macho] Emit map file entry for compact unwind info".
Nov 17 2022, 12:14 AM · Restricted Project
omjavaid added a reverting change for D137369: [lld-macho] Emit map file entry for compact unwind info: rGac3096e1dd77: Revert "[lld-macho] Emit map file entry for compact unwind info".
Nov 17 2022, 12:14 AM · Restricted Project, Restricted Project, Restricted Project
omjavaid committed rGac3096e1dd77: Revert "[lld-macho] Emit map file entry for compact unwind info" (authored by omjavaid).
Revert "[lld-macho] Emit map file entry for compact unwind info"
Nov 17 2022, 12:14 AM · Restricted Project
omjavaid added a reverting change for D137370: [lld-macho] Fix bugs around EH_Frame symbols: rGe2c868fbf7c3: Revert "[lld-macho] Fix bugs around EH_Frame symbols".
Nov 17 2022, 12:14 AM · Restricted Project, Restricted Project, Restricted Project
omjavaid added a reverting change for rG1a2bc103bba0: [lld-macho] Fix bugs around EH_Frame symbols: rGe2c868fbf7c3: Revert "[lld-macho] Fix bugs around EH_Frame symbols".
Nov 17 2022, 12:14 AM · Restricted Project
omjavaid committed rGe2c868fbf7c3: Revert "[lld-macho] Fix bugs around EH_Frame symbols" (authored by omjavaid).
Revert "[lld-macho] Fix bugs around EH_Frame symbols"
Nov 17 2022, 12:13 AM · Restricted Project

Nov 16 2022

omjavaid reopened D137368: [lld-macho] Overhaul map file code.

This patch series breaks lld:map-file.s on arm v7 linux buildbots. e.g https://lab.llvm.org/buildbot/#/builders/178/builds/3190
Kindly suggest an appropriate fix.

Nov 16 2022, 10:35 AM · Restricted Project, Restricted Project, Restricted Project
omjavaid committed rGf678217c246b: [llvm-objcopy] XFAIL ELF/update-section.test on 32-bit arm (authored by omjavaid).
[llvm-objcopy] XFAIL ELF/update-section.test on 32-bit arm
Nov 16 2022, 9:51 AM · Restricted Project, Restricted Project
omjavaid added a reverting change for rGcf239c2f1777: [NFC] Make format() more amenable to format attributes: rG332c4af35db9: Revert "[NFC] Make format() more amenable to format attributes".
Nov 16 2022, 7:19 AM · Restricted Project, Restricted Project
omjavaid committed rG332c4af35db9: Revert "[NFC] Make format() more amenable to format attributes" (authored by omjavaid).
Revert "[NFC] Make format() more amenable to format attributes"
Nov 16 2022, 7:19 AM · Restricted Project, Restricted Project
omjavaid added a comment to D138023: [FLANG] Fix MSVC + clang-cl build.

clang-cl implicitly uses clang_rt.builtins*

Can you give an example of a concrete, minimal, clang-cl command line, where you run it with the -v option, where you show where clang-cl actually implicitly links in clang_rt.builtins, as you claim it does in some cases? Because in my experience, it never does that implicitly.

(This is of course not entirely on point for the patch itself, but I would like that the patch background represents facts precisely.)

So I went ahead and tried a simple int128 div and compiled it with clang-cl on Surface X. As you suggested clang does not implicitly link rt library. I actually just read docs that target specific rtlib is implicitly linked
https://github.com/llvm/llvm-project/blob/main/clang/docs/Toolchain.rst

Nov 16 2022, 2:18 AM · Restricted Project, Restricted Project, Restricted Project

Nov 15 2022

omjavaid committed rGd599ac41aabd: [LLDB] Xfail TestVSCode_eventStatistic.py on Arm/AArch64 Linux (authored by omjavaid).
[LLDB] Xfail TestVSCode_eventStatistic.py on Arm/AArch64 Linux
Nov 15 2022, 10:45 PM · Restricted Project
omjavaid added a comment to D138077: Send statistics in initialized event.

This test fails on Arm/AArch64 Linux. I have marked it as an XFAIL.

Nov 15 2022, 10:26 PM · Restricted Project, Restricted Project
omjavaid added a comment to D138023: [FLANG] Fix MSVC + clang-cl build.

Flang build on windows with MSVC environment and clang-cl compiler requires clang_rt.builtin.${target} library.

Can you elaborate on which parts ends up requiring it? The main case I know of is for 128 bit integer support routines.

Clang implicitly uses this library while calling lld-link via clang driver

This doesn't match my experience - the builtin library isn't included automatically anywhere. If you do link with -rtlib=compiler-rt, then yes, it will try to link it in though.

Nov 15 2022, 4:25 AM · Restricted Project, Restricted Project, Restricted Project
omjavaid abandoned D137112: [FLANG] Fix MSVC + clang-cl build.
Nov 15 2022, 3:32 AM · Restricted Project, Restricted Project
omjavaid requested review of D138023: [FLANG] Fix MSVC + clang-cl build.
Nov 15 2022, 3:31 AM · Restricted Project, Restricted Project, Restricted Project
omjavaid added a comment to D137112: [FLANG] Fix MSVC + clang-cl build.

Would you know why we cannot see the results of the pre-commit CI?

Nov 15 2022, 2:47 AM · Restricted Project, Restricted Project

Nov 14 2022

omjavaid reopened D136844: [libclang] Expose completion result kind in `CXCompletionResult`.

Hi this broke https://lab.llvm.org/buildbot/#/builders/245/builds/761
I have reverted the change to make the buildbot green.

Nov 14 2022, 12:30 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
omjavaid added a reverting change for rG97105e5bf70f: [libclang] Expose completion result kind in `CXCompletionResult`: rG0b94525ddcfc: Revert "[libclang] Expose completion result kind in `CXCompletionResult`".
Nov 14 2022, 12:29 AM · Restricted Project, Restricted Project
omjavaid committed rG0b94525ddcfc: Revert "[libclang] Expose completion result kind in `CXCompletionResult`" (authored by omjavaid).
Revert "[libclang] Expose completion result kind in `CXCompletionResult`"
Nov 14 2022, 12:29 AM · Restricted Project, Restricted Project
omjavaid added a reverting change for D136844: [libclang] Expose completion result kind in `CXCompletionResult`: rG0b94525ddcfc: Revert "[libclang] Expose completion result kind in `CXCompletionResult`".
Nov 14 2022, 12:29 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 8 2022

omjavaid added a comment to D137112: [FLANG] Fix MSVC + clang-cl build.

ping!

Nov 8 2022, 3:14 AM · Restricted Project, Restricted Project

Nov 2 2022

omjavaid added inline comments to D136915: Add build for Windows on Arm in packaging script.
Nov 2 2022, 2:49 AM · Restricted Project, Restricted Project
omjavaid added inline comments to D136915: Add build for Windows on Arm in packaging script.
Nov 2 2022, 2:16 AM · Restricted Project, Restricted Project
omjavaid reopened D137112: [FLANG] Fix MSVC + clang-cl build.

Landed accidentally. Reverted the change.

Nov 2 2022, 2:07 AM · Restricted Project, Restricted Project
omjavaid added a reverting change for rG870fbf8e300f: [FLANG] Fix MSVC + clang-cl build: rG17c9d4dfeeb9: Revert "[FLANG] Fix MSVC + clang-cl build".
Nov 2 2022, 2:07 AM · Restricted Project, Restricted Project
omjavaid committed rG17c9d4dfeeb9: Revert "[FLANG] Fix MSVC + clang-cl build" (authored by omjavaid).
Revert "[FLANG] Fix MSVC + clang-cl build"
Nov 2 2022, 2:07 AM · Restricted Project, Restricted Project
omjavaid added a reverting change for D137112: [FLANG] Fix MSVC + clang-cl build: rG17c9d4dfeeb9: Revert "[FLANG] Fix MSVC + clang-cl build".
Nov 2 2022, 2:07 AM · Restricted Project, Restricted Project
omjavaid committed rG870fbf8e300f: [FLANG] Fix MSVC + clang-cl build (authored by omjavaid).
[FLANG] Fix MSVC + clang-cl build
Nov 2 2022, 1:35 AM · Restricted Project, Restricted Project
omjavaid committed rGc49db597a131: [CLANG] XFAIL c-strings.c & volatile-1.c AArch64/Windows (authored by omjavaid).
[CLANG] XFAIL c-strings.c & volatile-1.c AArch64/Windows
Nov 2 2022, 1:35 AM · Restricted Project, Restricted Project
omjavaid closed D137112: [FLANG] Fix MSVC + clang-cl build.
Nov 2 2022, 1:35 AM · Restricted Project, Restricted Project