Temporarily reverted this change as it predecessor broke LLDB build on Arm. https://reviews.llvm.org/D86909
http://lab.llvm.org:8011/builders/lldb-arm-ubuntu/builds/4409

I have temporarily reverted this change as i broke LLDB build on Arm http://lab.llvm.org:8011/builders/lldb-arm-ubuntu/builds/4409

This adds a rst page qemu-testing.rst that describes content which was previously written in README.txt.

This seems fine to me with some minor nits. Also do you plan on writing a Linux API test for this which test memory regions on Linux? I couldnt locate one already written.

This diff addresses issues highlighted in review.

Looks good to me.

@labath ping!

@labath ping!

Adding changes to FreeBSD/* missed earlier.

Fixed last diff it contained an invalid change.

NativeRegisterContextLinux_arm still uses "Plugins/Process/Utility/lldb-arm-register-enums.h" which I intend to deal in a later patch.

Update after moving SVE supported function to lldbtest.py

Fixed review comments.

Added test case for vg testing.

In D82064#2223991, @JDevlieghere wrote:

I didn't look at the scripts in detail but I have a few general (high level) comments:

• I also feel this should go under lldb/scripts.
• Can we put the documentations as RST under lldb/docs so it's rendered on the website? We already have bunch of developer resources there. That will certainly help with discovery.
• LLVM generally encourages scripts to be written in Python. While it doesn't look like this will work out of the box on Windows, I can imagine someone might be interested in that down the line. I also think the bar is lower for new contributors to write Python than bash. I'm kind of on the fence here because there's a reasonable balance between just running commands and control flow, but then I've been scarred by the build-script-impl disaster in Swift so I lean towards better safe than sorry.

In D82865#2225978, @labath wrote:

The new API looks fairly confusing. This doesn't sound like something that the SB users should generally know or care about. What would the GetByteOffset function return in the generic case?
I don't find the explanation in the summary convincing. Presumably, you should be able to verify the proper behavior by checking the data (and its size) that the SBValue object holds. If that returns the right thing, who cares about the value of the offset field?

This update changes this test;s dependence on register offset API.

Updated after changes to TestSVERegister.py for detecting SVE support using /proc/cpuinfo

Updated after changes to parent rev D82853

This reworks previous implementation by returning a vector containing register numbers to be expedited. Default case is minimal set of generic registers or complete register set 0.

@labath ping!

This revision updated after rebase.

@labath ping!

@labath ping!

@labath ping!

@labath ping!

In light of review comments I have come up with this new sceheme for setting up QEMU VM based testing environment for LLDB.

This update fixes SVE namespace name to lower case and fixes a typo in previous update.

This update adds check for SVE support using /proc/cpuinfo in SVE testcases. Also tests case to read predicate registers with 5 different values instead of 0xff.

@labath Any further action needed on this change? I have updated test main.c for doing asm write to SVE regs and then reading them back during testing. Also i have removed NativeProcessLinux_arm64 dependence on LinuxPTraceDefines_arm64sve.h. We are using sys root's ptrace.h as SVE marcros are back ported in most versions of ptrace.h.

This patch fixes review items from last review cycles. Now we do not use LinuxPTraceDefines_arm64sve.h for NativeProcessLinux_arm64 as these defs are already back ported into libc ptrace.h available on most distros. LLDB arm64 build bot and release builders should already have the header included.

Fixed as suggested by @JDevlieghere

This breaks LLDB arm-linux buildbot http://lab.llvm.org:8011/builders/lldb-arm-ubuntu/builds/2651

Thanks for fixing this. SVE was just a typo orignal core files were generated without SVE flag on a aarch64-linux target.

FYI I have reverted this change as it was breaking multiple buildbots.

In D85235#2198062, @JDevlieghere wrote:

In D85235#2198013, @max-kudr wrote:

@JDevlieghere This change is is failing LLDB Windows buildbot since build 18051. Can you please fix that?

Thanks for the heads up. I had just pushed a fix:

commit 927afdffbb1deebd83b86d024b67687d758521d0 
Author: Jonas Devlieghere <jonas@devlieghere.com>
Date:   Wed Aug 5 15:37:50 2020 -0700

    [lldb] Skip test_launch_simple on Windows

    Because stdio manipulation unsupported on Windows.

Corrected a typo.

In this update I have moved ConfigureRegisterContext insider InvalidateAllRegisters in light of D84501 where we move InvalidateAllRegisters on every stop rather than doing so before step/resume

In D84257#2166215, @labath wrote:

In D84257#2164967, @tatyana-krasnukha wrote:

Probably fixes llvm.org/PR44659, though I cannot check on arm/aarch64.

@omjavaid might be interested in checking that.

This update fixes issues highlighted in last review iteration.

One minor last minute change.

This update makes minor adjustments before merge in light of final comments.

This revision updates SVE ptrace support to reflect changes we made in SVE core file support specially around handling of FPSR and FPCR.

This update plugs the holes susceptible to bugs by endianity variations. I have used DataExtractor GetU16 to read flags and vl from user_sve_header. Also removed the memset and replaced it with SetFromMemoryData function.

In this update I have addressed issues highlighted in last review iteration.