Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

omjavaid (Muhammad Omair Javaid)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 13 2015, 4:38 PM (445 w, 8 h)

Recent Activity

Thu, Sep 21

omjavaid accepted D158500: [lldb][AArch64] Linux corefile support for SME.

This looks good with just one nit above.

Thu, Sep 21, 3:08 AM · Restricted Project, Restricted Project

Wed, Sep 20

omjavaid accepted D154927: [lldb][AArch64] Add SME's streaming vector control register.

This is good too. Thanks!!!

Wed, Sep 20, 2:12 AM · Restricted Project, Restricted Project
omjavaid added a comment to D154927: [lldb][AArch64] Add SME's streaming vector control register.

Are

Wed, Sep 20, 12:47 AM · Restricted Project, Restricted Project

Tue, Sep 19

omjavaid accepted D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers.

this looks good

Tue, Sep 19, 3:03 AM · Restricted Project, Restricted Project
omjavaid added inline comments to D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers.
Tue, Sep 19, 12:49 AM · Restricted Project, Restricted Project

Fri, Sep 15

omjavaid accepted D159504: [lldb][AArch64] Implement resizing of SME's ZA register.

This look good

Fri, Sep 15, 8:06 AM · Restricted Project, Restricted Project
omjavaid accepted D159503: [lldb][AArch64] Add SME streaming vector length pseduo register.

This is LGTM as you suggested pending child reviews.

Fri, Sep 15, 7:40 AM · Restricted Project, Restricted Project
omjavaid added inline comments to D159504: [lldb][AArch64] Implement resizing of SME's ZA register.
Fri, Sep 15, 3:28 AM · Restricted Project, Restricted Project
omjavaid added a comment to D159503: [lldb][AArch64] Add SME streaming vector length pseduo register.

This looks fine just couple of nits inline.

Fri, Sep 15, 3:14 AM · Restricted Project, Restricted Project
omjavaid accepted D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register.

This is LGTM. Thanks for your patience.

Fri, Sep 15, 3:03 AM · Restricted Project, Restricted Project

Thu, Sep 14

omjavaid added inline comments to D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register.
Thu, Sep 14, 12:54 AM · Restricted Project, Restricted Project
omjavaid added inline comments to D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register.
Thu, Sep 14, 12:47 AM · Restricted Project, Restricted Project
omjavaid added a comment to D159504: [lldb][AArch64] Implement resizing of SME's ZA register.

This apparently requires a rebase now.

Thu, Sep 14, 12:07 AM · Restricted Project, Restricted Project

Wed, Sep 13

omjavaid added inline comments to D159504: [lldb][AArch64] Implement resizing of SME's ZA register.
Wed, Sep 13, 3:15 AM · Restricted Project, Restricted Project
omjavaid added a comment to D159503: [lldb][AArch64] Add SME streaming vector length pseduo register.

Why do we have svg and za in different register sets?

Wed, Sep 13, 3:09 AM · Restricted Project, Restricted Project
omjavaid added a comment to D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register.

This looks good overall thanks for doing the patch split makes the review way less overwhelming.

Wed, Sep 13, 1:05 AM · Restricted Project, Restricted Project
omjavaid accepted D157846: [lldb][AArch64] Add tests for SME's SVE register state to TestArm64DynamicRegsets.
Wed, Sep 13, 12:43 AM · Restricted Project, Restricted Project
omjavaid added a comment to D157846: [lldb][AArch64] Add tests for SME's SVE register state to TestArm64DynamicRegsets.

In this test can we figure out whether SVE was read from Streaming mode or normal SVE mode?? and if yes may be add a check for that.

Not sure what you mean.

If you mean:

  • write non-streaming SVE with one set of values
  • write streaming SVE with another
  • assert that lldb read the correct one

There are a couple of issues there:

  • If lldb read the inactive mode, it would fail with unavailable register due to a failure down in lldb-sever. These tests would already catch that.
  • The kernel and the architecture say that the values of the registers for the mode you are coming from are wiped out on mode switch. So we wouldn't be able to truly read those values even if we were able to make the ptrace call and get some data.

So it's covered, but does not/ can not be covered by checking values. It'll be correct values, or a complete failure to read.

Wed, Sep 13, 12:42 AM · Restricted Project, Restricted Project

Tue, Sep 12

omjavaid added a comment to D157846: [lldb][AArch64] Add tests for SME's SVE register state to TestArm64DynamicRegsets.

In this test can we figure out whether SVE was read from Streaming mode or normal SVE mode?? and if yes may be add a check for that.

Tue, Sep 12, 5:26 AM · Restricted Project, Restricted Project
omjavaid added a comment to D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers.

This patch requires rebasing does not apply cleanly on top of its parent.

Tue, Sep 12, 5:14 AM · Restricted Project, Restricted Project
omjavaid added a comment to D157846: [lldb][AArch64] Add tests for SME's SVE register state to TestArm64DynamicRegsets.

Can you add more description to this patch. at the moment reading it without SME context in mind does not provide enough information to figure out what we are doing.

Tue, Sep 12, 1:47 AM · Restricted Project, Restricted Project
omjavaid requested changes to D157883: [lldb][AArch64] Add SME's Array Storage (ZA) and streaming vector length (SVG) registers.

The patch looks to implement all stuff needed at once lets break it down into three patches instead:

  1. First patch that just adds SME register set and does not implement RegisterContext Read/Write routines.
  2. Implement register context read/write for SME registers
  3. Implement size re-configuration after changing size of the SME vector.
Tue, Sep 12, 1:43 AM · Restricted Project, Restricted Project

Sun, Sep 10

omjavaid accepted D156687: [lldb][AArch64] Add type marker to ReadAll/WriteALLRegisterValues data.
Sun, Sep 10, 7:05 PM · Restricted Project, Restricted Project
omjavaid accepted D156839: [compiler-rt] ARM64 instruction are always 4 bytes long but GetInstructionSize in interception_win.cpp assumes x86_64 which has mixed sizes .
Sun, Sep 10, 6:48 PM · Restricted Project, Restricted Project

Wed, Sep 6

omjavaid committed rGe82191469ec4: [LLDB] Skip TestBSDArchives.py on windows (authored by omjavaid).
[LLDB] Skip TestBSDArchives.py on windows
Wed, Sep 6, 2:04 AM · Restricted Project

Mon, Sep 4

omjavaid committed rG42a46730bb34: Revert "fix test for #65212" (authored by omjavaid).
Revert "fix test for #65212"
Mon, Sep 4, 12:54 AM · Restricted Project, Restricted Project
omjavaid added a reverting change for rGa0b0d7493db6: fix test for #65212: rG42a46730bb34: Revert "fix test for #65212".
Mon, Sep 4, 12:54 AM · Restricted Project, Restricted Project

Fri, Sep 1

omjavaid added inline comments to D156687: [lldb][AArch64] Add type marker to ReadAll/WriteALLRegisterValues data.
Fri, Sep 1, 7:29 AM · Restricted Project, Restricted Project
omjavaid added inline comments to D156687: [lldb][AArch64] Add type marker to ReadAll/WriteALLRegisterValues data.
Fri, Sep 1, 7:26 AM · Restricted Project, Restricted Project
omjavaid accepted D157845: [lldb][AArch64] Remove bool return from UpdateARM64SVERegistersInfos.

Thanks!

Fri, Sep 1, 4:34 AM · Restricted Project, Restricted Project
omjavaid added inline comments to D156687: [lldb][AArch64] Add type marker to ReadAll/WriteALLRegisterValues data.
Fri, Sep 1, 4:05 AM · Restricted Project, Restricted Project

Thu, Aug 31

omjavaid accepted D157488: [lldb][AArch64] Add testing of save/restore for Linux MTE control register.
Thu, Aug 31, 3:46 AM · Restricted Project, Restricted Project
omjavaid added a comment to D156687: [lldb][AArch64] Add type marker to ReadAll/WriteALLRegisterValues data.

First thing to note is that WriteRegister also behaves this way, but there it is more appropriate because it updates only part of the buffer before writing it out in its entirety. Useful to know where the pattern came from though.

You would need roughly the following per WriteXYZ:

-      error = WriteTLS();
+      error = WriteTLS(src);

-Status NativeRegisterContextLinux_arm64::WriteTLS() {
+Status NativeRegisterContextLinux_arm64::WriteTLS(const void* src/*=nullptr*/) {

-  ioVec.iov_base = GetTLSBuffer();
+  ioVec.iov_base = src ? const_cast<void*>(src) : GetTLSBuffer();

-  Status WriteTLS();
+  Status WriteTLS(const void* src=nullptr);

We can assume that the buffer is the same as the data to be written back if it's something static like TLS. For SVE/SME, we would have resized our buffer first, so it holds there too.

The added complexity isn't that much but I think it adds more thinking time for a developer than it potentially saves in copying time. I already feel like the separate xyz_is_valid is enough to think about and having a potential second data source just adds to that load.

From the header docs it seems I was right that this is used primarily for expression evaluation:

// These two functions are used to implement "push" and "pop" of register
// states.  They are used primarily for expression evaluation, where we need
// to push a new state (storing the old one in data_sp) and then restoring
// the original state by passing the data_sp we got from ReadAllRegisters to
// WriteAllRegisterValues.

Which you would be doing a lot of in a formatter for example, but you'd get better savings implementing a more efficient packet format to do all that at once, I guess.

QSaveRegisterState / QRestoreRegisterState packets call it as part of expression evaluation, though in theory it's not always that. That's an lldb extension anyway so we're in control of it at least. In theory this could be used to restore state that is not just the previous state but I don't know how you'd trigger that from lldb.

The other use is NativeProcessLinux::Syscall which is sufficiently rare we can ignore that.

I did do a very rough benchmark where I printed the same expression 2000 times, so each one is doing a save/restore. Once with the code in this review right now, and again with this potential optimisation added to GPR/FPR/TLS (I'm on a Mountain Jade machine without SVE). Caveat shared machine, made up benchmark, etc. but all runs of both hovered between 16 and 17 seconds. Neither seemed to be consistently lower or higher than the other. Doesn't mean this isn't a speedup in isolation but if it is, it's dwarfed by the syscalls and packets sent back and forth.

Thu, Aug 31, 2:14 AM · Restricted Project, Restricted Project

Tue, Aug 29

omjavaid added a comment to D156687: [lldb][AArch64] Add type marker to ReadAll/WriteALLRegisterValues data.

I don't know about expensive literally but I did wonder if we could rely on the NativeRegisterContextLinux_arm64 buffers not being modified while the expression runs. Then do what I think you mean which is just flush them all to the process.

I'll need to work out exactly when SaveAll/WriteAll is and can be called. Part of me wonders why we even have such methods if you could just flush the existing buffers, but it wouldn't be the first time we've duplicated things.

Tue, Aug 29, 8:55 AM · Restricted Project, Restricted Project
omjavaid added a comment to D156687: [lldb][AArch64] Add type marker to ReadAll/WriteALLRegisterValues data.

I have a feeling that expressions are becoming an expensive operation with amount of data we need to move back and forth between various buffers. Is there a way we can optimise this may be write register directly from source buffer.
Also how much minimum data we need to move when SME is enabled?

Tue, Aug 29, 8:00 AM · Restricted Project, Restricted Project
omjavaid added a comment to D157488: [lldb][AArch64] Add testing of save/restore for Linux MTE control register.

This looks fine but instead of adding a new test cant we add MTE control register tests to already available MTE tests?

Tue, Aug 29, 4:26 AM · Restricted Project, Restricted Project
omjavaid accepted D157000: [lldb][AArch64] Check SIMD save/restore in SVE SIMD test.
Tue, Aug 29, 4:20 AM · Restricted Project, Restricted Project

Mon, Aug 28

omjavaid added a reverting change for rG653f77690bb2: [mlir][complex] Convert complex.abs to arith with fastmath flag: rG8e946fec0441: Revert "[mlir][complex] Convert complex.abs to arith with fastmath flag".
Mon, Aug 28, 2:04 PM · Restricted Project, Restricted Project
omjavaid committed rG8e946fec0441: Revert "[mlir][complex] Convert complex.abs to arith with fastmath flag" (authored by omjavaid).
Revert "[mlir][complex] Convert complex.abs to arith with fastmath flag"
Mon, Aug 28, 2:04 PM · Restricted Project, Restricted Project

Aug 7 2023

omjavaid accepted D156949: [lldb] Update LLDB Code Ownership.
Aug 7 2023, 4:57 AM · Restricted Project, Restricted Project
omjavaid added a comment to D157274: [flang] Add builder/worker for debug build with reverse iteration.

In case it's useful, this is what Linaro runs currently for flang:

clang-aarch64-full-2stage       
clang-arm64-windows-msvc        
clang-arm64-windows-msvc-2stage 
clang-aarch64-sve-vla           
clang-aarch64-sve-vla-2stage    
clang-aarch64-sve-vls           
clang-aarch64-sve-vls-2stage    
flang-aarch64-dylib             
flang-aarch64-sharedlibs        
flang-aarch64-out-of-tree       
flang-aarch64-release           
flang-aarch64-debug             
flang-aarch64-latest-clang      
flang-aarch64-rel-assert        
flang-aarch64-latest-gcc

To give you an idea why I'd like to replace an existing configuration rather than adding a new one on top of all that. Feel free to disagree of course, or suggest another home for reverse iteration.

Aug 7 2023, 4:45 AM · Restricted Project
omjavaid added a comment to D157274: [flang] Add builder/worker for debug build with reverse iteration.

Never mind got the answer from the summary.

Aug 7 2023, 4:36 AM · Restricted Project
omjavaid added a comment to D157274: [flang] Add builder/worker for debug build with reverse iteration.

Thanks David for adding this builder. Re debug builder do you plan to remove the flang-aarch64-debug after the new builder is up and running. I guess if we add a new builder with DLLVM_REVERSE_ITERATION=ON we ll loose the ccache advantage given many files will get built twice for the same set of changes.

Aug 7 2023, 4:27 AM · Restricted Project

Aug 3 2023

omjavaid accepted D156512: [lldb][AArch64] Save/restore TLS registers around expressions.

This looks good. Just a nit the summary seems to be using a lot pronouns. Could you kindly improve summary a little and add a one liner about expr_func and how it tests save/restore for future readers of this log.

Aug 3 2023, 5:01 AM · Restricted Project, Restricted Project
omjavaid accepted D156118: [lldb][AArch64] Add reading of TLS tpidr register from core files.

Looks legit. Thanks

Aug 3 2023, 4:39 AM · Restricted Project, Restricted Project, Restricted Project
omjavaid added a comment to D156839: [compiler-rt] ARM64 instruction are always 4 bytes long but GetInstructionSize in interception_win.cpp assumes x86_64 which has mixed sizes .

@farzon thanks for this fix. Please upload a full context diff using

git diff -U999999 --no-color HEAD^
Aug 3 2023, 2:00 AM · Restricted Project, Restricted Project

Jul 27 2023

omjavaid requested review of D156417: Port SingleSource tests to Windows.
Jul 27 2023, 4:46 AM · Restricted Project

Jul 21 2023

omjavaid added a comment to D154927: [lldb][AArch64] Add SME's streaming vector control register.

I guess there is not much gain from telling the user between sve/ssve mode for the moment. Can we defer this patch till SME registers are implemented?

Jul 21 2023, 7:23 AM · Restricted Project, Restricted Project
omjavaid accepted D154926: [lldb][AArch64] Add support for SME's SVE streaming mode registers.

This looks very good much simpler from the first version. just a minor nit.

Jul 21 2023, 7:18 AM · Restricted Project, Restricted Project
omjavaid accepted D154930: [lldb][AArch64] Add the tpidr2 TLS register that comes with SME.

This looks good just a minor suggestion inline.

Jul 21 2023, 2:14 AM · Restricted Project, Restricted Project

Jul 19 2023

omjavaid requested review of D155693: [Windows] This fixes modules to enable generation of size files.
Jul 19 2023, 3:50 AM · Restricted Project
omjavaid updated the diff for D153263: [RFC] Port tools/timeit.c for Windows.

This update fixes some bugs after testing.

Jul 19 2023, 3:30 AM · Restricted Project

Jul 16 2023

omjavaid added inline comments to D154926: [lldb][AArch64] Add support for SME's SVE streaming mode registers.
Jul 16 2023, 11:42 PM · Restricted Project, Restricted Project
omjavaid added inline comments to D154927: [lldb][AArch64] Add SME's streaming vector control register.
Jul 16 2023, 9:28 PM · Restricted Project, Restricted Project
omjavaid added inline comments to D154930: [lldb][AArch64] Add the tpidr2 TLS register that comes with SME.
Jul 16 2023, 9:02 PM · Restricted Project, Restricted Project

Jul 14 2023

omjavaid accepted D154823: [lldb][AArch64] Add test predicate for systems with SME enabled.
Jul 14 2023, 2:06 AM · Restricted Project, Restricted Project
omjavaid accepted D154705: [lldb][AArch64] Fix flakiness in TestSVEThreadedDynamic.

Sounds ok to me. We can always fix it if starts to cause trouble.

Jul 14 2023, 2:05 AM · Restricted Project, Restricted Project
omjavaid accepted D154448: [AArch64][LLDB] Remove lit workers limit.
Jul 14 2023, 1:49 AM · Restricted Project

Jul 4 2023

omjavaid accepted D154208: [lldb][AArch64] Handle different default vector length in SVE testing.
Jul 4 2023, 3:02 AM · Restricted Project, Restricted Project
omjavaid accepted D154204: [lldb][AArch64] Account for extra libc frames in PAC unwind test.
Jul 4 2023, 2:55 AM · Restricted Project, Restricted Project
omjavaid accepted D154201: [lldb][AArch64] Fix tagged watch test on Graviton 3.
Jul 4 2023, 2:54 AM · Restricted Project, Restricted Project

Jul 3 2023

omjavaid committed rZORG855fee4b284d: Update LLDB Arm/AArch64 email notifier list (authored by omjavaid).
Update LLDB Arm/AArch64 email notifier list
Jul 3 2023, 12:38 AM · Restricted Project

Jun 27 2023

omjavaid reopened D147740: [llvm-profdata] Refactoring Sample Profile Reader to increase FDO build speed using MD5 as key to Sample Profile map.

This seems to have broken https://lab.llvm.org/buildbot/#/builders/245/builds/10311

Jun 27 2023, 1:47 AM · Restricted Project, Restricted Project

Jun 19 2023

omjavaid requested review of D153263: [RFC] Port tools/timeit.c for Windows.
Jun 19 2023, 4:07 AM · Restricted Project

Jun 15 2023

omjavaid accepted D152516: [lldb][AArch64] Add thread local storage tpidr register.

This looks good to me, just a minor nit above. I have not run the test myself.

Jun 15 2023, 2:10 AM · Restricted Project, Restricted Project

Jun 14 2023

omjavaid accepted D152519: [lldb][AArch64] Add Scalable Matrix Extension option to QEMU launch script.

This looks good.

Jun 14 2023, 2:05 AM · Restricted Project, Restricted Project

May 30 2023

omjavaid committed rG898b880308f1: [LLDB] Update AArch64/Windows XFAIl decorators on TestNamespace.py (authored by omjavaid).
[LLDB] Update AArch64/Windows XFAIl decorators on TestNamespace.py
May 30 2023, 2:07 AM · Restricted Project

May 29 2023

omjavaid committed rG7fb60b0123e5: [LLDB] Add XFAIL on AArch64/Windows to TestNamespace.py (authored by omjavaid).
[LLDB] Add XFAIL on AArch64/Windows to TestNamespace.py
May 29 2023, 7:54 AM · Restricted Project
omjavaid added a reverting change for rG6ea1a0d4fc38: [LLDB] Add/Remove xfail for some API tests on Windows: rGab05d9134d18: Revert "[LLDB] Add/Remove xfail for some API tests on Windows".
May 29 2023, 6:40 AM · Restricted Project
omjavaid committed rGab05d9134d18: Revert "[LLDB] Add/Remove xfail for some API tests on Windows" (authored by tcwg <tcwg@linaro.org>).
Revert "[LLDB] Add/Remove xfail for some API tests on Windows"
May 29 2023, 6:40 AM · Restricted Project
omjavaid added a reverting change for D149235: Always emit symbol table when dwarf section exists in COFF: rGab05d9134d18: Revert "[LLDB] Add/Remove xfail for some API tests on Windows".
May 29 2023, 6:40 AM · Restricted Project, Restricted Project
omjavaid committed rGf2a866170c49: [LLDB] Fix TestVarPath.py for AArch64 Windows (authored by omjavaid).
[LLDB] Fix TestVarPath.py for AArch64 Windows
May 29 2023, 5:32 AM · Restricted Project
omjavaid requested changes to D151571: [flang][runtime] Support all non-ASCII characters in temporary path on Windows.

Kindly fix flang unit tests for Windows before relanding. Thanks

May 29 2023, 1:27 AM · Restricted Project, Restricted Project
omjavaid added a reverting change for rGfd0d846633b0: [flang][runtime] Support all non-ASCII characters in temporary path on Windows: rG6cf7fe4a9a71: Revert "[flang][runtime] Support all non-ASCII characters in temporary path on….
May 29 2023, 1:26 AM · Restricted Project, Restricted Project
omjavaid committed rG6cf7fe4a9a71: Revert "[flang][runtime] Support all non-ASCII characters in temporary path on… (authored by omjavaid).
Revert "[flang][runtime] Support all non-ASCII characters in temporary path on…
May 29 2023, 1:26 AM · Restricted Project, Restricted Project
omjavaid reopened D151571: [flang][runtime] Support all non-ASCII characters in temporary path on Windows.

This change has broken various unit tests on AArch64 Windows platform. I going to revert this change temporarily.

May 29 2023, 1:26 AM · Restricted Project, Restricted Project
omjavaid added a reverting change for D151571: [flang][runtime] Support all non-ASCII characters in temporary path on Windows: rG6cf7fe4a9a71: Revert "[flang][runtime] Support all non-ASCII characters in temporary path on….
May 29 2023, 1:26 AM · Restricted Project, Restricted Project
omjavaid committed rGd093111ab135: [LLDB] Remove XFAIL on Windows decorator XPASSes (authored by omjavaid).
[LLDB] Remove XFAIL on Windows decorator XPASSes
May 29 2023, 1:14 AM · Restricted Project

May 22 2023

omjavaid committed rGa7c7c61af631: [LLDB] Fix missing import in TestInterruptBacktrace.py (authored by omjavaid).
[LLDB] Fix missing import in TestInterruptBacktrace.py
May 22 2023, 4:47 AM · Restricted Project
omjavaid committed rG5dfec676c3ab: [LLDB] Skip TestInterruptBacktrace.py on Arm/Linux (authored by omjavaid).
[LLDB] Skip TestInterruptBacktrace.py on Arm/Linux
May 22 2023, 3:54 AM · Restricted Project

May 16 2023

omjavaid added a comment to D148761: Emit the correct flags for the PROC CodeView Debug Symbol.

Hi Aaron,

May 16 2023, 3:21 AM · Restricted Project, Restricted Project, Restricted Project

May 15 2023

omjavaid added a comment to D148761: Emit the correct flags for the PROC CodeView Debug Symbol.

@omjavaid this change DID NOT CAUSE THE TEST FAILURE, please see the previous comments where we were discussing this:

Thanks! Honestly, I don't know how to reproduce that test results on my Win-x86-64 platform to reveal failure reason.

CC @zturner and @clayborg -- this lldb builder has been down for 11 days and there are several failures unrelated to the one in this patch, otherwise I would have reverted this instead of waiting for the author to get back from vacation. Do either of you want to fix or revert to get the bot back into a good state?

I am the owner of lldb-aarch64-windows and i have verified that exactly this commit caused the test to fail. The builder was failing a few test earlier thats why this particular failure got masked.

Did you verify that the failure was because the changes were incorrect? These changes are correcting a bug and it's expected that downstreams like lldb may have to react to that sort of thing breaking their tests. A revert ~10 days after the failure landed is not exactly a timely revert -- now all the downstreams that did react to this change will have to react again, which is why I'm curious what amount of analysis was done prior to reverting and what details you can share about the problem.

May 15 2023, 11:34 PM · Restricted Project, Restricted Project, Restricted Project
omjavaid committed rG617c31c6a1dd: [LLDB] Fix typo in TestDataFormatterSynthVal.py (authored by omjavaid).
[LLDB] Fix typo in TestDataFormatterSynthVal.py
May 15 2023, 11:13 PM · Restricted Project
omjavaid committed rG039b28e14e6d: [LLDB] Fix TestDataFormatterSynthVal.py for AArch64/Windows (authored by omjavaid).
[LLDB] Fix TestDataFormatterSynthVal.py for AArch64/Windows
May 15 2023, 1:15 PM · Restricted Project
omjavaid added a reverting change for rGe48826e016e2: Emit the correct flags for the PROC CodeView Debug Symbol: rG6b22608a1d30: Revert "Emit the correct flags for the PROC CodeView Debug Symbol".
May 15 2023, 12:47 PM · Restricted Project, Restricted Project
omjavaid committed rG6b22608a1d30: Revert "Emit the correct flags for the PROC CodeView Debug Symbol" (authored by omjavaid).
Revert "Emit the correct flags for the PROC CodeView Debug Symbol"
May 15 2023, 12:47 PM · Restricted Project, Restricted Project
omjavaid added a reverting change for D148761: Emit the correct flags for the PROC CodeView Debug Symbol: rG6b22608a1d30: Revert "Emit the correct flags for the PROC CodeView Debug Symbol".
May 15 2023, 12:47 PM · Restricted Project, Restricted Project, Restricted Project
omjavaid closed D148761: Emit the correct flags for the PROC CodeView Debug Symbol.
May 15 2023, 12:47 PM · Restricted Project, Restricted Project, Restricted Project
omjavaid added a comment to D148761: Emit the correct flags for the PROC CodeView Debug Symbol.

@omjavaid this change DID NOT CAUSE THE TEST FAILURE, please see the previous comments where we were discussing this:

Thanks! Honestly, I don't know how to reproduce that test results on my Win-x86-64 platform to reveal failure reason.

CC @zturner and @clayborg -- this lldb builder has been down for 11 days and there are several failures unrelated to the one in this patch, otherwise I would have reverted this instead of waiting for the author to get back from vacation. Do either of you want to fix or revert to get the bot back into a good state?

May 15 2023, 12:45 PM · Restricted Project, Restricted Project, Restricted Project
omjavaid reopened D148761: Emit the correct flags for the PROC CodeView Debug Symbol.

This caused test failure on lldb-aarch64-windows buildbot
https://lab.llvm.org/buildbot/#/builders/219/builds/2520

May 15 2023, 12:13 PM · Restricted Project, Restricted Project, Restricted Project
omjavaid added a reverting change for rG2bea2d7b070d: [lldb] Refactor SBFileSpec::GetDirectory: rG58e6caaba1cf: Revert "[lldb] Refactor SBFileSpec::GetDirectory".
May 15 2023, 11:50 AM · Restricted Project
omjavaid committed rG58e6caaba1cf: Revert "[lldb] Refactor SBFileSpec::GetDirectory" (authored by omjavaid).
Revert "[lldb] Refactor SBFileSpec::GetDirectory"
May 15 2023, 11:50 AM · Restricted Project
omjavaid added a reverting change for D149625: [lldb] Refactor SBFileSpec::GetDirectory: rG58e6caaba1cf: Revert "[lldb] Refactor SBFileSpec::GetDirectory".
May 15 2023, 11:49 AM · Restricted Project, Restricted Project
omjavaid closed D149625: [lldb] Refactor SBFileSpec::GetDirectory.
May 15 2023, 11:49 AM · Restricted Project, Restricted Project
omjavaid reopened D149625: [lldb] Refactor SBFileSpec::GetDirectory.

This introduced test failures on windows lldb-aarch64-windows buildbot.

May 15 2023, 11:47 AM · Restricted Project, Restricted Project

May 2 2023

omjavaid committed rG6ea1a0d4fc38: [LLDB] Add/Remove xfail for some API tests on Windows (authored by omjavaid).
[LLDB] Add/Remove xfail for some API tests on Windows
May 2 2023, 4:46 PM · Restricted Project

Apr 26 2023

omjavaid accepted D148752: lldb: Fix usage of sve functions on arm64.
Apr 26 2023, 4:56 AM · Restricted Project, Restricted Project
omjavaid added a comment to D148752: lldb: Fix usage of sve functions on arm64.

I am building on ChromeOS. We only have headers from linux kernel 4.14 available in our build system (The actual running kernel could be a higher version).
But given these functions/struct definitions (sve::<foo>) are already available and used, why are they not used consistently?

e.g. https://source.chromium.org/chromium/external/github.com/llvm/llvm-project/+/main:lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp;l=99
already uses sve::vl_valid and there are uses of sve::user_sve_header as well.

Apr 26 2023, 4:56 AM · Restricted Project, Restricted Project

Apr 19 2023

omjavaid added a comment to D148752: lldb: Fix usage of sve functions on arm64.

HI Manoj
Which linux distro are you using for your cross build? I am wondering which version of gcc (aarch64-linux-gnu) are you using for your cross compilation build.
I believe sve headers are not defined in older versions of gcc or its packaged sysroot causing cross compilation build to break.
All sve:: functions and defines are just a make shift arrangement to accommodate build environment which dont have SVE headers/functions defined.

Apr 19 2023, 10:29 PM · Restricted Project, Restricted Project

Apr 16 2023

omjavaid committed rG9fdf82dc32dc: [LLDB] Fix broken Windows unittests build (authored by omjavaid).
[LLDB] Fix broken Windows unittests build
Apr 16 2023, 8:38 PM · Restricted Project