Page MenuHomePhabricator

omjavaid (Muhammad Omair Javaid)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 13 2015, 4:38 PM (239 w, 2 d)

Recent Activity

Mon, Oct 7

omjavaid reopened D66935: [AArch64][DebugInfo] Do not recompute CalleeSavedStackSize.

This change was reverted and hence causes LLDB AArch64 test failures again.

Mon, Oct 7, 9:31 PM · Restricted Project

Sep 2 2019

omjavaid committed rG1da33fd4eff0: [ARM64] Simplify RegisterInfos_arm64.h with macro based RegisterInfo array (authored by omjavaid).
[ARM64] Simplify RegisterInfos_arm64.h with macro based RegisterInfo array
Sep 2 2019, 4:53 AM
omjavaid committed rL370644: [ARM64] Simplify RegisterInfos_arm64.h with macro based RegisterInfo array.
[ARM64] Simplify RegisterInfos_arm64.h with macro based RegisterInfo array
Sep 2 2019, 4:52 AM
omjavaid closed D66934: [ARM64] Simplify RegisterInfos_arm64.h with macro based RegisterInfo array.
Sep 2 2019, 4:52 AM · Restricted Project
omjavaid added a comment to D66934: [ARM64] Simplify RegisterInfos_arm64.h with macro based RegisterInfo array.

Thanks @clayborg suggestions noted and will be fixed in committed patch.

Sep 2 2019, 4:22 AM · Restricted Project

Aug 29 2019

omjavaid created D66934: [ARM64] Simplify RegisterInfos_arm64.h with macro based RegisterInfo array.
Aug 29 2019, 3:22 AM · Restricted Project

Aug 26 2019

omjavaid reopened D65653: [AArch64] Change location of frame-record within callee-save area..

This rev breaks LLDB for AArch64. functionalities/thread/concurrent_events/* tests are failing after r368987.

Aug 26 2019, 12:52 PM · Restricted Project

Jun 18 2019

omjavaid committed rL363660: Add lit timeout for lldb arm/aarch64 ubuntu builders.
Add lit timeout for lldb arm/aarch64 ubuntu builders
Jun 18 2019, 3:59 AM
omjavaid committed rL363659: [zorg] Add lldb-arm-ubuntu builder.
[zorg] Add lldb-arm-ubuntu builder
Jun 18 2019, 3:50 AM
omjavaid closed D63441: [zorg] Add lldb-arm-ubuntu builder.
Jun 18 2019, 3:50 AM · Restricted Project

Jun 17 2019

omjavaid created D63441: [zorg] Add lldb-arm-ubuntu builder.
Jun 17 2019, 9:31 AM · Restricted Project

May 27 2019

omjavaid committed rL361787: [zorg] Add lldb-aarch64-ubuntu builder.
[zorg] Add lldb-aarch64-ubuntu builder
May 27 2019, 8:08 PM
omjavaid closed D62473: [zorg] Add lldb-aarch64-ubuntu builder.
May 27 2019, 8:08 PM · Restricted Project
omjavaid added inline comments to D62473: [zorg] Add lldb-aarch64-ubuntu builder.
May 27 2019, 3:24 AM · Restricted Project
omjavaid updated the diff for D62473: [zorg] Add lldb-aarch64-ubuntu builder.

Fixes typo in first rev.

May 27 2019, 3:24 AM · Restricted Project

May 26 2019

omjavaid created D62473: [zorg] Add lldb-aarch64-ubuntu builder.
May 26 2019, 11:39 PM · Restricted Project

May 23 2019

omjavaid added a comment to D62337: [lldb] followup fix for https://reviews.llvm.org/D62305.

This change breaks arm/aarch64 linux builds.

May 23 2019, 6:07 PM · Restricted Project

May 22 2019

omjavaid committed rG772176dad1fa: [ARM64][AArch64] Update disassembler attributes to ARMv8.5 ISA with SVE… (authored by omjavaid).
[ARM64][AArch64] Update disassembler attributes to ARMv8.5 ISA with SVE…
May 22 2019, 5:47 PM
omjavaid committed rL361451: [ARM64][AArch64] Update disassembler attributes to ARMv8.5 ISA with SVE….
[ARM64][AArch64] Update disassembler attributes to ARMv8.5 ISA with SVE…
May 22 2019, 5:46 PM
omjavaid committed rLLDB361451: [ARM64][AArch64] Update disassembler attributes to ARMv8.5 ISA with SVE….
[ARM64][AArch64] Update disassembler attributes to ARMv8.5 ISA with SVE…
May 22 2019, 5:46 PM
omjavaid closed D62235: [ARM64][AArch64] Update disassembler attributes to ARMv8.5 ISA with SVE extensions.
May 22 2019, 5:46 PM · Restricted Project
omjavaid created D62235: [ARM64][AArch64] Update disassembler attributes to ARMv8.5 ISA with SVE extensions.
May 22 2019, 12:19 AM · Restricted Project

Nov 25 2018

omjavaid accepted D54386: Disable for new Linux OS runs: upload test traces.

This was much needed. LGTM

Nov 25 2018, 11:57 AM · Restricted Project, Restricted Project

Jun 15 2017

omjavaid accepted D34199: Tweak SysV_arm64 function entry unwind plan.

LGTM

Jun 15 2017, 3:50 PM

Feb 24 2017

omjavaid committed rL296119: Hardware breakpoints for Linux on Arm/AArch64 targets.
Hardware breakpoints for Linux on Arm/AArch64 targets
Feb 24 2017, 5:39 AM
omjavaid closed D29669: Hardware breakpoints implementation for Arm/AArch64 targets by committing rL296119: Hardware breakpoints for Linux on Arm/AArch64 targets.
Feb 24 2017, 5:39 AM
omjavaid updated the diff for D29669: Hardware breakpoints implementation for Arm/AArch64 targets.

Hi I have updated diff with corrections.

Feb 24 2017, 4:00 AM

Feb 22 2017

omjavaid added inline comments to D29669: Hardware breakpoints implementation for Arm/AArch64 targets.
Feb 22 2017, 7:44 PM

Feb 20 2017

omjavaid retitled D29669: Hardware breakpoints implementation for Arm/AArch64 targets from Hardware breakpoints implementation for AArch64 targets to Hardware breakpoints implementation for Arm/AArch64 targets.
Feb 20 2017, 10:56 AM

Feb 15 2017

omjavaid updated the diff for D29669: Hardware breakpoints implementation for Arm/AArch64 targets.

This patch has following updates:

Feb 15 2017, 3:10 AM

Feb 9 2017

omjavaid added a comment to D29669: Hardware breakpoints implementation for Arm/AArch64 targets.

I would prefer to see NativeBreakpoint struct expanded to have more member variables instead of adding a new hardware breakpoint list. Then you just ask any breakpoint to enable/disable/remove itself and the structure contains all of the info we need. Keeping two lists means we have to check two lists. Let me know if any of my inline comments weren't clear?

Feb 9 2017, 3:02 AM

Feb 7 2017

omjavaid created D29669: Hardware breakpoints implementation for Arm/AArch64 targets.
Feb 7 2017, 12:10 PM

Feb 1 2017

omjavaid committed rL293850: Fix LLDB Android AArch64 GCC debug info build.
Fix LLDB Android AArch64 GCC debug info build
Feb 1 2017, 5:29 PM
omjavaid closed D29042: Fix LLDB Android AArch64 gcc debug info build by committing rL293850: Fix LLDB Android AArch64 GCC debug info build.
Feb 1 2017, 5:29 PM

Jan 31 2017

omjavaid updated the diff for D29042: Fix LLDB Android AArch64 gcc debug info build .

I have added look up for dladdr and it works for android debug info build.

Jan 31 2017, 3:55 AM

Jan 25 2017

omjavaid added a comment to D29042: Fix LLDB Android AArch64 gcc debug info build .

So I have given this a thought and have a inclination towards sticking to my first patch that was testing for following:

Jan 25 2017, 3:18 PM

Jan 24 2017

omjavaid updated the diff for D29042: Fix LLDB Android AArch64 gcc debug info build .

Guarding against HAVE_DLOPEN now. Works fine.

Jan 24 2017, 2:00 AM

Jan 23 2017

omjavaid created D29042: Fix LLDB Android AArch64 gcc debug info build .
Jan 23 2017, 11:28 AM

Jan 13 2017

omjavaid committed rL291949: Fix TestRegisterVariables for linux arm/arm64 gcc ver > 5.
Fix TestRegisterVariables for linux arm/arm64 gcc ver > 5
Jan 13 2017, 11:39 AM
omjavaid closed D28666: Fix TestRegisterVariables for linux arm/arm64 gcc ver > 5 by committing rL291949: Fix TestRegisterVariables for linux arm/arm64 gcc ver > 5.
Jan 13 2017, 11:39 AM
omjavaid retitled D28666: Fix TestRegisterVariables for linux arm/arm64 gcc ver > 5 from to Fix TestRegisterVariables for linux arm/arm64 gcc ver > 5.
Jan 13 2017, 1:32 AM
omjavaid committed rL291889: Fix log typo in ABISysV_arm64.cpp.
Fix log typo in ABISysV_arm64.cpp
Jan 13 2017, 1:18 AM

Jan 2 2017

omjavaid committed rL290821: XFail TestNoreturnUnwind for arm targets.
XFail TestNoreturnUnwind for arm targets
Jan 2 2017, 10:51 AM

Nov 25 2016

omjavaid abandoned D24610: LLDB Arm Watchpoints: Use single hardware watchpoint slot to watch multiple bytes where possible.

There is not exact solution that satisfies all corner cases. Abandoning for now until I come up with a solution that covers us from all corners.

Nov 25 2016, 2:01 AM
omjavaid added a comment to D27124: [LLDB][MIPS] Fix TestWatchpointIter failure.

Although this patch fixes the test case in question but in theory EphemeralMode watchpoint enable/disable cycles should be independent of step-over watchpoint enable disable cycle.

Nov 25 2016, 1:42 AM

Nov 22 2016

omjavaid committed rL287631: Fix build failure on Linux and BSD by reverting r287597.
Fix build failure on Linux and BSD by reverting r287597
Nov 22 2016, 1:57 AM

Nov 21 2016

omjavaid committed rL287542: Fix remote-linux regression due to stringRef changes.
Fix remote-linux regression due to stringRef changes
Nov 21 2016, 7:28 AM

Nov 11 2016

omjavaid committed rL286574: Mark xfail TestNamespaceDefinitions for arm/aarch64 targets.
Mark xfail TestNamespaceDefinitions for arm/aarch64 targets
Nov 11 2016, 2:10 AM

Oct 20 2016

omjavaid committed rL284706: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate….
Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate…
Oct 20 2016, 2:16 AM
omjavaid closed D25057: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate watchpoints by committing rL284706: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate….
Oct 20 2016, 2:16 AM

Oct 18 2016

omjavaid abandoned D11129: Fix for remote-linux test fails: use currently selected platform on target launch.
Oct 18 2016, 8:55 PM
omjavaid updated the diff for D25057: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate watchpoints.

Sorry I was on Holiday so couldnt get back to this earlier.

Oct 18 2016, 8:51 PM

Oct 3 2016

omjavaid added a comment to D25057: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate watchpoints.

@labath Referring to your email on the mailing list.

Oct 3 2016, 10:17 PM

Sep 28 2016

omjavaid retitled D25057: Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate watchpoints from to Fix ARM/AArch64 Step-Over watchpoint issue remove provision for duplicate watchpoints.
Sep 28 2016, 5:26 PM

Sep 27 2016

omjavaid updated the diff for D24610: LLDB Arm Watchpoints: Use single hardware watchpoint slot to watch multiple bytes where possible.

Give this approach a rethink I dont see a lot of problems with this final implementation unless it fails on other architectures.
We are already hacking our way to have these byte selection watchpoints working in existing code. New code seems to be improving the hack in my opinion.

Sep 27 2016, 3:39 PM

Sep 26 2016

omjavaid updated the diff for D24610: LLDB Arm Watchpoints: Use single hardware watchpoint slot to watch multiple bytes where possible.

This is a new version of what seems to me fully implementing functionality we intend to have here.

Sep 26 2016, 5:39 PM

Sep 19 2016

omjavaid added a comment to D24610: LLDB Arm Watchpoints: Use single hardware watchpoint slot to watch multiple bytes where possible.

Answers to comments. I will upload a updated patch after corrections and updates.

Sep 19 2016, 1:04 PM

Sep 16 2016

omjavaid updated the diff for D24610: LLDB Arm Watchpoints: Use single hardware watchpoint slot to watch multiple bytes where possible.

I have added a new test case that tests suggested scnario without changing any previous test cases.

Sep 16 2016, 6:47 AM
omjavaid added a comment to D24610: LLDB Arm Watchpoints: Use single hardware watchpoint slot to watch multiple bytes where possible.

comments inline.

Sep 16 2016, 3:59 AM

Sep 15 2016

omjavaid added a reviewer for D24610: LLDB Arm Watchpoints: Use single hardware watchpoint slot to watch multiple bytes where possible: clayborg.
Sep 15 2016, 6:43 AM
omjavaid retitled D24610: LLDB Arm Watchpoints: Use single hardware watchpoint slot to watch multiple bytes where possible from to LLDB Arm Watchpoints: Use single hardware watchpoint slot to watch multiple bytes where possible.
Sep 15 2016, 6:41 AM

Aug 17 2016

omjavaid committed rL278947: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY.
Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY
Aug 17 2016, 9:53 AM
omjavaid closed D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY by committing rL278947: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY.
Aug 17 2016, 9:53 AM
omjavaid updated the diff for D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY.

so I have used ?= now with following new changes

OBJCOPY ?= $(call replace_cc_with,objcopy)
ARCHIVER ?= $(call replace_cc_with,ar)
override AR = $(ARCHIVER)
Aug 17 2016, 5:27 AM

Aug 15 2016

omjavaid added a comment to D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY.

I like your suggestions and I dont think we have any other way but to use preset environment variable to detect what kind of TOOLCHAIN we want to use apart from some standard cases where we have the ability to detect through proposed hack logic.

Aug 15 2016, 7:05 PM

Aug 11 2016

omjavaid committed rL278326: Make sure LldbGdbServerTestCase is built in arm mode to avoid failures due….
Make sure LldbGdbServerTestCase is built in arm mode to avoid failures due…
Aug 11 2016, 3:43 AM
omjavaid closed D23395: Make sure LldbGdbServerTestCase is built in arm mode to avoid failures due thumb instructions by committing rL278326: Make sure LldbGdbServerTestCase is built in arm mode to avoid failures due….
Aug 11 2016, 3:43 AM
omjavaid updated the diff for D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY.

Updated with suggestion incorporated.

Aug 11 2016, 3:35 AM
omjavaid retitled D23395: Make sure LldbGdbServerTestCase is built in arm mode to avoid failures due thumb instructions from to Make sure LldbGdbServerTestCase is built in arm mode to avoid failures due thumb instructions.
Aug 11 2016, 2:42 AM

Aug 9 2016

omjavaid added inline comments to D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY.
Aug 9 2016, 1:18 PM

Aug 8 2016

omjavaid updated the diff for D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY.

Adding context.

Aug 8 2016, 3:07 PM
omjavaid reopened D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY.

reopening this for new review.

Aug 8 2016, 3:04 PM
omjavaid updated the diff for D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY.

I have updated previous patch which handles compiler binaries which have version string appended at the end like gcc-4.9 or clang-3.5.

Aug 8 2016, 3:04 PM

Aug 2 2016

omjavaid committed rL277453: Revert rL277429: Correct makefile.rules to use toolchain specific AR and OBJCOPY.
Revert rL277429: Correct makefile.rules to use toolchain specific AR and OBJCOPY
Aug 2 2016, 6:25 AM
omjavaid added a reverting change for rL277429: Correct makefile.rules to use toolchain specific AR and OBJCOPY: rL277453: Revert rL277429: Correct makefile.rules to use toolchain specific AR and OBJCOPY.
Aug 2 2016, 6:25 AM
omjavaid committed rL277429: Correct makefile.rules to use toolchain specific AR and OBJCOPY.
Correct makefile.rules to use toolchain specific AR and OBJCOPY
Aug 2 2016, 1:04 AM
omjavaid closed D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY by committing rL277429: Correct makefile.rules to use toolchain specific AR and OBJCOPY.
Aug 2 2016, 1:03 AM

Jul 31 2016

omjavaid updated the diff for D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY.

Sorry about the delay updating this. I lost track of this rev earlier.

Jul 31 2016, 5:12 PM

Jul 26 2016

omjavaid committed rL276814: Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets.
Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets
Jul 26 2016, 2:50 PM
omjavaid closed D22771: Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets by committing rL276814: Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets.
Jul 26 2016, 2:50 PM
omjavaid added a comment to D22771: Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets.

I am going ahead and committing this patch. If it breaks any build please revert it.

Jul 26 2016, 2:49 PM

Jul 25 2016

omjavaid retitled D22771: Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets from to Fix LLDBConfig.cmake to enable python enabled build for all 64 bit lldb targets.
Jul 25 2016, 12:12 PM

Jun 30 2016

omjavaid committed rL274215: Correct watchpoint size test failure on certain devices.
Correct watchpoint size test failure on certain devices
Jun 30 2016, 12:16 AM

Jun 27 2016

omjavaid committed rL273869: Improve watchpoint error reporting specially for arm/aarch64 targets.
Improve watchpoint error reporting specially for arm/aarch64 targets
Jun 27 2016, 5:42 AM
omjavaid closed D21164: Improve watchpoint error reporting specially for arm/aarch64 targets by committing rL273869: Improve watchpoint error reporting specially for arm/aarch64 targets.
Jun 27 2016, 5:42 AM
omjavaid added inline comments to D21164: Improve watchpoint error reporting specially for arm/aarch64 targets.
Jun 27 2016, 5:33 AM
omjavaid committed rL273863: Allow unaligned byte/word selection watchpoints for arm- linux/android targets..
Allow unaligned byte/word selection watchpoints for arm- linux/android targets.
Jun 27 2016, 4:25 AM
omjavaid closed D21516: Allow unaligned byte/word selection watchpoints for arm- linux/android targets. by committing rL273863: Allow unaligned byte/word selection watchpoints for arm- linux/android targets..
Jun 27 2016, 4:25 AM

Jun 19 2016

omjavaid retitled D21516: Allow unaligned byte/word selection watchpoints for arm- linux/android targets. from to Allow unaligned byte/word selection watchpoints for arm- linux/android targets..
Jun 19 2016, 9:50 PM

Jun 16 2016

omjavaid added a comment to D21164: Improve watchpoint error reporting specially for arm/aarch64 targets.

@clayborg
Any comments about this change? Thanks!

Jun 16 2016, 11:03 AM
omjavaid committed rL272916: Allow installing watchpoints at less than 8-byte alligned addresses for….
Allow installing watchpoints at less than 8-byte alligned addresses for…
Jun 16 2016, 9:48 AM
omjavaid closed D21280: Allow installing watchpoints at less than 8-byte alligned addresses for AArch64 targets by committing rL272916: Allow installing watchpoints at less than 8-byte alligned addresses for….
Jun 16 2016, 9:48 AM
omjavaid added inline comments to D21280: Allow installing watchpoints at less than 8-byte alligned addresses for AArch64 targets.
Jun 16 2016, 9:37 AM

Jun 15 2016

omjavaid updated the diff for D21280: Allow installing watchpoints at less than 8-byte alligned addresses for AArch64 targets.

I have added a test cases that tests all possibilities supported by current configuration.

Jun 15 2016, 6:48 PM

Jun 13 2016

omjavaid added a comment to D21280: Allow installing watchpoints at less than 8-byte alligned addresses for AArch64 targets.

The overall change looks good, but please also add a test which specifically tests for watchpoints at unaligned addresses. Last time I checked, we all watchpoint tests were passing (at least on android) even without this patch, so it looks like our tests coverage is not sufficient here.

Jun 13 2016, 11:36 PM
omjavaid retitled D21280: Allow installing watchpoints at less than 8-byte alligned addresses for AArch64 targets from to Allow installing watchpoints at less than 8-byte alligned addresses for AArch64 targets.
Jun 13 2016, 1:56 AM

Jun 8 2016

omjavaid retitled D21164: Improve watchpoint error reporting specially for arm/aarch64 targets from to Improve watchpoint error reporting specially for arm/aarch64 targets.
Jun 8 2016, 6:20 PM

May 25 2016

omjavaid committed rL270780: Mark some aarch64-linux specific xfails marking bug entries.
Mark some aarch64-linux specific xfails marking bug entries
May 25 2016, 3:36 PM
omjavaid committed rL270745: Mark some arm-linux specific xfails marking bug entries.
Mark some arm-linux specific xfails marking bug entries
May 25 2016, 11:55 AM

May 20 2016

omjavaid accepted D20368: Remove Platform usages from NativeProcessLinux.

Seems to be causing no regressions on arm-linux.

May 20 2016, 7:14 AM