User Details
- User Since
- Mar 13 2015, 4:38 PM (375 w, 2 d)
Yesterday
I have reverted this temporarily as It broke LLDB API test TestBadAddressBreakpoints.py
Tue, May 17
Tue, Apr 26
LGTM. With a minor nit fix about FixAnyAddress vs FixDataAddress if required.
Mon, Apr 25
Very corner case but Is there a possibility of masks changing positions during the life-time of an inferior ? So this makes me think that code/data masks are per process and cant be changes once set. Should we worry about it?AFAIK this is fine but just asking to clear any ambiguities.
Looks good to me.
Apr 20 2022
Apr 13 2022
I did have a completely difference experience, here are steps to reproduce:
Apr 12 2022
This broke LLVM AArch64 buildbot clang-aarch64-sve-vls-2stage
https://lab.llvm.org/buildbot/#/builders/176/builds/1515
llvm-tblgen crashes after applying this patch.
Apr 8 2022
Thanks for good detailed explanation. I think from the code readability point of view, we may use FixAddress function which i believe already exists in ABI and if not then introduce FixAnyAddress may be. We can put all the comments about PAC/TBI code vs data address bits there in AArch64 ABI code instead of putting a comment about code/data address everytime we use FixDataAddress in generic code.
Apr 7 2022
Apr 5 2022
Hi I have temporarily reverted this change as it has caused LLVM buildbot failures with failing fuzzer-threaded.test with clang crashing over an assertion failure in llvm/lib/CodeGen/CFIFixup.cpp. Kindly look into it. Thanks
.
Apr 4 2022
Apr 1 2022
Mar 28 2022
Mar 16 2022
Mar 8 2022
Feb 25 2022
Feb 23 2022
Feb 21 2022
Feb 17 2022
Hi @clayborg this rev has caused some lldb-vscode test failures across all LLDB/Linux buildbots.
Feb 15 2022
Hi James, Thanks for highlighting this. I ve merged a fix.
Feb 10 2022
Feb 9 2022
ping!
Jan 27 2022
Jan 25 2022
looks good thanks
LGTM Thanks! for your patience
Jan 23 2022
Jan 20 2022
Jan 19 2022
I have still setting up the Arm WoA worker which requires a bit of tweaking with visual studio config as well. I have not found a final patch for it and going to commit this one while I work on a follow up.
This doesnt interfere with LLDB tests for SVE. Rather I have not used it in a while for SVE tests I ahve using setup similar to to one David has explained above.
Jan 14 2022
I conveniently copied lit args from arm lldb bot. AFAIK both giving and sv together shows output as well as a progress bar but I am not too sure.
Jan 12 2022
Apologies for late response!!!
Jan 10 2022
Dec 29 2021
This breaks LLDB Linux buildbots:
Dec 23 2021
This has broken all LLDB buildbots:
Dec 14 2021
@lorenz are you still working on this issue? We are seeing this issue on LLVM for Windows on Arm while compiling TensorFlow with clang-cl.
Dec 3 2021
Dec 1 2021
Hi @clayborg
This breaks LLDB Arm/Linux buildbot. https://lab.llvm.org/buildbot/#/builders/17/builds/14035
Nov 8 2021
Nov 4 2021
Nov 3 2021
Oct 26 2021
Oct 25 2021
Oct 20 2021
This look great. Thanks for doing the legit fix.
Oct 11 2021
Oct 6 2021
These two are rare control paths so I thought not to infiltrate with
lambda arguments. Maybe we can readjust it if further logging needs arise
in future.
This addresses review comments converts printfs to log messages.