This is an archive of the discontinued LLVM Phabricator instance.

[lldb][AArch64] Add release notes and documentation for SME
AbandonedPublic

Authored by DavidSpickett on Aug 22 2023, 5:25 AM.

Details

Summary

This adds a release note for all the SME support now in LLDB
and a page where I have documented the user experience (for want
of a better term) when using SVE and SME.

This includes things like which mode transitions can or cannot
be triggered from within LLDB. I hope this will serve to A: document
what I've implemented and B: be a user's guide to these extensions.

(though it is not a design document, read the commits and code
for that sort of detail)

Diff Detail

Event Timeline

DavidSpickett created this revision.Aug 22 2023, 5:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 22 2023, 5:25 AM
DavidSpickett requested review of this revision.Aug 22 2023, 5:25 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 22 2023, 5:25 AM
DavidSpickett added a subscriber: jasonmolenda.

@jasonmolenda you asked some good questions about all this before, any of those not answered by this doc? No need to look deeply into anything, just stuff that comes to mind.

And if one of those is why does lldb use vg with these strange units, I think "vg" the term Arm's Fast Models used and GDB adopted it. It's possible we could improve that later but for now it is what it is.

Matt added a subscriber: Matt.Aug 22 2023, 3:31 PM

LGTM, fwiw.

lldb/docs/use/aarch64-linux.rst
37

You describe vg without noting the size, but note the size of vq and vl. Maybe these could be described similarly, as counting doublewords/quadwords/bytes.

39

drop second elsewhere

115

architecturally

  • Correct speeling.
  • Drop repeated word.
  • Clarify vg/vq/vl explanation and end with a listing of each value for the example shown.
DavidSpickett marked 3 inline comments as done.Aug 23 2023, 1:33 AM

LGTM, fwiw.

Thanks! I wanted to have someone who wasn't knee deep in this to look it over.