Page MenuHomePhabricator

jasonmolenda (Jason Molenda)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 2 2014, 12:05 PM (282 w, 4 h)

Recent Activity

Fri, Jan 24

jasonmolenda accepted D73401: [ldb/Breakpoint] Recognize HW breakpoints as breakpoints instead of just mach exceptions..

Looks like a good change.

Fri, Jan 24, 7:00 PM · Restricted Project
jasonmolenda accepted D72981: [debugserver] Unify the breakpoint/watchpoint interface (NFCI).

Looks good.

Fri, Jan 24, 3:05 PM · Restricted Project
jasonmolenda accepted D72985: [lldb/debugserver] Implement hardware breakpoints for x86_64 and i386.

Sorry for the delay, looks good to me.

Fri, Jan 24, 2:39 PM · Restricted Project

Wed, Jan 22

jasonmolenda committed rG1f45914b4289: Embed a zero-length /dev/null in darwin-debug for the special section. (authored by jasonmolenda).
Embed a zero-length /dev/null in darwin-debug for the special section.
Wed, Jan 22, 3:52 PM

Tue, Jan 21

jasonmolenda committed rG83a131b27642: Fix an over-suspend bug with LaunchInNewTerminalWithAppleScript sessions (authored by jasonmolenda).
Fix an over-suspend bug with LaunchInNewTerminalWithAppleScript sessions
Tue, Jan 21, 3:00 PM
jasonmolenda closed D72963: When darwin-debug exec's inferior suspended, make debugserver know that suspend count is higher than normal.
Tue, Jan 21, 3:00 PM · Restricted Project
jasonmolenda accepted D69524: [debugserver] Delete macOS/PPC debug server implementation.

Ah, sorry yes, the initial debugserver implementation was written back when macOS ppc was still a thing (although on its way out) - but the time the switch happened to lldb, we'd dropped support entirely. I doubt any of this code was ever actually used.

Tue, Jan 21, 10:29 AM · Restricted Project

Fri, Jan 17

jasonmolenda accepted D72971: [debugserver] Share code between Enable/DisableHardwareWatchpoint (NFC).

Yep, looks good.

Fri, Jan 17, 6:58 PM · Restricted Project
jasonmolenda created D72963: When darwin-debug exec's inferior suspended, make debugserver know that suspend count is higher than normal.
Fri, Jan 17, 3:39 PM · Restricted Project
jasonmolenda abandoned D72813: Fixes to lldb's eLaunchFlagLaunchInTTY feature on macOS.

Taking a different approach to fixing this.

Fri, Jan 17, 3:30 PM · Restricted Project

Thu, Jan 16

jasonmolenda added a comment to D72813: Fixes to lldb's eLaunchFlagLaunchInTTY feature on macOS.

ok if this works for now that is fine. Just close the socket_fd when we fail to write the pid to the socket and this is good to go.

Thu, Jan 16, 1:36 PM · Restricted Project

Wed, Jan 15

jasonmolenda added a comment to D72813: Fixes to lldb's eLaunchFlagLaunchInTTY feature on macOS.

Thanks for the review Greg. To really do this reliably, we probably either need to use a different kernel API, or push this down into debugserver where we can get the process' task port and inspect what its status is. This patch is more a preliminary one to get it working much of the time -- getting it to always work is going to require a slightly different approach.

Wed, Jan 15, 5:29 PM · Restricted Project
jasonmolenda created D72813: Fixes to lldb's eLaunchFlagLaunchInTTY feature on macOS.
Wed, Jan 15, 4:32 PM · Restricted Project

Thu, Jan 9

jasonmolenda committed rG02113918ed6b: When reading Aux file in chunks, read consecutive byte ranges (authored by jasonmolenda).
When reading Aux file in chunks, read consecutive byte ranges
Thu, Jan 9, 5:48 PM

Wed, Jan 8

jasonmolenda committed rGd44a0743175f: Save more descriptive error msg from FBS/BKS, relay it up to lldb. (authored by jasonmolenda).
Save more descriptive error msg from FBS/BKS, relay it up to lldb.
Wed, Jan 8, 6:52 PM

Tue, Jan 7

jasonmolenda committed rG5e2f4dc37b1b: Rewrite comment about what watchpoints Aarch64 supports. (authored by jasonmolenda).
Rewrite comment about what watchpoints Aarch64 supports.
Tue, Jan 7, 4:19 PM

Mon, Jan 6

jasonmolenda committed rG450073c639d7: Change the patterns to include the prefix '= ' so we don't pass errantly. (authored by jasonmolenda).
Change the patterns to include the prefix '= ' so we don't pass errantly.
Mon, Jan 6, 3:22 PM

Dec 18 2019

jasonmolenda committed rG7026b34702f3: make err msg in MachSymtabSectionInfo::GetSection clear about the file (authored by jasonmolenda).
make err msg in MachSymtabSectionInfo::GetSection clear about the file
Dec 18 2019, 4:14 PM
jasonmolenda committed rG997bc8b2e6b9: Add prototype for a function we call. (authored by jasonmolenda).
Add prototype for a function we call.
Dec 18 2019, 2:19 PM

Dec 11 2019

jasonmolenda committed rG6d64162a2d0d: return-object-by-reference ("non trivial") xfail on arm64 in TestTrivialABI.py (authored by jasonmolenda).
return-object-by-reference ("non trivial") xfail on arm64 in TestTrivialABI.py
Dec 11 2019, 12:09 PM
jasonmolenda committed rG52c5342ebcc1: update TestThreadStepOut.py to expect correct source line on arm64. (authored by jasonmolenda).
update TestThreadStepOut.py to expect correct source line on arm64.
Dec 11 2019, 9:17 AM
jasonmolenda committed rG24a4d27acd38: Don't run expect based tests remotely. (authored by jasonmolenda).
Don't run expect based tests remotely.
Dec 11 2019, 8:31 AM

Dec 10 2019

jasonmolenda committed rGaf3aac9a227e: Change the mtc Makefile to check $SDKROOT value instead of depending on it… (authored by jasonmolenda).
Change the mtc Makefile to check $SDKROOT value instead of depending on it…
Dec 10 2019, 6:55 PM
jasonmolenda committed rGb0937be06e44: Skip TestGuiBasic.py on ios etc device testing. (authored by jasonmolenda).
Skip TestGuiBasic.py on ios etc device testing.
Dec 10 2019, 3:19 PM
jasonmolenda committed rG90f4355b43ea: Skip TestMultilineCompletion.py on ios testsuite runs. (authored by jasonmolenda).
Skip TestMultilineCompletion.py on ios testsuite runs.
Dec 10 2019, 2:55 PM

Dec 9 2019

jasonmolenda added inline comments to D71237: [FormatEntity] Add mangled function name support.
Dec 9 2019, 5:11 PM · Restricted Project

Dec 4 2019

jasonmolenda committed rGe1a7d042c365: Add parray example for lldb, vrs. *ptr@count gdb cmd. (authored by jasonmolenda).
Add parray example for lldb, vrs. *ptr@count gdb cmd.
Dec 4 2019, 3:45 PM
jasonmolenda committed rGe001bf6330bb: Add help text for parray and poarray aliases. (authored by jasonmolenda).
Add help text for parray and poarray aliases.
Dec 4 2019, 3:36 PM
jasonmolenda committed rGe11df5858005: Upstream debugserver arm64e support. (authored by jasonmolenda).
Upstream debugserver arm64e support.
Dec 4 2019, 3:26 PM
jasonmolenda accepted D70155: [LLDB] Avoid triple corruption while merging core info from platform and target triples.

Thanks for the ping, yes this looks good to me.

Dec 4 2019, 12:37 PM · Restricted Project

Dec 3 2019

jasonmolenda added a comment to D63540: Fix lookup of symbols with the same address range but different binding.

Hi Jan,

I have done further investigation on this with new ampere arm server. This problem manifests itself on all kind of Debian flavors and is not related to underlying libraries. I have tested LLDB on Arm 32bit host with Ubuntu Xenial, Bionic and Debian Buster all show same problem.

Moreover this problem seems to be emerging from clang expression parser generating symbols while evaluating certain types of expressions. These symbols are rejected by expression interpreter. LLDB symtab classes are utilized for expressions as well so it is a highly likely problem so I would suggest you to investigate further on these lines

For example:
./bin/lldb-dotest -p TestVirtual.py -v -t

test_virtual_madness_dwarf (TestVirtual.CppVirtualMadness) fails with following error

runCmd: expression a_as_A->a()
runCmd failed!
error: Can't run the expression locally: Interpreter doesn't handle one of the expression's opcodes

Dec 3 2019, 11:29 AM · Restricted Project, Restricted Project

Dec 2 2019

jasonmolenda added a comment to D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM.

I don't want to add noise to this, but there's a related change that I'd like to upstream soon -- ARMv8.3 pointer authentication bits in addresses. With the ARMv8.3 ISA, higher bits that aren't used for addressing can be used to sign & authenticate pointers that are saved in memory, where they may be overwritten via buffer over-runs et al, to verify that they have not been modified before they are used. I hope to put together a patchset for upstreaming the changes I made to lldb to support this soon.

Dec 2 2019, 5:26 PM · Restricted Project
jasonmolenda accepted D70906: [lldb] Move register info "augmentation" from gdb-remote into ABI.

Good change, lgtm.

Dec 2 2019, 3:30 PM · Restricted Project

Nov 22 2019

jasonmolenda committed rG45098b6809eb: Remove extraneous log enabling. (authored by jasonmolenda).
Remove extraneous log enabling.
Nov 22 2019, 2:16 PM

Nov 21 2019

jasonmolenda added a comment to D70574: [lldb-server] Verify 'g' is supported before relying on them.

Hi, sorry I haven't had time to get back to this one. I wanted to look into the m_avoid_g_packets ivar in GDBRemoteCommunicationClient and GDBRemoteCommunicationClient::AvoidGPackets. It looks like it was written to specifically avoid the g packet with arm64 devices, and I think it's trying to avoid the g packet for older debugservers.

Nov 21 2019, 4:01 PM · Restricted Project

Nov 20 2019

jasonmolenda committed rGf24ed3a05198: Handle the case where the 'g' packet doesn't get all regs. lldb would silently… (authored by jasonmolenda).
Handle the case where the 'g' packet doesn't get all regs. lldb would silently…
Nov 20 2019, 2:15 PM
jasonmolenda closed D70417: Accept g packet responses that don't supply all registers.
Nov 20 2019, 2:15 PM · Restricted Project
jasonmolenda added a comment to D70417: Accept g packet responses that don't supply all registers.

Thanks for looking this over Pavel.

Nov 20 2019, 9:45 AM · Restricted Project

Nov 19 2019

jasonmolenda updated the diff for D70417: Accept g packet responses that don't supply all registers.

Updated GDBRemoteRegisterContext::ReadRegisterBytes to only mark registers as valid if the full contents for the register are included in the g packet. Updated gdbclientutils.py to strip off the thread specifier from the G packet, if it's present. Change the test file to check that the G packet either includes the full register context or just the general purpose registers.

Nov 19 2019, 12:52 PM · Restricted Project

Nov 18 2019

jasonmolenda added a comment to D70417: Accept g packet responses that don't supply all registers.

It might be worth adding an extra conditional to check for a buffer of 0 bytes returned. I haven't checked if ReadAllRegisters() would return success if a 0-length register context was received.

Nov 18 2019, 6:53 PM · Restricted Project
jasonmolenda created D70417: Accept g packet responses that don't supply all registers.
Nov 18 2019, 6:53 PM · Restricted Project

Nov 8 2019

jasonmolenda committed rG60ab30ebce83: Temporarily change the default for use-g-packet-for-reading to false, until we… (authored by jasonmolenda).
Temporarily change the default for use-g-packet-for-reading to false, until we…
Nov 8 2019, 6:22 PM
jasonmolenda committed rG1478f36f27cf: Test case to verify that lldb falls back to p/P if g is unsupported and that… (authored by jasonmolenda).
Test case to verify that lldb falls back to p/P if g is unsupported and that…
Nov 8 2019, 4:06 PM

Nov 7 2019

jasonmolenda committed rG6602e1fb0e34: Reordering KextImageInfo::LoadImageUsingMemoryModule so we only call… (authored by jasonmolenda).
Reordering KextImageInfo::LoadImageUsingMemoryModule so we only call…
Nov 7 2019, 7:39 PM

Nov 5 2019

jasonmolenda added a comment to D69871: crashlog.py: Improve regular expressions.

I'll be honest I'm having trouble thinking of all the possible problems these regexes might have just by looking at them, but overall this looks good to me.

Nov 5 2019, 6:56 PM · Restricted Project

Oct 31 2019

jasonmolenda committed rG54a873b158bd: Fix typeo in CPU_TYPE_ARM64_32 for older SDKs. (authored by jasonmolenda).
Fix typeo in CPU_TYPE_ARM64_32 for older SDKs.
Oct 31 2019, 2:15 PM

Oct 28 2019

jasonmolenda added a comment to D62931: [lldb-server] Add setting to force 'g' packet use.

Yeah, more tests would be useful. They made me notice an issue btw. I was simply sending a 'g' packet and checking if the server replied back nicely; however, IIUC with 'G' packets it isn't so simple because we also need to send the registers data in the same packet. I'm not sure how I could do that, and I'm also afraid that check could get too expensive. Do you have any idea what could be a nice way to handle that?

Oct 28 2019, 5:21 PM · Restricted Project, Restricted Project

Oct 16 2019

jasonmolenda committed rG7dd7a3607596: Add arm64_32 support to lldb, an ILP32 codegen that runs on arm64 ISA targets… (authored by jasonmolenda).
Add arm64_32 support to lldb, an ILP32 codegen that runs on arm64 ISA targets…
Oct 16 2019, 12:22 PM
jasonmolenda closed D69008: Add arm64_32 support.

committed in r375032 where I accidentally copied in the wrong phabracator URL, so lol.

Oct 16 2019, 12:13 PM · Restricted Project
jasonmolenda accepted D69008: Add arm64_32 support.
Oct 16 2019, 12:12 PM · Restricted Project
jasonmolenda added a comment to D69008: Add arm64_32 support.

Thanks for looking it over, Pavel. It touches lots of different files, but the changes are so tiny in most cases, I didn't know who to set as a reviewer. ;)

Oct 16 2019, 7:30 AM · Restricted Project

Oct 15 2019

jasonmolenda created D69008: Add arm64_32 support.
Oct 15 2019, 3:00 PM · Restricted Project

Oct 10 2019

jasonmolenda accepted D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans.

Thanks for all of the work on this patch Aleksandr, I really appreciate the work and this will be a nice addition to lldb. Apologies again for not looking over the revised patch earlier -- this looks really good to me, please do commit it when you have a chance.

Oct 10 2019, 10:23 PM · Restricted Project, Restricted Project

Oct 9 2019

jasonmolenda committed rGd6e9e99cec95: Change debugserver to use the brk #0 for breakpoints. (authored by jasonmolenda).
Change debugserver to use the brk #0 for breakpoints.
Oct 9 2019, 5:17 PM
jasonmolenda accepted D68454: Fix the unwinding plan augmentation from x86 assembly.

Hi Jaroslav, I apologize for taking so long to look at this; I've been heads-down on a project the past few weeks an my email inbox is a disaster right now.

Oct 9 2019, 3:04 PM · Restricted Project

Oct 8 2019

jasonmolenda accepted D68655: Trust the arange accelerator tables in dSYMs.

Nice fix. The real cost of computing the aranges manually is expanding all the line tables and calling GetContiguousFileAddressRanges on them. I wonder if avoiding the full linetable expansion here is shifting that to a different place for this operation.

Oct 8 2019, 1:14 PM · Restricted Project

Oct 4 2019

jasonmolenda committed rG984d08c680a7: Expand on the qfProcessInfo documentation, add examples from lldb-gdb-remote. (authored by jasonmolenda).
Expand on the qfProcessInfo documentation, add examples from lldb-gdb-remote.
Oct 4 2019, 2:03 PM

Sep 27 2019

jasonmolenda accepted D68156: [debugserver] Add --version/-V command line option to debugserver..

Awesome.

Sep 27 2019, 2:22 PM · Restricted Project, Restricted Project
jasonmolenda added a comment to D68156: [debugserver] Add --version/-V command line option to debugserver..

Hm, if the goal is to get -version (an unrecognized cmd line option) to explicitly print to stderr, don't we want to change the lines in show_usage_and_exit? I think this change would result in us not getting the version string in console logs for normal debug sessions, where we want to keep it.

Sep 27 2019, 12:59 PM · Restricted Project, Restricted Project

Sep 24 2019

jasonmolenda added a comment to D67892: [LLDB] Fix typo in RegisterContextDarwin_arm64.

In either case, it's sad that there are no tests breaking due to this. Ideally we'd have a small arm64 macho core file with well known register values that we could just assert are read correctly. You probably don't have the means to create such a core file, so it's not fair to ask you to do that, but it would be great if one of the apple folks added a test like that.

Sep 24 2019, 6:34 PM · Restricted Project, Restricted Project
jasonmolenda accepted D67965: Have ABI plugins vend llvm MCRegisterInfo data.

LGTM.

Sep 24 2019, 2:00 PM · Restricted Project

Sep 12 2019

jasonmolenda committed rG0a39ef4704a5: The setUp/tearDown methods I added mssed up the test function; reorder. (authored by jasonmolenda).
The setUp/tearDown methods I added mssed up the test function; reorder.
Sep 12 2019, 5:05 PM
jasonmolenda added a comment to D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans.

Hi Aleksandr, nice job getting this working. I read over the patch and had a couple of initial questions.

Sep 12 2019, 5:00 PM · Restricted Project, Restricted Project
jasonmolenda accepted D66638: Unwind: Add a stack scanning mechanism to support win32 unwinding.

Sorry for taking so long to look at this one -- it looks like a good solution to this.

Sep 12 2019, 12:41 PM · Restricted Project, Restricted Project

Sep 10 2019

jasonmolenda committed rG9b27586e8347: Ah, only skip this for embedded darwin targets. (authored by jasonmolenda).
Ah, only skip this for embedded darwin targets.
Sep 10 2019, 6:04 PM
jasonmolenda committed rGf0321c094d95: Skip a test in TestProcessIO.py when running against ios devices. (authored by jasonmolenda).
Skip a test in TestProcessIO.py when running against ios devices.
Sep 10 2019, 6:04 PM

Sep 9 2019

jasonmolenda accepted D67369: Implement DW_OP_convert.

LGTM, nice job with the test case, I see myself copying that in the future. :)

Sep 9 2019, 3:27 PM · Restricted Project, Restricted Project

Sep 6 2019

jasonmolenda committed rG5b0a687d891e: Long timeouts for the MacOSX SystemRuntime plugins under ASAN; else quick. (authored by jasonmolenda).
Long timeouts for the MacOSX SystemRuntime plugins under ASAN; else quick.
Sep 6 2019, 6:43 PM

Sep 5 2019

jasonmolenda accepted D65469: Remove `bugreport` command.

We don't need to keep this command around. It was originated by Tamas in 2015,
https://reviews.llvm.org/D10868
but never got used for anything - Tamas was working on unwind things back then iirc, and may it looks like he thought it would be useful for that. On Darwin systems we do ship with a python command for diagnosing unwind problems ("script import lldb.diagnose"; "diagnose-unwind") which can be used when the current backtrace looks like it may be missing stack frames, or truncate early. The unwinder hasn't seen a lot of active development for years, so we don't have cause to use this very often.

Sep 5 2019, 2:14 PM · Restricted Project

Sep 3 2019

jasonmolenda accepted D67124: Upstream macCatalyst support in debugserver and the dynamic library loader plugin..

LGTM.

Sep 3 2019, 6:20 PM · Restricted Project

Aug 29 2019

jasonmolenda added a comment to D66934: [ARM64] Simplify RegisterInfos_arm64.h with macro based RegisterInfo array.

LGTM. In debugserver we have the definition for the V registers invaliding the D and S registers it contains. If the user modifies v10, we want any cached s10 and d10 values to be marked as invalid / refresh them. The same thing with the X and W registers. But the definitions you're rewriting already had this as incorrect, you've just replicated it more compactly, so I wouldn't call that a reason to hold off. Let's give Pavel a chance to look at this too.

Aug 29 2019, 6:41 PM · Restricted Project

Aug 27 2019

jasonmolenda committed rGdeeda85f3ffa: Update name of objc runtime SPI function we call for class names. (authored by jasonmolenda).
Update name of objc runtime SPI function we call for class names.
Aug 27 2019, 7:15 PM

Aug 26 2019

jasonmolenda committed rGfe64323fd5c8: Send error message on failed attach from debugerserver. (authored by jasonmolenda).
Send error message on failed attach from debugerserver.
Aug 26 2019, 5:10 PM

Aug 22 2019

jasonmolenda added inline comments to D66250: [JIT][Unwinder] Add Trampoline ObjectFile and UnwindPlan support for FCB.
Aug 22 2019, 11:00 PM · Restricted Project

Aug 21 2019

jasonmolenda committed rGca4409b4dc15: The g_format_infos table needs to be updated in concert with the enum Format… (authored by jasonmolenda).
The g_format_infos table needs to be updated in concert with the enum Format…
Aug 21 2019, 7:06 PM
jasonmolenda committed rGf79f594bd259: When building file without debug info, include the architecture setting in the… (authored by jasonmolenda).
When building file without debug info, include the architecture setting in the…
Aug 21 2019, 2:35 PM

Aug 20 2019

jasonmolenda committed rG1ecc507e2a5f: Update a few tests that may change the platform to save & restore the platform… (authored by jasonmolenda).
Update a few tests that may change the platform to save & restore the platform…
Aug 20 2019, 5:30 PM
jasonmolenda added a comment to D66250: [JIT][Unwinder] Add Trampoline ObjectFile and UnwindPlan support for FCB.

Why are we not just using ObjectFileJIT? I am guessing these breakpoint expressions create one of these by compiling the breakpoint expression and JIT'ing it just like any other expression. If this is the case, then why do we need to create a ObjectFileTrampoline? Seems like we could add .cfi directives to the assembly we use for the breakpoint condition function so that we can unwind out of it?

Aug 20 2019, 3:24 PM · Restricted Project

Aug 15 2019

jasonmolenda created D66331: Save / restore selected platform in tests that may change it.
Aug 15 2019, 7:44 PM · Restricted Project, Restricted Project
jasonmolenda added a comment to D66250: [JIT][Unwinder] Add Trampoline ObjectFile and UnwindPlan support for FCB.

I have one high-level question. Who is generating the code inside the "trampoline" object file? Couldn't we have him generate proper unwind information so that the regular unwind machinery "just works"? I imagine all it would take is a couple of well-placed .cfi assembler directives...

Aug 15 2019, 2:51 PM · Restricted Project

Aug 14 2019

jasonmolenda added a comment to D66250: [JIT][Unwinder] Add Trampoline ObjectFile and UnwindPlan support for FCB.

Overall this changeset looks good to me. A few small comments.

Aug 14 2019, 7:17 PM · Restricted Project

Aug 6 2019

jasonmolenda committed rG6cebeafac31c: Upstream a few small Apple changes to debugserver - arm64_32, Catalyst (authored by jasonmolenda).
Upstream a few small Apple changes to debugserver - arm64_32, Catalyst
Aug 6 2019, 7:08 PM

Aug 5 2019

jasonmolenda added a comment to D65784: [lldb] delete "--platform-path" option from "target create".

Yeah, it's not currently hooked up to anything; I'm returning to remote-platform testing soon, if we've lost some necessary functionality I can re-add it, but this option right now isn't doing anything.

Aug 5 2019, 6:31 PM · Restricted Project

Aug 1 2019

jasonmolenda accepted D64993: Fix PC adjustment in StackFrame::GetSymbolContext.

This looks good, this is in line with what we discussed, thanks for taking it on! Sorry for the delay at looking this over, it has been a little crazy this week.

Aug 1 2019, 3:04 PM · Restricted Project, Restricted Project
jasonmolenda added a comment to D65594: Fix `skipIfSanitized` decorator on macOS.

fwiw this behavior is documented here,

Aug 1 2019, 2:03 PM · Restricted Project, Restricted Project
jasonmolenda added a comment to D65492: Adjust a ValueObjectChild's offset when the child is a bitfield.

I'm sure this is fine, I read the code through and I've realized I haven't had to do anything with bitfields in lldb up to now.

Aug 1 2019, 2:02 PM · Restricted Project, Restricted Project

Jul 29 2019

jasonmolenda added a comment to D65311: [dotest] Remove multiprocessing.

I'm not sure it's really relevant when lit is the driver, but I would often use --no-multiprocess with dotest to see the full trace output of a single test while it was running. In multiprocess mode that wasn't displayed iirc. That's my only use of it. I do use --threads 1 when doing a testsuite run against a device because there's some buggy behavior in the lldb testsuite when running multiple tests simultaneously on a remote device (at least a remote darwin device). But I'm sure you're not talking about removing that control.

Jul 29 2019, 1:49 PM · Restricted Project, Restricted Project

Jul 24 2019

jasonmolenda accepted D65207: LLGS: fix tracking execve on linux.

LGTM. I don't think the use of the posix_spawn API are important for the test case to exercise. If posix_spawn had a problem on darwin systems, lldb/debugserver's process launching would turn it up pretty quick.

Jul 24 2019, 7:12 PM · Restricted Project

Jul 23 2019

jasonmolenda added a comment to D65171: [LLDB] Find debugserver in Command Line Tools as well.

LGTM. There was another problem I was discussing with someone the other week (I can't remember exactly the details) where we'd need to retrieve the Xcode install path so this would have been needed there too.

Jul 23 2019, 4:28 PM · Restricted Project, Restricted Project
jasonmolenda added a comment to D65109: [LLDB] Remove the Xcode project.

Seriously, discussion for changes like this should be open for more than 1h15min! I am in favor of the change in principle, but there's a number of things that have been rushed over here,

Jul 23 2019, 12:58 PM · Restricted Project, Restricted Project

Jul 22 2019

jasonmolenda accepted D65109: [LLDB] Remove the Xcode project.

LGTM. scripts/sort-pbxproj.rb can go too.

Jul 22 2019, 2:07 PM · Restricted Project, Restricted Project

Jul 18 2019

jasonmolenda committed rG956761adb0ff: Fall back to dyld's _dyld_start when no LC_MAIN / main() func can be found (authored by jasonmolenda).
Fall back to dyld's _dyld_start when no LC_MAIN / main() func can be found
Jul 18 2019, 1:57 PM

Jul 17 2019

jasonmolenda added a comment to D64897: Move start-address finding to Target, implement fallback if main executable does not have a start address.

Hm, that could be really helpful! I think I'd like to do that as a separate piece of work a little bit later, but I'll look at that.

Jul 17 2019, 6:14 PM · Restricted Project, Restricted Project
jasonmolenda created D64897: Move start-address finding to Target, implement fallback if main executable does not have a start address.
Jul 17 2019, 5:05 PM · Restricted Project, Restricted Project
jasonmolenda added a comment to D64853: Fix CommandInterpreter for _regex-break with options.

I know there are a lot of specific notes floating around right now, but two quick suggestions.

Jul 17 2019, 3:27 PM · Restricted Project
jasonmolenda committed rG1375659e0f02: Ah, forgot a debug line I left in the dsym-for-uuid.sh script to make sure it… (authored by jasonmolenda).
Ah, forgot a debug line I left in the dsym-for-uuid.sh script to make sure it…
Jul 17 2019, 2:57 PM
jasonmolenda committed rGbe4be6120f10: Add support to ProcessMachCore::DoLoadCore to handle an EFI UUID str. (authored by jasonmolenda).
Add support to ProcessMachCore::DoLoadCore to handle an EFI UUID str.
Jul 17 2019, 2:45 PM

Jul 16 2019

jasonmolenda accepted D63667: Support __kernel_rt_sigreturn in frame initialization.

Sorry yes, I should have marked this as approved. I don't have a linux machine handy so I haven't looked into the problem Jan reports with the change -- fwiw if you turn on unwind logging ('log enable lldb unwind' before you backtrace at a stop), it will tell you which unwind rule it is using to find the caller's return pc value as it goes up the stack. It's a little tricky to read at first, but once you get the hang of it you can usually spot the problem quickly and understand why lldb is behaving the way it is. But just looking at the source changes you're making, I'm fine with this.

Jul 16 2019, 2:20 PM · Restricted Project, Restricted Project

Jul 15 2019

jasonmolenda committed rGc245249b7bd0: Update some file changes, but there's a dependency loop so it doesn't quite… (authored by jasonmolenda).
Update some file changes, but there's a dependency loop so it doesn't quite…
Jul 15 2019, 5:00 PM
jasonmolenda added a comment to D63667: Support __kernel_rt_sigreturn in frame initialization.

Ah, regarding the S bit, looks good to me. I think I misunderstood the original problem you were working on. On Darwin systems, we have our friend sigtramp. When an async interrupt is received, the kernel saves the register context to stack and then calls sigtramp which does some instructions and then calls the trap handler function. Backing up the pc by 1 for __sigtramp is fine, because it did a normal CALL instruction to the trap handler.

Jul 15 2019, 3:06 PM · Restricted Project, Restricted Project