Page MenuHomePhabricator

jasonmolenda (Jason Molenda)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 2 2014, 12:05 PM (263 w, 18 h)

Recent Activity

Thu, Sep 12

jasonmolenda committed rG0a39ef4704a5: The setUp/tearDown methods I added mssed up the test function; reorder. (authored by jasonmolenda).
The setUp/tearDown methods I added mssed up the test function; reorder.
Thu, Sep 12, 5:05 PM
jasonmolenda added a comment to D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans.

Hi Aleksandr, nice job getting this working. I read over the patch and had a couple of initial questions.

Thu, Sep 12, 5:00 PM · Restricted Project, Restricted Project
jasonmolenda accepted D66638: Unwind: Add a stack scanning mechanism to support win32 unwinding.

Sorry for taking so long to look at this one -- it looks like a good solution to this.

Thu, Sep 12, 12:41 PM · Restricted Project

Tue, Sep 10

jasonmolenda committed rG9b27586e8347: Ah, only skip this for embedded darwin targets. (authored by jasonmolenda).
Ah, only skip this for embedded darwin targets.
Tue, Sep 10, 6:04 PM
jasonmolenda committed rGf0321c094d95: Skip a test in TestProcessIO.py when running against ios devices. (authored by jasonmolenda).
Skip a test in TestProcessIO.py when running against ios devices.
Tue, Sep 10, 6:04 PM

Mon, Sep 9

jasonmolenda accepted D67369: Implement DW_OP_convert.

LGTM, nice job with the test case, I see myself copying that in the future. :)

Mon, Sep 9, 3:27 PM · Restricted Project, Restricted Project

Fri, Sep 6

jasonmolenda committed rG5b0a687d891e: Long timeouts for the MacOSX SystemRuntime plugins under ASAN; else quick. (authored by jasonmolenda).
Long timeouts for the MacOSX SystemRuntime plugins under ASAN; else quick.
Fri, Sep 6, 6:43 PM

Thu, Sep 5

jasonmolenda accepted D65469: Remove `bugreport` command.

We don't need to keep this command around. It was originated by Tamas in 2015,
https://reviews.llvm.org/D10868
but never got used for anything - Tamas was working on unwind things back then iirc, and may it looks like he thought it would be useful for that. On Darwin systems we do ship with a python command for diagnosing unwind problems ("script import lldb.diagnose"; "diagnose-unwind") which can be used when the current backtrace looks like it may be missing stack frames, or truncate early. The unwinder hasn't seen a lot of active development for years, so we don't have cause to use this very often.

Thu, Sep 5, 2:14 PM · Restricted Project

Tue, Sep 3

jasonmolenda accepted D67124: Upstream macCatalyst support in debugserver and the dynamic library loader plugin..

LGTM.

Tue, Sep 3, 6:20 PM · Restricted Project

Thu, Aug 29

jasonmolenda added a comment to D66934: [ARM64] Simplify RegisterInfos_arm64.h with macro based RegisterInfo array.

LGTM. In debugserver we have the definition for the V registers invaliding the D and S registers it contains. If the user modifies v10, we want any cached s10 and d10 values to be marked as invalid / refresh them. The same thing with the X and W registers. But the definitions you're rewriting already had this as incorrect, you've just replicated it more compactly, so I wouldn't call that a reason to hold off. Let's give Pavel a chance to look at this too.

Thu, Aug 29, 6:41 PM · Restricted Project

Tue, Aug 27

jasonmolenda committed rGdeeda85f3ffa: Update name of objc runtime SPI function we call for class names. (authored by jasonmolenda).
Update name of objc runtime SPI function we call for class names.
Tue, Aug 27, 7:15 PM

Mon, Aug 26

jasonmolenda committed rGfe64323fd5c8: Send error message on failed attach from debugerserver. (authored by jasonmolenda).
Send error message on failed attach from debugerserver.
Mon, Aug 26, 5:10 PM

Thu, Aug 22

jasonmolenda added inline comments to D66250: [JIT][Unwinder] Add Trampoline ObjectFile and UnwindPlan support for FCB.
Thu, Aug 22, 11:00 PM · Restricted Project

Wed, Aug 21

jasonmolenda committed rGca4409b4dc15: The g_format_infos table needs to be updated in concert with the enum Format… (authored by jasonmolenda).
The g_format_infos table needs to be updated in concert with the enum Format…
Wed, Aug 21, 7:06 PM
jasonmolenda committed rGf79f594bd259: When building file without debug info, include the architecture setting in the… (authored by jasonmolenda).
When building file without debug info, include the architecture setting in the…
Wed, Aug 21, 2:35 PM

Tue, Aug 20

jasonmolenda committed rG1ecc507e2a5f: Update a few tests that may change the platform to save & restore the platform… (authored by jasonmolenda).
Update a few tests that may change the platform to save & restore the platform…
Tue, Aug 20, 5:30 PM
jasonmolenda added a comment to D66250: [JIT][Unwinder] Add Trampoline ObjectFile and UnwindPlan support for FCB.

Why are we not just using ObjectFileJIT? I am guessing these breakpoint expressions create one of these by compiling the breakpoint expression and JIT'ing it just like any other expression. If this is the case, then why do we need to create a ObjectFileTrampoline? Seems like we could add .cfi directives to the assembly we use for the breakpoint condition function so that we can unwind out of it?

Tue, Aug 20, 3:24 PM · Restricted Project

Aug 15 2019

jasonmolenda created D66331: Save / restore selected platform in tests that may change it.
Aug 15 2019, 7:44 PM · Restricted Project, Restricted Project
jasonmolenda added a comment to D66250: [JIT][Unwinder] Add Trampoline ObjectFile and UnwindPlan support for FCB.

I have one high-level question. Who is generating the code inside the "trampoline" object file? Couldn't we have him generate proper unwind information so that the regular unwind machinery "just works"? I imagine all it would take is a couple of well-placed .cfi assembler directives...

Aug 15 2019, 2:51 PM · Restricted Project

Aug 14 2019

jasonmolenda added a comment to D66250: [JIT][Unwinder] Add Trampoline ObjectFile and UnwindPlan support for FCB.

Overall this changeset looks good to me. A few small comments.

Aug 14 2019, 7:17 PM · Restricted Project

Aug 6 2019

jasonmolenda committed rG6cebeafac31c: Upstream a few small Apple changes to debugserver - arm64_32, Catalyst (authored by jasonmolenda).
Upstream a few small Apple changes to debugserver - arm64_32, Catalyst
Aug 6 2019, 7:08 PM

Aug 5 2019

jasonmolenda added a comment to D65784: [lldb] delete "--platform-path" option from "target create".

Yeah, it's not currently hooked up to anything; I'm returning to remote-platform testing soon, if we've lost some necessary functionality I can re-add it, but this option right now isn't doing anything.

Aug 5 2019, 6:31 PM · Restricted Project

Aug 1 2019

jasonmolenda accepted D64993: Fix PC adjustment in StackFrame::GetSymbolContext.

This looks good, this is in line with what we discussed, thanks for taking it on! Sorry for the delay at looking this over, it has been a little crazy this week.

Aug 1 2019, 3:04 PM · Restricted Project, Restricted Project
jasonmolenda added a comment to D65594: Fix `skipIfSanitized` decorator on macOS.

fwiw this behavior is documented here,

Aug 1 2019, 2:03 PM · Restricted Project, Restricted Project
jasonmolenda added a comment to D65492: Adjust a ValueObjectChild's offset when the child is a bitfield.

I'm sure this is fine, I read the code through and I've realized I haven't had to do anything with bitfields in lldb up to now.

Aug 1 2019, 2:02 PM · Restricted Project, Restricted Project

Jul 29 2019

jasonmolenda added a comment to D65311: [dotest] Remove multiprocessing.

I'm not sure it's really relevant when lit is the driver, but I would often use --no-multiprocess with dotest to see the full trace output of a single test while it was running. In multiprocess mode that wasn't displayed iirc. That's my only use of it. I do use --threads 1 when doing a testsuite run against a device because there's some buggy behavior in the lldb testsuite when running multiple tests simultaneously on a remote device (at least a remote darwin device). But I'm sure you're not talking about removing that control.

Jul 29 2019, 1:49 PM · Restricted Project, Restricted Project

Jul 24 2019

jasonmolenda accepted D65207: LLGS: fix tracking execve on linux.

LGTM. I don't think the use of the posix_spawn API are important for the test case to exercise. If posix_spawn had a problem on darwin systems, lldb/debugserver's process launching would turn it up pretty quick.

Jul 24 2019, 7:12 PM · Restricted Project

Jul 23 2019

jasonmolenda added a comment to D65171: [LLDB] Find debugserver in Command Line Tools as well.

LGTM. There was another problem I was discussing with someone the other week (I can't remember exactly the details) where we'd need to retrieve the Xcode install path so this would have been needed there too.

Jul 23 2019, 4:28 PM · Restricted Project, Restricted Project
jasonmolenda added a comment to D65109: [LLDB] Remove the Xcode project.

Seriously, discussion for changes like this should be open for more than 1h15min! I am in favor of the change in principle, but there's a number of things that have been rushed over here,

Jul 23 2019, 12:58 PM · Restricted Project, Restricted Project

Jul 22 2019

jasonmolenda accepted D65109: [LLDB] Remove the Xcode project.

LGTM. scripts/sort-pbxproj.rb can go too.

Jul 22 2019, 2:07 PM · Restricted Project, Restricted Project

Jul 18 2019

jasonmolenda committed rG956761adb0ff: Fall back to dyld's _dyld_start when no LC_MAIN / main() func can be found (authored by jasonmolenda).
Fall back to dyld's _dyld_start when no LC_MAIN / main() func can be found
Jul 18 2019, 1:57 PM

Jul 17 2019

jasonmolenda added a comment to D64897: Move start-address finding to Target, implement fallback if main executable does not have a start address.

Hm, that could be really helpful! I think I'd like to do that as a separate piece of work a little bit later, but I'll look at that.

Jul 17 2019, 6:14 PM · Restricted Project, Restricted Project
jasonmolenda created D64897: Move start-address finding to Target, implement fallback if main executable does not have a start address.
Jul 17 2019, 5:05 PM · Restricted Project, Restricted Project
jasonmolenda added a comment to D64853: Fix CommandInterpreter for _regex-break with options.

I know there are a lot of specific notes floating around right now, but two quick suggestions.

Jul 17 2019, 3:27 PM · Restricted Project
jasonmolenda committed rG1375659e0f02: Ah, forgot a debug line I left in the dsym-for-uuid.sh script to make sure it… (authored by jasonmolenda).
Ah, forgot a debug line I left in the dsym-for-uuid.sh script to make sure it…
Jul 17 2019, 2:57 PM
jasonmolenda committed rGbe4be6120f10: Add support to ProcessMachCore::DoLoadCore to handle an EFI UUID str. (authored by jasonmolenda).
Add support to ProcessMachCore::DoLoadCore to handle an EFI UUID str.
Jul 17 2019, 2:45 PM

Jul 16 2019

jasonmolenda accepted D63667: Support __kernel_rt_sigreturn in frame initialization.

Sorry yes, I should have marked this as approved. I don't have a linux machine handy so I haven't looked into the problem Jan reports with the change -- fwiw if you turn on unwind logging ('log enable lldb unwind' before you backtrace at a stop), it will tell you which unwind rule it is using to find the caller's return pc value as it goes up the stack. It's a little tricky to read at first, but once you get the hang of it you can usually spot the problem quickly and understand why lldb is behaving the way it is. But just looking at the source changes you're making, I'm fine with this.

Jul 16 2019, 2:20 PM · Restricted Project, Restricted Project

Jul 15 2019

jasonmolenda committed rGc245249b7bd0: Update some file changes, but there's a dependency loop so it doesn't quite… (authored by jasonmolenda).
Update some file changes, but there's a dependency loop so it doesn't quite…
Jul 15 2019, 5:00 PM
jasonmolenda added a comment to D63667: Support __kernel_rt_sigreturn in frame initialization.

Ah, regarding the S bit, looks good to me. I think I misunderstood the original problem you were working on. On Darwin systems, we have our friend sigtramp. When an async interrupt is received, the kernel saves the register context to stack and then calls sigtramp which does some instructions and then calls the trap handler function. Backing up the pc by 1 for __sigtramp is fine, because it did a normal CALL instruction to the trap handler.

Jul 15 2019, 3:06 PM · Restricted Project, Restricted Project
jasonmolenda added a comment to D63667: Support __kernel_rt_sigreturn in frame initialization.

I've updated this with code to recognize the 'S' in the eh_frame augmentation and record it in a new bool member of UnwindPlan, m_plan_is_for_signal_trap. I haven't hooked up any consumers of the new bit; as you say, with the current code flow we don't parse the eh_frame info until after we've decided whether the current frame is a trap handler frame or not.

I took a look at behaves_like_zeroth_frame. In my case, we're not getting to the point of consulting it, because before checking it, if we are processing a trap handler frame or if AlwaysRelyOnEHInfo returns true (both of which are true in my case), we use the EH Frame unwind plan if it is valid at the current address, and that valid at current address check is already passing. I'm somewhat reluctant to fiddle with the behaves_like_zeroth_frame bit speculatively. Note that with this change, it will get set for the next frame above __kernel_rt_sigreturn (because the current test checks if the next-lower frame is an eTrapHandler frame), which I think is where we want the async processing.

Jul 15 2019, 3:01 PM · Restricted Project, Restricted Project

Jul 8 2019

jasonmolenda accepted D64362: Remove lldb-perf.

Thanks Jonas, yes we need to come up with a perf testing infrastructure in lldb but there isn't a lot of value in this original attempt from c. 2013.

Jul 8 2019, 2:21 PM · Restricted Project, Restricted Project

Jul 2 2019

jasonmolenda committed rG37aeca39ba2d: Update cmake build setup so lldb doesn't link against the DebugSymbols… (authored by jasonmolenda).
Update cmake build setup so lldb doesn't link against the DebugSymbols…
Jul 2 2019, 4:41 PM
jasonmolenda committed rGaab389170202: add symbols/declvendor.cpp. (authored by jasonmolenda).
add symbols/declvendor.cpp.
Jul 2 2019, 4:08 PM

Jun 26 2019

jasonmolenda committed rG1659276beec2: Support nested target.xml register definition files, lack of reg group markers. (authored by jasonmolenda).
Support nested target.xml register definition files, lack of reg group markers.
Jun 26 2019, 3:02 PM
jasonmolenda committed rGddf025e8dc46: Use the // integer divide operator in these target definition files, like… (authored by jasonmolenda).
Use the // integer divide operator in these target definition files, like…
Jun 26 2019, 2:43 PM

Jun 25 2019

jasonmolenda created D63802: Handle nested register definition xml files from the remote serial protocol stub.
Jun 25 2019, 7:21 PM · Restricted Project, Restricted Project

Jun 24 2019

jasonmolenda committed rG868a394bb60d: Don't link against the DebugSymbols private framework; try to dlopen + dlsym… (authored by jasonmolenda).
Don't link against the DebugSymbols private framework; try to dlopen + dlsym…
Jun 24 2019, 3:10 PM
jasonmolenda committed rGb5e86e0b5108: Add windows abi plugin, breakpointprecondition. (authored by jasonmolenda).
Add windows abi plugin, breakpointprecondition.
Jun 24 2019, 2:50 PM

Jun 21 2019

jasonmolenda added a comment to D63667: Support __kernel_rt_sigreturn in frame initialization.

This looks good. Over in RegisterContextLLDB::GetFullUnwindPlanForFrame there's a behaves_like_zeroth_frame bool with similar setup -- in that case, it's trying to decide what type of UnwindPlan to pick for the frame, either one that is synchronous ("valid only at call sites / throwable locations") or asynchronous ("valid at every instruction"). For a behaves_like_zeroth_frame it needs to pick an asynchronous unwind plan. You may want to look at that too.

Jun 21 2019, 2:32 PM · Restricted Project, Restricted Project

Jun 13 2019

jasonmolenda accepted D63310: Make crashlog.py less noisy.

Nice.

Jun 13 2019, 5:38 PM · Restricted Project, Restricted Project

Jun 12 2019

jasonmolenda committed rG0e197bcb6b82: Re-land r363103 ("When reading ObjC class table, use new SPI if it is avail")… (authored by jasonmolenda).
Re-land r363103 ("When reading ObjC class table, use new SPI if it is avail")…
Jun 12 2019, 2:44 PM

Jun 11 2019

jasonmolenda committed rGdd4bed3d7a85: Back out r363103 ("When reading ObjC class table, use new SPI if it is avail")… (authored by jasonmolenda).
Back out r363103 ("When reading ObjC class table, use new SPI if it is avail")…
Jun 11 2019, 5:59 PM
jasonmolenda committed rG1a7362f33e1f: When reading ObjC class table, use new SPI if it is avail (authored by jasonmolenda).
When reading ObjC class table, use new SPI if it is avail
Jun 11 2019, 2:29 PM
jasonmolenda committed rGeb2e0c3844d3: Update AuxVector.cpp (authored by jasonmolenda).
Update AuxVector.cpp
Jun 11 2019, 2:18 PM

Jun 4 2019

jasonmolenda committed rGc93b99589f7e: Call abs to avoid signed/unsigned comparison warning. (authored by jasonmolenda).
Call abs to avoid signed/unsigned comparison warning.
Jun 4 2019, 3:46 PM

Jun 3 2019

jasonmolenda added inline comments to D62732: [WIP][RISCV] Initial port of LLDB for RISC-V.
Jun 3 2019, 4:30 PM · Restricted Project
jasonmolenda committed rGc3ea7c66fec0: Add support for mid-function epilogues on x86 that end in a non-local jump. (authored by jasonmolenda).
Add support for mid-function epilogues on x86 that end in a non-local jump.
Jun 3 2019, 3:34 PM

May 31 2019

jasonmolenda created D62764: Detect x86 mid-function epilogues that end in a jump.
May 31 2019, 7:05 PM · Restricted Project, Restricted Project

May 22 2019

jasonmolenda added a comment to D62221: [lldb-server][LLGS] Support 'g' packets.

Does your feature print *all* the registers including floating point/vector registers? Or just the main general purpose registers? In debugserver, we expedite the register values for the stopping thread:

May 22 2019, 5:59 PM · Restricted Project, Restricted Project

May 21 2019

jasonmolenda added inline comments to D62213: [ABI] Implement Windows ABI for x86_64.
May 21 2019, 7:33 PM · Restricted Project, Restricted Project
jasonmolenda added inline comments to D62221: [lldb-server][LLGS] Support 'g' packets.
May 21 2019, 3:19 PM · Restricted Project, Restricted Project

May 16 2019

jasonmolenda accepted D62015: Make sure GetObjectDescription falls back to the Objective-C runtime..
May 16 2019, 11:06 AM · Restricted Project
jasonmolenda added a comment to D62015: Make sure GetObjectDescription falls back to the Objective-C runtime..

My one concern is how this will work in a swift-lldb where we have a swift ValueObject, the print description fails, and we fall back to the ObjC print description. That's a change in behavior, right? I imagine worst case is that the objc print description will fail to produce anything and we'll have the same behavior as we do today.

May 16 2019, 10:14 AM · Restricted Project

May 10 2019

jasonmolenda committed rGabcb1215c964: Change the disabling of packet logging to be in TearDownHook lambdas. (authored by jasonmolenda).
Change the disabling of packet logging to be in TearDownHook lambdas.
May 10 2019, 4:24 PM
jasonmolenda committed rG18ba8947a6c2: Ted pointed out that some of test tests that are enabling packet logging when… (authored by jasonmolenda).
Ted pointed out that some of test tests that are enabling packet logging when…
May 10 2019, 4:04 PM

May 9 2019

jasonmolenda accepted D61732: FuncUnwinders: Add a new "SymbolFile" unwind plan.

Looks good to me.

May 9 2019, 5:48 PM · Restricted Project
jasonmolenda accepted D61733: Breakpad: Generate unwind plans from STACK CFI records.
May 9 2019, 5:34 PM · Restricted Project

May 2 2019

jasonmolenda committed rGc9f44cd4b6e5: RegisterContextLLDB::GetFullUnwindPlanForFrame has four verbose logging… (authored by jasonmolenda).
RegisterContextLLDB::GetFullUnwindPlanForFrame has four verbose logging…
May 2 2019, 4:51 PM
jasonmolenda committed rG3af3900ee7f9: Upstreaming an apple local patch by Frederic Riss. (authored by jasonmolenda).
Upstreaming an apple local patch by Frederic Riss.
May 2 2019, 4:17 PM
jasonmolenda abandoned D60957: Read ObjC class names in one large read, instead of reading them individually.

I had some more revisions on this patch, but I finally understood that I was solving the wrong problem with this patchset. lldb should not fetch class names up front when scanning the objective c class tables, they should only be read lazily as we evaluate an expression. The fact that we're reading names during the table scan is the problem that needs to be fixed.

May 2 2019, 3:18 PM · Restricted Project

Apr 26 2019

jasonmolenda accepted D61218: Fix a stack-smasher in PlatformMacOSX::GetSDKDirectory().

LGTM.

Apr 26 2019, 5:29 PM · Restricted Project, Restricted Project

Apr 25 2019

jasonmolenda updated the diff for D60957: Read ObjC class names in one large read, instead of reading them individually.

Fix one small bug in the jitted expressions. Increase the estimated size of class names that lldb uses to pre-allocate the string pool buffer. Added a method to read the string pool out of the inferior, to reduce code duplication, and have it read the last name to get the full size of the string pool correct.

Apr 25 2019, 6:42 PM · Restricted Project
jasonmolenda committed rG1cb2c21fb4bd: Another use of the interactive lldb.debugger. (authored by jasonmolenda).
Another use of the interactive lldb.debugger.
Apr 25 2019, 1:46 PM
jasonmolenda committed rG3775794812e5: Two tests were using the interactive convenience variable lldb.debugger. They… (authored by jasonmolenda).
Two tests were using the interactive convenience variable lldb.debugger. They…
Apr 25 2019, 1:03 PM

Apr 24 2019

jasonmolenda committed rGd129ee34a51e: add postfixexpression.cpp. (authored by jasonmolenda).
add postfixexpression.cpp.
Apr 24 2019, 12:49 PM

Apr 22 2019

jasonmolenda committed rG759805fd8a6c: One small tweak to LocateExecutableScriptingResources - I was still stat'ing… (authored by jasonmolenda).
One small tweak to LocateExecutableScriptingResources - I was still stat'ing…
Apr 22 2019, 6:12 PM
jasonmolenda committed rG9270a201b9d1: Add a small check to PlatformDarwin::LoadScriptingResourceForModule which reads… (authored by jasonmolenda).
Add a small check to PlatformDarwin::LoadScriptingResourceForModule which reads…
Apr 22 2019, 6:04 PM
jasonmolenda committed rGa38b8c8abce0: Fix a bug in my change to ModulesDidLoad in r357955. In the process of hoisting… (authored by jasonmolenda).
Fix a bug in my change to ModulesDidLoad in r357955. In the process of hoisting…
Apr 22 2019, 3:42 PM
jasonmolenda accepted D60829: FuncUnwinders: remove "current_offset" from function arguments.

Sorry for the delay in looking at this. It looks like a good change, an improvement on the original for sure. I've never seen multiple eh_frame FDEs for a single function, so that's fine. The .ARM.exidx format and Apple's compact unwind format can theoretically have multiple different unwind plans for a single function - but I've never seen it done in practice. More commonly, a single unwind plan will be used for multiple functions that have the same unwind state. (these two formats don't describe prologue/epilogues - they only describe the unwind state in the middle of the function where exceptions can be thrown)

Apr 22 2019, 3:08 PM · Restricted Project

Apr 21 2019

jasonmolenda updated the summary of D60957: Read ObjC class names in one large read, instead of reading them individually.
Apr 21 2019, 11:20 PM · Restricted Project
jasonmolenda updated the summary of D60957: Read ObjC class names in one large read, instead of reading them individually.
Apr 21 2019, 11:20 PM · Restricted Project
jasonmolenda created D60957: Read ObjC class names in one large read, instead of reading them individually.
Apr 21 2019, 11:19 PM · Restricted Project
jasonmolenda accepted D60949: UnwindPlan: pretty-print dwarf expressions.

very nice.

Apr 21 2019, 9:44 PM · Restricted Project

Apr 17 2019

jasonmolenda added a comment to D60829: FuncUnwinders: remove "current_offset" from function arguments.

Thanks for digging in to this Pavel. I haven't had time to look over the patch today, but I'd like to; I'll make time for it in the next couple days if that's OK.

Apr 17 2019, 9:45 PM · Restricted Project

Apr 15 2019

jasonmolenda accepted D60655: Fix typo in ArmUnwindInfo::GetUnwindPlan.

Agreed, this change is correct. I double checked this in the http://infocenter.arm.com/help/topic/com.arm.doc.ihi0038b/IHI0038B_ehabi.pdf doc (mod 24 Nov 2015) and the only difference in Section 9.3 "Frame unwinding instructions" Table 4 and this code is in the comment - they now refer to this as 'Pop VFP double-precision registers D[8]-D[8+nnn] saved (as if) by VPUSH (see remark d)'. But there's no benefit in updating this one comment while the others are using the older comments (this code was originally written against the 30 Nov 2012 version of the doc).

Apr 15 2019, 2:36 PM · Restricted Project, Restricted Project

Apr 8 2019

jasonmolenda committed rG1724a179e7ae: Rename Target::GetSharedModule to Target::GetOrCreateModule. (authored by jasonmolenda).
Rename Target::GetSharedModule to Target::GetOrCreateModule.
Apr 8 2019, 4:02 PM

Apr 5 2019

jasonmolenda updated the diff for D60172: Renamed Target::GetSharedModule to AddModule, allow for ModulesDidLoad to be delayed when batch adding Modules.

Added a testcase, TestModuleLoadedNotifys.

Apr 5 2019, 8:39 PM · Restricted Project

Apr 4 2019

jasonmolenda added a comment to D60172: Renamed Target::GetSharedModule to AddModule, allow for ModulesDidLoad to be delayed when batch adding Modules.

Thanks Pavel, I'll convert this to use Expected<> while I'm working on it. I'm writing a test case right now, and looking at how DynamicPluginDarwin works more closely for adding & removing binaries, e.g. there's also no way to batch remove libraries and have a group broadcast notification be sent. There was also a bug in my original patch for calling LoadScriptingResourceForModule() to find a python resource file in a dSYM bundle - it is currently called from Target::ModuleUpdated when a binary is added to the target's ModuleList, but I'm suppressing that call with this change, so I need to move that over to ModulesDidLoad.

Apr 4 2019, 6:34 PM · Restricted Project

Apr 3 2019

jasonmolenda updated the diff for D60172: Renamed Target::GetSharedModule to AddModule, allow for ModulesDidLoad to be delayed when batch adding Modules.

Remove const bool notify's. Rename method to Target::GetOrCreateModule. Refine the method headerdoc a bit.

Apr 3 2019, 3:32 PM · Restricted Project
jasonmolenda added a comment to D60172: Renamed Target::GetSharedModule to AddModule, allow for ModulesDidLoad to be delayed when batch adding Modules.

OK looked things over a bit.

Apr 3 2019, 2:36 PM · Restricted Project

Apr 2 2019

jasonmolenda added a comment to D60172: Renamed Target::GetSharedModule to AddModule, allow for ModulesDidLoad to be delayed when batch adding Modules.

Thanks for looking the patch over.

Apr 2 2019, 9:20 PM · Restricted Project
jasonmolenda created D60172: Renamed Target::GetSharedModule to AddModule, allow for ModulesDidLoad to be delayed when batch adding Modules.
Apr 2 2019, 7:51 PM · Restricted Project
jasonmolenda committed rGaa107ca3a55f: Avoid macro redefinition error if HAVE_LIBCOMPRESSION is already defined. (authored by jasonmolenda).
Avoid macro redefinition error if HAVE_LIBCOMPRESSION is already defined.
Apr 2 2019, 6:16 PM

Apr 1 2019

jasonmolenda added inline comments to D60022: [Process] Fix WriteMemory return value.
Apr 1 2019, 11:26 AM · Restricted Project, Restricted Project

Mar 27 2019

jasonmolenda accepted D59896: [ObjectFileMachO] Disable memory caching for savecore..

Looks good. Removing that printf is good. Could you also remove the printf("mach_header:...") in the same function?

Mar 27 2019, 4:08 PM · Restricted Project, Restricted Project

Mar 26 2019

jasonmolenda added a comment to D55718: [ARC] Basic support in gdb-remote process plugin.

As long as the numbers _can_ still come from the GDB server, I am all for that. If they are not supplied, then we use arch defaults. That allows new system/arch bringups where the info might be changing often, and also allows the info to be locked down. The architecture plug-ins are a great place for this. We should also move the breakpoint opcode logic into the architecture plug-ins.

Mar 26 2019, 12:59 PM · Restricted Project
jasonmolenda added a comment to D55718: [ARC] Basic support in gdb-remote process plugin.

It would be really nice to get the GDB remote server for ARC so that it vends the correct regs to begin with, but if that isn't possible I guess we need to do what we are doing here. I would really like to not see more architectures have to add code to ProcessGDBRemote.cpp at all. If that isn't possible this solution will need to be used.

Mar 26 2019, 12:14 PM · Restricted Project
jasonmolenda accepted D59495: Fix an out-of-bounds error in RegisterContextDarwin_arm64.

Sorry for not weighing in earlier, yes this is good.

Mar 26 2019, 12:02 PM · Restricted Project

Mar 20 2019

jasonmolenda committed rG9d760a0a76e6: Change the logging on ptrace(PT_KILL) in MachProcess::Kill to log if… (authored by jasonmolenda).
Change the logging on ptrace(PT_KILL) in MachProcess::Kill to log if…
Mar 20 2019, 4:01 PM
jasonmolenda committed rGdb5edebea266: Update DWARF files. (authored by jasonmolenda).
Update DWARF files.
Mar 20 2019, 4:00 PM