Page MenuHomePhabricator

jasonmolenda (Jason Molenda)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 2 2014, 12:05 PM (346 w, 4 h)

Recent Activity

Today

jasonmolenda committed rGf2da1f68d815: Get Section from resolved_addr in Target::ReadMemory (authored by jasonmolenda).
Get Section from resolved_addr in Target::ReadMemory
Tue, Apr 20, 12:09 PM
jasonmolenda closed D100850: Fix reading from file cache using address instead of resolved address for getting a section.
Tue, Apr 20, 12:09 PM · Restricted Project
jasonmolenda accepted D100850: Fix reading from file cache using address instead of resolved address for getting a section.

Ach, I should have noticed that during review.

Tue, Apr 20, 12:07 PM · Restricted Project

Fri, Apr 16

jasonmolenda committed rGe9fe788d3260: Target::ReadMemory read from read-only binary file Section, not memory (authored by jasonmolenda).
Target::ReadMemory read from read-only binary file Section, not memory
Fri, Apr 16, 4:13 PM
jasonmolenda closed D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only.
Fri, Apr 16, 4:13 PM · Restricted Project
jasonmolenda added a comment to D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process.

Out of curiosity: Typically should one be able to set target.process.virtual-addressable-bits after the target has been created? Or is it expected that users will need to run in the following order only:

settings set target.process.virtual-addressable-bits ...
target create -c ....

Setting virtual-addressable-bits won't do anythin after the target has been created (and perhaps that is working as intended?)

Yep, that was exactly why I'm always reading the setting if the mask isn't set yet (as opposed to setting it once in the constructor).

Fri, Apr 16, 3:03 PM · Restricted Project
jasonmolenda accepted D100520: [lldb] Set code and data address mask from qHostInfo.

Looks good!

Fri, Apr 16, 1:19 PM · Restricted Project
jasonmolenda accepted D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only.

This looks good, thanks for doing this!

Fri, Apr 16, 10:50 AM · Restricted Project
jasonmolenda added inline comments to D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process.
Fri, Apr 16, 12:51 AM · Restricted Project

Thu, Apr 15

jasonmolenda accepted D100521: [lldb] Fix up code addresses in RegisterContextUnwind.

This looks good. Jonas, what do you think about having FixDataAddress() methods in the ABI's. We're going to be quickly sprinkling FixCodeAddress calls throughout lldb at places where Linux/Darwin ABI need them, and it'd be nice if we have the FixDataAddress method available (even if they're identical right now) so someone doesn't need to audit all the calls in the future and adjust them as appropriate.

Thu, Apr 15, 10:11 PM · Restricted Project
jasonmolenda accepted D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process.

I think we've heard from everyone involved with this & it's good to land. Thanks for bringing this home.

Thu, Apr 15, 10:06 PM · Restricted Project
jasonmolenda committed rG9d4415d01d23: Don't refer to allocation map entry after deallocating it (authored by jasonmolenda).
Don't refer to allocation map entry after deallocating it
Thu, Apr 15, 8:17 PM
jasonmolenda added inline comments to D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process.
Thu, Apr 15, 12:30 PM · Restricted Project
jasonmolenda added a comment to D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process.
Thu, Apr 15, 11:05 AM · Restricted Project
jasonmolenda committed rG71a45e7c6328: NFC put the armv6m entry with the other Cortex-M entries (authored by jasonmolenda).
NFC put the armv6m entry with the other Cortex-M entries
Thu, Apr 15, 2:02 AM
jasonmolenda committed rG01ad95ff2a7c: Mark armv6m compat with armv7em; match armv7em being compat with armv6m (authored by jasonmolenda).
Mark armv6m compat with armv7em; match armv7em being compat with armv6m
Thu, Apr 15, 1:31 AM

Wed, Apr 14

jasonmolenda added a comment to D100500: Add setting to artifically delay communication with the debug server, in order ro simulate slow network conditions.

Hi Augusto, this is an interesting idea. This would simulate a slow serial connection well, but over a modern USB or Wifi or Bluetooth connection, we find the packet size is nearly irrelevant to performance -- but the number of packets is absolutely critical. If we need to read 100 kbytes, sending ten 10kb read packets is *much* slower than a single 100kb packet. For fun, I built a native debugserver that claims it supported a maximum 1k packet size, and then rebuilt it claiming it supports a maximum 512k packet size. It turns out lldb won't actually use more than a 128kbyte packet size (v. ProcessGDBRemote::GetMaxMemorySize) but anyway,

Wed, Apr 14, 8:12 PM · Restricted Project
jasonmolenda added a comment to D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process.

Thanks Jonas, I think this change to Process can cover

Wed, Apr 14, 6:00 PM · Restricted Project
jasonmolenda added a comment to D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only.

@jasonmolenda I've updated all the function calls to prefer the file cache (except the one you pointed out), but I'm a little worried about this, since I changed a lot of function calls. Maybe I could update the function signature to force_live_memory (and default it to false), but keep all the current calls having the same behavior (by negating whatever was passed previously as prefer_file_cache). What do you think?

Wed, Apr 14, 3:22 PM · Restricted Project

Tue, Apr 13

jasonmolenda added a comment to D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only.

Thanks for the input @jasonmolenda. FWIW I also think it's worth implementing this correctly.

Could you help me figure out which callers I should change to force_live_memory though?

Tue, Apr 13, 11:23 AM · Restricted Project
jasonmolenda added a comment to D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only.

I should say, my suggestion of changing Target::ReadMemory is just an opinion, please do feel free to disagree!

Tue, Apr 13, 11:13 AM · Restricted Project

Mon, Apr 12

jasonmolenda updated subscribers of D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only.

Trying to reword my thinking a little more clearly.

Mon, Apr 12, 10:50 PM · Restricted Project
jasonmolenda added a comment to D99944: [LLDB] AArch64 PAC elf-core stack unwinder support.

I think this will come down to, who wants to implement a patch that can set/get either form through Process API. The mask might be a more general format, so if Justin is willing to update his patch to that we can add Omair's test case to his patch?

Mon, Apr 12, 7:15 PM
jasonmolenda added a comment to D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only.

Hm, a little more thinking. Target::ReadMemory prefers a file cache if it is available. Process::ReadMemory only uses live memory. But Process::ReadMemory doesn't work when we have run lldb on a file and not run yet. e.g.

% lldb
(lldb) tar cr -d /tmp/b.out
Current executable set to '/tmp/b.out' (x86_64).
(lldb) disass -n main
b.out`main:
b.out[0x100003f90] <+0>:  pushq  %rbp
b.out[0x100003f91] <+1>:  movq   %rsp, %rbp
b.out[0x100003f94] <+4>:  movq   0x65(%rip), %rax          ; (void *)0x0000000000000000
b.out[0x100003f9b] <+11>: movl   $0x0, -0x4(%rbp)
Mon, Apr 12, 7:03 PM · Restricted Project
jasonmolenda added a comment to D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only.

I'm not super convinced on the setting. It seems like something you'd add some people could work around a mistake we've made here.

Mon, Apr 12, 6:56 PM · Restricted Project
jasonmolenda added a comment to D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only.

Another question for @jasonmolenda: Do you happen to know if the existing prefer_file_cache mechanism applies relocations?

Mon, Apr 12, 6:38 PM · Restricted Project
jasonmolenda added a comment to D99944: [LLDB] AArch64 PAC elf-core stack unwinder support.

Hi Omair, sorry for the delay in looking at this. It seems like we have two overlapping patches here, @justincohen patch in https://reviews.llvm.org/D98886 and this one.

Mon, Apr 12, 2:58 PM

Fri, Apr 9

jasonmolenda requested review of D100164: Don't treat corefile binaries like dylibs in the shared cache, even if they say they are.
Fri, Apr 9, 12:16 AM · Restricted Project

Thu, Apr 8

jasonmolenda committed rGdd453a1389b6: Add setting to disable LanguageRuntime UnwindPlans (authored by jasonmolenda).
Add setting to disable LanguageRuntime UnwindPlans
Thu, Apr 8, 1:30 PM
jasonmolenda closed D99828: Create setting to disable LanguageRuntime provided UnwindPlans.
Thu, Apr 8, 1:30 PM · Restricted Project
jasonmolenda committed rGd9773c1b4eb1: Reorg firmware corefile tests; add test for OS plugin loading (authored by jasonmolenda).
Reorg firmware corefile tests; add test for OS plugin loading
Thu, Apr 8, 1:46 AM

Sun, Apr 4

jasonmolenda added a reverting change for rG4d9039c8dc2d: Add support for fetching signed values from tagged pointers.: rG602ab188a7e1: Revert "Add support for fetching signed values from tagged pointers.".
Sun, Apr 4, 1:49 AM
jasonmolenda committed rG602ab188a7e1: Revert "Add support for fetching signed values from tagged pointers." (authored by jasonmolenda).
Revert "Add support for fetching signed values from tagged pointers."
Sun, Apr 4, 1:49 AM
jasonmolenda added a reverting change for D99694: Add support for getting signed ObjC tagged pointer values: rG602ab188a7e1: Revert "Add support for fetching signed values from tagged pointers.".
Sun, Apr 4, 1:49 AM · Restricted Project

Fri, Apr 2

jasonmolenda requested review of D99828: Create setting to disable LanguageRuntime provided UnwindPlans.
Fri, Apr 2, 11:29 PM · Restricted Project

Thu, Apr 1

jasonmolenda committed rG78a1412845b5: Handle all standalone combinations of LC_NOTEs w/ & w/o addr & uuid (authored by jasonmolenda).
Handle all standalone combinations of LC_NOTEs w/ & w/o addr & uuid
Thu, Apr 1, 7:03 PM
jasonmolenda closed D99571: Update ProcessMachCore::DoLoadCore to handle binary hints with and without addresses.
Thu, Apr 1, 7:03 PM · Restricted Project
jasonmolenda added a comment to D99571: Update ProcessMachCore::DoLoadCore to handle binary hints with and without addresses.

Thanks for the feedback Shafik, updated the patch and landing in a sec.

Thu, Apr 1, 1:17 PM · Restricted Project

Tue, Mar 30

jasonmolenda requested review of D99571: Update ProcessMachCore::DoLoadCore to handle binary hints with and without addresses.
Tue, Mar 30, 3:10 AM · Restricted Project

Thu, Mar 25

jasonmolenda added a comment to D98529: [lldb] Strip pointer authentication codes from aarch64 pc..
Thu, Mar 25, 2:47 PM · Restricted Project

Wed, Mar 24

jasonmolenda committed rG3bc65a946ebe: Handle a LC_NOTE main bin spec for user process corefiles (authored by jasonmolenda).
Handle a LC_NOTE main bin spec for user process corefiles
Wed, Mar 24, 2:23 AM

Tue, Mar 23

jasonmolenda committed rGa0793cb1f1a6: Update SafeMachO.h to #undefine more names (authored by jasonmolenda).
Update SafeMachO.h to #undefine more names
Tue, Mar 23, 11:36 PM
jasonmolenda added a comment to D98529: [lldb] Strip pointer authentication codes from aarch64 pc..

TCR_ELx begins at 1 (see D13.2.123 TCR_EL1, Translation Control Register (EL1) in the armarm) and covers EL0 and 1. Looking at the pseudocode access to this is undefined at EL0.

Tue, Mar 23, 1:48 AM · Restricted Project

Mar 19 2021

jasonmolenda accepted D98996: Teach DWARFExpression about DWARF 4+ Location Descriptions.

This fits with my reading of the DWARF5 doc; LGTM.

Mar 19 2021, 11:24 PM · Restricted Project

Mar 17 2021

jasonmolenda added a comment to D98529: [lldb] Strip pointer authentication codes from aarch64 pc..
uint32_t addressing_bits;
size_t len = sizeof (uint32_t);
ret = sysctlbyname("machdep.virtual_address_size", &addressing_bits, &len, NULL, 0);

returns ret == -1 on an iOS 14.4 device. I do see this work on an m1 mac.

Mar 17 2021, 12:01 PM · Restricted Project
jasonmolenda added a comment to D98529: [lldb] Strip pointer authentication codes from aarch64 pc..

In the meantime, I'll look into adding something to the Crashpad minidump format to store an addrable bits mask, although I'm not clear how to grab this in userspace. Should sysctl machdep.virtual_address_size work on iOS? Can I grab TCR_ELx.T0SZ directly?

Mar 17 2021, 11:38 AM · Restricted Project
jasonmolenda added a comment to D98529: [lldb] Strip pointer authentication codes from aarch64 pc..

Before reading Jason's response, I was independently wondering whether it makes sense to temporarily introduce a variable to let the user set the mask, just until the workaround is replaced with final code. Given that there's precedent, I would support that. (I've not implemented one of these LLDB settings before, but I imagine it's pretty straightforward.)

Mar 17 2021, 11:33 AM · Restricted Project
jasonmolenda added a comment to D98529: [lldb] Strip pointer authentication codes from aarch64 pc..

TCR_ELx begins at 1 (see D13.2.123 TCR_EL1, Translation Control Register (EL1) in the armarm) and covers EL0 and 1. Looking at the pseudocode access to this is undefined at EL0.

Mar 17 2021, 11:29 AM · Restricted Project

Mar 16 2021

jasonmolenda added a comment to D98529: [lldb] Strip pointer authentication codes from aarch64 pc..

I added a Mach-O LC_NOTE which allows us to encode the number of bits used in addressing:

Mar 16 2021, 2:20 PM · Restricted Project
jasonmolenda added a comment to D98529: [lldb] Strip pointer authentication codes from aarch64 pc..

Sorry for not replying to this earlier. Yeah, correct number of bits to mask off must be determined dynamically at runtime, by looking at the CPU's TCR_EL0.T0SZ value (or TCR_EL1.T0SZ for EL1 code like a kernel), which is the inverse of the number of bits used for addressing (T0Sz value of 25, 39 bits used for addressing). When I added this support to the apple version of lldb, I hardcoded the number of bits used on our main processors and added a setting of target.process.virtual-addressable-bits for different cores -- because we didn't have any way of fetching these values at runtime. Since then we've added a k-v pair to the qHostInfo,

Mar 16 2021, 1:24 PM · Restricted Project

Mar 12 2021

jasonmolenda committed rG22e9753271b7: Don't load kexts/kernels without dSYMs present (authored by jasonmolenda).
Don't load kexts/kernels without dSYMs present
Mar 12 2021, 5:21 PM

Mar 9 2021

jasonmolenda committed rGea659ea101a5: Log in SetPrivateState when unwind logging enabled (authored by jasonmolenda).
Log in SetPrivateState when unwind logging enabled
Mar 9 2021, 4:24 PM

Mar 3 2021

jasonmolenda committed rG266bb78f7d13: LanguageRuntime for 0th frame unwind, simplify getting pc-for-symbolication (authored by jasonmolenda).
LanguageRuntime for 0th frame unwind, simplify getting pc-for-symbolication
Mar 3 2021, 7:30 PM
jasonmolenda closed D97644: Allow RegisterContext to track if behaves-like-frame-0, allow LanguageRuntime for above frame 0.
Mar 3 2021, 7:29 PM · Restricted Project
jasonmolenda added inline comments to D97644: Allow RegisterContext to track if behaves-like-frame-0, allow LanguageRuntime for above frame 0.
Mar 3 2021, 6:45 PM · Restricted Project
jasonmolenda added inline comments to D97644: Allow RegisterContext to track if behaves-like-frame-0, allow LanguageRuntime for above frame 0.
Mar 3 2021, 3:47 PM · Restricted Project
jasonmolenda updated the diff for D97644: Allow RegisterContext to track if behaves-like-frame-0, allow LanguageRuntime for above frame 0.

Rewrite patch to expose "get pc for symbolication" APIs instead of "behaves like zeroth frame" APIs so that we don't have different parts of lldb decrementing the pc for symbolication. Doing a final round of tests on different targets etc but I believe this is done.

Mar 3 2021, 2:47 PM · Restricted Project

Feb 28 2021

jasonmolenda added a comment to D97644: Allow RegisterContext to track if behaves-like-frame-0, allow LanguageRuntime for above frame 0.

Another alternative to RegisterContext::BehavesLikeZerothFrame that I've thought of is RegisterContext::GetPCForSymbolication, similar to GetPC() today. I think everyone who is decrementing $pc is doing it for symbolication, so having this hint and then leaving it to everyone to decrement-or-not may not be a great choice. It may be easier for higher-levels if RegisterContext can provide an Address suitable for symbolication directly.

Feb 28 2021, 6:01 PM · Restricted Project
jasonmolenda requested review of D97644: Allow RegisterContext to track if behaves-like-frame-0, allow LanguageRuntime for above frame 0.
Feb 28 2021, 2:48 PM · Restricted Project

Feb 24 2021

jasonmolenda accepted D97441: [debugserver] Fix logic to extract app bundle from file path.

Nice, LGTM.

Feb 24 2021, 10:37 PM · Restricted Project

Feb 18 2021

jasonmolenda committed rGd82ecb0ac722: LanguageRuntime can provide an UnwindPlan for special occasions (authored by jasonmolenda).
LanguageRuntime can provide an UnwindPlan for special occasions
Feb 18 2021, 11:23 PM
jasonmolenda closed D96839: Add a callout to the LanguageRuntime to override the normal UnwindPlan used for a frame.
Feb 18 2021, 11:23 PM · Restricted Project
jasonmolenda added a comment to D96939: [lldb] Add a note to the core file loading error message that mentions archives.

What about:

error: Couldn't recognise core file format of <PATH>.
note: If the file is a core file in a compressed file archive, it first needs to be manually extracted before it can be loaded.

Looks good to me. Although I would write it with the freedom spelling of recognize. :)

We could compromise and spell it as recogniße (which combines s and z into one letter).

Feb 18 2021, 12:27 AM · Restricted Project
jasonmolenda added a comment to D96939: [lldb] Add a note to the core file loading error message that mentions archives.

What about:

error: Couldn't recognise core file format of <PATH>.
note: If the file is a core file in a compressed file archive, it first needs to be manually extracted before it can be loaded.
Feb 18 2021, 12:23 AM · Restricted Project
jasonmolenda added a comment to D96939: [lldb] Add a note to the core file loading error message that mentions archives.

I mean, I'm also fine with suggesting that the file might be compressed, because this is a REAL common source of an unrecognized core file format. But also we can more clearly say "Doesn't look like a core file to me" and also noting that compression is something to look at is cool.

Feb 18 2021, 12:16 AM · Restricted Project
jasonmolenda added a comment to D96939: [lldb] Add a note to the core file loading error message that mentions archives.

Thanks for taking time to deal with this annoying error message. Should we just remove the "Unable to find process plug-in for core file" text altogether? It means nothing unless you work on lldb and understand the plugin system. "Unrecognized core file format" is equivalent and more helpful to the user I think.

Feb 18 2021, 12:14 AM · Restricted Project

Feb 17 2021

jasonmolenda committed rGfcdef15d77bd: Add a new Row setting to mark all un-declared regs as Undefined (authored by jasonmolenda).
Add a new Row setting to mark all un-declared regs as Undefined
Feb 17 2021, 11:53 PM
jasonmolenda closed D96829: Add "Undeclared registers are marked as Undefined" to UnwindPlan, adopt it in arch default unwind plans.
Feb 17 2021, 11:52 PM · Restricted Project
jasonmolenda added inline comments to D96839: Add a callout to the LanguageRuntime to override the normal UnwindPlan used for a frame.
Feb 17 2021, 1:56 PM · Restricted Project
jasonmolenda added inline comments to D96839: Add a callout to the LanguageRuntime to override the normal UnwindPlan used for a frame.
Feb 17 2021, 12:09 PM · Restricted Project

Feb 16 2021

jasonmolenda requested review of D96839: Add a callout to the LanguageRuntime to override the normal UnwindPlan used for a frame.
Feb 16 2021, 10:55 PM · Restricted Project
jasonmolenda added a comment to D96829: Add "Undeclared registers are marked as Undefined" to UnwindPlan, adopt it in arch default unwind plans.

I marked Pavel as the reviewer for this because he's maybe the most likely to have an opinion about this change; I don't mean to sign you up for review work if you don't have time right now. I don't know if the specifics of the patch are especially interesting, but the testability problem and the decision to update all of the arch default unwind plans seem the most notable/discussable to me.

Feb 16 2021, 9:44 PM · Restricted Project
jasonmolenda requested review of D96829: Add "Undeclared registers are marked as Undefined" to UnwindPlan, adopt it in arch default unwind plans.
Feb 16 2021, 6:48 PM · Restricted Project

Feb 3 2021

jasonmolenda accepted D95922: [lldb] Honor the CPU type & subtype on macOS.

Yep, looks good.

Feb 3 2021, 1:09 PM · Restricted Project

Feb 2 2021

jasonmolenda accepted D95922: [lldb] Honor the CPU type & subtype on macOS.

This looks good to me. Are the bots all running macOS Big Sur (macOS 11)? The -target command line arguments in the Makefile might not work if the test is run on an older version of macOS, I think.

Feb 2 2021, 11:12 PM · Restricted Project

Jan 22 2021

jasonmolenda committed rGad25bdcb8e4e: Change static buffer to be BSS instead of DATA in HandlePacket_qSpeedTest (authored by jasonmolenda).
Change static buffer to be BSS instead of DATA in HandlePacket_qSpeedTest
Jan 22 2021, 4:14 PM

Jan 20 2021

jasonmolenda accepted D95110: [lldb] Upstream eCore_arm_arm64e enum value.

Looks good.

Jan 20 2021, 6:48 PM · Restricted Project

Jan 15 2021

jasonmolenda committed rG10ac9b29a4ca: Skip 'g' packet tests when running on darwin; debugserver doesn't impl (authored by jasonmolenda).
Skip 'g' packet tests when running on darwin; debugserver doesn't impl
Jan 15 2021, 1:58 PM
jasonmolenda closed D94754: skip g packet tests on darwin systems.
Jan 15 2021, 1:58 PM · Restricted Project
jasonmolenda updated the diff for D94754: skip g packet tests on darwin systems.

Ah, Pavel's change was correct to run the first test.

Jan 15 2021, 2:14 AM · Restricted Project
jasonmolenda added a comment to D94754: skip g packet tests on darwin systems.

Ah, part of my confusion is mine - the alignas() requires c++11 and I wasn't building with that mode when I did it by hand.

Jan 15 2021, 1:25 AM · Restricted Project
jasonmolenda requested review of D94754: skip g packet tests on darwin systems.
Jan 15 2021, 1:22 AM · Restricted Project

Jan 13 2021

jasonmolenda committed rG885eae9d85de: Add func call so we don't instruction-step into the builtin_trap (authored by jasonmolenda).
Add func call so we don't instruction-step into the builtin_trap
Jan 13 2021, 11:42 PM

Jan 11 2021

jasonmolenda committed rGedde2eb1d209: Add unconditional logging to debugserver for launch/attach processes (authored by jasonmolenda).
Add unconditional logging to debugserver for launch/attach processes
Jan 11 2021, 10:26 PM
jasonmolenda closed D94357: [NFC] Add some additional, unconditional, logging to debugserver mostly related to app launching/attaching.
Jan 11 2021, 10:26 PM · Restricted Project
jasonmolenda added inline comments to D94460: [dsymutil] Copy eh_frame content into the dSYM companion file..
Jan 11 2021, 9:35 PM · Restricted Project
jasonmolenda added inline comments to D94460: [dsymutil] Copy eh_frame content into the dSYM companion file..
Jan 11 2021, 9:31 PM · Restricted Project

Jan 9 2021

jasonmolenda requested review of D94357: [NFC] Add some additional, unconditional, logging to debugserver mostly related to app launching/attaching.
Jan 9 2021, 2:11 AM · Restricted Project

Jan 8 2021

jasonmolenda accepted D94320: [debugserver] Various plist changes.

Thanks Jonas, LGTM.

Jan 8 2021, 1:07 PM · Restricted Project

Dec 9 2020

jasonmolenda committed rG2cedc44a9233: Ignore DBGArchitecture from dsymForUUID's plist (authored by jasonmolenda).
Ignore DBGArchitecture from dsymForUUID's plist
Dec 9 2020, 2:20 PM
jasonmolenda closed D92692: Ignore DBGArchitecture from DebugSymbols DBGShellCommands outputs .
Dec 9 2020, 2:20 PM · Restricted Project

Dec 4 2020

jasonmolenda accepted D92712: [debugserver] Honor the cpu sub type if specified.

Ah very cool, I didn't realize we had a new posix_spawn attr setter that could set the cpu subtype.

Dec 4 2020, 7:50 PM · Restricted Project
jasonmolenda added a comment to D92692: Ignore DBGArchitecture from DebugSymbols DBGShellCommands outputs .

Ah, I forgot to add. I added a test by having an existing corefile test (which loads an x86_64 binary) have a plist that claims it is i386. It's close to the same thing, and results in the same kind of erroring if lldb trusts the arch from the plist.

Dec 4 2020, 2:19 PM · Restricted Project
jasonmolenda requested review of D92692: Ignore DBGArchitecture from DebugSymbols DBGShellCommands outputs .
Dec 4 2020, 2:17 PM · Restricted Project

Dec 3 2020

jasonmolenda accepted D92609: [lldb] Use the cpu sub type defines for llvm::MachO.

Nice cleanup.

Dec 3 2020, 2:38 PM
jasonmolenda accepted D92603: [lldb] Recognize MachO cpu sub-type 2 as arm64.

Bien.

Dec 3 2020, 1:25 PM · Restricted Project
jasonmolenda added inline comments to D92452: [lldb] Treat remote macOS debugging like any other remote darwin platform.
Dec 3 2020, 1:25 AM · Restricted Project

Dec 1 2020

jasonmolenda added a comment to D92452: [lldb] Treat remote macOS debugging like any other remote darwin platform.

Looks good overall, nice test.

Dec 1 2020, 8:22 PM · Restricted Project

Nov 12 2020

jasonmolenda committed rG92b036dea24b: debugserver should advance pc past builtin_debugtrap insn (authored by jasonmolenda).
debugserver should advance pc past builtin_debugtrap insn
Nov 12 2020, 11:31 PM
jasonmolenda closed D91238: Recognize __builtin_debugtrap on arm64, advance pc past it so users can continue easily.
Nov 12 2020, 11:31 PM · Restricted Project