Page MenuHomePhabricator

jasonmolenda (Jason Molenda)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 2 2014, 12:05 PM (402 w, 5 d)

Recent Activity

Fri, May 20

jasonmolenda accepted D126076: [lldb] Set correct register number for cpsr (GENERIC_REGNUM_FLAGS).

Ah, good catch!

Fri, May 20, 9:34 AM · Restricted Project, Restricted Project

Mon, May 16

jasonmolenda committed rGd2f3b6020fbf: [NFC] Don't bother with unstripped binary w/ dSYM, don't DebugSymbols twice (authored by jasonmolenda).
[NFC] Don't bother with unstripped binary w/ dSYM, don't DebugSymbols twice
Mon, May 16, 3:31 PM · Restricted Project
jasonmolenda closed D125616: [NFC] two small perf fixes for when using a DebugSymbols DBGShellCommands to find a dSYM.
Mon, May 16, 3:30 PM · Restricted Project, Restricted Project
jasonmolenda updated the diff for D125616: [NFC] two small perf fixes for when using a DebugSymbols DBGShellCommands to find a dSYM.

Update to address Jonas' comments.

Mon, May 16, 10:50 AM · Restricted Project, Restricted Project
jasonmolenda added inline comments to D125616: [NFC] two small perf fixes for when using a DebugSymbols DBGShellCommands to find a dSYM.
Mon, May 16, 10:45 AM · Restricted Project, Restricted Project

Sat, May 14

jasonmolenda requested review of D125616: [NFC] two small perf fixes for when using a DebugSymbols DBGShellCommands to find a dSYM.
Sat, May 14, 1:06 PM · Restricted Project, Restricted Project

Thu, May 12

jasonmolenda abandoned D125505: Cache tilde expansions to avoid redundant lookups.
Thu, May 12, 5:12 PM · Restricted Project, Restricted Project
jasonmolenda added a comment to D125505: Cache tilde expansions to avoid redundant lookups.

Yeah, you're right. And as I walk through in my head what I'm solving with this -- it's not the really expensive part of this whole operation, I don't think. I should check more carefully but it's the stat's over NFS partitions that are impacting performance, and I doubt the realpath() to expand the tilde's is a significant factor (the kernel should cache all of these inodes anyway if we're doing it in a hot fashion). I'll probably abandon this altogether unless I can prove to myself that it's important, and hoist it into the base class.

Thu, May 12, 4:29 PM · Restricted Project, Restricted Project
jasonmolenda requested review of D125505: Cache tilde expansions to avoid redundant lookups.
Thu, May 12, 3:57 PM · Restricted Project, Restricted Project
jasonmolenda accepted D125434: Make a more convenient way to allow Darwin users to ignore certain Mach Exceptions.

This is a nice piece of work, and a good cleanup, LGTM.

Thu, May 12, 3:06 PM · Restricted Project, Restricted Project

Thu, May 5

jasonmolenda committed rG2be791e32af3: Insert crashing stack frame when call to null func ptr (authored by jasonmolenda).
Insert crashing stack frame when call to null func ptr
Thu, May 5, 5:56 PM · Restricted Project
jasonmolenda closed D125042: have crashlog.py insert a stack frame with $lr when stack frame 0 is address 0.
Thu, May 5, 5:55 PM · Restricted Project, Restricted Project
jasonmolenda updated the diff for D125042: have crashlog.py insert a stack frame with $lr when stack frame 0 is address 0.

update to incorporate dave's suggestions.

Thu, May 5, 5:53 PM · Restricted Project, Restricted Project
jasonmolenda added inline comments to D125042: have crashlog.py insert a stack frame with $lr when stack frame 0 is address 0.
Thu, May 5, 5:34 PM · Restricted Project, Restricted Project
jasonmolenda added a comment to D125042: have crashlog.py insert a stack frame with $lr when stack frame 0 is address 0.

Does that mean that the interactive crashlogs (crashlog -i) do this correctly?

Thu, May 5, 4:56 PM · Restricted Project, Restricted Project
jasonmolenda added inline comments to D124957: When picking a row from an UnwindPlan on a mid-stack frame, decr pc to get within bounds of the CALL instruction.
Thu, May 5, 2:38 PM · Restricted Project, Restricted Project
jasonmolenda committed rGb6388e4a0050: Decr return pc mid-stack when picking UnwindPlan row (authored by jasonmolenda).
Decr return pc mid-stack when picking UnwindPlan row
Thu, May 5, 2:19 PM · Restricted Project
jasonmolenda closed D124957: When picking a row from an UnwindPlan on a mid-stack frame, decr pc to get within bounds of the CALL instruction.
Thu, May 5, 2:18 PM · Restricted Project, Restricted Project
jasonmolenda requested review of D125042: have crashlog.py insert a stack frame with $lr when stack frame 0 is address 0.
Thu, May 5, 2:11 PM · Restricted Project, Restricted Project
jasonmolenda updated the diff for D124957: When picking a row from an UnwindPlan on a mid-stack frame, decr pc to get within bounds of the CALL instruction.

Accidentally included an unrelated change in the last update.

Thu, May 5, 1:57 PM · Restricted Project, Restricted Project
jasonmolenda added inline comments to D124957: When picking a row from an UnwindPlan on a mid-stack frame, decr pc to get within bounds of the CALL instruction.
Thu, May 5, 1:55 PM · Restricted Project, Restricted Project
jasonmolenda updated the diff for D124957: When picking a row from an UnwindPlan on a mid-stack frame, decr pc to get within bounds of the CALL instruction.

Update to address Greg's feedback.

Thu, May 5, 1:53 PM · Restricted Project, Restricted Project
jasonmolenda added inline comments to D124957: When picking a row from an UnwindPlan on a mid-stack frame, decr pc to get within bounds of the CALL instruction.
Thu, May 5, 1:34 PM · Restricted Project, Restricted Project

Wed, May 4

jasonmolenda added a comment to D124957: When picking a row from an UnwindPlan on a mid-stack frame, decr pc to get within bounds of the CALL instruction.

Ah, I can't share the binary/corefile that led me to this issue but I can show what it looks like. I have a function with a noreturn call, it's a crashing scenario where (as always) this is the most important bit to get right, to show the crash,

Wed, May 4, 6:23 PM · Restricted Project, Restricted Project
jasonmolenda committed rGa6553d97df39: Remove expected fail for TestStepNoDebug on AArch64 (authored by jasonmolenda).
Remove expected fail for TestStepNoDebug on AArch64
Wed, May 4, 3:28 PM · Restricted Project
jasonmolenda committed rGdf552edb08c4: Update the CFA to use $sp when $fp is restored on arm64 (authored by jasonmolenda).
Update the CFA to use $sp when $fp is restored on arm64
Wed, May 4, 2:54 PM · Restricted Project
jasonmolenda closed D124492: Update CFA to be in terms of $sp instead of $fp when $fp is overwritten in epilogue on AArch64.
Wed, May 4, 2:54 PM · Restricted Project, Restricted Project
jasonmolenda requested review of D124957: When picking a row from an UnwindPlan on a mid-stack frame, decr pc to get within bounds of the CALL instruction.
Wed, May 4, 1:08 PM · Restricted Project, Restricted Project

Tue, May 3

jasonmolenda accepted D124814: Fix debugserver translation check.

LGTM. I see how your workflow is set up. Yeah, you return an error if someone tries to run debugserver in translation (and the inferior isn't x86_64) - that's what we need to do, a translated debugserver won't be able to debug arm64 processes.

Tue, May 3, 1:31 PM · Restricted Project, Restricted Project

Mon, May 2

jasonmolenda added a comment to D124814: Fix debugserver translation check.

(tbh every case I've seen, it's someone who checked "Run in Rosetta" on the Xcode.app bundle with Finder, and are running their entire IDE as x86_64....)

Mon, May 2, 6:01 PM · Restricted Project, Restricted Project
jasonmolenda added a comment to D124814: Fix debugserver translation check.

Ah, I see what you're doing. You've got a shell running x86_64 or something (maybe started lldb as x86_64) so everything that is spawned from that is x86_64 -- debugserver and the inferior process -- and so you hit this. let me look more closely later tonight, but I didn't take that scenario into account. Normally when people are running debugserver as x86_64 it's because they unintentionally ran a parent as x86_64 and are paying an unintended perf hit across the debug session and part of this error reporting was to say "hey, you probably didn't mean to do this".

Mon, May 2, 6:00 PM · Restricted Project, Restricted Project

Fri, Apr 29

jasonmolenda committed rG9c8179f9ce10: LocationListLookup test case failing on lldb-arm-ubuntu (authored by jasonmolenda).
LocationListLookup test case failing on lldb-arm-ubuntu
Fri, Apr 29, 3:05 PM · Restricted Project
jasonmolenda added a comment to D124597: Select the correct DWARF location list entry when looking for variable locations.

I wonder if this will help optimized code debugging at all!? Good catch

Fri, Apr 29, 2:51 PM · Restricted Project, Restricted Project
jasonmolenda committed rG6e56c4961a10: Decr pc when looking for DWARF loc list entry mid-stack (authored by jasonmolenda).
Decr pc when looking for DWARF loc list entry mid-stack
Fri, Apr 29, 2:39 PM · Restricted Project
jasonmolenda closed D124597: Select the correct DWARF location list entry when looking for variable locations.
Fri, Apr 29, 2:39 PM · Restricted Project, Restricted Project

Thu, Apr 28

jasonmolenda abandoned D100164: Don't treat corefile binaries like dylibs in the shared cache, even if they say they are.
Thu, Apr 28, 2:18 PM · Restricted Project, Restricted Project
jasonmolenda updated the diff for D124492: Update CFA to be in terms of $sp instead of $fp when $fp is overwritten in epilogue on AArch64.

cleanup patch to remove an unintended diff.

Thu, Apr 28, 2:09 PM · Restricted Project, Restricted Project
jasonmolenda requested review of D124597: Select the correct DWARF location list entry when looking for variable locations.
Thu, Apr 28, 12:21 AM · Restricted Project, Restricted Project

Tue, Apr 26

jasonmolenda committed rGa2681c43308c: Don't push null ExecutionContext on CommandInterp exectx stack (authored by jasonmolenda).
Don't push null ExecutionContext on CommandInterp exectx stack
Tue, Apr 26, 6:32 PM · Restricted Project
jasonmolenda closed D111209: Don't push null ExecutionContext on CommandInterpreter exectx stack.
Tue, Apr 26, 6:32 PM · Restricted Project, Restricted Project
jasonmolenda added a comment to D121631: Introduce new symbol on-demand for debug info.

Thanks! Yeah, I only noticed because lldb-dotest threw an error when I was trying to run a test case earlier.

Tue, Apr 26, 6:22 PM · Restricted Project, Restricted Project
jasonmolenda added a comment to D121631: Introduce new symbol on-demand for debug info.

Hi, I noticed that we have two tests with the same name,

Tue, Apr 26, 5:50 PM · Restricted Project, Restricted Project
jasonmolenda requested review of D124492: Update CFA to be in terms of $sp instead of $fp when $fp is overwritten in epilogue on AArch64.
Tue, Apr 26, 5:46 PM · Restricted Project, Restricted Project

Mon, Apr 25

Herald added a project to D111209: Don't push null ExecutionContext on CommandInterpreter exectx stack: Restricted Project.

Hi all, getting back to this one after six months, hah. Reading through Jim's thoughts on this, I think we're OK to add this refinement. Tatyana also thought that removing this altogether would be an option, but this has been sitting unfixed for a while and I'd like to land the fix to it. Jim wishes for a world where HandleCommand requires an SBExecutionContext, or one in which we had an established way of deprecating old SB API. Given that we can't address that at the moment, I'm going to land this patch finally so we're not carrying the problem around for the foreseeable future.

Mon, Apr 25, 3:10 PM · Restricted Project, Restricted Project

Apr 21 2022

jasonmolenda added a comment to D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available..

I guess the other comment I would make is whether we should have a new ivar, instead of using the unused 0th bit of search_offset.

Apr 21 2022, 5:08 PM · Restricted Project, Restricted Project
jasonmolenda added a comment to D124198: [LLDB][Unwind] Add stack scanning as fallback unwind plan if no symbol file is available..

This is obviously building on Pavel's work of https://reviews.llvm.org/D66638 for Win32 systems. What problem with that existing patchset is this addressing? Pavel's original patch assumes that we can retrieve a function's expected stack frame size, and the size of the caller's arguments on the stack, plus a bit of searching around that location, as he describes. It seems like in ABIWindows_x86_64::CreateStackWalkingUnwindPlan you're adding a scheme that tries to look at the area directly around $sp for a return pc? This seems quite fragile by itself.

Apr 21 2022, 4:26 PM · Restricted Project, Restricted Project

Apr 14 2022

jasonmolenda accepted D123743: [lldb] Show the DBGError if dsymForUUID can't find a dSYM.

LGTM.

Apr 14 2022, 2:59 PM · Restricted Project, Restricted Project

Apr 12 2022

jasonmolenda added a comment to D123616: [debugserver ] Un-conditionalize use of libcompression.

Sounds good. I think it's test-and-use for lldb, and debugserver ended up structure the same way.

Apr 12 2022, 9:25 AM · Restricted Project, Restricted Project
jasonmolenda added a comment to D123616: [debugserver ] Un-conditionalize use of libcompression.

fwiw,

commit 681f6c2f552fb9b57380f4bfd453e1fc9b6a099e
Author: Jason Molenda <jmolenda@apple.com>
Date:   Tue Dec 18 22:21:48 2018 +0000
Apr 12 2022, 9:21 AM · Restricted Project, Restricted Project
jasonmolenda accepted D123616: [debugserver ] Un-conditionalize use of libcompression.

I think we only support building debugserver on macOS systems that have libcompression. Was there a configuration where this resulted in an error? lldb needs to test for libcompression and use it if available, but with debugserver we assume it is available iirc. I'm fine with the patch, but I'm curious how it came up. It used to be tested before use etc but I removed that a couple of years ago when our minimum deployment target was high enough that it was always available.

Apr 12 2022, 9:20 AM · Restricted Project, Restricted Project

Apr 6 2022

jasonmolenda committed rG4d3cc2783138: Correct debugserver to write xmm/ymm/zmm reg values (authored by jasonmolenda).
Correct debugserver to write xmm/ymm/zmm reg values
Apr 6 2022, 11:37 PM · Restricted Project
jasonmolenda closed D123269: debugserver would never write modified xmm/ymm/zmm register values into the inferior.
Apr 6 2022, 11:37 PM · Restricted Project, Restricted Project
jasonmolenda updated the diff for D123269: debugserver would never write modified xmm/ymm/zmm register values into the inferior.
Apr 6 2022, 4:43 PM · Restricted Project, Restricted Project
jasonmolenda requested review of D123269: debugserver would never write modified xmm/ymm/zmm register values into the inferior.
Apr 6 2022, 4:40 PM · Restricted Project, Restricted Project

Apr 5 2022

jasonmolenda committed rGee394177e6b7: Refine memory buffer for importing shared cache objc class list (authored by jasonmolenda).
Refine memory buffer for importing shared cache objc class list
Apr 5 2022, 12:50 PM · Restricted Project

Apr 4 2022

jasonmolenda accepted D123098: [lldb] Fix undefined behavior: left shift of negative value.

LGTM but unobfuscated is a uint64_t, does this cast do anything now?

Apr 4 2022, 9:05 PM · Restricted Project, Restricted Project
jasonmolenda committed rG7ebcd8891a7a: Add DumpBinaryEscaped method to JSONGenerator, avoid extra copy (authored by jasonmolenda).
Add DumpBinaryEscaped method to JSONGenerator, avoid extra copy
Apr 4 2022, 2:14 PM · Restricted Project
jasonmolenda closed D122882: Add JSONGenerator::DumpBinaryEscaped method in debugserver, update most callers to use this, skip escaping step.
Apr 4 2022, 2:14 PM · Restricted Project, Restricted Project
jasonmolenda updated the diff for D122882: Add JSONGenerator::DumpBinaryEscaped method in debugserver, update most callers to use this, skip escaping step.

Update patch to remove unnecessary temporary std::string when dumping a string into its JSON representation.

Apr 4 2022, 2:11 PM · Restricted Project, Restricted Project

Apr 1 2022

jasonmolenda requested review of D122882: Add JSONGenerator::DumpBinaryEscaped method in debugserver, update most callers to use this, skip escaping step.
Apr 1 2022, 1:48 AM · Restricted Project, Restricted Project

Mar 31 2022

jasonmolenda committed rGc04fdfa17e6d: Update callers to SendPacket with std::string's to not devolve to c-strs (authored by jasonmolenda).
Update callers to SendPacket with std::string's to not devolve to c-strs
Mar 31 2022, 11:47 PM · Restricted Project
jasonmolenda closed D122848: Reduce extraneous temp strings in debugserver, free objects when they're not longer needed.
Mar 31 2022, 11:47 PM · Restricted Project, Restricted Project
jasonmolenda updated the diff for D122848: Reduce extraneous temp strings in debugserver, free objects when they're not longer needed.

Address Jonas' feedback by removing the parts of the patch that freed the ostringstream's after binary-escaped versions of them had been generated. Instead I'll add DumpEscaped methods to the JSONGenerator class.

Mar 31 2022, 11:43 PM · Restricted Project, Restricted Project
jasonmolenda added a comment to D122848: Reduce extraneous temp strings in debugserver, free objects when they're not longer needed.

I was chatting with Jonas about this a bit. The part of this patch which fixes all of the SendPacket(outbuf.c_str()) calls, to avoid a temporary copy of the std::string, is clearly necessary and correct. The changes to clear the ostringstreams eagerly after we've escaped the data is noisy, and I'll remove those and look at updating JSONGenerator to print escaped string representations directly, to eliminate the unescaped copy & the escaped copy duplication. I'll update the patch in a bit.

Mar 31 2022, 5:00 PM · Restricted Project, Restricted Project
jasonmolenda added a comment to D122848: Reduce extraneous temp strings in debugserver, free objects when they're not longer needed.

If debugserver linked against libSupport we could have saved the additional copy altogether by using llvm::raw_string_ostream:

std::string str;
llvm::raw_string_ostream stream(str);
stream.str() // Flushes and returns a reference to the stack allocated str

Barring that, I wonder if if a little wrapper around std::ostringstream could improve readability and avoid bugs where someone forgets to call stream.str("").

class AggressiveStream {
public:
  AggressiveStream() : m_stream(std::make_unique<std::ostringstream>()) {}

  std::ostringstream &operator*() {
    assert(m_stream && "cannot use stream after having called str()");
    return *m_stream;
  }

  std::string str() {
    std::string s = m_stream->str();
    m_stream.reset();
    return std::move(s);
  }

private:
  std::unique_ptr<std::ostringstream> m_stream;
};

WDYT?

Mar 31 2022, 3:02 PM · Restricted Project, Restricted Project
jasonmolenda added inline comments to D122848: Reduce extraneous temp strings in debugserver, free objects when they're not longer needed.
Mar 31 2022, 2:51 PM · Restricted Project, Restricted Project
jasonmolenda requested review of D122848: Reduce extraneous temp strings in debugserver, free objects when they're not longer needed.
Mar 31 2022, 1:23 PM · Restricted Project, Restricted Project

Mar 24 2022

jasonmolenda committed rG99515783a63c: Don't search for sim SDK path until we know we need it (authored by jasonmolenda).
Don't search for sim SDK path until we know we need it
Mar 24 2022, 3:45 PM · Restricted Project
jasonmolenda closed D122373: [NFC] Be more lazy about looking up simulator SDKs on macs.
Mar 24 2022, 3:45 PM · Restricted Project, Restricted Project
jasonmolenda requested review of D122373: [NFC] Be more lazy about looking up simulator SDKs on macs.
Mar 24 2022, 1:49 AM · Restricted Project, Restricted Project

Mar 23 2022

jasonmolenda committed rG9a8a0a38613a: Load dyld manually with 'main bin spec' userland corefiles (authored by jasonmolenda).
Load dyld manually with 'main bin spec' userland corefiles
Mar 23 2022, 5:12 PM · Restricted Project
jasonmolenda accepted D122349: [lldb] Don't persist the LINKEDIT slide in the indirect symbol offset.

Ah, good catch. Yes this looks correct to me.

Mar 23 2022, 4:09 PM · Restricted Project, Restricted Project

Mar 21 2022

jasonmolenda accepted D122177: [lldb] Fix log & progress report for in-memory binaries.

LGTM.

Mar 21 2022, 1:40 PM · Restricted Project, Restricted Project

Mar 10 2022

jasonmolenda added a comment to D121348: Don't try to get memory returns for ABIMacOSX_arm64.

Ach, that's unfortunate. So a caller can allocate space for the return object, pass that address to a callee in x8, but when callee returns, x8 has been overwritten. Agree that this is the only right way to behave.

Mar 10 2022, 12:00 AM · Restricted Project, Restricted Project

Mar 2 2022

jasonmolenda committed rGdaba82362228: Refine error msgs from CommandObject & Disassemble (authored by jasonmolenda).
Refine error msgs from CommandObject & Disassemble
Mar 2 2022, 11:18 AM · Restricted Project
jasonmolenda closed D120594: Improve error messages for command that need a stopped process.
Mar 2 2022, 11:18 AM · Restricted Project, Restricted Project

Mar 1 2022

jasonmolenda updated the diff for D120594: Improve error messages for command that need a stopped process.

Integrate Jonas' suggestion, update the disassemble shell test to match the new error messages.

Mar 1 2022, 4:18 PM · Restricted Project, Restricted Project

Feb 25 2022

jasonmolenda added a comment to D120594: Improve error messages for command that need a stopped process.

Nit: can we use a colon instead of dash? We have a bunch of places already where we're "concatenating" errors with a colon so I'd like to keep that consistent.

Using a dash is definitely the kind of thing I would do, but I don't think I did here? I'm really not wedded to my specific wording in this patch.

Feb 25 2022, 3:49 PM · Restricted Project, Restricted Project
jasonmolenda added a comment to D120594: Improve error messages for command that need a stopped process.

Nit: can we use a colon instead of dash? We have a bunch of places already where we're "concatenating" errors with a colon so I'd like to keep that consistent.

Feb 25 2022, 3:48 PM · Restricted Project, Restricted Project
jasonmolenda requested review of D120594: Improve error messages for command that need a stopped process.
Feb 25 2022, 3:40 PM · Restricted Project, Restricted Project
jasonmolenda committed rGcd2ba23efb3e: PlatformMacOSX should be activated for lldb built to run on an iOS etc device (authored by jasonmolenda).
PlatformMacOSX should be activated for lldb built to run on an iOS etc device
Feb 25 2022, 12:57 AM
jasonmolenda closed D120517: PlatformMacOSX should be activated for lldb built to run on an iOS etc device.
Feb 25 2022, 12:57 AM · Restricted Project

Feb 24 2022

jasonmolenda requested review of D120517: PlatformMacOSX should be activated for lldb built to run on an iOS etc device.
Feb 24 2022, 2:09 PM · Restricted Project

Feb 22 2022

jasonmolenda added a comment to D120292: [lldb] Add lldb.find helper function.

@jasonmolenda one advantage this has over grepping is that the python specific extensions to SB are visible.

Feb 22 2022, 10:44 AM · Restricted Project

Feb 21 2022

jasonmolenda added a comment to D120292: [lldb] Add lldb.find helper function.

Nice. tbh when I'm SB API scripting, I am often sitting in include/lldb/API and grepping for keywords, because I can't remember exactly which class provides the API, or what arguments it takes or whatever.

Feb 21 2022, 10:07 PM · Restricted Project

Feb 14 2022

jasonmolenda committed rG4a394367c124: Alt mechanism to find the first loadable seg in a Mach-O binary (authored by jasonmolenda).
Alt mechanism to find the first loadable seg in a Mach-O binary
Feb 14 2022, 11:13 AM
jasonmolenda closed D119602: Add additional method for ObjectFileMachO to find the first loadable segment in a Mach-O binary.
Feb 14 2022, 11:13 AM · Restricted Project

Feb 11 2022

jasonmolenda updated the diff for D119602: Add additional method for ObjectFileMachO to find the first loadable segment in a Mach-O binary.

Fix typeo in comment.

Feb 11 2022, 4:11 PM · Restricted Project
jasonmolenda requested review of D119602: Add additional method for ObjectFileMachO to find the first loadable segment in a Mach-O binary.
Feb 11 2022, 4:09 PM · Restricted Project

Feb 7 2022

jasonmolenda committed rG9b1cb0e171a3: Platform gdb RSP packet doc fixes based on implementation behavior (authored by jasonmolenda).
Platform gdb RSP packet doc fixes based on implementation behavior
Feb 7 2022, 11:53 PM
jasonmolenda closed D118842: Small fixes to platform packet documentation.
Feb 7 2022, 11:52 PM · Restricted Project

Feb 4 2022

jasonmolenda committed rGa37c38176a5a: Increase memory buffer for scanning objc classes on darwin systems (authored by jasonmolenda).
Increase memory buffer for scanning objc classes on darwin systems
Feb 4 2022, 11:56 PM
jasonmolenda closed D118972: Increase preallocated buffer for scanning the process objc classes.
Feb 4 2022, 11:56 PM · Restricted Project
jasonmolenda updated the diff for D118972: Increase preallocated buffer for scanning the process objc classes.

Update to address Jonas' feedback.

Feb 4 2022, 11:53 PM · Restricted Project

Feb 3 2022

jasonmolenda requested review of D118972: Increase preallocated buffer for scanning the process objc classes.
Feb 3 2022, 11:29 PM · Restricted Project

Feb 2 2022

jasonmolenda added a comment to D118842: Small fixes to platform packet documentation.

FWIW I started updating my implementation by reading through all the changes to the docs, and implementing them. Then I went back and looked at the patches and found some small changes that were made but without documentation being updated, or the documentation not being specific about expected details.

Feb 2 2022, 9:11 PM · Restricted Project
jasonmolenda requested review of D118842: Small fixes to platform packet documentation.
Feb 2 2022, 12:52 PM · Restricted Project

Jan 14 2022

jasonmolenda accepted D117340: [lldb] Fix platform selection on Apple Silicon.

I see what you're doing, yeah, this makes sense. Sometimes with firmware debugging, we pick a random platform (basically) and this might change which platform gets picked, host versus remote-ios, but I don't think it will matter for them.

Jan 14 2022, 10:42 AM · Restricted Project

Jan 3 2022

jasonmolenda added a comment to D116211: With firmware debug sess, if gdb stub knows the UUID/address of binary, try to load it.

What happened to the test case?

Jan 3 2022, 11:11 PM · Restricted Project

Dec 23 2021

jasonmolenda committed rG8a26ba6a02f1: Load binary by UUID from qProcessInfo packet fields (authored by jasonmolenda).
Load binary by UUID from qProcessInfo packet fields
Dec 23 2021, 3:21 PM