Part of this test file was stolen from D156895. We should merge them
when committing.
Details
Details
- Reviewers
asb reames joshua-arch1 - Commits
- rGa8c502a58939: [RISCV] Add bf16 to isFPImmLegal.
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp | ||
---|---|---|
848 | Don't you need handling for bf16 here? |
llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp | ||
---|---|---|
848 | I think getLegalZfaFPImm should return -1 for bf16 since we don't have a bf16 FLI instruction. |
Comment Actions
LGTM. I incorporated the bfloat_zero and bfloat_negative_zero tests in the committed version of D156895.
Comment Actions
LGTM as well
llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp | ||
---|---|---|
848 | Yep, I'd misread the code. |
clang-format not found in user’s local PATH; not linting file.