[RISCV] Add bf16 to isFPImmLegal.

[craig.topper]

Summary

Part of this test file was stolen from D156895. We should merge them
when committing.

[craig.topper]

Add test file

[reames]

llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp

848

Don't you need handling for bf16 here?

[craig.topper]

llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp

848

I think getLegalZfaFPImm should return -1 for bf16 since we don't have a bf16 FLI instruction.

[asb]

LGTM. I incorporated the bfloat_zero and bfloat_negative_zero tests in the committed version of D156895.

[reames]

LGTM as well

llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp

848

Yep, I'd misread the code.

llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp

case ISD::ConstantFP: {
     const APFloat &APF = cast<ConstantFPSDNode>(Node)->getValueAPF();
     int FPImm = static_cast<const RISCVTargetLowering *>(TLI)->getLegalZfaFPImm(
         APF, VT);
     if (FPImm >= 0) {
       unsigned Opc;
       switch (VT.SimpleTy) {
       default:
         llvm_unreachable("Unexpected size");
       case MVT::f16:
         Opc = RISCV::FLI_H;
         break;
       case MVT::f32:
         Opc = RISCV::FLI_S;
         break;
       case MVT::f64:
         Opc = RISCV::FLI_D;
         break;
case ISD::ConstantFP: {
     else
       Imm = selectImm(CurDAG, DL, XLenVT, APF.bitcastToAPInt().getSExtValue(),
                       *Subtarget);
 
     unsigned Opc;
     switch (VT.SimpleTy) {
     default:
       llvm_unreachable("Unexpected size");
+    case MVT::bf16:
+      assert(Subtarget->hasStdExtZfbfmin());
+      Opc = RISCV::FMV_H_X;
+      break;
     case MVT::f16:
       Opc =
           Subtarget->hasStdExtZhinxOrZhinxmin() ? RISCV::COPY : RISCV::FMV_H_X;
       break;
     case MVT::f32:
       Opc = Subtarget->hasStdExtZfinx() ? RISCV::COPY : RISCV::FMV_W_X;
       break;
     case MVT::f64:

llvm/lib/Target/RISCV/RISCVISelLowering.cpp

bool RISCVTargetLowering::isFPImmLegal(const APFloat &Imm, EVT VT,
                                        bool ForCodeSize) const {
   bool IsLegalVT = false;
   if (VT == MVT::f16)
     IsLegalVT = Subtarget.hasStdExtZfhOrZfhminOrZhinxOrZhinxmin();
   else if (VT == MVT::f32)
     IsLegalVT = Subtarget.hasStdExtFOrZfinx();
   else if (VT == MVT::f64)
     IsLegalVT = Subtarget.hasStdExtDOrZdinx();
+  else if (VT == MVT::bf16)
+    IsLegalVT = Subtarget.hasStdExtZfbfmin();
 
   if (!IsLegalVT)
     return false;
 
   if (getLegalZfaFPImm(Imm, VT) >= 0)
     return true;
 
   // Cannot create a 64 bit floating-point immediate value for rv32.

llvm/test/CodeGen/RISCV/bfloat-imm.ll

 ; CHECK-NEXT:    ret
   %1 = fadd bfloat %a, 1.0
   ret bfloat %1
 }
 
 define bfloat @bfloat_zero() nounwind {
 ; CHECK-LABEL: bfloat_zero:
 ; CHECK:       # %bb.0:
-; CHECK-NEXT:    lui a0, %hi(.LCPI2_0)
-; CHECK-NEXT:    flh fa0, %lo(.LCPI2_0)(a0)
+; CHECK-NEXT:    fmv.h.x fa0, zero
 ; CHECK-NEXT:    ret
   ret bfloat 0.0
 }
 
 define bfloat @bfloat_negative_zero() nounwind {
 ; CHECK-LABEL: bfloat_negative_zero:
 ; CHECK:       # %bb.0:
-; CHECK-NEXT:    lui a0, %hi(.LCPI3_0)
-; CHECK-NEXT:    flh fa0, %lo(.LCPI3_0)(a0)
+; CHECK-NEXT:    lui a0, 1048568
+; CHECK-NEXT:    fmv.h.x fa0, a0
 ; CHECK-NEXT:    ret
   ret bfloat -0.0
 }

llvm/test/CodeGen/RISCV/bfloat-select-icmp.ll

; CHECK-NEXT:    ret
   %2 = select i1 %1, bfloat %c, bfloat %d
   ret bfloat %2
 }
 
 define bfloat @select_icmp_slt_one(i32 signext %a) {
 ; CHECK-LABEL: select_icmp_slt_one:
 ; CHECK:       # %bb.0:
 ; CHECK-NEXT:    slti a0, a0, 1
-; CHECK-NEXT:    slli a0, a0, 1
-; CHECK-NEXT:    lui a1, %hi(.LCPI10_0)
-; CHECK-NEXT:    addi a1, a1, %lo(.LCPI10_0)
-; CHECK-NEXT:    add a0, a1, a0
-; CHECK-NEXT:    flh fa0, 0(a0)
+; CHECK-NEXT:    fcvt.s.w fa5, a0
+; CHECK-NEXT:    fcvt.bf16.s fa0, fa5
 ; CHECK-NEXT:    ret
   %1 = icmp slt i32 %a, 1
   %2 = select i1 %1, bfloat 1.000000e+00, bfloat 0.000000e+00
   ret bfloat %2
 }
 
 define bfloat @select_icmp_sgt_zero(i32 signext %a) {
 ; CHECK-LABEL: select_icmp_sgt_zero:
 ; CHECK:       # %bb.0:
-; CHECK-NEXT:    sgtz a0, a0
-; CHECK-NEXT:    slli a0, a0, 1
-; CHECK-NEXT:    lui a1, %hi(.LCPI11_0)
-; CHECK-NEXT:    addi a1, a1, %lo(.LCPI11_0)
-; CHECK-NEXT:    add a0, a1, a0
-; CHECK-NEXT:    flh fa0, 0(a0)
+; CHECK-NEXT:    slti a0, a0, 1
+; CHECK-NEXT:    fcvt.s.w fa5, a0
+; CHECK-NEXT:    fcvt.bf16.s fa0, fa5
 ; CHECK-NEXT:    ret
   %1 = icmp sgt i32 %a, 0
   %2 = select i1 %1, bfloat 0.000000e+00, bfloat 1.000000e+00
   ret bfloat %2
 }