This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Fix the check assertion in hasMergeOp and hasMaskOp
ClosedPublic

Authored by jacquesguan on Jul 19 2023, 1:36 AM.

Details

Summary

Because we have STRICT_FCVT_W_RV64 equal to ISD::FIRST_TARGET_STRICTFP_OPCODE, the check needs to be splitted into 2 parts.

Diff Detail

Event Timeline

jacquesguan created this revision.Jul 19 2023, 1:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 19 2023, 1:36 AM
jacquesguan requested review of this revision.Jul 19 2023, 1:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 19 2023, 1:36 AM

Add some enumeration to mark the begin and end of vl op.

craig.topper added inline comments.Jul 24 2023, 8:44 PM
llvm/lib/Target/RISCV/RISCVISelLowering.h
169–170

READ_VLENB is not a VL vector op

move READ_VLENB out of vl range.

jacquesguan marked an inline comment as done.Jul 25 2023, 12:08 AM
jacquesguan added inline comments.
llvm/lib/Target/RISCV/RISCVISelLowering.h
169–170

Done.

This revision is now accepted and ready to land.Jul 25 2023, 9:41 AM
This revision was landed with ongoing or failed builds.Jul 25 2023, 8:22 PM
This revision was automatically updated to reflect the committed changes.
jacquesguan marked an inline comment as done.