This is an archive of the discontinued LLVM Phabricator instance.

Enable zba and zbs for RISCV64 Android
ClosedPublic

Authored by hiraditya on Jul 14 2023, 2:54 PM.

Diff Detail

Event Timeline

hiraditya created this revision.Jul 14 2023, 2:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2023, 2:54 PM
hiraditya requested review of this revision.Jul 14 2023, 2:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2023, 2:54 PM
hiraditya retitled this revision from Enable zba and zbs for riscv android to Enable zba and zbs for RISCV64 Android.Jul 14 2023, 2:54 PM
enh accepted this revision.Jul 14 2023, 4:28 PM
This revision is now accepted and ready to land.Jul 14 2023, 4:28 PM
MaskRay added inline comments.Jul 15 2023, 2:11 PM
clang/test/Driver/riscv-features.c
13

If the features are adjacent, test them on one line. // ANDROID: "-target-feature" "+zba" "-target-feature" "+zbb" ...

asb accepted this revision.Jul 17 2023, 8:03 AM

LGTM.

hiraditya added inline comments.Jul 17 2023, 3:37 PM
clang/test/Driver/riscv-features.c
13

that's a neat trick. it might work for zba, and zbb. But it could break for zbs if something else comes in between. that will make this test dependent on how flags are sorted internally. probably not worth micro-optimizing for this case.

This revision was landed with ongoing or failed builds.Jul 17 2023, 4:16 PM
This revision was automatically updated to reflect the committed changes.