Page MenuHomePhabricator

enh (Elliott Hughes)


User does not belong to any projects.

User Details

User Since
May 15 2015, 4:56 PM (244 w, 3 d)

Recent Activity

Nov 11 2019

enh added a comment to D69983: [libcxx] Omit unneeded locale fallbacks on Android 21+.

actually, it looks like clang is inlining the code for all the is*_l
functions anyway. you're paying for the indirection on
strcoll_l/strxfrm_l/wcscoll_l/wcsxfrm_l, but no one should be using
those anyway.

Nov 11 2019, 8:04 AM · Restricted Project

Nov 7 2019

enh added a comment to D69983: [libcxx] Omit unneeded locale fallbacks on Android 21+.

honestly, if it was me, i'd keep all these inlines even for current releases: inlining a call to the underlying function saves you a layer of useless cruft at runtime. (the Android "implementations" are just one-liners that drop the extra argument and call the underlying function, just like these inlines.)

Nov 7 2019, 9:30 PM · Restricted Project

Nov 6 2019

enh created D69929: Fix _LIBCPP_HAS_ definitions for Android..
Nov 6 2019, 9:09 PM · Restricted Project

Jul 16 2019

enh added a comment to D64299: Make ~mutex and ~condition_variable trivial with Bionic pthreads.

i assume the idea here is "all libc++ mutexes are covered by RAII anyway, so there's no value to the error checking"?

Jul 16 2019, 9:31 AM

Sep 19 2018

enh updated subscribers of D52251: [builtins] Add __emutls_unregister_key function.

yeah, we always used the low numbers internally.

Sep 19 2018, 4:05 PM

Jul 14 2015

enh added a comment to D10522: Implement target independent TLS compatible with glibc's emutls.c..

not really though --- i think you're getting that from libgcc. so
although short term you don't need to add this stuff to compiler-rt to
test, it will be necessary for anyone not using libgcc. (like us, at
some point in the future.)

Jul 14 2015, 3:49 PM