- User Since
- Mar 16 2015, 3:52 PM (289 w, 1 d)
Apr 13 2020
Mar 20 2020
Merged. Thanks for the review @MaskRay.
Cleanup based on review comments.
Use isOSDarwin() instead of isOSBinFormatMachO()
Treat any bitode with non-Darwin triple as GNU.
Use K_GNU for all ELF targets.
Mar 19 2020
Handle bitcode inputs with BSD target triple.
Mar 18 2020
Mar 17 2020
Dec 2 2019
Nov 19 2019
Oct 7 2019
Sep 11 2019
- Do not have a declaration as a prevailing symbol in llvm-lto2's arguments
- Fix comments in test
@tejohnson Did my reply about shared metadata clarify your question?
Sep 9 2019
Check for OMPRT_Unknown instead of a default case.
Sep 6 2019
Test -static, -static-openmp interaction. Added these only for iomp5 to avoid test-case explosion.
I'll update this review addressing @joerg's reply to cfe-commits:
Needs testing for the -static interaction?
Mention NDK issue https://github.com/android-ndk/ndk/issues/1028.
Sep 5 2019
Does this regress from existing behavior for unused argument warnings? Currently, -static-libstdc++ -nostdlib issues an unused argument warning for -static-libstdc++, while AFAICT -static=c++stdlib -nostdlib doesn't.
Change parameter name.
Supported this flag for NetBSD and FreeBSD as well.
Sep 4 2019
Update/clean-up comments in the test.
Aug 28 2019
Aug 27 2019
Fix typo reffers -> refers
Aug 8 2019
Aug 6 2019
Avoid extra variable
Thanks Peter. I'll wait for another day for further comments, and if none, will submit this tomorrow morning (pacific time).
Aug 5 2019
Aug 1 2019
Thanks for the workaround @peter.smith. I suggested it to the NDK developer as well. The immediate need for this change is gone, but I agree that this is useful for the various reasons you outlined.
Jul 31 2019
Jul 25 2019
Call strlen(gcov_prefix) only if its not null.
Remove stray new line.
Refactored the loop to call getenv just once.
LGTM for Android.
Jul 24 2019
Jul 1 2019
Jun 25 2019
Skip version script for all MinGW builds, not just when using lld.
Jun 24 2019
Mar 27 2019
Feb 20 2019
Feb 13 2019
Feb 12 2019
Jan 11 2019
Jan 10 2019
Dec 18 2018
Dec 3 2018
Nov 29 2018
Nov 15 2018
Someone just pointed out to me that even in Android P , libm's sincos() just called sin() followed by cos() so this optimization won't be beneficial. It was changed in March 2018  but is not a part of any release yet.