Page MenuHomePhabricator

pirama (Pirama Arumuga Nainar)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 16 2015, 3:52 PM (381 w, 2 d)

Recent Activity

Thu, Jun 30

pirama abandoned D108006: [lld][ELF] Add --no-search-static-libs-for-shlib-undefined flag.

To close the loop here, we were able to fix the build rules in Android without needing this flag.

Thu, Jun 30, 12:26 PM · Restricted Project, Restricted Project

Wed, Jun 15

pirama committed rG80aa41d9df3d: Pass through even more LIBCXX_* variables to libfuzzer's custom lib++ (authored by ccross).
Pass through even more LIBCXX_* variables to libfuzzer's custom lib++
Wed, Jun 15, 7:07 PM · Restricted Project, Restricted Project
pirama closed D127912: Pass through even more LIBCXX_* variables to libfuzzer's custom lib++.
Wed, Jun 15, 7:07 PM · Restricted Project, Restricted Project

Mar 9 2022

pirama committed rGe75f1d3c07ed: [CompilerRT] Fix build of compiler-rt with musl (authored by ccross).
[CompilerRT] Fix build of compiler-rt with musl
Mar 9 2022, 1:42 PM · Restricted Project
pirama closed D119358: [CompilerRT] Fix build of compiler-rt with musl.
Mar 9 2022, 1:41 PM · Restricted Project, Restricted Project
pirama added a comment to D119358: [CompilerRT] Fix build of compiler-rt with musl.

My local ninja check-sanitizer passed but the automated build has failed: https://reviews.llvm.org/B153417. Let me do a ninja check-all and fix.

Mar 9 2022, 1:16 PM · Restricted Project, Restricted Project
pirama added a comment to D121326: [MSAN] adjust Posix/timer.cpp.

Looks like this assert is broken? https://reviews.llvm.org/B153417 and https://reviews.llvm.org/B153416 are some early indications.

Mar 9 2022, 1:15 PM · Restricted Project, Restricted Project
pirama added a comment to D119358: [CompilerRT] Fix build of compiler-rt with musl.

My local ninja check-sanitizer passed but the automated build has failed: https://reviews.llvm.org/B153417. Let me do a ninja check-all and fix.

Mar 9 2022, 1:11 PM · Restricted Project, Restricted Project
pirama added a comment to D119358: [CompilerRT] Fix build of compiler-rt with musl.

Looks like all comments are addressed. I'll merge after a quick ninja check.

Mar 9 2022, 12:47 PM · Restricted Project, Restricted Project

Mar 4 2022

pirama committed rGbcc65fb491ca: Pass through more LIBCXX_* variables to libfuzzer's custom lib++ (authored by ccross).
Pass through more LIBCXX_* variables to libfuzzer's custom lib++
Mar 4 2022, 9:32 AM · Restricted Project
pirama closed D120946: Pass through more LIBCXX_* variables to libfuzzer's custom lib++.
Mar 4 2022, 9:31 AM · Restricted Project, Restricted Project

Feb 17 2022

pirama updated subscribers of D112349: [Verifier] Add verification logic for GlobalIFuncs.

Unrelated to missing resolver definition, this change doesn't accommodate resolvers that take parameters. (Curiously, this verification only fails with ThinLTO).

Feb 17 2022, 2:34 PM · Restricted Project, Restricted Project, Restricted Project

Feb 9 2022

pirama added a reviewer for D119358: [CompilerRT] Fix build of compiler-rt with musl: eugenis.
Feb 9 2022, 11:04 PM · Restricted Project, Restricted Project
pirama requested review of D119358: [CompilerRT] Fix build of compiler-rt with musl.
Feb 9 2022, 10:59 AM · Restricted Project, Restricted Project

Feb 8 2022

pirama added a comment to D102097: [CompilerRT] Sanitizer compilation on musl systems.

Hi, nice to see that musl gets more use. Can you clarify the Android use case? SANITIZER_ANDROID is defined while musl is used?

You had suggested in a comment to use SANITIZER_LINUX && !SANITIZER_GLIBC to detect MUSL but bionic would pass that check as well. If bionic and musl have different types/definitions, we'd then need SANITIZER_LINUX && !SANITIZER_GLIBC && !SANITIZER_ANDROID, as used in the diff I posted.

Not defining a musl macro is to follow its spirit https://wiki.musl-libc.org/faq.html "Why is there no MUSL macro?"

From my experience, most issues are related to glibc specific extensions or behaviors, less related to musl behaviors.
It seems that Android bionic may port quite a few glibc specific extensions as well.

So in many places SANITIZER_GLIBC || SANITIZER_ANDROID may be more appropriate than !SANITIZER_MUSL.

Feb 8 2022, 3:13 PM · Restricted Project
pirama added a comment to D102097: [CompilerRT] Sanitizer compilation on musl systems.

Hi, nice to see that musl gets more use. Can you clarify the Android use case? SANITIZER_ANDROID is defined while musl is used?

Feb 8 2022, 2:07 PM · Restricted Project
pirama updated subscribers of D102097: [CompilerRT] Sanitizer compilation on musl systems.

@ccross is building musl runtimes for Android host tools and we seem to need the following diff. The SANITIZER_LINUX && !SANITIZER_GLIBC idiom may not apply everywhere since it'd include Android as well. @vchuravy @MaskRay any thoughts? We could also consider an explicit CMake variable similar to _LIBCPP_HAS_MUSL_LIBC.

Feb 8 2022, 1:50 PM · Restricted Project

Feb 4 2022

pirama added a comment to D116753: [Driver] Default to -fno-math-errno for musl too.

@alxu Just realized you don't have commit access. Do you want one of us to merge this?

Feb 4 2022, 3:58 PM · Restricted Project

Jan 19 2022

pirama abandoned D117728: [libc++] Check that gdb is linked with Python 3.

Do they still fail after rG89103bd2f06d? I was able to run ninja check-all successfully with a gdb linked against 2.7.

Jan 19 2022, 4:30 PM · Restricted Project
pirama added a reviewer for D117728: [libc++] Check that gdb is linked with Python 3: DavidSpickett.
Jan 19 2022, 3:47 PM · Restricted Project
pirama requested review of D117728: [libc++] Check that gdb is linked with Python 3.
Jan 19 2022, 3:46 PM · Restricted Project

Jan 10 2022

pirama committed rGf5b387988bd4: Revert "[CodeGen] Mark fma as const for Android" (authored by alxu).
Revert "[CodeGen] Mark fma as const for Android"
Jan 10 2022, 11:35 AM
pirama added a reverting change for rGfbfba29d7474: [CodeGen] Mark fma as const for Android: rGf5b387988bd4: Revert "[CodeGen] Mark fma as const for Android".
Jan 10 2022, 11:35 AM
pirama added a reverting change for D44852: [CodeGen] Mark fma as const for Android: rGf5b387988bd4: Revert "[CodeGen] Mark fma as const for Android".
Jan 10 2022, 11:35 AM
pirama closed D116755: Revert "[CodeGen] Mark fma as const for Android".
Jan 10 2022, 11:35 AM · Restricted Project

Jan 6 2022

pirama accepted D116755: Revert "[CodeGen] Mark fma as const for Android".

Thanks for the cleanup here.

Jan 6 2022, 10:03 AM · Restricted Project

Nov 30 2021

pirama added a comment to D114473: [runtimes] Remove support for GCC-style 32 bit multilib builds.

Doesn't seem like we use this for Android, but @pirama just in case.

Nov 30 2021, 2:26 PM · Restricted Project, Restricted Project, Restricted Project

Nov 23 2021

pirama committed rG1df7289af66c: [compiler-rt/profile] Include __llvm_profile_get_magic in module signature (authored by pirama).
[compiler-rt/profile] Include __llvm_profile_get_magic in module signature
Nov 23 2021, 10:10 AM
pirama closed D114054: [compiler-rt/profile] Include __llvm_profile_get_magic in module signature.
Nov 23 2021, 10:10 AM · Restricted Project

Nov 16 2021

pirama updated the diff for D114054: [compiler-rt/profile] Include __llvm_profile_get_magic in module signature.

reword commit message.

Nov 16 2021, 9:33 PM · Restricted Project
pirama requested review of D114054: [compiler-rt/profile] Include __llvm_profile_get_magic in module signature.
Nov 16 2021, 9:24 PM · Restricted Project
pirama edited reviewers for D113840: [Driver][Android] Remove unneeded isNoExecStackDefault, added: srhines; removed: pirama.

Will defer to Dan's review. I think these changes are safe for the Android platform (where we only use lld). The NDK only supports lld but that does not preclude external users from using other linkers.

Nov 16 2021, 12:02 PM · Restricted Project
pirama committed rG078279ff017f: [compiler-rt/profile] Reland mark __llvm_profile_raw_version as hidden (authored by pirama).
[compiler-rt/profile] Reland mark __llvm_profile_raw_version as hidden
Nov 16 2021, 11:46 AM
pirama closed D111759: [compiler-rt/profile] Reland mark __llvm_profile_raw_version as hidden.
Nov 16 2021, 11:46 AM · Restricted Project
pirama updated the diff for D111759: [compiler-rt/profile] Reland mark __llvm_profile_raw_version as hidden.

arc diff --verbatim to update phabricator message

Nov 16 2021, 11:35 AM · Restricted Project

Nov 15 2021

pirama updated the diff for D111759: [compiler-rt/profile] Reland mark __llvm_profile_raw_version as hidden.

Do not hide __llvm_profile_raw_version on Apple platforms.

Nov 15 2021, 5:23 PM · Restricted Project

Oct 27 2021

pirama added a comment to D108006: [lld][ELF] Add --no-search-static-libs-for-shlib-undefined flag.

(I assume that Android will fix the issues so I can request changes to remove this from my very long review queue :)

Oct 27 2021, 5:10 PM · Restricted Project, Restricted Project
pirama added a comment to D111759: [compiler-rt/profile] Reland mark __llvm_profile_raw_version as hidden.

According to https://reviews.llvm.org/rGf5380185623be243ba0f1b18d4bd594ac5cc7163 Apple's API verification tool (tapi) checks the exported __llvm_profile_raw_version.
However, ld64 cannot export a private-extern (hidden) symbol.

I wonder whether Apple's tool should lift the restriction. If not, we may need to special case __APPLE__.

Oct 27 2021, 9:54 AM · Restricted Project

Oct 21 2021

pirama added a comment to D111759: [compiler-rt/profile] Reland mark __llvm_profile_raw_version as hidden.

This causes instrprof-darwin-exports.c test failure on MacOS:
ld: warning: cannot export hidden symbol ___llvm_profile_raw_version from /Users/zequanwu/llvm-project/build/release/lib/clang/14.0.0/lib/darwin/libclang_rt.profile_osx.a(InstrProfilingVersionVar.c.o)

I think we should stop exporting ___llvm_profile_raw_version from Darwin::addProfileRTLibs() in clang/lib/Driver/ToolChains/Darwin.cpp. @vsk Can you confirm?

Can you revert it for now to unblock the test failure on MacOS bots?

Done. Zequan, can you help test if removing https://github.com/llvm/llvm-project/blob/ab3d5d0533678ee93c93bd62db79c091741096f0/clang/lib/Driver/ToolChains/Darwin.cpp#L1292 fixes all failures? I'll submit this again once @vsk confirms if that is acceptable.

That doesn't help. I got different error:

Command Output (stdout):
--
2d1
< ___llvm_profile_raw_version

--
Oct 21 2021, 11:54 AM · Restricted Project
pirama reopened D111759: [compiler-rt/profile] Reland mark __llvm_profile_raw_version as hidden.

This causes instrprof-darwin-exports.c test failure on MacOS:
ld: warning: cannot export hidden symbol ___llvm_profile_raw_version from /Users/zequanwu/llvm-project/build/release/lib/clang/14.0.0/lib/darwin/libclang_rt.profile_osx.a(InstrProfilingVersionVar.c.o)

I think we should stop exporting ___llvm_profile_raw_version from Darwin::addProfileRTLibs() in clang/lib/Driver/ToolChains/Darwin.cpp. @vsk Can you confirm?

Can you revert it for now to unblock the test failure on MacOS bots?

Oct 21 2021, 11:00 AM · Restricted Project
pirama added a reverting change for rG69708477be25: [compiler-rt/profile] Hide __llvm_profile_raw_version: rGab3d5d053367: Revert "[compiler-rt/profile] Hide __llvm_profile_raw_version".
Oct 21 2021, 10:58 AM
pirama committed rGab3d5d053367: Revert "[compiler-rt/profile] Hide __llvm_profile_raw_version" (authored by pirama).
Revert "[compiler-rt/profile] Hide __llvm_profile_raw_version"
Oct 21 2021, 10:58 AM
pirama added a reverting change for D111759: [compiler-rt/profile] Reland mark __llvm_profile_raw_version as hidden: rGab3d5d053367: Revert "[compiler-rt/profile] Hide __llvm_profile_raw_version".
Oct 21 2021, 10:57 AM · Restricted Project

Oct 20 2021

pirama added a comment to D111759: [compiler-rt/profile] Reland mark __llvm_profile_raw_version as hidden.

This causes instrprof-darwin-exports.c test failure on MacOS:
ld: warning: cannot export hidden symbol ___llvm_profile_raw_version from /Users/zequanwu/llvm-project/build/release/lib/clang/14.0.0/lib/darwin/libclang_rt.profile_osx.a(InstrProfilingVersionVar.c.o)

Oct 20 2021, 7:21 PM · Restricted Project

Oct 15 2021

pirama committed rG69708477be25: [compiler-rt/profile] Hide __llvm_profile_raw_version (authored by pirama).
[compiler-rt/profile] Hide __llvm_profile_raw_version
Oct 15 2021, 12:08 PM
pirama closed D111759: [compiler-rt/profile] Reland mark __llvm_profile_raw_version as hidden.
Oct 15 2021, 12:08 PM · Restricted Project
pirama updated the diff for D111759: [compiler-rt/profile] Reland mark __llvm_profile_raw_version as hidden.

Describe Android use case.

Oct 15 2021, 11:14 AM · Restricted Project
pirama updated the diff for D111759: [compiler-rt/profile] Reland mark __llvm_profile_raw_version as hidden.

This is not related to weak attribute to __llvm_profile_raw_version

Oct 15 2021, 11:08 AM · Restricted Project
pirama added a comment to D111759: [compiler-rt/profile] Reland mark __llvm_profile_raw_version as hidden.

This leads to a runtime link failure if the libB.so available at runtime does not provide this symbol (but provides the other dependent symbols). Such a scenario can occur in Android's mainline modules.

The symbol is defined at link time but not available at run time? That's a pilot error.

Oct 15 2021, 10:21 AM · Restricted Project

Oct 14 2021

pirama updated the diff for D111759: [compiler-rt/profile] Reland mark __llvm_profile_raw_version as hidden.

Apply clang-format linter suggestion.

Oct 14 2021, 12:12 PM · Restricted Project

Oct 13 2021

pirama added a comment to D111759: [compiler-rt/profile] Reland mark __llvm_profile_raw_version as hidden.

In the summary, do you mean 'not excluded' instead of 'not included' ?

Oct 13 2021, 3:59 PM · Restricted Project
pirama updated the diff for D111759: [compiler-rt/profile] Reland mark __llvm_profile_raw_version as hidden.

Remove attribute from reference.

Oct 13 2021, 3:53 PM · Restricted Project
pirama updated the diff for D111759: [compiler-rt/profile] Reland mark __llvm_profile_raw_version as hidden.

Fix typos

Oct 13 2021, 3:35 PM · Restricted Project
pirama requested review of D111759: [compiler-rt/profile] Reland mark __llvm_profile_raw_version as hidden.
Oct 13 2021, 3:13 PM · Restricted Project

Oct 5 2021

pirama updated subscribers of rG91bfccf83733: add tsan shared library.

@haowei Can you share instructions to run this exact build? I briefly tried https://fuchsia.googlesource.com/fuchsia/+/refs/heads/main/docs/development/build/toolchain.md but it is different from the failure at https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8834613633802961617/overview, which also seems to set CMAKE_SYSROOT.

Oct 5 2021, 11:37 AM

Sep 23 2021

pirama added a reviewer for D110379: [Driver] Remove confusing *-linux-android detection with non-android --target=: nickdesaulniers.

@nickdesaulniers I presume this is still necessary? See https://reviews.llvm.org/D53463 for why we added this. (The Android kernel build does not use the Android triple.)

Sep 23 2021, 9:33 PM · Restricted Project

Aug 27 2021

pirama committed rG9632ce14e414: [lld/test/ELF] Test fetch from archive to resolve undefined symbols in shared… (authored by pirama).
[lld/test/ELF] Test fetch from archive to resolve undefined symbols in shared…
Aug 27 2021, 2:18 PM
pirama closed D108328: [lld/test/ELF] Test fetch from archive to resolve undefined symbols in shared libs.
Aug 27 2021, 2:18 PM · Restricted Project
pirama added inline comments to D108328: [lld/test/ELF] Test fetch from archive to resolve undefined symbols in shared libs.
Aug 27 2021, 10:45 AM · Restricted Project
pirama updated the diff for D108328: [lld/test/ELF] Test fetch from archive to resolve undefined symbols in shared libs.
  • rename file
  • append '.s' to split-file output names
Aug 27 2021, 10:44 AM · Restricted Project

Aug 26 2021

pirama added a comment to D108328: [lld/test/ELF] Test fetch from archive to resolve undefined symbols in shared libs.

Worth checking whether archive-fetch.s can be folded into the test.

Aug 26 2021, 11:28 AM · Restricted Project
pirama updated the diff for D108328: [lld/test/ELF] Test fetch from archive to resolve undefined symbols in shared libs.

Update with review comments.

Aug 26 2021, 11:24 AM · Restricted Project

Aug 23 2021

pirama added a comment to D108006: [lld][ELF] Add --no-search-static-libs-for-shlib-undefined flag.

For the Android problem, it looks like a workaround as well. Do you know why gold linked executables were fine when Android was still using gold?

Aug 23 2021, 10:49 PM · Restricted Project, Restricted Project

Aug 20 2021

pirama requested review of D108486: [profile] Add back zero-sized dummy sections.
Aug 20 2021, 2:20 PM · Restricted Project

Aug 18 2021

pirama requested review of D108328: [lld/test/ELF] Test fetch from archive to resolve undefined symbols in shared libs.
Aug 18 2021, 1:55 PM · Restricted Project
pirama added inline comments to rG51bf4c0e6d4c: [clang] Add -ffinite-loops & -fno-finite-loops options..
Aug 18 2021, 1:15 PM

Aug 13 2021

pirama added a comment to D108006: [lld][ELF] Add --no-search-static-libs-for-shlib-undefined flag.

Ideally test coverage improvement should be a separate patch.

Aug 13 2021, 11:22 AM · Restricted Project, Restricted Project
pirama added a comment to D108006: [lld][ELF] Add --no-search-static-libs-for-shlib-undefined flag.

It's important to have symmetry. a) ld.lld def.a ref.so b) ld.lld ref.so def.a.
The patch addresses a) but not b).

Aug 13 2021, 10:30 AM · Restricted Project, Restricted Project

Aug 12 2021

pirama added a comment to D108006: [lld][ELF] Add --no-search-static-libs-for-shlib-undefined flag.

I still need to add tests but wanted to upload it to get early thoughts on this approach.

Aug 12 2021, 6:02 PM · Restricted Project, Restricted Project
pirama requested review of D108006: [lld][ELF] Add --no-search-static-libs-for-shlib-undefined flag.
Aug 12 2021, 6:01 PM · Restricted Project, Restricted Project

Aug 11 2021

pirama added inline comments to rG51bf4c0e6d4c: [clang] Add -ffinite-loops & -fno-finite-loops options..
Aug 11 2021, 12:20 PM

Aug 9 2021

pirama committed rG49fabd9d76b4: [openmp] Do not use shared memory on Android (authored by pirama).
[openmp] Do not use shared memory on Android
Aug 9 2021, 9:48 AM
pirama closed D107181: [openmp] Do not use shared memory on Android.
Aug 9 2021, 9:47 AM · Restricted Project

Aug 6 2021

pirama updated the diff for D107181: [openmp] Do not use shared memory on Android.

Refactor preprocessor check to kmp_config.h.

Aug 6 2021, 3:44 PM · Restricted Project
pirama added a comment to D107324: [llvm-objcopy] [COFF] Do not patch debug entries with Repro type.

Thanks for the reviews @mstorsjo @jhenderson.

Aug 6 2021, 9:24 AM · Restricted Project
pirama committed rG16ebb7ab5c46: [llvm-objcopy] [COFF] Do not patch debug entries if PointerToRawData is zero (authored by pirama).
[llvm-objcopy] [COFF] Do not patch debug entries if PointerToRawData is zero
Aug 6 2021, 9:24 AM
pirama closed D107324: [llvm-objcopy] [COFF] Do not patch debug entries with Repro type.
Aug 6 2021, 9:23 AM · Restricted Project
pirama updated the diff for D107324: [llvm-objcopy] [COFF] Do not patch debug entries with Repro type.

Address review comments

Aug 6 2021, 8:52 AM · Restricted Project

Aug 5 2021

pirama updated the diff for D107324: [llvm-objcopy] [COFF] Do not patch debug entries with Repro type.

Update test with revew comments.

Aug 5 2021, 9:47 AM · Restricted Project

Aug 4 2021

pirama added inline comments to D107324: [llvm-objcopy] [COFF] Do not patch debug entries with Repro type.
Aug 4 2021, 10:13 AM · Restricted Project
pirama updated the diff for D107324: [llvm-objcopy] [COFF] Do not patch debug entries with Repro type.

Rename test, expand comments and remove '-S -x' from RUN line.

Aug 4 2021, 10:11 AM · Restricted Project

Aug 3 2021

pirama updated the diff for D107324: [llvm-objcopy] [COFF] Do not patch debug entries with Repro type.

Simplify check and update expected error for one test.

Aug 3 2021, 2:31 PM · Restricted Project
pirama added inline comments to D107324: [llvm-objcopy] [COFF] Do not patch debug entries with Repro type.
Aug 3 2021, 1:39 PM · Restricted Project
pirama updated the diff for D107324: [llvm-objcopy] [COFF] Do not patch debug entries with Repro type.

Skip IMAGE_DEBUG_TYPE_UNKNOWN debug entries as well.

Aug 3 2021, 9:09 AM · Restricted Project
pirama added a comment to D107324: [llvm-objcopy] [COFF] Do not patch debug entries with Repro type.

Do you happen to know if the same is the case for any other debug directory types, or is this the only one?

I'm not sure if this is also the case for other debug directory types. Maybe someone familiar with Windows debug info can help? (+thakis, rnk)

Aug 3 2021, 9:03 AM · Restricted Project

Aug 2 2021

pirama updated subscribers of D107324: [llvm-objcopy] [COFF] Do not patch debug entries with Repro type.

Do you happen to know if the same is the case for any other debug directory types, or is this the only one?

Aug 2 2021, 10:58 PM · Restricted Project
pirama requested review of D107324: [llvm-objcopy] [COFF] Do not patch debug entries with Repro type.
Aug 2 2021, 10:48 PM · Restricted Project

Jul 30 2021

pirama added a comment to D107181: [openmp] Do not use shared memory on Android.

I uploaded this as a starter but we should abstract the check to avoid repetition. Is kmp_config.h.cmake or kmp_platform.h a good place for defining a 'KMP_USE_SHMEM' and using it here?

Jul 30 2021, 10:12 AM · Restricted Project
pirama requested review of D107181: [openmp] Do not use shared memory on Android.
Jul 30 2021, 10:10 AM · Restricted Project

Jul 23 2021

pirama committed rGc45e17f11f50: [NewPM] Add CrossDSOCFI pass irrespective of LTO optimization level (authored by pirama).
[NewPM] Add CrossDSOCFI pass irrespective of LTO optimization level
Jul 23 2021, 2:13 PM
pirama closed D106699: [NewPM] Add CrossDSOCFI pass irrespective of LTO optimization level.
Jul 23 2021, 2:13 PM · Restricted Project
pirama updated the diff for D106699: [NewPM] Add CrossDSOCFI pass irrespective of LTO optimization level.

Remove note in comment.

Jul 23 2021, 12:24 PM · Restricted Project
pirama updated the diff for D106699: [NewPM] Add CrossDSOCFI pass irrespective of LTO optimization level.

s/CHECK-LTO/CHECK-LTO-NEXT in new-pm-O0-defaults.ll

Jul 23 2021, 12:22 PM · Restricted Project
pirama requested review of D106699: [NewPM] Add CrossDSOCFI pass irrespective of LTO optimization level.
Jul 23 2021, 12:19 PM · Restricted Project

May 21 2021

pirama abandoned D102790: [compiler-rt/profile] register __llvm_profile_write_file to run during quick_exit..

Looks like quick_exit + dlclose interaction is not well-defined and this change may cause calls into dlclose-d libraries.

May 21 2021, 10:43 AM · Restricted Project

May 19 2021

pirama added inline comments to D102790: [compiler-rt/profile] register __llvm_profile_write_file to run during quick_exit..
May 19 2021, 2:55 PM · Restricted Project
pirama requested review of D102790: [compiler-rt/profile] register __llvm_profile_write_file to run during quick_exit..
May 19 2021, 11:15 AM · Restricted Project
pirama updated subscribers of rGe4274cfe06fe: [CoverageMapping] Handle gaps in counter IDs for source-based coverage.

Thanks for the review @vsk and @richkadel for the details about Rust coverage instrumentation.

May 19 2021, 10:48 AM
pirama committed rGe4274cfe06fe: [CoverageMapping] Handle gaps in counter IDs for source-based coverage (authored by pirama).
[CoverageMapping] Handle gaps in counter IDs for source-based coverage
May 19 2021, 10:47 AM
pirama closed D101780: [CoverageMapping] Handle gaps in counter IDs for source-based coverage.
May 19 2021, 10:46 AM · Restricted Project