Page MenuHomePhabricator

pirama (Pirama Arumuga Nainar)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 16 2015, 3:52 PM (231 w, 5 d)

Recent Activity

Thu, Aug 8

pirama committed rG0cb2a33dfd3e: [AArch64] Do not emit '#' before immediates in inline asm (authored by pirama).
[AArch64] Do not emit '#' before immediates in inline asm
Thu, Aug 8, 10:51 AM
pirama committed rL368320: [AArch64] Do not emit '#' before immediates in inline asm.
[AArch64] Do not emit '#' before immediates in inline asm
Thu, Aug 8, 10:50 AM
pirama closed D65550: [AArch64] Do not emit '#' before immediates in inline asm.
Thu, Aug 8, 10:50 AM · Restricted Project

Tue, Aug 6

pirama updated the diff for D65550: [AArch64] Do not emit '#' before immediates in inline asm.

Avoid extra variable

Tue, Aug 6, 2:00 PM · Restricted Project
pirama added a comment to D65550: [AArch64] Do not emit '#' before immediates in inline asm.

Thanks Peter. I'll wait for another day for further comments, and if none, will submit this tomorrow morning (pacific time).

Tue, Aug 6, 9:16 AM · Restricted Project

Mon, Aug 5

pirama added a comment to D65550: [AArch64] Do not emit '#' before immediates in inline asm.

This only affects inline asm, it looks like, not general instructions? (I looked briefly, and it looks like instructions go through AArch64InstPrinter::printOperand instead.)

I don't think this would cause any issues off the top of my head, but you might want to run something like an Android build to confirm that.

Mon, Aug 5, 3:38 PM · Restricted Project

Thu, Aug 1

pirama added a comment to D65550: [AArch64] Do not emit '#' before immediates in inline asm.

Thanks for the workaround @peter.smith. I suggested it to the NDK developer as well. The immediate need for this change is gone, but I agree that this is useful for the various reasons you outlined.

Thu, Aug 1, 10:05 AM · Restricted Project

Wed, Jul 31

pirama created D65550: [AArch64] Do not emit '#' before immediates in inline asm.
Wed, Jul 31, 5:45 PM · Restricted Project

Jul 25 2019

pirama committed rG6caa8da072d6: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX (authored by pirama).
[profile] In Android, do not mkdir() dirs in GCOV_PREFIX
Jul 25 2019, 3:13 PM
pirama committed rL367064: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX.
[profile] In Android, do not mkdir() dirs in GCOV_PREFIX
Jul 25 2019, 3:13 PM
pirama closed D65245: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX.
Jul 25 2019, 3:13 PM · Restricted Project, Restricted Project
pirama updated the diff for D65245: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX.

Apply clang-format

Jul 25 2019, 3:09 PM · Restricted Project, Restricted Project
pirama added inline comments to D65245: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX.
Jul 25 2019, 2:29 PM · Restricted Project, Restricted Project
pirama updated the diff for D65245: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX.

Call strlen(gcov_prefix) only if its not null.

Jul 25 2019, 2:29 PM · Restricted Project, Restricted Project
pirama added inline comments to D65245: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX.
Jul 25 2019, 2:16 PM · Restricted Project, Restricted Project
pirama updated the diff for D65245: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX.

Remove stray new line.

Jul 25 2019, 2:16 PM · Restricted Project, Restricted Project
pirama updated the diff for D65245: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX.

Refactored the loop to call getenv just once.

Jul 25 2019, 2:14 PM · Restricted Project, Restricted Project
pirama accepted D65000: [ARM] Set default alignment to 64bits.

LGTM for Android.

Jul 25 2019, 10:21 AM · Restricted Project, Restricted Project

Jul 24 2019

pirama created D65245: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX.
Jul 24 2019, 3:14 PM · Restricted Project, Restricted Project

Jul 1 2019

pirama added inline comments to D63889: Check possible warnings on global initializers for reachability.
Jul 1 2019, 10:30 AM · Restricted Project

Jun 25 2019

pirama committed rG7803eac24f3e: [llvm-shlib] Do not use version script when building with MinGW (authored by pirama).
[llvm-shlib] Do not use version script when building with MinGW
Jun 25 2019, 12:36 PM
pirama committed rL364343: [llvm-shlib] Do not use version script when building with MinGW.
[llvm-shlib] Do not use version script when building with MinGW
Jun 25 2019, 12:35 PM
pirama closed D63743: [llvm-shlib] Do not use version script when building with MinGW.
Jun 25 2019, 12:35 PM · Restricted Project
pirama retitled D63743: [llvm-shlib] Do not use version script when building with MinGW from [llvm-shlib] Do not use version script when building with MinGW and LLD to [llvm-shlib] Do not use version script when building with MinGW.
Jun 25 2019, 11:01 AM · Restricted Project
pirama updated the diff for D63743: [llvm-shlib] Do not use version script when building with MinGW.

Skip version script for all MinGW builds, not just when using lld.

Jun 25 2019, 11:01 AM · Restricted Project

Jun 24 2019

pirama added a comment to D63743: [llvm-shlib] Do not use version script when building with MinGW.

I'd suggest skipping the lld condition, the version script adds no value here.

For ELF, version scripts do two things, select what symbols to export using glob pattetns, and set symbol versions on them.

As COFF doesn't have symbol versions, all it does on mingw with GNU ld, is filtering symbols, to export *. So it adds no value there.

Jun 24 2019, 10:40 PM · Restricted Project
pirama created D63743: [llvm-shlib] Do not use version script when building with MinGW.
Jun 24 2019, 3:56 PM · Restricted Project

Mar 27 2019

pirama accepted D53343: [Driver] Default Android toolchains to noexecstack..
Mar 27 2019, 4:44 PM · Restricted Project

Feb 20 2019

pirama accepted D58477: [Driver] Fix float ABI default for Android ARMv8..
Feb 20 2019, 4:14 PM · Restricted Project, Restricted Project

Feb 13 2019

Herald added a project to D56720: [MemorySSA] Add caching results of reaching LiveOnEntry MemoryDef to ClobberWalker: Restricted Project.
Feb 13 2019, 4:51 PM · Restricted Project

Feb 12 2019

pirama accepted D58153: [Driver] Default all Android ARM targets to NEON..
Feb 12 2019, 3:29 PM · Restricted Project, Restricted Project

Jan 11 2019

pirama committed rL350951: [Legalizer] Use correct ValueType of SELECT_CC node during Float promotion.
[Legalizer] Use correct ValueType of SELECT_CC node during Float promotion
Jan 11 2019, 10:50 AM
pirama closed D56566: [Legalizer] Use correct ValueType of SELECT_CC node during Float promotion.
Jan 11 2019, 10:50 AM

Jan 10 2019

pirama created D56566: [Legalizer] Use correct ValueType of SELECT_CC node during Float promotion.
Jan 10 2019, 3:52 PM

Dec 18 2018

pirama accepted D55856: [Driver] Also obey -nostdlib++ when rewriting -lstdc++..
Dec 18 2018, 3:06 PM
pirama added inline comments to D55856: [Driver] Also obey -nostdlib++ when rewriting -lstdc++..
Dec 18 2018, 3:06 PM

Dec 3 2018

pirama added inline comments to D55237: LTO: Don't internalize available_externally globals..
Dec 3 2018, 3:33 PM

Nov 29 2018

pirama added a comment to D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.

Hi @piramam,

This change is breaking the Linux ThinLTO build. I'll work to get you a test case. Could you revert this patch until we can resolve the issue?

Nov 29 2018, 5:48 PM

Nov 15 2018

pirama added a comment to D52025: [TargetLowering] Android has sincos functions.

Someone just pointed out to me that even in Android P [1], libm's sincos() just called sin() followed by cos() so this optimization won't be beneficial. It was changed in March 2018 [2] but is not a part of any release yet.

Nov 15 2018, 1:26 PM

Nov 8 2018

pirama committed rL346436: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.
[LTO] Drop non-prevailing definitions only if linkage is not local or appending
Nov 8 2018, 12:12 PM
pirama closed D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.
Nov 8 2018, 12:12 PM
pirama retitled D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending from [LTO] Drop non-prevailing definitions for non-local linkage types to [LTO] Drop non-prevailing definitions only if linkage is not local or appending.
Nov 8 2018, 11:10 AM
pirama added a comment to D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.

From the summary,

"In ELF, symbols non-weak symbols"

The first "symbols" seems extraneous?

Nov 8 2018, 11:09 AM
pirama added a comment to D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.

Thanks for the review Teresa. I'm running the tests again after a rebase and will commit this after the tests pass.

Nov 8 2018, 11:06 AM
pirama updated the diff for D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.

Fix a few more comments.

Nov 8 2018, 11:06 AM
pirama updated the diff for D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.

Update based on review comments. Hopefully I did the WeakForLinker->Prevailing
name changes in all the right places.

Nov 8 2018, 12:06 AM

Nov 7 2018

pirama added inline comments to D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.
Nov 7 2018, 11:26 AM

Nov 6 2018

pirama added inline comments to D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.
Nov 6 2018, 10:15 PM
pirama added inline comments to D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.
Nov 6 2018, 2:15 PM
pirama updated the diff for D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.

Rename thinLTOResolveWeakForLinker* to thinLTOResolvePrevailing*

Nov 6 2018, 2:10 PM
pirama added inline comments to D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.
Nov 6 2018, 9:24 AM

Nov 5 2018

pirama updated the diff for D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.

Fix commit message.

Nov 5 2018, 4:08 PM
pirama created D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.
Nov 5 2018, 2:53 PM

Oct 29 2018

pirama edited reviewers for D53850: Declares __cpu_model as dso local, added: echristo, craig.topper; removed: pirama.

Adding reviewers suggested by 'arc cover'.

Oct 29 2018, 5:05 PM

Sep 21 2018

pirama committed rCXXA342764: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32.
[libc++abi] is_strcmp parameter to is_equal is unused for WIN32
Sep 21 2018, 1:08 PM
pirama committed rL342764: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32.
[libc++abi] is_strcmp parameter to is_equal is unused for WIN32
Sep 21 2018, 1:02 PM
pirama closed D52368: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32.
Sep 21 2018, 1:02 PM
pirama updated the diff for D52368: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32.

Simplify patch.

Sep 21 2018, 11:55 AM
pirama created D52368: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32.
Sep 21 2018, 10:31 AM
pirama abandoned D48742: Set _LIBCPP_TLS_DESTRUCTOR_CC convention to run_dtors.

This file is not built for WIN32.

Sep 21 2018, 12:22 AM

Sep 14 2018

pirama accepted D52025: [TargetLowering] Android has sincos functions.
Sep 14 2018, 10:00 AM

Sep 12 2018

pirama added a comment to D50359: Add a new library, libclang-cxx.

As I mentioned in the discussion, we decided to carry build rules for the proposed library in downstream. I've updated this to make it more general, and will leave it open in case there's more interest to revive it in the future.

Sep 12 2018, 11:00 AM
pirama updated the diff for D50359: Add a new library, libclang-cxx.

Add empty source file to silence CMake warning.
Support more platforms, similar to libLLVM.so

Sep 12 2018, 10:53 AM

Aug 22 2018

pirama committed rC340424: [Android] Default to -fno-math-errno.
[Android] Default to -fno-math-errno
Aug 22 2018, 10:44 AM
pirama committed rL340424: [Android] Default to -fno-math-errno.
[Android] Default to -fno-math-errno
Aug 22 2018, 10:44 AM
pirama closed D51068: [Android] Default to -fno-math-errno.
Aug 22 2018, 10:44 AM

Aug 21 2018

pirama added inline comments to D51068: [Android] Default to -fno-math-errno.
Aug 21 2018, 3:32 PM
pirama created D51068: [Android] Default to -fno-math-errno.
Aug 21 2018, 3:30 PM

Aug 20 2018

pirama abandoned D50683: [Android] Set NewAlign for 64-bit Android to 8 bytes.

Thanks for the clarification Richard and Eli. I agree that leaving the status quo will match the intent of the macro. I'll abandon this.

Aug 20 2018, 11:04 AM

Aug 13 2018

pirama created D50683: [Android] Set NewAlign for 64-bit Android to 8 bytes.
Aug 13 2018, 5:53 PM

Aug 8 2018

pirama added inline comments to D50467: [SEMA] add more -Wfloat-conversion to compound assigment analysis.
Aug 8 2018, 3:30 PM
pirama committed rL339284: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL.
[Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL
Aug 8 2018, 1:39 PM
pirama committed rC339284: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL.
[Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL
Aug 8 2018, 1:39 PM
pirama closed D37302: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL.
Aug 8 2018, 1:39 PM

Aug 6 2018

pirama added a comment to D50359: Add a new library, libclang-cxx.

This implements the new library proposed in http://lists.llvm.org/pipermail/cfe-dev/2018-August/058736.html.

Aug 6 2018, 1:51 PM
pirama created D50359: Add a new library, libclang-cxx.
Aug 6 2018, 1:50 PM
pirama added a comment to D37302: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL.

Sorry this fell of my radar. I've rebased the patch.

Aug 6 2018, 10:14 AM
pirama updated the diff for D37302: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL.

Rebase

Aug 6 2018, 10:12 AM

Aug 2 2018

pirama added a comment to D50199: [MinGW] Predefine UNICODE if -municode is specified during compilation.
In D50199#1186164, @rnk wrote:

Does this do anything other than -DUNICODE? Maybe just translate it at the driver level and skip the -cc1 flag?

Aug 2 2018, 1:58 PM

Aug 1 2018

pirama committed rL338603: [Android] Increase default new alignment for Android.
[Android] Increase default new alignment for Android
Aug 1 2018, 10:56 AM
pirama committed rC338603: [Android] Increase default new alignment for Android.
[Android] Increase default new alignment for Android
Aug 1 2018, 10:56 AM
pirama closed D50112: [Android] Increase default new alignment for Android.
Aug 1 2018, 10:56 AM

Jul 31 2018

pirama created D50112: [Android] Increase default new alignment for Android.
Jul 31 2018, 3:16 PM

Jul 20 2018

pirama added a comment to D48742: Set _LIBCPP_TLS_DESTRUCTOR_CC convention to run_dtors.

Ping...

Jul 20 2018, 3:53 PM
pirama added a comment to D48743: Make pthread's __libcpp_get_tls declaration consistent.

Ping...

Jul 20 2018, 3:53 PM

Jul 9 2018

pirama added a comment to D44532: Add option to disable linking of libcxx into fuzzer.

Can you elaborate on the further issues with cross-compiling libcxx without a libcxxabi you mentioned in your commit message? I'd like to improve the build to handle all cases.

The built libcxx had references to some symbols from libcxxabi (__cxa_guard_acquire, I think). I'll reproduce the error tomorrow and report back.

Jul 9 2018, 10:19 AM

Jul 2 2018

pirama committed rL336141: [Win32] Overload ==, != for locale_t and long long.
[Win32] Overload ==, != for locale_t and long long
Jul 2 2018, 1:16 PM
pirama committed rCXX336141: [Win32] Overload ==, != for locale_t and long long.
[Win32] Overload ==, != for locale_t and long long
Jul 2 2018, 1:16 PM
pirama closed D48749: [Win32] Overload ==, != for locale_t and long long.
Jul 2 2018, 1:16 PM

Jun 28 2018

pirama created D48749: [Win32] Overload ==, != for locale_t and long long.
Jun 28 2018, 2:56 PM
pirama created D48743: Make pthread's __libcpp_get_tls declaration consistent.
Jun 28 2018, 2:32 PM
pirama created D48742: Set _LIBCPP_TLS_DESTRUCTOR_CC convention to run_dtors.
Jun 28 2018, 2:32 PM
pirama committed rL335916: Configure ELAST for MinGW.
Configure ELAST for MinGW
Jun 28 2018, 1:21 PM
pirama committed rCXX335916: Configure ELAST for MinGW.
Configure ELAST for MinGW
Jun 28 2018, 1:21 PM
pirama closed D48731: Configure ELAST for MinGW.
Jun 28 2018, 1:21 PM
pirama created D48731: Configure ELAST for MinGW.
Jun 28 2018, 10:46 AM

Jun 22 2018

pirama added a comment to D48402: [mingw] Fix GCC ABI compatibility for comdat things.
In D48402#1140046, @rnk wrote:

Sections:
....

3 .text$___Z3fooi 00000013  00000000  00000000  0000012c  2**4
               CONTENTS, ALLOC, LOAD, RELOC, READONLY, CODE, LINK_ONCE_DISCARD
Could that explain the difference?

Woops, one too many calls to getNameWithPrefix.

Jun 22 2018, 11:48 AM

Jun 21 2018

pirama added a comment to D48402: [mingw] Fix GCC ABI compatibility for comdat things.

Reid, thanks a lot for addressing this issue.

Jun 21 2018, 3:32 PM

Apr 2 2018

pirama accepted D45145: [Driver] Wire up the -f[no-]rtlib-add-rpath flag and tests.
Apr 2 2018, 1:17 PM
pirama added a comment to D45145: [Driver] Wire up the -f[no-]rtlib-add-rpath flag and tests.

Hi Petr, thanks for the fix (I dropped the ball on this one :( ). Instead of duplicating the checks, does it make sense to fold check into addArchSpecificRPath and rename it to 'addArchSpecificRPathIfRequested' or something similar?

Apr 2 2018, 11:07 AM