Page MenuHomePhabricator

pirama (Pirama Arumuga Nainar)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 16 2015, 3:52 PM (325 w, 4 d)

Recent Activity

Fri, May 21

pirama abandoned D102790: [compiler-rt/profile] register __llvm_profile_write_file to run during quick_exit..

Looks like quick_exit + dlclose interaction is not well-defined and this change may cause calls into dlclose-d libraries.

Fri, May 21, 10:43 AM · Restricted Project

Wed, May 19

pirama added inline comments to D102790: [compiler-rt/profile] register __llvm_profile_write_file to run during quick_exit..
Wed, May 19, 2:55 PM · Restricted Project
pirama requested review of D102790: [compiler-rt/profile] register __llvm_profile_write_file to run during quick_exit..
Wed, May 19, 11:15 AM · Restricted Project
pirama updated subscribers of rGe4274cfe06fe: [CoverageMapping] Handle gaps in counter IDs for source-based coverage.

Thanks for the review @vsk and @richkadel for the details about Rust coverage instrumentation.

Wed, May 19, 10:48 AM
pirama committed rGe4274cfe06fe: [CoverageMapping] Handle gaps in counter IDs for source-based coverage (authored by pirama).
[CoverageMapping] Handle gaps in counter IDs for source-based coverage
Wed, May 19, 10:47 AM
pirama closed D101780: [CoverageMapping] Handle gaps in counter IDs for source-based coverage.
Wed, May 19, 10:46 AM · Restricted Project

Mon, May 17

pirama added a comment to D101780: [CoverageMapping] Handle gaps in counter IDs for source-based coverage.

Thanks for the detail about the edge counters @richkadel.

Mon, May 17, 3:11 PM · Restricted Project
pirama updated the diff for D101780: [CoverageMapping] Handle gaps in counter IDs for source-based coverage.

Tighten and reword test. Also fix lint suggestion.

Mon, May 17, 3:09 PM · Restricted Project

May 11 2021

pirama added a comment to D101780: [CoverageMapping] Handle gaps in counter IDs for source-based coverage.

Do we need counters on edges if we're only interested in line segment coverage?

Edge counters exist so they can be operands in expressions, and since they don't have a code region, they would not be referenced directly by a code region in a report; but the expression might, and that's we we need them.

May 11 2021, 3:17 PM · Restricted Project
pirama added a comment to D101780: [CoverageMapping] Handle gaps in counter IDs for source-based coverage.

@vsk - Also, I want to confirm that it is OK to have counters that are incremented (via instrprof.increment intrinsic) that are not associated with a code region.

May 11 2021, 2:25 PM · Restricted Project
pirama committed rG0fd0a010a1ed: [git-clang-format] Do not apply clang-format to symlinks (authored by pirama).
[git-clang-format] Do not apply clang-format to symlinks
May 11 2021, 10:35 AM
pirama closed D101878: [git-clang-format] Do not apply clang-format to symlinks.
May 11 2021, 10:35 AM · Restricted Project, Restricted Project

May 10 2021

pirama updated subscribers of D102179: [Demangle][Rust] Parse integer constants.

@tmiasko Thanks for adding this support to llvm. We're already using your work in Android. Can you comment on the status of this support? For e.g., I see that the following name is not demangled:

May 10 2021, 3:24 PM · Restricted Project
pirama updated subscribers of D101780: [CoverageMapping] Handle gaps in counter IDs for source-based coverage.

Thanks for digging into this. Could you explain why it's necessary to use more coverage counters than there are regions? If there's no longer a reserved counter (counter #0), then are counters N >= Regions.size() somehow redundant (and if so, are they worth deduplicating in the Rust FE)?

May 10 2021, 12:11 PM · Restricted Project

May 5 2021

pirama updated the diff for D101878: [git-clang-format] Do not apply clang-format to symlinks.

Add release note

May 5 2021, 2:28 PM · Restricted Project, Restricted Project
pirama added a comment to D101878: [git-clang-format] Do not apply clang-format to symlinks.

LGTM but let's wait a day or two before landing, so that others can chime in.
Btw, do you have commit rights? If no, please provide "Name <email>" for commit attribution.

May 5 2021, 1:57 PM · Restricted Project, Restricted Project
pirama added inline comments to D101878: [git-clang-format] Do not apply clang-format to symlinks.
May 5 2021, 1:42 PM · Restricted Project, Restricted Project
pirama updated the diff for D101878: [git-clang-format] Do not apply clang-format to symlinks.

Remove debug print().

May 5 2021, 1:41 PM · Restricted Project, Restricted Project

May 4 2021

pirama updated the diff for D101878: [git-clang-format] Do not apply clang-format to symlinks.

Leave two empty lines after filter_symlinks.

May 4 2021, 5:59 PM · Restricted Project, Restricted Project
pirama requested review of D101878: [git-clang-format] Do not apply clang-format to symlinks.
May 4 2021, 5:57 PM · Restricted Project, Restricted Project

May 3 2021

pirama requested review of D101780: [CoverageMapping] Handle gaps in counter IDs for source-based coverage.
May 3 2021, 12:21 PM · Restricted Project

Apr 12 2021

pirama committed rG5d214238a15c: [compiler-rt][aarch64] Add PAC-RET/BTI property to hwasan_interceptors_vfork.S (authored by pirama).
[compiler-rt][aarch64] Add PAC-RET/BTI property to hwasan_interceptors_vfork.S
Apr 12 2021, 5:35 PM
pirama closed D100354: [compiler-rt][aarch64] Add PAC-RET/BTI property to hwasan_interceptors_vfork.S.
Apr 12 2021, 5:35 PM · Restricted Project
pirama requested review of D100354: [compiler-rt][aarch64] Add PAC-RET/BTI property to hwasan_interceptors_vfork.S.
Apr 12 2021, 5:17 PM · Restricted Project

Mar 8 2021

pirama added inline comments to D98084: Revert "[llvm-cov] reset executation count to 0 after wrapped segment".
Mar 8 2021, 9:26 AM · Restricted Project

Feb 5 2021

pirama added a comment to D95987: [llvm-cov] Reset ExecutionCount only if first line segment is start of a new region..

For the example you provided, I am not sure if it's a bug or not. Segment at 3:45 (count = 0), RegionEntry corresponds to the error path of the ? operator, which means error path is not executed. So, the 0 count looks reasonable. If we mark line 3 as executed regardless of which path is chosen, we may lost the information of path choices.

I just realized that this also applies to C++ ? operator. In the following case, if we always mark line 5 as executed, we don't know which branch is chosen (But when generating html report by llvm-cov, we will see that the not executed branch is marked with red color).

Feb 5 2021, 11:25 AM · Restricted Project, Restricted Project

Feb 3 2021

pirama updated subscribers of D95987: [llvm-cov] Reset ExecutionCount only if first line segment is start of a new region..

Thanks for the patch Zequan. This fixes the C++ test case that prompted this issue.

Feb 3 2021, 10:53 PM · Restricted Project, Restricted Project

Nov 10 2020

pirama committed rG8262e94a6da7: [ARM] Fix PR 47980: Use constrainRegClass during foldImmediate opt. (authored by pirama).
[ARM] Fix PR 47980: Use constrainRegClass during foldImmediate opt.
Nov 10 2020, 1:41 PM
pirama closed D91192: [ARM] Fix PR 47980: Use constrainRegClass during foldImmediate opt..
Nov 10 2020, 1:40 PM · Restricted Project
pirama updated the diff for D91192: [ARM] Fix PR 47980: Use constrainRegClass during foldImmediate opt..

Added CHECK line for TCRETURNri

Nov 10 2020, 12:47 PM · Restricted Project
pirama requested review of D91192: [ARM] Fix PR 47980: Use constrainRegClass during foldImmediate opt..
Nov 10 2020, 11:33 AM · Restricted Project
pirama added inline comments to D90591: [ARM] Introduce t2DoLoopStartTP.
Nov 10 2020, 11:27 AM · Restricted Project

Apr 13 2020

pirama added a comment to D78033: [cmake] Restrict symbols exported from libclang-cpp.

I think this has some unintended consequences. If your tool wants to use libLLVM and libClang you really need libClang to be linked against libLLVM, otherwise you're actually just hiding the problem.

Apr 13 2020, 11:57 PM · Restricted Project
pirama created D78033: [cmake] Restrict symbols exported from libclang-cpp.
Apr 13 2020, 10:11 AM · Restricted Project

Mar 20 2020

pirama committed rGfe5599eac6a5: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs (authored by pirama).
[llvm-ar] Use target triple to deduce archive kind for bitcode inputs
Mar 20 2020, 1:35 PM
pirama closed D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.
Mar 20 2020, 1:35 PM · Restricted Project
pirama added a comment to D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.

Merged. Thanks for the review @MaskRay.

Mar 20 2020, 1:34 PM · Restricted Project
pirama updated the diff for D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.

Cleanup based on review comments.

Mar 20 2020, 12:28 PM · Restricted Project
pirama updated the diff for D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.

Use isOSDarwin() instead of isOSBinFormatMachO()

Mar 20 2020, 11:23 AM · Restricted Project
pirama added inline comments to D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.
Mar 20 2020, 10:52 AM · Restricted Project
pirama updated the diff for D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.

Treat any bitode with non-Darwin triple as GNU.
Test cleanup.

Mar 20 2020, 10:49 AM · Restricted Project
pirama updated the diff for D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.

Use K_GNU for all ELF targets.

Mar 20 2020, 10:49 AM · Restricted Project
pirama updated the diff for D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.

Simplify test.

Mar 20 2020, 10:17 AM · Restricted Project
pirama committed rGedcfb47ff6d5: [DAGCombiner] Do not fold truncate(build_vector(..)) if it creates an illegal… (authored by pirama).
[DAGCombiner] Do not fold truncate(build_vector(..)) if it creates an illegal…
Mar 20 2020, 9:45 AM
pirama closed D76312: [DAGCombiner] Do not fold truncate(build_vector(..)) if it creates an illegal type.
Mar 20 2020, 9:45 AM · Restricted Project

Mar 19 2020

pirama added a comment to D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.
Mar 19 2020, 9:54 PM · Restricted Project
pirama updated the diff for D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.

Apply clang-format.

Mar 19 2020, 9:54 PM · Restricted Project
pirama added a comment to D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.

https://llvm.org/doxygen/classllvm_1_1object_1_1Archive.html#ab288378fa8bfa0678dd25e36b5198a87. I think this regresses behavior for those other hosts.

*BSD may need the __.SYMDEF format.

Have you considered passing an explicit --format= via something like ARFLAGS?

Mar 19 2020, 6:41 PM · Restricted Project
pirama updated the diff for D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.

Handle bitcode inputs with BSD target triple.

Mar 19 2020, 6:39 PM · Restricted Project
pirama created D76461: [llvm-ar] Use target triple to deduce archive kind for bitcode inputs.
Mar 19 2020, 4:27 PM · Restricted Project

Mar 18 2020

pirama updated the diff for D76312: [DAGCombiner] Do not fold truncate(build_vector(..)) if it creates an illegal type.

Cleanup test.

Mar 18 2020, 3:46 PM · Restricted Project

Mar 17 2020

pirama created D76312: [DAGCombiner] Do not fold truncate(build_vector(..)) if it creates an illegal type.
Mar 17 2020, 12:23 PM · Restricted Project

Dec 2 2019

pirama updated subscribers of D64045: [InstrProfiling] Put instrumentation into comdat group with function.
Dec 2 2019, 5:07 PM · Restricted Project

Nov 19 2019

pirama added a comment to D65550: [AArch64] Do not emit '#' before immediates in inline asm.
In D65550#1752082, @vsk wrote:

Thanks Nick & Eli, '-fno-integrated-as' does the trick, as does changing the makefile. If the effect of this patch on the asm writer is intentional/correct, we can just push for a project change instead of fiddling with the compiler.

Nov 19 2019, 2:24 PM · Restricted Project

Oct 7 2019

pirama closed D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.
Oct 7 2019, 3:33 AM · Restricted Project

Sep 11 2019

pirama committed rG8b46544641ef: [IRMover] Don't map globals if their types are the same (authored by pirama).
[IRMover] Don't map globals if their types are the same
Sep 11 2019, 11:35 AM
pirama committed rL371643: [IRMover] Don't map globals if their types are the same.
[IRMover] Don't map globals if their types are the same
Sep 11 2019, 11:35 AM
pirama closed D66814: [IRMover] Don't map globals if their types are the same.
Sep 11 2019, 11:35 AM · Restricted Project
pirama updated the summary of D66814: [IRMover] Don't map globals if their types are the same.
Sep 11 2019, 11:06 AM · Restricted Project
pirama updated the diff for D66814: [IRMover] Don't map globals if their types are the same.
  • Do not have a declaration as a prevailing symbol in llvm-lto2's arguments
  • Fix comments in test
Sep 11 2019, 11:06 AM · Restricted Project
pirama added a comment to D66814: [IRMover] Don't map globals if their types are the same.

(note the summary description of the patch needs to be adjusted similarly, it still refers to the summary).

Sep 11 2019, 11:06 AM · Restricted Project
pirama added a comment to D66814: [IRMover] Don't map globals if their types are the same.

@tejohnson Did my reply about shared metadata clarify your question?

Sep 11 2019, 10:00 AM · Restricted Project

Sep 9 2019

pirama committed rGff49a52cf3dd: [Driver] Handle default case in refactored addOpenMPRuntime (authored by pirama).
[Driver] Handle default case in refactored addOpenMPRuntime
Sep 9 2019, 12:53 PM
pirama committed rL371444: [Driver] Handle default case in refactored addOpenMPRuntime.
[Driver] Handle default case in refactored addOpenMPRuntime
Sep 9 2019, 12:52 PM
pirama closed D67364: [Driver] Handle default case in refactored addOpenMPRuntime.
Sep 9 2019, 12:52 PM · Restricted Project, Restricted Project
pirama updated the diff for D67364: [Driver] Handle default case in refactored addOpenMPRuntime.

Check for OMPRT_Unknown instead of a default case.

Sep 9 2019, 12:47 PM · Restricted Project, Restricted Project
pirama created D67364: [Driver] Handle default case in refactored addOpenMPRuntime.
Sep 9 2019, 12:41 PM · Restricted Project, Restricted Project
pirama committed rGd60ff75b562b: [Driver] Add -static-openmp driver option (authored by pirama).
[Driver] Add -static-openmp driver option
Sep 9 2019, 11:33 AM
pirama committed rL371437: [Driver] Add -static-openmp driver option.
[Driver] Add -static-openmp driver option
Sep 9 2019, 11:30 AM
pirama closed D67200: Add -static-openmp driver option.
Sep 9 2019, 11:30 AM · Restricted Project, Restricted Project

Sep 6 2019

pirama updated the diff for D67200: Add -static-openmp driver option.

Test -static, -static-openmp interaction. Added these only for iomp5 to avoid test-case explosion.

Sep 6 2019, 4:27 PM · Restricted Project, Restricted Project
pirama added a comment to D67200: Add -static-openmp driver option.

I'll update this review addressing @joerg's reply to cfe-commits:

Needs testing for the -static interaction?

Sep 6 2019, 3:51 PM · Restricted Project, Restricted Project
pirama updated the summary of D67200: Add -static-openmp driver option.
Sep 6 2019, 2:53 PM · Restricted Project, Restricted Project
pirama added a comment to D67200: Add -static-openmp driver option.

Looks really nice. I am sure the NDK developers will be happy to see support for static OpenMP. Do you want to add the public NDK github issue link in the commit message?

Sep 6 2019, 2:52 PM · Restricted Project, Restricted Project
pirama updated the diff for D67200: Add -static-openmp driver option.

Mention NDK issue https://github.com/android-ndk/ndk/issues/1028.

Sep 6 2019, 2:50 PM · Restricted Project, Restricted Project

Sep 5 2019

pirama added a comment to D53238: [Driver] Add -static= to unify -static-{libgcc,libstdc++}.

Does this regress from existing behavior for unused argument warnings? Currently, -static-libstdc++ -nostdlib issues an unused argument warning for -static-libstdc++, while AFAICT -static=c++stdlib -nostdlib doesn't.

Sep 5 2019, 9:49 PM · Restricted Project
pirama updated the diff for D67200: Add -static-openmp driver option.

Change parameter name.

Sep 5 2019, 4:35 PM · Restricted Project, Restricted Project
pirama updated the diff for D67200: Add -static-openmp driver option.

Supported this flag for NetBSD and FreeBSD as well.

Sep 5 2019, 11:16 AM · Restricted Project, Restricted Project

Sep 4 2019

pirama committed rL371012: Request commit access for pirama.
Request commit access for pirama
Sep 4 2019, 8:59 PM
pirama created D67200: Add -static-openmp driver option.
Sep 4 2019, 4:28 PM · Restricted Project, Restricted Project
pirama added inline comments to D66814: [IRMover] Don't map globals if their types are the same.
Sep 4 2019, 2:06 PM · Restricted Project
pirama updated the diff for D66814: [IRMover] Don't map globals if their types are the same.

Update/clean-up comments in the test.

Sep 4 2019, 2:04 PM · Restricted Project

Aug 28 2019

pirama committed rG19205abaaa3e: [ValueMapper] NFC: Remove dead code to pause metadata mapping (authored by pirama).
[ValueMapper] NFC: Remove dead code to pause metadata mapping
Aug 28 2019, 10:43 AM
pirama committed rL370236: [ValueMapper] NFC: Remove dead code to pause metadata mapping.
[ValueMapper] NFC: Remove dead code to pause metadata mapping
Aug 28 2019, 10:42 AM
pirama closed D66860: [ValueMapper] NFC: Remove dead code to pause metadata mapping.
Aug 28 2019, 10:42 AM · Restricted Project

Aug 27 2019

pirama added inline comments to D66814: [IRMover] Don't map globals if their types are the same.
Aug 27 2019, 8:42 PM · Restricted Project
pirama created D66860: [ValueMapper] NFC: Remove dead code to pause metadata mapping.
Aug 27 2019, 7:14 PM · Restricted Project
pirama added inline comments to D66814: [IRMover] Don't map globals if their types are the same.
Aug 27 2019, 2:28 PM · Restricted Project
pirama updated the diff for D66814: [IRMover] Don't map globals if their types are the same.

Fix typo reffers -> refers

Aug 27 2019, 2:28 PM · Restricted Project
pirama created D66814: [IRMover] Don't map globals if their types are the same.
Aug 27 2019, 11:15 AM · Restricted Project

Aug 8 2019

pirama committed rG0cb2a33dfd3e: [AArch64] Do not emit '#' before immediates in inline asm (authored by pirama).
[AArch64] Do not emit '#' before immediates in inline asm
Aug 8 2019, 10:51 AM
pirama committed rL368320: [AArch64] Do not emit '#' before immediates in inline asm.
[AArch64] Do not emit '#' before immediates in inline asm
Aug 8 2019, 10:50 AM
pirama closed D65550: [AArch64] Do not emit '#' before immediates in inline asm.
Aug 8 2019, 10:50 AM · Restricted Project

Aug 6 2019

pirama updated the diff for D65550: [AArch64] Do not emit '#' before immediates in inline asm.

Avoid extra variable

Aug 6 2019, 2:00 PM · Restricted Project
pirama added a comment to D65550: [AArch64] Do not emit '#' before immediates in inline asm.

Thanks Peter. I'll wait for another day for further comments, and if none, will submit this tomorrow morning (pacific time).

Aug 6 2019, 9:16 AM · Restricted Project

Aug 5 2019

pirama added a comment to D65550: [AArch64] Do not emit '#' before immediates in inline asm.

This only affects inline asm, it looks like, not general instructions? (I looked briefly, and it looks like instructions go through AArch64InstPrinter::printOperand instead.)

I don't think this would cause any issues off the top of my head, but you might want to run something like an Android build to confirm that.

Aug 5 2019, 3:38 PM · Restricted Project

Aug 1 2019

pirama added a comment to D65550: [AArch64] Do not emit '#' before immediates in inline asm.

Thanks for the workaround @peter.smith. I suggested it to the NDK developer as well. The immediate need for this change is gone, but I agree that this is useful for the various reasons you outlined.

Aug 1 2019, 10:05 AM · Restricted Project

Jul 31 2019

pirama created D65550: [AArch64] Do not emit '#' before immediates in inline asm.
Jul 31 2019, 5:45 PM · Restricted Project

Jul 25 2019

pirama committed rG6caa8da072d6: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX (authored by pirama).
[profile] In Android, do not mkdir() dirs in GCOV_PREFIX
Jul 25 2019, 3:13 PM
pirama committed rL367064: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX.
[profile] In Android, do not mkdir() dirs in GCOV_PREFIX
Jul 25 2019, 3:13 PM