- User Since
- Mar 16 2015, 3:52 PM (381 w, 2 d)
Thu, Jun 30
To close the loop here, we were able to fix the build rules in Android without needing this flag.
Wed, Jun 15
Mar 9 2022
My local ninja check-sanitizer passed but the automated build has failed: https://reviews.llvm.org/B153417. Let me do a ninja check-all and fix.
Looks like all comments are addressed. I'll merge after a quick ninja check.
Mar 4 2022
Feb 17 2022
Unrelated to missing resolver definition, this change doesn't accommodate resolvers that take parameters. (Curiously, this verification only fails with ThinLTO).
Feb 9 2022
Feb 8 2022
@ccross is building musl runtimes for Android host tools and we seem to need the following diff. The SANITIZER_LINUX && !SANITIZER_GLIBC idiom may not apply everywhere since it'd include Android as well. @vchuravy @MaskRay any thoughts? We could also consider an explicit CMake variable similar to _LIBCPP_HAS_MUSL_LIBC.
Feb 4 2022
@alxu Just realized you don't have commit access. Do you want one of us to merge this?
Jan 19 2022
Jan 10 2022
Jan 6 2022
Thanks for the cleanup here.
Nov 30 2021
Nov 23 2021
Nov 16 2021
reword commit message.
Will defer to Dan's review. I think these changes are safe for the Android platform (where we only use lld). The NDK only supports lld but that does not preclude external users from using other linkers.
arc diff --verbatim to update phabricator message
Nov 15 2021
Do not hide __llvm_profile_raw_version on Apple platforms.
Oct 27 2021
Oct 21 2021
Oct 20 2021
Oct 15 2021
Describe Android use case.
This is not related to weak attribute to __llvm_profile_raw_version
Oct 14 2021
Apply clang-format linter suggestion.
Oct 13 2021
Remove attribute from reference.
Oct 5 2021
@haowei Can you share instructions to run this exact build? I briefly tried https://fuchsia.googlesource.com/fuchsia/+/refs/heads/main/docs/development/build/toolchain.md but it is different from the failure at https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8834613633802961617/overview, which also seems to set CMAKE_SYSROOT.
Sep 23 2021
Aug 27 2021
- rename file
- append '.s' to split-file output names
Aug 26 2021
Update with review comments.
Aug 23 2021
For the Android problem, it looks like a workaround as well. Do you know why gold linked executables were fine when Android was still using gold?
Aug 20 2021
Aug 18 2021
Aug 13 2021
Aug 12 2021
I still need to add tests but wanted to upload it to get early thoughts on this approach.
Aug 11 2021
Aug 9 2021
Aug 6 2021
Refactor preprocessor check to kmp_config.h.
Address review comments
Aug 5 2021
Update test with revew comments.
Aug 4 2021
Rename test, expand comments and remove '-S -x' from RUN line.
Aug 3 2021
Simplify check and update expected error for one test.
Skip IMAGE_DEBUG_TYPE_UNKNOWN debug entries as well.
Aug 2 2021
Jul 30 2021
I uploaded this as a starter but we should abstract the check to avoid repetition. Is kmp_config.h.cmake or kmp_platform.h a good place for defining a 'KMP_USE_SHMEM' and using it here?
Jul 23 2021
Remove note in comment.
s/CHECK-LTO/CHECK-LTO-NEXT in new-pm-O0-defaults.ll
May 21 2021
Looks like quick_exit + dlclose interaction is not well-defined and this change may cause calls into dlclose-d libraries.