Page MenuHomePhabricator

pirama (Pirama Arumuga Nainar)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 16 2015, 3:52 PM (239 w, 3 d)

Recent Activity

Mon, Oct 7

pirama closed D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.
Mon, Oct 7, 3:33 AM · Restricted Project

Sep 11 2019

pirama committed rG8b46544641ef: [IRMover] Don't map globals if their types are the same (authored by pirama).
[IRMover] Don't map globals if their types are the same
Sep 11 2019, 11:35 AM
pirama committed rL371643: [IRMover] Don't map globals if their types are the same.
[IRMover] Don't map globals if their types are the same
Sep 11 2019, 11:35 AM
pirama closed D66814: [IRMover] Don't map globals if their types are the same.
Sep 11 2019, 11:35 AM · Restricted Project
pirama updated the summary of D66814: [IRMover] Don't map globals if their types are the same.
Sep 11 2019, 11:06 AM · Restricted Project
pirama updated the diff for D66814: [IRMover] Don't map globals if their types are the same.
  • Do not have a declaration as a prevailing symbol in llvm-lto2's arguments
  • Fix comments in test
Sep 11 2019, 11:06 AM · Restricted Project
pirama added a comment to D66814: [IRMover] Don't map globals if their types are the same.

(note the summary description of the patch needs to be adjusted similarly, it still refers to the summary).

Sep 11 2019, 11:06 AM · Restricted Project
pirama added a comment to D66814: [IRMover] Don't map globals if their types are the same.

@tejohnson Did my reply about shared metadata clarify your question?

Sep 11 2019, 10:00 AM · Restricted Project

Sep 9 2019

pirama committed rGff49a52cf3dd: [Driver] Handle default case in refactored addOpenMPRuntime (authored by pirama).
[Driver] Handle default case in refactored addOpenMPRuntime
Sep 9 2019, 12:53 PM
pirama committed rL371444: [Driver] Handle default case in refactored addOpenMPRuntime.
[Driver] Handle default case in refactored addOpenMPRuntime
Sep 9 2019, 12:52 PM
pirama closed D67364: [Driver] Handle default case in refactored addOpenMPRuntime.
Sep 9 2019, 12:52 PM · Restricted Project, Restricted Project
pirama updated the diff for D67364: [Driver] Handle default case in refactored addOpenMPRuntime.

Check for OMPRT_Unknown instead of a default case.

Sep 9 2019, 12:47 PM · Restricted Project, Restricted Project
pirama created D67364: [Driver] Handle default case in refactored addOpenMPRuntime.
Sep 9 2019, 12:41 PM · Restricted Project, Restricted Project
pirama committed rGd60ff75b562b: [Driver] Add -static-openmp driver option (authored by pirama).
[Driver] Add -static-openmp driver option
Sep 9 2019, 11:33 AM
pirama committed rL371437: [Driver] Add -static-openmp driver option.
[Driver] Add -static-openmp driver option
Sep 9 2019, 11:30 AM
pirama closed D67200: Add -static-openmp driver option.
Sep 9 2019, 11:30 AM · Restricted Project, Restricted Project

Sep 6 2019

pirama updated the diff for D67200: Add -static-openmp driver option.

Test -static, -static-openmp interaction. Added these only for iomp5 to avoid test-case explosion.

Sep 6 2019, 4:27 PM · Restricted Project, Restricted Project
pirama added a comment to D67200: Add -static-openmp driver option.

I'll update this review addressing @joerg's reply to cfe-commits:

Needs testing for the -static interaction?

Sep 6 2019, 3:51 PM · Restricted Project, Restricted Project
pirama updated the summary of D67200: Add -static-openmp driver option.
Sep 6 2019, 2:53 PM · Restricted Project, Restricted Project
pirama added a comment to D67200: Add -static-openmp driver option.

Looks really nice. I am sure the NDK developers will be happy to see support for static OpenMP. Do you want to add the public NDK github issue link in the commit message?

Sep 6 2019, 2:52 PM · Restricted Project, Restricted Project
pirama updated the diff for D67200: Add -static-openmp driver option.

Mention NDK issue https://github.com/android-ndk/ndk/issues/1028.

Sep 6 2019, 2:50 PM · Restricted Project, Restricted Project

Sep 5 2019

pirama added a comment to D53238: [Driver] Add -static= to unify -static-{libgcc,libstdc++}.

Does this regress from existing behavior for unused arguments? Currently, -static-libstdc++ -nostdlib issues an unused argument warning for -static-libstdc++, while AFAICT -static=c++stdlib -nostdlib doesn't.

Sep 5 2019, 9:49 PM · Restricted Project
pirama updated the diff for D67200: Add -static-openmp driver option.

Change parameter name.

Sep 5 2019, 4:35 PM · Restricted Project, Restricted Project
pirama updated the diff for D67200: Add -static-openmp driver option.

Supported this flag for NetBSD and FreeBSD as well.

Sep 5 2019, 11:16 AM · Restricted Project, Restricted Project

Sep 4 2019

pirama committed rL371012: Request commit access for pirama.
Request commit access for pirama
Sep 4 2019, 8:59 PM
pirama created D67200: Add -static-openmp driver option.
Sep 4 2019, 4:28 PM · Restricted Project, Restricted Project
pirama added inline comments to D66814: [IRMover] Don't map globals if their types are the same.
Sep 4 2019, 2:06 PM · Restricted Project
pirama updated the diff for D66814: [IRMover] Don't map globals if their types are the same.

Update/clean-up comments in the test.

Sep 4 2019, 2:04 PM · Restricted Project

Aug 28 2019

pirama committed rG19205abaaa3e: [ValueMapper] NFC: Remove dead code to pause metadata mapping (authored by pirama).
[ValueMapper] NFC: Remove dead code to pause metadata mapping
Aug 28 2019, 10:43 AM
pirama committed rL370236: [ValueMapper] NFC: Remove dead code to pause metadata mapping.
[ValueMapper] NFC: Remove dead code to pause metadata mapping
Aug 28 2019, 10:42 AM
pirama closed D66860: [ValueMapper] NFC: Remove dead code to pause metadata mapping.
Aug 28 2019, 10:42 AM · Restricted Project

Aug 27 2019

pirama added inline comments to D66814: [IRMover] Don't map globals if their types are the same.
Aug 27 2019, 8:42 PM · Restricted Project
pirama created D66860: [ValueMapper] NFC: Remove dead code to pause metadata mapping.
Aug 27 2019, 7:14 PM · Restricted Project
pirama added inline comments to D66814: [IRMover] Don't map globals if their types are the same.
Aug 27 2019, 2:28 PM · Restricted Project
pirama updated the diff for D66814: [IRMover] Don't map globals if their types are the same.

Fix typo reffers -> refers

Aug 27 2019, 2:28 PM · Restricted Project
pirama created D66814: [IRMover] Don't map globals if their types are the same.
Aug 27 2019, 11:15 AM · Restricted Project

Aug 8 2019

pirama committed rG0cb2a33dfd3e: [AArch64] Do not emit '#' before immediates in inline asm (authored by pirama).
[AArch64] Do not emit '#' before immediates in inline asm
Aug 8 2019, 10:51 AM
pirama committed rL368320: [AArch64] Do not emit '#' before immediates in inline asm.
[AArch64] Do not emit '#' before immediates in inline asm
Aug 8 2019, 10:50 AM
pirama closed D65550: [AArch64] Do not emit '#' before immediates in inline asm.
Aug 8 2019, 10:50 AM · Restricted Project

Aug 6 2019

pirama updated the diff for D65550: [AArch64] Do not emit '#' before immediates in inline asm.

Avoid extra variable

Aug 6 2019, 2:00 PM · Restricted Project
pirama added a comment to D65550: [AArch64] Do not emit '#' before immediates in inline asm.

Thanks Peter. I'll wait for another day for further comments, and if none, will submit this tomorrow morning (pacific time).

Aug 6 2019, 9:16 AM · Restricted Project

Aug 5 2019

pirama added a comment to D65550: [AArch64] Do not emit '#' before immediates in inline asm.

This only affects inline asm, it looks like, not general instructions? (I looked briefly, and it looks like instructions go through AArch64InstPrinter::printOperand instead.)

I don't think this would cause any issues off the top of my head, but you might want to run something like an Android build to confirm that.

Aug 5 2019, 3:38 PM · Restricted Project

Aug 1 2019

pirama added a comment to D65550: [AArch64] Do not emit '#' before immediates in inline asm.

Thanks for the workaround @peter.smith. I suggested it to the NDK developer as well. The immediate need for this change is gone, but I agree that this is useful for the various reasons you outlined.

Aug 1 2019, 10:05 AM · Restricted Project

Jul 31 2019

pirama created D65550: [AArch64] Do not emit '#' before immediates in inline asm.
Jul 31 2019, 5:45 PM · Restricted Project

Jul 25 2019

pirama committed rG6caa8da072d6: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX (authored by pirama).
[profile] In Android, do not mkdir() dirs in GCOV_PREFIX
Jul 25 2019, 3:13 PM
pirama committed rL367064: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX.
[profile] In Android, do not mkdir() dirs in GCOV_PREFIX
Jul 25 2019, 3:13 PM
pirama closed D65245: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX.
Jul 25 2019, 3:13 PM · Restricted Project, Restricted Project
pirama updated the diff for D65245: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX.

Apply clang-format

Jul 25 2019, 3:09 PM · Restricted Project, Restricted Project
pirama added inline comments to D65245: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX.
Jul 25 2019, 2:29 PM · Restricted Project, Restricted Project
pirama updated the diff for D65245: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX.

Call strlen(gcov_prefix) only if its not null.

Jul 25 2019, 2:29 PM · Restricted Project, Restricted Project
pirama added inline comments to D65245: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX.
Jul 25 2019, 2:16 PM · Restricted Project, Restricted Project
pirama updated the diff for D65245: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX.

Remove stray new line.

Jul 25 2019, 2:16 PM · Restricted Project, Restricted Project
pirama updated the diff for D65245: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX.

Refactored the loop to call getenv just once.

Jul 25 2019, 2:14 PM · Restricted Project, Restricted Project
pirama accepted D65000: [ARM] Set default alignment to 64bits.

LGTM for Android.

Jul 25 2019, 10:21 AM · Restricted Project, Restricted Project

Jul 24 2019

pirama created D65245: [profile] In Android, do not mkdir() dirs in GCOV_PREFIX.
Jul 24 2019, 3:14 PM · Restricted Project, Restricted Project

Jul 1 2019

pirama added inline comments to D63889: Check possible warnings on global initializers for reachability.
Jul 1 2019, 10:30 AM · Restricted Project

Jun 25 2019

pirama committed rG7803eac24f3e: [llvm-shlib] Do not use version script when building with MinGW (authored by pirama).
[llvm-shlib] Do not use version script when building with MinGW
Jun 25 2019, 12:36 PM
pirama committed rL364343: [llvm-shlib] Do not use version script when building with MinGW.
[llvm-shlib] Do not use version script when building with MinGW
Jun 25 2019, 12:35 PM
pirama closed D63743: [llvm-shlib] Do not use version script when building with MinGW.
Jun 25 2019, 12:35 PM · Restricted Project
pirama retitled D63743: [llvm-shlib] Do not use version script when building with MinGW from [llvm-shlib] Do not use version script when building with MinGW and LLD to [llvm-shlib] Do not use version script when building with MinGW.
Jun 25 2019, 11:01 AM · Restricted Project
pirama updated the diff for D63743: [llvm-shlib] Do not use version script when building with MinGW.

Skip version script for all MinGW builds, not just when using lld.

Jun 25 2019, 11:01 AM · Restricted Project

Jun 24 2019

pirama added a comment to D63743: [llvm-shlib] Do not use version script when building with MinGW.

I'd suggest skipping the lld condition, the version script adds no value here.

For ELF, version scripts do two things, select what symbols to export using glob pattetns, and set symbol versions on them.

As COFF doesn't have symbol versions, all it does on mingw with GNU ld, is filtering symbols, to export *. So it adds no value there.

Jun 24 2019, 10:40 PM · Restricted Project
pirama created D63743: [llvm-shlib] Do not use version script when building with MinGW.
Jun 24 2019, 3:56 PM · Restricted Project

Mar 27 2019

pirama accepted D53343: [Driver] Default Android toolchains to noexecstack..
Mar 27 2019, 4:44 PM · Restricted Project

Feb 20 2019

pirama accepted D58477: [Driver] Fix float ABI default for Android ARMv8..
Feb 20 2019, 4:14 PM · Restricted Project, Restricted Project

Feb 13 2019

Herald added a project to D56720: [MemorySSA] Add caching results of reaching LiveOnEntry MemoryDef to ClobberWalker: Restricted Project.
Feb 13 2019, 4:51 PM · Restricted Project

Feb 12 2019

pirama accepted D58153: [Driver] Default all Android ARM targets to NEON..
Feb 12 2019, 3:29 PM · Restricted Project, Restricted Project

Jan 11 2019

pirama committed rL350951: [Legalizer] Use correct ValueType of SELECT_CC node during Float promotion.
[Legalizer] Use correct ValueType of SELECT_CC node during Float promotion
Jan 11 2019, 10:50 AM
pirama closed D56566: [Legalizer] Use correct ValueType of SELECT_CC node during Float promotion.
Jan 11 2019, 10:50 AM

Jan 10 2019

pirama created D56566: [Legalizer] Use correct ValueType of SELECT_CC node during Float promotion.
Jan 10 2019, 3:52 PM

Dec 18 2018

pirama accepted D55856: [Driver] Also obey -nostdlib++ when rewriting -lstdc++..
Dec 18 2018, 3:06 PM
pirama added inline comments to D55856: [Driver] Also obey -nostdlib++ when rewriting -lstdc++..
Dec 18 2018, 3:06 PM

Dec 3 2018

pirama added inline comments to D55237: LTO: Don't internalize available_externally globals..
Dec 3 2018, 3:33 PM

Nov 29 2018

pirama added a comment to D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.

Hi @piramam,

This change is breaking the Linux ThinLTO build. I'll work to get you a test case. Could you revert this patch until we can resolve the issue?

Nov 29 2018, 5:48 PM · Restricted Project

Nov 15 2018

pirama added a comment to D52025: [TargetLowering] Android has sincos functions.

Someone just pointed out to me that even in Android P [1], libm's sincos() just called sin() followed by cos() so this optimization won't be beneficial. It was changed in March 2018 [2] but is not a part of any release yet.

Nov 15 2018, 1:26 PM

Nov 8 2018

pirama committed rL346436: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.
[LTO] Drop non-prevailing definitions only if linkage is not local or appending
Nov 8 2018, 12:12 PM
pirama closed D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.
Nov 8 2018, 12:12 PM · Restricted Project
pirama retitled D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending from [LTO] Drop non-prevailing definitions for non-local linkage types to [LTO] Drop non-prevailing definitions only if linkage is not local or appending.
Nov 8 2018, 11:10 AM · Restricted Project
pirama added a comment to D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.

From the summary,

"In ELF, symbols non-weak symbols"

The first "symbols" seems extraneous?

Nov 8 2018, 11:09 AM · Restricted Project
pirama added a comment to D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.

Thanks for the review Teresa. I'm running the tests again after a rebase and will commit this after the tests pass.

Nov 8 2018, 11:06 AM · Restricted Project
pirama updated the diff for D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.

Fix a few more comments.

Nov 8 2018, 11:06 AM · Restricted Project
pirama updated the diff for D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.

Update based on review comments. Hopefully I did the WeakForLinker->Prevailing
name changes in all the right places.

Nov 8 2018, 12:06 AM · Restricted Project

Nov 7 2018

pirama added inline comments to D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.
Nov 7 2018, 11:26 AM · Restricted Project

Nov 6 2018

pirama added inline comments to D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.
Nov 6 2018, 10:15 PM · Restricted Project
pirama added inline comments to D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.
Nov 6 2018, 2:15 PM · Restricted Project
pirama updated the diff for D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.

Rename thinLTOResolveWeakForLinker* to thinLTOResolvePrevailing*

Nov 6 2018, 2:10 PM · Restricted Project
pirama added inline comments to D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.
Nov 6 2018, 9:24 AM · Restricted Project

Nov 5 2018

pirama updated the diff for D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.

Fix commit message.

Nov 5 2018, 4:08 PM · Restricted Project
pirama created D54125: [LTO] Drop non-prevailing definitions only if linkage is not local or appending.
Nov 5 2018, 2:53 PM · Restricted Project

Oct 29 2018

pirama edited reviewers for D53850: Declares __cpu_model as dso local, added: echristo, craig.topper; removed: pirama.

Adding reviewers suggested by 'arc cover'.

Oct 29 2018, 5:05 PM

Sep 21 2018

pirama committed rCXXA342764: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32.
[libc++abi] is_strcmp parameter to is_equal is unused for WIN32
Sep 21 2018, 1:08 PM
pirama committed rL342764: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32.
[libc++abi] is_strcmp parameter to is_equal is unused for WIN32
Sep 21 2018, 1:02 PM
pirama closed D52368: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32.
Sep 21 2018, 1:02 PM
pirama updated the diff for D52368: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32.

Simplify patch.

Sep 21 2018, 11:55 AM
pirama created D52368: [libc++abi] is_strcmp parameter to is_equal is unused for WIN32.
Sep 21 2018, 10:31 AM
pirama abandoned D48742: Set _LIBCPP_TLS_DESTRUCTOR_CC convention to run_dtors.

This file is not built for WIN32.

Sep 21 2018, 12:22 AM

Sep 14 2018

pirama accepted D52025: [TargetLowering] Android has sincos functions.
Sep 14 2018, 10:00 AM

Sep 12 2018

pirama added a comment to D50359: Add a new library, libclang-cxx.

As I mentioned in the discussion, we decided to carry build rules for the proposed library in downstream. I've updated this to make it more general, and will leave it open in case there's more interest to revive it in the future.

Sep 12 2018, 11:00 AM
pirama updated the diff for D50359: Add a new library, libclang-cxx.

Add empty source file to silence CMake warning.
Support more platforms, similar to libLLVM.so

Sep 12 2018, 10:53 AM

Aug 22 2018

pirama committed rC340424: [Android] Default to -fno-math-errno.
[Android] Default to -fno-math-errno
Aug 22 2018, 10:44 AM