This is an archive of the discontinued LLVM Phabricator instance.

[RISC-V] Zvk update to 0.9.7, Zvknc/Zvksc
ClosedPublic

Authored by ego on Jun 4 2023, 3:23 PM.

Details

Summary

[RISC-V] Zvk update to 0.9.7, Zvknc/Zvksc

Update the RISC-V Zvk (vector cryptography) extension support from 0.5
to version 0.9.7 (2023-05-31), per

<https://github.com/riscv/riscv-crypto/releases/download/v20230531/riscv-crypto-spec-vector.pdf>

Differences:

  • Zvbc is dropped from Zvkn and Zvks, and by extension from Zvkng and Zvksg;
  • new combo extensions Zvknc and Zvksc are introduced, adding Zvbc to Zvkn and Zvks;
  • the experimentatl extensions are tagged as "0.9", from the earlier "0.5".

Signed-off-by: Eric Gouriou <ego@rivosinc.com>

Diff Detail

Event Timeline

ego created this revision.Jun 4 2023, 3:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 4 2023, 3:23 PM
ego requested review of this revision.Jun 4 2023, 3:23 PM
4vtomat accepted this revision.Jun 5 2023, 9:05 AM

I just found that we forgot to add zvkned in previous RISCVUsage.rst lol~
LGTM

This revision is now accepted and ready to land.Jun 5 2023, 9:05 AM
ego added a comment.Jun 5 2023, 9:08 AM

Thanks for the review. I don't have commit rights, hence a committer will have to land this.

4vtomat added a comment.EditedJun 5 2023, 9:09 AM

I can help you to commit it after a while for other reviewers to review!

Please update the version in the comment in the header of RISCVInstrInfoZvk.td

ego updated this revision to Diff 528480.EditedJun 5 2023, 9:40 AM

Updated the Zvk version number in llvm/lib/Target/RISCV/RISCVInstrInfoZvk.td to indicate 0.9.7, per Craig's request.

I'll do a rebase on top of /main to include Craig's change to vwsll and will upload a new version.

Note: I thought I had missed adding that changed in the second upload, and edited this message previously to indicate that a new version was coming. This was incorrect, the new upload did contain the intended change. Apologies for causing confusion.

ego updated this revision to Diff 528482.EditedJun 5 2023, 9:48 AM

New revision that was rebased against current /main, which contains Craig's just committed change to use VSHT_IV_V_X_I for the vwsll instruction.

As far as I am concerned this is ready for submission.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2023, 3:43 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript