Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[LV] Vectorization remark for outerloop

Authored by nikolaypanchenko on May 16 2023, 10:53 AM.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2023, 10:53 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
nikolaypanchenko requested review of this revision.May 16 2023, 10:53 AM
ABataev added inline comments.May 16 2023, 1:45 PM
  1. Make it static?
  2. Add doxygen description.

Addressed comments

nikolaypanchenko marked an inline comment as done.May 26 2023, 9:50 AM
ABataev accepted this revision.May 26 2023, 9:53 AM

LG with a nit



This revision is now accepted and ready to land.May 26 2023, 9:53 AM
fhahn accepted this revision.May 26 2023, 9:59 AM

LGTM as well, thanks for splitting this off!

nikolaypanchenko marked an inline comment as done.

fixed typo

fhahn accepted this revision.Jul 7 2023, 7:59 AM

LGTM with inline comments, thanks!


nit: In case an outer loop is vectorized, + period at end of sentence. But it would also be OK to remove the last sentence IMO.


here it will use outerloop whereas above it will use outer loop. It would be good to use outer loop in both cases.

nikolaypanchenko marked 2 inline comments as done.

Addressed comments

@fhahn please take a look again if it's good right now

fhahn accepted this revision.Aug 16 2023, 2:48 AM

LGTM, thanks!

This revision was automatically updated to reflect the committed changes.