Page MenuHomePhabricator

artagnon (Ramkumar Ramachandra)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 28 2014, 11:11 AM (430 w, 3 d)

Recent Activity

Sat, Jan 7

artagnon added a comment to D139954: mlir/opdsl: fix and inline type annotations, trim includes.

I see the following in LLVM's CMakeLists.txt:

Sat, Jan 7, 8:43 AM · Restricted Project, Restricted Project
artagnon added a reviewer for D139954: mlir/opdsl: fix and inline type annotations, trim includes: jpienaar.
Sat, Jan 7, 8:25 AM · Restricted Project, Restricted Project
artagnon added a comment to D139954: mlir/opdsl: fix and inline type annotations, trim includes.

I've tested it with Python 3.10, but shouldn't the CI fail my commit if it doesn't build on the minimum required version of Python?

Sat, Jan 7, 8:24 AM · Restricted Project, Restricted Project
artagnon added a comment to D139954: mlir/opdsl: fix and inline type annotations, trim includes.

Ping. This should be quite straightforward to review.

Sat, Jan 7, 5:03 AM · Restricted Project, Restricted Project
artagnon added a comment to D140120: mlir/linalg-ods-gen: generate uniformly indented description.

Ping. Is this a good idea or a controversial change?

Sat, Jan 7, 5:02 AM · Restricted Project, Restricted Project

Dec 22 2022

artagnon committed rGf8077a1f0247: mlir/tblgen test: add a test for EnumAttr customAssemblyFormat (authored by artagnon).
mlir/tblgen test: add a test for EnumAttr customAssemblyFormat
Dec 22 2022, 8:32 AM · Restricted Project, Restricted Project
artagnon closed D140034: mlir/tblgen test: add a test for EnumAttr customAssemblyFormat.
Dec 22 2022, 8:31 AM · Restricted Project, Restricted Project

Dec 21 2022

artagnon committed rG9c58d10c7da8: mlir/LinalgOps: fix name of generated .yamlgen in comments (authored by artagnon).
mlir/LinalgOps: fix name of generated .yamlgen in comments
Dec 21 2022, 9:43 AM · Restricted Project, Restricted Project
artagnon closed D139946: mlir/LinalgOps: fix name of generated .yamlgen in comments.
Dec 21 2022, 9:43 AM · Restricted Project, Restricted Project
artagnon added a reviewer for D140120: mlir/linalg-ods-gen: generate uniformly indented description: nicolasvasilache.
Dec 21 2022, 12:34 AM · Restricted Project, Restricted Project

Dec 20 2022

artagnon updated the diff for D140120: mlir/linalg-ods-gen: generate uniformly indented description.

Another attempt to fix build on Windows.

Dec 20 2022, 11:59 PM · Restricted Project, Restricted Project
artagnon added a reviewer for D140034: mlir/tblgen test: add a test for EnumAttr customAssemblyFormat: rriddle.
Dec 20 2022, 11:12 PM · Restricted Project, Restricted Project
artagnon edited reviewers for D140120: mlir/linalg-ods-gen: generate uniformly indented description, added: jpienaar; removed: kazu.
Dec 20 2022, 11:09 PM · Restricted Project, Restricted Project
artagnon updated the diff for D140120: mlir/linalg-ods-gen: generate uniformly indented description.

Attempt to fix build on Windows.

Dec 20 2022, 11:09 PM · Restricted Project, Restricted Project
artagnon committed rGe8bcc37fff5b: mlir/{SPIRV,Bufferization}: use std::optional in .td files (NFC) (authored by artagnon).
mlir/{SPIRV,Bufferization}: use std::optional in .td files (NFC)
Dec 20 2022, 12:24 AM · Restricted Project, Restricted Project
artagnon closed D140329: mlir/{SPIRV,Bufferization}: use std::optional in .td files (NFC).
Dec 20 2022, 12:24 AM · Restricted Project, Restricted Project

Dec 19 2022

artagnon requested review of D140329: mlir/{SPIRV,Bufferization}: use std::optional in .td files (NFC).
Dec 19 2022, 11:34 AM · Restricted Project, Restricted Project
artagnon committed rG0de16fafa571: mlir/DialectConversion: use std::optional (NFC) (authored by artagnon).
mlir/DialectConversion: use std::optional (NFC)
Dec 19 2022, 9:49 AM · Restricted Project, Restricted Project, Restricted Project
artagnon closed D140303: mlir/DialectConversion: use std::optional (NFC).
Dec 19 2022, 9:49 AM · Restricted Project, Restricted Project, Restricted Project
artagnon updated the diff for D140303: mlir/DialectConversion: use std::optional (NFC).

Attempt to fix flang build.

Dec 19 2022, 8:48 AM · Restricted Project, Restricted Project, Restricted Project
artagnon requested review of D140303: mlir/DialectConversion: use std::optional (NFC).
Dec 19 2022, 6:32 AM · Restricted Project, Restricted Project, Restricted Project

Dec 17 2022

artagnon committed rG22426110c5ef: mlir/tblgen: use std::optional in generation (authored by artagnon).
mlir/tblgen: use std::optional in generation
Dec 17 2022, 2:14 AM · Restricted Project, Restricted Project, Restricted Project
artagnon closed D138934: mlir/tblgen: use std::optional in generation.
Dec 17 2022, 2:14 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
artagnon updated the diff for D138934: mlir/tblgen: use std::optional in generation.

Rebased onto main, with changes. Posting here for pre-merge CI checks.

Dec 17 2022, 12:51 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 15 2022

artagnon requested review of D140120: mlir/linalg-ods-gen: generate uniformly indented description.
Dec 15 2022, 10:26 AM · Restricted Project, Restricted Project

Dec 14 2022

artagnon requested review of D140034: mlir/tblgen test: add a test for EnumAttr customAssemblyFormat.
Dec 14 2022, 10:26 AM · Restricted Project, Restricted Project
artagnon committed rGbcd652855428: mlir/ods-gen: use bash from env in shell script (authored by artagnon).
mlir/ods-gen: use bash from env in shell script
Dec 14 2022, 3:29 AM · Restricted Project, Restricted Project
artagnon closed D139942: mlir/ods-gen: use bash from env in shell script.
Dec 14 2022, 3:28 AM · Restricted Project, Restricted Project
artagnon added a comment to D139942: mlir/ods-gen: use bash from env in shell script.

I have commit access, no worries. Thanks for asking though! Will land momentarily.

Dec 14 2022, 3:27 AM · Restricted Project, Restricted Project
artagnon updated the diff for D138934: mlir/tblgen: use std::optional in generation.

Attempt to fix failing builds on Debian/Windows.

Dec 14 2022, 3:26 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
artagnon updated the summary of D138934: mlir/tblgen: use std::optional in generation.
Dec 14 2022, 3:24 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 13 2022

artagnon requested review of D139954: mlir/opdsl: fix and inline type annotations, trim includes.
Dec 13 2022, 10:26 AM · Restricted Project, Restricted Project
artagnon requested review of D139946: mlir/LinalgOps: fix name of generated .yamlgen in comments.
Dec 13 2022, 8:47 AM · Restricted Project, Restricted Project
artagnon requested review of D139944: mlir/LinalgNamedStructuredOps: re-generate from script.
Dec 13 2022, 8:42 AM · Restricted Project, Restricted Project
artagnon requested review of D139942: mlir/ods-gen: use bash from env in shell script.
Dec 13 2022, 8:32 AM · Restricted Project, Restricted Project
artagnon added inline comments to D138934: mlir/tblgen: use std::optional in generation.
Dec 13 2022, 6:41 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
artagnon updated the diff for D138934: mlir/tblgen: use std::optional in generation.

Rebase onto main, address review comments, and attempt to fix build on
Windows.

Dec 13 2022, 6:40 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
artagnon updated the summary of D138934: mlir/tblgen: use std::optional in generation.
Dec 13 2022, 6:38 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
artagnon abandoned D138984: mlir: replace llvm::None with std::nullopt (NFC).

Subsumed by 1a36588ec64 by @kazu.

Dec 13 2022, 4:27 AM · Restricted Project, Restricted Project

Dec 6 2022

artagnon added a comment to D138934: mlir/tblgen: use std::optional in generation.

The Windows build is failing, and I don't know why. In light of @kazu's comments on D138984, and his recent commits, I'm tempted to abandon this change, and let him take over the work.

Dec 6 2022, 1:19 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 5 2022

artagnon added a comment to D139091: mlir/tosa: move tosa.pad from Linalg to Tensor conversion.

Landed as 2a1962542423.

Dec 5 2022, 10:41 PM · Restricted Project, Restricted Project
artagnon committed rG2a1962542423: mlir/tosa: move tosa.pad from Linalg to Tensor conversion (authored by artagnon).
mlir/tosa: move tosa.pad from Linalg to Tensor conversion
Dec 5 2022, 10:40 PM · Restricted Project, Restricted Project
artagnon closed D139091: mlir/tosa: move tosa.pad from Linalg to Tensor conversion.
Dec 5 2022, 10:40 PM · Restricted Project, Restricted Project
artagnon updated the diff for D139091: mlir/tosa: move tosa.pad from Linalg to Tensor conversion.

Rebased onto main

Dec 5 2022, 10:37 PM · Restricted Project, Restricted Project

Dec 3 2022

artagnon updated the diff for D139089: mlir/tosa: supply better documentation for tosa.pad.

Wrap overly long line.

Dec 3 2022, 1:12 AM · Restricted Project, Restricted Project
artagnon added a comment to D139085: mlir/TosaToTensor: fix typos in test.

Committed as 1e33330e29e7.

Dec 3 2022, 12:57 AM · Restricted Project, Restricted Project
artagnon committed rG1e33330e29e7: mlir/TosaToTensor: fix typos in test (authored by artagnon).
mlir/TosaToTensor: fix typos in test
Dec 3 2022, 12:57 AM · Restricted Project, Restricted Project
artagnon closed D139085: mlir/TosaToTensor: fix typos in test.
Dec 3 2022, 12:57 AM · Restricted Project, Restricted Project
artagnon added a comment to D139191: mlir/linalg: improve debugging in LinalgTransformOps.

Committed as 57c89359.

Dec 3 2022, 12:56 AM · Restricted Project, Restricted Project
artagnon committed rG57c893599d6b: mlir/linalg: improve debugging in LinalgTransformOps (authored by artagnon).
mlir/linalg: improve debugging in LinalgTransformOps
Dec 3 2022, 12:56 AM · Restricted Project, Restricted Project
artagnon closed D139191: mlir/linalg: improve debugging in LinalgTransformOps.
Dec 3 2022, 12:55 AM · Restricted Project, Restricted Project
artagnon committed rG0b74de58a19c: .mailmap: add entry for myself (authored by artagnon).
.mailmap: add entry for myself
Dec 3 2022, 12:54 AM · Restricted Project

Dec 2 2022

artagnon added a comment to D139190: mlir/TosaToLinalg: improve debugging during conversion.

Done, thanks :)

Dec 2 2022, 10:54 AM · Restricted Project, Restricted Project
artagnon updated the diff for D139190: mlir/TosaToLinalg: improve debugging during conversion.

Address review comment by @NatashaKnk.

Dec 2 2022, 10:54 AM · Restricted Project, Restricted Project
artagnon added a comment to D139191: mlir/linalg: improve debugging in LinalgTransformOps.

Hi @ftynse. I don't have commit access, so could you commit this change for me? Thanks.

Dec 2 2022, 4:35 AM · Restricted Project, Restricted Project
artagnon added a comment to D139191: mlir/linalg: improve debugging in LinalgTransformOps.

Fixed, thanks.

Dec 2 2022, 4:11 AM · Restricted Project, Restricted Project
artagnon updated the diff for D139191: mlir/linalg: improve debugging in LinalgTransformOps.

Address @ftynse's review.

Dec 2 2022, 4:11 AM · Restricted Project, Restricted Project
artagnon requested review of D139191: mlir/linalg: improve debugging in LinalgTransformOps.
Dec 2 2022, 4:02 AM · Restricted Project, Restricted Project
artagnon requested review of D139190: mlir/TosaToLinalg: improve debugging during conversion.
Dec 2 2022, 3:57 AM · Restricted Project, Restricted Project

Dec 1 2022

artagnon abandoned D138762: mlir/tosa: move sole slice in TosaToTensor to Linalg.

Abandoned in favor of D139091.

Dec 1 2022, 8:53 AM · Restricted Project, Restricted Project
artagnon requested review of D139091: mlir/tosa: move tosa.pad from Linalg to Tensor conversion.
Dec 1 2022, 2:57 AM · Restricted Project, Restricted Project
artagnon requested review of D139089: mlir/tosa: supply better documentation for tosa.pad.
Dec 1 2022, 2:35 AM · Restricted Project, Restricted Project
artagnon requested review of D139085: mlir/TosaToTensor: fix typos in test.
Dec 1 2022, 1:48 AM · Restricted Project, Restricted Project
artagnon updated the diff for D138934: mlir/tblgen: use std::optional in generation.

Fix all flang compile errors.

Dec 1 2022, 1:24 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 30 2022

artagnon added a comment to D138984: mlir: replace llvm::None with std::nullopt (NFC).

Thanks for the suggestion @kazu! I'll try to tackle that in a follow-up patch. For now, I've updated the diff to a programmatically-generated and safe-subset replacement of llvm::Optional to std::nullopt. We should have additional assurance from the CI. I understand your concerns about wanting super-safe steps, but D138934 involved a lot of manual work, and I'm not sure how we can fix that: will it be sufficient to trust the CI in that case?

I am not sure how much we can rely on CI. For example, we may not be able to catch performance regressions of generated code. llvm/include/llvm/Support/Casting.h knows about Optional but not std::optional yet, so dyn_cast of an std::optional object quietly returns nullptr, which could in turn cause a missed optimization. There may be other pitfalls like this, so I am not sure if there is a better way than go through every single instance one by one.

Nov 30 2022, 11:12 AM · Restricted Project, Restricted Project
artagnon updated the diff for D138984: mlir: replace llvm::None with std::nullopt (NFC).

Missed /g in gsed's replace command

Nov 30 2022, 11:10 AM · Restricted Project, Restricted Project
artagnon added a comment to D138984: mlir: replace llvm::None with std::nullopt (NFC).

Thanks for the suggestion @kazu! I'll try to tackle that in a follow-up patch. For now, I've updated the diff to a programmatically-generated and safe-subset replacement of llvm::Optional to std::nullopt. We should have additional assurance from the CI. I understand your concerns about wanting super-safe steps, but D138934 involved a lot of manual work, and I'm not sure how we can fix that: will it be sufficient to trust the CI in that case?

Nov 30 2022, 10:45 AM · Restricted Project, Restricted Project
artagnon updated the diff for D138984: mlir: replace llvm::None with std::nullopt (NFC).

Address review comment by @kazu. Now, the patch is generated by the
following steps:

Nov 30 2022, 10:40 AM · Restricted Project, Restricted Project
artagnon added a comment to D138984: mlir: replace llvm::None with std::nullopt (NFC).

Use using llvm::None to fix compile-time errors.

Are you trying to replace llvm::None first in this patch and then address None (without llvm::) later?

Nov 30 2022, 10:21 AM · Restricted Project, Restricted Project
artagnon updated the diff for D138934: mlir/tblgen: use std::optional in generation.

Address some build failures in flang. Unfortunately, it's very
difficult to build flang locally, as it takes a really long time.
I'm relying on the CI to tell us about additional failures.

Nov 30 2022, 9:58 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
artagnon added a comment to D138984: mlir: replace llvm::None with std::nullopt (NFC).

Unfortunately, there is no easy solution to replacing None without the llvm:: prefix. I edited it by hand in a few places.

Nov 30 2022, 9:54 AM · Restricted Project, Restricted Project
artagnon updated the diff for D138984: mlir: replace llvm::None with std::nullopt (NFC).

Address review comment by @kazu, git clang-format.

Nov 30 2022, 9:51 AM · Restricted Project, Restricted Project
artagnon updated the diff for D138984: mlir: replace llvm::None with std::nullopt (NFC).

Use using llvm::None to fix compile-time errors.

Nov 30 2022, 1:25 AM · Restricted Project, Restricted Project
artagnon added a comment to D138762: mlir/tosa: move sole slice in TosaToTensor to Linalg.

Okay, I see a TensorToLinalg. However, there is a tosa.pad -> tensor.pad conversion in TosaToLinalg: for consistency, do you recommend moving this to TosaToTensor?

Nov 30 2022, 12:22 AM · Restricted Project, Restricted Project
artagnon updated the diff for D138934: mlir/tblgen: use std::optional in generation.

Rebased on top of D138984.

Nov 30 2022, 12:09 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 29 2022

artagnon requested review of D138984: mlir: replace llvm::None with std::nullopt (NFC).
Nov 29 2022, 11:57 PM · Restricted Project, Restricted Project
artagnon requested review of D138934: mlir/tblgen: use std::optional in generation.
Nov 29 2022, 11:11 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
artagnon closed D138767: mlir/linalg: use std::optional.

Committed as 537137ece1d.

Nov 29 2022, 2:19 AM · Restricted Project, Restricted Project
artagnon closed D138765: mlir/VectorToGPU: use std::optional (NFC).

Committed as d32ec5232c9e.

Nov 29 2022, 2:19 AM · Restricted Project, Restricted Project

Nov 27 2022

artagnon added a comment to D138767: mlir/linalg: use std::optional.

Hi. Ever since the migration to the git monorepo (I know, it's been a while), I don't have commit access. Could you kindly commit this and D138765 for me? Thanks.

Nov 27 2022, 11:34 AM · Restricted Project, Restricted Project
artagnon requested review of D138767: mlir/linalg: use std::optional.
Nov 27 2022, 11:18 AM · Restricted Project, Restricted Project
artagnon requested review of D138765: mlir/VectorToGPU: use std::optional (NFC).
Nov 27 2022, 11:16 AM · Restricted Project, Restricted Project
artagnon requested review of D138762: mlir/tosa: move sole slice in TosaToTensor to Linalg.
Nov 27 2022, 10:23 AM · Restricted Project, Restricted Project
artagnon abandoned D98217: [.mailmap] Add entry for Ramkumar Ramachandra.
Nov 27 2022, 5:13 AM · Restricted Project, Restricted Project
artagnon abandoned D23250: Fix jumptable with large code model.
Nov 27 2022, 5:12 AM · Restricted Project

Mar 10 2021

artagnon added a reviewer for D98217: [.mailmap] Add entry for Ramkumar Ramachandra: chandlerc.
Mar 10 2021, 3:41 AM · Restricted Project, Restricted Project

Mar 8 2021

artagnon requested review of D98217: [.mailmap] Add entry for Ramkumar Ramachandra.
Mar 8 2021, 1:59 PM · Restricted Project, Restricted Project

Aug 7 2016

artagnon added a comment to D23250: Fix jumptable with large code model.

The file was auto-formatted via clang-format on save, via Atom. Sorry about the noise.

Aug 7 2016, 4:34 PM · Restricted Project
artagnon retitled D23250: Fix jumptable with large code model from to Fix jumptable with large code model.
Aug 7 2016, 4:25 PM · Restricted Project

Nov 12 2015

artagnon committed rL252898: Use uniqueness of C++ fully-qualified names to resolve conflicts.
Use uniqueness of C++ fully-qualified names to resolve conflicts
Nov 12 2015, 6:47 AM
artagnon closed D14549: Use uniqueness of C++ fully-qualified names to resolve conflicts by committing rL252898: Use uniqueness of C++ fully-qualified names to resolve conflicts.
Nov 12 2015, 6:46 AM

Nov 10 2015

artagnon retitled D14549: Use uniqueness of C++ fully-qualified names to resolve conflicts from to Use uniqueness of C++ fully-qualified names to resolve conflicts.
Nov 10 2015, 11:59 AM
artagnon committed rL252628: AddLLVM: squelch CMP0007 by not adding empty elements to list.
AddLLVM: squelch CMP0007 by not adding empty elements to list
Nov 10 2015, 10:29 AM
artagnon closed D14339: AddLLVM: squelch CMP0007 by not adding empty elements to list by committing rL252628: AddLLVM: squelch CMP0007 by not adding empty elements to list.
Nov 10 2015, 10:29 AM
artagnon committed rL252624: LLDBStandalone: Report nice errors on missing vars.
LLDBStandalone: Report nice errors on missing vars
Nov 10 2015, 10:11 AM
artagnon closed D13819: LLDBStandalone: Report nice errors on missing vars by committing rL252624: LLDBStandalone: Report nice errors on missing vars.
Nov 10 2015, 10:11 AM

Nov 4 2015

artagnon added a comment to D14339: AddLLVM: squelch CMP0007 by not adding empty elements to list.

It's actually an extra newline character that my editor automatically stripped out. *nix has the requirement that all lines must end with a newline character, not that a file must end with an empty line.

Nov 4 2015, 11:08 AM
artagnon retitled D14339: AddLLVM: squelch CMP0007 by not adding empty elements to list from to AddLLVM: squelch CMP0007 by not adding empty elements to list.
Nov 4 2015, 10:55 AM
artagnon added a comment to D13819: LLDBStandalone: Report nice errors on missing vars.

Okay, so run this on the current HEAD:

$ cmake -GNinja -DCMAKE_BUILD_TYPE=Debug ../lldb
-- The C compiler identification is AppleClang 6.1.0.6020053
-- The CXX compiler identification is AppleClang 6.1.0.6020053
-- Check for working C compiler using: Ninja
-- Check for working C compiler using: Ninja -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler using: Ninja
-- Check for working CXX compiler using: Ninja -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at cmake/modules/LLDBStandalone.cmake:37 (get_filename_component):
  get_filename_component called with incorrect number of arguments
Call Stack (most recent call first):
  CMakeLists.txt:3 (include)
Nov 4 2015, 10:20 AM

Nov 3 2015

artagnon committed rL251979: Squelch a silly warning regarding an extra 'default' in 'case'.
Squelch a silly warning regarding an extra 'default' in 'case'
Nov 3 2015, 1:32 PM