Page MenuHomePhabricator

gilr (Gil Rapaport)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 12 2014, 11:00 PM (270 w, 4 d)

Recent Activity

Thu, Jan 9

gilr committed rG8647a72c4a52: [LV] VPValues for memory operation pointers (NFCI) (authored by gilr).
[LV] VPValues for memory operation pointers (NFCI)
Thu, Jan 9, 11:37 PM
gilr closed D70865: [LV] VPValues for memory operation pointers (NFCI).
Thu, Jan 9, 11:37 PM · Restricted Project

Wed, Jan 8

gilr added a comment to D70865: [LV] VPValues for memory operation pointers (NFCI).

Adding minor comments; may be good to have consistent naming of VPValue variables and their corresponding code-gen'd Values(?).

Wed, Jan 8, 4:44 AM · Restricted Project
gilr updated the diff for D70865: [LV] VPValues for memory operation pointers (NFCI).

Addressed comments.

Wed, Jan 8, 4:44 AM · Restricted Project

Mon, Jan 6

gilr added inline comments to D68814: [LV] Allow assume calls in predicated blocks..
Mon, Jan 6, 5:10 AM · Restricted Project

Sun, Dec 29

gilr updated the diff for D70865: [LV] VPValues for memory operation pointers (NFCI).

Addressed comments.

Sun, Dec 29, 1:09 AM · Restricted Project

Sat, Dec 28

gilr committed rGd62bf16131e4: [LV] Use getMask() when printing recipe [NFCI] (authored by gilr).
[LV] Use getMask() when printing recipe [NFCI]
Sat, Dec 28, 11:11 PM
gilr closed D71964: [LV] Use getMask() when printing recipe [NFCI].
Sat, Dec 28, 11:11 PM · Restricted Project
gilr added a comment to D71964: [LV] Use getMask() when printing recipe [NFCI].

LGTM

Sat, Dec 28, 11:11 PM · Restricted Project
gilr added inline comments to D70865: [LV] VPValues for memory operation pointers (NFCI).
Sat, Dec 28, 9:58 AM · Restricted Project
gilr retitled D71964: [LV] Use getMask() when printing recipe [NFCI] from [LV] Use getMask() when printing recipe to [LV] Use getMask() when printing recipe [NFCI].
Sat, Dec 28, 9:58 AM · Restricted Project
gilr created D71964: [LV] Use getMask() when printing recipe [NFCI].
Sat, Dec 28, 9:39 AM · Restricted Project

Dec 9 2019

gilr updated the diff for D70865: [LV] VPValues for memory operation pointers (NFCI).

Addressed comments.

Dec 9 2019, 12:34 PM · Restricted Project
gilr added inline comments to D70865: [LV] VPValues for memory operation pointers (NFCI).
Dec 9 2019, 12:25 PM · Restricted Project

Dec 7 2019

gilr added a comment to D70734: [VPlan] Add basicblocks() and loop_basicblocks iterators..

Traversing VPRegions is not supported at the moment but we do not create such plans at the moment as far as I know

I assume you're referring to the native path? (non-native generates regions for scalarized & predicated instructions)

Ah right, I missed that code path! For my initial use-case (dropping assumes), the iterator needs to traverse the regions as well then. Let's see if I can get the iterators to co-operate. Do you think it's worth to get the existing iterators in as is? There are a few places that could use them, I think.

Dec 7 2019, 1:43 AM · Restricted Project

Dec 6 2019

gilr accepted D70732: [VPlan] Rename VPlanHCFGTransforms to VPlanTransforms (NFC)..

LGTM!

Dec 6 2019, 10:43 PM · Restricted Project
gilr added inline comments to D70732: [VPlan] Rename VPlanHCFGTransforms to VPlanTransforms (NFC)..
Dec 6 2019, 11:28 AM · Restricted Project
gilr committed rG39ccc099c901: [LV] Record GEP widening decisions in recipe (NFCI) (authored by gilr).
[LV] Record GEP widening decisions in recipe (NFCI)
Dec 6 2019, 3:53 AM
gilr closed D69067: [LV] Record GEP widening decisions in recipe (NFCI).
Dec 6 2019, 3:52 AM · Restricted Project
gilr updated the diff for D69067: [LV] Record GEP widening decisions in recipe (NFCI).

Addressed final comment (thanks Florian!)

Dec 6 2019, 2:29 AM · Restricted Project
gilr added inline comments to D68814: [LV] Allow assume calls in predicated blocks..
Dec 6 2019, 1:45 AM · Restricted Project

Dec 1 2019

gilr updated the diff for D69067: [LV] Record GEP widening decisions in recipe (NFCI).

Addressed comments.

Dec 1 2019, 1:36 AM · Restricted Project

Nov 29 2019

gilr abandoned D70054: [LV] Move pointer inspection from ILV to recipe (NFCI).

A more comprehensive solution for breaking this ingredient def-use dependence is implemented in D70865.

Nov 29 2019, 11:19 PM · Restricted Project
gilr created D70865: [LV] VPValues for memory operation pointers (NFCI).
Nov 29 2019, 11:51 AM · Restricted Project
gilr accepted D70733: [VPlan] Move graph traits (NFC)..
Nov 29 2019, 10:49 AM · Restricted Project
gilr added a comment to D70734: [VPlan] Add basicblocks() and loop_basicblocks iterators..

Traversing VPRegions is not supported at the moment but we do not create such plans at the moment as far as I know

Nov 29 2019, 10:38 AM · Restricted Project

Nov 25 2019

gilr updated the diff for D69067: [LV] Record GEP widening decisions in recipe (NFCI).
  • Limit this commit to handling GEP widening only, per Ayal's comment.
  • Bug fix: The all-operands-are-invariant check was not checking the pointer's invariance.
Nov 25 2019, 5:35 AM · Restricted Project

Nov 10 2019

gilr added a comment to D70054: [LV] Move pointer inspection from ILV to recipe (NFCI).

Originally part of D69067, to be reviewed separately per Ayal's comment.

Nov 10 2019, 9:47 AM · Restricted Project
gilr created D70054: [LV] Move pointer inspection from ILV to recipe (NFCI).
Nov 10 2019, 9:38 AM · Restricted Project

Nov 9 2019

gilr added a comment to D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC).

Testcase follows; reproduce with opt -loop-vectorize:

Nov 9 2019, 11:02 PM · Restricted Project
gilr committed rG7f152543e4ff: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFCI) (authored by gilr).
[LV] Apply sink-after & interleave-groups as VPlan transformations (NFCI)
Nov 9 2019, 10:59 AM

Nov 8 2019

gilr committed rG9f08ce0d2197: Revert "[LV] Apply sink-after & interleave-groups as VPlan transformations… (authored by gilr).
Revert "[LV] Apply sink-after & interleave-groups as VPlan transformations…
Nov 8 2019, 12:25 PM
gilr added a reverting change for rG11ed1c0239fd: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFCI): rG9f08ce0d2197: Revert "[LV] Apply sink-after & interleave-groups as VPlan transformations….
Nov 8 2019, 12:25 PM
gilr added a comment to D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC).

Please let me know if you need me to come up with a testcase.

Nov 8 2019, 12:06 PM · Restricted Project
gilr updated subscribers of D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC).

Gil, I can put a patch up for not sinking past terminators in OVDescriptor, as I am already working on patches in that area.

I’d also suggest to land the removeFromParent & co changes separately from the other changes in the patch.

Nov 8 2019, 5:47 AM · Restricted Project
gilr committed rG11ed1c0239fd: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFCI) (authored by gilr).
[LV] Apply sink-after & interleave-groups as VPlan transformations (NFCI)
Nov 8 2019, 5:32 AM

Nov 5 2019

gilr added a comment to D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC).
Nov 5 2019, 11:28 PM · Restricted Project
gilr committed rG100e797adb43: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC) (authored by gilr).
[LV] Apply sink-after & interleave-groups as VPlan transformations (NFC)
Nov 5 2019, 7:33 AM

Nov 4 2019

gilr committed rG2be17087f8c3: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC) (authored by gilr).
[LV] Apply sink-after & interleave-groups as VPlan transformations (NFC)
Nov 4 2019, 1:09 AM
gilr closed D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC).
Nov 4 2019, 1:09 AM · Restricted Project

Nov 3 2019

gilr updated the diff for D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC).

Addressed comments.

Nov 3 2019, 8:58 AM · Restricted Project
gilr added a comment to D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC).

Thanks everyone!

Nov 3 2019, 8:55 AM · Restricted Project
gilr updated the diff for D69067: [LV] Record GEP widening decisions in recipe (NFCI).

Address comments.

Nov 3 2019, 8:19 AM · Restricted Project
gilr added inline comments to D69067: [LV] Record GEP widening decisions in recipe (NFCI).
Nov 3 2019, 7:55 AM · Restricted Project

Nov 1 2019

gilr added a comment to D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC).

Any other concern, guys?

Nov 1 2019, 6:26 AM · Restricted Project
gilr updated the diff for D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC).

Rebased.

Nov 1 2019, 6:07 AM · Restricted Project

Oct 16 2019

gilr created D69067: [LV] Record GEP widening decisions in recipe (NFCI).
Oct 16 2019, 12:59 PM · Restricted Project

Oct 14 2019

gilr added a comment to D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC).

ping

Oct 14 2019, 12:28 PM · Restricted Project

Oct 13 2019

gilr updated the diff for D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC).

Applied review comments.
Reused VPWidenMemoryInstructionRecipe's new getMask() in its execute().

Oct 13 2019, 11:23 PM · Restricted Project
gilr updated the diff for D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC).

Applied review comments.

Oct 13 2019, 1:12 PM · Restricted Project
gilr updated the diff for D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC).

Applied review comments.

Oct 13 2019, 4:44 AM · Restricted Project
gilr updated the diff for D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC).

Applied review comments.

Oct 13 2019, 3:51 AM · Restricted Project
gilr added inline comments to D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC).
Oct 13 2019, 3:50 AM · Restricted Project

Oct 11 2019

gilr updated the diff for D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC).

Applied review comments.

Oct 11 2019, 5:26 AM · Restricted Project

Oct 9 2019

gilr added a comment to D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC).

So, IIUC, this is changing tryCreateRecipe to move the interleave recipe creation to the caller, buildVPlanWithVPRecipes. The dependencies with the sink values is recorded initially, then the plans are created, then the sinks are applied and, if any, the interleave groups.

Oct 9 2019, 11:08 AM · Restricted Project
gilr updated the diff for D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC).
  • Applied review comment
  • Simplified predicate lambda function
Oct 9 2019, 5:59 AM · Restricted Project
gilr added inline comments to D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC).
Oct 9 2019, 5:49 AM · Restricted Project

Oct 7 2019

gilr created D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC).
Oct 7 2019, 7:39 AM · Restricted Project

Sep 15 2019

gilr committed rL371956: Request commit access for gilr.
Request commit access for gilr
Sep 15 2019, 11:00 PM

Mar 14 2019

gilr added a comment to D58389: [NFC][LSR] Cleanup Cost API.

No problem :)
LGTM

Mar 14 2019, 3:45 AM · Restricted Project
gilr accepted D58389: [NFC][LSR] Cleanup Cost API.
Mar 14 2019, 3:45 AM · Restricted Project

Feb 21 2019

gilr added inline comments to D58389: [NFC][LSR] Cleanup Cost API.
Feb 21 2019, 4:31 AM · Restricted Project
gilr added inline comments to D58389: [NFC][LSR] Cleanup Cost API.
Feb 21 2019, 1:09 AM · Restricted Project

Feb 7 2019

gilr accepted D55373: [LSR] Generate formulae to enable more indexed accesses.

LGTM!
(One last nitpick: I'd consider letting EnableBackedgeIndexing default to true as TTI's default already disables it for Hexagon and all other targets)

Feb 7 2019, 4:28 AM · Restricted Project
gilr added inline comments to D55373: [LSR] Generate formulae to enable more indexed accesses.
Feb 7 2019, 2:27 AM · Restricted Project

Feb 6 2019

gilr added inline comments to D55373: [LSR] Generate formulae to enable more indexed accesses.
Feb 6 2019, 12:40 PM · Restricted Project

Feb 3 2019

gilr added inline comments to D55373: [LSR] Generate formulae to enable more indexed accesses.
Feb 3 2019, 2:29 PM · Restricted Project

Jan 28 2019

gilr added inline comments to D55373: [LSR] Generate formulae to enable more indexed accesses.
Jan 28 2019, 5:52 AM · Restricted Project

Dec 16 2018

gilr added inline comments to D55373: [LSR] Generate formulae to enable more indexed accesses.
Dec 16 2018, 5:57 AM · Restricted Project

Dec 12 2018

gilr added inline comments to D55373: [LSR] Generate formulae to enable more indexed accesses.
Dec 12 2018, 12:13 AM · Restricted Project

Dec 9 2018

gilr added inline comments to D55373: [LSR] Generate formulae to enable more indexed accesses.
Dec 9 2018, 8:49 AM · Restricted Project

Nov 28 2018

gilr updated subscribers of D54899: [LoopStrengthReduce] ComplexityLimit as an option.

Thanks for taking a look and for the value renamer tip! The test case has now been renamed and reduced.

Nov 28 2018, 2:21 PM

Nov 27 2018

gilr added inline comments to D54899: [LoopStrengthReduce] ComplexityLimit as an option.
Nov 27 2018, 8:26 AM
gilr added inline comments to D54899: [LoopStrengthReduce] ComplexityLimit as an option.
Nov 27 2018, 5:37 AM

Nov 8 2018

gilr committed rL346390: [LSR] Combine unfolded offset into invariant register.
[LSR] Combine unfolded offset into invariant register
Nov 8 2018, 1:05 AM
gilr closed D51861: [LSR] Combine unfolded offset into invariant register.
Nov 8 2018, 1:05 AM

Nov 7 2018

gilr updated the diff for D51861: [LSR] Combine unfolded offset into invariant register.

Test case for the two-combinations bug greatly reduced by bugpoint (thanks, Quentin!) and checks the generated IR instead of LSR's debug prints.

Nov 7 2018, 8:28 AM

Nov 5 2018

gilr updated the diff for D51861: [LSR] Combine unfolded offset into invariant register.

Added a test case to cover the bug introduced by the first patch and fixed in the second.

Nov 5 2018, 6:08 AM

Nov 2 2018

gilr added a comment to D51861: [LSR] Combine unfolded offset into invariant register.

I am confused. If they don't do (c) how can they fail?

Nov 2 2018, 6:58 AM

Nov 1 2018

gilr added a comment to D51861: [LSR] Combine unfolded offset into invariant register.

Is this covered by an existing test case?
If not, could you add one?

Nov 1 2018, 9:03 AM

Oct 28 2018

gilr requested review of D51861: [LSR] Combine unfolded offset into invariant register.
Oct 28 2018, 1:01 PM
gilr added a reviewer for D51861: [LSR] Combine unfolded offset into invariant register: delena.
Oct 28 2018, 6:04 AM
gilr updated the diff for D51861: [LSR] Combine unfolded offset into invariant register.

Bug fix: ScalarEvolution::getAddExpr() may modify the vector of SCEVs it is given as argument, causing 2nd formula to be created with only part of the SCEVs in Ops.
This patch fixes this by using a temporary copy of Ops for the 1st formula.

Oct 28 2018, 6:03 AM
gilr reopened D51861: [LSR] Combine unfolded offset into invariant register.
Oct 28 2018, 5:55 AM

Oct 24 2018

gilr committed rL345123: Revert r345114.
Revert r345114
Oct 24 2018, 1:43 AM
gilr committed rL345114: [LSR] Combine unfolded offset into invariant register.
[LSR] Combine unfolded offset into invariant register
Oct 24 2018, 12:10 AM
gilr closed D51861: [LSR] Combine unfolded offset into invariant register.
Oct 24 2018, 12:10 AM

Oct 23 2018

gilr added a comment to D51861: [LSR] Combine unfolded offset into invariant register.

Thanks Quentin!
Regarding effect on compile time please see attached CTMark results on x86.

Oct 23 2018, 7:45 AM

Sep 23 2018

gilr added a comment to D51861: [LSR] Combine unfolded offset into invariant register.

Ping

Sep 23 2018, 12:30 AM

Sep 10 2018

gilr created D51861: [LSR] Combine unfolded offset into invariant register.
Sep 10 2018, 8:57 AM
gilr committed rL341835: [LSR] Add tests for small constants; NFC.
[LSR] Add tests for small constants; NFC
Sep 10 2018, 7:57 AM

Jun 25 2018

gilr committed rL335579: [InstCombine] (A + 1) + (B ^ -1) --> A - B.
[InstCombine] (A + 1) + (B ^ -1) --> A - B
Jun 25 2018, 10:36 PM
gilr closed D48535: [InstCombine] (A + 1) + (B ^ -1) --> A - B.
Jun 25 2018, 10:36 PM
gilr updated the diff for D48535: [InstCombine] (A + 1) + (B ^ -1) --> A - B.

Impl. Sanjay comments.
Thanks for taking the time guys!

Jun 25 2018, 7:10 AM
gilr updated the diff for D48535: [InstCombine] (A + 1) + (B ^ -1) --> A - B.

Impl. Roman's comment - m_Add instead of m_c_Add.

Jun 25 2018, 4:02 AM
gilr created D48535: [InstCombine] (A + 1) + (B ^ -1) --> A - B.
Jun 25 2018, 1:41 AM

Nov 20 2017

gilr committed rL318645: [LV] Model masking in VPlan, introducing VPInstructions.
[LV] Model masking in VPlan, introducing VPInstructions
Nov 20 2017, 4:02 AM
gilr closed D38676: [LV] Model masking in VPlan, introducing VPInstructions by committing rL318645: [LV] Model masking in VPlan, introducing VPInstructions.
Nov 20 2017, 4:01 AM

Nov 19 2017

gilr updated the diff for D38676: [LV] Model masking in VPlan, introducing VPInstructions.

Addressed review comments.

Nov 19 2017, 8:18 AM
gilr added a comment to D38676: [LV] Model masking in VPlan, introducing VPInstructions.

I finished my review, and apart from my two final comments, everything looks fine.

Thanks for the hard work! :)

Nov 19 2017, 8:15 AM