User Details
- User Since
- Nov 12 2014, 11:00 PM (323 w, 3 d)
Yesterday
Tue, Jan 19
Should the (final) goal be to move the whole phi-trunc-cast logic from code-gen to vplanning phase?
Wed, Jan 13
Tue, Jan 12
Ping :)
Fri, Jan 8
LGTM!
LGTM, with a nit.
(Seems reduction might be worth splitting widenPhiInstruction() and its own Recipe, but that's beyond the scope of this patch)
Thanks!
Thu, Jan 7
Rebased on top of 7ddbe0cb905ec62d37b284a2e8daf54887a35f94 (merge ..-assume-divisible-TC.ll into ..-divisible-TC.ll)
Wed, Jan 6
Addressed comments.
Tue, Jan 5
I wonder if the code from fixReductions() could be moved (almost as-is) to widenPHIInstruction() as a first step?
Sorry for the delay @nikic.
Sun, Jan 3
Sat, Jan 2
Limit trailing-zeros check to SCEVUnknowns and only while depth limit is not reached.
Addressed comments.
Fri, Jan 1
Dec 22 2020
LGTM, thanks!
Dec 21 2020
Add a test for a constant TC with IC=3.
Dec 20 2020
LGTM!
Dec 16 2020
Dec 15 2020
LGTM, tx!
Dec 14 2020
How is the new test related to this change?
LGTM, tx!
Nov 28 2020
LGTM, tx!
Nov 24 2020
LGTM, tx!
Nov 22 2020
Nov 15 2020
Jul 8 2020
Jun 16 2020
Jun 6 2020
The patch LGTM, any reason not to include the base pointer?
May 24 2020
May 18 2020
LGTM with a nit. Thanks!
May 10 2020
Thanks for looking into this, Florian (and sorry for taking so long).
LGTM, except VPInterleaveRecipe::print() is missing here.
The patch stands by itself as a standardization of printing, similar to how the multi-line Function and Module print. If meant as a first step, would be good to elaborate on the full picture.
Apr 22 2020
LGTM (with that missing comment nit), thanks!
Apr 19 2020
LGTM, thanks.
Apr 15 2020
Addressed comments and narrowed LIT checks to the relevant vectorized instructions.
Thanks @fhahn !
Apr 14 2020
Apr 13 2020
Apr 12 2020
LGTM, thanks!
Apr 10 2020
Apr 9 2020
Apr 8 2020
Addressed comments.
Apr 7 2020
Address comments
Apr 6 2020
Apr 5 2020
LGTM, thanks!
Apr 4 2020
Mar 28 2020
LGTM, with a nit.
Mar 25 2020
Addressed comments.
Mar 24 2020
Addressed comments.
Ping :)
Mar 18 2020
Clang format.
Mar 17 2020
Mar 5 2020
LGTM!