User Details
- User Since
- Nov 12 2014, 11:00 PM (436 w, 21 h)
Oct 18 2021
Rebased.
Sep 26 2021
Addressed comments.
Sep 25 2021
Jun 17 2021
May 18 2021
May 10 2021
Thanks, I updated the code to turn VPUser in a virtual base class and added s subclass for the uses in VPBlockBase. WDYT?
May 3 2021
Very nice step forward!!
Apr 20 2021
Feb 19 2021
LGTM, thanks!
Feb 18 2021
Feb 15 2021
Feb 9 2021
Feb 8 2021
Feb 7 2021
LGTM, thanks!
Feb 3 2021
LGTM with a nit. Thanks!
Feb 1 2021
Addressed comments.
Jan 31 2021
Addressed comments.
Rebased
Jan 27 2021
Trying to apply Florian's suggestion in D95521 (only for powers of 2 as a first step). This handles the power-of-two case added by PR47904.
Jan 25 2021
ping
Jan 24 2021
LGTM, with a nit. Thanks!
Jan 23 2021
Jan 19 2021
Should the (final) goal be to move the whole phi-trunc-cast logic from code-gen to vplanning phase?
Jan 13 2021
Jan 12 2021
Ping :)
Jan 8 2021
LGTM!
LGTM, with a nit.
(Seems reduction might be worth splitting widenPhiInstruction() and its own Recipe, but that's beyond the scope of this patch)
Thanks!
Jan 7 2021
Rebased on top of 7ddbe0cb905ec62d37b284a2e8daf54887a35f94 (merge ..-assume-divisible-TC.ll into ..-divisible-TC.ll)
Jan 6 2021
Addressed comments.
Jan 5 2021
I wonder if the code from fixReductions() could be moved (almost as-is) to widenPHIInstruction() as a first step?
Sorry for the delay @nikic.
Jan 3 2021
Jan 2 2021
Limit trailing-zeros check to SCEVUnknowns and only while depth limit is not reached.
Addressed comments.
Jan 1 2021
Dec 22 2020
LGTM, thanks!
Dec 21 2020
Add a test for a constant TC with IC=3.
Dec 20 2020
LGTM!
Dec 16 2020
Dec 15 2020
LGTM, tx!
Dec 14 2020
How is the new test related to this change?
LGTM, tx!
Nov 28 2020
LGTM, tx!
Nov 24 2020
LGTM, tx!
Nov 22 2020
Nov 15 2020
Jul 8 2020
Jun 16 2020
Jun 6 2020
The patch LGTM, any reason not to include the base pointer?
May 24 2020
May 18 2020
LGTM with a nit. Thanks!
May 10 2020
Thanks for looking into this, Florian (and sorry for taking so long).
LGTM, except VPInterleaveRecipe::print() is missing here.
The patch stands by itself as a standardization of printing, similar to how the multi-line Function and Module print. If meant as a first step, would be good to elaborate on the full picture.
Apr 22 2020
LGTM (with that missing comment nit), thanks!