Page MenuHomePhabricator

Ayal (Ayal Zaks)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 12 2015, 1:48 PM (402 w, 5 d)

Recent Activity

Sun, Mar 26

Ayal added inline comments to D142886: [VPlan] Switch to checking sinking legality for recurrences in VPlan..
Sun, Mar 26, 9:23 AM · Restricted Project, Restricted Project

Thu, Mar 23

Ayal added inline comments to D142885: [VPlan] Allow building a VPlan to may fail..
Thu, Mar 23, 7:15 AM · Restricted Project, Restricted Project

Tue, Mar 21

Ayal added inline comments to D142885: [VPlan] Allow building a VPlan to may fail..
Tue, Mar 21, 1:27 AM · Restricted Project, Restricted Project

Sun, Mar 19

Ayal accepted D142885: [VPlan] Allow building a VPlan to may fail..

This is fine, adding a minor nit.

Sun, Mar 19, 8:50 AM · Restricted Project, Restricted Project
Ayal added a comment to rG371bb2c9d34a: [VPlan] Move createReplicateRegion out of VPRecipeBuilder.h. (NFC).

Nice!
Couple of nits.

Sun, Mar 19, 5:40 AM · Restricted Project, Restricted Project

Fri, Mar 17

Ayal added inline comments to rG2db71c9851e5: [VPlan] Simplify code in createReplicateRegion (NFC)..
Fri, Mar 17, 5:38 AM · Restricted Project, Restricted Project

Tue, Mar 14

Ayal accepted D144125: [VPlan] VPWidenIntOrFpInductionRecipe inherits from VPHeaderPHIRecipe.
Tue, Mar 14, 3:54 AM · Restricted Project, Restricted Project

Mon, Mar 13

Ayal committed rGeae70ccbf975: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0 (authored by Ayal).
[Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0
Mon, Mar 13, 10:04 AM · Restricted Project, Restricted Project
Ayal closed D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0.
Mon, Mar 13, 10:04 AM · Restricted Project, Restricted Project

Wed, Mar 8

Ayal added inline comments to D144491: [VPlan] Use isUniformAfterVec in VPReplicateRecipe::execute..
Wed, Mar 8, 8:37 AM · Restricted Project, Restricted Project
Ayal accepted D144487: [VPlan] Replace invariance fields from VPWidenGEPRecipe..

Nice cleanup!

Wed, Mar 8, 2:07 AM · Restricted Project, Restricted Project
Ayal accepted D144489: [VPlan] Replace InvariantCond field from VPWidenSelectRecipe..

Nice cleanup! Indicate patch is [NFC]?

Wed, Mar 8, 1:55 AM · Restricted Project, Restricted Project
Ayal accepted D145322: [VPlan] Check if recipe is in ReplicateRegion for IfPredicateInstr (NFC).

Part of moving predicated replicate recipes to either contain a mask operand or be embedded within a replicating region, changing their internal IsPredicated to represent the former but not the latter.

Wed, Mar 8, 1:37 AM · Restricted Project, Restricted Project
Ayal accepted D143865: [VPlan] Add predicate to VPReplicateRecipe, expand region later..

Looks good to me, thanks!
Adding a couple of final nits.

Wed, Mar 8, 1:13 AM · Restricted Project, Restricted Project

Tue, Mar 7

Ayal added inline comments to D143865: [VPlan] Add predicate to VPReplicateRecipe, expand region later..
Tue, Mar 7, 2:28 PM · Restricted Project, Restricted Project
Ayal added a comment to D144125: [VPlan] VPWidenIntOrFpInductionRecipe inherits from VPHeaderPHIRecipe.

This change makes a lot of sense, except for getBackedgeValue() - see comment.

Tue, Mar 7, 1:38 PM · Restricted Project, Restricted Project

Mon, Mar 6

Ayal added inline comments to D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0.
Mon, Mar 6, 4:40 PM · Restricted Project, Restricted Project
Ayal updated the diff for D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0.

It's hard for getOpenCLKernelParameterType() to detect and diagnose invalid pointer cases w/o context (of an enclosing struct or not), but it's easy to detect valid pointer cases for v2.0+ and return ValidKernelParam.

Mon, Mar 6, 4:35 PM · Restricted Project, Restricted Project

Sun, Mar 5

Ayal added inline comments to D143865: [VPlan] Add predicate to VPReplicateRecipe, expand region later..
Sun, Mar 5, 6:23 AM · Restricted Project, Restricted Project

Feb 20 2023

Ayal added a comment to D143865: [VPlan] Add predicate to VPReplicateRecipe, expand region later..

Nice clean-up!

Feb 20 2023, 3:30 PM · Restricted Project, Restricted Project

Feb 19 2023

Ayal accepted D143864: [VPlan] Replace AlsoPack field with shouldPack() method (NFC)..

Indeed better compute such information on demand than cache it! Looks good to me, adding a couple of nits.

Feb 19 2023, 1:05 PM · Restricted Project, Restricted Project

Feb 15 2023

Ayal added inline comments to D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0.
Feb 15 2023, 3:22 PM · Restricted Project, Restricted Project

Feb 14 2023

Ayal added inline comments to D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0.
Feb 14 2023, 7:17 AM · Restricted Project, Restricted Project
Ayal updated the diff for D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0.

Use -verify=expected,ocl12 instead of #ifdef'ing the test to check diagnostics emitted for 1.2 but not emitted for 2.0.

Feb 14 2023, 7:13 AM · Restricted Project, Restricted Project
Ayal added inline comments to D142589: [LV] Perform recurrence sinking directly on VPlan..
Feb 14 2023, 1:26 AM · Restricted Project, Restricted Project

Feb 13 2023

Ayal added inline comments to D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0.
Feb 13 2023, 3:24 PM · Restricted Project, Restricted Project
Ayal updated the diff for D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0.

Updated version merges the if's and checks tests for both 1.2 and 2.0.

Feb 13 2023, 3:19 PM · Restricted Project, Restricted Project
Ayal added inline comments to rGaf3c25dc3d87: [VPlan] Fix iterator invalidation in adjustFixedOrderRecurrences..
Feb 13 2023, 2:00 PM · Restricted Project, Restricted Project
Ayal added inline comments to rGaf3c25dc3d87: [VPlan] Fix iterator invalidation in adjustFixedOrderRecurrences..
Feb 13 2023, 7:16 AM · Restricted Project, Restricted Project

Feb 12 2023

Ayal added a comment to D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0.

I feel that originally pointers were disallowed because they create the same issue as size_t and etc as their size is implementation depended but the same logic applies to images and other types that are even more implementation depended. Overall this bit of the spec is very inconsistent so I don't mind if we change the behavior to be whatever we find more helpful. However I would encourage to submit an issue to OpenCL-Docs to point out this inconsistency.

Feb 12 2023, 3:18 PM · Restricted Project, Restricted Project
Ayal added a comment to D49723: [OpenCL] Check for invalid kernel arguments in array types.

This is admittedly a couple of years old by now, but wonder about that other intended patch - Clang still seems to consider pointers in struct arguments to be illegal in CL2.0 (and CL3.0) - please see https://godbolt.org/z/E87z66h1d

Yeah, the patch got lost somewhere, I'm sorry...

Feb 12 2023, 9:47 AM · Restricted Project
Ayal requested review of D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0.
Feb 12 2023, 9:40 AM · Restricted Project, Restricted Project

Feb 9 2023

Ayal added inline comments to D142885: [VPlan] Allow building a VPlan to may fail..
Feb 9 2023, 3:38 PM · Restricted Project, Restricted Project
Herald added a project to D49723: [OpenCL] Check for invalid kernel arguments in array types: Restricted Project.

Btw, has this restriction been removed from CL 2.0?

No, it applies for CL2.0 as well.

It seems however the restriction on pointer to pointer was removed (see s6.9.a last item) in CL2.0.

Right, and it seems that pointers in struct arguments should also be legal in CL2.0.
I'll submit another patch to remove this check for CL2.0.

Feb 9 2023, 2:06 PM · Restricted Project

Feb 7 2023

Ayal accepted D142589: [LV] Perform recurrence sinking directly on VPlan..

This looks good to me, thanks! Adding couple of final nits.

Feb 7 2023, 4:05 PM · Restricted Project, Restricted Project

Feb 5 2023

Ayal added a comment to D142589: [LV] Perform recurrence sinking directly on VPlan..

Address latest comments, thanks! I think it would be good to address the independent comments once the new sinking code has settled in.

Feb 5 2023, 9:10 AM · Restricted Project, Restricted Project

Feb 1 2023

Ayal added a comment to D142885: [VPlan] Allow building a VPlan to may fail..

Adding a couple of nits. The optional functionality added cannot yet be exercised (with a test)?

Feb 1 2023, 9:15 AM · Restricted Project, Restricted Project

Jan 31 2023

Ayal added a comment to D142589: [LV] Perform recurrence sinking directly on VPlan..

A very nice step forward! Raises a few thoughts regarding recipes of predicated instructions, arguably independent of the patch.

Jan 31 2023, 11:42 AM · Restricted Project, Restricted Project

Jan 24 2023

Ayal accepted D140514: [VPlan] Use VPDominatorTree in VPlanVerifier ..

Ship it!

Jan 24 2023, 8:31 AM · Restricted Project, Restricted Project

Jan 19 2023

Ayal accepted D139790: [VPlan] Consider all recipes in replicate blocks as sink candidates..

Looks good to me.
May indicate in the commit message that this addresses the iterative nature of sink scalar operands where it is invoked repeatedly.

Jan 19 2023, 6:14 AM · Restricted Project, Restricted Project
Ayal accepted D140513: [VPlan] Switch default graph traits to be recursive, update VPDomTree..

Looks good to me, with a few minor nits.

Jan 19 2023, 5:50 AM · Restricted Project, Restricted Project
Ayal added inline comments to D140514: [VPlan] Use VPDominatorTree in VPlanVerifier ..
Jan 19 2023, 1:59 AM · Restricted Project, Restricted Project
Ayal accepted D142055: [VPlan] Add vp_depth_first_deep (NFC).

Thanks for adding, looks good to me, ship it!

Jan 19 2023, 1:32 AM · Restricted Project, Restricted Project
Ayal added inline comments to D140512: [VPlan] Add vp_depth_first_shallow + graph traits for wrapper(NFC).
Jan 19 2023, 12:22 AM · Restricted Project, Restricted Project

Jan 18 2023

Ayal added inline comments to D140513: [VPlan] Switch default graph traits to be recursive, update VPDomTree..
Jan 18 2023, 5:21 AM · Restricted Project, Restricted Project

Jan 17 2023

Ayal accepted D140512: [VPlan] Add vp_depth_first_shallow + graph traits for wrapper(NFC).

Ship it!

Jan 17 2023, 9:35 PM · Restricted Project, Restricted Project
Ayal accepted D140511: [VPlan] Disconnect VPRegionBlock from successors in graph iterator(NFCI).

Looks good to me, thanks for adding the test!

Jan 17 2023, 4:59 AM · Restricted Project, Restricted Project
Ayal added inline comments to D140511: [VPlan] Disconnect VPRegionBlock from successors in graph iterator(NFCI).
Jan 17 2023, 12:57 AM · Restricted Project, Restricted Project

Jan 16 2023

Ayal accepted D140848: [VPlan] Remove duplicated VPValue IDs (NFCI)..

OK, thanks for clarifying.
It's somewhat confusing to have the order of parameters dictate which VPValue is being constructed, but the alternative of having each subclass provide its VPDefID seems less appealing.
Perhaps once a common base class is introduced to take care of all recipes that also inherit from VPValue it could pass VPVRecipeSC explicitly when constructing VPValue, rather than relying on this order.

Jan 16 2023, 11:09 AM · Restricted Project, Restricted Project

Jan 15 2023

Ayal added a comment to D140848: [VPlan] Remove duplicated VPValue IDs (NFCI)..

Nice cleanup!

Jan 15 2023, 3:57 PM · Restricted Project, Restricted Project

Jan 1 2023

Ayal added a comment to rG89718815c669: [VPlan] Adjust mergeReplicateRegions to be in line with mergeBlock (NFC).

Thanks!

Jan 1 2023, 1:51 PM · Restricted Project, Restricted Project

Dec 31 2022

Ayal added inline comments to D139790: [VPlan] Consider all recipes in replicate blocks as sink candidates..
Dec 31 2022, 3:12 PM · Restricted Project, Restricted Project

Dec 27 2022

Ayal added inline comments to D139788: [LV] Sink scalar operands and merge regions repeatedly..
Dec 27 2022, 12:59 PM · Restricted Project, Restricted Project

Dec 26 2022

Ayal accepted D139927: [VPlan] Remove redundant blocks by merging them into predecessors..

Thanks!

Dec 26 2022, 2:02 PM · Restricted Project, Restricted Project
Ayal added inline comments to D139927: [VPlan] Remove redundant blocks by merging them into predecessors..
Dec 26 2022, 1:09 PM · Restricted Project, Restricted Project
Ayal accepted D140500: [VPlan] Move GraphTraits definitions to separate header (NFC)..

Ship it!

Dec 26 2022, 7:41 AM · Restricted Project, Restricted Project
Ayal added inline comments to D139927: [VPlan] Remove redundant blocks by merging them into predecessors..
Dec 26 2022, 6:46 AM · Restricted Project, Restricted Project
Ayal added inline comments to D135017: [LV] Move exit cond simplification to separate transform..
Dec 26 2022, 3:09 AM · Restricted Project, Restricted Project

Dec 20 2022

Ayal accepted D92132: [LV] Support widened induction variables in epilogue vectorization..

Ship it!
This looks even better with the added tests, and the last issue @venkataramanan.kumar.llvm raised regarding replicated end values seems acceptable.
SCEV expanding the end values is worth a TODO? Added a couple of thoughts that can be addressed separately.

Dec 20 2022, 12:43 PM · Restricted Project, Restricted Project
Ayal added inline comments to D139927: [VPlan] Remove redundant blocks by merging them into predecessors..
Dec 20 2022, 6:05 AM · Restricted Project, Restricted Project
Ayal accepted D133017: [LV] Use SCEV to check if the trip count <= VF * UF..

Looks good to me, thanks.

Dec 20 2022, 5:26 AM · Restricted Project, Restricted Project
Ayal accepted D135017: [LV] Move exit cond simplification to separate transform..

Looks good to me, adding various nits.

Dec 20 2022, 2:05 AM · Restricted Project, Restricted Project

Dec 17 2022

Ayal added inline comments to D139790: [VPlan] Consider all recipes in replicate blocks as sink candidates..
Dec 17 2022, 12:04 PM · Restricted Project, Restricted Project

Dec 11 2022

Ayal accepted D139788: [LV] Sink scalar operands and merge regions repeatedly..

Nice catch, ship it!

Dec 11 2022, 2:40 PM · Restricted Project, Restricted Project
Ayal added inline comments to D139790: [VPlan] Consider all recipes in replicate blocks as sink candidates..
Dec 11 2022, 2:32 PM · Restricted Project, Restricted Project

Dec 10 2022

Ayal accepted D138748: [VPlan] Summarize recipes used to model inductions..

Ship it, thanks!
Add [NFC] to title?
Relate to recent IV recipe patches in commit message?

Dec 10 2022, 2:58 PM · Restricted Project, Restricted Project

Dec 5 2022

Ayal added inline comments to D133760: [VPlan] Support sinking VPScalarIVStepsRecipe..
Dec 5 2022, 12:41 AM · Restricted Project, Restricted Project

Dec 4 2022

Ayal accepted D133760: [VPlan] Support sinking VPScalarIVStepsRecipe..

Looks good to me, thnks!
Adding a minor optional nit.

Dec 4 2022, 9:50 AM · Restricted Project, Restricted Project
Ayal added inline comments to D133760: [VPlan] Support sinking VPScalarIVStepsRecipe..
Dec 4 2022, 1:33 AM · Restricted Project, Restricted Project

Nov 27 2022

Ayal accepted D133758: [VPlan] Add VPDerivedIVRecipe, use for VPScalarIVStepsRecipe..

This looks good to me, ship it!

Nov 27 2022, 3:58 PM · Restricted Project, Restricted Project
Ayal added a comment to rG12bb5535d270: [VPlan] Move cast codegen to emitTransformedIndex (NFCI)..

Nice simplification, thanks for following up!

Nov 27 2022, 3:35 PM · Restricted Project, Restricted Project
Ayal added a comment to D138748: [VPlan] Summarize recipes used to model inductions..

Thanks for following up! Adding some thoughts to consider.

Nov 27 2022, 3:12 PM · Restricted Project, Restricted Project
Ayal added inline comments to D133758: [VPlan] Add VPDerivedIVRecipe, use for VPScalarIVStepsRecipe..
Nov 27 2022, 8:15 AM · Restricted Project, Restricted Project

Nov 15 2022

Ayal added a comment to D133758: [VPlan] Add VPDerivedIVRecipe, use for VPScalarIVStepsRecipe..

pong :-)

Nov 15 2022, 2:03 PM · Restricted Project, Restricted Project
Ayal accepted D136068: [VPlan] Update VPValue::getDef to return VPRecipeBase* (NFC)..

This looks good to me, thanks. Adding various nits, mostly irrespective of this patch.

Nov 15 2022, 7:14 AM · Restricted Project, Restricted Project

Oct 23 2022

Ayal added inline comments to D133760: [VPlan] Support sinking VPScalarIVStepsRecipe..
Oct 23 2022, 2:07 PM · Restricted Project, Restricted Project
Ayal added a comment to D136068: [VPlan] Update VPValue::getDef to return VPRecipeBase* (NFC)..

A more accurate name for getDef() may then be getDefiningRecipe(), as in MLIR's Value::getDefiningOp().

Oct 23 2022, 11:08 AM · Restricted Project, Restricted Project
Ayal accepted D136368: [VPlan] Use onlyFirstLaneUsed in sinkScalarOperands..

Ship it!
Comment needs to be updated.

Oct 23 2022, 8:26 AM · Restricted Project, Restricted Project
Ayal added a comment to D133758: [VPlan] Add VPDerivedIVRecipe, use for VPScalarIVStepsRecipe..

Ahh, this brings up some further thoughts...

Oct 23 2022, 8:19 AM · Restricted Project, Restricted Project

Oct 11 2022

Ayal added a comment to D92132: [LV] Support widened induction variables in epilogue vectorization..

Thanks for accommodating, this looks good to me, with a couple of final nits.
@rengolin, @bmahjour, @venkataramanan.kumar.llvm - any further comments or ok with you to accept?

Oct 11 2022, 4:34 PM · Restricted Project, Restricted Project

Oct 5 2022

Ayal added a comment to D92132: [LV] Support widened induction variables in epilogue vectorization..

Good improvement, adding various nits.

Oct 5 2022, 2:00 PM · Restricted Project, Restricted Project

Oct 2 2022

Ayal added inline comments to D133017: [LV] Use SCEV to check if the trip count <= VF * UF..
Oct 2 2022, 7:52 AM · Restricted Project, Restricted Project
Ayal added inline comments to D135017: [LV] Move exit cond simplification to separate transform..
Oct 2 2022, 7:40 AM · Restricted Project, Restricted Project
Ayal added inline comments to D135017: [LV] Move exit cond simplification to separate transform..
Oct 2 2022, 7:32 AM · Restricted Project, Restricted Project

Sep 22 2022

Ayal accepted D133580: [VPlan] Only generate single instr for unpredicated stores of varying value to invariant address.

This makes good forward progress, adding a couple of nits.

Sep 22 2022, 1:24 AM · Restricted Project, Restricted Project

Sep 20 2022

Ayal accepted D134218: [VPlan] Sink non-uniform recieps for scalar plans..

This is essentially saying that for VF=1 every recipe is uniform (across VF lanes), or none are.
Perhaps this should be done more 'uniformly', as in CM.isUniformAfterVectorization(I, VF) which returns true if (VF.isScalar()) regardless of I.

Sep 20 2022, 2:44 AM · Restricted Project, Restricted Project
Ayal added a comment to D134214: [VPlan] Add VPReplicateRecipe::Instr field to hold replicated instr..

Underlying value is designed to only be used for opcode, type info, metadata and so on, for any recipe; the operands and uses are modeled in VPlan, for any recipe; worth clarifying?

Sep 20 2022, 12:44 AM · Restricted Project, Restricted Project
Ayal accepted D134211: [LV] Create createInductionResumeValue helper..

LGTM, adding minor nits.

Sep 20 2022, 12:37 AM · Restricted Project, Restricted Project
Ayal accepted D133762: [VPlan] Remove dead recipes before sinking..

LGTM! Adding a minor nit.

Sep 20 2022, 12:24 AM · Restricted Project, Restricted Project
Ayal added inline comments to D133760: [VPlan] Support sinking VPScalarIVStepsRecipe..
Sep 20 2022, 12:18 AM · Restricted Project, Restricted Project

Sep 19 2022

Ayal added a comment to D133758: [VPlan] Add VPDerivedIVRecipe, use for VPScalarIVStepsRecipe..

Nice refactoring - potentially closing a gap between VPlan and original post-vectorization IR sink scalar operands?

Sep 19 2022, 2:45 PM · Restricted Project, Restricted Project

Sep 13 2022

Ayal added inline comments to D133666: [VPlan] Add VPValue::isDefinedOutsideVectorRegions helper (NFC)..
Sep 13 2022, 6:44 AM · Restricted Project, Restricted Project

Sep 11 2022

Ayal added inline comments to D133580: [VPlan] Only generate single instr for unpredicated stores of varying value to invariant address.
Sep 11 2022, 12:34 PM · Restricted Project, Restricted Project
Ayal added inline comments to D131015: [LV] Track all IR blocks corresponding to VPBasicBlock.
Sep 11 2022, 7:31 AM · Restricted Project, Restricted Project
Ayal added inline comments to rG2a78890b7b7f: [VPlan] Move SCEV expansion for pointer induction to VPExpandSCEV (NFC)..
Sep 11 2022, 6:30 AM · Restricted Project, Restricted Project
Ayal added inline comments to D133497: [VPlan] Only generate single instr for stores uniform across all parts..
Sep 11 2022, 3:24 AM · Restricted Project, Restricted Project

Sep 7 2022

Ayal added inline comments to D131015: [LV] Track all IR blocks corresponding to VPBasicBlock.
Sep 7 2022, 1:47 PM · Restricted Project, Restricted Project

Sep 6 2022

Ayal added inline comments to D133017: [LV] Use SCEV to check if the trip count <= VF * UF..
Sep 6 2022, 2:47 AM · Restricted Project, Restricted Project

Aug 31 2022

Ayal accepted D132585: [VPlan] Add field to track if intrinsic should be used for call. (NFC).

Thanks for addressing, looks good to me, adding minor last nits.

Aug 31 2022, 1:01 PM · Restricted Project, Restricted Project

Aug 29 2022

Ayal added inline comments to D132585: [VPlan] Add field to track if intrinsic should be used for call. (NFC).
Aug 29 2022, 7:16 AM · Restricted Project, Restricted Project