User Details
- User Since
- Jul 12 2015, 1:48 PM (363 w, 4 d)
Yesterday
This minimal improvement is fine, thanks! Adding some optional nits:
Nice clean-up!
Adding a nit for potential further clean-ups.
Wed, Jun 29
This fix is fine, thanks, adding a minor nit.
Tue, Jun 28
Mon, Jun 27
Sun, Jun 26
Ship it!
Ship it!
Curious if current lack of proper noalias metadata of an epilogue vector loop may result in missed optimization or potentially wrong code?
Nice move! Would it be reasonable to also have a matching VPlanRecipes.h, excluding VPRecipeBase?
Mon, Jun 13
Looks good to me!
Thu, Jun 2
Ship it!
This looks good to me, thanks!
This looks good to me, thanks!
Adding minor nits.
Wed, Jun 1
May 31 2022
This looks good to me, ship it!
May 29 2022
Should tests check for new BranchOnCond VPInstruction?
May 22 2022
Thanks for following up! Minor nits to help keep consistency.
Thanks for following up!
May 21 2022
Thanks for following up!
May 20 2022
Looks good to me, thanks!
May 19 2022
Looks good to me! Adding minor suggestions.
May 17 2022
May 16 2022
Summary deserves updating.
Looks good! Minor documentation update nits.
May 2 2022
Looks good to me, adding a couple of nits.
Apr 28 2022
Apr 27 2022
Apr 25 2022
Apr 13 2022
Ship it!
minor nits.
Looks good to me.
Can this too lead to different - more accurate decisions? If so wonder if that could be tested(?)
Looks good to me, curious if it may lead to any regression...
Adding minor nits.
This looks good to me, thanks for accommodating, ship it!
Adding minor nits.
Note that there are some test changes, because we now can correctly look through instructions like truncates to analyze the actual users.
Apr 12 2022
Nice preparation for expanding VPlan's scope to include exit/middle-block after its expansion to include preheader.
Looks good to me, adding minor nits.
Apr 9 2022
Apr 8 2022
Apr 4 2022
This looks fine! Adding a couple of nits and future thoughts:
Apr 3 2022
Mar 30 2022
This is fine, thanks!
Mar 29 2022
This is fine; adding a clarifying comment.
Looks fine to me, with a couple of nits.
Mar 28 2022
Looks good to me!
Mar 27 2022
A good step forward in refactoring and simplifying induction variable recipes, raising thoughts for follow-up steps. Ship it!
Mar 20 2022
Nice! Looks good to me.
Mar 16 2022
Nice clean-up, effectively retiring ILV's widenPHIInstruction(), completing its refactoring into more specific recipes.
Adding various nits.
Mar 15 2022
Ship it!
Ship it!
Address clearly uses first lane only, as evident in VPInterleaveGroup::execute(), and the other operands Stored values and Mask clearly use all lanes.
This will be exercised/tested by follow-up patch only?
Mar 10 2022
Ship it!
Would be good to follow-up with cleaning-up of needsScalarIV/needsVectorIV.
Looks good to me, with some last minor nits.
Can drop 'only' also from title.
Specifying VPScalarIVStepsRecipe::onlyFirstLaneUsed() could be committed separately, it belongs to previous patches introducing VPScalarIVStepsRecipe and/or onlyFirstLaneUsed().
Mar 9 2022
Perhaps drop "only" - "usesScalars()" instead of "onlyScalarsUsed()"? As opposed to usesVectors.
Mar 8 2022
This nicely removes from ILV both widenIntOrFpInduction() along with createVectorIntOrFpInductionPHI() which it calls, inlining them into VPlan's VPWidenIntOrFpInductionRecipe::execute(), while postponing buildScalarSteps() for all potential scalar users of the vectorized IV to a VPlan2VPlan transformation/optimization.
How about VPScalarIVStepsRecipe, VPBlendRecipe, VPBranchOnMaskRecipe, VPPredInstPHIRecipe, VPExpandSCEVRecipe?
Mar 6 2022
Mar 1 2022
Looks good to me, with a last nit.
Feb 28 2022
Feb 26 2022
Feb 22 2022
Looks good to me, thanks!
Feb 21 2022
Looks good to me, thanks!
Feb 20 2022
minor nits
Feb 19 2022
Jan 27 2022
This is fine, couple of final nits; thanks for accommodating!
This is fine, with a last nit
Jan 26 2022
This is fine, remove EntryVal from buildScalarSteps() and update comment?
Jan 25 2022
Jan 19 2022
Jan 18 2022
This looks fine, with a minor comment.