Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People nikolaypanchenko

nikolaypanchenko (Kolya Panchenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 16 2022, 3:15 PM (57 w, 3 d)

Recent Activity
View All

Mon, Sep 11

nikolaypanchenko added inline comments to D158716: [RFC][LV] VPlan-based cost model.
Mon, Sep 11, 2:31 PM · Unknown Object (Project), Restricted Project

Wed, Aug 30

nikolaypanchenko added inline comments to D157322: [VPlan] Initial modeling of runtime VF * UF as VPValue..
Wed, Aug 30, 1:06 PM · Unknown Object (Project), Restricted Project

Aug 21 2023

nikolaypanchenko updated the summary of D99750: [LV, VP]VP intrinsics support for the Loop Vectorizer.
Aug 21 2023, 11:55 AM · Restricted Project, Restricted Project, Unknown Object (Project)
nikolaypanchenko added a comment to D150700: [LV] Stability fix for outerloop vectorization.

@fhahn ping

Aug 21 2023, 10:06 AM · Unknown Object (Project), Restricted Project
nikolaypanchenko committed rGacbe886880d3: [LV] Vectorization remark for outerloop (authored by nikolaypanchenko).
[LV] Vectorization remark for outerloop
Aug 21 2023, 10:05 AM · Unknown Object (Project), Restricted Project
nikolaypanchenko closed D150696: [LV] Vectorization remark for outerloop.
Aug 21 2023, 10:05 AM · Unknown Object (Project), Restricted Project

Aug 18 2023

nikolaypanchenko added a comment to D156131: [LV] Generate predicate in a proper VPBasicBlock.

@fhahn ping

Aug 18 2023, 1:44 PM · Unknown Object (Project), Restricted Project

Aug 15 2023

nikolaypanchenko added a comment to D150696: [LV] Vectorization remark for outerloop.

@fhahn please take a look again if it's good right now

Aug 15 2023, 12:15 PM · Unknown Object (Project), Restricted Project

Aug 11 2023

nikolaypanchenko updated the diff for D150696: [LV] Vectorization remark for outerloop.

Addressed comments

Aug 11 2023, 3:22 PM · Unknown Object (Project), Restricted Project

Aug 8 2023

nikolaypanchenko added a comment to D149479: [LV] Enable scalable outer loop vectorization.
In D149479#4568588, @iamlouk wrote:

@nikolaypanchenko, thank you for this patch! Sorry to bother you, but will you update the revision (to support scalable vectorization factors)? I have written a patch myself with the same intention (although it works slightly differently, I also modified determineVPlanVF), not knowing that this revision already exists, so if you do not have the resources for this at the moment, I could present an alternative one, but only if you are ok with that of course.

Aug 8 2023, 12:52 PM · Unknown Object (Project), Restricted Project
nikolaypanchenko added inline comments to D157322: [VPlan] Initial modeling of runtime VF * UF as VPValue..
Aug 8 2023, 9:07 AM · Unknown Object (Project), Restricted Project

Aug 7 2023

nikolaypanchenko updated the diff for D156131: [LV] Generate predicate in a proper VPBasicBlock.

Rebase

Aug 7 2023, 11:52 AM · Unknown Object (Project), Restricted Project
nikolaypanchenko added a comment to D156131: [LV] Generate predicate in a proper VPBasicBlock.
In D156131#4560161, @fhahn wrote:

Interesting issue! Would it be possible to construct a test case showing the issue on current main?

Aug 7 2023, 10:58 AM · Unknown Object (Project), Restricted Project
nikolaypanchenko added inline comments to D99750: [LV, VP]VP intrinsics support for the Loop Vectorizer.
Aug 7 2023, 10:31 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Aug 2 2023

nikolaypanchenko updated the diff for D156131: [LV] Generate predicate in a proper VPBasicBlock.

Hoisted out InsertPointGuard

Aug 2 2023, 6:03 PM · Unknown Object (Project), Restricted Project
nikolaypanchenko updated the diff for D156131: [LV] Generate predicate in a proper VPBasicBlock.

Rebased

Aug 2 2023, 6:02 PM · Unknown Object (Project), Restricted Project

Jul 24 2023

nikolaypanchenko added a comment to D156131: [LV] Generate predicate in a proper VPBasicBlock.

The problem was found in our downstream compiler with masked-ordered reduction enabled, where non-flattened invalid VPlan looks like before adjustRecipesForReductions:

  WIDEN ir<%add.i> = fadd ir<%add.i2426>, ir<%conv.i>
Successor(s): if.else.i.i.i.i.i15
Jul 24 2023, 7:58 AM · Unknown Object (Project), Restricted Project
nikolaypanchenko added reviewers for D156131: [LV] Generate predicate in a proper VPBasicBlock: fhahn, ABataev.
Jul 24 2023, 7:55 AM · Unknown Object (Project), Restricted Project
nikolaypanchenko requested review of D156131: [LV] Generate predicate in a proper VPBasicBlock.
Jul 24 2023, 7:52 AM · Unknown Object (Project), Restricted Project

Jul 6 2023

nikolaypanchenko updated the diff for D150696: [LV] Vectorization remark for outerloop.

fixed typo

Jul 6 2023, 8:13 AM · Unknown Object (Project), Restricted Project

May 26 2023

nikolaypanchenko updated the diff for D150700: [LV] Stability fix for outerloop vectorization.

Fixed unittest

May 26 2023, 10:19 AM · Unknown Object (Project), Restricted Project
nikolaypanchenko updated the diff for D150696: [LV] Vectorization remark for outerloop.

Addressed comments

May 26 2023, 9:50 AM · Unknown Object (Project), Restricted Project

May 16 2023

nikolaypanchenko added reviewers for D150700: [LV] Stability fix for outerloop vectorization: fhahn, ABataev.
May 16 2023, 11:36 AM · Unknown Object (Project), Restricted Project
nikolaypanchenko requested review of D150700: [LV] Stability fix for outerloop vectorization.
May 16 2023, 11:36 AM · Unknown Object (Project), Restricted Project
nikolaypanchenko added reviewers for D150696: [LV] Vectorization remark for outerloop: fhahn, ABataev.
May 16 2023, 10:54 AM · Unknown Object (Project), Restricted Project
nikolaypanchenko requested review of D150696: [LV] Vectorization remark for outerloop.
May 16 2023, 10:53 AM · Unknown Object (Project), Restricted Project

Apr 28 2023

nikolaypanchenko added reviewers for D149479: [LV] Enable scalable outer loop vectorization: fhahn, ABataev, peixin.
Apr 28 2023, 1:07 PM · Unknown Object (Project), Restricted Project
nikolaypanchenko requested review of D149479: [LV] Enable scalable outer loop vectorization.
Apr 28 2023, 1:05 PM · Unknown Object (Project), Restricted Project

Apr 17 2023

nikolaypanchenko requested review of D148581: [LV] Added special representation of the loop into VPlan.
Apr 17 2023, 4:25 PM · Unknown Object (Project), Restricted Project

Feb 3 2023

nikolaypanchenko added a comment to D126363: [VPlan, VP] 1/4 Introduce new recipes to support predicated vectorization.

ping

Feb 3 2023, 12:02 PM · Unknown Object (Project), Restricted Project, Restricted Project

Jan 27 2023

nikolaypanchenko added a comment to D142680: [ConstFolding] Modified algorithm of `ConstantFoldConstantImpl` to be iterative.
In D142680#4084917, @nikic wrote:

Patch missing description. What's the motivation for the change?

Jan 27 2023, 12:06 PM · Unknown Object (Project), Restricted Project
nikolaypanchenko updated the summary of D142680: [ConstFolding] Modified algorithm of `ConstantFoldConstantImpl` to be iterative.
Jan 27 2023, 12:05 PM · Unknown Object (Project), Restricted Project

Jan 26 2023

nikolaypanchenko published D142680: [ConstFolding] Modified algorithm of `ConstantFoldConstantImpl` to be iterative for review.
Jan 26 2023, 5:46 PM · Unknown Object (Project), Restricted Project

Jan 23 2023

nikolaypanchenko added inline comments to D142258: [LV] Ignore runtime checks threshold when vectorization is forced.
Jan 23 2023, 10:57 AM · Unknown Object (Project), Restricted Project
nikolaypanchenko updated the diff for D142258: [LV] Ignore runtime checks threshold when vectorization is forced.

Addressed comments

Jan 23 2023, 10:57 AM · Unknown Object (Project), Restricted Project
nikolaypanchenko published D142382: [LV] Test case to show the problem with forced vec and rt-checks. NFC. for review.
Jan 23 2023, 10:52 AM · Unknown Object (Project), Restricted Project

Jan 20 2023

nikolaypanchenko added reviewers for D142258: [LV] Ignore runtime checks threshold when vectorization is forced: ABataev, fhahn, rui.zhang.
Jan 20 2023, 2:55 PM · Unknown Object (Project), Restricted Project
nikolaypanchenko requested review of D142258: [LV] Ignore runtime checks threshold when vectorization is forced.
Jan 20 2023, 2:53 PM · Unknown Object (Project), Restricted Project