[clang] Fix crash on attempt to initialize union with flexible array member

[Fznamznon]

Summary

Due to missing check on union, there was a null expression
added to init list that caused crash later.

Fixes https://github.com/llvm/llvm-project/issues/61746

[aaron.ballman]

The precommit CI failures seem unrelated to these changes.

clang/test/Sema/init.c

168–169

I think we might want to move this to its own test file so we can test the various edge cases. I'd like to see a RUN line that tests explicitly in -fms-compatibility mode to demonstrate that we do not issue this diagnostic, and RUN lines for C++ mode as well.

[Fznamznon]

Move the test to a separate file, test C++ and MSVC compatibility mode

[shafik]

LGTM after addressing Aaron's comment

[Fznamznon]

@aaron.ballman , WDYT?

[aaron.ballman]

LGTM with a minor tweak to the test, thanks!

clang/test/Sema/flexible-array-in-union.c

1–16 ↗

(On Diff #523723)

Slight tweak to get rid of the preprocessor stuff and simplify the test a bit; NFC.

[Fznamznon]

clang/test/Sema/flexible-array-in-union.c

1–16 ↗

(On Diff #523723)

Neat! Thank you.

clang/docs/ReleaseNotes.rst

 - A default argument for a non-type template parameter is evaluated and checked
   at the point where it is required. This fixes:
   (`#62224 <https://github.com/llvm/llvm-project/issues/62224>`_) and
   (`#62596 <https://github.com/llvm/llvm-project/issues/62596>`_)
 - Fix an assertion when instantiating the body of a Class Template Specialization
   when it had been instantiated from a partial template specialization with different
   template arguments on the containing class. This fixes:
   (`#60778 <https://github.com/llvm/llvm-project/issues/60778>`_).
+- Fix crash on attempt to initialize union with flexible array member.
+  (`#61746 <https://github.com/llvm/llvm-project/issues/61746>`_).
 
 Bug Fixes to Compiler Builtins
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 Bug Fixes to Attribute Support
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 - Fixed a bug where attribute annotations on type specifiers (enums, classes,
   structs, unions, and scoped enums) were not properly ignored, resulting in

clang/lib/Sema/SemaInit.cpp

else if (RDecl->isUnion() && isa<CXXRecordDecl>(RDecl) &&
           break;
         }
       }
     } else {
       // The fields beyond ILE->getNumInits() are default initialized, so in
       // order to leave them uninitialized, the ILE is expanded and the extra
       // fields are then filled with NoInitExpr.
       unsigned NumElems = numStructUnionElements(ILE->getType());
-      if (RDecl->hasFlexibleArrayMember())
+      if (!RDecl->isUnion() && RDecl->hasFlexibleArrayMember())
         ++NumElems;
       if (!VerifyOnly && ILE->getNumInits() < NumElems)
         ILE->resizeInits(SemaRef.Context, NumElems);
 
       unsigned Init = 0;
 
       if (auto *CXXRD = dyn_cast<CXXRecordDecl>(RDecl)) {
         for (auto &Base : CXXRD->bases()) {

clang/test/Sema/init.c

 
 // <rdar://problem/10185490> (derived from SPEC vortex benchmark)
 typedef char strty[10];
 struct vortexstruct { strty s; };
 struct vortexstruct vortexvar = { "asdf" };
 
 typedef struct { uintptr_t x : 2; } StructWithBitfield;
 StructWithBitfield bitfieldvar = { (uintptr_t)&bitfieldvar }; // expected-error {{initializer element is not a compile-time constant}}
+
+// GH61746
+union { char x[]; } r = {0}; // expected-error {{flexible array member 'x' in a union is not allowed}}