Page MenuHomePhabricator

Fznamznon (Mariya Podchishchaeva)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 18 2017, 12:01 AM (274 w, 6 d)

Recent Activity

Fri, Mar 24

Fznamznon added inline comments to D146801: [clang] Fix consteval initializers of temporaries.
Fri, Mar 24, 7:13 AM · Restricted Project, Restricted Project
Fznamznon updated the diff for D146801: [clang] Fix consteval initializers of temporaries.

Apply the suggestion

Fri, Mar 24, 7:12 AM · Restricted Project, Restricted Project
Fznamznon added reviewers for D146801: [clang] Fix consteval initializers of temporaries: aaron.ballman, rsmith.
Fri, Mar 24, 4:05 AM · Restricted Project, Restricted Project
Fznamznon requested review of D146801: [clang] Fix consteval initializers of temporaries.
Fri, Mar 24, 4:03 AM · Restricted Project, Restricted Project
Fznamznon added a reviewer for D146412: [NFC] Fix potential use-after-free in DumpModuleInfoAction::ExecuteAction(): schittir.
Fri, Mar 24, 2:58 AM · Restricted Project, Restricted Project

Thu, Mar 23

Fznamznon added inline comments to D146234: [clang] Fix crash when handling nested immediate invocations.
Thu, Mar 23, 9:47 AM · Restricted Project, Restricted Project
Fznamznon added a comment to D146234: [clang] Fix crash when handling nested immediate invocations.

Ping?

Thu, Mar 23, 3:45 AM · Restricted Project, Restricted Project

Mon, Mar 20

Fznamznon added reviewers for D146412: [NFC] Fix potential use-after-free in DumpModuleInfoAction::ExecuteAction(): shafik, tahonermann, kastiglione.
Mon, Mar 20, 4:10 AM · Restricted Project, Restricted Project
Fznamznon requested review of D146412: [NFC] Fix potential use-after-free in DumpModuleInfoAction::ExecuteAction().
Mon, Mar 20, 4:09 AM · Restricted Project, Restricted Project

Thu, Mar 16

Fznamznon added inline comments to D146234: [clang] Fix crash when handling nested immediate invocations.
Thu, Mar 16, 12:36 PM · Restricted Project, Restricted Project
Fznamznon added reviewers for D146234: [clang] Fix crash when handling nested immediate invocations: aaron.ballman, shafik, royjacobson, cor3ntin, ilya-biryukov, usaxena95.
Thu, Mar 16, 9:36 AM · Restricted Project, Restricted Project
Fznamznon requested review of D146234: [clang] Fix crash when handling nested immediate invocations.
Thu, Mar 16, 9:34 AM · Restricted Project, Restricted Project

Tue, Mar 7

Fznamznon committed rGa2739f111d97: [clang] Treat function parameter scope as an immediate function context (authored by Fznamznon).
[clang] Treat function parameter scope as an immediate function context
Tue, Mar 7, 8:51 AM · Restricted Project, Restricted Project
Fznamznon closed D145251: [clang] Treat function parameter scope as an immediate function context.
Tue, Mar 7, 8:51 AM · Restricted Project, Restricted Project
Fznamznon committed rGd0db54e0dd32: [clang] Update test according to P1937 (authored by Fznamznon).
[clang] Update test according to P1937
Tue, Mar 7, 8:32 AM · Restricted Project, Restricted Project
Fznamznon closed D145362: [clang] Update test according to P1937.
Tue, Mar 7, 8:32 AM · Restricted Project, Restricted Project
Fznamznon added a comment to D145486: [clang] Fix single-element array initialization in constexpr.

Filed https://github.com/llvm/llvm-project/issues/61243 to backport.

Tue, Mar 7, 8:12 AM · Restricted Project, Restricted Project
Fznamznon committed rGaf682f0df83f: [clang] Fix single-element array initialization in constexpr (authored by Fznamznon).
[clang] Fix single-element array initialization in constexpr
Tue, Mar 7, 8:06 AM · Restricted Project, Restricted Project
Fznamznon closed D145486: [clang] Fix single-element array initialization in constexpr.
Tue, Mar 7, 8:05 AM · Restricted Project, Restricted Project
Fznamznon updated the diff for D145486: [clang] Fix single-element array initialization in constexpr.

Rebase and update test comment.

Tue, Mar 7, 6:13 AM · Restricted Project, Restricted Project
Fznamznon updated the diff for D145486: [clang] Fix single-element array initialization in constexpr.

Check FinalSize instead of N since it is probably more obvious

Tue, Mar 7, 4:50 AM · Restricted Project, Restricted Project
Fznamznon added reviewers for D145486: [clang] Fix single-element array initialization in constexpr: aaron.ballman, tbaeder.
Tue, Mar 7, 4:12 AM · Restricted Project, Restricted Project
Fznamznon requested review of D145486: [clang] Fix single-element array initialization in constexpr.
Tue, Mar 7, 4:11 AM · Restricted Project, Restricted Project

Mon, Mar 6

Fznamznon updated the diff for D145251: [clang] Treat function parameter scope as an immediate function context.

Rebase and add quoting [expr.const] p15.1

Mon, Mar 6, 12:20 PM · Restricted Project, Restricted Project
Fznamznon added inline comments to D145362: [clang] Update test according to P1937.
Mon, Mar 6, 11:33 AM · Restricted Project, Restricted Project
Fznamznon updated the diff for D145362: [clang] Update test according to P1937.

Rebase and apply the nitpick

Mon, Mar 6, 11:32 AM · Restricted Project, Restricted Project
Fznamznon added reviewers for D145362: [clang] Update test according to P1937: aaron.ballman, erichkeane, shafik, cor3ntin.
Mon, Mar 6, 1:55 AM · Restricted Project, Restricted Project
Fznamznon requested review of D145362: [clang] Update test according to P1937.
Mon, Mar 6, 1:54 AM · Restricted Project, Restricted Project
Fznamznon committed rG2fbf18b40026: [clang] Fix aggregate initialization inside lambda constexpr (authored by Fznamznon).
[clang] Fix aggregate initialization inside lambda constexpr
Mon, Mar 6, 12:43 AM · Restricted Project, Restricted Project
Fznamznon closed D144866: [clang] Fix aggregate initialization inside lambda constexpr.
Mon, Mar 6, 12:43 AM · Restricted Project, Restricted Project

Fri, Mar 3

Fznamznon added reviewers for D145251: [clang] Treat function parameter scope as an immediate function context: aaron.ballman, erichkeane, shafik, cor3ntin.
Fri, Mar 3, 9:02 AM · Restricted Project, Restricted Project
Fznamznon requested review of D145251: [clang] Treat function parameter scope as an immediate function context.
Fri, Mar 3, 8:59 AM · Restricted Project, Restricted Project
Fznamznon committed rG6121190b8ccc: [NFC] Refine tests by adding `:` to checks (authored by Fznamznon).
[NFC] Refine tests by adding `:` to checks
Fri, Mar 3, 2:24 AM · Restricted Project, Restricted Project
Fznamznon closed D144562: [NFC] Refine tests by adding `:` to checks.
Fri, Mar 3, 2:24 AM · Restricted Project, Restricted Project

Wed, Mar 1

Fznamznon added a comment to D144562: [NFC] Refine tests by adding `:` to checks.

I'm fine with the patch, but it's a shame the solution isn't more robust.

Wed, Mar 1, 3:12 AM · Restricted Project, Restricted Project
Fznamznon added a comment to D144562: [NFC] Refine tests by adding `:` to checks.

LGTM, but best leave it a bit in case others have comments.

Wed, Mar 1, 3:11 AM · Restricted Project, Restricted Project
Fznamznon committed rG831591b2a075: [NFC][clang] Refine tests by adding `:` to checks (authored by Fznamznon).
[NFC][clang] Refine tests by adding `:` to checks
Wed, Mar 1, 3:10 AM · Restricted Project, Restricted Project
Fznamznon closed D144495: [NFC][clang] Refine tests by adding `:` to checks.
Wed, Mar 1, 3:10 AM · Restricted Project, Restricted Project
Fznamznon added a comment to D144866: [clang] Fix aggregate initialization inside lambda constexpr.

Thanks for the review @shafik .

Wed, Mar 1, 2:53 AM · Restricted Project, Restricted Project

Tue, Feb 28

Fznamznon added inline comments to D144866: [clang] Fix aggregate initialization inside lambda constexpr.
Tue, Feb 28, 6:54 AM · Restricted Project, Restricted Project
Fznamznon updated the diff for D144866: [clang] Fix aggregate initialization inside lambda constexpr.

Apply suggestions and rebase.

Tue, Feb 28, 4:15 AM · Restricted Project, Restricted Project

Mon, Feb 27

Fznamznon added reviewers for D144866: [clang] Fix aggregate initialization inside lambda constexpr: aaron.ballman, erichkeane, shafik.
Mon, Feb 27, 5:48 AM · Restricted Project, Restricted Project
Fznamznon requested review of D144866: [clang] Fix aggregate initialization inside lambda constexpr.
Mon, Feb 27, 5:47 AM · Restricted Project, Restricted Project

Feb 22 2023

Fznamznon added inline comments to D144562: [NFC] Refine tests by adding `:` to checks.
Feb 22 2023, 7:39 AM · Restricted Project, Restricted Project
Fznamznon updated the summary of D144562: [NFC] Refine tests by adding `:` to checks.
Feb 22 2023, 6:54 AM · Restricted Project, Restricted Project
Fznamznon requested review of D144562: [NFC] Refine tests by adding `:` to checks.
Feb 22 2023, 6:48 AM · Restricted Project, Restricted Project

Feb 21 2023

Fznamznon added reviewers for D144495: [NFC][clang] Refine tests by adding `:` to checks: MaskRay, benlangmuir, aaron.ballman.
Feb 21 2023, 8:10 AM · Restricted Project, Restricted Project
Fznamznon requested review of D144495: [NFC][clang] Refine tests by adding `:` to checks.
Feb 21 2023, 8:04 AM · Restricted Project, Restricted Project
Fznamznon committed rG440f45acff1c: [NFC][clang][Modules] Refine test checks by adding `:` (authored by Fznamznon).
[NFC][clang][Modules] Refine test checks by adding `:`
Feb 21 2023, 7:18 AM · Restricted Project, Restricted Project
Fznamznon closed D143734: [NFC][clang][Modules] Refine test checks by adding `:`.
Feb 21 2023, 7:18 AM · Restricted Project, Restricted Project

Feb 10 2023

Fznamznon requested review of D143734: [NFC][clang][Modules] Refine test checks by adding `:`.
Feb 10 2023, 6:20 AM · Restricted Project, Restricted Project

Feb 9 2023

Fznamznon committed rG2929683eef27: [clang][codegen] Fix emission of consteval constructor of derived type (authored by Fznamznon).
[clang][codegen] Fix emission of consteval constructor of derived type
Feb 9 2023, 1:54 AM · Restricted Project, Restricted Project
Fznamznon closed D142534: [clang][codegen] Fix emission of consteval constructor of derived type.
Feb 9 2023, 1:54 AM · Restricted Project, Restricted Project

Feb 8 2023

Fznamznon updated the diff for D142534: [clang][codegen] Fix emission of consteval constructor of derived type.

Rebase and add a release note

Feb 8 2023, 7:31 AM · Restricted Project, Restricted Project
Fznamznon updated the summary of D142534: [clang][codegen] Fix emission of consteval constructor of derived type.
Feb 8 2023, 4:02 AM · Restricted Project, Restricted Project
Fznamznon added a comment to D142534: [clang][codegen] Fix emission of consteval constructor of derived type.

I discovered that this patch also helps to fix crash reported in https://github.com/llvm/llvm-project/issues/59223 .

Feb 8 2023, 4:01 AM · Restricted Project, Restricted Project
Fznamznon added a comment to D142534: [clang][codegen] Fix emission of consteval constructor of derived type.

Ping.

Feb 8 2023, 3:59 AM · Restricted Project, Restricted Project
Fznamznon retitled D142534: [clang][codegen] Fix emission of consteval constructor of derived type from Fix emission of consteval constructor of derived type to [clang][codegen] Fix emission of consteval constructor of derived type.
Feb 8 2023, 3:59 AM · Restricted Project, Restricted Project

Feb 7 2023

Fznamznon committed rG8681797e595d: [NFC][clang] Fix static analyzer concern about uninitialized variable (authored by Fznamznon).
[NFC][clang] Fix static analyzer concern about uninitialized variable
Feb 7 2023, 1:43 AM · Restricted Project, Restricted Project
Fznamznon closed D143411: [NFC][clang] Fix static analyzer concern about uninitialized variable.
Feb 7 2023, 1:42 AM · Restricted Project, Restricted Project

Feb 6 2023

Fznamznon requested review of D143411: [NFC][clang] Fix static analyzer concern about uninitialized variable.
Feb 6 2023, 8:35 AM · Restricted Project, Restricted Project
Fznamznon abandoned D143072: [NFC][clang] Fix static code analyzer complains.
Feb 6 2023, 6:50 AM · Restricted Project, Restricted Project

Feb 2 2023

Fznamznon added a comment to D142757: [clang][driver] Emit an error for `/clang:-x`.

Should be fixed by https://github.com/llvm/llvm-project/commit/108fa70cd213e63a591adb87ce444fb74afc6786 .

Feb 2 2023, 10:47 AM · Restricted Project, Restricted Project
Fznamznon committed rG108fa70cd213: [clang][driver] Fix test fail on Mac after fe082124 (authored by Fznamznon).
[clang][driver] Fix test fail on Mac after fe082124
Feb 2 2023, 10:47 AM · Restricted Project, Restricted Project
Fznamznon added a comment to D142757: [clang][driver] Emit an error for `/clang:-x`.

This breaks tests on Mac: http://45.33.8.238/macm1/54097/step_7.txt

Please take a look and revert for now if it takes a while to fix.

Feb 2 2023, 10:29 AM · Restricted Project, Restricted Project
Fznamznon committed rGfe082124faa8: [clang][driver] Emit an error for `/clang:-x` (authored by Fznamznon).
[clang][driver] Emit an error for `/clang:-x`
Feb 2 2023, 8:54 AM · Restricted Project, Restricted Project
Fznamznon closed D142757: [clang][driver] Emit an error for `/clang:-x`.
Feb 2 2023, 8:54 AM · Restricted Project, Restricted Project
Fznamznon added inline comments to D142757: [clang][driver] Emit an error for `/clang:-x`.
Feb 2 2023, 2:39 AM · Restricted Project, Restricted Project
Fznamznon updated the diff for D142757: [clang][driver] Emit an error for `/clang:-x`.

Fix incorrect conflict resolution

Feb 2 2023, 2:37 AM · Restricted Project, Restricted Project
Fznamznon updated the diff for D142757: [clang][driver] Emit an error for `/clang:-x`.

Apply suggestion and rebase

Feb 2 2023, 2:34 AM · Restricted Project, Restricted Project
Fznamznon added a comment to D142534: [clang][codegen] Fix emission of consteval constructor of derived type.

Ping?

Feb 2 2023, 1:23 AM · Restricted Project, Restricted Project

Feb 1 2023

Fznamznon added reviewers for D143072: [NFC][clang] Fix static code analyzer complains: EricWF, rjmccall.
Feb 1 2023, 8:19 AM · Restricted Project, Restricted Project
Fznamznon requested review of D143072: [NFC][clang] Fix static code analyzer complains.
Feb 1 2023, 7:33 AM · Restricted Project, Restricted Project
Fznamznon added inline comments to D142757: [clang][driver] Emit an error for `/clang:-x`.
Feb 1 2023, 2:06 AM · Restricted Project, Restricted Project

Jan 31 2023

Fznamznon added inline comments to D142757: [clang][driver] Emit an error for `/clang:-x`.
Jan 31 2023, 10:22 AM · Restricted Project, Restricted Project
Fznamznon added a comment to D142757: [clang][driver] Emit an error for `/clang:-x`.

@MaskRay , thanks for the suggestions. Applied. Please let me know that it is ok now.

Jan 31 2023, 7:24 AM · Restricted Project, Restricted Project
Fznamznon added inline comments to D142757: [clang][driver] Emit an error for `/clang:-x`.
Jan 31 2023, 7:22 AM · Restricted Project, Restricted Project
Fznamznon added inline comments to D142757: [clang][driver] Emit an error for `/clang:-x`.
Jan 31 2023, 5:41 AM · Restricted Project, Restricted Project
Fznamznon updated the summary of D142757: [clang][driver] Emit an error for `/clang:-x`.
Jan 31 2023, 5:39 AM · Restricted Project, Restricted Project
Fznamznon updated the diff for D142757: [clang][driver] Emit an error for `/clang:-x`.

Apply suggestions

Jan 31 2023, 5:37 AM · Restricted Project, Restricted Project

Jan 30 2023

Fznamznon updated the diff for D142757: [clang][driver] Emit an error for `/clang:-x`.

Add a release note.

Jan 30 2023, 8:47 AM · Restricted Project, Restricted Project
Fznamznon added inline comments to D142757: [clang][driver] Emit an error for `/clang:-x`.
Jan 30 2023, 2:51 AM · Restricted Project, Restricted Project
Fznamznon retitled D142757: [clang][driver] Emit an error for `/clang:-x` from [clang][driver] Do not warn about position of `/clang:-xc` in cl mode to [clang][driver] Emit an error for `/clang:-x`.
Jan 30 2023, 2:41 AM · Restricted Project, Restricted Project
Fznamznon updated the diff for D142757: [clang][driver] Emit an error for `/clang:-x`.

Emit an error if /clang:-x passed.

Jan 30 2023, 2:40 AM · Restricted Project, Restricted Project

Jan 27 2023

Fznamznon added reviewers for D142757: [clang][driver] Emit an error for `/clang:-x`: MaskRay, aaron.ballman, kongyi.
Jan 27 2023, 9:39 AM · Restricted Project, Restricted Project
Fznamznon requested review of D142757: [clang][driver] Emit an error for `/clang:-x`.
Jan 27 2023, 9:35 AM · Restricted Project, Restricted Project

Jan 26 2023

Fznamznon updated the diff for D142534: [clang][codegen] Fix emission of consteval constructor of derived type.

Rebase and apply nit

Jan 26 2023, 9:23 AM · Restricted Project, Restricted Project
Fznamznon committed rGd4f4b2fe21dd: [clang] Fix sizeof of boolean vector (authored by Fznamznon).
[clang] Fix sizeof of boolean vector
Jan 26 2023, 7:59 AM · Restricted Project, Restricted Project
Fznamznon closed D142550: Fix sizeof of boolean vector.
Jan 26 2023, 7:58 AM · Restricted Project, Restricted Project
Fznamznon added inline comments to D142550: Fix sizeof of boolean vector.
Jan 26 2023, 2:01 AM · Restricted Project, Restricted Project
Fznamznon updated the diff for D142550: Fix sizeof of boolean vector.

Add more sizes to test

Jan 26 2023, 2:00 AM · Restricted Project, Restricted Project

Jan 25 2023

Fznamznon added inline comments to D142550: Fix sizeof of boolean vector.
Jan 25 2023, 9:25 AM · Restricted Project, Restricted Project
Fznamznon updated the diff for D142550: Fix sizeof of boolean vector.

Add a case with vector of length 33

Jan 25 2023, 9:23 AM · Restricted Project, Restricted Project
Fznamznon added inline comments to D142550: Fix sizeof of boolean vector.
Jan 25 2023, 8:24 AM · Restricted Project, Restricted Project
Fznamznon updated the diff for D142550: Fix sizeof of boolean vector.

Adjust the test

Jan 25 2023, 8:23 AM · Restricted Project, Restricted Project
Fznamznon added inline comments to D142550: Fix sizeof of boolean vector.
Jan 25 2023, 8:09 AM · Restricted Project, Restricted Project
Fznamznon added inline comments to D142550: Fix sizeof of boolean vector.
Jan 25 2023, 8:07 AM · Restricted Project, Restricted Project
Fznamznon added reviewers for D142550: Fix sizeof of boolean vector: erichkeane, simoll, aaron.ballman.
Jan 25 2023, 8:05 AM · Restricted Project, Restricted Project
Fznamznon requested review of D142550: Fix sizeof of boolean vector.
Jan 25 2023, 8:04 AM · Restricted Project, Restricted Project
Fznamznon added a comment to D142534: [clang][codegen] Fix emission of consteval constructor of derived type.

I think having a link to the github issue in the summary allows for the issue be closed automatically when you commit. Is this correct @aaron.ballman I have been doing this for a while and they get closed when I commit but maybe there is another mechanism involved.

Jan 25 2023, 8:01 AM · Restricted Project, Restricted Project