This is an archive of the discontinued LLVM Phabricator instance.

Differential D149334

[RISCV] Enable strict fp for RISC-V in clang.
ClosedPublic

Authored by fakepaper56 on Apr 27 2023, 5:14 AM.

Details

Reviewers
craig.topper
reames
frasercrmck
rogfer01
asb
Commits
rGfa53ce0faaa0: [RISCV] Enable strict fp for RISC-V in clang.

Diff Detail

Event Timeline

fakepaper56 created this revision.Apr 27 2023, 5:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2023, 5:14 AM
Herald added subscribers: jobnoorman, luke, VincentWu and 26 others. · View Herald Transcript
fakepaper56 requested review of this revision.Apr 27 2023, 5:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2023, 5:14 AM
Herald added subscribers: cfe-commits, • pcwang-thead, eopXD, MaskRay. · View Herald Transcript
Harbormaster completed remote builds in B228526: Diff 517515.Apr 27 2023, 6:32 AM
craig.topper added a reviewer: asb.Apr 27 2023, 10:39 PM
craig.topper accepted this revision.May 1 2023, 9:35 PM

LGTM

This revision is now accepted and ready to land.May 1 2023, 9:35 PM
Closed by commit rGfa53ce0faaa0: [RISCV] Enable strict fp for RISC-V in clang. (authored by fakepaper56). · Explain WhyMay 2 2023, 5:32 PM
This revision was automatically updated to reflect the committed changes.
fakepaper56 added a commit: rGfa53ce0faaa0: [RISCV] Enable strict fp for RISC-V in clang..

Revision Contents

PathSize
clang/
lib/
Basic/
Targets/
1 line
test/
CodeGen/
RISCV/
27 lines

Diff 517515

clang/lib/Basic/Targets/RISCV.h

Show All 35 Lines RISCVTargetInfo(const llvm::Triple &Triple, const TargetOptions &)
LongDoubleAlign = 128; LongDoubleAlign = 128;
LongDoubleFormat = &llvm::APFloat::IEEEquad(); LongDoubleFormat = &llvm::APFloat::IEEEquad();
SuitableAlign = 128; SuitableAlign = 128;
WCharType = SignedInt; WCharType = SignedInt;
WIntType = UnsignedInt; WIntType = UnsignedInt;
HasRISCVVTypes = true; HasRISCVVTypes = true;
MCountName = "_mcount"; MCountName = "_mcount";
HasFloat16 = true; HasFloat16 = true;
HasStrictFP = true;
} }
bool setCPU(const std::string &Name) override { bool setCPU(const std::string &Name) override {
if (!isValidCPUName(Name)) if (!isValidCPUName(Name))
return false; return false;
CPU = Name; CPU = Name;
return true; return true;
} }
▲ Show 20 Lines • Show All 113 Lines • Show Last 20 Lines

clang/test/CodeGen/RISCV/fpconstrained.c

  • This file was added.
// RUN: %clang_cc1 -triple riscv64 -frounding-math -ffp-exception-behavior=strict -fexperimental-strict-floating-point -emit-llvm -o - %s | FileCheck %s -check-prefix=FPMODELSTRICT
// RUN: %clang_cc1 -triple riscv64 -ffp-contract=fast -emit-llvm -o - %s | FileCheck %s -check-prefix=PRECISE
// RUN: %clang_cc1 -triple riscv64 -ffast-math -ffp-contract=fast -emit-llvm -o - %s | FileCheck %s -check-prefix=FAST
// RUN: %clang_cc1 -triple riscv64 -ffast-math -emit-llvm -o - %s | FileCheck %s -check-prefix=FASTNOCONTRACT
// RUN: %clang_cc1 -triple riscv64 -ffast-math -ffp-contract=fast -ffp-exception-behavior=ignore -emit-llvm -o - %s | FileCheck %s -check-prefix=FAST
// RUN: %clang_cc1 -triple riscv64 -ffast-math -ffp-contract=fast -ffp-exception-behavior=strict -fexperimental-strict-floating-point -emit-llvm -o - %s | FileCheck %s -check-prefix=EXCEPT
// RUN: %clang_cc1 -triple riscv64 -ffast-math -ffp-contract=fast -ffp-exception-behavior=maytrap -fexperimental-strict-floating-point -emit-llvm -o - %s | FileCheck %s -check-prefix=MAYTRAP
// Test strict-fp support in RISC-V.
float f0, f1, f2;
void foo(void) {
// CHECK-LABEL: define {{.*}}void @foo()
// MAYTRAP: llvm.experimental.constrained.fadd.f32(float %{{.*}}, float %{{.*}}, metadata !"round.tonearest", metadata !"fpexcept.maytrap")
// EXCEPT: llvm.experimental.constrained.fadd.f32(float %{{.*}}, float %{{.*}}, metadata !"round.tonearest", metadata !"fpexcept.strict")
// FPMODELSTRICT: llvm.experimental.constrained.fadd.f32(float %{{.*}}, float %{{.*}}, metadata !"round.dynamic", metadata !"fpexcept.strict")
// STRICTEXCEPT: llvm.experimental.constrained.fadd.f32(float %{{.*}}, float %{{.*}}, metadata !"round.dynamic", metadata !"fpexcept.strict")
// STRICTNOEXCEPT: llvm.experimental.constrained.fadd.f32(float %{{.*}}, float %{{.*}}, metadata !"round.dynamic", metadata !"fpexcept.ignore")
// PRECISE: fadd contract float %{{.*}}, %{{.*}}
// FAST: fadd fast
// FASTNOCONTRACT: fadd reassoc nnan ninf nsz arcp afn float
f0 = f1 + f2;
// CHECK: ret
}