This is an archive of the discontinued LLVM Phabricator instance.

Differential D146945

Add Release Note for -mcode-object-v3 removal
ClosedPublic

Authored by Pierre-vh on Mar 27 2023, 4:27 AM.

Details

Reviewers
aaron.ballman
Group Reviewers
Restricted Project
Commits
rG4559e8e8cd99: Add Release Note for -mcode-object-v3 removal

Diff Detail

Event Timeline

Pierre-vh created this revision.Mar 27 2023, 4:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 27 2023, 4:27 AM
Pierre-vh requested review of this revision.Mar 27 2023, 4:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 27 2023, 4:27 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Pierre-vh mentioned this in D145671: [clang] Remove legacy -m(no)-code-object-v3 options.Mar 27 2023, 4:28 AM
aaron.ballman accepted this revision.Mar 27 2023, 4:29 AM
aaron.ballman added a reviewer: Restricted Project.

LGTM! Adding the clang-vendors group for awareness since this technically could break some downstream (I don't expect it to given that this was deprecated, but you never know).

This revision is now accepted and ready to land.Mar 27 2023, 4:29 AM
Pierre-vh added a comment.Mar 27 2023, 4:35 AM
In D146945#4223677, @aaron.ballman wrote:

LGTM! Adding the clang-vendors group for awareness since this technically could break some downstream (I don't expect it to given that this was deprecated, but you never know).

Can it land or should I wait for someone from that group to comment first?
Thanks

aaron.ballman added a comment.Mar 27 2023, 4:39 AM
In D146945#4223702, @Pierre-vh wrote:
In D146945#4223677, @aaron.ballman wrote:

LGTM! Adding the clang-vendors group for awareness since this technically could break some downstream (I don't expect it to given that this was deprecated, but you never know).

Can it land or should I wait for someone from that group to comment first?
Thanks

Sorry for adding confusion. :-) Feel free to land it -- if someone from clang-vendors has concerns, they can raise them here.

This revision was landed with ongoing or failed builds.Mar 27 2023, 4:41 AM
Closed by commit rG4559e8e8cd99: Add Release Note for -mcode-object-v3 removal (authored by Pierre-vh). · Explain Why
This revision was automatically updated to reflect the committed changes.
Pierre-vh added a commit: rG4559e8e8cd99: Add Release Note for -mcode-object-v3 removal.
Harbormaster completed remote builds in B221949: Diff 508571.Mar 27 2023, 8:11 PM

Revision Contents

PathSize
clang/
docs/
2 lines

Diff 508575

clang/docs/ReleaseNotes.rst

Show First 20 Lines • Show All 273 Lines • ▼ Show 20 Lines
AMDGPU Support AMDGPU Support
^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^
- Linking for AMDGPU now uses ``--no-undefined`` by default. This causes - Linking for AMDGPU now uses ``--no-undefined`` by default. This causes
undefined symbols in the created module to be a linker error. To prevent this, undefined symbols in the created module to be a linker error. To prevent this,
pass ``-Wl,--undefined`` if compiling directly, or ``-Xoffload-linker pass ``-Wl,--undefined`` if compiling directly, or ``-Xoffload-linker
--undefined`` if using an offloading language. --undefined`` if using an offloading language.
- The deprecated ``-mcode-object-v3`` and ``-mno-code-object-v3`` command-line
options have been removed.
X86 Support X86 Support
^^^^^^^^^^^ ^^^^^^^^^^^
Arm and AArch64 Support Arm and AArch64 Support
^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^
- The hard-float ABI is now available in Armv8.1-M configurations that - The hard-float ABI is now available in Armv8.1-M configurations that
▲ Show 20 Lines • Show All 119 Lines • Show Last 20 Lines