This is an archive of the discontinued LLVM Phabricator instance.

Add Release Note for -mcode-object-v3 removal
ClosedPublic

Authored by Pierre-vh on Mar 27 2023, 4:27 AM.

Details

Reviewers
aaron.ballman
Group Reviewers
Restricted Project
Commits
rG4559e8e8cd99: Add Release Note for -mcode-object-v3 removal

Diff Detail

Event Timeline

Pierre-vh created this revision.Mar 27 2023, 4:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 27 2023, 4:27 AM
Pierre-vh requested review of this revision.Mar 27 2023, 4:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 27 2023, 4:27 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
aaron.ballman accepted this revision.Mar 27 2023, 4:29 AM
aaron.ballman added a reviewer: Restricted Project.

LGTM! Adding the clang-vendors group for awareness since this technically could break some downstream (I don't expect it to given that this was deprecated, but you never know).

This revision is now accepted and ready to land.Mar 27 2023, 4:29 AM

LGTM! Adding the clang-vendors group for awareness since this technically could break some downstream (I don't expect it to given that this was deprecated, but you never know).

Can it land or should I wait for someone from that group to comment first?
Thanks

LGTM! Adding the clang-vendors group for awareness since this technically could break some downstream (I don't expect it to given that this was deprecated, but you never know).

Can it land or should I wait for someone from that group to comment first?
Thanks

Sorry for adding confusion. :-) Feel free to land it -- if someone from clang-vendors has concerns, they can raise them here.

This revision was landed with ongoing or failed builds.Mar 27 2023, 4:41 AM
This revision was automatically updated to reflect the committed changes.