This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Replace RISCV->RISC-V in strings.
ClosedPublic

Authored by craig.topper on Mar 20 2023, 12:35 PM.

Details

Summary

To be consistent with RISC-V branding guidelines
https://riscv.org/about/risc-v-branding-guidelines/
Think we should be using RISC-V where possible.

D146449 already updated comments. Strings may have more user impact.

Diff Detail

Event Timeline

craig.topper created this revision.Mar 20 2023, 12:35 PM
craig.topper requested review of this revision.Mar 20 2023, 12:35 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 20 2023, 12:35 PM
asb added a comment.Mar 20 2023, 12:48 PM

The logic I saw with the pass names is that the backend for the RISC-V architecture is called "RISCV". But I've got no objection to changing.

The logic I saw with the pass names is that the backend for the RISC-V architecture is called "RISCV". But I've got no objection to changing.

Yeah. I also wasn't sure which is best.

asb accepted this revision.Mar 27 2023, 1:38 AM

Not as compelling as user facing strings or comments that clearly refer to the RISC-V ISA rather than the "RISCV" LLVM backend. But I don't really see a good reason not to be consistent. LGTM.

This revision is now accepted and ready to land.Mar 27 2023, 1:38 AM
This revision was landed with ongoing or failed builds.Mar 27 2023, 9:51 AM
This revision was automatically updated to reflect the committed changes.